Re: [Libreoffice] Suggestion needed for External Edit functionality.
Hi Thorsten, Mon, Nov 15, 2010 at 5:40 PM, Thorsten Behrens wrote: > surensp...@gmail.com wrote: >> 1) Making it work in all OS/platforms: >> [...] >> > Hi Suren, > > wow, great progress! For the editing, one easy way out would be to > use the SystemShellExecute service, which will pick an app > registered for the file type at hand. You can e.g. find a usage > example in sfx2/source/dialog/about.cxx:298 > Thanks for the encouraging words :) I spent quite some time trying to find out how XSystemShellExecute works (ie) how it gets an application mapped to a specific mime-type, so that I can use it in my logic. I was in fact done creating a new interface to get that logic re-factored. But I realised was that, XSystemShellExecute is only internally calling "gnome-open-url $filepath" ( which is a shell script which does a xdg-open or gnome-open ). And for mac, it does a "open $filePath". This is bad for our purpose because both these functions returns (and not blocks) as soon as the new external application is opened and _not _ wait until they are closed. Here are the few alternatives I can think of : 1) register an event Listener to listen to any change of that temporary file. And update the graphic in the call-back function of that event listener. Remove the event listener after graphic update is done ( Not sure if file based even listeners are available) 2) Give the users an option to choose application ( FIle picker dialog ) and save it in libreoffice's session info (How to save it across multiple sessions ? ) 3) Directly check the availability of certain applications like Photoshop, Gimp , Preview. ( But this is really bad ) To be honest, I didn't anticipate these many issues when I chose to work on it, but I am getting to learn a lot about Libreoffice code base this way. This really is a good beginner bug :) > A smallish nit regarding the move of lcl_GetPreferedExtension to a > header - better rename it GetPreferedExtension, remove the static, > have the declaration in the header - but keep the code inside a cxx. > This is Done :) >> 3) Window repaint issue: >> [...] >> > A rather blunt method is to call SwWrtShell::InvalidateWindows(), > that basically forces a repaint of the given rectangular area. Would > have to dig a bit for the Writer method du jour for this case, maybe > the code from grfsh.cxx above has the right call already, e.g. > UpdateFlyFrm() or somesuch. there is a ReRead method for a SwWrtShell which worked well for this case. ( Used once in grfsh.hxx) > > Keep going, this starts to look *really* nice! :) > > Cheers, > > -- Thorsten Thanks again. I really appreciate your help in giving me a lots of current usages (to an extent of line numbers in specific files to look for ). -- regards Suren Learning < Doing Learn By doing. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Greasemonkey script for bugzilla page
Hi, I have made the greasemonkey script required in the easy hacks page. Please set this bug status to be NEEDINFO - https://bugs.freedesktop.org/show_bug.cgi?id=31853, so that I can improve the greasemonkey and resend it ! -- regards Suren Learning < Doing Learn By doing. highlight.user.js Description: JavaScript source ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Suggestion needed for External Edit functionality.
Hi everyone, After few sleepless nights spent grokking and with quite a big deal help from IRC and the list, have come up with the first cuts working version of the External Edit functionality[1]. Have attached the patches rebased against the latest master. Would love to hear reviews/suggestions/improvements :) PS And I had lots of fun hacking. [1] https://bugs.freedesktop.org/show_bug.cgi?id=30508 On Mon, Nov 22, 2010 at 5:27 PM, Michael Meeks wrote: > -- regards Suren Learning < Doing Learn By doing. edit_external.tar.gz Description: GNU Zip compressed data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Suggestion needed for External Edit functionality.
Hey Thorsten , On Thu, Dec 2, 2010 at 1:05 PM, Thorsten Behrens wrote: > > I had initially intended to reply even earlier, was playing with > your patch yesterday - sadly, there was much preemption. So here's a > little intermezzo - great work so far, stuff looks promising! I understand. There has been too much stuff going on RC release and new build structure coming in. And as always thanks for the support and encouragement :) Very grateful for your looking into my patch in spite of the busy schedule. > I'm pondering moving parts of extedit.cxx to svtools (there's a > handy "misc" directory) - that way, one could reuse that from > Impress and Calc as well. Needs a bit of tweaking here and there > (that's what took more time yesterday than I had available) - e.g. > hide the SwWrtShell in some opaque void pointer. I shall touch base with you on the IRC and will implement all the tweaks as you suggest. If there are any best practices wiki link, please guide me to that :) > There are one or two other things that could benefit from looking > into, e.g. the usage of the worker thread - I think that may not be > needed anymore, with XSystemShellExecute not blocking. > Yes, that might work as well. Should I try this and resend the patch or should I wait for your other suggestions as well ? Also is this the right time to apply for the FOSDEM paper or should I wait some more time for the patch to mature ? -- regards Suren Learning < Doing Learn By doing. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] FOSDEM foo ...
HI Michael, On Thu, Dec 2, 2010 at 5:53 PM, Michael Meeks wrote: > Hi Suren, >e more time for the patch to mature ? > > Wow - it's always the right time to apply for a FOSDEM paper :-) just > whack your name in the wiki, and encourage your friends to come. > > ... > Incidentally; the wiki page is here: > > http://wiki.documentfoundation.org/Marketing/Events/Fosdem2011 > I have made my proposal now :) Hope its alright :) Thanks for the encouraging words :D -- regards Suren Learning < Doing Learn By doing. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] dmake: Error code 1, while making '../unxlngx6.pro/misc/rsc_svt'
I had the exact same error with svtools when I was building as well today. I am building it on Ubuntu 10.10 64 bit version. Any pointers on how to go about fixing it ? Thanks, ~Suren On Tue, Dec 14, 2010 at 2:59 PM, imacat wrote: > Dear all, > > Hi. This is imacat from Taiwan. I tried to build libreoffice on my > Debian Lenny 5.0.6, gcc 4.3.2, GLibC 2.7, by running: > > = > ./autogen.sh --with-git --with-num-cpus=2 > ./download > make > = > > This time it fails at the "svtools" module, complaining an error > while making "rsc_svt": > > = > % make > Making all in po > ... > Entering > /usr/local/src/libreoffice-3.2.99.2-20101213/build/libreoffice-3.2.99.2/svtools/util > > Making: svten-US.res > Compiling: rsc_svt > f268: Error: The image(s) lx03187 lx03190 lx03193 lx03198 lx03201 lx03202 lx03203 lx03204 lx03205 > lx03206 lx03236 lx03237 sx03124 sx03134 sx03142 sx03159 sx03168 sx03198 > sx03203 sx03204 sx03205 sx03206 sx03236 sx03237> could not be found. > Terminating compiler > dmake: Error code 1, while making '../unxlngx6.pro/misc/rsc_svt' > > --- > Oh dear - something failed during the build - sorry ! > For more help with debugging build errors, please see the section in: > http://wiki.documentfoundation.org/Development > > internal build errors: > > ERROR: error 65280 occurred while making > /usr/local/src/libreoffice-3.2.99.2-20101213/build/libreoffice-3.2.99.2/svtools/util > ERROR: error 65280 occurred while making > /usr/local/src/libreoffice-3.2.99.2-20101213/build/libreoffice-3.2.99.2/nss > ERROR: error 65280 occurred while making > /usr/local/src/libreoffice-3.2.99.2-20101213/build/libreoffice-3.2.99.2/libwpd > ERROR: error 65280 occurred while making > /usr/local/src/libreoffice-3.2.99.2-20101213/build/libreoffice-3.2.99.2/more_fonts/fonts/ttf_linlibertineg > > it seems you are using a threaded build, which means that the > actual compile error is probably hidden far above, and could be > inside any of these other modules: > libwpd nss svtools > please re-run build inside each one to isolate the problem. > --- > > /bin/sh > cd /usr/local/src/libreoffice-3.2.99.2-20101213/build/libreoffice-3.2.99.2 > source ./LinuxX86-64Env.Set.sh > cd more_fonts > build > > when the problem is isolated and fixed exit and re-run 'make' from the > top-level > sometimes (sadly) it is necessary to rm -Rf unxlngx6.pro in a module. > make: *** [stamp/build] Error 1 > % > = > > It looks like this thread: > > http://www.mail-archive.com/libreoffice@lists.freedesktop.org/msg02041.html > > But this error did not exist while I was building LibreOffice on > 2010-12-05. Is there any change that reversed the code, or is this a > new problem? Thank you very much in advance. > > -- > Best regards, > imacat ^_*' > PGP Key http://www.imacat.idv.tw/me/pgpkey.asc > > <> News: http://www.wov.idv.tw/ > Tavern IMACAT's http://www.imacat.idv.tw/ > Woman in FOSS in Taiwan http://wofoss.blogspot.com/ > TLUG List Manager http://lists.linux.org.tw/cgi-bin/mailman/listinfo/tlug > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice > -- regards Suren Learning < Doing Learn By doing. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] dmake: Error code 1, while making '../unxlngx6.pro/misc/rsc_svt'
Hi, Yes, A pull and subsequent build worked fine. Thanks for the help :D On Tue, Dec 14, 2010 at 7:44 PM, Kohei Yoshida wrote: > On Tue, 2010-12-14 at 19:42 +0530, surensp...@gmail.com wrote: >> I had the exact same error with svtools when I was building as well >> today. I am building it on Ubuntu 10.10 64 bit version. >> >> Any pointers on how to go about fixing it ? > > I'm pretty sure Michael has already fixed this yesterday. So, please > update your build tree and see if you can go past that. > > Kohei > > -- regards Suren Learning < Doing Learn By doing. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Build issue with cppu
Hi,
I am building LO after some time now. Did the usual ./g pull -r , make
clean and then make. The build was breaking for me at cppu.
'''
build -- version: 275224
=
Building module cppu
=
Entering /home/suren/libreoffice/libo/cppu/inc
Entering /home/suren/libreoffice/libo/cppu/source/LogBridge
Entering /home/suren/libreoffice/libo/cppu/source/typelib
Entering /home/suren/libreoffice/libo/cppu/source/cppu
Entering /home/suren/libreoffice/libo/cppu/source/threadpool
Entering /home/suren/libreoffice/libo/cppu/source/UnsafeBridge
Entering /home/suren/libreoffice/libo/cppu/source/uno
Entering /home/suren/libreoffice/libo/cppu/source/helper/purpenv
Entering /home/suren/libreoffice/libo/cppu/source/AffineBridge
Entering /home/suren/libreoffice/libo/cppu/util
dmake -f extra.mk
Entering /home/suren/libreoffice/libo/cppu/qa
--
- start unit test #1 on library ../unxlngx6.pro/lib/qa_any.so
--
: &&
LD_LIBRARY_PATH=${LD_LIBRARY_PATH+${LD_LIBRARY_PATH}:}/home/suren/libreoffice/libo/clone/ure/cppu/unxlngx6.pro/lib:/home/suren/libreoffice/libo/solver/330/unxlngx6.pro/lib
/home/suren/libreoffice/libo/solver/330/unxlngx6.pro/bin/cppunittester
../unxlngx6.pro/lib/qa_any.so
Forcing regeneration of dependency info
--
- start unit test #1 on library
--
: &&
LD_LIBRARY_PATH=${LD_LIBRARY_PATH+${LD_LIBRARY_PATH}:}/home/suren/libreoffice/libo/clone/ure/cppu/unxlngx6.pro/lib:/home/suren/libreoffice/libo/solver/330/unxlngx6.pro/lib
/home/suren/libreoffice/libo/solver/330/unxlngx6.pro/bin/cppunittester
Retrying /home/suren/libreoffice/libo/cppu/qa
Making:all_qa.dpslo
--
- start unit test #1 on library ../unxlngx6.pro/lib/qa_any.so
--
: &&
LD_LIBRARY_PATH=${LD_LIBRARY_PATH+${LD_LIBRARY_PATH}:}/home/suren/libreoffice/libo/clone/ure/cppu/unxlngx6.pro/lib:/home/suren/libreoffice/libo/solver/330/unxlngx6.pro/lib
/home/suren/libreoffice/libo/solver/330/unxlngx6.pro/bin/cppunittester
../unxlngx6.pro/lib/qa_any.so
---
Oh dear - something failed during the build - sorry !
For more help with debugging build errors, please see the section in:
http://wiki.documentfoundation.org/Development
it seems that the error is inside 'cppu', please re-run build
inside this module to isolate the error and/or test your fix:
---
rm -Rf /home/suren/libreoffice/libo/cppu/unxlngx6.pro # optional module 'clean'
/bin/bash
cd /home/suren/libreoffice/libo
source ./LinuxX86-64Env.Set.sh
cd cppu
build
when the problem is isolated and fixed exit and re-run 'make' from the top-level
Please do advice what to do here ? Let me know if anything more is
needed from my side.
I am running Ubuntu 10.10, 64 bit.
--
regards
Suren
Learning < Doing
Learn By doing.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Build issue with cppu
Hi Dave, On Tue, Jan 25, 2011 at 10:42 AM, David Dumaresq wrote: > > > I suggest you take a look at the advice under The Build Failed... What can I > do? here, http://wiki.documentfoundation.org/Development/Native_Build > > Dave > I already did that and have pasted the output of the individual rebuild of the module above :) I tried quite a few times with the individual build. It seems like the build is going through fine, but the unit tests failing. I didn't know what to do from there. -- regards Suren Learning < Doing Learn By doing. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Build issue with cppu
Hi Caolan, Ran it once again without the --enable-symols after a make clean. Looks like things are okay now :) On Wed, Jan 26, 2011 at 10:10 PM, Caolán McNamara wrote: > On Wed, 2011-01-26 at 11:51 +0530, Surendran Mahendran wrote: >> All these were the changes in the ure folder which had cppu. Reckon any >> one of this could have fixed my issue ? > > I wouldn't *think* so, would have to check again without > --enable-symbols to see if the failure comes back :-) > > C. > -- regards Suren Learning < Doing Learn By doing. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] First time Build issues on Ubuntu
Hi, I am new to Libreoffice and I was trying to build Libreoffice for the first time. I ended up with this error - [1]. I figured it might be because the file might not have included algorithm as the 'lower_bound' function that was said missing is provided by algorithm header. I naively added a #include using namespace std to .../build/build/libreoffice-3.2.99.2/forms/source/component/GroupManager.hxx and the build worked. And right now proceeding with the build further. But I am not sure this is the right way of doing it as I believe we are using stlports and that would mean algorithm should come from stlports and now from system provided STL. Please do advice how to proceed to get it fixed. [1] http://libreoffice.pastebin.com/3hEYKZnk -- Thanks, Suren ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] First time Build issues on Ubuntu
Hi, On Fri, Oct 29, 2010 at 3:04 PM, Caolán McNamara wrote: > On Fri, 2010-10-29 at 09:34 +0530, surensp...@gmail.com wrote: >> I am new to Libreoffice and I was trying to build Libreoffice for the >> first time. I ended up with this error - [1]. I figured it might be >> because the file might not have included algorithm as the >> 'lower_bound' function that was said missing is provided by algorithm >> header. I naively added a >> >> >> #include >> using namespace std >> >> >> to >> .../build/build/libreoffice-3.2.99.2/forms/source/component/GroupManager.hxx >> and the build worked. And right now proceeding with the build further. > > Right, yes #include was the right fix. I pushed that last > night, so it should be good now. You're instincts were correct. > >> But I am not sure this is the right way of doing it as I believe we >> are using stlports and that would mean algorithm should come from >> stlports and now from system provided STL. Please do advice how to >> proceed to get it fixed. > > Nah, Ignore the stl implementation behind the curtain (For linux its > only behind the curtain for x86 anyway). You generally don't need to > worry about doing anything special for the stlport using ports, just > #include and its all taken care of, so indeed #include > is good. > > C. > > Thanks for the response and fix. Meanwhile I had got the actual commit which introduced the break and raised the bug against the committer. Will close the bug as well. -- regards Suren ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Building LibreOffice in Ubuntu Maverick
Hi,
Have successfully completed a build on Ubuntu 10.10. Thanks to a lot
of guys from IRC and mailing list for helping out :)
My earlier builds were taking very long times and were failing for one
reason or other. I decided to try out --with-system-libs ( another
suggestion from IRC) and it worked out quite well.After a few tries,
this was my autogen.sh command
./autogen.sh --with-system-libs --with-num-cpus=5 --without-junit
--disable-kde --with-lucene-core-jar=/usr/share/java/lucene-core-2.9.2.jar
--with-lucene-analyzers-jar=/usr/share/java/lucene-analyzers-2.9.2.jar
--with-saxon-jar=/usr/share/java/saxonb-9.0.jar --without-agg
There were few issues
1) Issue with the lpsolve system library alone as the library in the
ubunu repository were not new enough. Tried to replace the native
liblpsolve55.{a,o} with the ones in lpsolve_5.5.zip from $loroot/src.
This fixed the issue.
2) Installed lucene libs from synaptic and supply that for the
autogen.sh when it complains. Its likely to complain since I had
specified to use system libs
3) Install saxonb and not saxon from apt.
4) Native ubuntu version of agg was old for autogen.sh. so disabled it
from build.
5) autogen.sh also complained for few more missing system libs, but
just installing them via apt fixed the issues.
Make and dev-install steps went through without any issues.
But when I try to run make dev-install again in the rawbuild
directory, it could not do so because of these errors -
http://libreoffice.pastebin.com/g2rJn2bR. Figured out from the
ooinstall perl script that script dies if it could not copy. There is
no check if the file or symlink already exists.
797 copy ("$sourcepath", "$destdir$destination") || die "Can't
copy file: $sourcepath -> $destdir$destination $!";
So is the rawbuild directory meant only for first time builds ? if so
how to do successive builds ? Please do point me to any wiki pages if
these are already answered there.
Thanks in advance :)
--
regards,
Suren
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] sc: fix parenthesis mixup
I also faced the issue. I just had to add a paranthesis to fix it and proceed with the build. But when I thought of submitting the patch, that ucalc.cxx file was not git revisioned. Just for knowledge, How are these files generated ? Thanks, ~Suren On Wed, Nov 3, 2010 at 2:54 AM, Caolán McNamara wrote: > On Tue, 2010-11-02 at 20:00 +0100, Gert Faller wrote: >> Hi, >> >> On Tue, Nov 02, 2010 at 03:10:49PM +0100, Sebastian Spaeth wrote: >> > Commit cab7e33c4ff6067486b745ebfc0b37ed1d6d18b7 broke parentheses. Fixing >> > >> >> My fault, sorry. > > Fear not, I've broken the build about fifteen times already. Its the > easiest thing in the world to not break the build, by not making any > changes at all :-) so I wouldn't worry massively about it. > > C. > > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice > -- regards Suren http://twitter.com/suren ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] sc: fix parenthesis mixup
Hey Sebastian, I did the push in rawbuild directory and not in build directory. This specific file within clone even was not in git repo. Not sure how that is possible though. Thanks, ~Suren On Wed, Nov 3, 2010 at 2:15 PM, Sebastian Spaeth wrote: > On Wed, 3 Nov 2010 10:12:08 +0530, "surensp...@gmail.com" > wrote: >> I also faced the issue. I just had to add a paranthesis to fix it and >> proceed with the build. But when I thought of submitting the patch, >> that ucalc.cxx file was not git revisioned. Just for knowledge, How >> are these files generated ? > > You were looking in build/libreoffice/* which is rsynce'd over from the > git repositories (and therefore really not in a git repo). The real git > administered files are in clone/* respectively symlinked to rawbuild/* > (which is why many developers prefer to build in rawbuild directly) > > Sebastian > -- regards Suren http://twitter.com/suren ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Bulding problem, Linux 32 bit, Ubuntu 10.10
Hi , I had a similar problem in my ubuntu as well. A little debugging into install log showed me that there were issues with /usr/lib/libdb-4.7.so in ubuntu 10.10. I compared the files in rawbuild/solver/330/unx*/lib/libdb-4.7. They were different. Thats why everything else seemed to work but for this "unopkg sync" command which somehow was pulling the native library. I backed up the native libdb and syn linked the one built during libreoffice to /usr/lib. Its a very unconventional/desperate hack, but it worked. The build succeeded without any more issues. Hope that helps. Thanks, ~Suren On Wed, Nov 3, 2010 at 12:15 PM, KAMI911 KAMI911 wrote: > Hi Friends of LibreOffice, > During the very last stage of make I hit this problem: > > In instsetoo_native, I got ERROR: ERROR: > JFW_PLUGIN_DO_NOT_CHECK_ACCESSIBILITY=1 unopkg sync --verbose > -env:BUNDLED_EXTENSIONS_USER="file:///home/kami/git/libreoffice-3-3/build/build/libreoffice-3.2.99.2/instsetoo_native/unxlngi6.pro/LibreOffice/archive/install/en-US_inprogress/LibO_3.3.0_Linux_x86_install-arc_en-US/./share/prereg/bundled" > -env:UserInstallation=file:///tmp/ooopackaging/i_216551288745877/unxlngi6.pro/LibreOffice/archive/uno/en-US > 2>&1 | failed! in function: register_extensions > > Do you have idea how to fix it? > > Best regards, > KAMI > > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice > > -- regards Suren http://twitter.com/suren ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] German Translations in Writer module
Hi Miklos, On Wed, Nov 3, 2010 at 10:16 PM, Miklos Vajna wrote: >> @@ -27,8 +27,8 @@ >> / >> >> /** >> -Achtung: Ab sofort sind in diesem File keine C++-Kommentare (//) mehr >> - erlaubt, da es von swicli.c included wird! >> +Attention: From now on in this file does not C comments (//) more >> + allowed because it is included of swicli.c > > Hmm, this sounds like the output of a machine translator. :) most part of it was machine translation as I had mentioned :) > [1] It is not clear to me what "it" means here, need to check the code > if some script really extracts part of that header, or what's going on. > Also the statement should be like this - "From now on C++ comments (/ comments) are no longer allowed as swicli.c has been included. " ( only /* comments */ are allowed is implied. I thought it was obvious for me. Sorry about that. ) Most part of the file comments were description of the identifiers for which the translations were good enough, which is why I decided to use the machine translations in the first place. And this being a file will all the identfiers, I felt the added need to translate them before I start working on it. Please let me know if there are any more changes, so that I can make and resubmit the patch. Thanks, ~Suren. -- regards Suren http://twitter.com/suren ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Building LibreOffice in Ubuntu Maverick
HI Michael, On Mon, Nov 1, 2010 at 5:29 PM, Michael Meeks wrote: > > On Sun, 2010-10-31 at 02:31 +0530, surensp...@gmail.com wrote: >> >> But when I try to run make dev-install again in the rawbuild >> directory, it could not do so because of these errors - >> http://libreoffice.pastebin.com/g2rJn2bR. Figured out from the >> ooinstall perl script that script dies if it could not copy. There is >> no check if the file or symlink already exists. > > Ok - well, that is a great bug to fix in the perl script itself ;-) > it'd be lovely to have 'make_install' work again. IMHO we should unlink > before we copy - so we don't tread through symlinks by mistake. Have attached the patch for the same. Tested it in my environment and it works fine. Probably takes up an additional minute to remove all the symlinks/files before copying them again. But better than actually me removing the install directory manually. [ I also heard from IRC this might be a bug with ubuntu only, but then this should not break anywhere ] -- regards Suren Learning > Doing Learn By doing. 0001-Build-script-improvement-to-dev-install-target.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED, partial] Re: [Patch] German Translation and dev-install build improvement
Hey Caolan,
On Fri, Nov 5, 2010 at 7:47 PM, Caolán McNamara wrote:
> On Thu, 2010-11-04 at 22:22 +0530, surensp...@gmail.com wrote:
>> Hi,
>>
>> Just resending the patches with the suggested changes from other mailing
>> threads
>>
>> Patch 1 : German Translation of comments in writer
>
> So, catch is that there was a few other changes made in the meantime to
> that file so it doesn't fully apply.
>
> Like we talked out in IRC there are a few other gotchas in there as well
> wrt. the comments falling out of sync and ending commenting the next
> entry down. And there's a fair bit of machine generated English in there
> which I can't make head or tail of :-). So I've pushed what applied and
> what made sense to me.
Sorry for the machine translation part., there were quite a large
volume of german comments in my defense ;) I will review the file once
again and make manual translations where ever possible. Thanks once
again for the awesome support :)
>> Patch 2 : make dev-install fails when run the second time (happens so
>> in Ubuntu). The patch I have provided is platform independent and have
>> tested in Ubuntu to work fine.
>
> Should the test for a dir be *before* the test for existence, i.e. like
> so...
>
> if(-e "$destdir$destination") {
> #printf "Deleting already present file $destdir$destination from
> previous builds\n";
> unlink "$destdir$destination";
> }
> if(-d "$destdir$destination"){
> #printf "Deleting already present Directory $destdir$destination
> from previous builds\n";
> rmree("$destdir$destination");
> }
>
> C.
>
>
Updated the second patch and tested it.( Also as an off note, to be
noted is through out "make dev-install" the directory check condition
is not satisfied at all.)
Thanks to Sebastian also for the help :)
--
regards
Suren
Learning > Doing
Learn By doing.
suren.in
0002-Build-script-improvement-to-dev-install-target.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Suggestion needed for External Edit functionality.
Hi Everyone, This is regarding this bug - https://bugs.freedesktop.org/show_bug.cgi?id=30508 Goal: To be able to open an image(Graphic item) in an external application for advanced editing What is already done: Added a menu item to right click popup on the graphic, coupled the menu item with a method that handles the event.(I have attached a snippet of that method as a preliminary hack for the same) I current way I am implementing is that I save the Graphic a temporary file,then to create a new thread ( using osl_createThread from osl/thread.h ) and from within the new thread execute the external application to open the temp ( using osl_executeProcess from osl/process.h). Then on I poll for the exit of the process and after exit, exit the new thread and main thread updates the graphic with the new temporary image. But the current way blocks the main loop and I end up getting an unresponsive libreoffice window which is not desirable at all. Please advice me how to go about this further. I thought off interrupts but not really sure to proceed. I searched opengrok for interrupt but couldn't find anything helpful. If I have been doing it the wrong way altogether please suggest me how to proceed. Please bear with the varied string classes used in the snippet, will fix them all before submitting the patch. Also Currently I am implementing this in Gnome ( just using eog as the external command), but will give the user the option to choose the application with a file chooser dialog. Many thanks for Thorsten and many others so far who have helped to get me this far. -- regards Suren Learning < Doing Learn By doing. snippet.cpp Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Suggestion needed for External Edit functionality.
Hi Thorsten, On Wed, Nov 10, 2010 at 10:32 PM, Thorsten Behrens wrote: >> > Hi Suren, > > since you already create a separate thread for the editing - just > fire it off, and send the main app a msg - like here: > > desktop/source/app/officeipcthread.cxx:289 > > (you'll probably replace STATIC_LINK with LINK, > DECL_STATIC_LINK with DECL_LINK, and IMPL_STATIC_LINK_NOINSTANCE > with IMPL_LINK) > > PostUserEvent adds an event into the main app msg queue, which then > gets processed like any other input (mouse, keyboard) in the LibO > mainloop. > > Also: just using osl_executeProcess() avoids idly spinning until the > external app is finished. Your thread just blocks then. > > HTH, > > -- Thorsten > It Did, It did. When I Hit compile and when it worked I was litreally jumping in my seat. :) Will clean up code and submit the patch soon enough. Thanks for the help very much :) -- regards Suren Learning < Doing Learn By doing. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Suggestion needed for External Edit functionality.
Hi Thorsten, > It Did, It did. When I Hit compile and when it worked I was litreally > jumping in my seat. :) Will clean up code and submit the patch soon > enough. Thanks for the help very much :) > I have attached the new snippet I have come up with. There are few issues I faced. 1) The postUserEvent is a way of asynchronously doing it. But had a tough time sending the processHandle as a part of data sent to the Event handler method. So had to use a deprecated method to get the ident and pass it across. That worked though the method was deprecated. 2) The thread is not blocking as expected when osl_ExecuteProcess is called and since it does not block, no other threads get executed. So back to the problem of LO window hanging up. Probably I am using a wrong osl_ProcessOption ? 3) I get Unknown status when the external process is exit and joinProcess is called. But I guess that is expected for the process is already exit by the time join process is called ? Not sure how to handle this scenario from a genuine scenario Once the process handling issues are resolved, just have to uncomment the commented code to handle the importing of the new grahic into the old graphic's place. Waiting for your input :) PS: The LGPL License in the file I had mentioned was copied from a file in a folder to where this file should go. Please suggest the proper license to be used for patches :) -- regards Suren Learning < Doing Learn By doing. extedit.cxx Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Suggestion needed for External Edit functionality.
On Sat, Nov 13, 2010 at 4:57 AM, Thorsten Behrens wrote: > surensp...@gmail.com wrote: >> 2) The thread is not blocking as expected when osl_ExecuteProcess is >> called and since it does not block, no other threads get executed. So >> back to the problem of LO window hanging up. Probably I am using a >> wrong osl_ProcessOption ? >> > Hi Suren, > > meh, that's my bad - indeed, the osl functions don't block. Just > move osl_joinProcess(pProcess) into the pWorker function, and let > that one block (it's a separate thread, so no prob). The event then > can just contain the name of the temp file, that needs loading. > >> PS: The LGPL License in the file I had mentioned was copied from a >> file in a folder to where this file should go. Please suggest the >> proper license to be used for patches :) >> > If you copy code from other files, that header is correct (you may > add "Portions copyright Suren , licensed under LGPLv3+ / MPL > 1.1" there). If it's all your code, please use this template: > > http://www.freedesktop.org/wiki/Software/LibreOffice/LicenseHeader > > Cheers, > > -- Thorsten > -- regards Suren Learning < Doing Learn By doing. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Suggestion needed for External Edit functionality.
Hi Thorsten, First of all, Many thanks for all the help through out :) I have attached the patches ( I have re-based with the latest origin/master as of Sunday Night IST ) for the First cuts of the "Edit with External Application" functionality. I have seen it working nicely in Gnome based (just needs the eog command actually). Moving Further, I would like to add the following items to make it a full fledged items across all platforms. 1) Making it work in all OS/platforms: Currently I just call eog as the external application(eye of gnome - an image viewer application). Instead a file chooser dialog can be provided which can be used to choose the application to run. This can work well with Mac OS ( have to prefix "open -a " to the file name and supply it for the osl_executeProcess method ) and Linux ( not much different from the current implementation ). For Windows, just supplying the full system path of the file should open it with the registered application for the mime type. Is there a better way to Handle this ? Also, if they user has once selected an application, how to 'cache' that selection for that session/computer ? 2) Undo/Redo Option: Need to dig a bit more into how to add this functionality. 3) Window repaint issue: Most of the times, the Graphic object is still showing the old image after closing the external application but this happens because somehow the writer window is not repainted. If I scroll down and scroll up again, it repaints it and everything is good. (digging up on this and will try to complete this on my own :) ) Please do review the code as well as the above items and let me know how to proceed. Would love to hear any other comments/suggestions as well. PS: Thanks to spaeth for the git rebasing squash magic. -- regards Suren Learning < Doing Learn By doing. external_edit-0.1.tar.gz Description: GNU Zip compressed data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Suggestion needed for External Edit functionality.
Apologies for the blank mail earlier. Accidentally hit the send button :( -- regards Suren Learning < Doing Learn By doing. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] More patches for Base
Hey Wols, >> On Wed, 10 Nov 2010 22:51:04 +, Wols Lists >> wrote: > By the way, is there an easy git command to squash two patches together? > > Cheers, > Wol Got to know about the git-squashing from Spaetz. Works really nice for me. Hope this helps :) [1] http://book.git-scm.com/4_interactive_rebasing.html -- regards Suren Learning < Doing Learn By doing. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Licensing my contributions
All of my past & future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. Cheers, Suren. -- Cheers, ~Suren. Co-Founder, Goyaka Labs http://suren.in http://twitter.com/suren skype: pingsuren Ph: 9742077760 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
