Re: DPI and screen resolution on OS X

[SOS]

On 3/02/2016 3:55, Kohei Yoshida wrote:

On Wed, 2016-02-03 at 10:52 +1100, Chris Sherlock wrote:

The other question is: why would we not want to the actual DPI and
screen resolution?

My understanding is that, historically, the OS provided a function to
query DPI but what gets returned from such function was not always
accurate (or always not accurate depending on who you ask).  So, the
workaround at the time was to assume that DPI is always 96 (and
hard-code that value) regardless of what the OS told you, which worked
just fine because the monitors used back in the day had the same screen
resolution.
Mostly DPI is found in the header of a pixelfile (taken by camera). 
Unfortunately it's not the photographer who gets to decide about the 
needed DPI.
DPI is actually a wrong definition for documents, Dots Per Inch is a 
definition used by output devices. Screens need a PIXEL par DOT but for 
print devices there is no precise correlation between the number of dots 
used by the device and the pixels needed in  the image for having a 
maximum image-view quality.

The print industry has come to some standards by trial and error.
- monitor screens need 96 - (220-retina) pixels per inch
- laser printers need 150 pixels per inch (up tot 2000 + dots)
- offset printers need 254 -300 pixels per inch (up to 3000 dots)

For a document we must use Pixels Per Inch which are calculated 
regarding the DPI needed by the final output device and represented in 
each document by  a "Print Intention" .
When producing docs for printing on an office laser printer we need less 
Pixels Per Inch than docs (magazines , books) which are printed on 
offset machines.
When an image is loaded, then the system can calculate the viewing size 
using the number of pixels needed by the "Print Intention". The user can 
then see the maximum size the image can have in his document without 
losing image  quality.


Hope it helps

Fernand


I'm not sure if that's a non-issue today.  I don't know enough about
this topic to tell you that with confidence.

Kohei

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: framework/source

[kerem]

 framework/source/services/desktop.cxx  |3 +--
 framework/source/services/modulemanager.cxx|3 +--
 framework/source/uielement/thesaurusmenucontroller.cxx |3 +--
 3 files changed, 3 insertions(+), 6 deletions(-)

New commits:
commit 36c3229a2e7765901dc3c21da3b223eca33266a4
Author: kerem 
Date:   Tue Feb 2 15:21:41 2016 +0200

tdf#88205 Delete 'css::uno::Sequence' in framework

Change-Id: I66857f640e2e4c397b4f9baf7903356a0510c0b7
Reviewed-on: https://gerrit.libreoffice.org/22035
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/framework/source/services/desktop.cxx 
b/framework/source/services/desktop.cxx
index 939d3ba..50bf49c 100644
--- a/framework/source/services/desktop.cxx
+++ b/framework/source/services/desktop.cxx
@@ -88,8 +88,7 @@ sal_Bool SAL_CALL Desktop::supportsService(OUString const & 
ServiceName)
 css::uno::Sequence SAL_CALL Desktop::getSupportedServiceNames()
 throw (css::uno::RuntimeException, std::exception)
 {
-css::uno::Sequence< OUString > aSeq { "com.sun.star.frame.Desktop" };
-return aSeq;
+return { "com.sun.star.frame.Desktop" };
 }
 
 void Desktop::constructorInit()
diff --git a/framework/source/services/modulemanager.cxx 
b/framework/source/services/modulemanager.cxx
index e558ed0..98e441e 100644
--- a/framework/source/services/modulemanager.cxx
+++ b/framework/source/services/modulemanager.cxx
@@ -170,8 +170,7 @@ sal_Bool ModuleManager::supportsService(OUString const & 
ServiceName)
 css::uno::Sequence< OUString > ModuleManager::getSupportedServiceNames()
 throw (css::uno::RuntimeException, std::exception)
 {
-css::uno::Sequence< OUString > s { "com.sun.star.frame.ModuleManager" };
-return s;
+return { "com.sun.star.frame.ModuleManager" };
 }
 
 OUString SAL_CALL ModuleManager::identify(const css::uno::Reference< 
css::uno::XInterface >& xModule)
diff --git a/framework/source/uielement/thesaurusmenucontroller.cxx 
b/framework/source/uielement/thesaurusmenucontroller.cxx
index 41601e3..bf46b79 100644
--- a/framework/source/uielement/thesaurusmenucontroller.cxx
+++ b/framework/source/uielement/thesaurusmenucontroller.cxx
@@ -159,8 +159,7 @@ OUString ThesaurusMenuController::getImplementationName()
 css::uno::Sequence< OUString > 
ThesaurusMenuController::getSupportedServiceNames()
 throw ( css::uno::RuntimeException, std::exception )
 {
-css::uno::Sequence aRet { 
"com.sun.star.frame.PopupMenuController" };
-return aRet;
+return { "com.sun.star.frame.PopupMenuController" };
 }
 
 extern "C" SAL_DLLPUBLIC_EXPORT css::uno::XInterface * SAL_CALL
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 88205] Adapt uses of css::uno::Sequence to use initializer_list ctor

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88205

--- Comment #7 from Commit Notification 
 ---
kerem committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=36c3229a2e7765901dc3c21da3b223eca33266a4

tdf#88205 Delete 'css::uno::Sequence' in framework

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: dtrans/Library_ftransl.mk dtrans/source dtrans/StaticLibrary_dtobj.mk

[burcinakalin]

 dtrans/Library_ftransl.mk|5 
 dtrans/StaticLibrary_dtobj.mk|5 
 dtrans/source/inc/WinClip.hxx|   29 +++
 dtrans/source/win32/dtobj/DOTransferable.cxx |2 -
 dtrans/source/win32/dtobj/DTransHelper.hxx   |2 -
 dtrans/source/win32/dtobj/DataFmtTransl.cxx  |2 -
 dtrans/source/win32/dtobj/FetcList.cxx   |2 -
 dtrans/source/win32/ftransl/ftransl.hxx  |2 -
 dtrans/source/win32/misc/WinClip.hxx |   29 ---
 9 files changed, 44 insertions(+), 34 deletions(-)

New commits:
commit 078d5e8abf51a576dd8532d479fb39bfcb8a4e97
Author: burcinakalin 
Date:   Wed Dec 23 19:51:09 2015 +0200

tdf#95416 Get rid of #include "../foo/bar.hxx" style includes.

Change-Id: Icbff7c5f596d4ec1918e0d7924972a0651dde811
Signed-off-by: burcinakalin 
Reviewed-on: https://gerrit.libreoffice.org/20913
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/dtrans/Library_ftransl.mk b/dtrans/Library_ftransl.mk
index b7b735d..7d4a5a2 100644
--- a/dtrans/Library_ftransl.mk
+++ b/dtrans/Library_ftransl.mk
@@ -46,4 +46,9 @@ $(eval $(call gb_Library_add_exception_objects,ftransl,\
dtrans/source/win32/ftransl/ftranslentry \
 ))
 
+$(eval $(call gb_Library_set_include,ftransl,\
+-I$(SRCDIR)/dtrans/source/inc \
+$$(INCLUDE) \
+))
+
 # vim: set noet sw=4 ts=4:
diff --git a/dtrans/StaticLibrary_dtobj.mk b/dtrans/StaticLibrary_dtobj.mk
index 3553ae8..04ed1c5 100644
--- a/dtrans/StaticLibrary_dtobj.mk
+++ b/dtrans/StaticLibrary_dtobj.mk
@@ -36,4 +36,9 @@ $(eval $(call gb_StaticLibrary_add_exception_objects,dtobj,\
dtrans/source/win32/misc/ImplHelper \
 ))
 
+$(eval $(call gb_StaticLibrary_set_include,dtobj,\
+   -I$(SRCDIR)/dtrans/source/inc \
+   $$(INCLUDE) \
+))
+
 # vim: set noet sw=4 ts=4:
diff --git a/dtrans/source/win32/misc/WinClip.hxx 
b/dtrans/source/inc/WinClip.hxx
similarity index 87%
rename from dtrans/source/win32/misc/WinClip.hxx
rename to dtrans/source/inc/WinClip.hxx
index 268c7a0..69d4c50 100644
--- a/dtrans/source/win32/misc/WinClip.hxx
+++ b/dtrans/source/inc/WinClip.hxx
@@ -17,13 +17,13 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_DTRANS_SOURCE_WIN32_MISC_WINCLIP_HXX
-#define INCLUDED_DTRANS_SOURCE_WIN32_MISC_WINCLIP_HXX
+#ifndef INCLUDED_DTRANS_SOURCE_INC_WINCLIP_HXX
+#define INCLUDED_DTRANS_SOURCE_INC_WINCLIP_HXX
 
 #include 
 
 const sal_Int32 CF_INVALID = 0;
 
-#endif
+#endif // INCLUDED_DTRANS_SOURCE_INC_WINCLIP_HXX
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/dtrans/source/win32/dtobj/DOTransferable.cxx 
b/dtrans/source/win32/dtobj/DOTransferable.cxx
index 7a9a632..e57b745 100644
--- a/dtrans/source/win32/dtobj/DOTransferable.cxx
+++ b/dtrans/source/win32/dtobj/DOTransferable.cxx
@@ -23,7 +23,7 @@
 
 #include "DOTransferable.hxx"
 #include "../misc/ImplHelper.hxx"
-#include "../misc/WinClip.hxx"
+#include "WinClip.hxx"
 #include "DTransHelper.hxx"
 #include "TxtCnvtHlp.hxx"
 #include "MimeAttrib.hxx"
diff --git a/dtrans/source/win32/dtobj/DTransHelper.hxx 
b/dtrans/source/win32/dtobj/DTransHelper.hxx
index ce0e3b4..5760ca3 100644
--- a/dtrans/source/win32/dtobj/DTransHelper.hxx
+++ b/dtrans/source/win32/dtobj/DTransHelper.hxx
@@ -27,7 +27,7 @@
 #if defined _MSC_VER
 #pragma warning(pop)
 #endif
-#include "../misc/WinClip.hxx"
+#include "WinClip.hxx"
 
 #define AUTO_INIT TRUE
 
diff --git a/dtrans/source/win32/dtobj/DataFmtTransl.cxx 
b/dtrans/source/win32/dtobj/DataFmtTransl.cxx
index cfba2eb..55b1fba 100644
--- a/dtrans/source/win32/dtobj/DataFmtTransl.cxx
+++ b/dtrans/source/win32/dtobj/DataFmtTransl.cxx
@@ -22,7 +22,7 @@
 #include 
 #include 
 #include "../misc/ImplHelper.hxx"
-#include "../misc/WinClip.hxx"
+#include "WinClip.hxx"
 #include "MimeAttrib.hxx"
 #include "DTransHelper.hxx"
 #include 
diff --git a/dtrans/source/win32/dtobj/FetcList.cxx 
b/dtrans/source/win32/dtobj/FetcList.cxx
index 2b4db3f..fbd9500 100644
--- a/dtrans/source/win32/dtobj/FetcList.cxx
+++ b/dtrans/source/win32/dtobj/FetcList.cxx
@@ -25,7 +25,7 @@
 
 #include "DataFmtTransl.hxx"
 #include "../misc/ImplHelper.hxx"
-#include "../misc/WinClip.hxx"
+#include "WinClip.hxx"
 
 #include 
 
diff --git a/dtrans/source/win32/ftransl/ftransl.hxx 
b/dtrans/source/win32/ftransl/ftransl.hxx
index 936377d..6d1f0ea 100644
--- a/dtrans/source/win32/ftransl/ftransl.hxx
+++ b/dtrans/source/win32/ftransl/ftransl.hxx
@@ -27,7 +27,7 @@
 #include 
 #include 
 #include 
-#include "../misc/WinClip.hxx"
+#include "WinClip.hxx"
 
 #include 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 95416] Get rid of #include "../foo/bar.hxx" style includes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95416

--- Comment #7 from Commit Notification 
 ---
burcinakalin committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=078d5e8abf51a576dd8532d479fb39bfcb8a4e97

tdf#95416 Get rid of #include "../foo/bar.hxx" style includes.

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 51/e9a26e702cdbdeb864844b5092d7f24ba28141

[Caolán McNamara]

 51/e9a26e702cdbdeb864844b5092d7f24ba28141 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 2f5861bfcff3af387290e90d6269e786b41bd8cc
Author: Caolán McNamara 
Date:   Wed Feb 3 09:08:34 2016 +

Notes added by 'git notes add'

diff --git a/51/e9a26e702cdbdeb864844b5092d7f24ba28141 
b/51/e9a26e702cdbdeb864844b5092d7f24ba28141
new file mode 100644
index 000..889f487
--- /dev/null
+++ b/51/e9a26e702cdbdeb864844b5092d7f24ba28141
@@ -0,0 +1 @@
+prefer: 21e2c2f16408328f78f418dd9dc086ef2a2a8f19
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - libreofficekit/qa

[Stephan Bergmann]

 libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 201793cb2c204475422cd0ee86f4065f03e4b9be
Author: Stephan Bergmann 
Date:   Thu Jan 28 15:47:41 2016 +0100

Missing include

Change-Id: I4930837c2a5bd78c16a83dcccde34843d3026618
(cherry picked from commit 63cada47911029cce512f3b8ac0b6a6d2c323032)

diff --git a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx 
b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
index fb886ef..ebf0559 100644
--- a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
@@ -11,6 +11,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: extras/CustomTarget_autotextshare.mk extras/source

[László Németh]

 extras/CustomTarget_autotextshare.mk  |   12 +-
 extras/source/autotext/lang/hu/standard/2010/content.xml  |2 -
 extras/source/autotext/lang/hu/standard/2010/styles.xml   |2 -
 extras/source/autotext/lang/hu/standard/2011/content.xml  |2 -
 extras/source/autotext/lang/hu/standard/2011/styles.xml   |2 -
 extras/source/autotext/lang/hu/standard/2012/content.xml  |2 -
 extras/source/autotext/lang/hu/standard/2012/styles.xml   |2 -
 extras/source/autotext/lang/hu/standard/2013/content.xml  |2 -
 extras/source/autotext/lang/hu/standard/2013/styles.xml   |2 -
 extras/source/autotext/lang/hu/standard/2014/content.xml  |2 -
 extras/source/autotext/lang/hu/standard/2014/styles.xml   |2 -
 extras/source/autotext/lang/hu/standard/2016/content.xml  |2 +
 extras/source/autotext/lang/hu/standard/2016/styles.xml   |2 +
 extras/source/autotext/lang/hu/standard/BlockList.xml |8 +---
 extras/source/autotext/lang/hu/standard/META-INF/manifest.xml |   20 ++
 15 files changed, 12 insertions(+), 52 deletions(-)

New commits:
commit ddefbfd6453ec4184fbe806f9aec4188c4b88012
Author: László Németh 
Date:   Fri Jan 29 18:27:08 2016 +0100

Update Hungarian Autotext patterns

Remove obsolete patterns for date field insertion, add a current one.

Change-Id: Ifb7109b6b3eb210f1b1b40bab236794c07a105d7
Reviewed-on: https://gerrit.libreoffice.org/21943
Tested-by: Jenkins 
Reviewed-by: Andras Timar 

diff --git a/extras/CustomTarget_autotextshare.mk 
b/extras/CustomTarget_autotextshare.mk
index 486ac63..dda8b98 100644
--- a/extras/CustomTarget_autotextshare.mk
+++ b/extras/CustomTarget_autotextshare.mk
@@ -1581,16 +1581,8 @@ extras_AUTOTEXTSHARE_XMLFILES := \
hu/crdbus54/MOD2/Pictures/201B0CD20CED91A0BB03.svm \
hu/crdbus54/MOD2/settings.xml \
hu/crdbus54/MOD2/styles.xml \
-   hu/standard/2010/content.xml \
-   hu/standard/2010/styles.xml \
-   hu/standard/2011/content.xml \
-   hu/standard/2011/styles.xml \
-   hu/standard/2012/content.xml \
-   hu/standard/2012/styles.xml \
-   hu/standard/2013/content.xml \
-   hu/standard/2013/styles.xml \
-   hu/standard/2014/content.xml \
-   hu/standard/2014/styles.xml \
+   hu/standard/2016/content.xml \
+   hu/standard/2016/styles.xml \
hu/standard/AL/AL.xml \
hu/standard/AL/atevent.xml \
hu/standard/B/atevent.xml \
diff --git a/extras/source/autotext/lang/hu/standard/2010/content.xml 
b/extras/source/autotext/lang/hu/standard/2010/content.xml
deleted file mode 100644
index d91793b..000
--- a/extras/source/autotext/lang/hu/standard/2010/content.xml
+++ /dev/null
@@ -1,2 +0,0 @@
-
-http://www.w3.org/1999/xlink"; 
xmlns:dc="http://purl.org/dc/elements/1.1/"; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML"; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" 
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" xmlns:ooo="ht
 tp://openoffice.org/2004/office" 
xmlns:ooow="http://openoffice.org/2004/writer"; 
xmlns:oooc="http://openoffice.org/2004/calc"; 
xmlns:dom="http://www.w3.org/2001/xml-events"; 
xmlns:xforms="http://www.w3.org/2002/xforms"; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
office:version="1.0">.  .2006. június 
12.
\ No newline at end of file
diff --git a/extras/source/autotext/lang/hu/standard/2010/styles.xml 
b/extras/source/autotext/lang/hu/standard/2010/styles.xml
deleted file mode 100644
index 9a50834..000
--- a/extras/source/autotext/lang/hu/standard/2010/styles.xml
+++ /dev/null
@@ -1,2 +0,0 @@
-
-http://www.w3.org/1999/xlink"; 
xmlns:dc="http://purl.org/dc/elements/1.1/"; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML"; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" 
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" xmlns:ooo="htt
 p://openoffice.org/2004/office" xmlns:ooow="http://openoffice.org/2004/writer"; 
xmlns:oooc="http://openoffice.org/2004/calc"; 
xmlns:dom="http://www.w3.org/2001/xml-events"; 
office:version="1.0">
\ No newline at end of file
diff --git a/extras/source/autotext/lang/hu/standard/2011/content.xml 
b/extras/source/autotext

[Libreoffice-commits] core.git: sw/source

[László Németh]

 sw/source/uibase/docvw/edtwin.cxx |   31 +++
 1 file changed, 31 insertions(+)

New commits:
commit 483d0e85fad6f8f787ada28bc16242c43f7496b4
Author: László Németh 
Date:   Sat Jan 30 17:17:42 2016 +0100

Autocompletion: complete year (part) to current date

to check or insert it during typing.

For example, typing "201" or "2016-0", Writer will
suggest "2016-01-30" - the current date in ISO 8601
format - in a tooltip, and it's possible to insert it
pressing enter.

There is no autocompletion for single years (e.g. "2016")
to avoid unintentional text insertion at line ending, e.g.
typing "30 January 2016" in a letter header.

Change-Id: I230a449b0e19d5316b8369d780d7c7fda57fea37
Reviewed-on: https://gerrit.libreoffice.org/21928
Tested-by: Jenkins 
Reviewed-by: Andras Timar 

diff --git a/sw/source/uibase/docvw/edtwin.cxx 
b/sw/source/uibase/docvw/edtwin.cxx
index 72b03f3..bfb3a40 100644
--- a/sw/source/uibase/docvw/edtwin.cxx
+++ b/sw/source/uibase/docvw/edtwin.cxx
@@ -29,6 +29,7 @@
 #include 
 
 #include 
+#include 
 
 #include 
 #include 
@@ -6022,6 +6023,29 @@ void QuickHelpData::FillStrArr( SwWrtShell& rSh, const 
OUString& rWord )
 aNames = (*pCalendar)->getDays();
 }
 
+// Add matching current date in ISO 8601 format, for example 2016-01-30
+OUString rStrToday;
+
+if (rWord[0] == '2')
+{
+OUStringBuffer rStr("");
+rStr.append(sal::static_int_cast< sal_Int32 
>((*pCalendar)->getValue(i18n::CalendarFieldIndex::YEAR))).append("-");
+sal_Int32 nMonth = sal::static_int_cast< sal_Int32 
>((*pCalendar)->getValue(i18n::CalendarFieldIndex::MONTH)+1);
+sal_Int32 nDay = sal::static_int_cast< sal_Int32 > 
((*pCalendar)->getValue(i18n::CalendarFieldIndex::DAY_OF_MONTH));
+if (nMonth < 10)
+rStr.append("0");
+rStr.append(nMonth).append("-");
+if (nDay < 10)
+rStr.append("0");
+rStrToday = rStr.append(nDay).toString();
+
+// do not suggest for single years, for example for "2016",
+// only for "201" or "2016-..." (to avoid unintentional text
+// insertion at line ending, for example typing "30 January 2016")
+if (rWord.getLength() != 4 && rStrToday.startsWith(rWord))
+m_aHelpStrings.push_back(rStrToday);
+}
+
 // Add matching words from AutoCompleteWord list
 const SwAutoCompleteWord& rACList = SwEditShell::GetAutoCompleteWords();
 std::vector strings;
@@ -6031,6 +6055,13 @@ void QuickHelpData::FillStrArr( SwWrtShell& rSh, const 
OUString& rWord )
 for (size_t i= 0; i___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - desktop/source include/LibreOfficeKit libreofficekit/source

[Jan Holesovsky]

 desktop/source/lib/init.cxx  |   39 ++-
 desktop/source/lib/lokinteractionhandler.cxx |  284 +--
 desktop/source/lib/lokinteractionhandler.hxx |   33 ++-
 include/LibreOfficeKit/LibreOfficeKitEnums.h |   14 +
 libreofficekit/source/gtk/lokdocview.cxx |   17 +
 5 files changed, 309 insertions(+), 78 deletions(-)

New commits:
commit c406c90289baa12663a382c7ed664f2cf93b75ab
Author: Jan Holesovsky 
Date:   Tue Feb 2 22:59:34 2016 +0100

lok interaction handler: Add handling of io and network errors.

Change-Id: If7c84a7b24f2072439718fb0c473b73243f2ecc1

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 5010bd0..3ae825a 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -252,7 +252,7 @@ static OUString getAbsoluteURL(const char* pURL)
 return OUString();
 }
 
-static void jsonToPropertyValues(const char* pJSON, 
uno::Sequence& rPropertyValues)
+static std::vector jsonToPropertyValuesVector(const 
char* pJSON)
 {
 std::vector aArguments;
 if (pJSON && pJSON[0] != '\0')
@@ -279,11 +279,11 @@ static void jsonToPropertyValues(const char* pJSON, 
uno::Sequence(OString(rValue.c_str()).toUInt32());
 else
-SAL_WARN("desktop.lib", "jsonToPropertyValues: unhandled type 
'"< const pInteraction(
-new 
LOKInteractionHandler(::comphelper::getProcessComponentContext(), pLib));
+new 
LOKInteractionHandler(::comphelper::getProcessComponentContext(), "load", 
pLib));
 auto const 
pair(pLib->mInteractionMap.insert(std::make_pair(aURL.toUtf8(), pInteraction)));
 comphelper::ScopeGuard const g([&] () {
 if (pair.second)
@@ -985,9 +985,9 @@ static void 
doc_initializeForRendering(LibreOfficeKitDocument* pThis,
 if (pDoc)
 {
 doc_iniUnoCommands();
-uno::Sequence aPropertyValues;
-jsonToPropertyValues(pArguments, aPropertyValues);
-pDoc->initializeForTiledRendering(aPropertyValues);
+
+pDoc->initializeForTiledRendering(
+
comphelper::containerToSequence(jsonToPropertyValuesVector(pArguments)));
 }
 }
 
@@ -1077,20 +1077,33 @@ public:
 static void doc_postUnoCommand(LibreOfficeKitDocument* pThis, const char* 
pCommand, const char* pArguments, bool bNotifyWhenFinished)
 {
 OUString aCommand(pCommand, strlen(pCommand), RTL_TEXTENCODING_UTF8);
+LibLODocument_Impl* pDocument = static_cast(pThis);
 
-uno::Sequence aPropertyValues;
-jsonToPropertyValues(pArguments, aPropertyValues);
-bool bResult = false;
+std::vector 
aPropertyValuesVector(jsonToPropertyValuesVector(pArguments));
 
-LibLODocument_Impl* pDocument = static_cast(pThis);
+// handle potential interaction
+if (aCommand == ".uno:Save")
+{
+rtl::Reference const pInteraction(
+new 
LOKInteractionHandler(::comphelper::getProcessComponentContext(), "save", 
gImpl, pDocument));
+uno::Reference const 
xInteraction(pInteraction.get());
+
+beans::PropertyValue aValue;
+aValue.Name = "InteractionHandler";
+aValue.Value <<= xInteraction;
+
+aPropertyValuesVector.push_back(aValue);
+}
+
+bool bResult = false;
 
 if (bNotifyWhenFinished && pDocument->mpCallback)
 {
-bResult = comphelper::dispatchCommand(aCommand, aPropertyValues,
+bResult = comphelper::dispatchCommand(aCommand, 
comphelper::containerToSequence(aPropertyValuesVector),
 new DispatchResultListener(pCommand, pDocument->mpCallback, 
pDocument->mpCallbackData));
 }
 else
-bResult = comphelper::dispatchCommand(aCommand, aPropertyValues);
+bResult = comphelper::dispatchCommand(aCommand, 
comphelper::containerToSequence(aPropertyValuesVector));
 
 if (!bResult)
 {
diff --git a/desktop/source/lib/lokinteractionhandler.cxx 
b/desktop/source/lib/lokinteractionhandler.cxx
index 5bb164c..bb287ff 100644
--- a/desktop/source/lib/lokinteractionhandler.cxx
+++ b/desktop/source/lib/lokinteractionhandler.cxx
@@ -19,12 +19,21 @@
 
 #include "lokinteractionhandler.hxx"
 
+#include 
+
 #include 
 #include 
 
 #include 
 #include 
 #include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
 
 #include <../../inc/lib/init.hxx>
 
@@ -34,8 +43,12 @@ using namespace com::sun::star;
 
 LOKInteractionHandler::LOKInteractionHandler(
 uno::Reference const & /*rxContext*/,
-desktop::LibLibreOffice_Impl *const pLOKit)
+const OString& rCommand,
+desktop::LibLibreOffice_Impl *const pLOKit,
+desktop::LibLODocument_Impl *const pLOKDocument)
 : m_pLOKit(pLOKit)
+, m_pLOKDocument(pLOKDocument)
+, m_command(rCommand)
 , m_usePassword(false)
 {
 assert(m_pLOKit);
@@ -78,8 +91,157 @@ throw (uno::RuntimeException, std::exception)
 handleInteractionRequest(xRequest);
 }
 
-sal_Bool LOKInteractionHandler::handlePasswordRequest(const 
uno::Seq

[Libreoffice-commits] core.git: svx/source

[Miklos Vajna]

 svx/source/svdraw/svdedtv2.cxx |   50 
 svx/source/svdraw/svdetc.cxx   |   64 -
 2 files changed, 57 insertions(+), 57 deletions(-)

New commits:
commit dc146752b2fe11b3523299462a806c3c374ee0fa
Author: Miklos Vajna 
Date:   Wed Feb 3 10:20:59 2016 +0100

svx: can now do nAnz -> nCount without name clashes

Change-Id: Ifc884a44008de0a34c056348321e5344ab2cb1f1

diff --git a/svx/source/svdraw/svdedtv2.cxx b/svx/source/svdraw/svdedtv2.cxx
index fcee2e4..3c9d41c 100644
--- a/svx/source/svdraw/svdedtv2.cxx
+++ b/svx/source/svdraw/svdedtv2.cxx
@@ -63,8 +63,8 @@ void SdrEditView::ObjOrderChanged(SdrObject* /*pObj*/, 
sal_uIntPtr /*nOldPos*/,
 
 void SdrEditView::MovMarkedToTop()
 {
-const size_t nAnz=GetMarkedObjectCount();
-if (nAnz!=0)
+const size_t nCount=GetMarkedObjectCount();
+if (nCount!=0)
 {
 const bool bUndo = IsUndoEnabled();
 
@@ -72,14 +72,14 @@ void SdrEditView::MovMarkedToTop()
 
BegUndo(ImpGetResStr(STR_EditMovToTop),GetDescriptionOfMarkedObjects(),SDRREPFUNC_OBJ_MOVTOTOP);
 
 SortMarkedObjects();
-for (size_t nm=0; nmGetOrdNum();
 }
 bool bChg=false;
 SdrObjList* pOL0=nullptr;
 size_t nNewPos=0;
-for (size_t nm=nAnz; nm>0;)
+for (size_t nm=nCount; nm>0;)
 {
 --nm;
 SdrMark* pM=GetSdrMarkByIndex(nm);
@@ -150,8 +150,8 @@ void SdrEditView::MovMarkedToTop()
 
 void SdrEditView::MovMarkedToBtm()
 {
-const size_t nAnz=GetMarkedObjectCount();
-if (nAnz!=0)
+const size_t nCount=GetMarkedObjectCount();
+if (nCount!=0)
 {
 const bool bUndo = IsUndoEnabled();
 
@@ -159,7 +159,7 @@ void SdrEditView::MovMarkedToBtm()
 
BegUndo(ImpGetResStr(STR_EditMovToBtm),GetDescriptionOfMarkedObjects(),SDRREPFUNC_OBJ_MOVTOBTM);
 
 SortMarkedObjects();
-for (size_t nm=0; nmGetOrdNum();
 }
@@ -167,7 +167,7 @@ void SdrEditView::MovMarkedToBtm()
 bool bChg=false;
 SdrObjList* pOL0=nullptr;
 size_t nNewPos=0;
-for (size_t nm=0; nmGetMarkedSdrObj();
@@ -245,8 +245,8 @@ void SdrEditView::PutMarkedToTop()
 
 void SdrEditView::PutMarkedInFrontOfObj(const SdrObject* pRefObj)
 {
-const size_t nAnz=GetMarkedObjectCount();
-if (nAnz!=0)
+const size_t nCount=GetMarkedObjectCount();
+if (nCount!=0)
 {
 const bool bUndo = IsUndoEnabled();
 if( bUndo )
@@ -272,14 +272,14 @@ void SdrEditView::PutMarkedInFrontOfObj(const SdrObject* 
pRefObj)
 SortMarkedObjects();
 }
 }
-for (size_t nm=0; nmGetOrdNum();
 }
 bool bChg=false;
 SdrObjList* pOL0=nullptr;
 size_t nNewPos=0;
-for (size_t nm=nAnz; nm>0;)
+for (size_t nm=nCount; nm>0;)
 {
 --nm;
 SdrMark* pM=GetSdrMarkByIndex(nm);
@@ -346,8 +346,8 @@ void SdrEditView::PutMarkedToBtm()
 
 void SdrEditView::PutMarkedBehindObj(const SdrObject* pRefObj)
 {
-const size_t nAnz=GetMarkedObjectCount();
-if (nAnz!=0)
+const size_t nCount=GetMarkedObjectCount();
+if (nCount!=0)
 {
 const bool bUndo = IsUndoEnabled();
 
@@ -373,13 +373,13 @@ void SdrEditView::PutMarkedBehindObj(const SdrObject* 
pRefObj)
 SortMarkedObjects();
 }
 }
-for (size_t nm=0; nmGetOrdNum();
 }
 bool bChg=false;
 SdrObjList* pOL0=nullptr;
 size_t nNewPos=0;
-for (size_t nm=0; nmGetMarkedSdrObj();
 if (pObj!=pRefObj) {
@@ -477,10 +477,10 @@ void SdrEditView::ReverseOrderOfMarked()
 
 void SdrEditView::ImpCheckToTopBtmPossible()
 {
-const size_t nAnz=GetMarkedObjectCount();
-if (nAnz==0)
+const size_t nCount=GetMarkedObjectCount();
+if (nCount==0)
 return;
-if (nAnz==1)
+if (nCount==1)
 { // special-casing for single selection
 SdrObject* pObj=GetMarkedObjectByIndex(0);
 SdrObjList* pOL=pObj->GetObjList();
@@ -503,7 +503,7 @@ void SdrEditView::ImpCheckToTopBtmPossible()
 } else { // multiple selection
 SdrObjList* pOL0=nullptr;
 size_t nPos0 = 0;
-for (size_t nm = 0; !bToBtmPossible && nmGetObjList();
 if (pOL!=pOL0) {
@@ -517,7 +517,7 @@ void SdrEditView::ImpCheckToTopBtmPossible()
 
 pOL0=nullptr;
 nPos0 = SAL_MAX_SIZE;
-for (size_t nm=nAnz; !bToTopPossible && nm>0; ) { // check 'bring to 
front'
+for (size_t nm=nCount; !bToTopPossible && nm>0; ) { // check 'bring to 
front'
 --nm;
 SdrObject* pObj=GetMarkedObjectByIndex(nm);
 SdrObjList* pOL=pObj->GetObjList();
@@ -1796,13 +1796,13 @@ void SdrEditView::GroupMarked(const SdrObject* pUserGrp)
 if (pGrp!=nullptr)
 {
 aNewMark.InsertEntry(SdrMark(pGrp,pPV));
-const size_t nAnz=pDstLst->GetO

[Libreoffice-commits] core.git: vcl/AllLangResTarget_vcl.mk vcl/inc vcl/source

[Andras Timar]

 vcl/AllLangResTarget_vcl.mk |1 +
 vcl/inc/svids.hrc   |6 ++
 vcl/source/app/svapp.cxx|   10 +-
 vcl/source/src/app.src  |   37 +
 4 files changed, 49 insertions(+), 5 deletions(-)

New commits:
commit e4b98408f60fdbe8248540da58bde8a9bf00c461
Author: Andras Timar 
Date:   Tue Feb 2 22:38:58 2016 +0100

tdf#97512 make strings localizable

Change-Id: I518918689e81475e9aaf0023cf91f4860531ad1e
Reviewed-on: https://gerrit.libreoffice.org/22063
Tested-by: Jenkins 
Reviewed-by: Andras Timar 

diff --git a/vcl/AllLangResTarget_vcl.mk b/vcl/AllLangResTarget_vcl.mk
index 7c286bf..822b3a2 100644
--- a/vcl/AllLangResTarget_vcl.mk
+++ b/vcl/AllLangResTarget_vcl.mk
@@ -33,6 +33,7 @@ $(eval $(call gb_SrsTarget_set_include,vcl/source/src,\
 ))
 
 $(eval $(call gb_SrsTarget_add_files,vcl/source/src,\
+vcl/source/src/app.src \
 vcl/source/src/btntext.src \
 vcl/source/src/helptext.src \
 vcl/source/src/menu.src \
diff --git a/vcl/inc/svids.hrc b/vcl/inc/svids.hrc
index d66ea92..e23fdc5 100644
--- a/vcl/inc/svids.hrc
+++ b/vcl/inc/svids.hrc
@@ -178,6 +178,12 @@
 
 #define SV_FUNIT_STRINGS10700
 
+#define SV_APP_CPUTHREADS   10800
+#define SV_APP_OSVERSION10801
+#define SV_APP_UIRENDER 10802
+#define SV_APP_GL   10803
+#define SV_APP_DEFAULT  10804
+
 #define SV_ICON_SIZE48_START2
 #define SV_ICON_SIZE32_START21000
 #define SV_ICON_SIZE16_START23000
diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx
index b22812e..b0d9111 100644
--- a/vcl/source/app/svapp.cxx
+++ b/vcl/source/app/svapp.cxx
@@ -1189,7 +1189,7 @@ OUString Application::GetHWOSConfInfo()
 ImplSVData* pSVData = ImplGetSVData();
 OUStringBuffer aDetails;
 
-aDetails.append( "CPU Threads: " );
+aDetails.append( VclResId(SV_APP_CPUTHREADS).toString() );
 aDetails.append( (sal_Int32)
 std::thread::hardware_concurrency() );
 aDetails.append( "; " );
@@ -1200,15 +1200,15 @@ OUString Application::GetHWOSConfInfo()
 else
 aVersion = "-";
 
-aDetails.append( "OS Version: " );
+aDetails.append( VclResId(SV_APP_OSVERSION).toString() );
 aDetails.append( aVersion );
 aDetails.append( "; " );
 
-aDetails.append( "UI Render: " );
+aDetails.append( VclResId(SV_APP_UIRENDER).toString() );
 if ( OpenGLWrapper::isVCLOpenGLEnabled() )
-aDetails.append( "GL" );
+aDetails.append( VclResId(SV_APP_GL).toString() );
 else
-aDetails.append( "default" );
+aDetails.append( VclResId(SV_APP_DEFAULT).toString() );
 aDetails.append( "; " );
 
 return aDetails.makeStringAndClear();
diff --git a/vcl/source/src/app.src b/vcl/source/src/app.src
new file mode 100644
index 000..91d9df1
--- /dev/null
+++ b/vcl/source/src/app.src
@@ -0,0 +1,37 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include "svids.hrc"
+
+String SV_APP_CPUTHREADS
+{
+Text [en-US] = "CPU Threads: ";
+};
+
+String SV_APP_OSVERSION
+{
+Text [en-US] = "OS Version: ";
+};
+
+String SV_APP_UIRENDER
+{
+Text [en-US] = "UI Render: ";
+};
+
+String SV_APP_GL
+{
+Text [en-US] = "GL";
+};
+
+String SV_APP_DEFAULT
+{
+Text [ en-US ] = "default";
+};
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [libo-marketing-priv] Program Committee for LibOCon

[Jan Holesovsky]

Hi Sophie,

Sophie píše v Út 02. 02. 2016 v 11:49 +0100:

> As each year, it's time to form the Program Committee. We need at least
> 3 or 4 persons available to review the talks proposed by the community,
> sort and organize them and then manage the conference program.
> 
> *Important note*: you need to be available during July and August as
> these are the months during which we set the program.

I'd like to be in the program committee this year again :-)

All the best,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: oox/source sw/qa

[Andras Timar]

 oox/source/export/shapes.cxx  |   18 ++
 sw/qa/extras/ooxmlexport/data/flip_and_rotate.odt |binary
 sw/qa/extras/ooxmlexport/ooxmlexport7.cxx |   19 +++
 3 files changed, 33 insertions(+), 4 deletions(-)

New commits:
commit bd36889b2caa4a74d647e18fc52e455f83529be9
Author: Andras Timar 
Date:   Fri Jan 29 16:42:31 2016 +0100

Improve DrawingML export of rotated/flipped customshapes

When we export the customshape as polypolygon, we need to
take into account, that the polypolygon of the shape already
has flipped coordinates, but coordinates has to be relative
to the rotated bounding rectangle.

Change-Id: I4f3b015e439d3d6041adc67eddd460f5bd4dfca1
Reviewed-on: https://gerrit.libreoffice.org/21905
Tested-by: Jenkins 
Reviewed-by: Andras Timar 

diff --git a/oox/source/export/shapes.cxx b/oox/source/export/shapes.cxx
index b4e7b13..f7e84db 100644
--- a/oox/source/export/shapes.cxx
+++ b/oox/source/export/shapes.cxx
@@ -713,9 +713,7 @@ ShapeExport& ShapeExport::WriteCustomShape( Reference< 
XShape > xShape )
 pFS->startElementNS( mnXmlNamespace, XML_spPr, FSEND );
 // moon is flipped in MSO, and mso-spt89 (right up arrow) is mapped to 
leftUpArrow
 if ( sShapeType == "moon" || sShapeType == "mso-spt89" )
-WriteShapeTransformation( xShape, XML_a, !bFlipH, bFlipV );
-else
-WriteShapeTransformation( xShape, XML_a, bFlipH, bFlipV );
+bFlipH = !bFlipH;
 
 // we export non-primitive shapes to custom geometry
 // we also export non-ooxml shapes which have handles/equations to custom 
geometry, because
@@ -736,14 +734,26 @@ ShapeExport& ShapeExport::WriteCustomShape( Reference< 
XShape > xShape )
 
 if (bHasHandles && bCustGeom && pShape)
 {
-WritePolyPolygon( tools::PolyPolygon( pShape->GetLineGeometry(true) ) 
);
+WriteShapeTransformation( xShape, XML_a ); // do not flip, polypolygon 
coordinates are flipped already
+tools::PolyPolygon aPolyPolygon( pShape->GetLineGeometry(true) );
+sal_Int32 nRotation = 0;
+// The RotateAngle property's value is independent from any flipping, 
and that's exactly what we need here.
+uno::Reference xPropertySet(xShape, 
uno::UNO_QUERY);
+uno::Reference xPropertySetInfo = 
xPropertySet->getPropertySetInfo();
+if (xPropertySetInfo->hasPropertyByName("RotateAngle"))
+xPropertySet->getPropertyValue("RotateAngle") >>= nRotation;
+if (nRotation != 0)
+aPolyPolygon.Rotate(Point(0,0), 
static_cast(3600-nRotation/10));
+WritePolyPolygon( aPolyPolygon );
 }
 else if (bCustGeom)
 {
+WriteShapeTransformation( xShape, XML_a, bFlipH, bFlipV );
 WriteCustomGeometry( xShape );
 }
 else // preset geometry
 {
+WriteShapeTransformation( xShape, XML_a, bFlipH, bFlipV );
 if( nAdjustmentValuesIndex != -1 )
 {
 sal_Int32 nAdjustmentsWhichNeedsToBeConverted = 0;
diff --git a/sw/qa/extras/ooxmlexport/data/flip_and_rotate.odt 
b/sw/qa/extras/ooxmlexport/data/flip_and_rotate.odt
new file mode 100644
index 000..4805bfa
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/flip_and_rotate.odt 
differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport7.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport7.cxx
index cfa1ddb..6463c80 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport7.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport7.cxx
@@ -1103,6 +1103,25 @@ DECLARE_OOXMLEXPORT_TEST(testTDF93675, 
"no-numlevel-but-indented.odt")
 assertXPath(pXmlDoc, "//w:ind", "start", "1418");
 }
 
+DECLARE_OOXMLEXPORT_TEST(testFlipAndRotateCustomShape, "flip_and_rotate.odt")
+{
+xmlDocPtr pXmlDoc = parseExport("word/document.xml");
+if (!pXmlDoc)
+return;
+// there should be no flipH and flipV attributes in this case
+assertXPathNoAttribute(pXmlDoc, "//a:xfrm", "flipH");
+assertXPathNoAttribute(pXmlDoc, "//a:xfrm", "flipV");
+// check rotation angle
+assertXPath(pXmlDoc, "//a:xfrm", "rot", "1350");
+// check the first few coordinates of the polygon
+assertXPath(pXmlDoc, "//a:custGeom/a:pathLst/a:path/a:lnTo[1]/a:pt", "x", 
"2351");
+assertXPath(pXmlDoc, "//a:custGeom/a:pathLst/a:path/a:lnTo[1]/a:pt", "y", 
"3171");
+assertXPath(pXmlDoc, "//a:custGeom/a:pathLst/a:path/a:lnTo[2]/a:pt", "x", 
"1695");
+assertXPath(pXmlDoc, "//a:custGeom/a:pathLst/a:path/a:lnTo[2]/a:pt", "y", 
"3171");
+assertXPath(pXmlDoc, "//a:custGeom/a:pathLst/a:path/a:lnTo[3]/a:pt", "x", 
"1695");
+assertXPath(pXmlDoc, "//a:custGeom/a:pathLst/a:path/a:lnTo[3]/a:pt", "y", 
"1701");
+}
+
 #endif
 
 CPPUNIT_PLUGIN_IMPLEMENT();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 5 commits - sc/qa sd/qa sw/qa vcl/headless

[Caolán McNamara]

 sc/qa/unit/data/xls/fail/EDB-39398-1.xlsx |binary
 sd/qa/unit/data/ppt/pass/EDB-39395-1.ppt  |binary
 sd/qa/unit/data/ppt/pass/EDB-39397-1.ppt  |binary
 sw/qa/core/data/ww8/pass/EDB-39396-1.doc  |binary
 vcl/headless/svpgdi.cxx   |   27 +++
 5 files changed, 7 insertions(+), 20 deletions(-)

New commits:
commit afcd01bdd9e90321bd42e6b5a513758386e4
Author: Caolán McNamara 
Date:   Wed Feb 3 09:52:38 2016 +

add EDB-39395-1 test-case

Change-Id: I3e611a3a647245d40ba808fdef7b64b877285fdc

diff --git a/sd/qa/unit/data/ppt/pass/EDB-39395-1.ppt 
b/sd/qa/unit/data/ppt/pass/EDB-39395-1.ppt
new file mode 100644
index 000..6404323
Binary files /dev/null and b/sd/qa/unit/data/ppt/pass/EDB-39395-1.ppt differ
commit 066e79288b6ad1afe5f896c4cd41e73d947bfee2
Author: Caolán McNamara 
Date:   Wed Feb 3 09:50:22 2016 +

add EDB-39396-1 test-case

Change-Id: I8afd1db3859b99cf09d0d52e999bbd95cd88ed10

diff --git a/sw/qa/core/data/ww8/pass/EDB-39396-1.doc 
b/sw/qa/core/data/ww8/pass/EDB-39396-1.doc
new file mode 100644
index 000..ae7c7ae
Binary files /dev/null and b/sw/qa/core/data/ww8/pass/EDB-39396-1.doc differ
commit eea4639dd70de591239e7fb12de7f9e347a5bc27
Author: Caolán McNamara 
Date:   Wed Feb 3 09:47:33 2016 +

add EDB-39397-1 test-case

Change-Id: I08b8d0247625745665aa9f048bf3fae028c7c36f

diff --git a/sd/qa/unit/data/ppt/pass/EDB-39397-1.ppt 
b/sd/qa/unit/data/ppt/pass/EDB-39397-1.ppt
new file mode 100644
index 000..091fb65
Binary files /dev/null and b/sd/qa/unit/data/ppt/pass/EDB-39397-1.ppt differ
commit 3b33d4fdffee687f8e087bfc78f12543d722ee0b
Author: Caolán McNamara 
Date:   Wed Feb 3 09:44:54 2016 +

add EDB-39398-1 test-case

Change-Id: I69ac97c391d1d4a1ec72751b3efdbdd68a2f6090

diff --git a/sc/qa/unit/data/xls/fail/EDB-39398-1.xlsx 
b/sc/qa/unit/data/xls/fail/EDB-39398-1.xlsx
new file mode 100644
index 000..dd0de64
Binary files /dev/null and b/sc/qa/unit/data/xls/fail/EDB-39398-1.xlsx differ
commit 6884f53ac490c11b98a77e747033f4971cc285f5
Author: Caolán McNamara 
Date:   Wed Feb 3 09:14:33 2016 +

default B2DRange ctor doesn't do what I thought it did

Change-Id: Idfe49de429c08d1dd7663ca3fcced8f326e46d15

diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index edd230d..bebf53e 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -337,7 +337,7 @@ bool SvpSalGraphics::drawAlphaRect(long nX, long nY, long 
nWidth, long nHeight,
 
 const double fTransparency = (100 - nTransparency) * (1.0/100);
 
-basegfx::B2DRange extents;
+basegfx::B2DRange extents(0, 0, 0, 0);
 
 cairo_rectangle(cr, nX, nY, nWidth, nHeight);
 
@@ -744,7 +744,7 @@ bool SvpSalGraphics::drawPolyLine(
 cairo_set_miter_limit(cr, 15.0);
 
 
-basegfx::B2DRange extents;
+basegfx::B2DRange extents(0, 0, 0, 0);
 
 if (!bNoJoin)
 {
@@ -824,7 +824,7 @@ bool SvpSalGraphics::drawPolyPolygon(const 
basegfx::B2DPolyPolygon& rPolyPoly, d
 
 setupPolyPolygon(cr, rPolyPoly);
 
-basegfx::B2DRange extents;
+basegfx::B2DRange extents(0, 0, 0, 0);
 
 if (m_aFillColor != SALCOLOR_NONE)
 {
@@ -879,7 +879,7 @@ void SvpSalGraphics::drawPolyPolygon(const 
basegfx::B2DPolyPolygon& rPolyPoly)
 
 setupPolyPolygon(cr, rPolyPoly);
 
-basegfx::B2DRange extents;
+basegfx::B2DRange extents(0, 0, 0, 0);
 
 if (m_aFillColor != SALCOLOR_NONE)
 {
@@ -1128,7 +1128,7 @@ void SvpSalGraphics::invert(const basegfx::B2DPolygon 
&rPoly, SalInvert nFlags)
 cairo_t* cr = getCairoContext(false);
 clipRegion(cr);
 
-basegfx::B2DRange extents;
+basegfx::B2DRange extents(0, 0, 0, 0);
 
 AddPolygonToPath(cr, rPoly, true, !getAntiAliasB2DDraw(), false);
 
@@ -1271,21 +1271,8 @@ cairo_user_data_key_t* SvpSalGraphics::getDamageKey()
 
 void SvpSalGraphics::releaseCairoContext(cairo_t* cr, bool bXorModeAllowed, 
const basegfx::B2DRange& rExtents) const
 {
-sal_Int32 nExtentsLeft;
-sal_Int32 nExtentsTop;
-sal_Int32 nExtentsRight;
-sal_Int32 nExtentsBottom;
-if (rExtents.isEmpty()) {
-nExtentsLeft = 0;
-nExtentsTop = 0;
-nExtentsRight = 0;
-nExtentsBottom = 0;
-} else {
-nExtentsLeft = rExtents.getMinX();
-nExtentsTop = rExtents.getMinY();
-nExtentsRight = rExtents.getMaxX();
-nExtentsBottom = rExtents.getMaxY();
-}
+sal_Int32 nExtentsLeft(rExtents.getMinX()), 
nExtentsTop(rExtents.getMinY());
+sal_Int32 nExtentsRight(rExtents.getMaxX()), 
nExtentsBottom(rExtents.getMaxY());
 sal_Int32 nWidth = cairo_image_surface_get_width(m_pSurface);
 sal_Int32 nHeight = cairo_image_surface_get_height(m_pSurface);
 nExtentsLeft = std::max(nExtentsLeft, 0);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commit

[Libreoffice-commits] core.git: sw/qa

[Varun Dhall]

 sw/qa/extras/uiwriter/uiwriter.cxx |   65 +
 1 file changed, 65 insertions(+)

New commits:
commit cdffa289a32ba21ee30906e1268ec5962f1d88d9
Author: Varun Dhall 
Date:   Mon Feb 1 17:38:41 2016 +0530

Added Test for checking newly created writer document with AppYield

Change-Id: If331fb2b0c03cd153387ddad7b33bbc28727ac11
Reviewed-on: https://gerrit.libreoffice.org/21995
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx 
b/sw/qa/extras/uiwriter/uiwriter.cxx
index 5d49784..53507f6 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -168,6 +168,7 @@ public:
 void testTextTableCellNames();
 void testShapeAnchorUndo();
 void testDde();
+void testDocModState();
 void testTdf94804();
 void testTdf34957();
 void testTdf89954();
@@ -255,6 +256,7 @@ public:
 CPPUNIT_TEST(testTextTableCellNames);
 CPPUNIT_TEST(testShapeAnchorUndo);
 CPPUNIT_TEST(testDde);
+CPPUNIT_TEST(testDocModState);
 CPPUNIT_TEST(testTdf94804);
 CPPUNIT_TEST(testTdf34957);
 CPPUNIT_TEST(testTdf89954);
@@ -2739,6 +2741,69 @@ void SwUiWriterTest::testDde()
 CPPUNIT_ASSERT(xField->getString().endsWith("asdf"));
 }
 
+//IdleTask class to add a low priority Idle task
+class IdleTask
+{
+public:
+bool GetFlag();
+IdleTask();
+DECL_LINK_TYPED( FlipFlag, Idle *, void );
+~IdleTask() {}
+private:
+bool flag;
+Idle maIdle;
+};
+
+//constructor of IdleTask Class
+IdleTask::IdleTask() : flag( false )
+{
+//setting the Priority of Idle task to LOW, LOWEST
+maIdle.SetPriority( SchedulerPriority::LOWEST );
+//set idle for callback
+maIdle.SetIdleHdl( LINK( this, IdleTask, FlipFlag) );
+//starting the idle
+maIdle.Start();
+}
+
+//GetFlag() of IdleTask Class
+bool IdleTask::GetFlag()
+{
+//returning the status of current flag
+return this->flag;
+}
+
+//Callback function of IdleTask Class
+IMPL_LINK_TYPED(IdleTask, FlipFlag, Idle*, , void)
+{
+//setting the flag to make sure that low priority idle task has been 
dispatched
+this->flag = true;
+}
+
+void SwUiWriterTest::testDocModState()
+{
+//creating a new writer document via the XDesktop(to have more shells etc.)
+SwDoc* pDoc = createDoc();
+//creating instance of IdleTask Class
+IdleTask idleTask;
+//checking the state of the document via IDocumentState
+IDocumentState& rState(pDoc->getIDocumentState());
+//the state should not be modified
+CPPUNIT_ASSERT(!(rState.IsModified()));
+//checking the state of the document via SfxObjectShell
+SwDocShell* pShell(pDoc->GetDocShell());
+CPPUNIT_ASSERT(!(pShell->IsModified()));
+//looping around yield until low priority idle task is dispatched and flag 
is flipped
+while(!idleTask.GetFlag())
+{
+//dispatching all the events via VCL main-loop
+Application::Yield();
+}
+//again checking for the state via IDocumentState
+CPPUNIT_ASSERT(!(rState.IsModified()));
+//again checking for the state via SfxObjectShell
+CPPUNIT_ASSERT(!(pShell->IsModified()));
+}
+
 void SwUiWriterTest::testTdf94804()
 {
 //create new writer document
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa

[Caolán McNamara]

 dev/null |binary
 sc/qa/unit/data/xls/fail/EDB-39398-1.xls |binary
 2 files changed

New commits:
commit b590d157645141f320f155b56ac915d72b2c4a46
Author: Caolán McNamara 
Date:   Wed Feb 3 10:10:05 2016 +

its an xls not an xlsx

Change-Id: I0d66e2714ce96555c3ea8c2c76c7f483ea69707e

diff --git a/sc/qa/unit/data/xls/fail/EDB-39398-1.xlsx 
b/sc/qa/unit/data/xls/fail/EDB-39398-1.xls
similarity index 100%
rename from sc/qa/unit/data/xls/fail/EDB-39398-1.xlsx
rename to sc/qa/unit/data/xls/fail/EDB-39398-1.xls
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - connectivity/inc connectivity/source extensions/source

[Michael Stahl]

 connectivity/inc/pch/precompiled_dbtools.hxx|1 -
 connectivity/source/parse/sqlnode.cxx   |3 +--
 extensions/source/propctrlr/standardcontrol.cxx |6 ++
 3 files changed, 3 insertions(+), 7 deletions(-)

New commits:
commit 8c279f01597cea9850ab68add6fa3370eb61c1b2
Author: Michael Stahl 
Date:   Tue Feb 2 15:47:41 2016 +0100

extensions: replace boost::bind with lambda

Change-Id: I3f0b1835aac20cfd1c149caa122bed1cc96d699e

diff --git a/extensions/source/propctrlr/standardcontrol.cxx 
b/extensions/source/propctrlr/standardcontrol.cxx
index f01e8f3..25e4bd4 100644
--- a/extensions/source/propctrlr/standardcontrol.cxx
+++ b/extensions/source/propctrlr/standardcontrol.cxx
@@ -48,7 +48,6 @@
 
 #include 
 #include 
-#include 
 #include 
 
 
@@ -464,9 +463,8 @@ namespace pcr
 {
 ActionEvent aEvent( *this, OUString( "clicked" ) );
 m_aActionListeners.forEach< XActionListener >(
-boost::bind(
-&XActionListener::actionPerformed,
-_1, boost::cref(aEvent) ) );
+[this, &aEvent] (uno::Reference const& 
xListener)
+{ return xListener->actionPerformed(aEvent); });
 }
 
 
commit bf253799f6858aa1ab607b8f127c0ed6bd2c1b45
Author: Michael Stahl 
Date:   Tue Feb 2 15:44:14 2016 +0100

connectivity: replace boost::bind with lambda

Change-Id: I5a68b743221a3519701e4e3778562ae626783e0f

diff --git a/connectivity/inc/pch/precompiled_dbtools.hxx 
b/connectivity/inc/pch/precompiled_dbtools.hxx
index 3babfec..31b04ad 100644
--- a/connectivity/inc/pch/precompiled_dbtools.hxx
+++ b/connectivity/inc/pch/precompiled_dbtools.hxx
@@ -37,7 +37,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/connectivity/source/parse/sqlnode.cxx 
b/connectivity/source/parse/sqlnode.cxx
index 7f7fdeb..7ba07e6 100644
--- a/connectivity/source/parse/sqlnode.cxx
+++ b/connectivity/source/parse/sqlnode.cxx
@@ -53,7 +53,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -713,7 +712,7 @@ void 
OSQLParseNode::impl_parseTableRangeNodeToString_throw(OUStringBuffer& rStri
 
 // rString += " ";
 ::std::for_each(m_aChildren.begin(),m_aChildren.end(),
-boost::bind( &OSQLParseNode::impl_parseNodeToString_throw, _1, 
boost::ref( rString ), boost::cref( rParam ), false ));
+[&] (OSQLParseNode *const pNode) { 
pNode->impl_parseNodeToString_throw(rString, rParam, false); });
 }
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/milestone-7' - loleaflet/reference.html loleaflet/src loolwsd/bundled loolwsd/LOKitClient.cpp loolwsd/LOOLSession.cpp loolwsd/protocol.txt

[Jan Holesovsky]

 loleaflet/reference.html |4 +++
 loleaflet/src/core/Socket.js |3 ++
 loleaflet/src/layer/tile/TileLayer.js|9 ++-
 loolwsd/LOKitClient.cpp  |1 
 loolwsd/LOOLSession.cpp  |   10 +++
 loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKitEnums.h |   14 +++
 loolwsd/protocol.txt |5 +++
 7 files changed, 44 insertions(+), 2 deletions(-)

New commits:
commit de0a21e9fddefba7d5591e5aedee561fe5448229
Author: Jan Holesovsky 
Date:   Wed Feb 3 11:15:07 2016 +0100

loolwsd, loleaflet: Handle the ERROR callback.

This introduces a new error id 5 - "document save failed".

diff --git a/loleaflet/reference.html b/loleaflet/reference.html
index 4724e54..bae4e86 100644
--- a/loleaflet/reference.html
+++ b/loleaflet/reference.html
@@ -2105,6 +2105,10 @@ The id property of ErrorEvent can have the 
following values:
4
Socket connection was closed.

+   
+   5
+   Document couldn't be saved.
+   
 
 
 HyperlinkClickedEvent
diff --git a/loleaflet/src/core/Socket.js b/loleaflet/src/core/Socket.js
index 7499773..7efcaed 100644
--- a/loleaflet/src/core/Socket.js
+++ b/loleaflet/src/core/Socket.js
@@ -220,6 +220,9 @@ L.Socket = L.Class.extend({
else if (tokens[i].substring(0, 4) === 'cmd=') {
command.errorCmd = tokens[i].substring(4);
}
+   else if (tokens[i].substring(0, 5) === 'code=') {
+   command.errorCode = tokens[i].substring(5);
+   }
else if (tokens[i].substring(0, 5) === 'kind=') {
command.errorKind = tokens[i].substring(5);
}
diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index 220efc8..f776337 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -393,8 +393,15 @@ L.TileLayer = L.GridLayer.extend({
if (command.errorCmd === 'load') {
errorId = 2; // document cannot be loaded
}
+   else if (command.errorCmd === 'save') {
+   errorId = 5; // document cannot be saved
+   }
+
+   var errorCode = -1;
+   if (command.errorCode !== undefined)
+   errorCode = command.errorCode;
 
-   this._map.fire('error', {cmd: command.errorCmd, kind: 
command.errorKind, id: errorId});
+   this._map.fire('error', {cmd: command.errorCmd, kind: 
command.errorKind, id: errorId, code: errorCode});
},
 
_onGetChildIdMsg: function (textMsg) {
diff --git a/loolwsd/LOKitClient.cpp b/loolwsd/LOKitClient.cpp
index 58c7e78..9542942 100644
--- a/loolwsd/LOKitClient.cpp
+++ b/loolwsd/LOKitClient.cpp
@@ -66,6 +66,7 @@ extern "C"
 CASE(UNO_COMMAND_RESULT);
 CASE(DOCUMENT_PASSWORD);
 CASE(DOCUMENT_PASSWORD_TO_MODIFY);
+CASE(ERROR);
 #undef CASE
 }
 std::cout << " payload: " << pPayload << std::endl;
diff --git a/loolwsd/LOOLSession.cpp b/loolwsd/LOOLSession.cpp
index 8643196..cce38df 100644
--- a/loolwsd/LOOLSession.cpp
+++ b/loolwsd/LOOLSession.cpp
@@ -1075,6 +1075,16 @@ extern "C"
 break;
 case LOK_CALLBACK_DOCUMENT_PASSWORD_TO_MODIFY:
 break;
+case LOK_CALLBACK_ERROR:
+{
+Poco::JSON::Parser parser;
+Poco::Dynamic::Var var = parser.parse(pPayload);
+Poco::JSON::Object::Ptr object = 
var.extract();
+
+srv->sendTextFrame("error: cmd=" + 
object->get("cmd").toString() +
+" kind=" + object->get("kind").toString() + " code=" + 
object->get("code").toString());
+}
+break;
 }
 }
 }
diff --git a/loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKitEnums.h 
b/loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKitEnums.h
index b615bd9..5ce8610 100644
--- a/loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKitEnums.h
+++ b/loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKitEnums.h
@@ -265,6 +265,20 @@ typedef enum
  * lok::Office::setDocumentPassword().
  */
 LOK_CALLBACK_DOCUMENT_PASSWORD_TO_MODIFY,
+
+/**
+ * An error happened.
+ *
+ * The payload returns information further identifying the error, like:
+ *
+ * {
+ * "classification": "error" | "warning" | "info"
+ * "kind": "network" etc.
+ * "code": 403 | 404 | ...
+ * "message": freeform description
+ * }
+ */
+LOK_CALLBACK_ERROR,
 }
 LibreOfficeKitCallbackType;
 
diff --git a/loolwsd/pro

[Libreoffice-commits] core.git: chart2/source

[Chris Sherlock]

 chart2/source/view/main/3DChartObjects.cxx |6 +-
 1 file changed, 1 insertion(+), 5 deletions(-)

New commits:
commit f16433ec2cba13b78022f1bf6e78bcf26fb22be8
Author: Chris Sherlock 
Date:   Wed Feb 3 21:23:41 2016 +1100

chart2: I think we can get rid of OLDRENDER now

Change-Id: I4919d4a75bdd7dc0398f5829a25f2908e97b0eaf

diff --git a/chart2/source/view/main/3DChartObjects.cxx 
b/chart2/source/view/main/3DChartObjects.cxx
index 56cc323..1a7c500 100644
--- a/chart2/source/view/main/3DChartObjects.cxx
+++ b/chart2/source/view/main/3DChartObjects.cxx
@@ -84,11 +84,7 @@ const TextCacheItem& TextCache::getText(OUString const & 
rText, bool bIs3dText)
 else
 aFont = pDevice->GetFont();
 aFont.SetSize(Size(0, 96));
-static bool bOldRender = getenv("OLDRENDER");
-if (bOldRender)
-aFont.SetColor(COL_BLACK);
-else
-aFont.SetColor(COL_GREEN); // RGB_COLORDATA(0xf0, 0xf0, 0xf0));
+aFont.SetColor(COL_GREEN); // RGB_COLORDATA(0xf0, 0xf0, 0xf0));
 pDevice->SetFont(aFont);
 pDevice->Erase();
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/reference.html loleaflet/src loolwsd/bundled loolwsd/ChildProcessSession.cpp loolwsd/LOKitClient.cpp loolwsd/protocol.txt

[Jan Holesovsky]

 loleaflet/reference.html |4 +++
 loleaflet/src/core/Socket.js |3 ++
 loleaflet/src/layer/tile/TileLayer.js|9 ++-
 loolwsd/ChildProcessSession.cpp  |   10 +++
 loolwsd/LOKitClient.cpp  |1 
 loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKitEnums.h |   14 +++
 loolwsd/protocol.txt |5 +++
 7 files changed, 44 insertions(+), 2 deletions(-)

New commits:
commit 32ecdb8ab6d28d6e86c6281cfe8cac3ca79fb149
Author: Jan Holesovsky 
Date:   Wed Feb 3 11:15:07 2016 +0100

loolwsd, loleaflet: Handle the ERROR callback.

This introduces a new error id 5 - "document save failed".

diff --git a/loleaflet/reference.html b/loleaflet/reference.html
index 4724e54..bae4e86 100644
--- a/loleaflet/reference.html
+++ b/loleaflet/reference.html
@@ -2105,6 +2105,10 @@ The id property of ErrorEvent can have the 
following values:
4
Socket connection was closed.

+   
+   5
+   Document couldn't be saved.
+   
 
 
 HyperlinkClickedEvent
diff --git a/loleaflet/src/core/Socket.js b/loleaflet/src/core/Socket.js
index cbfb87c..38895ce 100644
--- a/loleaflet/src/core/Socket.js
+++ b/loleaflet/src/core/Socket.js
@@ -236,6 +236,9 @@ L.Socket = L.Class.extend({
else if (tokens[i].substring(0, 4) === 'cmd=') {
command.errorCmd = tokens[i].substring(4);
}
+   else if (tokens[i].substring(0, 5) === 'code=') {
+   command.errorCode = tokens[i].substring(5);
+   }
else if (tokens[i].substring(0, 5) === 'kind=') {
command.errorKind = tokens[i].substring(5);
}
diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index 220efc8..f776337 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -393,8 +393,15 @@ L.TileLayer = L.GridLayer.extend({
if (command.errorCmd === 'load') {
errorId = 2; // document cannot be loaded
}
+   else if (command.errorCmd === 'save') {
+   errorId = 5; // document cannot be saved
+   }
+
+   var errorCode = -1;
+   if (command.errorCode !== undefined)
+   errorCode = command.errorCode;
 
-   this._map.fire('error', {cmd: command.errorCmd, kind: 
command.errorKind, id: errorId});
+   this._map.fire('error', {cmd: command.errorCmd, kind: 
command.errorKind, id: errorId, code: errorCode});
},
 
_onGetChildIdMsg: function (textMsg) {
diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index 2ebe1ff..5933856 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -246,6 +246,16 @@ public:
 break;
 case LOK_CALLBACK_DOCUMENT_PASSWORD_TO_MODIFY:
 break;
+case LOK_CALLBACK_ERROR:
+{
+Poco::JSON::Parser parser;
+Poco::Dynamic::Var var = parser.parse(rPayload);
+Poco::JSON::Object::Ptr object = 
var.extract();
+
+_session.sendTextFrame("error: cmd=" + 
object->get("cmd").toString() +
+" kind=" + object->get("kind").toString() + " code=" + 
object->get("code").toString());
+}
+break;
 }
 }
 
diff --git a/loolwsd/LOKitClient.cpp b/loolwsd/LOKitClient.cpp
index f46136d..0d94115 100644
--- a/loolwsd/LOKitClient.cpp
+++ b/loolwsd/LOKitClient.cpp
@@ -66,6 +66,7 @@ extern "C"
 CASE(UNO_COMMAND_RESULT);
 CASE(DOCUMENT_PASSWORD);
 CASE(DOCUMENT_PASSWORD_TO_MODIFY);
+CASE(ERROR);
 #undef CASE
 }
 std::cout << " payload: " << pPayload << std::endl;
diff --git a/loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKitEnums.h 
b/loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKitEnums.h
index b615bd9..5ce8610 100644
--- a/loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKitEnums.h
+++ b/loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKitEnums.h
@@ -265,6 +265,20 @@ typedef enum
  * lok::Office::setDocumentPassword().
  */
 LOK_CALLBACK_DOCUMENT_PASSWORD_TO_MODIFY,
+
+/**
+ * An error happened.
+ *
+ * The payload returns information further identifying the error, like:
+ *
+ * {
+ * "classification": "error" | "warning" | "info"
+ * "kind": "network" etc.
+ * "code": 403 | 404 | ...
+ * "message": freeform description
+ * }
+ */
+LOK_CALLBACK_ERROR,
 }
 LibreOfficeKitCallbackTy

[Libreoffice-commits] core.git: chart2/source

[Chris Sherlock]

 chart2/source/view/main/3DChartObjects.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit bb65881c20c5ab0f60f658b152539fc7ab49666c
Author: Chris Sherlock 
Date:   Wed Feb 3 21:27:31 2016 +1100

chart2: remove commented out code

Change-Id: Ie69dcec1431b6cbbaccfa7d92f17166d2f43c69a

diff --git a/chart2/source/view/main/3DChartObjects.cxx 
b/chart2/source/view/main/3DChartObjects.cxx
index 1a7c500..74856d5 100644
--- a/chart2/source/view/main/3DChartObjects.cxx
+++ b/chart2/source/view/main/3DChartObjects.cxx
@@ -93,7 +93,6 @@ const TextCacheItem& TextCache::getText(OUString const & 
rText, bool bIs3dText)
 pDevice->DrawText(Point(0,0), rText);
 
 BitmapEx aText(pDevice->GetBitmapEx(Point(0,0), pDevice->GetOutputSize()));
-//TextCacheItem *pItem = new 
TextCacheItem(OpenGLHelper::ConvertBitmapExToRGBABuffer(aText), 
aText.GetSizePixel());
 Bitmap aBitmap (aText.GetBitmap());
 BitmapReadAccess *pAcc = aBitmap.AcquireReadAccess();
 sal_uInt8 *buf = reinterpret_cast(pAcc->GetBuffer());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: DPI and screen resolution on OS X

[Chris Sherlock]

On 3 Feb 2016, at 7:24 PM, SOS  wrote:
> 
> 
> On 3/02/2016 3:55, Kohei Yoshida wrote:
>> On Wed, 2016-02-03 at 10:52 +1100, Chris Sherlock wrote:
>>> The other question is: why would we not want to the actual DPI and
>>> screen resolution?
>> My understanding is that, historically, the OS provided a function to
>> query DPI but what gets returned from such function was not always
>> accurate (or always not accurate depending on who you ask).  So, the
>> workaround at the time was to assume that DPI is always 96 (and
>> hard-code that value) regardless of what the OS told you, which worked
>> just fine because the monitors used back in the day had the same screen
>> resolution.
> Mostly DPI is found in the header of a pixelfile (taken by camera). 
> Unfortunately it's not the photographer who gets to decide about the needed 
> DPI.
> DPI is actually a wrong definition for documents, Dots Per Inch is a 
> definition used by output devices. Screens need a PIXEL par DOT but for print 
> devices there is no precise correlation between the number of dots used by 
> the device and the pixels needed in  the image for having a maximum 
> image-view quality.
> The print industry has come to some standards by trial and error.
> - monitor screens need 96 - (220-retina) pixels per inch
> - laser printers need 150 pixels per inch (up tot 2000 + dots)
> - offset printers need 254 -300 pixels per inch (up to 3000 dots)

Definitely true :-) Only in OS X’s case, it doesn’t actually report back the 
correct resolution unless you ask for the backing coordinate system. 

The PPI business is a red herring I think I’ve introduced into this discussion 
I’m afraid. We calculate the PPI ourselves (and call it DPI) based on the 
reported pixels, and the size of the screen in mm (which we obviously convert 
to inches). 

I guess I’m curious as to what is relying on the screen resolution and PPI. 

Although… it’s funny that we have the function SalGraphics::GetResolution, but 
that returns the PPI!

Chris
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.0' - 2 commits - desktop/source include/LibreOfficeKit libreofficekit/source

[Jan Holesovsky]

 desktop/source/lib/init.cxx  |   39 ++-
 desktop/source/lib/lokinteractionhandler.cxx |  284 +--
 desktop/source/lib/lokinteractionhandler.hxx |   33 ++-
 include/LibreOfficeKit/LibreOfficeKitEnums.h |   14 +
 libreofficekit/source/gtk/lokdocview.cxx |   21 +
 5 files changed, 313 insertions(+), 78 deletions(-)

New commits:
commit 64c1690fa31937bb4adfe0eb7beb42f105841c3b
Author: Jan Holesovsky 
Date:   Tue Feb 2 22:59:34 2016 +0100

lok interaction handler: Add handling of io and network errors.

Change-Id: If7c84a7b24f2072439718fb0c473b73243f2ecc1

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 0fbece0..c4d4450 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -271,7 +271,7 @@ static OUString getAbsoluteURL(const char* pURL)
 return OUString();
 }
 
-static void jsonToPropertyValues(const char* pJSON, 
uno::Sequence& rPropertyValues)
+static std::vector jsonToPropertyValuesVector(const 
char* pJSON)
 {
 std::vector aArguments;
 if (pJSON)
@@ -298,11 +298,11 @@ static void jsonToPropertyValues(const char* pJSON, 
uno::Sequence(OString(rValue.c_str()).toUInt32());
 else
-SAL_WARN("desktop.lib", "jsonToPropertyValues: unhandled type 
'"< const pInteraction(
-new 
LOKInteractionHandler(::comphelper::getProcessComponentContext(), pLib));
+new 
LOKInteractionHandler(::comphelper::getProcessComponentContext(), "load", 
pLib));
 auto const 
pair(pLib->mInteractionMap.insert(std::make_pair(aURL.toUtf8(), pInteraction)));
 uno::Reference const 
xInteraction(pInteraction.get());
 aFilterOptions[1].Name = "InteractionHandler";
@@ -1034,9 +1034,9 @@ static void 
doc_initializeForRendering(LibreOfficeKitDocument* pThis,
 if (pDoc)
 {
 doc_iniUnoCommands();
-uno::Sequence aPropertyValues;
-jsonToPropertyValues(pArguments, aPropertyValues);
-pDoc->initializeForTiledRendering(aPropertyValues);
+
+pDoc->initializeForTiledRendering(
+
comphelper::containerToSequence(jsonToPropertyValuesVector(pArguments)));
 }
 }
 
@@ -1126,20 +1126,33 @@ public:
 static void doc_postUnoCommand(LibreOfficeKitDocument* pThis, const char* 
pCommand, const char* pArguments, bool bNotifyWhenFinished)
 {
 OUString aCommand(pCommand, strlen(pCommand), RTL_TEXTENCODING_UTF8);
+LibLODocument_Impl* pDocument = static_cast(pThis);
 
-uno::Sequence aPropertyValues;
-jsonToPropertyValues(pArguments, aPropertyValues);
-bool bResult = false;
+std::vector 
aPropertyValuesVector(jsonToPropertyValuesVector(pArguments));
 
-LibLODocument_Impl* pDocument = static_cast(pThis);
+// handle potential interaction
+if (aCommand == ".uno:Save")
+{
+rtl::Reference const pInteraction(
+new 
LOKInteractionHandler(::comphelper::getProcessComponentContext(), "save", 
gImpl, pDocument));
+uno::Reference const 
xInteraction(pInteraction.get());
+
+beans::PropertyValue aValue;
+aValue.Name = "InteractionHandler";
+aValue.Value <<= xInteraction;
+
+aPropertyValuesVector.push_back(aValue);
+}
+
+bool bResult = false;
 
 if (bNotifyWhenFinished && pDocument->mpCallback)
 {
-bResult = comphelper::dispatchCommand(aCommand, aPropertyValues,
+bResult = comphelper::dispatchCommand(aCommand, 
comphelper::containerToSequence(aPropertyValuesVector),
 new DispatchResultListener(pCommand, pDocument->mpCallback, 
pDocument->mpCallbackData));
 }
 else
-bResult = comphelper::dispatchCommand(aCommand, aPropertyValues);
+bResult = comphelper::dispatchCommand(aCommand, 
comphelper::containerToSequence(aPropertyValuesVector));
 
 if (!bResult)
 {
diff --git a/desktop/source/lib/lokinteractionhandler.cxx 
b/desktop/source/lib/lokinteractionhandler.cxx
index 86f521e..a4a60c2 100644
--- a/desktop/source/lib/lokinteractionhandler.cxx
+++ b/desktop/source/lib/lokinteractionhandler.cxx
@@ -19,12 +19,21 @@
 
 #include "lokinteractionhandler.hxx"
 
+#include 
+
 #include 
 #include 
 
 #include 
 #include 
 #include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
 
 #define LOK_USE_UNSTABLE_API
 #include <../../inc/lib/init.hxx>
@@ -35,8 +44,12 @@ using namespace com::sun::star;
 
 LOKInteractionHandler::LOKInteractionHandler(
 uno::Reference const & /*rxContext*/,
-desktop::LibLibreOffice_Impl *const pLOKit)
+const OString& rCommand,
+desktop::LibLibreOffice_Impl *const pLOKit,
+desktop::LibLODocument_Impl *const pLOKDocument)
 : m_pLOKit(pLOKit)
+, m_pLOKDocument(pLOKDocument)
+, m_command(rCommand)
 , m_usePassword(false)
 {
 assert(m_pLOKit);
@@ -79,8 +92,157 @@ throw (uno::RuntimeException, std::exception)
 handleInteractionRequest(xRequest);
 }
 
-sal_Bool LOKInteracti

[Libreoffice-commits] help.git: source/text

[Adolfo Jayme Barrientos]

 source/text/shared/01/0211.xhp  |6 +++---
 source/text/swriter/01/0211.xhp |4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit 5290d2a3f4df1fb63171b37352dc4ac59a9acf10
Author: Adolfo Jayme Barrientos 
Date:   Wed Feb 3 04:32:19 2016 -0600

tdf#95408 Update this button’s name in Help as well

Change-Id: I0810e767247745dcb1cf922301be1705479f9dbd

diff --git a/source/text/shared/01/0211.xhp 
b/source/text/shared/01/0211.xhp
index 7e120a7..0ea745b 100644
--- a/source/text/shared/01/0211.xhp
+++ b/source/text/shared/01/0211.xhp
@@ -33,7 +33,7 @@
 
 The Navigator lists the 
main components of the master document. If you rest the mouse pointer over a 
name of a sub-document in the list, the full path of the sub-document is 
displayed.
   The master view in the Navigator displays the following 
icons:
-  Toggle
+  Toggle Master View
   Switches between master view and normal view.
   
  
@@ -43,7 +43,7 @@

 
 
-   Toggle
+   Toggle Master View
 
  
   
@@ -194,4 +194,4 @@
  oldref="26">Delete
   Deletes the selection from the 
Navigator list.

-
\ No newline at end of file
+
diff --git a/source/text/swriter/01/0211.xhp 
b/source/text/swriter/01/0211.xhp
index efc9e6b..be2fca6 100644
--- a/source/text/swriter/01/0211.xhp
+++ b/source/text/swriter/01/0211.xhp
@@ -40,7 +40,7 @@
 To jump to the next or previous item in a document, click the Navigation icon to 
open the Navigation toolbar, click the item category, and then click the up or 
down arrows.
 A hidden section in a document appears gray in the Navigator, and 
displays the text "hidden" when you rest the mouse pointer over it. The same 
applies to header and footer contents of Page Styles that are not used in a 
document, and hidden contents in tables, text frames, graphics, OLE objects, 
and indexes.
 
-Toggle
+Toggle Master View
 Switches between master view and 
normal view if a master document is open. Switches between master view and 
normal view if a master document is open.
 
 
@@ -50,7 +50,7 @@

 
 
-Toggle
+Toggle Master View
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Adolfo Jayme Barrientos]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b4dc15e72e6c8925fb607558d5005a9c684e420d
Author: Adolfo Jayme Barrientos 
Date:   Wed Feb 3 04:32:19 2016 -0600

Updated core
Project: help  5290d2a3f4df1fb63171b37352dc4ac59a9acf10

tdf#95408 Update this button’s name in Help as well

Change-Id: I0810e767247745dcb1cf922301be1705479f9dbd

diff --git a/helpcontent2 b/helpcontent2
index a6b267e..5290d2a 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit a6b267eeb607461fe440a5195af522c0ac057555
+Subproject commit 5290d2a3f4df1fb63171b37352dc4ac59a9acf10
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sax/source

[Caolán McNamara]

 sax/source/tools/converter.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit b9fa2963cf12e6987b3a0acc219c4fa591e41be8
Author: Caolán McNamara 
Date:   Wed Feb 3 10:30:43 2016 +

fix gcc build error

error: invalid operands of types '__gnu_cxx::__enable_if::__type
{aka double}' and 'int' to binary 'operator%'

apparently there's a template returning double for abs for the
non-int/long/float/double argument case. So promote earlier to int so the
abs is called

Change-Id: I882a27c5ec349f894c1c9f4857687360a46b55ae

diff --git a/sax/source/tools/converter.cxx b/sax/source/tools/converter.cxx
index 744415e..cf061c9 100644
--- a/sax/source/tools/converter.cxx
+++ b/sax/source/tools/converter.cxx
@@ -1250,7 +1250,7 @@ bool Converter::convertDuration(util::Duration& rDuration,
 
 
 static void
-lcl_AppendTimezone(OUStringBuffer & i_rBuffer, sal_Int16 const nOffset)
+lcl_AppendTimezone(OUStringBuffer & i_rBuffer, int const nOffset)
 {
 if (0 == nOffset)
 {
@@ -1435,7 +1435,7 @@ lcl_MaxDaysPerMonth(const sal_Int32 nMonth, const 
sal_Int32 nYear)
 static void lcl_ConvertToUTC(
 sal_Int16 & o_rYear, sal_uInt16 & o_rMonth, sal_uInt16 & o_rDay,
 sal_uInt16 & o_rHours, sal_uInt16 & o_rMinutes,
-sal_Int16 const nSourceOffset)
+int const nSourceOffset)
 {
 sal_Int16 nOffsetHours(abs(nSourceOffset) / 60);
 sal_Int16 const nOffsetMinutes(abs(nSourceOffset) % 60);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 95408] "Toggle" in Writer Navigator should be more explicit in what it toggles

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95408

--- Comment #4 from Commit Notification 
 ---
Adolfo Jayme Barrientos committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/help/commit/?id=5290d2a3f4df1fb63171b37352dc4ac59a9acf10

tdf#95408 Update this button’s name in Help as well

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: desktop/source

[Michael Stahl]

 desktop/source/lib/lokinteractionhandler.cxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 85e6cc898c5d5a1d5d60897bef31da9f46b22686
Author: Michael Stahl 
Date:   Wed Feb 3 11:38:10 2016 +0100

libreofficekit: CppunitTest_libreofficekit_tiledrendering crashes

Need to check that a callback was actually set before calling it.

Change-Id: Icb2ca19aec0c74f6695d7286f046dadfe609d68c

diff --git a/desktop/source/lib/lokinteractionhandler.cxx 
b/desktop/source/lib/lokinteractionhandler.cxx
index bb287ff..df8345c 100644
--- a/desktop/source/lib/lokinteractionhandler.cxx
+++ b/desktop/source/lib/lokinteractionhandler.cxx
@@ -114,9 +114,9 @@ void 
LOKInteractionHandler::postError(css::task::InteractionClassification class
 std::stringstream aStream;
 boost::property_tree::write_json(aStream, aTree);
 
-if (m_pLOKDocument)
+if (m_pLOKDocument && m_pLOKDocument->mpCallback)
 m_pLOKDocument->mpCallback(LOK_CALLBACK_ERROR, aStream.str().c_str(), 
m_pLOKDocument->mpCallbackData);
-else
+else if (m_pLOKit->mpCallback)
 m_pLOKit->mpCallback(LOK_CALLBACK_ERROR, aStream.str().c_str(), 
m_pLOKit->mpCallbackData);
 }
 
@@ -242,7 +242,8 @@ bool LOKInteractionHandler::handlePasswordRequest(const 
uno::Sequence>= passwordRequest))
 return false;
 
-if 
(m_pLOKit->hasOptionalFeature((passwordRequest.IsRequestPasswordToModify)
+if (m_pLOKit->mpCallback &&
+
m_pLOKit->hasOptionalFeature((passwordRequest.IsRequestPasswordToModify)
 ? LOK_FEATURE_DOCUMENT_PASSWORD_TO_MODIFY
 : LOK_FEATURE_DOCUMENT_PASSWORD))
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 96132] Enabling Experimental Features in the UI doesn't inform the user that LibO needs to be restarted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96132

--- Comment #6 from Cor Nouws  ---
(In reply to Markus Mohrhard (retired) from comment #5)

> There are many experimental features that work without a restart.

To be honest: I wouldn't be able (without searching) to point to the list of
those features...

> The better
> question is which ones don't and then check if they can't be made to work
> without it. Especially as we now have a configuration change listener.

Sure.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: desktop/inc desktop/source include/vcl

[Michael Stahl]

 desktop/inc/pch/precompiled_deployment.hxx|1 -
 desktop/inc/pch/precompiled_deploymentgui.hxx |1 -
 desktop/source/deployment/gui/license_dialog.cxx  |5 +++--
 desktop/source/deployment/gui/license_dialog.hxx  |1 -
 desktop/source/deployment/manager/dp_extensionmanager.cxx |5 ++---
 desktop/source/deployment/manager/dp_manager.cxx  |   10 +-
 include/vcl/threadex.hxx  |4 
 7 files changed, 14 insertions(+), 13 deletions(-)

New commits:
commit e9089b4f53c0fef5d0bdcc76add9a43a8c6d81bd
Author: Michael Stahl 
Date:   Tue Feb 2 15:40:33 2016 +0100

desktop: replace boost::bind with lambda or std::bind

This requires working around MSVC 2013 error C3848, that compiler
apparently just doesn't like to call its std::bind() functions if
they're "const".

Change-Id: Ic2e66cab3cadb36ab29cf2504a4c6107334f2ae1

diff --git a/desktop/inc/pch/precompiled_deployment.hxx 
b/desktop/inc/pch/precompiled_deployment.hxx
index 0b60d8b..925f79c 100644
--- a/desktop/inc/pch/precompiled_deployment.hxx
+++ b/desktop/inc/pch/precompiled_deployment.hxx
@@ -27,7 +27,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/desktop/inc/pch/precompiled_deploymentgui.hxx 
b/desktop/inc/pch/precompiled_deploymentgui.hxx
index 23c501f..7664dd2 100644
--- a/desktop/inc/pch/precompiled_deploymentgui.hxx
+++ b/desktop/inc/pch/precompiled_deploymentgui.hxx
@@ -33,7 +33,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/desktop/source/deployment/gui/license_dialog.cxx 
b/desktop/source/deployment/gui/license_dialog.cxx
index ec47151..0932782 100644
--- a/desktop/source/deployment/gui/license_dialog.cxx
+++ b/desktop/source/deployment/gui/license_dialog.cxx
@@ -35,11 +35,12 @@
 #include 
 #include 
 
-#include 
 #include "dp_gui_shared.hxx"
 #include "license_dialog.hxx"
 #include "dp_gui.hrc"
 
+#include 
+
 using namespace ::dp_misc;
 namespace cssu = ::com::sun::star::uno;
 using namespace ::com::sun::star;
@@ -311,7 +312,7 @@ void LicenseDialog::setTitle( OUString const & ) throw 
(RuntimeException, std::e
 sal_Int16 LicenseDialog::execute() throw (RuntimeException, std::exception)
 {
 return vcl::solarthread::syncExecute(
-boost::bind( &LicenseDialog::solar_execute, this));
+std::bind(&LicenseDialog::solar_execute, this));
 }
 
 sal_Int16 LicenseDialog::solar_execute()
diff --git a/desktop/source/deployment/gui/license_dialog.hxx 
b/desktop/source/deployment/gui/license_dialog.hxx
index f5646c9..11eab9d 100644
--- a/desktop/source/deployment/gui/license_dialog.hxx
+++ b/desktop/source/deployment/gui/license_dialog.hxx
@@ -24,7 +24,6 @@
 #include 
 #include 
 
-#include 
 
 namespace dp_gui {
 
diff --git a/desktop/source/deployment/manager/dp_extensionmanager.cxx 
b/desktop/source/deployment/manager/dp_extensionmanager.cxx
index 58aadbb..3d5000d 100644
--- a/desktop/source/deployment/manager/dp_extensionmanager.cxx
+++ b/desktop/source/deployment/manager/dp_extensionmanager.cxx
@@ -51,7 +51,6 @@
 #include "dp_extensionmanager.hxx"
 #include "dp_commandenvironments.hxx"
 #include "dp_properties.hxx"
-#include 
 
 #include 
 #include 
@@ -1495,8 +1494,8 @@ void ExtensionManager::fireModified()
 cppu::UnoType::get() );
 if (pContainer != nullptr) {
 pContainer->forEach(
-boost::bind(&util::XModifyListener::modified, _1,
-lang::EventObject(static_cast(this))) );
+[this] (uno::Reference const& xListener)
+{ return 
xListener->modified(lang::EventObject(static_cast(this))); });
 }
 }
 
diff --git a/desktop/source/deployment/manager/dp_manager.cxx 
b/desktop/source/deployment/manager/dp_manager.cxx
index 0c87238..2db22a5 100644
--- a/desktop/source/deployment/manager/dp_manager.cxx
+++ b/desktop/source/deployment/manager/dp_manager.cxx
@@ -54,14 +54,14 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 
-#include 
-#include 
 #include "dp_descriptioninfoset.hxx"
 #include "dp_commandenvironments.hxx"
 #include "dp_properties.hxx"
+
+#include 
+#include 
 #include 
 
 using namespace ::dp_misc;
@@ -431,8 +431,8 @@ void PackageManagerImpl::fireModified()
 cppu::UnoType::get() );
 if (pContainer != nullptr) {
 pContainer->forEach(
-boost::bind(&util::XModifyListener::modified, _1,
-lang::EventObject(static_cast(this))) );
+[this] (uno::Reference const& xListener)
+{ return 
xListener->modified(lang::EventObject(static_cast(this))); });
 }
 }
 
diff --git a/include/vcl/threadex.hxx b/include/vcl/threadex.hxx
index 47c1c44..358f1ca 100644
--- a/include/vcl/threadex.hxx
+++ b/include/vcl/threadex.hxx
@@ -87,7 +87,11 @@ private:
 }
 
 css::uno::Any m_exc;
+#ifdef _MSC_VER
+FuncT m_func; // "const" and std::bind() resu

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.0' - sc/source sd/source sw/source

[Jan Holesovsky]

 sc/source/ui/unoobj/docuno.cxx|7 +++
 sd/source/ui/unoidl/unomodel.cxx  |7 +++
 sw/source/uibase/uno/unotxdoc.cxx |7 +++
 3 files changed, 21 insertions(+)

New commits:
commit 9b5f1a79f52b3d541a978f117548e255febf39d4
Author: Jan Holesovsky 
Date:   Wed Feb 3 11:59:04 2016 +0100

lok: Avoid the 'alien format' warning in LibreOfficeKit.

We immediately cancel all the dialogs that potentially come up when using
LibreOfficeKit; which means that when you tried to save a .docx to a remote
server (which triggered the 'alien format' warning), the save operation
couldn't be completed.

Change-Id: I6bb5eadac994c1f515d7a49299c21960b3491bbe

diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx
index 891c69d..072923f 100644
--- a/sc/source/ui/unoobj/docuno.cxx
+++ b/sc/source/ui/unoobj/docuno.cxx
@@ -45,6 +45,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -933,6 +934,12 @@ void ScModelObj::initializeForTiledRendering(const 
css::uno::Sequence
 #include 
 #include 
+#include 
 
 // Support creation of GraphicObjectResolver and EmbeddedObjectResolver
 #include 
@@ -2406,6 +2407,12 @@ void 
SdXImpressDocument::initializeForTiledRendering(const css::uno::Sequence
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -3299,6 +3300,12 @@ void SwXTextDocument::initializeForTiledRendering(const 
css::uno::Sequencehttp://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [libreoffice-projects] Program Committee for LibOCon

[Marina Latini]

Il 02.02.2016 11:49 Sophie ha scritto:

Hi all,



Hi Sophie


As each year, it's time to form the Program Committee. We need at least
3 or 4 persons available to review the talks proposed by the community,
sort and organize them and then manage the conference program.

*Important note*: you need to be available during July and August as
these are the months during which we set the program.



Count me in!
All the best,
Marina

--
Marina Latini
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: wizards/source

[Jean-Pierre Ledure]

 wizards/source/access2base/Application.xba |2 
 wizards/source/access2base/Collect.xba |3 
 wizards/source/access2base/Compatible.xba  |2 
 wizards/source/access2base/DataDef.xba |   17 ++-
 wizards/source/access2base/Database.xba|   34 --
 wizards/source/access2base/Field.xba   |  155 +
 wizards/source/access2base/L10N.xba|8 -
 wizards/source/access2base/Recordset.xba   |  130 
 wizards/source/access2base/Utils.xba   |   26 +++-
 wizards/source/access2base/acConstants.xba |2 
 10 files changed, 337 insertions(+), 42 deletions(-)

New commits:
commit d8a113841160c571a3f254e73b676994eb940a79
Author: Jean-Pierre Ledure 
Date:   Wed Feb 3 12:13:54 2016 +0100

Access2Base - Wider database support

Support of HSQLDB 2.3 and MySql
CLOB and BLOB as database field types
Schema and catalog names in tables
GetChunk and AppendChunk methods for binary fields
The Value property returns the correct binary content of binary fields

Change-Id: I0aba80134f9add90f438ac4b7951fce9c1d36239

diff --git a/wizards/source/access2base/Application.xba 
b/wizards/source/access2base/Application.xba
index 7a76ed0..ae7483b 100644
--- a/wizards/source/access2base/Application.xba
+++ b/wizards/source/access2base/Application.xba
@@ -59,7 +59,7 @@ Global Const ERRRECORDSETCLOSED   =   1538
 Global Const ERRRECORDSETRANGE =   1539
 Global Const ERRRECORDSETFORWARD   =   1540
 Global Const ERRFIELDNULL  =   1541
-Global Const ERRMEMOLENGTH =   1542
+Global Const ERROVERFLOW   =   1542
 Global Const ERRNOTACTIONQUERY =   1543
 Global Const ERRNOTUPDATABLE   =   1544
 Global Const ERRUPDATESEQUENCE =   1545
diff --git a/wizards/source/access2base/Collect.xba 
b/wizards/source/access2base/Collect.xba
index cafda77..74cd756 100644
--- a/wizards/source/access2base/Collect.xba
+++ b/wizards/source/access2base/Collect.xba
@@ -206,6 +206,9 @@ Dim vObject As Variant, oTempVar As Object
Set oTables = oConnection.getTables()
oTables.appendByDescriptor(.TableDescriptor)
Set .Table = oTables.getByName(._Name)
+   .CatalogName = .Table.CatalogName
+   .SchemaName = .Table.SchemaName
+   .TableName = .Table.Name
.TableDescriptor.dispose()
Set .TableDescriptor = Nothing
.TableFieldsCount = 0
diff --git a/wizards/source/access2base/Compatible.xba 
b/wizards/source/access2base/Compatible.xba
index f3d3ad9..30cab09 100644
--- a/wizards/source/access2base/Compatible.xba
+++ b/wizards/source/access2base/Compatible.xba
@@ -19,7 +19,7 @@ Dim vVarTypes() As Variant, i As Integer
 Const cstTab = 5
On Local Error Goto Exit_Sub'  Never interrupt processing
Utils._SetCalledSub("DebugPrint")
-   vVarTypes = Utils._AddNumeric(Array(vbEmpty, vbNull, vbDate, vbString, 
vbBoolean, vbObject, vbVariant))
+   vVarTypes = Utils._AddNumeric(Array(vbEmpty, vbNull, vbDate, vbString, 
vbBoolean, vbObject, vbVariant, vbByte, 8192 + vbByte))

If UBound(pvArgs) >= 0 Then
For i = 0 To UBound(pvArgs)
diff --git a/wizards/source/access2base/DataDef.xba 
b/wizards/source/access2base/DataDef.xba
index e151b28..a283264 100644
--- a/wizards/source/access2base/DataDef.xba
+++ b/wizards/source/access2base/DataDef.xba
@@ -19,6 +19,9 @@ Private _Name As String
 Private _ParentDatabaseAs Object
 Private _ReadOnly  As Boolean
 Private Table  As Object   
'  com.sun.star.sdb.dbaccess.ODBTable
+Private CatalogNameAs String
+Private SchemaName As String
+Private TableName  As String
 Private Query  As Object   
'  com.sun.star.sdb.dbaccess.OQuery
 Private TableDescriptorAs Object   
'  com.sun.star.sdb.dbaccess.ODBTable
 Private TableFieldsCount   As Integer
@@ -33,6 +36,9 @@ Private Sub Class_Initialize()
Set _ParentDatabase = Nothing
_ReadOnly = False
Set Table = Nothing
+   CatalogName = ""
+   SchemaName = ""
+   TableName = ""
Set Query = Nothing
Set TableDescriptor = Nothing
TableFieldsCount = 0
@@ -151,6 +157,9 @@ Const cstMaxKeyLength = 30
.Precision = Int(pvSize)
If pvType = dbNumeric Or pvType = dbDecimal Or pvType = 
dbCurrency Then .Scale = Int(

[Bug 38835] strip out non-trivial globals before main

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38835

--- Comment #21 from Björn Michaelsen  ---
Note that constants (currently either #defines or "static const ..." can --
with C++11 -- be turned into constexprs:

 http://en.cppreference.com/w/cpp/language/constexpr

which should be generally preferable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.0' - desktop/source

[Michael Stahl]

 desktop/source/lib/lokinteractionhandler.cxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit d04cf314d44c0ae0cbb135d21436d119f936208c
Author: Michael Stahl 
Date:   Wed Feb 3 11:38:10 2016 +0100

libreofficekit: CppunitTest_libreofficekit_tiledrendering crashes

Need to check that a callback was actually set before calling it.

Change-Id: Icb2ca19aec0c74f6695d7286f046dadfe609d68c

diff --git a/desktop/source/lib/lokinteractionhandler.cxx 
b/desktop/source/lib/lokinteractionhandler.cxx
index a4a60c2..e4c3ee5 100644
--- a/desktop/source/lib/lokinteractionhandler.cxx
+++ b/desktop/source/lib/lokinteractionhandler.cxx
@@ -115,9 +115,9 @@ void 
LOKInteractionHandler::postError(css::task::InteractionClassification class
 std::stringstream aStream;
 boost::property_tree::write_json(aStream, aTree);
 
-if (m_pLOKDocument)
+if (m_pLOKDocument && m_pLOKDocument->mpCallback)
 m_pLOKDocument->mpCallback(LOK_CALLBACK_ERROR, aStream.str().c_str(), 
m_pLOKDocument->mpCallbackData);
-else
+else if (m_pLOKit->mpCallback)
 m_pLOKit->mpCallback(LOK_CALLBACK_ERROR, aStream.str().c_str(), 
m_pLOKit->mpCallbackData);
 }
 
@@ -243,7 +243,8 @@ bool LOKInteractionHandler::handlePasswordRequest(const 
uno::Sequence>= passwordRequest))
 return false;
 
-if 
(m_pLOKit->hasOptionalFeature((passwordRequest.IsRequestPasswordToModify)
+if (m_pLOKit->mpCallback &&
+
m_pLOKit->hasOptionalFeature((passwordRequest.IsRequestPasswordToModify)
 ? LOK_FEATURE_DOCUMENT_PASSWORD_TO_MODIFY
 : LOK_FEATURE_DOCUMENT_PASSWORD))
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source sd/source sw/source

[Jan Holesovsky]

 sc/source/ui/unoobj/docuno.cxx|7 +++
 sd/source/ui/unoidl/unomodel.cxx  |7 +++
 sw/source/uibase/uno/unotxdoc.cxx |7 +++
 3 files changed, 21 insertions(+)

New commits:
commit 70a1dbb4c7fdcb6ba309aa53dac8299a3f2bc626
Author: Jan Holesovsky 
Date:   Wed Feb 3 11:59:04 2016 +0100

lok: Avoid the 'alien format' warning in LibreOfficeKit.

We immediately cancel all the dialogs that potentially come up when using
LibreOfficeKit; which means that when you tried to save a .docx to a remote
server (which triggered the 'alien format' warning), the save operation
couldn't be completed.

Change-Id: I6bb5eadac994c1f515d7a49299c21960b3491bbe

diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx
index 4993f18..8806a88 100644
--- a/sc/source/ui/unoobj/docuno.cxx
+++ b/sc/source/ui/unoobj/docuno.cxx
@@ -44,6 +44,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -931,6 +932,12 @@ void ScModelObj::initializeForTiledRendering(const 
css::uno::SequenceSetInputOptions(aInputOptions);
 pDocShell->CalcOutputFactor();
 
+// when the "This document may contain formatting or content that cannot
+// be saved..." dialog appears, it is auto-cancelled with tiled rendering,
+// causing 'Save' being disabled; so let's always save to the original
+// format
+SvtSaveOptions().SetWarnAlienFormat(false);
+
 // default tile size in pixels
 mnTilePixelWidth = 256;
 mnTilePixelHeight = 256;
diff --git a/sd/source/ui/unoidl/unomodel.cxx b/sd/source/ui/unoidl/unomodel.cxx
index 36fbeec..cf0a32c 100644
--- a/sd/source/ui/unoidl/unomodel.cxx
+++ b/sd/source/ui/unoidl/unomodel.cxx
@@ -63,6 +63,7 @@
 #include 
 #include 
 #include 
+#include 
 
 // Support creation of GraphicObjectResolver and EmbeddedObjectResolver
 #include 
@@ -2392,6 +2393,12 @@ void 
SdXImpressDocument::initializeForTiledRendering(const css::uno::SequenceSetSwapAsynchron(false);
 }
+
+// when the "This document may contain formatting or content that cannot
+// be saved..." dialog appears, it is auto-cancelled with tiled rendering,
+// causing 'Save' being disabled; so let's always save to the original
+// format
+SvtSaveOptions().SetWarnAlienFormat(false);
 }
 
 void SdXImpressDocument::registerCallback(LibreOfficeKitCallback pCallback, 
void* pData)
diff --git a/sw/source/uibase/uno/unotxdoc.cxx 
b/sw/source/uibase/uno/unotxdoc.cxx
index 9c64773..55b9b21 100644
--- a/sw/source/uibase/uno/unotxdoc.cxx
+++ b/sw/source/uibase/uno/unotxdoc.cxx
@@ -116,6 +116,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -3263,6 +3264,12 @@ void SwXTextDocument::initializeForTiledRendering(const 
css::uno::SequenceGetView()->GetEditWin();
 rEditWin.EnableMapMode(false);
+
+// when the "This document may contain formatting or content that cannot
+// be saved..." dialog appears, it is auto-cancelled with tiled rendering,
+// causing 'Save' being disabled; so let's always save to the original
+// format
+SvtSaveOptions().SetWarnAlienFormat(false);
 }
 
 void SwXTextDocument::registerCallback(LibreOfficeKitCallback pCallback, void* 
pData)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: DPI and screen resolution on OS X

[SOS]

On 3/02/2016 11:32, Chris Sherlock wrote:

On 3 Feb 2016, at 7:24 PM, SOS  wrote:


On 3/02/2016 3:55, Kohei Yoshida wrote:

On Wed, 2016-02-03 at 10:52 +1100, Chris Sherlock wrote:

The other question is: why would we not want to the actual DPI and
screen resolution?

My understanding is that, historically, the OS provided a function to
query DPI but what gets returned from such function was not always
accurate (or always not accurate depending on who you ask).  So, the
workaround at the time was to assume that DPI is always 96 (and
hard-code that value) regardless of what the OS told you, which worked
just fine because the monitors used back in the day had the same screen
resolution.

Mostly DPI is found in the header of a pixelfile (taken by camera). 
Unfortunately it's not the photographer who gets to decide about the needed DPI.
DPI is actually a wrong definition for documents, Dots Per Inch is a definition 
used by output devices. Screens need a PIXEL par DOT but for print devices 
there is no precise correlation between the number of dots used by the device 
and the pixels needed in  the image for having a maximum image-view quality.
The print industry has come to some standards by trial and error.
- monitor screens need 96 - (220-retina) pixels per inch
- laser printers need 150 pixels per inch (up tot 2000 + dots)
- offset printers need 254 -300 pixels per inch (up to 3000 dots)

Definitely true :-) Only in OS X’s case, it doesn’t actually report back the 
correct resolution unless you ask for the backing coordinate system.

The PPI business is a red herring I think I’ve introduced into this discussion 
I’m afraid. We calculate the PPI ourselves (and call it DPI) based on the 
reported pixels, and the size of the screen in mm (which we obviously convert 
to inches).
its a bit the wrong discussion: what we see on screen has no relevance: 
the user can "zoom" the document until he is happy with the image 
quality on screen
But in the current situation, LO users has no idea how big (size) he can 
place a image in a document.
When the doc is intented for online use (email and Web) then there is a 
minimum of 96 pixels par inch needed. More is no problem but is in many 
cases a overkill.
Who is editing a "book" or a "magazine" need minimal 254 pixels par inch 
to has a good image quality after printing.
When using less pixels the book pages  are looking fine on screen put 
shall have a creepy print quality
So having a new "DocumentProperty" indicating the needed pixels (for 
printing)  make it possible to make the "size" calculations before 
inserting.


I guess I’m curious as to what is relying on the screen resolution and PPI.

Although… it’s funny that we have the function SalGraphics::GetResolution, but 
that returns the PPI!

Chris
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: DPI and screen resolution on OS X

[Chris Sherlock]

On 3 Feb 2016, at 10:35 PM, SOS  wrote:
> 
> 
> On 3/02/2016 11:32, Chris Sherlock wrote:
>> On 3 Feb 2016, at 7:24 PM, SOS  wrote:
>>> 
>>> On 3/02/2016 3:55, Kohei Yoshida wrote:
 On Wed, 2016-02-03 at 10:52 +1100, Chris Sherlock wrote:
> The other question is: why would we not want to the actual DPI and
> screen resolution?
 My understanding is that, historically, the OS provided a function to
 query DPI but what gets returned from such function was not always
 accurate (or always not accurate depending on who you ask).  So, the
 workaround at the time was to assume that DPI is always 96 (and
 hard-code that value) regardless of what the OS told you, which worked
 just fine because the monitors used back in the day had the same screen
 resolution.
>>> Mostly DPI is found in the header of a pixelfile (taken by camera). 
>>> Unfortunately it's not the photographer who gets to decide about the needed 
>>> DPI.
>>> DPI is actually a wrong definition for documents, Dots Per Inch is a 
>>> definition used by output devices. Screens need a PIXEL par DOT but for 
>>> print devices there is no precise correlation between the number of dots 
>>> used by the device and the pixels needed in  the image for having a maximum 
>>> image-view quality.
>>> The print industry has come to some standards by trial and error.
>>> - monitor screens need 96 - (220-retina) pixels per inch
>>> - laser printers need 150 pixels per inch (up tot 2000 + dots)
>>> - offset printers need 254 -300 pixels per inch (up to 3000 dots)
>> Definitely true :-) Only in OS X’s case, it doesn’t actually report back the 
>> correct resolution unless you ask for the backing coordinate system.
>> 
>> The PPI business is a red herring I think I’ve introduced into this 
>> discussion I’m afraid. We calculate the PPI ourselves (and call it DPI) 
>> based on the reported pixels, and the size of the screen in mm (which we 
>> obviously convert to inches).
> its a bit the wrong discussion: what we see on screen has no relevance: the 
> user can "zoom" the document until he is happy with the image quality on 
> screen
> But in the current situation, LO users has no idea how big (size) he can 
> place a image in a document.
> When the doc is intented for online use (email and Web) then there is a 
> minimum of 96 pixels par inch needed. More is no problem but is in many cases 
> a overkill.
> Who is editing a "book" or a "magazine" need minimal 254 pixels par inch to 
> has a good image quality after printing.
> When using less pixels the book pages  are looking fine on screen put shall 
> have a creepy print quality
> So having a new "DocumentProperty" indicating the needed pixels (for 
> printing)  make it possible to make the "size" calculations before inserting.

We are actually detecting the PPI… with the greatest of respect, I’ve actually 
implemented some testing changes to detect the correct PPI and on my Mac is 
should actually be just over 200PPI…

I think this is going in the wrong direction. I worked for Epson about 13 years 
ago, so I have some knowledge of printing :-) I could talk your ear off on 
colour management and halftoning, and I probably know a bit too much about 
piezo-electric crystal technology…

I’m really trying to understand what is relying on the resolution and what sort 
of impact fixing the resolution detection might be having on OS X systems. 

Chris
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: DPI and screen resolution on OS X

[Alexander Thurgood]

Le 03/02/2016 00:52, Chris Sherlock a écrit :

Hi Chris,


> Hi all, 
> 
> I’ve mentioned this briefly to Tor on IRC, but thought I’d email the mailing 
> list and a general enquiry. 
> 
> I noticed that we don’t actually get the “true” DPI for OS X, nor the actual 
> resolution - at least on high resolution screens (Retina in particular). 
> 

From what I recall this has provided a few calculation issues in the
past with some of the xml layout unit tests in sw on OSX - making rect
calculation rounding errors spring to mind causing the unit test to
fail. As I only reported these at the time, and not involved in fixing
them, I can't say I understand the details.

I also wonder whether the horrible black or white bands and other
display detritus we see on OSX in fullscreen would be affected by
changes in this area (for the better hopefully)

Alex


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: DPI and screen resolution on OS X

[SOS]

On 3/02/2016 13:01, Chris Sherlock wrote:

On 3 Feb 2016, at 10:35 PM, SOS  wrote:


On 3/02/2016 11:32, Chris Sherlock wrote:

On 3 Feb 2016, at 7:24 PM, SOS  wrote:

On 3/02/2016 3:55, Kohei Yoshida wrote:

On Wed, 2016-02-03 at 10:52 +1100, Chris Sherlock wrote:

The other question is: why would we not want to the actual DPI and
screen resolution?

My understanding is that, historically, the OS provided a function to
query DPI but what gets returned from such function was not always
accurate (or always not accurate depending on who you ask).  So, the
workaround at the time was to assume that DPI is always 96 (and
hard-code that value) regardless of what the OS told you, which worked
just fine because the monitors used back in the day had the same screen
resolution.

Mostly DPI is found in the header of a pixelfile (taken by camera). 
Unfortunately it's not the photographer who gets to decide about the needed DPI.
DPI is actually a wrong definition for documents, Dots Per Inch is a definition 
used by output devices. Screens need a PIXEL par DOT but for print devices 
there is no precise correlation between the number of dots used by the device 
and the pixels needed in  the image for having a maximum image-view quality.
The print industry has come to some standards by trial and error.
- monitor screens need 96 - (220-retina) pixels per inch
- laser printers need 150 pixels per inch (up tot 2000 + dots)
- offset printers need 254 -300 pixels per inch (up to 3000 dots)

Definitely true :-) Only in OS X’s case, it doesn’t actually report back the 
correct resolution unless you ask for the backing coordinate system.

The PPI business is a red herring I think I’ve introduced into this discussion 
I’m afraid. We calculate the PPI ourselves (and call it DPI) based on the 
reported pixels, and the size of the screen in mm (which we obviously convert 
to inches).

its a bit the wrong discussion: what we see on screen has no relevance: the user can 
"zoom" the document until he is happy with the image quality on screen
But in the current situation, LO users has no idea how big (size) he can place 
a image in a document.
When the doc is intented for online use (email and Web) then there is a minimum 
of 96 pixels par inch needed. More is no problem but is in many cases a 
overkill.
Who is editing a "book" or a "magazine" need minimal 254 pixels par inch to has 
a good image quality after printing.
When using less pixels the book pages  are looking fine on screen put shall 
have a creepy print quality
So having a new "DocumentProperty" indicating the needed pixels (for printing)  make it 
possible to make the "size" calculations before inserting.

We are actually detecting the PPI… with the greatest of respect, I’ve actually 
implemented some testing changes to detect the correct PPI and on my Mac is 
should actually be just over 200PPI…

ok but how did you detected the PPI ?
You need the "fysical" dots given by the manufactor off the screen. Then 
you cab devide the total dots by the size off the screen

Standard Led and LCD screens have around 100 dots par inch
A Retina screen on a tablet or a smartphone could have 150-300 dots par 
inch





I think this is going in the wrong direction. I worked for Epson about 13 years 
ago, so I have some knowledge of printing :-) I could talk your ear off on 
colour management and halftoning, and I probably know a bit too much about 
piezo-electric crystal technology…

I’m really trying to understand what is relying on the resolution and what sort 
of impact fixing the resolution detection might be having on OS X systems.

Chris


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: DPI and screen resolution on OS X

[Chris Sherlock]

> On 3 Feb 2016, at 11:08 PM, Alexander Thurgood  
> wrote:
> 
> Le 03/02/2016 00:52, Chris Sherlock a écrit :
> 
> Hi Chris,
> 
> 
>> Hi all, 
>> 
>> I’ve mentioned this briefly to Tor on IRC, but thought I’d email the mailing 
>> list and a general enquiry. 
>> 
>> I noticed that we don’t actually get the “true” DPI for OS X, nor the actual 
>> resolution - at least on high resolution screens (Retina in particular). 
>> 
> 
> From what I recall this has provided a few calculation issues in the
> past with some of the xml layout unit tests in sw on OSX - making rect
> calculation rounding errors spring to mind causing the unit test to
> fail. As I only reported these at the time, and not involved in fixing
> them, I can't say I understand the details.
> 
> I also wonder whether the horrible black or white bands and other
> display detritus we see on OSX in fullscreen would be affected by
> changes in this area (for the better hopefully)
> 
> Alex

If nobody has any objections, I can add an environment variable that forces it 
to pick up the actual screen resolution. 

Something like OSX_FORCEBACKINGCOORDS

If you then want to troubleshoot this sort of thing and wonder if this might be 
helpful, then set the environment variable and reload LO, see if the same issue 
occurs. 

Chris
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 87813] SIDEBAR: Incorporating the effects list into the animation tab

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87813

Rishabh  changed:

   What|Removed |Added

   Assignee|akshaydeepi...@gmail.com|kris.kr...@gmail.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.0' - configure.ac

[Andras Timar]

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit df7825ac64cbf54122bbcd8976214c6b148b67df
Author: Andras Timar 
Date:   Wed Feb 3 13:30:35 2016 +0100

Bump version to 5.0-21

Change-Id: I2f1f6a61661faad76a9929ffc64125ffbd09ec6a

diff --git a/configure.ac b/configure.ac
index 75489fb..7e14b85 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([Collabora Office],[5.0.10.20],[],[],[https://CollaboraOffice.com/])
+AC_INIT([Collabora Office],[5.0.10.21],[],[],[https://CollaboraOffice.com/])
 
 AC_PREREQ([2.59])
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 87813] SIDEBAR: Incorporating the effects list into the animation tab

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87813

--- Comment #9 from Rishabh  ---
(In reply to Samuel Mehrbrodt from comment #8)
> This is an easy hack. The task is to complete the patch here:
> https://gerrit.libreoffice.org/#/c/17008/
> 
> There are some bugs to fix, see comment from Jay Philips in Gerrit (Aug 23
> 9:48 PM).

Hi Samuel,

Apologies for the inactivity. I wish to restart the work on this patch and will
start by updating the commit to build in the current master.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: offapi/com

[Michael Stahl]

 offapi/com/sun/star/util/XNumberFormatTypes.idl |   13 +
 offapi/com/sun/star/util/XSearchable.idl|2 ++
 offapi/com/sun/star/xml/sax/XFastParser.idl |1 +
 3 files changed, 12 insertions(+), 4 deletions(-)

New commits:
commit 12ac55d594757246dcf0007d4f0947a453ffdd83
Author: Michael Stahl 
Date:   Wed Feb 3 13:27:37 2016 +0100

offapi: fix a few doxygen warnings

Change-Id: I0fbd4affa876fa01458942c4cf14d029ed5d1095

diff --git a/offapi/com/sun/star/util/XNumberFormatTypes.idl 
b/offapi/com/sun/star/util/XNumberFormatTypes.idl
index 63d3902..b281710 100644
--- a/offapi/com/sun/star/util/XNumberFormatTypes.idl
+++ b/offapi/com/sun/star/util/XNumberFormatTypes.idl
@@ -41,9 +41,12 @@ published interface XNumberFormatTypes: 
com::sun::star::uno::XInterface
 /** @returns
 the key of the standard format within a specified type for a 
given locale.
 
-@param nType
+@param nType
 the type of the number format. Must be one of the
 NumberFormat constants.
+@param nLocale
+the locale for which the number format is requested.
+
  */
 long getStandardFormat( [in] short nType,
  [in] com::sun::star::lang::Locale nLocale );
@@ -52,11 +55,13 @@ published interface XNumberFormatTypes: 
com::sun::star::uno::XInterface
 /** @returns
 the key of a built-in format for a locale:
 
-@param  nIndex
+@param  nIndex
 the index of the wanted number format within the formats for
 the given locale. One of the
  com::sun::star::i18n::NumberFormatIndex
 constants.
+@param nLocale
+the locale for which the key is requested.
  */
 long getFormatIndex( [in] short nIndex,
  [in] com::sun::star::lang::Locale nLocale );
@@ -72,10 +77,10 @@ published interface XNumberFormatTypes: 
com::sun::star::uno::XInterface
 the index of the converted number format if successful,
 the old index if the number format could not be converted.
 
-@param nKey
+@param nKey
 index of the old number format
 
-@param nLocale
+@param nLocale
 the locale to which the number format is converted
  */
 long getFormatForLocale( [in] long nKey,
diff --git a/offapi/com/sun/star/util/XSearchable.idl 
b/offapi/com/sun/star/util/XSearchable.idl
index 9a18ad5..b470815 100644
--- a/offapi/com/sun/star/util/XSearchable.idl
+++ b/offapi/com/sun/star/util/XSearchable.idl
@@ -77,6 +77,8 @@ published interface XSearchable: 
com::sun::star::uno::XInterface
 represents a position within the component at which the search 
continues.
 This position is returned by XSearchable::findFirst() or
 the previous XSearchable::findNext().
+@param xDesc
+the descriptor used for searching.
 
 @see SearchDescriptor
  */
diff --git a/offapi/com/sun/star/xml/sax/XFastParser.idl 
b/offapi/com/sun/star/xml/sax/XFastParser.idl
index 6f28b60..bcb1f5f 100644
--- a/offapi/com/sun/star/xml/sax/XFastParser.idl
+++ b/offapi/com/sun/star/xml/sax/XFastParser.idl
@@ -122,6 +122,7 @@ interface XFastParser: com::sun::star::uno::XInterface
 
 
 /** registers a known namespace url with the given integer token.
+@param NamespaceURL the namespace URL.
 @param NamespaceToken
 an integer token that must be greater than FastToken::NAMESPACE.
  */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 87813] SIDEBAR: Incorporating the effects list into the animation tab

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87813

--- Comment #10 from Samuel Mehrbrodt  ---
(In reply to Rishabh from comment #9)
> Apologies for the inactivity. I wish to restart the work on this patch and
> will start by updating the commit to build in the current master.

Hi Rishab, please get in touch with akshaydeepi...@gmail.com who started
working on this yesterday.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: external/libxmlsec

[Miklos Vajna]

 external/libxmlsec/UnpackedTarball_xmlsec.mk   |1 
 external/libxmlsec/xmlsec1-mscrypto-sha256.patch.1 |  308 +
 2 files changed, 309 insertions(+)

New commits:
commit e2ccc96482e770edb57edffbf653c18d3a0c4c23
Author: Miklos Vajna 
Date:   Wed Feb 3 13:34:19 2016 +0100

tdf#76142 libxmlsec: implement SHA-256 support in the mscrypto backend

The only tricky part is PROV_RSA_FULL -> PROV_RSA_AES, otherwise SHA-256
is not recognized as a valid algo. MSDN documentation for PROV_RSA_FULL
at


and PROV_RSA_AES at


say that AES is a superset of full, so should be no
backwards-compatibility issue. I tested this on Windows 7, but according
to the documentation, it should be no problem on Windows XP, either --
provided that the latest SP is installed.

Change-Id: I3ae196679c2cbf0e9e55fab10584d9c46a480659

diff --git a/external/libxmlsec/UnpackedTarball_xmlsec.mk 
b/external/libxmlsec/UnpackedTarball_xmlsec.mk
index 68fb8d1..18a9308 100644
--- a/external/libxmlsec/UnpackedTarball_xmlsec.mk
+++ b/external/libxmlsec/UnpackedTarball_xmlsec.mk
@@ -28,6 +28,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,xmlsec,\
external/libxmlsec/xmlsec1-update-config.guess.patch.1 \
external/libxmlsec/xmlsec1-ooxml.patch.1 \
external/libxmlsec/xmlsec1-nss-sha256.patch.1 \
+   external/libxmlsec/xmlsec1-mscrypto-sha256.patch.1 \
 ))
 
 $(eval $(call 
gb_UnpackedTarball_add_file,xmlsec,include/xmlsec/mscrypto/akmngr.h,external/libxmlsec/include/akmngr_mscrypto.h))
diff --git a/external/libxmlsec/xmlsec1-mscrypto-sha256.patch.1 
b/external/libxmlsec/xmlsec1-mscrypto-sha256.patch.1
new file mode 100644
index 000..13577b7
--- /dev/null
+++ b/external/libxmlsec/xmlsec1-mscrypto-sha256.patch.1
@@ -0,0 +1,308 @@
+From 1562c2ee1f30ec9983e2f7e5a7bf4a89b594d706 Mon Sep 17 00:00:00 2001
+From: Miklos Vajna 
+Date: Tue, 2 Feb 2016 15:49:10 +0100
+Subject: [PATCH] mscrypto glue layer: add SHA-256 support
+
+---
+ include/xmlsec/mscrypto/crypto.h | 27 
+ src/mscrypto/certkeys.c  |  2 +-
+ src/mscrypto/crypto.c|  4 +++
+ src/mscrypto/digests.c   | 70 
+ src/mscrypto/signatures.c| 64 
+ 5 files changed, 166 insertions(+), 1 deletion(-)
+
+diff --git a/include/xmlsec/mscrypto/crypto.h 
b/include/xmlsec/mscrypto/crypto.h
+index 28d792a..96aaa78 100644
+--- a/include/xmlsec/mscrypto/crypto.h
 b/include/xmlsec/mscrypto/crypto.h
+@@ -133,6 +133,16 @@ XMLSEC_CRYPTO_EXPORT xmlSecKeyDataId 
xmlSecMSCryptoKeyDataRsaGetKlass(void);
+ XMLSEC_CRYPTO_EXPORT xmlSecTransformId 
xmlSecMSCryptoTransformRsaSha1GetKlass(void);
+ 
+ /**
++ * xmlSecMSCryptoTransformRsaSha256Id:
++ *
++ * The RSA-SHA256 signature transform klass.
++ */
++
++#define xmlSecMSCryptoTransformRsaSha256Id\
++  xmlSecMSCryptoTransformRsaSha256GetKlass()
++XMLSEC_CRYPTO_EXPORT xmlSecTransformId 
xmlSecMSCryptoTransformRsaSha256GetKlass(void);
++
++/**
+  * xmlSecMSCryptoTransformRsaPkcs1Id:
+  * 
+  * The RSA PKCS1 key transport transform klass.
+@@ -172,6 +182,23 @@ XMLSEC_CRYPTO_EXPORT xmlSecTransformId 
xmlSecMSCryptoTransformSha1GetKlass(void)
+ 
+ /
+  *
++ * SHA256 transform
++ *
++ ***/
++#ifndef XMLSEC_NO_SHA256
++
++/**
++ * xmlSecMSCryptoTransformSha256Id:
++ *
++ * The SHA256 digest transform klass.
++ */
++#define xmlSecMSCryptoTransformSha256Id \
++  xmlSecMSCryptoTransformSha256GetKlass()
++XMLSEC_CRYPTO_EXPORT xmlSecTransformId 
xmlSecMSCryptoTransformSha256GetKlass(void);
++#endif /* XMLSEC_NO_SHA256 */
++
++/
++ *
+  * GOSTR3411_94 transform
+  *
+  ***/
+diff --git a/src/mscrypto/certkeys.c b/src/mscrypto/certkeys.c
+index 73a6c26..e0b4f47 100644
+--- a/src/mscrypto/certkeys.c
 b/src/mscrypto/certkeys.c
+@@ -1009,7 +1009,7 @@ xmlSecMSCryptoKeyDataRsaInitialize(xmlSecKeyDataPtr 
data) {
+ xmlSecAssert2(ctx != NULL, -1);
+ 
+ ctx->providerName = MS_ENHANCED_PROV;
+-ctx->providerType = PROV_RSA_FULL;
++ctx->providerType = PROV_RSA_AES;
+ 
+ return(0);
+ }
+diff --git a/src/mscrypto/crypto.c b/src/mscrypto/crypto.c
+index d60d3c6..b2fde85 100644
+--- a/src/mscrypto/crypto.c
 b/src/mscrypto/crypto.c
+@@ -105,6 +105,7 @@ xmlSecCryptoGetFunctions_mscrypto(void) {
+ 
+ #ifndef XMLSEC_NO_RSA
+ gXmlSecMSCryptoFunctions->transformRsaSha1GetKlass= 
xmlSecMSCryptoTransformRsaSha1GetKlass;
++gXmlSecMSCryptoFunctions->transformRsaSha256GetKlass  = 
xml

[Libreoffice-commits] core.git: vcl/source

[Caolán McNamara]

 vcl/source/gdi/pdfwriter_impl.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 384c815eda697d75706f686dc2ceb227b4d3f245
Author: Caolán McNamara 
Date:   Wed Feb 3 12:36:09 2016 +

Resolves: tdf#96653 distorted images on export to pdf

regression from:

commit ffe150ce903d9cdc62c25ad3437e61d24ede17d6
Date:   Fri Dec 4 18:19:08 2015 +0100

tdf#94739 use GetScanlineSize instead of calculating it

which was on the right track in the sense that the original
code was wrong and only worked for <= 8 bit depth images

Change-Id: Iee54a9f29dd0fdaf3e1f2aeb7b9898cecb453e37

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index de67de6..3c20b49 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -11390,7 +11390,8 @@ bool PDFWriterImpl::writeBitmapObject( BitmapEmit& 
rObject, bool bMask )
 beginCompression();
 if( ! bTrueColor || pAccess->GetScanlineFormat() == 
BMP_FORMAT_24BIT_TC_RGB )
 {
-const int nScanLineBytes = pAccess->GetScanlineSize();
+//With PDF bitmaps, each row is padded to a BYTE boundary 
(multiple of 8 bits).
+const int nScanLineBytes = ((pAccess->GetBitCount() * 
pAccess->Width()) + 7U) / 8U;
 
 for( long i = 0; i < pAccess->Height(); i++ )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/source

[Ras-al-Ghul]

 include/vcl/window.hxx   |3 -
 vcl/inc/svdata.hxx   |   13 
 vcl/source/app/svapp.cxx |   34 --
 vcl/source/window/window.cxx |   65 +--
 4 files changed, 15 insertions(+), 100 deletions(-)

New commits:
commit 60d6cb4faaffeef7e4660b2077c7d41a6865b761
Author: Ras-al-Ghul 
Date:   Tue Feb 2 19:42:15 2016 +0530

tdf#96888 - Kill internal vcl dog-tags ...

Removed some more usages of ImplDelData

Change-Id: Ieb3c83ecebaa799bec6ae409dd480ac123b8a460
Reviewed-on: https://gerrit.libreoffice.org/22040
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 

diff --git a/include/vcl/window.hxx b/include/vcl/window.hxx
index bc762f4..d69de6d 100644
--- a/include/vcl/window.hxx
+++ b/include/vcl/window.hxx
@@ -591,9 +591,6 @@ public:
 
 SAL_DLLPRIVATE void ImplPosSizeWindow( long nX, long nY, 
long nWidth, long nHeight, PosSizeFlags nFlags );
 
-SAL_DLLPRIVATE void ImplAddDel( ImplDelData* pDel ) const;
-SAL_DLLPRIVATE void ImplRemoveDel( ImplDelData* pDel ) 
const;
-
 SAL_DLLPRIVATE void ImplCallResize();
 SAL_DLLPRIVATE void ImplCallMove();
 
diff --git a/vcl/inc/svdata.hxx b/vcl/inc/svdata.hxx
index d139c14..e43b0d4 100644
--- a/vcl/inc/svdata.hxx
+++ b/vcl/inc/svdata.hxx
@@ -375,19 +375,6 @@ struct ImplDelData
 ImplDelData*mpNext;
 VclPtr mpWindow;
 boolmbDel;
-
-ImplDelData( vcl::Window* pWindow = nullptr );
-virtual ~ImplDelData();
-
-boolIsDead() const
-{
-DBG_ASSERT( !mbDel, "object deleted while in use !" );
-return mbDel;
-}
-
-private:
-voidAttachToWindow( const vcl::Window* );
-
 };
 
 struct ImplSVEvent
diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx
index b0d9111..c36b722 100644
--- a/vcl/source/app/svapp.cxx
+++ b/vcl/source/app/svapp.cxx
@@ -1783,38 +1783,4 @@ void 
Application::setDeInitHook(Link const & hook) {
 pSVData->maAppData.mbInAppMain = true;
 }
 
-ImplDelData::ImplDelData( vcl::Window* pWindow ) :
- mpNext( nullptr ),
- mpWindow( nullptr ),
- mbDel( false )
-{
-if( pWindow ) AttachToWindow( pWindow );
-}
-
-// helper method to allow inline constructor even for pWindow!=NULL case
-void ImplDelData::AttachToWindow( const vcl::Window* pWindow )
-{
-if( pWindow )
-{
-if( pWindow->IsDisposed() )
-mbDel = true;
-else
-pWindow->ImplAddDel( this );
-}
-}
-
-// define dtor for ImplDelData
-ImplDelData::~ImplDelData()
-{
-// #112873# auto remove of ImplDelData
-// due to this code actively calling ImplRemoveDel() is not mandatory 
anymore
-if( !mbDel && mpWindow )
-{
-// the window still exists but we were not removed
-mpWindow.get()->ImplRemoveDel( this );
-mpWindow = nullptr;
-}
-}
-
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index 3489e0d..a6c4fc8 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -1377,41 +1377,6 @@ void Window::ImplSetReallyVisible()
 }
 }
 
-void Window::ImplAddDel( ImplDelData* pDel ) const
-{
-if ( IsDisposed() )
-{
-pDel->mbDel = true;
-return;
-}
-
-DBG_ASSERT( !pDel->mpWindow, "Window::ImplAddDel(): cannot add ImplDelData 
twice !" );
-if( !pDel->mpWindow )
-{
-pDel->mpWindow = const_cast(this);  // #112873# store 
ref to this window, so pDel can remove itself
-pDel->mpNext = mpWindowImpl->mpFirstDel;
-mpWindowImpl->mpFirstDel = pDel;
-}
-}
-
-void Window::ImplRemoveDel( ImplDelData* pDel ) const
-{
-pDel->mpWindow = nullptr;  // #112873# pDel is not associated with a 
Window anymore
-
-if ( IsDisposed() )
-return;
-
-if ( mpWindowImpl->mpFirstDel == pDel )
-mpWindowImpl->mpFirstDel = pDel->mpNext;
-else
-{
-ImplDelData* pData = mpWindowImpl->mpFirstDel;
-while ( pData->mpNext != pDel )
-pData = pData->mpNext;
-pData->mpNext = pDel->mpNext;
-}
-}
-
 void Window::ImplInitResolutionSettings()
 {
 // recalculate AppFont-resolution and DPI-resolution
@@ -1949,9 +1914,9 @@ void Window::GetFocus()
 {
 if ( HasFocus() && mpWindowImpl->mpLastFocusWindow && 
!(mpWindowImpl->mnDlgCtrlFlags & DialogControlFlags::WantFocus) )
 {
-ImplDelData aDogtag( this );
+VclPtr xWindow(this);
 mpWindowImpl->mpLastFocusWindow->GrabFocus();
-if( aDogtag.IsDead() )
+if( xWindow->IsDisposed() )
 return;
 }
 
@@ -2296,7 +2261,7 @@ void Window::Show(bool bVisible, ShowFlags nFlags)
 if ( IsDisposed() || mpWindowImpl-

[Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #38 from Commit Notification 
 ---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=60d6cb4faaffeef7e4660b2077c7d41a6865b761

tdf#96888 - Kill internal vcl dog-tags ...

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Apple Numbers application and format.

[jan iversen]

Hi.

With a little help in IRC (Thanks) I managed to convert a ods (calc) file to 
apple's number application using .xlsx as an intermidiate format.

Does anybody know, where I can find a specificition of the numbers file format ?

if the format is known, it cannot be that hard to write import/export 
functions, and my time would be better spend than converting file formats.

thanks in advance
rgds
jan i.


Sent from my iPad, please excuse any misspellings 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Apple Numbers application and format.

[Chris Sherlock]

What exactly are you trying to do?

Chris

> On 3 Feb 2016, at 11:58 PM, jan iversen  wrote:
> 
> Hi.
> 
> With a little help in IRC (Thanks) I managed to convert a ods (calc) file to 
> apple's number application using .xlsx as an intermidiate format.
> 
> Does anybody know, where I can find a specificition of the numbers file 
> format ?
> 
> if the format is known, it cannot be that hard to write import/export 
> functions, and my time would be better spend than converting file formats.
> 
> thanks in advance
> rgds
> jan i.
> 
> 
> Sent from my iPad, please excuse any misspellings 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

RE: Apple Numbers application and format.

[Winfried Donkers]

Hi Jan,

> With a little help in IRC (Thanks) I managed to convert a ods (calc) file
> to apple's number application using .xlsx as an intermidiate format.
> 
> Does anybody know, where I can find a specificition of the numbers file
> format ?

I may have misunderstood you, but you might find answers here: 
https://bugs.documentfoundation.org/show_bug.cgi?id=97334

Winfried
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: idl/inc idl/source sc/sdi sd/sdi sfx2/sdi starmath/sdi svx/sdi sw/sdi

[Noel Grandin]

 idl/inc/globals.hxx |2 
 idl/inc/slot.hxx|2 
 idl/source/objects/slot.cxx |8 
 idl/source/prj/command.cxx  |1 
 idl/source/prj/globals.cxx  |1 
 sc/sdi/scalc.sdi|  360 -
 sd/sdi/sdnew.sdi|3 
 sd/sdi/sdraw.sdi|  283 ---
 sfx2/sdi/sfx.sdi|  302 -
 starmath/sdi/smath.sdi  |   36 --
 svx/sdi/svx.sdi |  626 
 sw/sdi/swriter.sdi  |  419 -
 12 files changed, 2043 deletions(-)

New commits:
commit d9e362e4516a5df77f3edd12d57ce224a0a4979d
Author: Noel Grandin 
Date:   Wed Feb 3 13:23:09 2016 +0200

remove unused HasCoreId from SDI files

Change-Id: I4aca4b8a79ce92d64ce004ccdb7e9a0f408dc768

diff --git a/idl/inc/globals.hxx b/idl/inc/globals.hxx
index b748244..ab12cb7 100644
--- a/idl/inc/globals.hxx
+++ b/idl/inc/globals.hxx
@@ -43,7 +43,6 @@ struct SvGlobalHashNames
 SvStringHashEntryRef MM_Get;
 SvStringHashEntryRef MM_Set;
 SvStringHashEntryRef MM_SlotId;
-SvStringHashEntryRef MM_HasCoreId;
 SvStringHashEntryRef MM_Cachable;
 SvStringHashEntryRef MM_Volatile;
 SvStringHashEntryRef MM_Toggle;
@@ -148,7 +147,6 @@ HASH_INLINE(shell)
 HASH_INLINE(Get)
 HASH_INLINE(Set)
 HASH_INLINE(SlotId)
-HASH_INLINE(HasCoreId)
 HASH_INLINE(Cachable)
 HASH_INLINE(Volatile)
 HASH_INLINE(Toggle)
diff --git a/idl/inc/slot.hxx b/idl/inc/slot.hxx
index 8ed5d39..165388b 100644
--- a/idl/inc/slot.hxx
+++ b/idl/inc/slot.hxx
@@ -28,7 +28,6 @@ class SvMetaSlot : public SvMetaAttribute
 SvMetaTypeRef   aSlotType;
 SvMetaAttributeRef aMethod;
 SvIdentifieraGroupId;
-SvBOOL  aHasCoreId;
 SvIdentifieraConfigId;
 SvIdentifieraExecMethod;
 SvIdentifieraStateMethod;
@@ -158,7 +157,6 @@ public:
 
 SvMetaAttribute *   GetMethod() const;
 SvMetaType *GetSlotType() const;
-boolGetHasCoreId() const;
 const OString& GetGroupId() const;
 const OString& GetConfigId() const;
 const OString& GetExecMethod() const;
diff --git a/idl/source/objects/slot.cxx b/idl/source/objects/slot.cxx
index 9876016..9f0e036 100644
--- a/idl/source/objects/slot.cxx
+++ b/idl/source/objects/slot.cxx
@@ -98,11 +98,6 @@ SvMetaAttribute * SvMetaSlot::GetMethod() const
 if( aMethod.Is() || !GetRef() ) return aMethod;
 return static_cast(GetRef())->GetMethod();
 }
-bool SvMetaSlot::GetHasCoreId() const
-{
-if( aHasCoreId.IsSet() || !GetRef() ) return aHasCoreId;
-return static_cast(GetRef())->GetHasCoreId();
-}
 const OString& SvMetaSlot::GetGroupId() const
 {
 if( !aGroupId.getString().isEmpty() || !GetRef() ) return 
aGroupId.getString();
@@ -281,7 +276,6 @@ void SvMetaSlot::ReadAttributesSvIdl( SvIdlDataBase & rBase,
 bool bOk = false;
 bOk |= aDefault.ReadSvIdl( SvHash_Default(), rInStm );
 bOk |= aPseudoSlots.ReadSvIdl( SvHash_PseudoSlots(), rInStm );
-bOk |= aHasCoreId.ReadSvIdl( SvHash_HasCoreId(), rInStm );
 bOk |= aGroupId.ReadSvIdl( SvHash_GroupId(), rInStm );
 bOk |= aExecMethod.ReadSvIdl( SvHash_ExecMethod(), rInStm );
 bOk |= aStateMethod.ReadSvIdl( SvHash_StateMethod(), rInStm );
@@ -832,8 +826,6 @@ void SvMetaSlot::WriteSlot( const OString& rShellName, 
sal_uInt16 nCount,
 WriteTab( rOutStm, 4 );
 
 // write flags
-if( GetHasCoreId() )
-rOutStm.WriteCharPtr( MakeSlotName( SvHash_HasCoreId() ).getStr() 
).WriteChar( '|' );
 if( GetCachable() )
 rOutStm.WriteCharPtr( MakeSlotName( SvHash_Cachable() ).getStr() 
).WriteChar( '|' );
 if( GetVolatile() )
diff --git a/idl/source/prj/command.cxx b/idl/source/prj/command.cxx
index 1ccade4..b1c8708 100644
--- a/idl/source/prj/command.cxx
+++ b/idl/source/prj/command.cxx
@@ -84,7 +84,6 @@ char const * SyntaxStrings[] = {
 "\t\tFastCall",
 "\t\tGet, Set",
 "\t\tGroupId= Identifier",
-"\t\tHasCoreId",
 "\t\tHasDialog",
 "\t\tIsCollection",
 "\t\tImageRotation",
diff --git a/idl/source/prj/globals.cxx b/idl/source/prj/globals.cxx
index 68dba1c..6665fcc 100644
--- a/idl/source/prj/globals.cxx
+++ b/idl/source/prj/globals.cxx
@@ -71,7 +71,6 @@ SvGlobalHashNames::SvGlobalHashNames()
 , MM_Get( INS( "Get" ) )
 , MM_Set( INS( "Set" ) )
 , MM_SlotId( INS( "SlotId" ) )
-, MM_HasCoreId( INS( "HasCoreId" ) )
 , MM_Cachable( INS( "Cachable" ) )
 , MM_Toggle( INS( "Toggle" ) )
 , MM_AutoUpdate( INS( "AutoUpdate" ) )
diff --git a/sc/sdi/scalc.sdi b/sc/sdi/scalc.sdi
index fda341a..0372daf 100644
--- a/sc/sdi/scalc.sdi
+++ b/sc/sdi/scalc.sdi
@@ -23,7 +23,6 @@ SfxVoidItem AcceptChanges FID_CHG_ACCEPT
 AutoUpdate = FALSE,
 Cachable = Cachable,
 FastCall = FALSE,
-HasCoreId = FALSE,
 HasDialog = FALSE,
 ReadOnlyDoc = TRUE,
 Toggle = FALSE,
@@ -48,7 +47,6 @@ SfxVoidItem ActivateOLE SID_OLE_ACTIVATE
 AutoUp

Re: Apple Numbers application and format.

[jan iversen]

Sent from my iPad, please excuse any misspellings 

> I may have misunderstood you, but you might find answers here: 
> https://bugs.documentfoundation.org/show_bug.cgi?id=97334
> 
Thanks, Dennis really did a super job with that, which is very helpful, but it 
missed the essential part, how does the raw file look like. We have documents 
describing the ODF file formats, it is the similar thing for numbers I look for.

rgds
jan i.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: DPI and screen resolution on OS X

[Armin Le Grand]

Hi,

comments inline

Am 03.02.2016 um 12:35 schrieb SOS:


On 3/02/2016 11:32, Chris Sherlock wrote:

On 3 Feb 2016, at 7:24 PM, SOS  wrote:


On 3/02/2016 3:55, Kohei Yoshida wrote:

On Wed, 2016-02-03 at 10:52 +1100, Chris Sherlock wrote:

The other question is: why would we not want to the actual DPI and
screen resolution?

My understanding is that, historically, the OS provided a function to
query DPI but what gets returned from such function was not always
accurate (or always not accurate depending on who you ask). So, the
workaround at the time was to assume that DPI is always 96 (and
hard-code that value) regardless of what the OS told you, which worked
just fine because the monitors used back in the day had the same 
screen

resolution.
Mostly DPI is found in the header of a pixelfile (taken by camera). 
Unfortunately it's not the photographer who gets to decide about the 
needed DPI.
DPI is actually a wrong definition for documents, Dots Per Inch is a 
definition used by output devices. Screens need a PIXEL par DOT but 
for print devices there is no precise correlation between the number 
of dots used by the device and the pixels needed in  the image for 
having a maximum image-view quality.

The print industry has come to some standards by trial and error.
- monitor screens need 96 - (220-retina) pixels per inch
- laser printers need 150 pixels per inch (up tot 2000 + dots)
- offset printers need 254 -300 pixels per inch (up to 3000 dots)
Definitely true :-) Only in OS X’s case, it doesn’t actually report 
back the correct resolution unless you ask for the backing coordinate 
system.


The PPI business is a red herring I think I’ve introduced into this 
discussion I’m afraid. We calculate the PPI ourselves (and call it 
DPI) based on the reported pixels, and the size of the screen in mm 
(which we obviously convert to inches).
its a bit the wrong discussion: what we see on screen has no 
relevance: the user can "zoom" the document until he is happy with the 
image quality on screen
But in the current situation, LO users has no idea how big (size) he 
can place a image in a document.
When the doc is intented for online use (email and Web) then there is 
a minimum of 96 pixels par inch needed. More is no problem but is in 
many cases a overkill.
Who is editing a "book" or a "magazine" need minimal 254 pixels par 
inch to has a good image quality after printing.
When using less pixels the book pages  are looking fine on screen put 
shall have a creepy print quality
So having a new "DocumentProperty" indicating the needed pixels (for 
printing)  make it possible to make the "size" calculations before 
inserting.


It is relevant. If you have a vector graphic and it gets converted to 
bitmap, the DPI from the system is used to define the resulting pixel 
size. Conversion to bitmap happens more often than it might seem. Examples:

- user chooses to do so (context menu, convert to bitmap)
- some exporters who are not capable using vector graphics
- PDF, e.g. PDF/1A which is not allowed to use transprencies and solves 
by creating bitmaps where graphics and transparent parts overlap

- 3D renderer which targets to bitmaps (chart, 3D objects)
Thus, the system DPI is essential. If on Mac, the bigger DPI will be 
used, it will enlarge all these conversions.


HTH!



I guess I’m curious as to what is relying on the screen resolution 
and PPI.


Although… it’s funny that we have the function 
SalGraphics::GetResolution, but that returns the PPI!


Chris
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


--
--
ALG (PGP Key: EE1C 4B3F E751 D8BC C485 DEC1 3C59 F953 D81C F4A2)

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Apple Numbers application and format.

[Tor Lillqvist]

> We have documents describing the ODF file formats, it is the similar
thing for numbers I look for.

It is not publicly documented.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sc/inc sc/source

[Dennis Francis]

 sc/inc/dbdata.hxx  |3 ++
 sc/inc/table.hxx   |   11 ---
 sc/source/core/data/documen3.cxx   |   32 +
 sc/source/core/data/table1.cxx |1 
 sc/source/core/data/table2.cxx |   54 -
 sc/source/core/data/table5.cxx |   31 -
 sc/source/core/tool/dbdata.cxx |   26 +++--
 sc/source/ui/docshell/dbdocfun.cxx |1 
 8 files changed, 29 insertions(+), 130 deletions(-)

New commits:
commit 1e619fdf9e79cb49895d83fe7f5a1f373495b915
Author: Dennis Francis 
Date:   Fri Jan 22 22:14:54 2016 +0530

tdf#34873 : Better way to show autofilter count

This patch modifies the commit 3536fe8f4cdbacf5702e743407f34d918b6f4d38
by keeping the filtered row count inside ScDBData instead of
ScTable as suggested by Eike Rathke. This significantly reduced the
code complexity involved.

Change-Id: I30ac26061d9665ce7a749e23a636f7fb3f69b176
Reviewed-on: https://gerrit.libreoffice.org/21720
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/inc/dbdata.hxx b/sc/inc/dbdata.hxx
index bab0608..6778a94 100644
--- a/sc/inc/dbdata.hxx
+++ b/sc/inc/dbdata.hxx
@@ -97,6 +97,7 @@ private:
 
 ::std::vector< OUString > maTableColumnNames;   ///< names of table columns
 boolmbTableColumnNamesDirty;
+SCSIZE  nFilteredRowCount;
 
 using ScRefreshTimer::operator==;
 
@@ -214,6 +215,8 @@ public:
 SCsCOL nDx, SCsROW nDy, SCsTAB nDz);
 
 void ExtendDataArea(ScDocument* pDoc);
+void CalcSaveFilteredCount(SCSIZE nNonFilteredRowCount);
+void GetFilterSelCount(SCSIZE& nSelected, SCSIZE& nTotal);
 
 private:
 
diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx
index d6111dd..d2672fe 100644
--- a/sc/inc/table.hxx
+++ b/sc/inc/table.hxx
@@ -117,16 +117,6 @@ class ScHint;
 class ScTable : private boost::noncopyable
 {
 private:
-// To store an Autofilter's filtered row count
-struct FilteredRowCountData {
-SCROW nStartRow;
-SCROW nEndRow;
-SCSIZE nCount;
-FilteredRowCountData(SCROW nRow1, SCROW nRow2, SCSIZE nVal) :
-nStartRow(nRow1), nEndRow(nRow2), nCount(nVal)
-{}
-};
-
 typedef ::std::vector< ScRange > ScRangeVec;
 
 ScColumnaCol[MAXCOLCOUNT];
@@ -161,7 +151,6 @@ private:
 std::unique_ptr  mpHiddenRows;
 std::unique_ptr  mpFilteredCols;
 std::unique_ptr  mpFilteredRows;
-FilteredRowCountDatamaFilteredRowCount;
 
 ::std::set  maRowPageBreaks;
 ::std::set  maRowManualBreaks;
diff --git a/sc/source/core/data/documen3.cxx b/sc/source/core/data/documen3.cxx
index 5f632d9..aa9fbb7 100644
--- a/sc/source/core/data/documen3.cxx
+++ b/sc/source/core/data/documen3.cxx
@@ -1470,37 +1470,9 @@ void ScDocument::GetFilterSelCount( SCCOL nCol, SCROW 
nRow, SCTAB nTab, SCSIZE&
 nTotal = 0;
 if ( ValidTab(nTab) && nTab < static_cast(maTabs.size()) && 
maTabs[nTab] )
 {
-const ScDBData* pDBData = GetDBAtCursor( nCol, nRow, nTab, 
ScDBDataPortion::AREA );
+ScDBData* pDBData = GetDBAtCursor( nCol, nRow, nTab, 
ScDBDataPortion::AREA );
 if( pDBData && pDBData->HasAutoFilter() )
-{
-SCTAB nAreaTab;
-SCCOL nStartCol;
-SCROW nStartRow;
-SCCOL nEndCol;
-SCROW nEndRow;
-pDBData->GetArea( nAreaTab, nStartCol, nStartRow, nEndCol, nEndRow 
);
-
-if( pDBData->HasHeader() )
-++nStartRow;
-
-nTotal = nEndRow - nStartRow + 1;
-
-ScTable::FilteredRowCountData* pFilteredRowCount = 
&(maTabs[nTab]->maFilteredRowCount);
-// Exact range match, cache hit, early exit
-if( ( pFilteredRowCount->nStartRow == nStartRow ) && ( 
pFilteredRowCount->nEndRow == nEndRow ) &&
-( pFilteredRowCount->nCount != SCSIZE_MAX ) )
-{
-nSelected = nTotal - pFilteredRowCount->nCount;
-return;
-}
-
-// Compute the count
-nSelected = CountNonFilteredRows( nStartRow, nEndRow, nTab );
-// and store it in the cache
-pFilteredRowCount->nStartRow = nStartRow;
-pFilteredRowCount->nEndRow   = nEndRow;
-pFilteredRowCount->nCount= nTotal - nSelected;
-}
+pDBData->GetFilterSelCount( nSelected, nTotal );
 }
 }
 
diff --git a/sc/source/core/data/table1.cxx b/sc/source/core/data/table1.cxx
index e09018d..2bc2705 100644
--- a/sc/source/core/data/table1.cxx
+++ b/sc/source/core/data/table1.cxx
@@ -245,7 +245,6 @@ ScTable::ScTable( ScDocument* pDoc, SCTAB nNewTab, const 
OUString& rNewName,
 mpHiddenRows(new ScFlatBoolRowSegments),
 mpFilteredCols(new ScFlatBoolColSegments),
 mpFilteredRows(new ScFlatBoolRowSegments),
-maFilteredRowCount(

[Libreoffice-commits] core.git: starmath/source

[Michael Stahl]

 starmath/source/mathmlimport.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 4a2824e72aae407f5f2a86e6ef45278ef864d437
Author: Michael Stahl 
Date:   Wed Feb 3 14:02:22 2016 +0100

starmath: tdf#97190: don't assert on missing base URL

There are valid scenarios where we don't have a URL at all, such as when
importing MathML from the clipboard.  Also there probably isn't much of
a problem caused by missing base URLs in Math anyway since RDF import is
currently not implemented and i'm not sure if hyperlinks in Math
documents are possible at all.

Change-Id: I13b70ac62542364f329875e292c574883255af5e

diff --git a/starmath/source/mathmlimport.cxx b/starmath/source/mathmlimport.cxx
index ca557ae..36884c9 100644
--- a/starmath/source/mathmlimport.cxx
+++ b/starmath/source/mathmlimport.cxx
@@ -142,7 +142,9 @@ sal_uLong SmXMLImportWrapper::Import(SfxMedium &rMedium)
 
 // Set base URI
 OUString const baseURI(rMedium.GetBaseURL());
-assert(!baseURI.isEmpty()); // needed for relative URLs
+// needed for relative URLs; but it's OK to import e.g. MathML from the
+// clipboard without one
+SAL_INFO_IF(baseURI.isEmpty(), "starmath", "SmXMLImportWrapper: no base 
URL");
 xInfoSet->setPropertyValue("BaseURI", makeAny(baseURI));
 
 sal_Int32 nSteps=3;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

Michael Meeks  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #39 from Michael Meeks  ---
Great work - this is finally gone =)

Thanks Dipankar !

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: editeng/source filter/source idl/inc sc/source sd/source vcl/source

[Chris Sherlock]

 editeng/source/outliner/outlundo.hxx  |2 +-
 filter/source/graphicfilter/ipcx/ipcx.cxx |   24 
 idl/inc/bastype.hxx   |   26 +-
 sc/source/core/tool/rangeutl.cxx  |8 
 sc/source/filter/inc/xcl97rec.hxx |2 +-
 sc/source/filter/xcl97/xcl97rec.cxx   |6 +++---
 sd/source/ui/dlg/navigatr.cxx |   10 +-
 vcl/source/window/winproc.cxx |6 +++---
 8 files changed, 42 insertions(+), 42 deletions(-)

New commits:
commit 8db902785ed40ef388218bd5068f14f5d4bedd69
Author: Chris Sherlock 
Date:   Thu Feb 4 00:23:52 2016 +1100

tdf#94269 Replace "n" prefix for bool variables with "b"

Change-Id: I8999dc2701010424ea4d2504e99ed429030d7d4e

diff --git a/editeng/source/outliner/outlundo.hxx 
b/editeng/source/outliner/outlundo.hxx
index cb36c57..adc1554 100644
--- a/editeng/source/outliner/outlundo.hxx
+++ b/editeng/source/outliner/outlundo.hxx
@@ -69,7 +69,7 @@ private:
 public:
 OutlinerUndoChangeParaNumberingRestart( Outliner* pOutliner, sal_Int32 
nPara,
 sal_Int16 nOldNumberingStartValue, sal_Int16 mnNewNumberingStartValue,
-bool  nOldbParaIsNumberingRestart, bool nbNewParaIsNumberingRestart );
+bool  bOldbParaIsNumberingRestart, bool bNewParaIsNumberingRestart );
 
 virtual voidUndo() override;
 virtual voidRedo() override;
diff --git a/filter/source/graphicfilter/ipcx/ipcx.cxx 
b/filter/source/graphicfilter/ipcx/ipcx.cxx
index 33308a0..6710f5d 100644
--- a/filter/source/graphicfilter/ipcx/ipcx.cxx
+++ b/filter/source/graphicfilter/ipcx/ipcx.cxx
@@ -43,7 +43,7 @@ private:
 sal_uInt16  nResX, nResY;   // resolution in pixel per inch 
oder 0,0
 sal_uInt16  nDestBitsPerPixel;  // bits per pixel in destination 
bitmap 1,4,8 or 24
 sal_uInt8*  pPalette;
-boolnStatus;// from now on do not read status 
from stream ( SJ )
+boolbStatus;// from now on do not read status 
from stream ( SJ )
 
 
 voidImplReadBody(BitmapWriteAccess * pAcc);
@@ -72,7 +72,7 @@ PCXReader::PCXReader(SvStream &rStream)
 , nResX(0)
 , nResY(0)
 , nDestBitsPerPixel(0)
-, nStatus(false)
+, bStatus(false)
 {
 pPalette = new sal_uInt8[ 768 ];
 }
@@ -91,12 +91,12 @@ bool PCXReader::ReadPCX(Graphic & rGraphic)
 
 // read header:
 
-nStatus = true;
+bStatus = true;
 
 ImplReadHeader();
 
 // Write BMP header and conditionally (maybe invalid for now) color 
palette:
-if ( nStatus )
+if ( bStatus )
 {
 aBmp = Bitmap( Size( nWidth, nHeight ), nDestBitsPerPixel );
 Bitmap::ScopedWriteAccess pAcc(aBmp);
@@ -118,7 +118,7 @@ bool PCXReader::ReadPCX(Graphic & rGraphic)
 
 // If an extended color palette exists at the end of the file, then 
read it and
 // and write again in palette:
-if ( nDestBitsPerPixel == 8 && nStatus )
+if ( nDestBitsPerPixel == 8 && bStatus )
 {
 sal_uInt8* pPal = pPalette;
 m_rPCX.SeekRel(1);
@@ -136,7 +136,7 @@ bool PCXReader::ReadPCX(Graphic & rGraphic)
 rBitmap.SetPrefMapMode(aMapMode);
 rBitmap.SetPrefSize(Size(nWidth,nHeight));
 }
-*/  if ( nStatus )
+*/  if ( bStatus )
 {
 rGraphic = aBmp;
 return true;
@@ -151,7 +151,7 @@ void PCXReader::ImplReadHeader()
 m_rPCX.ReadUChar( nbyte ).ReadUChar( nVersion ).ReadUChar( nEncoding );
 if ( nbyte!=0x0a || (nVersion != 0 && nVersion != 2 && nVersion != 3 && 
nVersion != 5) || nEncoding > 1 )
 {
-nStatus = false;
+bStatus = false;
 return;
 }
 
@@ -162,7 +162,7 @@ void PCXReader::ImplReadHeader()
 
 if ((nMinX > nMaxX) || (nMinY > nMaxY))
 {
-nStatus = false;
+bStatus = false;
 return;
 }
 
@@ -191,7 +191,7 @@ void PCXReader::ImplReadHeader()
 if ( ( nDestBitsPerPixel != 1 && nDestBitsPerPixel != 4 && 
nDestBitsPerPixel != 8 && nDestBitsPerPixel != 24 )
 || nPlanes > 4 || nBytesPerPlaneLin < ( ( nWidth * nBitsPerPlanePix+7 
) >> 3 ) )
 {
-nStatus = false;
+bStatus = false;
 return;
 }
 
@@ -214,7 +214,7 @@ void PCXReader::ImplReadBody(BitmapWriteAccess * pAcc)
 //sanity check there is enough data before trying allocation
 if (nBytesPerPlaneLin > m_rPCX.remainingSize() / nPlanes)
 {
-nStatus = false;
+bStatus = false;
 return;
 }
 
@@ -226,7 +226,7 @@ void PCXReader::ImplReadBody(BitmapWriteAccess * pAcc)
 {
 if (!m_rPCX.good())
 {
-nStatus = false;
+bStatus = false;
 break;
 }
 nPercent = ny * 60 / nHeight + 10;
@@ -378,7 +378,7 @@ void PCXReader::ImplReadBody(BitmapWriteAccess * pAcc)
 }
 break;
 defa

[Libreoffice-commits] core.git: sd/inc sd/source sd/uiconfig

[Bryan Quigley]

 sd/inc/drawdoc.hxx|1 
 sd/source/core/drawdoc.cxx|6 -
 sd/source/ui/dlg/present.cxx  |4 -
 sd/source/ui/func/fusldlg.cxx |8 --
 sd/source/ui/slideshow/slideshow.cxx  |   25 ---
 sd/source/ui/slideshow/slideshowimpl.cxx  |   85 --
 sd/source/ui/view/drviewsd.cxx|   41 ++--
 sd/uiconfig/simpress/ui/presentationdialog.ui |   15 
 8 files changed, 10 insertions(+), 175 deletions(-)

New commits:
commit 2503a1e99df463aef1bf87c94b7b4a8ee3554efe
Author: Bryan Quigley 
Date:   Wed Jan 27 12:19:28 2016 -0500

tdf#96414 Remove showing navigator during slideshow

This isn't very user-friendly and the presenter console
does a much better job of this.

Change-Id: I621863b585d763fb65ed8637c3dab7b7f5ea7aed
Reviewed-on: https://gerrit.libreoffice.org/22062
Tested-by: Jenkins 
Reviewed-by: Samuel Mehrbrodt 

diff --git a/sd/inc/drawdoc.hxx b/sd/inc/drawdoc.hxx
index 9208e6c..f3a599a 100644
--- a/sd/inc/drawdoc.hxx
+++ b/sd/inc/drawdoc.hxx
@@ -126,7 +126,6 @@ namespace sd
 bool mbAnimationAllowed;
 sal_Int32 mnPauseTimeout;
 bool mbShowPauseLogo;
-bool mbStartWithNavigator;
 
 PresentationSettings();
 PresentationSettings( const PresentationSettings& r );
diff --git a/sd/source/core/drawdoc.cxx b/sd/source/core/drawdoc.cxx
index 6702e9d..62235b5 100644
--- a/sd/source/core/drawdoc.cxx
+++ b/sd/source/core/drawdoc.cxx
@@ -126,8 +126,7 @@ PresentationSettings::PresentationSettings()
 mbFullScreen( true ),
 mbAnimationAllowed( true ),
 mnPauseTimeout( 10 ),
-mbShowPauseLogo( false ),
-mbStartWithNavigator(false)
+mbShowPauseLogo( false )
 {
 }
 
@@ -144,8 +143,7 @@ PresentationSettings::PresentationSettings( const 
PresentationSettings& r )
 mbFullScreen( r.mbFullScreen ),
 mbAnimationAllowed( r.mbAnimationAllowed ),
 mnPauseTimeout( r.mnPauseTimeout ),
-mbShowPauseLogo( r.mbShowPauseLogo ),
-mbStartWithNavigator( r.mbStartWithNavigator )
+mbShowPauseLogo( r.mbShowPauseLogo )
 {
 }
 
diff --git a/sd/source/ui/dlg/present.cxx b/sd/source/ui/dlg/present.cxx
index 3fe2206..14ee529 100644
--- a/sd/source/ui/dlg/present.cxx
+++ b/sd/source/ui/dlg/present.cxx
@@ -58,7 +58,6 @@ SdStartPresentationDlg::SdStartPresentationDlg( vcl::Window* 
pWindow,
 get( aCbxManuel,"manualslides"  );
 get( aCbxMousepointer,  "pointervisible");
 get( aCbxPen,   "pointeraspen"  );
-get( aCbxNavigator, "navigatorvisible"  );
 get( aCbxAnimationAllowed,  "animationsallowed" );
 get( aCbxChangePage,"changeslidesbyclick"   );
 get( aCbxAlwaysOnTop,   "alwaysontop"   );
@@ -118,7 +117,6 @@ SdStartPresentationDlg::SdStartPresentationDlg( 
vcl::Window* pWindow,
 aCbxManuel->Check( static_cast( rOutAttrs.Get( 
ATTR_PRESENT_MANUEL ) ).GetValue() );
 aCbxMousepointer->Check( static_cast( rOutAttrs.Get( 
ATTR_PRESENT_MOUSE ) ).GetValue() );
 aCbxPen->Check( static_cast( rOutAttrs.Get( 
ATTR_PRESENT_PEN ) ).GetValue() );
-aCbxNavigator->Check( static_cast( rOutAttrs.Get( 
ATTR_PRESENT_NAVIGATOR ) ).GetValue() );
 aCbxAnimationAllowed->Check( static_cast( 
rOutAttrs.Get( ATTR_PRESENT_ANIMATION_ALLOWED ) ).GetValue() );
 aCbxChangePage->Check( static_cast( rOutAttrs.Get( 
ATTR_PRESENT_CHANGE_PAGE ) ).GetValue() );
 aCbxAlwaysOnTop->Check( static_cast( rOutAttrs.Get( 
ATTR_PRESENT_ALWAYS_ON_TOP ) ).GetValue() );
@@ -170,7 +168,6 @@ void SdStartPresentationDlg::dispose()
 aCbxManuel.clear();
 aCbxMousepointer.clear();
 aCbxPen.clear();
-aCbxNavigator.clear();
 aCbxAnimationAllowed.clear();
 aCbxChangePage.clear();
 aCbxAlwaysOnTop.clear();
@@ -301,7 +298,6 @@ void SdStartPresentationDlg::GetAttr( SfxItemSet& rAttr )
 rAttr.Put( SfxBoolItem ( ATTR_PRESENT_MANUEL, aCbxManuel->IsChecked() ) );
 rAttr.Put( SfxBoolItem ( ATTR_PRESENT_MOUSE, aCbxMousepointer->IsChecked() 
) );
 rAttr.Put( SfxBoolItem ( ATTR_PRESENT_PEN, aCbxPen->IsChecked() ) );
-rAttr.Put( SfxBoolItem ( ATTR_PRESENT_NAVIGATOR, 
aCbxNavigator->IsChecked() ) );
 rAttr.Put( SfxBoolItem ( ATTR_PRESENT_ANIMATION_ALLOWED, 
aCbxAnimationAllowed->IsChecked() ) );
 rAttr.Put( SfxBoolItem ( ATTR_PRESENT_CHANGE_PAGE, 
aCbxChangePage->IsChecked() ) );
 rAttr.Put( SfxBoolItem ( ATTR_PRESENT_ALWAYS_ON_TOP, 
aCbxAlwaysOnTop->IsChecked() ) );
diff --git a/sd/source/ui/func/fusldlg.cxx b/sd/source/ui/func/fusldlg.cxx
index f3c2f09..8cf501b 100644
--- a/sd/source/ui/func/fusldlg.cxx
+++ b/sd/source/ui/func/fusldlg.cxx
@@ -97,7 +97,6 @@ void FuSlideShowDlg::DoExecute( SfxRequest& )
 aDlgSet.Put( SfxBoolItem( ATTR_PRESENT_MANUEL, 
rPresentationSettings.mbManual ) );
 aDlgSet.Put( SfxBoolItem( ATTR_PRESENT_MOUSE, 
rPresentationSetti

[Bug 94269] Replace "n" prefix for bool variables with "b"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94269

--- Comment #9 from Commit Notification 
 ---
Chris Sherlock committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8db902785ed40ef388218bd5068f14f5d4bedd69

tdf#94269 Replace "n" prefix for bool variables with "b"

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 94269] Replace "n" prefix for bool variables with "b"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94269

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.1.0|target:5.1.0 target:5.2.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 96414] Remove feature to show Navigator during slideshow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96414

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|| target:5.2.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 96414] Remove feature to show Navigator during slideshow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96414

--- Comment #11 from Commit Notification 
 ---
Bryan Quigley committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2503a1e99df463aef1bf87c94b7b4a8ee3554efe

tdf#96414 Remove showing navigator during slideshow

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 45168] Add Option to crop (reduce size of) Images in PDF Export

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45168

--- Comment #13 from Cor Nouws  ---
So for renewing my understanding of this:
 - it is when images are croped in the document, that then at PDF-export only
that part of the image ?
 - so not the same as setting the resolution in the dialog PDF Options..

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 94269] Replace "n" prefix for bool variables with "b"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94269

Chris Sherlock  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||chris.sherloc...@gmail.com
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 96414] Remove feature to show Navigator during slideshow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96414

Samuel Mehrbrodt  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Bug 96888] Kill internal vcl dog-tags ...

[Chris Sherlock]

Finally! The fix is in - no more dog tags!

Thanks from me as well :-)

Chris

> On 4 Feb 2016, at 12:24 AM, bugzilla-dae...@bugs.documentfoundation.org wrote:
> 
> Michael Meeks  changed bug 96888 
>  
> What  Removed Added
> StatusREOPENEDRESOLVED
> Resolution--- FIXED
> 
> Comment # 39  
> on bug 96888  from 
> Michael Meeks 
> Great work - this is finally gone =)
> 
> Thanks Dipankar !
> 
> You are receiving this mail because:
> You are on the CC list for the bug.
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 97525] vcl: make DeletionListener internal ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97525

Michael Meeks  changed:

   What|Removed |Added

   Keywords||difficultyBeginner,
   ||easyHack, skillCpp,
   ||topicCleanup
 Status|UNCONFIRMED |NEW
 CC||libreoffice@lists.freedeskt
   ||op.org
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=96
   ||888
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

Michael Meeks  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=97
   ||525

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #40 from Dipankar Niranjan  ---
There are some remnants though..(Maybe two or three usages..)
ImplDelData is still used at those places..
But ImplAddDel and ImplRemoveDel along with IsDead are completely gone..
So, if the cleanup is finished I would like to say I learned a lot during this
cleanup!
Thanks for all the help..

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 97525] vcl: make DeletionListener internal ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97525

Chris Sherlock  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |chris.sherloc...@gmail.com
   |desktop.org |

--- Comment #1 from Chris Sherlock  ---
I'm happy to take this one. 

I'll try to give it to you in one patch :-) No more little patches I promise
Michael!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #41 from Michael Meeks  ---
Oh - true ! =) not quite done - would love another patch to finally kill those.

Thanks !

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #42 from Dipankar Niranjan  ---
(In reply to Michael Meeks from comment #41)
Sure.. Will do it once Grok gets updated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 87743] Pack LibreOffice for PlayOnLinux for QA

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87743

Björn Michaelsen  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #17 from Björn Michaelsen  ---
(In reply to Gouchi from comment #16)
> Scripts have been submitted. Waiting for approval.

Aaand they are apparently approved. Awesome stuff! Will tell the LibreOffice QA
list about it right away!

http://nabble.documentfoundation.org/QA-f3613148.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 97525] vcl: make DeletionListener internal ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97525

Chris Sherlock  changed:

   What|Removed |Added

   Assignee|chris.sherloc...@gmail.com  |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #2 from Chris Sherlock  ---
On second thoughts, I might welsh on this one :-)

Some other lucky person can have the pleasure! Sorry all.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - include/LibreOfficeKit libreofficekit/qa libreofficekit/source

[Pranav Kant]

 include/LibreOfficeKit/LibreOfficeKitGtk.h  |   12 ++
 libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx |   50 +
 libreofficekit/source/gtk/lokdocview.cxx|  109 +++-
 3 files changed, 166 insertions(+), 5 deletions(-)

New commits:
commit 89a3c1b4d69aac447606dc6f0e661b2ef4dddc8c
Author: Pranav Kant 
Date:   Wed Jan 27 16:56:14 2016 +0530

lokdocview: Handle password protected documents

Reviewed-on: https://gerrit.libreoffice.org/21861
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
(cherry picked from commit 18fbddcca569c109ca2f46f7d791187e672d4d83)
Signed-off-by: Michael Stahl 

Change-Id: I606a1112c8eb4c1cc4596d6947ce1223543cc87c

diff --git a/include/LibreOfficeKit/LibreOfficeKitGtk.h 
b/include/LibreOfficeKit/LibreOfficeKitGtk.h
index e06d154..1df27c1 100644
--- a/include/LibreOfficeKit/LibreOfficeKitGtk.h
+++ b/include/LibreOfficeKit/LibreOfficeKitGtk.h
@@ -275,6 +275,18 @@ gbooleanlok_doc_view_paste 
(LOKDocView*
 gsize 
nSize);
 
 /**
+ * lok_doc_view_set_document_password:
+ * @pDocView: The #LOKDocView instance
+ * @pUrl: the URL of the document to set password for, as sent with signal 
`password-required`
+ * @pPassword: (nullable): the password, NULL for no password
+ *
+ * Set the password for password protected documents
+ */
+voidlok_doc_view_set_document_password 
(LOKDocView* pDocView,
+const 
gchar* pURL,
+const 
gchar* pPassword);
+
+/**
  * lok_doc_view_pixel_to_twip:
  * @pDocView: The #LOKDocView instance
  * @fInput: The value in pixels to convert to twips
diff --git a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx 
b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
index ebf0559..fb97af1 100644
--- a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
@@ -462,10 +462,20 @@ static void toggleFindbar(GtkWidget* pButton, gpointer 
/*pItem*/)
 }
 }
 
+static void
+setLOKFeatures (GtkWidget* pDocView)
+{
+g_object_set(G_OBJECT(pDocView),
+ "doc-password", TRUE,
+ "doc-password-to-modify", TRUE,
+ nullptr);
+}
+
 /// Common initialization, regardless if it's just a new view or a full init.
 static TiledWindow& setupWidgetAndCreateWindow(GtkWidget* pDocView)
 {
 setupDocView(pDocView);
+setLOKFeatures(pDocView);
 TiledWindow aWindow;
 aWindow.m_pDocView = pDocView;
 GtkWidget* pWindow = createWindow(aWindow);
@@ -798,6 +808,45 @@ static void formulaChanged(LOKDocView* pLOKDocView, char* 
pPayload, gpointer /*p
 gtk_entry_set_text(GTK_ENTRY(rWindow.m_pFormulabarEntry), pPayload);
 }
 
+/// LOKDocView password is requried to open the document
+static void passwordRequired(LOKDocView* pLOKDocView, gchar* pUrl, gboolean 
bModify, gpointer /*pData*/)
+{
+GtkWidget* pPasswordDialog = gtk_dialog_new_with_buttons ("Password 
required",
+  GTK_WINDOW 
(gtk_widget_get_toplevel(GTK_WIDGET(pLOKDocView))),
+  GTK_DIALOG_MODAL,
+  "OK",
+  GTK_RESPONSE_OK,
+  nullptr);
+g_object_set(G_OBJECT(pPasswordDialog), "resizable", FALSE, nullptr);
+GtkWidget* pDialogMessageArea = gtk_dialog_get_content_area (GTK_DIALOG 
(pPasswordDialog));
+GtkWidget* pPasswordEntry = gtk_entry_new ();
+gtk_entry_set_visibility (GTK_ENTRY(pPasswordEntry), FALSE);
+gtk_entry_set_invisible_char (GTK_ENTRY(pPasswordEntry), '*');
+gtk_box_pack_end(GTK_BOX(pDialogMessageArea), pPasswordEntry, TRUE, TRUE, 
2);
+if (bModify)
+{
+GtkWidget* pSecondaryLabel = gtk_label_new ("Document requires 
password to edit");
+gtk_box_pack_end(GTK_BOX(pDialogMessageArea), pSecondaryLabel, TRUE, 
TRUE, 2);
+gtk_dialog_add_button (GTK_DIALOG (pPasswordDialog), "Open as 
read-only", GTK_RESPONSE_ACCEPT);
+}
+gtk_widget_show_all(pPasswordDialog);
+
+gint res = gtk_dialog_run (GTK_DIALOG(pPasswordDialog));
+switch (res)
+{
+case GTK_RESPONSE_OK:
+lok_doc_view_set_document_password (pLOKDocView, pUrl, 
gtk_entry_get_text(GTK_ENTRY(pPasswordEntry)));
+break;
+case GTK_RESPONSE_ACCEPT:
+// User accepts to open this document as read-only
+case GTK_RESPONSE_DELETE_EVENT:
+lok_doc_view_set_document_password (pLOKDocView, pUrl, nullptr);
+break;
+}
+
+gtk_widget_destroy(pPasswordDialog);
+}
+
 static vo

[Bug 97527] vcl: reference-count Menu ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97527

Michael Meeks  changed:

   What|Removed |Added

   Keywords||difficultyInteresting,
   ||easyHack, skillCpp,
   ||topicCleanup
 Status|UNCONFIRMED |NEW
 CC||chris.sherloc...@gmail.com,
   ||libreoffice@lists.freedeskt
   ||op.org
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 97525] vcl: make DeletionListener internal ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97525

--- Comment #3 from Michael Meeks  ---
Heh - my hope was that Nurhak might do this one =)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 97527] vcl: reference-count Menu ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97527

Chris Sherlock  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |chris.sherloc...@gmail.com
   |desktop.org |

--- Comment #1 from Chris Sherlock  ---
I'll take this one. This is going to be interesting :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: cui/source

[akki95]

 cui/source/options/optjava.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 5008b9a692296ab72e08d397a49d11d0f83c
Author: akki95 
Date:   Wed Feb 3 04:54:01 2016 +0530

tdf#96132 Enabling Experimental Features in UI doesn't warn about restart

Change-Id: I2efafee4f8ebd4cd7ba2b7a23f68ca08022eb659
Reviewed-on: https://gerrit.libreoffice.org/22064
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 

diff --git a/cui/source/options/optjava.cxx b/cui/source/options/optjava.cxx
index ed32628..6c8e805 100644
--- a/cui/source/options/optjava.cxx
+++ b/cui/source/options/optjava.cxx
@@ -665,6 +665,8 @@ bool SvxJavaOptionsPage::FillItemSet( SfxItemSet* 
/*rCoreSet*/ )
 SvtMiscOptions aMiscOpt;
 aMiscOpt.SetExperimentalMode( m_pExperimentalCB->IsChecked() );
 bModified = true;
+ScopedVclPtrInstance< MessageDialog > aWarnBox( this, CUI_RES( 
RID_SVXSTR_OPTIONS_RESTART ), VCL_MESSAGE_INFO );
+aWarnBox->Execute();
 }
 
 if ( m_pMacroCB->IsValueChangedFromSaved() )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 96132] Enabling Experimental Features in the UI doesn't inform the user that LibO needs to be restarted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96132

--- Comment #7 from Commit Notification 
 ---
akki95 committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5008b9a692296ab72e08d397a49d11d0f83c

tdf#96132 Enabling Experimental Features in UI doesn't warn about restart

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 96132] Enabling Experimental Features in the UI doesn't inform the user that LibO needs to be restarted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96132

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|| target:5.2.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 96132] Enabling Experimental Features in the UI doesn't inform the user that LibO needs to be restarted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96132

Samuel Mehrbrodt  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from Samuel Mehrbrodt  ---
(In reply to Markus Mohrhard (retired) from comment #5)
> That is actually not completely true.
> 
> There are many experimental features that work without a restart. The better
> question is which ones don't and then check if they can't be made to work
> without it. Especially as we now have a configuration change listener.

Closing this bug. Markus, maybe you can create a new bug where you describe
your idea?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sc/inc sc/source

[Arul]

 sc/inc/table.hxx   |2 +-
 sc/source/core/data/document10.cxx |2 +-
 sc/source/core/data/table7.cxx |5 -
 sc/source/ui/view/viewfun3.cxx |   22 --
 4 files changed, 22 insertions(+), 9 deletions(-)

New commits:
commit 403ca446458268ae04d42f666223974f525e8df8
Author: Arul 
Date:   Thu Jan 21 18:22:51 2016 +0530

tdf#89140:Calc row paste doesn't keep row height

Change-Id: Ibf9a5674711cf496706c4d3ac9d3133016aea39d
Reviewed-on: https://gerrit.libreoffice.org/21665
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx
index d2672fe..0e84a70 100644
--- a/sc/inc/table.hxx
+++ b/sc/inc/table.hxx
@@ -428,7 +428,7 @@ public:
 sc::CopyFromClipContext& rCxt, const ScTable& rClipTab, 
sc::ColumnSpanSet& rBroadcastSpans );
 
 void CopyOneCellFromClip(
-sc::CopyFromClipContext& rCxt, SCCOL nCol1, SCROW nRow1, SCCOL nCol2, 
SCROW nRow2 );
+sc::CopyFromClipContext& rCxt, SCCOL nCol1, SCROW nRow1, SCCOL nCol2, 
SCROW nRow2, SCROW nSrcRow, ScTable* pSrcTab );
 
 void CopyFromClip(
 sc::CopyFromClipContext& rCxt, SCCOL nCol1, SCROW nRow1, SCCOL nCol2, 
SCROW nRow2,
diff --git a/sc/source/core/data/document10.cxx 
b/sc/source/core/data/document10.cxx
index 8b0..a2f13920 100644
--- a/sc/source/core/data/document10.cxx
+++ b/sc/source/core/data/document10.cxx
@@ -117,7 +117,7 @@ bool ScDocument::CopyOneCellFromClip(
 SCTAB nTabEnd = rCxt.getTabEnd();
 for (SCTAB i = rCxt.getTabStart(); i <= nTabEnd && i < 
static_cast(maTabs.size()); ++i)
 {
-maTabs[i]->CopyOneCellFromClip(rCxt, nCol1, nRow1, nCol2, nRow2);
+maTabs[i]->CopyOneCellFromClip(rCxt, nCol1, nRow1, nCol2, nRow2,  
aClipRange.aStart.Row(), pSrcTab);
 if (rCxt.getInsertFlag() & InsertDeleteFlags::ATTRIB)
 for (SCROW nRow = nRow1; nRow <= nRow2; ++nRow)
 {
diff --git a/sc/source/core/data/table7.cxx b/sc/source/core/data/table7.cxx
index f940ee5..6c0cefa 100644
--- a/sc/source/core/data/table7.cxx
+++ b/sc/source/core/data/table7.cxx
@@ -52,7 +52,7 @@ void ScTable::DeleteBeforeCopyFromClip(
 }
 
 void ScTable::CopyOneCellFromClip(
-sc::CopyFromClipContext& rCxt, SCCOL nCol1, SCROW nRow1, SCCOL nCol2, 
SCROW nRow2 )
+sc::CopyFromClipContext& rCxt, SCCOL nCol1, SCROW nRow1, SCCOL nCol2, 
SCROW nRow2, SCROW nSrcRow, ScTable* pSrcTab )
 {
 ScRange aSrcRange = rCxt.getClipDoc()->GetClipParam().getWholeRange();
 SCCOL nSrcColSize = aSrcRange.aEnd.Col() - aSrcRange.aStart.Col() + 1;
@@ -64,6 +64,9 @@ void ScTable::CopyOneCellFromClip(
 assert(nColOffset >= 0);
 aCol[nCol].CopyOneCellFromClip(rCxt, nRow1, nRow2, nColOffset);
 }
+
+if (nCol1 == 0 && nCol2 == MAXCOL && mpRowHeights)
+mpRowHeights->setValue(nRow1, nRow2, 
pSrcTab->GetOriginalHeight(nSrcRow));
 }
 
 void ScTable::SetValues( SCCOL nCol, SCROW nRow, const std::vector& 
rVals )
diff --git a/sc/source/ui/view/viewfun3.cxx b/sc/source/ui/view/viewfun3.cxx
index 1e6a216..77b0fad 100644
--- a/sc/source/ui/view/viewfun3.cxx
+++ b/sc/source/ui/view/viewfun3.cxx
@@ -1505,11 +1505,12 @@ bool ScViewFunc::PasteMultiRangesFromClip(
 return false;
 }
 
+bool bRowInfo = ( aMarkedRange.aStart.Col()==0 && 
aMarkedRange.aEnd.Col()==MAXCOL );
 ::std::unique_ptr pUndoDoc;
 if (pDoc->IsUndoEnabled())
 {
 pUndoDoc.reset(new ScDocument(SCDOCMODE_UNDO));
-pUndoDoc->InitUndoSelected(pDoc, aMark);
+pUndoDoc->InitUndoSelected(pDoc, aMark, false, bRowInfo);
 pDoc->CopyToDocument(aMarkedRange, nUndoFlags, false, pUndoDoc.get(), 
&aMark);
 }
 
@@ -1549,10 +1550,15 @@ bool ScViewFunc::PasteMultiRangesFromClip(
  true, false, false, true);
 }
 
-ScRange aTmp = aMarkedRange;
-aTmp.aStart.SetTab(nTab1);
-aTmp.aEnd.SetTab(nTab1);
-pDocSh->PostPaint(aTmp, PAINT_GRID);
+if (bRowInfo)
+pDocSh->PostPaint(aMarkedRange.aStart.Col(), 
aMarkedRange.aStart.Row(), nTab1, MAXCOL, MAXROW, nTab1, PAINT_GRID|PAINT_LEFT);
+else
+{
+ScRange aTmp = aMarkedRange;
+aTmp.aStart.SetTab(nTab1);
+aTmp.aEnd.SetTab(nTab1);
+pDocSh->PostPaint(aTmp, PAINT_GRID);
+}
 
 if (pDoc->IsUndoEnabled())
 {
@@ -1712,7 +1718,11 @@ bool ScViewFunc::PasteFromClipToMultiRanges(
 
 // Refresh the range that includes all pasted ranges.  We only need to
 // refresh the current sheet.
-pDocSh->PostPaint(aRanges, PAINT_GRID);
+sal_uInt16 nPaint = PAINT_GRID;
+bool bRowInfo = (aSrcRange.aStart.Col()==0 &&  
aSrcRange.aEnd.Col()==MAXCOL);
+if (bRowInfo)
+nPaint |= PAINT_LEFT;
+pDocSh->PostPaint(aRanges, nPaint);
 
 if (pDoc->IsUndoEnabled())
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/cp-5.0-21'

[Ricardo Palomares]

Tag 'cp-5.0-21' created by Andras Timar  at 
2016-02-03 14:22 -0800

cp-5.0-21

Changes since cp-5.0-18-2:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] translations.git: Changes to 'refs/tags/cp-5.0-21'

[Christian Lohmaier]

Tag 'cp-5.0-21' created by Andras Timar  at 
2016-02-03 14:22 -0800

cp-5.0-21

Changes since cp-5.0-14-23:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: Changes to 'refs/tags/cp-5.0-21'

[Christian Lohmaier]

Tag 'cp-5.0-21' created by Andras Timar  at 
2016-02-03 14:22 -0800

cp-5.0-21

Changes since cp-5.0-18:
Christian Lohmaier (1):
   should not be empty/self-closing element ()

---
 source/text/shared/01/0222.xhp  |2 +-
 source/text/swriter/01/04020100.xhp |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-5.0-21'

[Andras Timar]

Tag 'cp-5.0-21' created by Andras Timar  at 
2016-02-03 14:22 -0800

cp-5.0-21

Changes since cp-5.0-20-33:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/milestone-7' - 2 commits - loolwsd/configure.ac

[Andras Timar]

 loolwsd/configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c69535b67cb597b6b2f978a41f6a3b7b5789f205
Author: Andras Timar 
Date:   Wed Feb 3 15:19:16 2016 +0100

loolwsd: bump version after tarball

diff --git a/loolwsd/configure.ac b/loolwsd/configure.ac
index 87f2180..c7516d5 100644
--- a/loolwsd/configure.ac
+++ b/loolwsd/configure.ac
@@ -3,7 +3,7 @@
 
 AC_PREREQ([2.69])
 
-AC_INIT([loolwsd], [1.4.38], [libreoff...@collabora.com])
+AC_INIT([loolwsd], [1.4.39], [libreoff...@collabora.com])
 
 AM_INIT_AUTOMAKE([1.11 silent-rules subdir-objects])
 
commit b1e4f210bc85c899b9602995f582276ae5fdccbf
Author: Andras Timar 
Date:   Wed Feb 3 15:08:18 2016 +0100

loolwsd: bump version before tarball

diff --git a/loolwsd/configure.ac b/loolwsd/configure.ac
index 6eccd77..87f2180 100644
--- a/loolwsd/configure.ac
+++ b/loolwsd/configure.ac
@@ -3,7 +3,7 @@
 
 AC_PREREQ([2.69])
 
-AC_INIT([loolwsd], [1.4.37], [libreoff...@collabora.com])
+AC_INIT([loolwsd], [1.4.38], [libreoff...@collabora.com])
 
 AM_INIT_AUTOMAKE([1.11 silent-rules subdir-objects])
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 97525] vcl: make DeletionListener internal ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97525

--- Comment #4 from NURHAK ALTIN  ---
Now, I'm on that bug thanks for orientation =)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Can no longer login to ask.libreoffice.org

[Regina Henschel]

Hi,

I try to login with my AskLibO user name and password. Neither the user 
name regina nor the email rb.hensc...@t-online.de works.


When I do "Recover account" I get an email with a link. I click the link 
and I reach my account to enter a new password. I can enter the password 
and then login is done. I can see my account informations. But when I 
then logout and try to login again, the same happens. No login possible.


I have tried it with different browsers and different PCs.

I need help for login. Who is responsible for ask.libreoffice.org and 
can look what is wrong with my account?


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Can no longer login to ask.libreoffice.org

[Sophie]

Hi Regina,

I'm adding the website list on copy, I get the same issue and can't do
the moderation, I don't know what is happening.

Cheers
Sophie
Le 03/02/2016 15:53, Regina Henschel a écrit :
> Hi,
> 
> I try to login with my AskLibO user name and password. Neither the user
> name regina nor the email rb.hensc...@t-online.de works.
> 
> When I do "Recover account" I get an email with a link. I click the link
> and I reach my account to enter a new password. I can enter the password
> and then login is done. I can see my account informations. But when I
> then logout and try to login again, the same happens. No login possible.
> 
> I have tried it with different browsers and different PCs.
> 
> I need help for login. Who is responsible for ask.libreoffice.org and
> can look what is wrong with my account?
> 
> Kind regards
> Regina
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice


-- 
Sophie Gautier sophie.gaut...@documentfoundation.org
GSM: +33683901545
IRC: sophi
Co-founder - Release coordinator
The Document Foundation
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 90855] DIALOG: Improve the 'Insert Bookmark' dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90855

Samuel Mehrbrodt  changed:

   What|Removed |Added

   Keywords|needsDevEval|difficultyInteresting,
   ||easyHack, skillCpp
 CC|libreoffice-ux-advise@lists |libreoffice@lists.freedeskt
   |.freedesktop.org|op.org,
   ||samuel.mehrbr...@cib.de

--- Comment #5 from Samuel Mehrbrodt  ---
EasyHack:
The ui file is in sw/uiconfig/swriter/ui/insertbookmark.ui and the code in
sw/source/ui/misc/bookmark.cxx .

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [libreoffice-website] Re: Can no longer login to ask.libreoffice.org

[Florian Effenberger]

Hi,

Sophie wrote on 2016-02-03 at 16:00:

I'm adding the website list on copy, I get the same issue and can't do
the moderation, I don't know what is happening.


I just tried and can login without a problem - does this problem still 
exist? Maybe it was just temporary?


Florian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sd/qa svx/source

[Xisco Fauli]

 sd/qa/unit/import-tests.cxx|3 +--
 svx/source/table/cell.cxx  |2 +-
 svx/source/table/tablelayouter.cxx |   12 +++-
 3 files changed, 13 insertions(+), 4 deletions(-)

New commits:
commit 7583d19a58f9aa0fed51c248c1773285e2cb39cf
Author: Xisco Fauli 
Date:   Thu Jan 21 20:56:31 2016 +0100

tdf#91762: Check wether the row and the cell have text...

... in order to set the row's min height

Regression from 4f2c8194f485b1527fb4f4dfe23ce804937f1f9c
After this commit, the row's min height was set based only on
the cells containing text in the row, but the problem appeared
when the row didn't have any cell with text.
Change logic to check wether there's text in the cell and in the row.

Now, height in SdImportTest::testRowHeight() is 507 instead of
508 but I can't figure it out why. However, I believe there's
no harm in change the test from 508 to 507 as, visually speaking,
the difference can't be distinguish.

Change-Id: I0b3a14c34eaeaa8e77227860ca290fb79a0302ce
Reviewed-on: https://gerrit.libreoffice.org/21692
Tested-by: Jenkins 
Reviewed-by: jan iversen 
(cherry picked from commit 13d4398820ded5914f635757865e258db2db2b57)
Reviewed-on: https://gerrit.libreoffice.org/22009
Reviewed-by: Katarina Behrens 

diff --git a/sd/qa/unit/import-tests.cxx b/sd/qa/unit/import-tests.cxx
index 53f14e8..3c9f720 100644
--- a/sd/qa/unit/import-tests.cxx
+++ b/sd/qa/unit/import-tests.cxx
@@ -1232,9 +1232,8 @@ void SdImportTest::testRowHeight()
 uno::Reference< com::sun::star::table::XTableRows > xRows( 
xTable->getRows(), uno::UNO_QUERY_THROW);
 uno::Reference< beans::XPropertySet > xRefRow( xRows->getByIndex(0), 
uno::UNO_QUERY_THROW );
 xRefRow->getPropertyValue( sHeight ) >>= nHeight;
-CPPUNIT_ASSERT_EQUAL( sal_Int32(508), nHeight);
+CPPUNIT_ASSERT_EQUAL( sal_Int32(507), nHeight);
 }
-
 void SdImportTest::testTdf93830()
 {
 // Text shape offset was ignored
diff --git a/svx/source/table/cell.cxx b/svx/source/table/cell.cxx
index 71da0f1..26b66bd 100644
--- a/svx/source/table/cell.cxx
+++ b/svx/source/table/cell.cxx
@@ -727,7 +727,7 @@ sal_Int32 Cell::getMinimumHeight()
 pEditOutliner->SetMaxAutoPaperSize(aSize);
 nMinimumHeight = pEditOutliner->GetTextHeight()+1;
 }
-else if ( hasText() )
+else
 {
 Outliner& rOutliner=rTableObj.ImpGetDrawOutliner();
 rOutliner.SetPaperSize(aSize);
diff --git a/svx/source/table/tablelayouter.cxx 
b/svx/source/table/tablelayouter.cxx
index 0793e77..ee66352 100644
--- a/svx/source/table/tablelayouter.cxx
+++ b/svx/source/table/tablelayouter.cxx
@@ -688,6 +688,7 @@ void TableLayouter::LayoutTableHeight( Rectangle& rArea, 
bool bFit )
 sal_Int32 nMinHeight = 0;
 
 bool bIsEmpty = true; // check if all cells in this row are merged
+bool bRowHasText = false;
 
 for( nCol = 0; nCol < nColCount; ++nCol )
 {
@@ -704,7 +705,16 @@ void TableLayouter::LayoutTableHeight( Rectangle& rArea, 
bool bFit )
 }
 else
 {
-nMinHeight = std::max( nMinHeight, 
xCell->getMinimumHeight() );
+bool bCellHasText = xCell->hasText();
+if ( (!bRowHasText && !bCellHasText) || ( bRowHasText && 
bCellHasText ) )
+{
+nMinHeight = std::max( nMinHeight, 
xCell->getMinimumHeight() );
+}
+else if ( !bRowHasText && bCellHasText )
+{
+bRowHasText = true;
+nMinHeight = xCell->getMinimumHeight();
+}
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[kumar]

 sc/source/ui/app/inputhdl.cxx |   18 ++
 1 file changed, 14 insertions(+), 4 deletions(-)

New commits:
commit 94aff0c21989e8be46b1676cef4d2a1db61752d3
Author: kumar 
Date:   Thu Jan 21 18:41:50 2016 +0530

tdf#93936:while creating formula comma appends incorrectly using Ctrl key

Change-Id: I6d0e210f11e52dd16cbd61b1da22d79064796efc
Reviewed-on: https://gerrit.libreoffice.org/21667
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx
index 98783dc..d567842 100644
--- a/sc/source/ui/app/inputhdl.cxx
+++ b/sc/source/ui/app/inputhdl.cxx
@@ -2975,10 +2975,20 @@ void ScInputHandler::AddRefEntry()
 DataChanging(); // Cannot be new
 
 RemoveSelection();
-if (pTableView)
-pTableView->InsertText( OUString(cSep) );
-if (pTopView)
-pTopView->InsertText( OUString(cSep) );
+OUString aText = GetEditText(pEngine);
+sal_Unicode cLastChar = 0;
+sal_Int32 nPos = aText.getLength() - 1;
+while (nPos >= 0 && ((cLastChar = aText[nPos]) == ' ')) //checking space
+--nPos;
+
+bool bAppendSeparator = (cLastChar != '(' && cLastChar != cSep && 
cLastChar != '=');
+if (bAppendSeparator)
+{
+if (pTableView)
+pTableView->InsertText( OUString(cSep) );
+if (pTopView)
+pTopView->InsertText( OUString(cSep) );
+}
 
 DataChanged();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits