date:20150716

About fix for tdf#82744: on gerritt, need help

2015-07-16 Thread Giuseppe Castagno


Hi all,

I pushed the preliminary version of the fix, I have trouble with the 
build on Windows, I build in Linux only, and being the fault in Windows 
in an entirely different code area, I fail to see where the culprit lies.


I said preliminary because there is still something that's nagging me on 
a couple of occasions:


- when a file is first created and the lock is put on the null resource,
an operation the RFC4918 allows;

- when you operate on a web site that has has no lock functionality 
available.


The two question are related to each other, both already work, but 
locking at the net log, there seems to be something I need to check more 
thoroughly.


Thanks

--
Kind Regards,
Giuseppe Castagno aka beppec56
Acca Esse http://www.acca-esse.eu
giuseppe.castagno at acca-esse.eu
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Approximating a missing platform with gerrit

2015-07-16 Thread Stephan Bergmann

Our gerrit/jenkins setup is fine in detecting change requests that would 
break the build.  But when you try to (mis-)use it to modify a change 
request until it passes on all platforms (because you don't have direct 
access to one of the platforms, say), the situation is not that ideal. 
As I recently experienced when I tried to get 
 "Make content of OSL_ASSERT, 
DBG_ASSERT, etc. visiblie in non-debug builds" to build on Windows---and 
ultimately resorted to a local Windows build anyway, to speed things up.


I do understand that this may be issues in the design of the setup that 
are hard to overcome, but wanted to dump this food for thought anyway:


* Once two of the three platforms are known to compile a give change 
fine, it would be nice if one could requests builds of new versions of 
the change for only one specific platform (esp. when then newly made 
modifications are in platform-specific code, so should not affect the 
already-good platforms anyway).  Could save time and reduce (real-world) 
waste.


* Sometimes, a build fails for spurious reasons midway through, and you 
need to start another build.  But the only way to re-trigger a build is 
to rebase the change.  (The downsides are: disrupts the history of the 
change's revisions; the rebased-upon master revision itself may be 
broken; and there just might not be a new master revision to rebase 
against yet at all)  It would be nice if one could force rebuilds of 
already built change request vesions.  (In my example, this happend at 
patch sets 6 -> 7.)


* In cases like in my example, where the change breaks platform-specific 
code in various places in the code base, it can be tedious and wasteful 
to find all those places incrementally, one place per new build.  It 
would be nice if one could trigger builds that employ "make -k".

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: unotools/source

2015-07-16 Thread Caolán McNamara

 unotools/source/config/lingucfg.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 91f41ac71a773e2016f2f53e08e85c5fc065999d
Author: CaolÃ¡n McNamara 
Date:   Thu Jul 16 08:48:30 2015 +0100

WaE: -Wmaybe-uninitialized

Change-Id: Ie49c6a8067c5223bbe3c86505aa909c2bd5d3c93

diff --git a/unotools/source/config/lingucfg.cxx 
b/unotools/source/config/lingucfg.cxx
index 2439cd4..5bda4e6 100644
--- a/unotools/source/config/lingucfg.cxx
+++ b/unotools/source/config/lingucfg.cxx
@@ -569,7 +569,7 @@ bool SvtLinguConfigItem::LoadOptions( const uno::Sequence< 
OUString > &rProperyN
 for (sal_Int32 i = 0;  i < nProps;  ++i)
 {
 const uno::Any &rVal = pValue[i];
-sal_Int32 nPropertyHandle;
+sal_Int32 nPropertyHandle(0);
 GetHdlByName( nPropertyHandle, pProperyNames[i], true );
 switch ( nPropertyHandle )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svgio/inc svgio/source

2015-07-16 Thread Noel Grandin

 svgio/inc/svgio/svgreader/svgcharacternode.hxx   |3 ---
 svgio/inc/svgio/svgreader/svgdocument.hxx|1 -
 svgio/inc/svgio/svgreader/svgstyleattributes.hxx |7 ---
 svgio/inc/svgio/svgreader/svgsvgnode.hxx |1 -
 svgio/inc/svgio/svgreader/svgsymbolnode.hxx  |2 --
 svgio/inc/svgio/svgreader/svgtextpathnode.hxx|2 --
 svgio/inc/svgio/svgreader/svgtools.hxx   |1 -
 svgio/inc/svgio/svgreader/svgusenode.hxx |2 --
 svgio/source/svgreader/svgcharacternode.cxx  |3 +--
 9 files changed, 1 insertion(+), 21 deletions(-)

New commits:
commit ee79541aa892ff218e1dc3f869a3ac11b6f296ba
Author: Noel Grandin 
Date:   Wed Jul 15 15:28:37 2015 +0200

loplugin:unusedmethods svgio

Change-Id: I0dd601429b70dc09780e31079a6f7c0570652fe9
Reviewed-on: https://gerrit.libreoffice.org/17114
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/svgio/inc/svgio/svgreader/svgcharacternode.hxx 
b/svgio/inc/svgio/svgreader/svgcharacternode.hxx
index 192f24d..23d7809 100644
--- a/svgio/inc/svgio/svgreader/svgcharacternode.hxx
+++ b/svgio/inc/svgio/svgreader/svgcharacternode.hxx
@@ -101,7 +101,6 @@ namespace svgio
 /// bitfield
 boolmbLengthAdjust : 1; // true = spacing, 
false = spacingAndGlyphs
 boolmbAbsoluteX : 1;
-boolmbAbsoluteY : 1;
 
 public:
 SvgTextPosition(
@@ -112,11 +111,9 @@ namespace svgio
 // data read access
 const SvgTextPosition* getParent() const { return mpParent; }
 const ::std::vector< double >& getX() const { return maX; }
-const ::std::vector< double >& getY() const { return maY; }
 double getTextLength() const { return mfTextLength; }
 bool getLengthAdjust() const { return mbLengthAdjust; }
 bool getAbsoluteX() const { return mbAbsoluteX; }
-bool getAbsoluteY() const { return mbAbsoluteY; }
 
 // get/set absolute, current, advancing position
 const basegfx::B2DPoint& getPosition() const { return maPosition; }
diff --git a/svgio/inc/svgio/svgreader/svgdocument.hxx 
b/svgio/inc/svgio/svgreader/svgdocument.hxx
index e0d0141..46aee7a 100644
--- a/svgio/inc/svgio/svgreader/svgdocument.hxx
+++ b/svgio/inc/svgio/svgreader/svgdocument.hxx
@@ -61,7 +61,6 @@ namespace svgio
 void removeSvgNodeFromMapper(const OUString& rStr);
 
 /// find a node by its Id
-bool hasSvgNodesById() const { return 
!maIdTokenMapperList.empty(); }
 const SvgNode* findSvgNodeById(const OUString& rStr) const;
 
 /// add/remove styles to mapper
diff --git a/svgio/inc/svgio/svgreader/svgstyleattributes.hxx 
b/svgio/inc/svgio/svgreader/svgstyleattributes.hxx
index 5a67aa1..cb1982d 100644
--- a/svgio/inc/svgio/svgreader/svgstyleattributes.hxx
+++ b/svgio/inc/svgio/svgreader/svgstyleattributes.hxx
@@ -335,7 +335,6 @@ namespace svgio
 
 /// fill rule content
 FillRule getFillRule() const;
-void setFillRule(const FillRule aFillRule = FillRule_notset) { 
maFillRule = aFillRule; }
 
 /// fill StrokeDasharray content
 const SvgNumberVector& getStrokeDasharray() const;
@@ -382,7 +381,6 @@ namespace svgio
 void setFontStyle(const FontStyle aFontStyle = FontStyle_notset) { 
maFontStyle = aFontStyle; }
 
 /// FontVariant content
-FontVariant getFontVariant() const;
 void setFontVariant(const FontVariant aFontVariant = 
FontVariant_notset) { maFontVariant = aFontVariant; }
 
 /// FontWeight content
@@ -427,26 +425,21 @@ namespace svgio
 
 // ClipPathXLink content
 const OUString getClipPathXLink() const { return maClipPathXLink; }
-void setClipPathXLink(const OUString& rNew) { maClipPathXLink = 
rNew; }
 
 // MaskXLink content
 const OUString getMaskXLink() const { return maMaskXLink; }
-void setMaskXLink(const OUString& rNew) { maMaskXLink = rNew; }
 
 // MarkerStartXLink content
 OUString getMarkerStartXLink() const;
 const SvgMarkerNode* accessMarkerStartXLink() const;
-void setMarkerStartXLink(const OUString& rNew) { 
maMarkerStartXLink = rNew; }
 
 // MarkerMidXLink content
 OUString getMarkerMidXLink() const;
 const SvgMarkerNode* accessMarkerMidXLink() const;
-void setMarkerMidXLink(const OUString& rNew) { maMarkerMidXLink = 
rNew; }
 
 // MarkerEndXLink content
 OUString getMarkerEndXLink() const;
 const SvgMarkerNode* accessMarkerEndXLink() const;
-void setMarkerEndXLink(const OUString& rNew) { maMarkerEndXLink = 
rNew; }
 
 // BaselineShift
 void setBaselineShift(const Baselin

[Libreoffice-commits] core.git: 92 commits - fpicker/Library_fps_office.mk fpicker/source framework/inc framework/Library_fwk.mk framework/source framework/util icon-themes/breeze icon-themes/tango in

2015-07-16 Thread Szymon Kłos

 fpicker/Library_fps_office.mk   |1 
 fpicker/source/office/OfficeFilePicker.cxx  |   79 
 fpicker/source/office/OfficeFilePicker.hxx  |   39 
 fpicker/source/office/OfficeFolderPicker.cxx|2 
 fpicker/source/office/OfficeFolderPicker.hxx|2 
 fpicker/source/office/RemoteFilesDialog.cxx |  980 
++
 fpicker/source/office/RemoteFilesDialog.hxx |  171 +
 fpicker/source/office/commonpicker.hxx  |8 
 fpicker/source/office/fpdialogbase.hxx  |  113 +
 fpicker/source/office/fps_office.component  |3 
 fpicker/source/office/fps_office.cxx|6 
 fpicker/source/office/iodlg.cxx |4 
 fpicker/source/office/iodlg.hxx |   41 
 framework/Library_fwk.mk|1 
 framework/inc/classes/resource.hrc  |2 
 framework/source/classes/resource.src   |   10 
 framework/source/uielement/recentfilesmenucontroller.cxx|   20 
 framework/source/uielement/saveasmenucontroller.cxx |  192 +
 framework/util/fwk.component|4 
 icon-themes/breeze/links.txt|2 
 icon-themes/tango/links.txt |2 
 include/sfx2/app.hxx|1 
 include/sfx2/filedlghelper.hxx  |1 
 include/sfx2/sfxsids.hrc|3 
 include/sfx2/tbxctrl.hxx|   15 
 include/svtools/PlaceEditDialog.hxx |8 
 include/svtools/ServerDetailsControls.hxx   |   12 
 include/svtools/breadcrumb.hxx  |   64 
 include/svtools/foldertree.hxx  |   56 
 include/ucbhelper/simpleauthenticationrequest.hxx   |8 
 officecfg/registry/data/org/openoffice/Office/Common.xcu|   21 
 officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu   |8 
 officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu |   11 
 officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu |8 
 officecfg/registry/data/org/openoffice/Setup.xcu|1 
 officecfg/registry/schema/org/openoffice/Office/Common.xcs  |5 
 sc/source/ui/app/scdll.cxx  |1 
 sc/uiconfig/scalc/toolbar/standardbar.xml   |3 
 sfx2/sdi/docslots.sdi   |9 
 sfx2/sdi/sfx.sdi|   51 
 sfx2/source/appl/appopen.cxx|   10 
 sfx2/source/appl/appuno.cxx |2 
 sfx2/source/dialog/backingwindow.cxx|   12 
 sfx2/source/dialog/backingwindow.hxx|1 
 sfx2/source/dialog/filedlghelper.cxx|2 
 sfx2/source/doc/guisaveas.cxx   |   47 
 sfx2/source/doc/objserv.cxx |6 
 sfx2/source/toolbox/tbxitem.cxx |   50 
 sfx2/uiconfig/ui/startcenter.ui |   44 
 svtools/Library_svt.mk  |2 
 svtools/UIConfig_svt.mk |1 
 svtools/source/contnr/foldertree.cxx|  116 +
 svtools/source/control/breadcrumb.cxx   |  225 ++
 svtools/source/dialogs/PlaceEditDialog.cxx  |   99 -
 svtools/source/dialogs/ServerDetailsControls.cxx|  107 -
 svtools/uiconfig/ui/placeedit.ui|  826 
+++-
 svtools/uiconfig/ui/remotefilesdialog.ui|  241 ++
 sw/source/uibase/app/swmodule.cxx   |1 
 sw/uiconfig/swriter/toolbar/standardbar.xml |3 
 ucb/source/ucp/cmis/auth_provider.cxx   |2 
 ucb/source/ucp/cmis/cmis_content.cxx|9 
 ucb/source/ucp/cmis/cmis_repo_content.cxx   |5 
 ucbhelper/source/provider/simpleauthenticationrequest.cxx   |   32 
 63 files changed, 3159 insertions(+), 652 deletions(-)

New commits:
commit c09512c30bdaede606547a246d755cda0154cf33

[Libreoffice-commits] core.git: include/sfx2

2015-07-16 Thread Stephan Bergmann

 include/sfx2/event.hxx |   19 ---
 1 file changed, 19 deletions(-)

New commits:
commit f013178f078d2670b5d7d677ab17edd115de53d7
Author: Stephan Bergmann 
Date:   Thu Jul 16 10:02:08 2015 +0200

Remove unused SfxViewEventHint

Change-Id: I42200260b98f90978d2c214fd9ea77376ab8cd8d

diff --git a/include/sfx2/event.hxx b/include/sfx2/event.hxx
index e3a01c8..0eb1d5d 100644
--- a/include/sfx2/event.hxx
+++ b/include/sfx2/event.hxx
@@ -79,25 +79,6 @@ public:
 { return xViewController; }
 };
 
-
-
-class SfxNamedHint : public SfxHint
-{
-OUString_aEventName;
-OUString_aArgs;
-
-public:
-SfxNamedHint( const OUString& rName,
-  const OUString& rArgs  )
-:   _aEventName( rName ),
-_aArgs( rArgs )
-{}
-
-SfxNamedHint( const OUString& rName )
-:   _aEventName( rName )
-{}
-};
-
 class Printer;
 
 class SfxPrintingHint : public SfxViewEventHint
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'feature/gsoc15-open-remote-files-dialog' - 3289 commits - accessibility/inc accessibility/source android/Bootstrap android/CustomTarget_android_desktop.mk andro

2015-07-16 Thread Szymon Kłos

Rebased ref, commits from common ancestor:
commit c09512c30bdaede606547a246d755cda0154cf33
Author: Szymon KÅos 
Date:   Tue Jul 14 20:55:52 2015 +0200

question about overwriting the file only in the save mode

Change-Id: Iabb3bc12a8efae65a1c3d221a31c2214de8f6c90

diff --git a/fpicker/source/office/RemoteFilesDialog.cxx 
b/fpicker/source/office/RemoteFilesDialog.cxx
index 6c200ae..ec34e96 100644
--- a/fpicker/source/office/RemoteFilesDialog.cxx
+++ b/fpicker/source/office/RemoteFilesDialog.cxx
@@ -777,11 +777,14 @@ IMPL_LINK_NOARG ( RemoteFilesDialog, OkHdl )
 
 if ( bExists )
 {
-OUString sMsg = ResId( STR_SVT_ALREADYEXISTOVERWRITE, 
*ResMgrHolder::getOrCreate() );
-sMsg = sMsg.replaceFirst( "$filename$", sName );
-ScopedVclPtrInstance< MessageDialog > aBox( this, sMsg, 
VCL_MESSAGE_QUESTION, VCL_BUTTONS_YES_NO );
-if( aBox->Execute() != RET_YES )
-return 0;
+if( m_eMode == REMOTEDLG_MODE_SAVE )
+{
+OUString sMsg = ResId( STR_SVT_ALREADYEXISTOVERWRITE, 
*ResMgrHolder::getOrCreate() );
+sMsg = sMsg.replaceFirst( "$filename$", sName );
+ScopedVclPtrInstance< MessageDialog > aBox( this, sMsg, 
VCL_MESSAGE_QUESTION, VCL_BUTTONS_YES_NO );
+if( aBox->Execute() != RET_YES )
+return 0;
+}
 }
 else
 {
commit 84e8159ada9a63ac4fd690406e4295860912ebea
Author: Szymon KÅos 
Date:   Tue Jul 14 16:16:06 2015 +0200

FilePickerLastService as a string, not string-list 2

Change-Id: If100617ef968fde94178528327135e15f64c1542

diff --git a/fpicker/source/office/RemoteFilesDialog.cxx 
b/fpicker/source/office/RemoteFilesDialog.cxx
index 5ea0658..6c200ae 100644
--- a/fpicker/source/office/RemoteFilesDialog.cxx
+++ b/fpicker/source/office/RemoteFilesDialog.cxx
@@ -227,10 +227,7 @@ void RemoteFilesDialog::dispose()
 
 std::shared_ptr< comphelper::ConfigurationChanges > batch( 
comphelper::ConfigurationChanges::create( m_context ) );
 
-Sequence< OUString > lastService( 1 );
-lastService[0] = m_sLastServiceUrl;
-
-officecfg::Office::Common::Misc::FilePickerLastService::set( lastService, 
batch );
+officecfg::Office::Common::Misc::FilePickerLastService::set( 
m_sLastServiceUrl, batch );
 
 if( m_bIsUpdated )
 {
@@ -324,10 +321,8 @@ void RemoteFilesDialog::FillServicesListbox()
 
 unsigned int nPos = 0;
 unsigned int i = 0;
-Sequence< OUString > lastService( 
officecfg::Office::Common::Misc::FilePickerLastService::get( m_context ) );
 
-if( lastService.getLength() > 0 )
-m_sLastServiceUrl = lastService[0];
+m_sLastServiceUrl = 
officecfg::Office::Common::Misc::FilePickerLastService::get( m_context );
 
 for( sal_Int32 nPlace = 0; nPlace < placesUrlsList.getLength() && nPlace < 
placesNamesList.getLength(); ++nPlace )
 {
commit f587314d8d03cc6ac6e112955b401f098e231223
Author: Szymon KÅos 
Date:   Tue Jul 14 16:02:02 2015 +0200

FilePickerLastService as a string, not string-list

Change-Id: I7c379e797250be2f61791f5f3260d23ad24d26b3

diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs 
b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
index 5109e66..220a989 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
@@ -5828,7 +5828,7 @@
   List of names of the places the user bookmarked in the file 
picker dialog.
 
   
-  
+  
 
   URL of the last used service in the remote file picker.
 
commit 84d266fa838a3df1cedbcde5ab98c8a8b23f6b48
Author: Szymon KÅos 
Date:   Tue Jul 14 13:10:53 2015 +0200

RemoteFilesDialog: remember last used service

Change-Id: I494b1d43d28d8e6c37ce9d391b37580be6a9be31

diff --git a/fpicker/source/office/RemoteFilesDialog.cxx 
b/fpicker/source/office/RemoteFilesDialog.cxx
index 533940d..5ea0658 100644
--- a/fpicker/source/office/RemoteFilesDialog.cxx
+++ b/fpicker/source/office/RemoteFilesDialog.cxx
@@ -225,6 +225,13 @@ void RemoteFilesDialog::dispose()
 {
 m_pFileView->SetSelectHdl( Link<>() );
 
+std::shared_ptr< comphelper::ConfigurationChanges > batch( 
comphelper::ConfigurationChanges::create( m_context ) );
+
+Sequence< OUString > lastService( 1 );
+lastService[0] = m_sLastServiceUrl;
+
+officecfg::Office::Common::Misc::FilePickerLastService::set( lastService, 
batch );
+
 if( m_bIsUpdated )
 {
 Sequence< OUString > placesUrlsList( m_aServices.size() );
@@ -238,12 +245,12 @@ void RemoteFilesDialog::dispose()
 ++i;
 }
 
-std::shared_ptr< comphelper::ConfigurationChanges > batch( 
comphelper::ConfigurationChanges::create( m_context ) );
 officecfg::Office::Common::Misc::FilePickerPlacesUrls::set( 
placesUrlsList, batch );
 officecfg::Office::Common::Misc::FilePickerPlacesNames::set( 
placesNamesList, batch );

[Libreoffice-commits] core.git: include/svtools

2015-07-16 Thread Stephan Bergmann

 include/svtools/ServerDetailsControls.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e373d3cd63dc0728aed0c16782a49754658e5e72
Author: Stephan Bergmann 
Date:   Thu Jul 16 10:06:26 2015 +0200

-Werror,-Winconsistent-missing-override

Change-Id: Ic26b03153d856f460a2e6c90b64a670541ec5af0

diff --git a/include/svtools/ServerDetailsControls.hxx 
b/include/svtools/ServerDetailsControls.hxx
index 29c951a..5df8a36 100644
--- a/include/svtools/ServerDetailsControls.hxx
+++ b/include/svtools/ServerDetailsControls.hxx
@@ -130,7 +130,7 @@ class CmisDetailsContainer : public DetailsContainer
 CmisDetailsContainer( VclBuilderContainer* pBuilder, OUString sBinding 
);
 virtual ~CmisDetailsContainer( ) { };
 
-virtual void show( bool bShow = true );
+virtual void show( bool bShow = true ) SAL_OVERRIDE;
 virtual INetURLObject getUrl( ) SAL_OVERRIDE;
 virtual bool setUrl( const INetURLObject& rUrl ) SAL_OVERRIDE;
 virtual void setUsername( const OUString& rUsername ) SAL_OVERRIDE;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Howto build a viewer to compare differences using tiles?

2015-07-16 Thread Michel Renon

Hi Stef,

Le 15/07/2015 18:52, Stef Bon a écrit :

Hi,

I'm building backup/version system, using sqlite, btrfs and FUSE for
the user. It's comparable to snapper, but that's more a tool to
backup/snapshot the system. Fuse-backup is a tool for the user, he/she
can assign a directory to backup easily, and view versions of files
with a simple mouseclick.

[...]

Now I've spoken with Michael Meeks in Den Hage begin May at the
OpenSuse conference. I asked him howto build a tool to view the
differences between versions. He suggested me to look at the
libreofficekit, and especially the lokdocview, to view pages as tiles.

Now can someone describe globally howto write an app using qt 5,
showing the pages as tiles, the page of the current version left and
the previous version right?

1 2 >

1 - 100 of 123 matches

Mail list logo