[Libreoffice-commits] core.git: Branch 'aoo/trunk' - 2 commits - officecfg/registry xmloff/source

2015-01-31 Thread Tsutomu Uchino
 officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu |4 
++--
 xmloff/source/forms/elementimport.cxx|9 
-
 xmloff/source/forms/elementimport.hxx|2 +-
 3 files changed, 11 insertions(+), 4 deletions(-)

New commits:
commit 23e16b91ad69a123e795d63f2d4862d94412d582
Author: Tsutomu Uchino 
Date:   Sat Jan 31 07:26:19 2015 +

#i114416# use default service name for scroll bar if failed to detect the 
control-implementation

diff --git a/xmloff/source/forms/elementimport.cxx 
b/xmloff/source/forms/elementimport.cxx
index 672d9a7..89ad745 100644
--- a/xmloff/source/forms/elementimport.cxx
+++ b/xmloff/source/forms/elementimport.cxx
@@ -190,7 +190,7 @@ namespace xmloff
 }
 
 if ( !m_sServiceName.getLength() )
-determineDefaultServiceName();
+m_sServiceName = determineDefaultServiceName();
 
 // create the object *now*. This allows setting properties in the 
various handleAttribute methods.
 // (Though currently not all code is migrated to this pattern, most 
attributes are still handled
@@ -712,6 +712,7 @@ namespace xmloff
 case OControlElement::IMAGE_FRAME:   pServiceName = 
"com.sun.star.form.component.DatabaseImageControl"; break;
 case OControlElement::HIDDEN:pServiceName = 
"com.sun.star.form.component.HiddenControl"; break;
 case OControlElement::GRID:  pServiceName = 
"com.sun.star.form.component.GridControl"; break;
+case OControlElement::VALUERANGE:pServiceName = 
"com.sun.star.form.component.ScrollBar"; break;
 case OControlElement::TIME:  pServiceName = 
"com.sun.star.form.component.DateField"; break;
 case OControlElement::DATE:  pServiceName = 
"com.sun.star.form.component.TimeField"; break;
 default: break;
@@ -2221,6 +,12 @@ namespace xmloff
 }
 }
 
+//-
+::rtl::OUString OFormImport::determineDefaultServiceName() const
+{
+return ::rtl::OUString::createFromAscii( 
"com.sun.star.form.component.Form" );
+}
+
 //.
 }   // namespace xmloff
 //.
diff --git a/xmloff/source/forms/elementimport.hxx 
b/xmloff/source/forms/elementimport.hxx
index dacda2e..eb04e84 100644
--- a/xmloff/source/forms/elementimport.hxx
+++ b/xmloff/source/forms/elementimport.hxx
@@ -740,7 +740,7 @@ namespace xmloff
 sal_uInt16 _nPrefix, const ::rtl::OUString& _rLocalName,
 OControlElement::ElementType _eType );
 
-
+virtual ::rtl::OUString determineDefaultServiceName() const;
 void implTranslateStringListProperty(const ::rtl::OUString& 
_rPropertyName, const ::rtl::OUString& _rValue);
 };
 
commit 459c1d18f71552db70b349ef50828142cd6f744f
Author: Tsutomu Uchino 
Date:   Sat Jan 31 06:50:26 2015 +

#i116863# remove extra spaces from labels of line spacing commands

diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
index 0a17cdb..d4b350f 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
@@ -4832,7 +4832,7 @@
 
 
 
-Line Spacing : 1.5
+Line Spacing: 1.5
 
 
 15
@@ -4840,7 +4840,7 @@
 
 
 
-Line Spacing : 2
+Line Spacing: 2
 
 
 15
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: basic/source

2015-01-31 Thread Arnaud Versini
 basic/source/comp/basiccharclass.cxx |9 ++---
 basic/source/comp/sbcomp.cxx |9 ++---
 basic/source/comp/scanner.cxx|   12 ++--
 basic/source/inc/basiccharclass.hxx  |3 +--
 4 files changed, 11 insertions(+), 22 deletions(-)

New commits:
commit 4b9a9ce8a0e5e0716dad9a9ec87d16237e534dc2
Author: Arnaud Versini 
Date:   Sun Jan 25 13:58:08 2015 +0100

Use rtl/character.hxx in basic module when possible

Change-Id: I1296541ac1a6a65a613818a1264c2b7482915e64
Reviewed-on: https://gerrit.libreoffice.org/14170
Reviewed-by: Arnaud Versini 
Tested-by: Arnaud Versini 

diff --git a/basic/source/comp/basiccharclass.cxx 
b/basic/source/comp/basiccharclass.cxx
index 59ae724..8e404cc 100644
--- a/basic/source/comp/basiccharclass.cxx
+++ b/basic/source/comp/basiccharclass.cxx
@@ -108,18 +108,13 @@ bool BasicCharClass::isLetterUnicode( sal_Unicode c )
 
 bool BasicCharClass::isAlpha( sal_Unicode c, bool bCompatible )
 {
-  return (c >= 'a' && c <= 'z') || (c >= 'A' && c <= 'Z')
+  return rtl::isAsciiAlpha(c)
 || (bCompatible && isLetter( c ));
 }
 
-bool BasicCharClass::isDigit( sal_Unicode c )
-{
-  return (c >= '0' && c <= '9');
-}
-
 bool BasicCharClass::isAlphaNumeric( sal_Unicode c, bool bCompatible )
 {
-  return isDigit( c ) || isAlpha( c, bCompatible );
+  return rtl::isAsciiDigit( c ) || isAlpha( c, bCompatible );
 }
 
 bool BasicCharClass::isWhitespace( sal_Unicode c )
diff --git a/basic/source/comp/sbcomp.cxx b/basic/source/comp/sbcomp.cxx
index 293e8cf..dfc0b4a 100644
--- a/basic/source/comp/sbcomp.cxx
+++ b/basic/source/comp/sbcomp.cxx
@@ -25,6 +25,7 @@
 #include 
 #include 
 #include 
+#include 
 
 // To activate tracing enable in sbtrace.hxx
 #ifdef DBG_TRACE_BASIC
@@ -124,12 +125,6 @@ inline void lcl_findNextLine( char*& rpc, char* pe )
 ++rpc;
 }
 
-inline bool lcl_isAlpha( char c )
-{
-bool bRet = (c >= 'a' && c <= 'z') || (c >= 'A' && c <= 'Z');
-return bRet;
-}
-
 static void lcl_ReadIniFile( const char* pIniFileName )
 {
 const int BUF_SIZE = 1000;
@@ -153,7 +148,7 @@ static void lcl_ReadIniFile( const char* pIniFileName )
 
 // Read variable
 char* pVarStart = pc;
-while( pc < pe && lcl_isAlpha( *pc ) )
+while( pc < pe && rtl::isAsciiAlpha( *pc ) )
 ++pc;
 int nVarLen = pc - pVarStart;
 if( nVarLen == 0 )
diff --git a/basic/source/comp/scanner.cxx b/basic/source/comp/scanner.cxx
index 8a893f0..41e6171 100644
--- a/basic/source/comp/scanner.cxx
+++ b/basic/source/comp/scanner.cxx
@@ -152,7 +152,7 @@ void SbiScanner::scanAlphanumeric()
 void SbiScanner::scanGoto()
 {
 sal_Int32 n = nCol;
-while(n < aLine.getLength() && 
theBasicCharClass::get().isWhitespace(aLine[n]))
+while(n < aLine.getLength() && BasicCharClass::isWhitespace(aLine[n]))
 ++n;
 
 if(n + 1 < aLine.getLength())
@@ -180,7 +180,7 @@ bool SbiScanner::readLine()
 
 // Trim trailing whitespace
 sal_Int32 nEnd = n;
-while(nBufPos < nEnd && theBasicCharClass::get().isWhitespace(aBuf[nEnd - 
1]))
+while(nBufPos < nEnd && BasicCharClass::isWhitespace(aBuf[nEnd - 1]))
 --nEnd;
 
 aLine = aBuf.copy(nBufPos, nEnd - nBufPos);
@@ -223,10 +223,10 @@ bool SbiScanner::NextSym()
 nOldCol1 = nOldCol2 = 0;
 }
 
-if(nCol < aLine.getLength() && 
theBasicCharClass::get().isWhitespace(aLine[nCol]))
+if(nCol < aLine.getLength() && BasicCharClass::isWhitespace(aLine[nCol]))
 {
 bSpaces = true;
-while(nCol < aLine.getLength() && 
theBasicCharClass::get().isWhitespace(aLine[nCol]))
+while(nCol < aLine.getLength() && 
BasicCharClass::isWhitespace(aLine[nCol]))
 ++pLine, ++nCol;
 }
 
@@ -298,8 +298,8 @@ bool SbiScanner::NextSym()
 }
 
 // read in and convert if number
-else if((nCol < aLine.getLength() && 
theBasicCharClass::get().isDigit(aLine[nCol] & 0xFF)) ||
-(nCol + 1 < aLine.getLength() && aLine[nCol] == '.' && 
theBasicCharClass::get().isDigit(aLine[nCol + 1] & 0xFF)))
+else if((nCol < aLine.getLength() && rtl::isAsciiDigit(aLine[nCol])) ||
+(nCol + 1 < aLine.getLength() && aLine[nCol] == '.' && 
rtl::isAsciiDigit(aLine[nCol + 1])))
 {
 short exp = 0;
 short dec = 0;
diff --git a/basic/source/inc/basiccharclass.hxx 
b/basic/source/inc/basiccharclass.hxx
index 335bff6..e6fea65 100644
--- a/basic/source/inc/basiccharclass.hxx
+++ b/basic/source/inc/basiccharclass.hxx
@@ -35,9 +35,8 @@ public:
 bool isLetter( sal_Unicode c );
 bool isLetterUnicode( sal_Unicode c );
 bool isAlpha( sal_Unicode c, bool bCompatible );
-bool isDigit( sal_Unicode c );
 bool isAlphaNumeric( sal_Unicode c, bool bCompatible );
-bool isWhitespace( sal_Unicode c );
+static bool isWhitespace( sal_Unicode c );
 };
 
 class theBasicCharClass: public rtl::Static 
{};
___
Libreoffice-commits mailing list

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.2' - unotools/source

2015-01-31 Thread Tomofumi Yagi
 unotools/source/misc/fontdefs.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 6e4e936d9bffbe7f890809b722a74cd7f95106a8
Author: Tomofumi Yagi 
Date:   Thu Jan 29 20:12:47 2015 +0900

fix tdf#88855: GetEnglishSearchFontName() returns incorrect value.

GetEnglishSearchFontName() returns incorrect value for specific localized
font name as parameter(ex."HGS Gothic M").
Because, the conversion table "aImplLocalizedNamesList[]" is wrong.


http://opengrok.libreoffice.org/xref/core/unotools/source/misc/fontdefs.cxx#181

This causes the assertion from 
vcl/source/font/PhysicalFontFamily.cxx(line:297),
and more problems, probably.

This patch fixes two entries in the conversion table.
One fixes the assertion, another fixes typo.

Change-Id: I31417956608cc59f20ad42c76ef97a42189d
Reviewed-on: https://gerrit.libreoffice.org/14244
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
(cherry picked from commit c8c4e766643c8ad0a3d6d48e5105518ef5f66250)
Reviewed-on: https://gerrit.libreoffice.org/14262
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/unotools/source/misc/fontdefs.cxx 
b/unotools/source/misc/fontdefs.cxx
index cdb8bd6..a5fd5ff 100644
--- a/unotools/source/misc/fontdefs.cxx
+++ b/unotools/source/misc/fontdefs.cxx
@@ -284,10 +284,10 @@ static ImplLocalizedFontName aImplLocalizedNamesList[] =
 {   "mdeasop",  aMDEasop },
 {   "hggothice",aHGGothicE },
 {   "hgpgothice",   aHGPGothicE },
-{   "hgpothice",aHGSGothicE },
+{   "hgsgothice",   aHGSGothicE },
 {   "hggothicm",aHGGothicM },
 {   "hgpgothicm",   aHGPGothicM },
-{   "hgpgothicm",   aHGSGothicM },
+{   "hgsgothicm",   aHGSGothicM },
 {   "hggyoshotai",  aHGGyoshotai },
 {   "hgpgyoshotai", aHGPGyoshotai },
 {   "hgsgyoshotai", aHGSGyoshotai },
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.3' - unotools/source

2015-01-31 Thread Tomofumi Yagi
 unotools/source/misc/fontdefs.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit a7a039e77221ac0c330e6265634371de70fc470d
Author: Tomofumi Yagi 
Date:   Thu Jan 29 20:12:47 2015 +0900

fix tdf#88855: GetEnglishSearchFontName() returns incorrect value.

GetEnglishSearchFontName() returns incorrect value for specific localized
font name as parameter(ex."HGS Gothic M").
Because, the conversion table "aImplLocalizedNamesList[]" is wrong.


http://opengrok.libreoffice.org/xref/core/unotools/source/misc/fontdefs.cxx#181

This causes the assertion from 
vcl/source/font/PhysicalFontFamily.cxx(line:297),
and more problems, probably.

This patch fixes two entries in the conversion table.
One fixes the assertion, another fixes typo.

Change-Id: I31417956608cc59f20ad42c76ef97a42189d
Reviewed-on: https://gerrit.libreoffice.org/14244
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
(cherry picked from commit c8c4e766643c8ad0a3d6d48e5105518ef5f66250)
Reviewed-on: https://gerrit.libreoffice.org/14263
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/unotools/source/misc/fontdefs.cxx 
b/unotools/source/misc/fontdefs.cxx
index 61f6a07..38cfdcf 100644
--- a/unotools/source/misc/fontdefs.cxx
+++ b/unotools/source/misc/fontdefs.cxx
@@ -284,10 +284,10 @@ static ImplLocalizedFontName aImplLocalizedNamesList[] =
 {   "mdeasop",  aMDEasop },
 {   "hggothice",aHGGothicE },
 {   "hgpgothice",   aHGPGothicE },
-{   "hgpothice",aHGSGothicE },
+{   "hgsgothice",   aHGSGothicE },
 {   "hggothicm",aHGGothicM },
 {   "hgpgothicm",   aHGPGothicM },
-{   "hgpgothicm",   aHGSGothicM },
+{   "hgsgothicm",   aHGSGothicM },
 {   "hggyoshotai",  aHGGyoshotai },
 {   "hgpgyoshotai", aHGPGyoshotai },
 {   "hgsgyoshotai", aHGSGyoshotai },
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/qa sw/source

2015-01-31 Thread Miklos Vajna
 sw/qa/extras/ooxmlexport/data/tdf88583.odt |binary
 sw/qa/extras/ooxmlexport/ooxmlexport.cxx   |7 +++
 sw/source/filter/ww8/ww8atr.cxx|8 
 3 files changed, 15 insertions(+)

New commits:
commit 60cdeb2d441a6bf5c55f511f574b2b9dd598fbb8
Author: Miklos Vajna 
Date:   Sat Jan 31 10:55:39 2015 +0100

tdf#88583 MSWordExportBase: fix handling of paragraph background color

Regression from 7d9bb549d498d6beed2c4050c402d09643febdfa (Related:
i#124638 Second step of DrawingLayer FillAttributes..., 2014-06-02), the
problem was that exporters still expect an SvxBrushItem for the para
background color, while doc model was changed to have an XFillStyleItem
/ XFillColorItem pair instead.

Change-Id: Ib94fda103ec35a6f087307aafdd890183d9d935f

diff --git a/sw/qa/extras/ooxmlexport/data/tdf88583.odt 
b/sw/qa/extras/ooxmlexport/data/tdf88583.odt
new file mode 100644
index 000..307ab1e
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf88583.odt differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
index 2109a7f..53a0b7e 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
@@ -629,6 +629,13 @@ DECLARE_OOXMLEXPORT_TEST(testEffectExtentMargin, 
"effectextent-margin.docx")
 CPPUNIT_ASSERT_EQUAL(oox::drawingml::convertEmuToHmm(114300+95250), 
getProperty(getShape(1), "LeftMargin"));
 }
 
+DECLARE_OOXMLEXPORT_TEST(testTdf88583, "tdf88583.odt")
+{
+if (xmlDocPtr pXmlDoc = parseExport())
+//  had no  child element, paragraph background was lost.
+assertXPath(pXmlDoc, "//w:pPr/w:shd", "fill", "00CC00");
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx
index 1a80623..9ef456e 100644
--- a/sw/source/filter/ww8/ww8atr.cxx
+++ b/sw/source/filter/ww8/ww8atr.cxx
@@ -304,6 +304,14 @@ void MSWordExportBase::OutputItemSet( const SfxItemSet& 
rSet, bool bPapFmt, bool
  (nWhich >= XATTR_FILL_FIRST && nWhich < XATTR_FILL_LAST))
 AttrOutput().OutputItem( *pItem );
 }
+
+// Has to be called after RES_PARATR_GRABBAG is processed.
+const XFillStyleItem* pXFillStyleItem(static_cast(rSet.GetItem(XATTR_FILLSTYLE)));
+if (pXFillStyleItem && pXFillStyleItem->GetValue() == 
drawing::FillStyle_SOLID && !rSet.HasItem(RES_BACKGROUND))
+{
+// Construct an SvxBrushItem, as expected by the exporters.
+AttrOutput().OutputItem(getSvxBrushItemFromSourceSet(rSet, 
RES_BACKGROUND));
+}
 }
 pISet = 0;  // fuer Doppel-Attribute
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: TDF bugzilla bug report

2015-01-31 Thread Robinson Tryon
On Wed, Jan 28, 2015 at 9:34 PM, Lionel Elie Mamane  wrote:
> Hi,
>
> 1) There doesn't seem to be a project/component on Bugzilla for
>problems with the bugzilla installation.

https://redmine.documentfoundation.org/projects/infrastructure/issues/new

Set category to 'Bugzilla'

(I don't know how to format a file-a-bug URL that contains the category yet)

> 3) The FreeDesktop bugzilla had a nice shortcut of putting only the
>bug number, for example http://bugs.freedesktop.org/72267
>
>Please enable the same shortcut on the TDF Bugzilla.

https://redmine.documentfoundation.org/issues/1042
"Bugzilla: Use tdf.io as url-shortener"

Lionel: If you sign up on redmine, you can then add yourself as a
watcher to that bug report.

Best,
--R

-- 
Robinson Tryon
QA Engineer - The Document Foundation
LibreOffice Community Outreach Herald
qu...@libreoffice.org
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: TDF bugzilla bug report

2015-01-31 Thread Eike Rathke
Hi Lionel,

On Wednesday, 2015-01-28 21:34:28 +0100, Lionel Elie Mamane wrote:

> 3) The FreeDesktop bugzilla had a nice shortcut of putting only the
>bug number, for example http://bugs.freedesktop.org/72267
> 
>Please enable the same shortcut on the TDF Bugzilla.

Btw, what I'm using is a Firefox QuickSearch, i.e. setup to Keywordf tdf
and Location https://bugs.documentfoundation.org/show_bug.cgi?id=%s so
in the browser's URL line I just have to enter  tdf 72267

  Eik

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/
Care about Free Software, support the FSFE https://fsfe.org/support/?erack


pgpo1xJniI5Y9.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: wizards/source

2015-01-31 Thread Jean-Pierre Ledure
 wizards/source/access2base/Control.xba |9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

New commits:
commit 602f5010bc41f71d29695a348d56b6d953865c2f
Author: Jean-Pierre Ledure 
Date:   Sat Jan 31 16:50:41 2015 +0100

Access2Base - Bug in Control.RemoveItem

Removing last item of a Listbox produces an "Index out of rande" run-time 
error
Bug reported in user forum 
https://forum.openoffice.org/en/forum/viewtopic.php?f=47&t=75008

Change-Id: I4bf790f8fee1f88def580dee7bac708b5620fbed

diff --git a/wizards/source/access2base/Control.xba 
b/wizards/source/access2base/Control.xba
index 66705d9..d150c87 100644
--- a/wizards/source/access2base/Control.xba
+++ b/wizards/source/access2base/Control.xba
@@ -690,21 +690,24 @@ Dim vRowSource() As Variant, iCount As Integer, i As 
Integer, j As integer, bFou
For j = i To iCount - 1
vRowSource(j) = vRowSource(j + 
1)
Next j
-   ReDim Preserve vRowSource(0 To iCount - 
1)
bFound = True
Exit For'  Remove only 1st 
occurrence of string
End If
Next i
Case Else
If pvIndex < 0 Or pvIndex > iCount Then Goto 
Error_Index
-   bFound = True
For i = pvIndex To iCount - 1
vRowSource(i) = vRowSource(i + 1)
Next i
-   ReDim Preserve vRowSource(0 To iCount - 1)
+   bFound = True
End Select

If bFound Then
+   If iCount > 0 Then   '  
https://forum.openoffice.org/en/forum/viewtopic.php?f=47&t=75008
+   ReDim Preserve vRowSource(0 To iCount - 1)
+   Else
+   vRowSource = Array()
+   End If
If _ParentType <> CTLPARENTISDIALOG Then
ControlModel.ListSource = vRowSource()
End If
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: connectivity/source

2015-01-31 Thread Lionel Elie Mamane
 connectivity/source/drivers/macab/MacabStatement.cxx |5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

New commits:
commit d2a6d6a1a05337dbb733a9a3d4926a5c6d6cd8cd
Author: Lionel Elie Mamane 
Date:   Sat Jan 31 17:01:15 2015 +0100

tdf#88814 parameters are kinda-partially supported, so follow the suggestion

Change-Id: I1a39378d521f128e6b8f35a0bce781435f94e5a8

diff --git a/connectivity/source/drivers/macab/MacabStatement.cxx 
b/connectivity/source/drivers/macab/MacabStatement.cxx
index f807b5b..2de3f3f 100644
--- a/connectivity/source/drivers/macab/MacabStatement.cxx
+++ b/connectivity/source/drivers/macab/MacabStatement.cxx
@@ -85,7 +85,6 @@ void MacabCommonStatement::disposing()
 
 void MacabCommonStatement::resetParameters() const 
throw(::com::sun::star::sdbc::SQLException)
 {
-impl_throwError(STR_PARA_ONLY_PREPARED);
 }
 
 void MacabCommonStatement::getNextParameter(OUString &) const 
throw(::com::sun::star::sdbc::SQLException)
@@ -325,9 +324,7 @@ void MacabCommonStatement::selectRecords(MacabResultSet 
*pResult) const throw(SQ
 {
 if (SQL_ISRULE(pParseNode, where_clause))
 {
-// Since we don't support parameters, don't reset them. If we ever
-// support them, uncomment this line and fix resetParameters.
-//resetParameters();
+resetParameters();
 pParseNode = pParseNode->getChild(1);
 MacabCondition *pCondition = analyseWhereClause(pParseNode);
 if (pCondition->isAlwaysTrue())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: Substring method

2015-01-31 Thread Eike Rathke
Hi Mihály,

On Thursday, 2015-01-29 14:57:58 +0100, Mihály Palenik wrote:

> I'd like to examine a string is part of another but in all languages. I
> know CollatorWrapper class which has compareString method to compare two
> strings using uno. I'm searching this kind of method.

For case significant comparisons and literal string in string search you
can use OUString::indexOf()

As soon as the search shall be done case insignificant you'll have to
transliterate and for that you need to specify the language.

If the searched string should be the start of a string you could use
TransliterationWrapper::equals() from
include/unotools/transliterationwrapper.hxx

If the search string can appear anywhere the practical approach is to
transliterate both strings to, for example, lowercase and then use
OUString::indexOf() to search the occurrence.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/
Care about Free Software, support the FSFE https://fsfe.org/support/?erack


pgpgp6oWI5vpx.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: include/svl svl/source sw/source

2015-01-31 Thread Miklos Vajna
 include/svl/undo.hxx|2 ++
 svl/source/undo/undo.cxx|   21 +
 sw/source/core/docnode/nodedump.cxx |   20 +---
 3 files changed, 24 insertions(+), 19 deletions(-)

New commits:
commit e4b0d63c134e7833db562f4eef93bbf828ea1b9d
Author: Miklos Vajna 
Date:   Sat Jan 31 18:09:05 2015 +0100

Extract SfxUndoAction::dumpAsXml() from sw

Change-Id: I7ec2071150c03b61f3f681dbd26968ae3c535742

diff --git a/include/svl/undo.hxx b/include/svl/undo.hxx
index 92a9907..2c19238 100644
--- a/include/svl/undo.hxx
+++ b/include/svl/undo.hxx
@@ -71,6 +71,7 @@ public:
 virtual OUStringGetComment() const;
 virtual OUStringGetRepeatComment(SfxRepeatTarget&) const;
 virtual sal_uInt16  GetId() const;
+virtual void dumpAsXml(struct _xmlTextWriter* pWriter) const;
 
 private:
 SfxUndoAction( const SfxUndoAction& ); // disabled
@@ -159,6 +160,7 @@ public:
 virtual sal_uInt16  GetId() const SAL_OVERRIDE;
 
 void SetComment(const OUString& rComment);
+void dumpAsXml(struct _xmlTextWriter* pWriter) const SAL_OVERRIDE;
 };
 
 
diff --git a/svl/source/undo/undo.cxx b/svl/source/undo/undo.cxx
index 772dd43..1fcc649 100644
--- a/svl/source/undo/undo.cxx
+++ b/svl/source/undo/undo.cxx
@@ -24,6 +24,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -135,6 +136,14 @@ bool SfxUndoAction::CanRepeat(SfxRepeatTarget&) const
 return true;
 }
 
+void SfxUndoAction::dumpAsXml(xmlTextWriterPtr pWriter) const
+{
+xmlTextWriterStartElement(pWriter, BAD_CAST("sfxUndoAction"));
+xmlTextWriterWriteAttribute(pWriter, BAD_CAST("symbol"), 
BAD_CAST(typeid(*this).name()));
+xmlTextWriterWriteAttribute(pWriter, BAD_CAST("comment"), 
BAD_CAST(GetComment().toUtf8().getStr()));
+xmlTextWriterEndElement(pWriter);
+}
+
 struct MarkedUndoAction
 {
 SfxUndoAction*  pAction;
@@ -1372,6 +1381,18 @@ bool SfxListUndoAction::Merge( SfxUndoAction 
*pNextAction )
 return !aUndoActions.empty() && 
aUndoActions[aUndoActions.size()-1].pAction->Merge( pNextAction );
 }
 
+void SfxListUndoAction::dumpAsXml(xmlTextWriterPtr pWriter) const
+{
+xmlTextWriterStartElement(pWriter, BAD_CAST("sfxListUndoAction"));
+xmlTextWriterWriteAttribute(pWriter, BAD_CAST("size"), 
BAD_CAST(OString::number(aUndoActions.size()).getStr()));
+SfxUndoAction::dumpAsXml(pWriter);
+
+for (size_t i = 0; i < aUndoActions.size(); ++i)
+aUndoActions.GetUndoAction(i)->dumpAsXml(pWriter);
+
+xmlTextWriterEndElement(pWriter);
+}
+
 /**
  * Creates a LinkAction which points to another UndoManager.
  * Gets that UndoManagers current Action and sets it as that UndoManager's
diff --git a/sw/source/core/docnode/nodedump.cxx 
b/sw/source/core/docnode/nodedump.cxx
index 67ea050..902c494 100644
--- a/sw/source/core/docnode/nodedump.cxx
+++ b/sw/source/core/docnode/nodedump.cxx
@@ -656,24 +656,6 @@ void SwExtraRedlineTbl::dumpAsXml( xmlTextWriterPtr w ) 
const
 writer.endElement( );// swextraredlinetbl
 }
 
-void lcl_dumpSfxUndoAction(WriterHelper& writer, SfxUndoAction* pAction)
-{
-writer.startElement("undoAction");
-writer.writeFormatAttribute("symbol", "%s", 
BAD_CAST(typeid(*pAction).name()));
-writer.writeFormatAttribute("comment", "%s", 
BAD_CAST(OUStringToOString(pAction->GetComment(), 
RTL_TEXTENCODING_UTF8).getStr()));
-
-if (SfxListUndoAction* pList = dynamic_cast(pAction))
-{
-writer.startElement("list");
-writer.writeFormatAttribute("size", TMP_FORMAT, 
pList->aUndoActions.size());
-for (size_t i = 0; i < pList->aUndoActions.size(); ++i)
-lcl_dumpSfxUndoAction(writer, 
pList->aUndoActions.GetUndoAction(i));
-writer.endElement();
-}
-
-writer.endElement();
-}
-
 void sw::UndoManager::dumpAsXml(xmlTextWriterPtr w)
 {
 WriterHelper writer(w);
@@ -682,7 +664,7 @@ void sw::UndoManager::dumpAsXml(xmlTextWriterPtr w)
 writer.writeFormatAttribute("nUndoActionCount", TMP_FORMAT, 
GetUndoActionCount());
 
 for (size_t i = 0; i < GetUndoActionCount(); ++i)
-lcl_dumpSfxUndoAction(writer, GetUndoAction(i));
+GetUndoAction(i)->dumpAsXml(w);
 
 writer.endElement();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: help asked for Calc jump function with empty arguments

2015-01-31 Thread Eike Rathke
Hi Winfried,

On Thursday, 2015-01-29 10:15:59 +0100, Winfried Donkers wrote:

> I am working on bug 88576, regarding IFERROR and IFNA not giving expected 
> results when not all mandatory arguments are given.
> On checking their behaviour in various cases, I discovered that IFERROR, IFNA 
> and IF do not handle empty arguments as they should be.
> With empty argument I mean e.g. -IFERROR(something;) of 
> IF(statement;;argument).
> With IFERROR and IFNA these situation should return an empty value to be 
> compatible with Excel.

AFAIK also Excel does not allow a null argument for IFERROR() second
parameter, but I'm not sure, I'd have to check.

> With IF, the behaviour is described in ODFF1.2.

Note that there seems to be a typo in the spec, IfFalse is mentioned
twice to be considered to be 0, the first (two consecutive ;; case)
probably should be IfTrue.

> My question is, where should this behaviour best be put in the code?
> In class FormulaCompiler, e.g. in FormulaCompiler::Factor(), in 
> ScInterpreter::Interpret(), in the functions themselves 
> (ScInterpreter::ScIf() and ScInterpreter::ScIfError() or somewhere else?

I think the right place would be ScInterpreter::Interpret() at the end
where the final result is obtained. There's a check

if( pCur->GetOpCode() == ocPush )

and if not an error is set. An ocMissing here could be propagated
through to the ScFormulaResult, then

bool isValue( formula::StackVar sv )

in sc/source/core/tool/formularesult.cxx would need to handle
formula::svMissing as well, the ScFormulaResult::GetDouble() already
returns 0.0 in such case.

> And as these functions are jump functions, how best to access/modify the 
> stack or FormulaToken?

Don't ;-)
The code is already an ocMissing and the jumps are correct, just the
final result isn't.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/
Care about Free Software, support the FSFE https://fsfe.org/support/?erack


pgpCR48S6d68v.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: Branch 'aoo/trunk' - officecfg/registry sw/source

2015-01-31 Thread Tsutomu Uchino
 officecfg/registry/schema/org/openoffice/Office/Labels.xcs |4 
 officecfg/registry/schema/org/openoffice/Office/Writer.xcs |   12 
 sw/source/ui/app/applab.cxx|   18 -
 sw/source/ui/envelp/label1.cxx |4 
 sw/source/ui/envelp/labelcfg.cxx   |6 
 sw/source/ui/envelp/labfmt.cxx |   16 +
 sw/source/ui/envelp/labfmt.hrc |4 
 sw/source/ui/envelp/labfmt.hxx |4 
 sw/source/ui/envelp/labfmt.src |   72 +++-
 sw/source/ui/envelp/labimg.cxx |  206 +++--
 sw/source/ui/envelp/labimp.hxx |2 
 sw/source/ui/inc/labimg.hxx|2 
 12 files changed, 234 insertions(+), 116 deletions(-)

New commits:
commit 7fb6496ef1c553b2d186505b18672bb8b984ce9a
Author: Tsutomu Uchino 
Date:   Sat Jan 31 16:55:56 2015 +

#i53718# add support of paper size for label document

diff --git a/officecfg/registry/schema/org/openoffice/Office/Labels.xcs 
b/officecfg/registry/schema/org/openoffice/Office/Labels.xcs
index 996bdcc..488640d 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Labels.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Labels.xcs
@@ -40,10 +40,10 @@




-   Contains the measurement data of 
the label concatenated by a colon (;) in the following order: 'C' or 
'S';Horizontal Distance;Vertical Distance;Width;Height;Left margin;Upper 
margin;Columns;Rows" while 'C' marks a continuous label and 
'S' marks a sheet.
+   Contains the measurement data of 
the label concatenated by a colon (;) in the following order: 'C' or 
'S';Horizontal Distance;Vertical Distance;Width;Height;Left margin;Upper 
margin;Columns;Rows;Paper Width;Paper Height" while 'C' marks a 
continuous label and 'S' marks a sheet.



diff --git a/officecfg/registry/schema/org/openoffice/Office/Writer.xcs 
b/officecfg/registry/schema/org/openoffice/Office/Writer.xcs
index 1610f18..30f25ac3 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Writer.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Writer.xcs
@@ -5026,6 +5026,18 @@

0

+   
+   
+   Specifies the width of 
the paper [UNIT=1/100 mm].
+   
+   1
+   
+   
+   
+   Specifies the height of 
the paper [UNIT=1/100 mm].
+   
+   1
+   



diff --git a/sw/source/ui/app/applab.cxx b/sw/source/ui/app/applab.cxx
index 5eb0b96..425b469 100644
--- a/sw/source/ui/app/applab.cxx
+++ b/sw/source/ui/app/applab.cxx
@@ -97,7 +97,8 @@ const SwFrmFmt *lcl_InsertBCText( SwWrtShell& rSh, const 
SwLabItem& rItem,
 sal_uInt16 nCol, sal_uInt16 nRow, sal_Bool bPage)
 {
 SfxItemSet aSet(rSh.GetAttrPool(), RES_ANCHOR, RES_ANCHOR,
-RES_VERT_ORIENT, RES_VERT_ORIENT, RES_HORI_ORIENT, 
RES_HORI_ORIENT, 0 );
+RES_VERT_ORIENT, RES_VERT_ORIENT, RES_HORI_ORIENT, 
RES_HORI_ORIENT,
+RES_LR_SPACE, RES_LR_SPACE, 0 );
 sal_uInt16 nPhyPageNum, nVirtPageNum;
 rSh.GetPageNum( nPhyPageNum, nVirtPageNum );
 
@@ -109,6 +110,10 @@ const SwFrmFmt *lcl_InsertBCText( SwWrtShell& rSh, const 
SwLabItem& rItem,
 aSet.Put(SwFmtVertOrient(rItem.lUpper + nRow * rItem.lVDist,
 
text::VertOrientation::NONE, text::RelOrientation::PAGE_FRAME ));
 }
+if ( nCol == rItem.nCols -1 )
+{
+aSet.Put( SvxLRSpaceItem( 0, 0, 0, 0, RES_LR_SPACE ) );
+}
 const SwFrmFmt *pFmt = rSh.NewFlyFrm(aSet, sal_True,  &rFmt );  // Fly 
einfuegen
 ASSERT( pFmt, "Fly not inserted" );
 
@@ -137,7 +142,8 @@ const SwFrmFmt *lcl_InsertLabText( SwWrtShell& rSh, const 
SwLabItem& rItem,
 sal_uInt16 nCol, sal_uInt16 nRow, sal_Bool bLast, 
sal_Bool bPage)
 {
 SfxItemSet aSet(rSh.GetAttrPool(), RES_ANCHOR, RES_ANCHOR,
-RES_VERT_ORIENT, RES_VERT_ORIENT, RES_HORI_ORIENT, 
RES_HORI_ORIENT, 0 );
+RES_VERT_ORIENT, RES_VERT

[Libreoffice-commits] core.git: sc/source

2015-01-31 Thread Caolán McNamara
 sc/source/ui/StatisticsDialogs/RandomNumberGeneratorDialog.cxx |2 +-
 sc/source/ui/inc/RandomNumberGeneratorDialog.hxx   |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 4ad4540e33c431a8b4b5b1692cee3432de88b3f1
Author: Caolán McNamara 
Date:   Sat Jan 31 18:57:25 2015 +

coverity#1267677 Big parameter passed by value

Change-Id: I04a96e13eb4f17a6fa91435eff104fd95a902cf2

diff --git a/sc/source/ui/StatisticsDialogs/RandomNumberGeneratorDialog.cxx 
b/sc/source/ui/StatisticsDialogs/RandomNumberGeneratorDialog.cxx
index 954cadd..ee906d4 100644
--- a/sc/source/ui/StatisticsDialogs/RandomNumberGeneratorDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/RandomNumberGeneratorDialog.cxx
@@ -252,7 +252,7 @@ void 
ScRandomNumberGeneratorDialog::SelectGeneratorAndGenerateNumbers()
 }
 
 template
-void ScRandomNumberGeneratorDialog::GenerateNumbers(RNG randomGenerator, const 
sal_Int16 aDistributionStringId, boost::optional aDecimalPlaces)
+void ScRandomNumberGeneratorDialog::GenerateNumbers(RNG& randomGenerator, 
const sal_Int16 aDistributionStringId, boost::optional aDecimalPlaces)
 {
 OUString aUndo = SC_STRLOAD(RID_STATISTICS_DLGS, 
STR_UNDO_DISTRIBUTION_TEMPLATE);
 OUString aDistributionName = SC_STRLOAD(RID_STATISTICS_DLGS, 
aDistributionStringId);
diff --git a/sc/source/ui/inc/RandomNumberGeneratorDialog.hxx 
b/sc/source/ui/inc/RandomNumberGeneratorDialog.hxx
index d940b39..b1736b2 100644
--- a/sc/source/ui/inc/RandomNumberGeneratorDialog.hxx
+++ b/sc/source/ui/inc/RandomNumberGeneratorDialog.hxx
@@ -65,7 +65,7 @@ private:
 
 template
 
-void GenerateNumbers(RNG randomGenerator, const sal_Int16 
aDistributionStringId, const boost::optional aDecimalPlaces);
+void GenerateNumbers(RNG& randomGenerator, const sal_Int16 
aDistributionStringId, const boost::optional aDecimalPlaces);
 
 void SelectGeneratorAndGenerateNumbers();
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 45/9c1d18f71552db70b349ef50828142cd6f744f

2015-01-31 Thread Caolán McNamara
 45/9c1d18f71552db70b349ef50828142cd6f744f |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 00def9c6a0a81bed9a2f2faa13421623240931e9
Author: Caolán McNamara 
Date:   Sat Jan 31 19:01:29 2015 +

Notes added by 'git notes add'

diff --git a/45/9c1d18f71552db70b349ef50828142cd6f744f 
b/45/9c1d18f71552db70b349ef50828142cd6f744f
new file mode 100644
index 000..26ccde6
--- /dev/null
+++ b/45/9c1d18f71552db70b349ef50828142cd6f744f
@@ -0,0 +1 @@
+prefer: 695d29e17feefb33ff54e7263ba2d322e665d176
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: 3 commits - connectivity/source extensions/source vcl/opengl

2015-01-31 Thread Caolán McNamara
 connectivity/source/drivers/file/FResultSet.cxx |   11 ---
 extensions/source/update/ui/updatecheckui.cxx   |4 ++--
 vcl/opengl/gdiimpl.cxx  |   12 +---
 3 files changed, 11 insertions(+), 16 deletions(-)

New commits:
commit eaf1c5f85bcf33fbb7e0ad0d6de4b33ae07445ae
Author: Caolán McNamara 
Date:   Sat Jan 31 19:14:02 2015 +

coverity#1267680 Dereference before null check

Change-Id: I4a7e8751a5a6a93bd0cb8208a06a7c4fd30ef1b4

diff --git a/extensions/source/update/ui/updatecheckui.cxx 
b/extensions/source/update/ui/updatecheckui.cxx
index cccb034..6f6d30b 100644
--- a/extensions/source/update/ui/updatecheckui.cxx
+++ b/extensions/source/update/ui/updatecheckui.cxx
@@ -735,8 +735,8 @@ IMPL_LINK( UpdateCheckUI, ApplicationEventHdl, 
VclSimpleEvent *, pEvent)
 if ( pWindow && pWindow->IsTopWindow() )
 {
 SystemWindow *pSysWin = pWindow->GetSystemWindow();
-MenuBar  *pMBar   = pSysWin->GetMenuBar();
-if ( pSysWin && pMBar )
+MenuBar *pMBar = pSysWin ? pSysWin->GetMenuBar() : NULL;
+if (pMBar)
 {
 AddMenuBarIcon( pSysWin, true );
 }
commit fed1ed0a17a770e9b4c75ef4737032f9ad2e154a
Author: Caolán McNamara 
Date:   Sat Jan 31 19:06:52 2015 +

coverity#1267670 Division or modulo by float zero

and

coverity#1267699 Division or modulo by float zero

Change-Id: If31037712208673438155b30369ebe1068387cba

diff --git a/vcl/opengl/gdiimpl.cxx b/vcl/opengl/gdiimpl.cxx
index 854c090..dcede20 100644
--- a/vcl/opengl/gdiimpl.cxx
+++ b/vcl/opengl/gdiimpl.cxx
@@ -934,23 +934,21 @@ void OpenGLSalGraphicsImpl::DrawTransformedTexture(
 return;
 }
 
-if( areaScaling )
+int mnWidth = rTexture.GetWidth();
+int mnHeight = rTexture.GetHeight();
+if(areaScaling )
 {
 // From OpenGLSalBitmap::ImplScaleArea().
-if( fastAreaScaling )
+if (fastAreaScaling && mnWidth && mnHeight)
 {
-int mnWidth = rTexture.GetWidth();
-int mnHeight = rTexture.GetHeight();
 mpProgram->SetUniform1i( "xscale", ixscale );
 mpProgram->SetUniform1i( "yscale", iyscale );
 mpProgram->SetUniform1f( "xstep", 1.0 / mnWidth );
 mpProgram->SetUniform1f( "ystep", 1.0 / mnHeight );
 mpProgram->SetUniform1f( "ratio", 1.0 / ( ixscale * iyscale ));
 }
-else
+else if (mnHeight > 1 && mnWidth > 1)
 {
-int mnWidth = rTexture.GetWidth();
-int mnHeight = rTexture.GetHeight();
 mpProgram->SetUniform1f( "xscale", ixscale );
 mpProgram->SetUniform1f( "yscale", iyscale );
 mpProgram->SetUniform1i( "swidth", mnWidth );
commit 1fb386749d9f9c599a08edcaef7848c82c95a38f
Author: Caolán McNamara 
Date:   Sat Jan 31 19:04:05 2015 +

coverity#1267674 Dereference after null check

Change-Id: I735e95a25b32d11b58ab3b187bfaac41b2f91e10

diff --git a/connectivity/source/drivers/file/FResultSet.cxx 
b/connectivity/source/drivers/file/FResultSet.cxx
index afc9d96..1394f93 100644
--- a/connectivity/source/drivers/file/FResultSet.cxx
+++ b/connectivity/source/drivers/file/FResultSet.cxx
@@ -1676,13 +1676,10 @@ Reference< ::com::sun::star::beans::XPropertySetInfo > 
SAL_CALL OResultSet::getP
 
 void OResultSet::doTableSpecials(const OSQLTable& _xTable)
 {
-Reference< ::com::sun::star::lang::XUnoTunnel> xTunnel(_xTable,UNO_QUERY);
-if(xTunnel.is())
-{
-m_pTable = reinterpret_cast< OFileTable* >( 
xTunnel->getSomething(OFileTable::getUnoTunnelImplementationId()) );
-if(m_pTable)
-m_pTable->acquire();
-}
+Reference xTunnel(_xTable, UNO_QUERY_THROW);
+m_pTable = reinterpret_cast< OFileTable* 
>(xTunnel->getSomething(OFileTable::getUnoTunnelImplementationId()));
+assert(m_pTable);
+m_pTable->acquire();
 }
 
 void OResultSet::clearInsertRow()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


LibreOffice Gerrit News for core on 2015-02-01

2015-01-31 Thread gerrit
Moin!

* Open changes on master for project core changed in the last 25 hours:

 First time contributors doing great things! 
+ fdo#39440: replace C-style cast's with static_cast
  in https://gerrit.libreoffice.org/14268 from Juan Picca
  about module basic
+ fdo#39440: remove redundant checks and breaks
  in https://gerrit.libreoffice.org/14267 from Juan Picca
  about module sw
+ fdo#46723 - enable configmgr unit tests
  in https://gerrit.libreoffice.org/13514 from Ioan Radu
  about module configmgr
+ fdo#88826: replace MM100toEMU() by convertHmmToEmu()
  in https://gerrit.libreoffice.org/14266 from Juan Picca
  about module include, oox, sc
 End of freshness 

+ fdo#47577  Zoom slider should only react to full click
  in https://gerrit.libreoffice.org/14265 from Rodolfo Ribeiro Gomes
  about module include, svx
+ fdo#83672 , fdo#67776 : Fixed shape rotation angle in xlsx import.
  in https://gerrit.libreoffice.org/13090 from sushil_shinde
  about module sc
+ fdo#85491 : break parameter incorrectly set in .XLSX import.
  in https://gerrit.libreoffice.org/12213 from sushil_shinde
  about module chart2, oox
+ tdf#88960 Scientific format: add/remove digits with buttons
  in https://gerrit.libreoffice.org/14264 from Laurent BP
  about module sc, svl
+ starmath: Refactor common code inside cfgitem and  modernize the code...
  in https://gerrit.libreoffice.org/14249 from Marcos Paulo de Souza
  about module starmath


* Merged changes on master for project core changed in the last 25 hours:

+ Use rtl/character.hxx in basic module when possible
  in https://gerrit.libreoffice.org/14170 from Arnaud Versini


* Abandoned changes on master for project core changed in the last 25 hours:

None

* Open changes needing tweaks, but being untouched for more than a week:

+ wip: get rid of svx dbtoolsclient
  in https://gerrit.libreoffice.org/11737 from Lionel Elie Mamane
+ fdo#86606 removal of direct formatting options from the context menu
  in https://gerrit.libreoffice.org/13196 from Yousuf Philips
+ Fix typo code Persistant
  in https://gerrit.libreoffice.org/14030 from Andrea Gelmini
+ fdo#88309: Standardize, cleanup, and improve Assertions
  in https://gerrit.libreoffice.org/13945 from Ashod Nakashian
+ --with-macosx-app-name= is unused, so bin it from AC_ARG_WITH list
  in https://gerrit.libreoffice.org/13658 from Douglas Mencken
+ fdo#30541: Default icon set on Windows should be Galaxy, not Tango.
  in https://gerrit.libreoffice.org/13859 from Rimas Kudelis
+ fdo#63905: fix regression by using paper size set in printer properties
  in https://gerrit.libreoffice.org/13763 from Clément Lassieur
+ fdo#75825-"Send Document as E-Mail" not working
  in https://gerrit.libreoffice.org/13786 from Charu Tyagi
+ solenv-filelists.pm: fix "can't call method `mode' on an undefined value"
  in https://gerrit.libreoffice.org/13669 from Douglas Mencken
+ gbuild-to-ide fixes
  in https://gerrit.libreoffice.org/11754 from Peter Foley
+ fdo#82335.
  in https://gerrit.libreoffice.org/11555 from Sudarshan Rao
+ fdo#39625 Make existing CppUnittests work
  in https://gerrit.libreoffice.org/11605 from Tobias Madl
+ fdo#86784 make soffice commandline in juh Bootstrap.bootstrap() configura
  in https://gerrit.libreoffice.org/13290 from Christoph Lutz
+ start detection of kf5 stuff in configure.ac
  in https://gerrit.libreoffice.org/13079 from Jonathan Riddell
+ more breeze icons
  in https://gerrit.libreoffice.org/13058 from Jonathan Riddell
+ Perftest for loading autocorrect dictionaries, related fdo#79761
  in https://gerrit.libreoffice.org/11296 from Matúš Kukan


Best,

Your friendly LibreOffice Gerrit Digest Mailer

Note: The bot generating this message can be found and improved here:
   
https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice