Re: [Libcdio-devel] Unmerged branch ts-cdtext-fix
Hi, i merged "ts-cdtext-fix" with "master", ran "make check" again, and then pushed "master". Have a nice day :) Thomas
[Libcdio-devel] Makefile change for joliet_multi_extent, was: Unmerged branch ts-cdtext-fix
Hi, i wrote: > > - In "joliet_multi_extent" please check whether your wishes about the > > larger multi-extent test ISO are fulfilled. Rocky Bernstein wrote: > We want the new README and all of the iso, cue, and bin files included in a > distribution. The way that is done is by listing them in Makefile.am > variable EXTRA_DIST. > Attached is a patch file that does this. git am refuses to apply it to a branch derived from "joliet_multi_extent": Patch does not have a valid e-mail address. So i applied it by patch -p1 -b ChangeLog (after installing git2cl). I also renamed my *.orig files to *.original. Then i did again: make dist which seems to have succeeded with producing libcdio-2.1.0.tar.gz libcdio-2.1.0.tar.bz2 It contains some .bin and .cue files, as well as test/README.multiextent . The test went too bumpy to give me enough confidence for committing to "joliet_multi_extent" and merging. So i propose that you take care of that branch and merge it when ready. Have a nice day :) Thomas
Re: [Libcdio-devel] Makefile change for joliet_multi_extent, was: Unmerged branch ts-cdtext-fix
On Sun, Apr 9, 2023 at 8:05 AM Thomas Schmitt wrote: > Hi, > > ... - > > The test went too bumpy to give me enough confidence for committing to > "joliet_multi_extent" and merging. > So i propose that you take care of that branch and merge it when ready. > No problem. joliet_multi_extent has been merged to master and the branch on savannah.gnu.org has been deleted. (Of course you still have a local copy of an older version) There were mistakes in the patch I sent. You can look at commit 5f797b27d1b73815f27c03e8ee9074e35e37f0e2 for the proper final changes. I had to break out the GNU make and bash debuggers to track my mistakes. But in short, `make distcheck` works on master. > > Have a nice day :) > > Thomas > > >
