Re: Porting a project to KDE

2020-08-20 Thread Albert Astals Cid
El diumenge, 16 d’agost de 2020, a les 0:01:11 CEST, Francois Blanchette va 
escriure:
> Great observation. I just updated the CmakeLists.txt. I don’t know how
> compliant it is right now but at least it compiles and links.
> https://github.com/cfrankb/lgck-src/blob/develop/src/lgck-builder/CMakeLists.txt

Fails to build here

/home/tsdgeos/lgck-src/src/lgck-builder/main.cpp:28:10: fatal error: 
ss_build.h: File or directory does not exist
   28 | #include "ss_build.h"
  |  ^~~~

Cheers,
  Albert




Re: Porting a project to KDE

2020-08-20 Thread Albert Astals Cid
El dijous, 20 d’agost de 2020, a les 16:40:44 CEST, Francois Blanchette va 
escriure:
> Fixed. I pushed a patch to the develop branch to remove this dependency.

Almost works now.

It compiles but I'm getting linking errors

/usr/bin/ld: 
CMakeFiles/lgck-builder.dir/home/tsdgeos/lgck-src/src/shared/implementers/sdl/gr_sdl.cpp.o:
 in function `CGRSdl::clear(unsigned int, unsigned int, unsigned int) [clone 
.localalias]':
gr_sdl.cpp:(.text+0x59): undefined reference to `SDL_SetRenderDrawColor'

SDL_SetRenderDrawColor seems to be from SDL2 but you're only doing cmake stuff 
regarding SDL1?

Cheers,
  Albert

> 
> 
> On 8/20/20, Albert Astals Cid  wrote:
> > El diumenge, 16 d’agost de 2020, a les 0:01:11 CEST, Francois Blanchette va
> > escriure:
> >> Great observation. I just updated the CmakeLists.txt. I don’t know how
> >> compliant it is right now but at least it compiles and links.
> >> https://github.com/cfrankb/lgck-src/blob/develop/src/lgck-builder/CMakeLists.txt
> >
> > Fails to build here
> >
> > /home/tsdgeos/lgck-src/src/lgck-builder/main.cpp:28:10: fatal error:
> > ss_build.h: File or directory does not exist
> >28 | #include "ss_build.h"
> >   |  ^~~~
> >
> > Cheers,
> >   Albert
> >
> >
> >
> 






ANNOUNCE] CMake 3.18.2 available for download

2020-08-20 Thread Robert Maynard
We are pleased to announce that CMake 3.18.2 is now available for download.

Please use the latest release from our download page:
  https://cmake.org/download/

Thanks for your support!

-
Changes in 3.18.2 since 3.18.1:

Alexandru Croitor (2):
  AutoGen: Fix over-specified direct dependencies of custom command
  AutoGen: Add test to check for correct AutoMoc dependencies

Axel Huebl (1):
  FindMPI: Fix regression in pthread guard

Ben Boeckel (1):
  FPHSA: detect inclusion between find modules

Brad King (8):
  Tests: Isolate RunCMake.FindPkgConfig from caller environment
  FindRuby: Restore compatibility variable RUBY_INCLUDE_PATH
  Xcode: Explicitly turn off signing in try_compile projects
  PCH: Avoid Apple-specific architecture flags on other platforms
  gitlab-ci: add 'cmake' tag to all jobs
  Tests: Fix RunCMake.try_compile test for C standards with MSVC 19.27
  gitlab-ci: Update Windows builds to MSVC 19.27
  CMake 3.18.2

Craig Scott (2):
  ExternalProject: Stop patch target from always appearing out-of-date
  ExternalProject: Stop configure target from always appearing out-of-date

Cristian Adam (1):
  PCH: Avoid unnecessary 30s delay on MSBuild Generator with REUSE_FROM

Daniele E. Domenichelli (1):
  FindRuby: Add documentation for deprecated variables

Joerg Bornemann (2):
  Autogen: Turn off moc path prefix generation by default
  Help: Add 3.18.2 release note about AUTOMOC_PATH_PREFIX default change

Kyle Edwards (1):
  Ninja: Restore shorter path to response files

Laurits Riple (1):
  GoogleTest: Restore support for list arguments in TEST_EXECUTOR

Marc Chevrier (3):
  FindPython: ensure user's policies are respected
  FindPython: manage SOABI for all Python versions
  FindPython: enhance robustness of version extraction from library name

Raul Tambre (1):
  MSVC: Record support for C11 and c_restrict

Robert Maynard (1):
  CMakeFindBinUtils: Always consider plain binutils when not cross-compiling

Seth R Johnson (1):
  FindHDF5: fix compiler detection when HL is disabled

Thomas Bernard (1):
  llvm-rc: Fix quoting of path to cmake in CMAKE_RC_COMPILE_OBJECT


Re: Porting a project to KDE

2020-08-20 Thread Francois Blanchette
You are correct. :) References to SDL in the CMakeLists.txt should SDL2.
I pushed another patch to develop branch.

On 8/20/20, Albert Astals Cid  wrote:
> El dijous, 20 d’agost de 2020, a les 16:40:44 CEST, Francois Blanchette va
> escriure:
>> Fixed. I pushed a patch to the develop branch to remove this dependency.
>
> Almost works now.
>
> It compiles but I'm getting linking errors
>
> /usr/bin/ld:
> CMakeFiles/lgck-builder.dir/home/tsdgeos/lgck-src/src/shared/implementers/sdl/gr_sdl.cpp.o:
> in function `CGRSdl::clear(unsigned int, unsigned int, unsigned int) [clone
> .localalias]':
> gr_sdl.cpp:(.text+0x59): undefined reference to `SDL_SetRenderDrawColor'
>
> SDL_SetRenderDrawColor seems to be from SDL2 but you're only doing cmake
> stuff regarding SDL1?
>
> Cheers,
>   Albert
>
>>
>>
>> On 8/20/20, Albert Astals Cid  wrote:
>> > El diumenge, 16 d’agost de 2020, a les 0:01:11 CEST, Francois Blanchette
>> > va
>> > escriure:
>> >> Great observation. I just updated the CmakeLists.txt. I don’t know how
>> >> compliant it is right now but at least it compiles and links.
>> >> https://github.com/cfrankb/lgck-src/blob/develop/src/lgck-builder/CMakeLists.txt
>> >
>> > Fails to build here
>> >
>> > /home/tsdgeos/lgck-src/src/lgck-builder/main.cpp:28:10: fatal error:
>> > ss_build.h: File or directory does not exist
>> >28 | #include "ss_build.h"
>> >   |  ^~~~
>> >
>> > Cheers,
>> >   Albert
>> >
>> >
>> >
>>
>
>
>
>
>


Re: Porting a project to KDE

2020-08-20 Thread Albert Astals Cid
El dijous, 20 d’agost de 2020, a les 23:53:27 CEST, Francois Blanchette va 
escriure:
> You are correct. :) References to SDL in the CMakeLists.txt should SDL2.
> I pushed another patch to develop branch.

I've needed this to make it link for me.

http://paste.debian.net/1160708/

Cheers,
  Albert

> 
> On 8/20/20, Albert Astals Cid  wrote:
> > El dijous, 20 d’agost de 2020, a les 16:40:44 CEST, Francois Blanchette va
> > escriure:
> >> Fixed. I pushed a patch to the develop branch to remove this dependency.
> >
> > Almost works now.
> >
> > It compiles but I'm getting linking errors
> >
> > /usr/bin/ld:
> > CMakeFiles/lgck-builder.dir/home/tsdgeos/lgck-src/src/shared/implementers/sdl/gr_sdl.cpp.o:
> > in function `CGRSdl::clear(unsigned int, unsigned int, unsigned int) [clone
> > .localalias]':
> > gr_sdl.cpp:(.text+0x59): undefined reference to `SDL_SetRenderDrawColor'
> >
> > SDL_SetRenderDrawColor seems to be from SDL2 but you're only doing cmake
> > stuff regarding SDL1?
> >
> > Cheers,
> >   Albert
> >
> >>
> >>
> >> On 8/20/20, Albert Astals Cid  wrote:
> >> > El diumenge, 16 d’agost de 2020, a les 0:01:11 CEST, Francois Blanchette
> >> > va
> >> > escriure:
> >> >> Great observation. I just updated the CmakeLists.txt. I don’t know how
> >> >> compliant it is right now but at least it compiles and links.
> >> >> https://github.com/cfrankb/lgck-src/blob/develop/src/lgck-builder/CMakeLists.txt
> >> >
> >> > Fails to build here
> >> >
> >> > /home/tsdgeos/lgck-src/src/lgck-builder/main.cpp:28:10: fatal error:
> >> > ss_build.h: File or directory does not exist
> >> >28 | #include "ss_build.h"
> >> >   |  ^~~~
> >> >
> >> > Cheers,
> >> >   Albert
> >> >
> >> >
> >> >
> >>
> >
> >
> >
> >
> >
>