Re: Who creates the standard folders in user home?
Kai Uwe Broulik wrote: > Hi there, > > I was just wondering who creates the standard folders in the user's home > location such as Pictures, Videos, Downloads, Desktop..? They are > re-created on session startup if they are missing. I believe it is xdg-user-dirs >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Review Request 118752: Fix Baloo to work against frameworkified KFileMetaData.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118752/#review60194 --- Thanks for this, but would you mind rebasing your patch with this - https://git.reviewboard.kde.org/r/118670/ - Vishesh Handa On June 14, 2014, 10:53 p.m., Matthew Dawson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118752/ > --- > > (Updated June 14, 2014, 10:53 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > --- > > Fix Baloo to work against frameworkified KFileMetaData. > > Change Baloo to find KFileMetaData as a proper framework, and change the > necessary include statements. > > > Diffs > - > > src/file/lib/file.h 89c03e2c3ddcc7215ec8451caeeb6323b8eeed9b > src/file/lib/autotests/filefetchjobtest.cpp > f9c49ff30ee119950603f1b9628c14fffe0bd5dd > src/file/extractor/result.cpp b2d5615ce3645d6e0ff435b3771539e1aeea5380 > src/file/extractor/result.h 3dbde3d333076543f141859b074da47d1ed593c2 > src/file/extractor/app.cpp 00c250e5796c58b0fb1a7b7f8ba7849df557f56e > src/file/extractor/app.h 9e674d369fb25538ed971dce9026fe53d697db3e > src/file/basicindexingjob.cpp b53cd79ccded7ce901cfd80c1eea119c6f6ab121 > src/file/basicindexingjob.h f72680c499de5f6d48a1b2bdedceb1877101e3b2 > CMakeLists.txt 7a07aa465601d4d196e9fa9158c05d1573d0f90d > src/file/lib/file_p.h a4fcf44325a360149fa646e8b8adb15c68a6b20e > src/file/search/CMakeLists.txt 5549943aaf98026a698b4a4ae6bba4df01699012 > src/file/search/filesearchstore.cpp > 0b1a6201ed7ae12f776daf2392313406d0168de3 > src/tools/balooshow/main.cpp db0acb019c9bda696775150ccc4f6007fec7be82 > > Diff: https://git.reviewboard.kde.org/r/118752/diff/ > > > Testing > --- > > Compiles and tests fine. > > > Thanks, > > Matthew Dawson > > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Review Request 118438: Add an option to only build baloo's libraries
> On June 4, 2014, 2:55 p.m., Vishesh Handa wrote: > > I'm not too sure about this. I was planning on moving the runners, kcm and > > kioslaves out of the baloo repository and into plasma-desktop and > > plasma-workspace. This just leaves the executables, which IMO should > > overwrite the old ones, but that would be a problem, right? > > Heiko Becker wrote: > Well, splitting it out would work for us, too. So that leaves the > binaries. If they shouldn't be renamed it would to nice to have a cmake > option in order to decide if they should be build. That way we could provide > packages with an option allowing the user to build and install the binaries > for the version he wants (probably matching his version of Plasma workspaces). > > I'd be willing to adjust this patch to only make the building of binaries > depending on a cmake option, if it's alright with you. > Just to confirm, this patch would also need to go in the KDE4 version as well, right? - Vishesh --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118438/#review59206 --- On May 31, 2014, 11:54 a.m., Heiko Becker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118438/ > --- > > (Updated May 31, 2014, 11:54 a.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > --- > > The intention behind this review request is to make it easier to turn baloo > into a framework and make it coinstallable with its KDE4 counterpart in a > second review request. > > That being said I'm not exactly sure this is the way you guys want to go, but > I'd be willing to update my review request accordingly if you have other > plans to make it coinstallable. > > > Diffs > - > > src/CMakeLists.txt de044025012ebcccb8a9c7293edfe045cc9b7856 > src/file/CMakeLists.txt 4f9fb9dd6b0e680a5f70cfaeb3986000cb192acd > > Diff: https://git.reviewboard.kde.org/r/118438/diff/ > > > Testing > --- > > cmake -DBALOO_LIBRARIES_ONLY:BOOL=TRUE .. > make > make install > > I've also built the frameworks branch of milou against it (needed a few > modifications). > > > Thanks, > > Heiko Becker > > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Review Request 118438: Add an option to only build baloo's libraries
> On June 4, 2014, 2:55 p.m., Vishesh Handa wrote: > > I'm not too sure about this. I was planning on moving the runners, kcm and > > kioslaves out of the baloo repository and into plasma-desktop and > > plasma-workspace. This just leaves the executables, which IMO should > > overwrite the old ones, but that would be a problem, right? > > Heiko Becker wrote: > Well, splitting it out would work for us, too. So that leaves the > binaries. If they shouldn't be renamed it would to nice to have a cmake > option in order to decide if they should be build. That way we could provide > packages with an option allowing the user to build and install the binaries > for the version he wants (probably matching his version of Plasma workspaces). > > I'd be willing to adjust this patch to only make the building of binaries > depending on a cmake option, if it's alright with you. > > > Vishesh Handa wrote: > Just to confirm, this patch would also need to go in the KDE4 version as > well, right? Yes, something similar was done for kactivities: http://quickgit.kde.org/?p=kactivities.git&a=commitdiff&h=f6c2bddb07b43ca857098c5bb2661e236d07bb57 (and http://quickgit.kde.org/?p=kactivities.git&a=commitdiff&h=51de5b25d483c45f37918efd690ba1d6dd0c2388 for KF5). - Heiko --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118438/#review59206 --- On May 31, 2014, 11:54 a.m., Heiko Becker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118438/ > --- > > (Updated May 31, 2014, 11:54 a.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > --- > > The intention behind this review request is to make it easier to turn baloo > into a framework and make it coinstallable with its KDE4 counterpart in a > second review request. > > That being said I'm not exactly sure this is the way you guys want to go, but > I'd be willing to update my review request accordingly if you have other > plans to make it coinstallable. > > > Diffs > - > > src/CMakeLists.txt de044025012ebcccb8a9c7293edfe045cc9b7856 > src/file/CMakeLists.txt 4f9fb9dd6b0e680a5f70cfaeb3986000cb192acd > > Diff: https://git.reviewboard.kde.org/r/118438/diff/ > > > Testing > --- > > cmake -DBALOO_LIBRARIES_ONLY:BOOL=TRUE .. > make > make install > > I've also built the frameworks branch of milou against it (needed a few > modifications). > > > Thanks, > > Heiko Becker > > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Review Request 118752: Fix Baloo to work against frameworkified KFileMetaData.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118752/ --- (Updated June 16, 2014, 6:05 p.m.) Review request for Baloo. Changes --- Update to work on the new frameworkified KFileMetaData. Repository: baloo Description --- Fix Baloo to work against frameworkified KFileMetaData. Change Baloo to find KFileMetaData as a proper framework, and change the necessary include statements. Diffs (updated) - src/tools/balooshow/main.cpp db0acb019c9bda696775150ccc4f6007fec7be82 src/file/search/filesearchstore.cpp 0b1a6201ed7ae12f776daf2392313406d0168de3 src/file/search/CMakeLists.txt 5549943aaf98026a698b4a4ae6bba4df01699012 src/file/lib/file_p.h a4fcf44325a360149fa646e8b8adb15c68a6b20e src/file/lib/file.h 89c03e2c3ddcc7215ec8451caeeb6323b8eeed9b src/file/lib/autotests/filefetchjobtest.cpp f9c49ff30ee119950603f1b9628c14fffe0bd5dd src/file/extractor/result.cpp b2d5615ce3645d6e0ff435b3771539e1aeea5380 src/file/extractor/result.h 3dbde3d333076543f141859b074da47d1ed593c2 src/file/extractor/app.cpp 00c250e5796c58b0fb1a7b7f8ba7849df557f56e src/file/extractor/app.h 9e674d369fb25538ed971dce9026fe53d697db3e src/file/basicindexingjob.cpp b53cd79ccded7ce901cfd80c1eea119c6f6ab121 src/file/basicindexingjob.h f72680c499de5f6d48a1b2bdedceb1877101e3b2 CMakeLists.txt 7a07aa465601d4d196e9fa9158c05d1573d0f90d Diff: https://git.reviewboard.kde.org/r/118752/diff/ Testing --- Compiles and tests fine. Thanks, Matthew Dawson >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<