[digikam] [Bug 467245] New: NetBSD compilation fix for Neptune
https://bugs.kde.org/show_bug.cgi?id=467245 Bug ID: 467245 Summary: NetBSD compilation fix for Neptune Classification: Applications Product: digikam Version: 7.9.0 Platform: NetBSD pkgsrc OS: NetBSD Status: REPORTED Severity: major Priority: NOR Component: Plugin-Generic-MediaServer Assignee: digikam-bugs-n...@kde.org Reporter: t...@giga.or.at Target Milestone: --- Created attachment 157215 --> https://bugs.kde.org/attachment.cgi?id=157215&action=edit Patch fixing the problem. On NetBSD, linking fails due to a missing Resolve() function because NPT_CONFIG_HAVE_GETADDRINFO is not defined and the function is not compiled. The attached patch fixes the problem. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kfilemetadata] [Bug 469607] kfilemetadata does not build with exiv2 0.28.0
https://bugs.kde.org/show_bug.cgi?id=469607 Thomas Klausner changed: What|Removed |Added CC||t...@giga.or.at --- Comment #2 from Thomas Klausner --- I've asked upstream for a portability guide https://github.com/Exiv2/exiv2/issues/2630 -- You are receiving this mail because: You are watching all bug changes.
[kid3] [Bug 465144] New: Add explicit encoding to python's fileopen
https://bugs.kde.org/show_bug.cgi?id=465144 Bug ID: 465144 Summary: Add explicit encoding to python's fileopen Classification: Applications Product: kid3 Version: 3.9.x Platform: NetBSD pkgsrc OS: NetBSD Status: REPORTED Severity: major Priority: NOR Component: general Assignee: uflei...@users.sourceforge.net Reporter: t...@giga.or.at Target Milestone: --- Created attachment 155858 --> https://bugs.kde.org/attachment.cgi?id=155858&action=edit Patch fixing the problem. With the default C locale on NetBSD, the fixappdata.py script as run in the build reports an error: UnicodeDecodeError: 'ascii' codec can't decode byte 0xd9 in position 305: ordinal not in range(128) Please apply the attached patch to give fileinput.input() an explicit encoding argument - this fixes the issue. -- You are receiving this mail because: You are watching all bug changes.
[kid3] [Bug 465144] Add explicit encoding to python's fileopen
https://bugs.kde.org/show_bug.cgi?id=465144 Thomas Klausner changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED|RESOLVED --- Comment #2 from Thomas Klausner --- Thanks for the information - the committed patch works for me. -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 501769] New: Build uses -Werror=undef, which makes it fail
https://bugs.kde.org/show_bug.cgi?id=501769 Bug ID: 501769 Summary: Build uses -Werror=undef, which makes it fail Classification: Applications Product: digikam Version: 8.6.0 Platform: NetBSD pkgsrc OS: NetBSD Status: REPORTED Severity: normal Priority: NOR Component: Portability-Compilation Assignee: digikam-bugs-n...@kde.org Reporter: w...@gatalith.at Target Milestone: --- When compiling digikam 8.6.0 using dependencies from pkgsrc on NetBSD 10.99.12/x86_64, in particular x265-4.1 and jasper-4.2.4, I see the following compilation error: In file included from /scratch/wip/digikam/work/.buildlink/include/jasper/jas_version.h:73, from /scratch/wip/digikam/work/digikam-8.6.0/core/libs/dialogs/libsinfodlg.cpp:119: /scratch/wip/digikam/work/.buildlink/include/jasper/jas_config.h:116:6: error: "__STDC_VERSION__" is not defined, evaluates to 0 [-Werror=undef] 116 | #if (__STDC_VERSION__ - 0 < JAS_STDC_VERSION) | ^~~~ /scratch/wip/digikam/work/.buildlink/include/jasper/jas_config.h:117:2: warning: #warning "Your code is being built against an older version of the C standard than JasPer was. Although this is supported, this may require some extra preprocessor defines when building." [-Wcpp] 117 | #warning "Your code is being built against an older version of the C standard than JasPer was. Although this is supported, this may require some extra preprocessor defines when building." | ^~~ In file included from /scratch/wip/digikam/work/digikam-8.6.0/core/libs/dialogs/libsinfodlg.cpp:151: /scratch/wip/digikam/work/.buildlink/include/x265.h:35:5: error: "_MSC_VER" is not defined, evaluates to 0 [-Werror=undef] 35 | #if _MSC_VER | ^~~~ /scratch/wip/digikam/work/.buildlink/include/x265.h:186:5: error: "X265_DEPTH" is not defined, evaluates to 0 [-Werror=undef] 186 | #if X265_DEPTH < 10 | ^~ /scratch/wip/digikam/work/.buildlink/include/x265.h:643:5: error: "ENABLE_MULTIVIEW" is not defined, evaluates to 0 [-Werror=undef] 643 | #if ENABLE_MULTIVIEW | ^~~~ /scratch/wip/digikam/work/.buildlink/include/x265.h:650:5: error: "ENABLE_ALPHA" is not defined, evaluates to 0 [-Werror=undef] 650 | #if ENABLE_ALPHA | ^~~~ /scratch/wip/digikam/work/.buildlink/include/x265.h:656:5: error: "ENABLE_ALPHA" is not defined, evaluates to 0 [-Werror=undef] 656 | #if ENABLE_ALPHA || ENABLE_MULTIVIEW | ^~~~ /scratch/wip/digikam/work/.buildlink/include/x265.h:656:21: error: "ENABLE_MULTIVIEW" is not defined, evaluates to 0 [-Werror=undef] 656 | #if ENABLE_ALPHA || ENABLE_MULTIVIEW | ^~~~ /scratch/wip/digikam/work/.buildlink/include/x265.h:665:5: error: "ENABLE_SCC_EXT" is not defined, evaluates to 0 [-Werror=undef] 665 | #if ENABLE_SCC_EXT | ^~ /scratch/wip/digikam/work/.buildlink/include/x265.h:2400:5: error: "ENABLE_SCC_EXT" is not defined, evaluates to 0 [-Werror=undef] 2400 | #if ENABLE_SCC_EXT | ^~ /scratch/wip/digikam/work/.buildlink/include/x265.h:2618:5: error: "ENABLE_LIBVMAF" is not defined, evaluates to 0 [-Werror=undef] 2618 | #if ENABLE_LIBVMAF | ^~ /scratch/wip/digikam/work/.buildlink/include/x265.h:2690:5: error: "ENABLE_LIBVMAF" is not defined, evaluates to 0 [-Werror=undef] 2690 | #if ENABLE_LIBVMAF | ^~ Removing -Werror=undef (via the pkgsrc compiler wrapper) allows the build to finish. I must confess I'm not sure where it originates from. Grepping the digikam sources I can't find it being set, but after running cmake, it is there all over the place, e.g. work/digikam-8.6.0/_KDE_build/CMakeFiles/CMakeConfigureLog.yaml: CMAKE_CXX_FLAGS: "-O2 -g -fstack-clash-protection -pthread -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/ImageMagick-7 -I/usr/pkg/include/freet ype2 -I/usr/pkg/include/glib-2.0 -I/usr/pkg/include/gio-unix-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include/harfbuzz -I/usr/pkg/include/opencv4 -I/usr/pkg/include/ffmpeg6 -I/usr/pkg/include/libdrm -I/usr/pkg/qt6/ include -I/usr/pkg/include/gstreamer-1.0 -fno-operator-names -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual - Werror=return-type -Werror=init-self -Werror=undef -Wvla" or work/digikam-8.6.0/_KDE_build/build.ninja: FLAGS = -O2 -g -fstack-clash-protection -pthread -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/ImageMagick-7 -I/usr/pkg/include/freetype2 -I/usr/pkg/include/glib-2.0 -I/ usr/pkg/include/gio-unix-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include/harfbuzz -I/usr/pkg/include/opencv4 -I/usr/pkg/include/ffmpeg6 -I/usr/pkg/include/libdrm -I/usr/pkg/qt6/include -I/usr/pkg/include/gstreamer
[digikam] [Bug 501604] 8.6.0 compilation error in QtAVPlayer/qavstream.cpp
https://bugs.kde.org/show_bug.cgi?id=501604 --- Comment #4 from Thomas Klausner --- Yes, you're right, std::round is used in that other file. I guess (I didn't check in detail) that it includes cmath. Here's an alternate patch for QtAVPlayer that also fixes the problem and is perhaps more acceptable: ``` --- core/libs/video/QtAVPlayer/qavstream.cpp.orig 2025-03-15 14:01:45.0 + +++ core/libs/video/QtAVPlayer/qavstream.cpp @@ -5,6 +5,7 @@ * Free Qt Media Player based on FFmpeg. * */ +#include #include "qavstream.h" #include "qavdemuxer_p.h" #include "qavcodec_p.h" ``` -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 501604] 8.6.0 compilation error in QtAVPlayer/qavstream.cpp
https://bugs.kde.org/show_bug.cgi?id=501604 Thomas Klausner changed: What|Removed |Added Attachment #179478|0 |1 is obsolete|| --- Comment #5 from Thomas Klausner --- Created attachment 179488 --> https://bugs.kde.org/attachment.cgi?id=179488&action=edit Alternate patch, including cmath -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 501769] Build uses -Werror=undef, which makes it fail
https://bugs.kde.org/show_bug.cgi?id=501769 Thomas Klausner changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED|RESOLVED --- Comment #7 from Thomas Klausner --- Thank you! Your latest commit applied to 8.6.0 fixes the problem for me. -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 501604] New: 8.6.0 compilation error in QtAVPlayer/qavstream.cpp
https://bugs.kde.org/show_bug.cgi?id=501604 Bug ID: 501604 Summary: 8.6.0 compilation error in QtAVPlayer/qavstream.cpp Classification: Applications Product: digikam Version: 8.6.0 Platform: NetBSD pkgsrc OS: NetBSD Status: REPORTED Severity: major Priority: NOR Component: Preview-Video Assignee: digikam-bugs-n...@kde.org Reporter: w...@gatalith.at Target Milestone: --- Created attachment 179478 --> https://bugs.kde.org/attachment.cgi?id=179478&action=edit Patch fixing the problem. I'm currently updating the pkgsrc package for digiKam from 8.5.0 to 8.6.0, and see one new compilation error on NetBSD 10.99.12/x86_64 with gcc 12.4.0: ``` digikam-8.6.0/core/libs/video/QtAVPlayer/qavstream.cpp: In function 'int streamRotation(const AVStream*)': digikam-8.6.0/core/libs/video/QtAVPlayer/qavstream.cpp:100:43: error: 'round' is not a member of 'std' 100 | auto rotation = static_cast(std::round(av_display_rotation_get(reinterpret_cast(sideData; | ^ ``` The attached patch (removing `std::`) fixes the problem for me. (I'm sorry if I picked the wrong Component, but I think there are too many to select from in the small selection box.) -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 501604] 8.6.0 compilation error in QtAVPlayer/qavstream.cpp
https://bugs.kde.org/show_bug.cgi?id=501604 Thomas Klausner changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED|RESOLVED --- Comment #9 from Thomas Klausner --- Thank you! I can confirm that the committed patch fixes the problem. -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 501769] Build uses -Werror=undef, which makes it fail
https://bugs.kde.org/show_bug.cgi?id=501769 --- Comment #4 from Thomas Klausner --- jasper already had a bug report about this, and I mentioned the digikam problem there: https://github.com/jasper-software/jasper/issues/393 The patch is not enough, sadly. I see other locations e.g. /scratch/wip/digikam/work/digikam-8.6.0/core/libs/dngwriter/extra/xmp_sdk/source/XML_Node.cpp:11:5: error: "AdobePrivate" is not defined, evaluates to 0 [-Werror=undef] 11 | #if AdobePrivate | ^~~~ In file included from /scratch/wip/digikam/work/digikam-8.6.0/core/libs/dngwriter/extra/xmp_sdk/source/XML_Node.cpp:32: /scratch/wip/digikam/work/digikam-8.6.0/core/libs/dngwriter/extra/xmp_sdk/public/include/XMP_Environment.h:23:5: error: "AdobePrivate" is not defined, evaluates to 0 [-Werror=undef] 23 | #if AdobePrivate | ^~~~ /scratch/wip/digikam/work/digikam-8.6.0/core/libs/dngwriter/extra/xmp_sdk/public/include/XMP_Environment.h:233:9: error: "_WIN64" is not defined, evaluates to 0 [-Werror=undef] 233 | #if _WIN64 || defined(_LP64) | ^~ /scratch/wip/digikam/work/digikam-8.6.0/core/libs/dngwriter/extra/xmp_sdk/public/include/XMP_Environment.h:288:6: error: "XMP_DynamicBuild" is not defined, evaluates to 0 [-Werror=undef] 288 | #if (XMP_DynamicBuild) | ^~~~ In file included from /scratch/wip/digikam/work/digikam-8.6.0/core/libs/dngwriter/extra/xmp_sdk/public/include/XMPCore/XMPCoreDefines.h:25, from /scratch/wip/digikam/work/digikam-8.6.0/core/libs/dngwriter/extra/xmp_sdk/public/include/XMP_Const.h:2071, from /scratch/wip/digikam/work/digikam-8.6.0/core/libs/dngwriter/extra/xmp_sdk/source/XMLParserAdapter.hpp:52, from /scratch/wip/digikam/work/digikam-8.6.0/core/libs/dngwriter/extra/xmp_sdk/source/XML_Node.cpp:33: /scratch/wip/digikam/work/digikam-8.6.0/core/libs/dngwriter/extra/xmp_sdk/public/include/XMPCommon/XMPCommonDefines.h:110:14: error: "__clang__" is not defined, evaluates to 0 [-Werror=undef] 110 | # if __clang__ | ^ /scratch/wip/digikam/work/digikam-8.6.0/core/libs/dngwriter/extra/xmp_sdk/public/include/XMPCommon/XMPCommonDefines.h:149:9: error: "SOURCE_COMPILING_XMP_ALL" is not defined, evaluates to 0 [-Werror=undef] 149 | #if SOURCE_COMPILING_XMP_ALL || SOURCE_COMPILING_XMPCORE_LIB || SOURCE_COMPILING_XMPCOMPAREANDMERGE_LIB || SOURCE_COMPILING_XMPEXTENSIONS_LIB | ^~~~ /scratch/wip/digikam/work/digikam-8.6.0/core/libs/dngwriter/extra/xmp_sdk/public/include/XMPCommon/XMPCommonDefines.h:149:37: error: "SOURCE_COMPILING_XMPCORE_LIB" is not defined, evaluates to 0 [-Werror=undef] 149 | #if SOURCE_COMPILING_XMP_ALL || SOURCE_COMPILING_XMPCORE_LIB || SOURCE_COMPILING_XMPCOMPAREANDMERGE_LIB || SOURCE_COMPILING_XMPEXTENSIONS_LIB | ^~~~ /scratch/wip/digikam/work/digikam-8.6.0/core/libs/dngwriter/extra/xmp_sdk/public/include/XMPCommon/XMPCommonDefines.h:149:69: error: "SOURCE_COMPILING_XMPCOMPAREANDMERGE_LIB" is not defined, evaluates to 0 [-Werror=undef ] 149 | #if SOURCE_COMPILING_XMP_ALL || SOURCE_COMPILING_XMPCORE_LIB || SOURCE_COMPILING_XMPCOMPAREANDMERGE_LIB || SOURCE_COMPILING_XMPEXTENSIONS_LIB | ^~~ /scratch/wip/digikam/work/digikam-8.6.0/core/libs/dngwriter/extra/xmp_sdk/public/include/XMPCommon/XMPCommonDefines.h:149:112: error: "SOURCE_COMPILING_XMPEXTENSIONS_LIB" is not defined, evaluates to 0 [-Werror=undef] 149 | #if SOURCE_COMPILING_XMP_ALL || SOURCE_COMPILING_XMPCORE_LIB || SOURCE_COMPILING_XMPCOMPAREANDMERGE_LIB || SOURCE_COMPILING_XMPEXTENSIONS_LIB | ^~ In file included from /scratch/wip/digikam/work/digikam-8.6.0/core/libs/dngwriter/extra/xmp_sdk/source/XMLParserAdapter.hpp:54: 08:47:35 [720/1974] /scratch/wip/digikam/work/digikam-8.6.0/core/libs/dngwriter/extra/xmp_sdk/source/XMP_LibUtils.hpp:390:5: error: "UseNoLock" is not defined, evaluates to 0 [-Werror=undef] 390 | #if UseNoLock | ^ /scratch/wip/digikam/work/digikam-8.6.0/core/libs/dngwriter/extra/xmp_sdk/source/XMP_LibUtils.hpp:403:7: error: "UseGlobalLibraryLock" is not defined, evaluates to 0 [-Werror=undef] 403 | #elif UseGlobalLibraryLock | ^~~~ /scratch/wip/digikam/work/digikam-8.6.0/core/libs/dngwriter/extra/xmp_sdk/source/XMP_LibUtils.hpp:418:7: error: "UseBoostLock" is not defined, evaluates to 0 [-Werror=undef] 418 | #elif UseBoostLock |
