[digikam] [Bug 379553] Feature req: default zoom level
https://bugs.kde.org/show_bug.cgi?id=379553 Qian changed: What|Removed |Added CC||oldk1...@gmail.com --- Comment #1 from Qian --- Link https://bugs.kde.org/show_bug.cgi?id=434049 here before I forgot. -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 434049] New: faulty logic in "updateZoomAndSize", zoom level changed after preview image changed
https://bugs.kde.org/show_bug.cgi?id=434049
Bug ID: 434049
Summary: faulty logic in "updateZoomAndSize", zoom level
changed after preview image changed
Product: digikam
Version: 7.2.0
Platform: Other
OS: Linux
Status: REPORTED
Severity: normal
Priority: NOR
Component: Preview-Image
Assignee: digikam-bugs-n...@kde.org
Reporter: oldk1...@gmail.com
Target Milestone: ---
SUMMARY
I think the logic in "updateZoomAndSize" is faulty and suggest following
change.
The check "(zoomFactor() <= fitZoom)" is unnecessary, it messes up zoom level
when a small image is encountered.
With this patch, the zoom level is fixed when "isFitToWindow" flag is not set.
This patch should also fulfill the need of
https://bugs.kde.org/show_bug.cgi?id=379553
--- a/core/libs/widgets/graphicsview/previewlayout.cpp
+++ b/core/libs/widgets/graphicsview/previewlayout.cpp
@@ -326,7 +326,7 @@ void SinglePhotoPreviewLayout::updateZoomAndSize()
// Is currently the zoom factor set to fit to window? Then set it again to
fit the new size.
-if (!d->zoomSettings()->imageSize().isNull() && ((zoomFactor() <= fitZoom)
|| d->isFitToWindow))
+if (!d->zoomSettings()->imageSize().isNull() && d->isFitToWindow)
{
fitToWindow();
}
STEPS TO REPRODUCE
1. In preview mode, select a big picture, and "Zoom to 100%".
2. Now select a small picture.
3. Select back the big picture.
OBSERVED RESULT
1. Can see part of the big picture, which is expected.
2. Can see the small picture with original size.
3. The big picture is now "fit to window".
EXPECTED RESULT
1. Same, see the big picture with zoom level 100%.
2. Same, see the small picture with zoom level 100%.
3. We should still see the big picture with zoom level 100%.
SOFTWARE/OS VERSIONS
digikam 7.2.0-rc on Linux/Plasma
ADDITIONAL INFORMATION
--
You are receiving this mail because:
You are watching all bug changes.
[digikam] [Bug 275078] Fit to window size not working if image is smaller then window size
https://bugs.kde.org/show_bug.cgi?id=275078 Qian changed: What|Removed |Added CC||oldk1...@gmail.com --- Comment #13 from Qian --- After my patch in https://bugs.kde.org/show_bug.cgi?id=434049 is applied, together with this following patch, we can have "fit to window" to always fit to window, instead of current behavior. Developers, this is 2021 now, where 4K screen is more and more popular. So viewing a 1 million pixel picture on a 8 million pixel screen is not that uncommon. Also, zoom such pictures on this hiDPI screen is not blurry at all. The old behavior can be achieved via a manually set fixed 100% zoom level. --- a/core/libs/widgets/graphicsview/previewlayout.cpp +++ b/core/libs/widgets/graphicsview/previewlayout.cpp @@ -259,7 +259,7 @@ void SinglePhotoPreviewLayout::fitToWindow() d->isFitToWindow = true; -d->zoomSettings()->fitToSize(d->frameSize(), ImageZoomSettings::OnlyScaleDown); +d->zoomSettings()->fitToSize(d->frameSize(), ImageZoomSettings::AlwaysFit); d->item->sizeHasChanged(); updateLayout(); d->item->update(); -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 434049] faulty logic in "updateZoomAndSize", zoom level changed after preview image changed [patch]
https://bugs.kde.org/show_bug.cgi?id=434049 --- Comment #2 from Qian --- https://bugs.kde.org/show_bug.cgi?id=379553 can be also closed then. -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 275078] Fit to window size not working if image is smaller then window size [patch]
https://bugs.kde.org/show_bug.cgi?id=275078 --- Comment #15 from Qian --- Yes, a configurable option is the right way to do things. Anyway, I can apply this patch locally on my system, or use fullscreen instead as a workaround. -- You are receiving this mail because: You are watching all bug changes.
[kdeconnect] [Bug 461046] Totally can't use in iOS 16.0.3
https://bugs.kde.org/show_bug.cgi?id=461046 --- Comment #22 from Ryan Qian --- (In reply to Apollo Zhu from comment #20) > 1. In terms of receiving files, > https://www.reddit.com/r/kde/comments/x0wipc/on_kde_connect_ios_where_do_files_go_when/imb4y4q/ > suggest that you might need to unhide the “on my phone” option to see the KDE > Connect folder. > I tested with the Qt client and couldn’t find any problem, so I guess the > above might be why. FYI, I tried it, but I didn't find the KDE Connect folder or other related buttons under `Files --> On My iPhone`. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 443723] "Display geometry when moving or resizing" feature is missing
https://bugs.kde.org/show_bug.cgi?id=443723 Richard Qian changed: What|Removed |Added Version|5.23.0 |5.24.0 CC||richwiki...@gmail.com --- Comment #15 from Richard Qian --- Since it seems nobody stepped up to make a replacement, I decided that I do most of the work. This is a reimplementation based off the desktopchangeosd script that functions mostly like the old version. I thank Vald for helping me get started with the code. Original location: https://gitlab.com/Worldblender/kwin-scripts My KWin fork containing this script: https://invent.kde.org/rqian/kwin I'm considering to upload this script to the KDE store so others that are stuck with Plasma versions that previously removed this feature can download it without waiting for a new Plasma version. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 443723] "Display geometry when moving or resizing" feature is missing
https://bugs.kde.org/show_bug.cgi?id=443723 --- Comment #16 from Richard Qian --- Okay, I now have a draft merge request opened up: https://invent.kde.org/plasma/kwin/-/merge_requests/2553 I marked it as a draft, because there's a few things that need to be worked on before it's ready, including some translation work that I can't do myself. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 443723] "Display geometry when moving or resizing" feature is missing
https://bugs.kde.org/show_bug.cgi?id=443723 --- Comment #18 from Richard Qian --- As my implementation has not yet been merged upstream, I uploaded it to the KDE store so others can get it more easily until then: https://www.pling.com/p/1833846/ -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 425371] New: Dolphin sometimes crashes during random browsing, especially after files are changed by another program
https://bugs.kde.org/show_bug.cgi?id=425371 Bug ID: 425371 Summary: Dolphin sometimes crashes during random browsing, especially after files are changed by another program Product: dolphin Version: 19.12.3 Platform: Ubuntu Packages OS: Linux Status: REPORTED Severity: major Priority: NOR Component: general Assignee: dolphin-bugs-n...@kde.org Reporter: richwiki...@gmail.com CC: kfm-de...@kde.org Target Milestone: --- Created attachment 130882 --> https://bugs.kde.org/attachment.cgi?id=130882&action=edit GDB backtraces and my attempts at continuing the program SUMMARY Dolphin has a tendency to freeze and not crash, which normally leaves me unable to get enough information on why this keeps happening. The freeze can happen almost always by random file browsing, but it becomes more likely when another program changes files outside of the file manager. STEPS TO REPRODUCE 1. Launch Dolphin as normal 2. Use like normal 3. The freeze will happen without warning OBSERVED RESULT The Dolphin window freezes, no longer repainting the window, or responding to user input. It happens just before the file or folder size of an item is finished being calculated. Often, any other programs using the same file view or I/O components as those of Dolphin will also not open, including, but not limited to, Konqueror (after trying to open the home directory), Gwenview and System Settings. Only logging out, rebooting, or using alternate programs will temporarily solve this problem. EXPECTED RESULT Nothing special is supposed to happen. There should not be any freezes or crashes normally happening in this situation. SOFTWARE/OS VERSIONS Linux/KDE Plasma: (K)Ubuntu 20.04 KDE Plasma Version: 5.18.5 KDE Frameworks Version: 5.68.0 Qt Version: 5.12.8 ADDITIONAL INFORMATION The freezes have also happened in Ubuntu 18.04, and I have tried out KDE Neon in hopes of getting around this problem. However, some programs I use depend on the ABI found in the Qt5 shipped in the Ubuntu repositories, and not the one found in the KDE Neon repositories. The only way I can keep such programs is by recompiling them against the new Qt5 versions, which gets annoying to do upon every Qt5 update (I know I'm doing something totally unsupported, but it at least gets me around frustrating freezes like this). Kernel log produced just after the freeze: [ 58.037143] show_signal_msg: 47 callbacks suppressed [ 58.037145] gam_server[6617]: segfault at 13 ip 77eb9463 sp 7fffc280 error 4 in libglib-2.0.so.0.6400.3[77e65000+84000] [ 58.037152] Code: 0f 1f 80 00 00 00 00 48 c1 e8 04 4c 8b 3b 8d 48 ff 48 89 c5 49 89 ce 49 c1 e6 04 4d 01 f7 4d 8b 27 4d 85 e4 0f 84 cd 00 00 00 <49> 8b 44 24 08 48 85 c0 74 43 48 8b 10 49 89 54 24 08 49 89 c4 49 [ 131.820681] gam_server[7697]: segfault at 13 ip 77eb9463 sp 7fffc280 error 4 in libglib-2.0.so.0.6400.3[77e65000+84000] [ 131.820689] Code: 0f 1f 80 00 00 00 00 48 c1 e8 04 4c 8b 3b 8d 48 ff 48 89 c5 49 89 ce 49 c1 e6 04 4d 01 f7 4d 8b 27 4d 85 e4 0f 84 cd 00 00 00 <49> 8b 44 24 08 48 85 c0 74 43 48 8b 10 49 89 54 24 08 49 89 c4 49 [ 483.888107] gam_server[10351]: segfault at 13 ip 77eb9463 sp 7fffc280 error 4 in libglib-2.0.so.0.6400.3[77e65000+84000] [ 483.888122] Code: 0f 1f 80 00 00 00 00 48 c1 e8 04 4c 8b 3b 8d 48 ff 48 89 c5 49 89 ce 49 c1 e6 04 4d 01 f7 4d 8b 27 4d 85 e4 0f 84 cd 00 00 00 <49> 8b 44 24 08 48 85 c0 74 43 48 8b 10 49 89 54 24 08 49 89 c4 49 The partial kernel log implies that Gamin and GLib may also be at fault, but I don't know exactly where. I also have a longer outout from GDB for more information. -- You are receiving this mail because: You are watching all bug changes.
