[plasma-browser-integration] [Bug 398073] Browser interaction working improperly with Google Play Music
https://bugs.kde.org/show_bug.cgi?id=398073 James Lee changed: What|Removed |Added CC||ja...@james.tl -- You are receiving this mail because: You are watching all bug changes.
[plasma-browser-integration] [Bug 398073] Browser interaction working improperly with Google Play Music
https://bugs.kde.org/show_bug.cgi?id=398073 --- Comment #2 from James Lee --- For what it's worth, this extension https://github.com/beingmohit/browser-playerctl works perfectly with Google Play Music, but it handles GPM specially which may not extend to the generic nature of plasma-browser-integration. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 363147] Breeze cursors should have more sizes (patch included)
https://bugs.kde.org/show_bug.cgi?id=363147 --- Comment #3 from James Lee --- 36 px isn't good enough and here's why: You have a whole class of laptops with 14" 2560x1440 (WQHD) displays, such as the Lenovo ThinkPad T4*0/X* line of laptops that are very popular in the Linux community. These screens require a scaling factor of 1.67 (that's one and two thirds), which would make a (24 * 1.67 =) 40 px cursor look right. You may ask, "what difference does 4 pixels make?" Well that's 10%, and it's instantly noticeable, especially when highlighting lines relative to normal text height. See the attached screenshots. You might say, "well having 24, 32, 36, 40, and 48 is too many confusing choices." But users are used to making choices like that for fonts, where sizes like 24, 32, 36, 40, and 48 are common. You might say, "well having that many sizes increases the size of the resulting binaries installed on the system." To that I say adding sizes 32 and 40 in addition to 36 increases the total size of both Breeze and Breeze_Snow combined by just 625 KB. You might say, "well, managing all of those sizes is kind of ugly with our build scripts." But if you had actually looked at my patch, you would have seen that I completely refactored the build script to support arbitrarily many sizes, and also support building arbitrarily many cursors (so that you don't have to duplicate the build script across both the Breeze and Breeze_Snow cursors). Please reconsider my patch. Also, I take sincere objection to your suggestion that I didn't submit my contribution properly. I have contributed to a lot of open-source projects before. This is a bug so I submitted a bug report and made it perfectly clear in the bug report title that I included a patch. The patch had a lot of binary data, so rather than upload it to Bugzilla, I chose to link to it on GitHub, where there is an official mirror of the Breeze repository. If you don't want people using GitHub, either don't mirror the repo on GitHub, or include a CONTRIBUTING file in the repository so community members know how to submit contributions. Furthermore, you are the KDE dev, not me. You should have seen this; I mean, it's been eight months! It is your job to look at and respond to Bugzilla bugs, and shepherd community contributions through your SDLC, of which I am unfamiliar, especially because there is no CONTRIBUTING file in the repository! Your apparent dismissal of my well-crafted (and personally time-consuming) contribution is offensive and makes me less likely to contribute to KDE projects. Please reconsider my patch. Again, it's at https://github.com/iamjamestl/breeze/compare/master...iamjamestl:cursor-build-multiple-sizes.patch in standard Git unified diff format, regardless of where it's hosted. If you need me to rebase it again, I can. Thanks, James -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 363147] Breeze cursors should have more sizes (patch included)
https://bugs.kde.org/show_bug.cgi?id=363147 --- Comment #5 from James Lee --- Created attachment 103739 --> https://bugs.kde.org/attachment.cgi?id=103739&action=edit Breeze @ 40 px on properly-scaled WQHD display -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 363147] Breeze cursors should have more sizes (patch included)
https://bugs.kde.org/show_bug.cgi?id=363147 --- Comment #4 from James Lee --- Created attachment 103738 --> https://bugs.kde.org/attachment.cgi?id=103738&action=edit Breeze @ 36 px on properly-scaled WQHD display -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 363147] Breeze cursors should have more sizes (patch included)
https://bugs.kde.org/show_bug.cgi?id=363147 --- Comment #6 from James Lee --- I have rebased the patch on the current master HEAD and added your 36 px size. Again, it's at: https://github.com/iamjamestl/breeze/compare/master...iamjamestl:cursor-build-multiple-sizes.patch You have no excuse not to consider it. Please do the honorable thing. This patch was first, and it's better. Thanks, James -- You are receiving this mail because: You are watching all bug changes.
[frameworks-knotifications] [Bug 382444] Applications hang when trying to call org.freedesktop.Notifications due to plasma_waitforname, when plasma is not running
https://bugs.kde.org/show_bug.cgi?id=382444 James Lee changed: What|Removed |Added CC||ja...@james.tl --- Comment #5 from James Lee --- Created attachment 107141 --> https://bugs.kde.org/attachment.cgi?id=107141&action=edit Backtrace from kwrite with debug symbols during hang I am seeing this same issue running KDE apps like kwrite outside of Plasma when no notification service is running. This is with kde-frameworks/knotify-5.36.0 and kwrite-17.04.3. If I start a notification service, like dunst, the hang goes away. I've attached a backtrace of my kwrite with debug symbols during the hang. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 366451] "display scaling" on hidpi screen results in poor font quality
https://bugs.kde.org/show_bug.cgi?id=366451 James Lee changed: What|Removed |Added CC||ja...@james.tl -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 363147] Breeze cursors should have more sizes (patch included)
https://bugs.kde.org/show_bug.cgi?id=363147 James Lee changed: What|Removed |Added Version|5.6.4 |5.8.4 --- Comment #1 from James Lee --- I've rebased my branch at https://github.com/iamjamestl/breeze/tree/cursor-build-multiple-sizes so this is cleanly mergeable into current HEAD. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 363147] Breeze cursors should have more sizes (patch included)
https://bugs.kde.org/show_bug.cgi?id=363147 --- Comment #8 from James Lee --- Dominik, I tried, but due to the binary data in this patch, it was too large for Phabricator, by an order of magnitude. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 363147] Breeze cursors should have more sizes (patch included)
https://bugs.kde.org/show_bug.cgi?id=363147 --- Comment #10 from James Lee --- So that's how it's going to be. Guess I won't be contributing to KDE anymore. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 363147] Breeze cursors should have more sizes (patch included)
https://bugs.kde.org/show_bug.cgi?id=363147 --- Comment #12 from James Lee --- Created attachment 104804 --> https://bugs.kde.org/attachment.cgi?id=104804&action=edit Phabricator Error on Patch Upload I literally can't upload this patch to Phabricator. Because it contains new sizes of the cursors, it exceeds the 2 MB limit. The patch is 13 MB. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 363147] Breeze cursors should have more sizes (patch included)
https://bugs.kde.org/show_bug.cgi?id=363147 --- Comment #14 from James Lee --- For what it's worth, this page https://community.kde.org/Infrastructure/Github_Mirror, and probably Phabricator, didn't exist when I submitted this bug report and patch. I tried uploading the patch with Arcanist and it was still too large. I took out the build data as suggested at https://secure.phabricator.com/book/phabricator/article/differential_large_changes/ and then it went through. The diff is open at https://phabricator.kde.org/D5250; and I think it is still worth a review since it improves the cursor build script and supports building arbitrarily many cursor sizes. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 382340] Notifications are often as 1px vertical line
https://bugs.kde.org/show_bug.cgi?id=382340 James Lee changed: What|Removed |Added CC||ja...@james.tl --- Comment #1 from James Lee --- Created attachment 106628 --> https://bugs.kde.org/attachment.cgi?id=106628&action=edit Screenshot of notifications under plasma-workspace-5.10.3 I am seeing the same behavior since upgrading from 5.10.2 to 5.10.3 on my Gentoo system. All notifications appear as one pixel vertical lines. -- You are receiving this mail because: You are watching all bug changes.
[Breeze] [Bug 363147] New: Breeze cursors should have more sizes (patch included)
https://bugs.kde.org/show_bug.cgi?id=363147 Bug ID: 363147 Summary: Breeze cursors should have more sizes (patch included) Product: Breeze Version: 5.6.4 Platform: Compiled Sources OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: plasma-de...@kde.org Reporter: ja...@james.tl Breeze currently ships with 24 and 48 px cursors. My 14" WQHD screen, which I understand to be a fairly common size and resolution, needs something in between to look right. For this screen, 40 px is ideal. GNOME's theme Adwaita ships with 24, 32, 48, 64, and 96 px options. It seems reasonable for Breeze to have at least the same options. I have patched the Breeze cursor build script to support building many sizes without hard-coding the xcursorgen configs. You can find the changes on my 'cursor-build-multiple-sizes' branch at: https://github.com/iamjamestl/breeze/tree/cursor-build-multiple-sizes https://github.com/KDE/breeze/compare/master...iamjamestl:cursor-build-multiple-sizes See the commit message for implementation comments. Reproducible: Always -- You are receiving this mail because: You are watching all bug changes.
[KScreen] [Bug 346961] Multi Monitor configuration lost on reboot, must reconfigure after startup
https://bugs.kde.org/show_bug.cgi?id=346961 James Lee changed: What|Removed |Added CC||ja...@james.tl -- You are receiving this mail because: You are watching all bug changes.
