Can't update net.sourceforge.htmlunit to latest due to JDK7 enforcer

2020-07-26 Thread tzach....@gmail.com
Hi All,

According to GitHub Advisory Database, I should update 
*net.sourceforge.htmlunit* to at least* 2.37.0* in order to fix 
*CVE-2020-5529*.

My problem is once I do that and run mvn compile, maven enforcer blocks due 
to:

*[INFO] Restricted to JDK 1.7 yet 
net.sourceforge.htmlunit:neko-htmlunit:jar:2.42.0:compile contains 
net/sourceforge/htmlunit/cyberneko/filters/DefaultFilter.class targeted to 
JDK 1.8*
Should I fix the security issue? If so, how should I proceed?

Thanks,
Tzach

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/f5938e1c-77c3-4852-a7fd-5712771a016an%40googlegroups.com.


Is there an example on how to create configuration for build trigger?

2020-08-04 Thread tzach....@gmail.com
Hi All,

I wish to extend the bitbucket plugin to have some configuration. I've 
tried to look for an example but I did not find any.

Here is an example of what I'm referring to as configuration. (Build 
Trigger plugin that has configuration)

[image: build_trigger_configuration.png]

Thanks in advance,
Tzach

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/06a5521b-790b-4cf9-8bf0-070b4a7b7ae9n%40googlegroups.com.


Re: Plugin Maintainer alumni metadata

2021-10-17 Thread tzach....@gmail.com
I'm with Oleg on this one. 
Just for the sake that someone contributed from his/her time and knowledge 
and it would be nice to still give credit.

On Sunday, 17 October 2021 at 13:06:47 UTC+3 timja...@gmail.com wrote:

> I don't see the need for this, if someone wants to come back to active 
> they can just ask, the git history is there in RPU, commit history etc
>
> On Sun, 17 Oct 2021 at 09:52, Oleg Nenashev  wrote:
>
>> GitHub contributor metadata does not list former maintainers 
>> specifically, unless you want to query audit log
>> Listing all contributors is possible through that and it would be cool 
>> indeed, but it is not a specific use-case for maintainer alumni
>>
>> On Sunday, October 17, 2021 at 10:46:48 AM UTC+2 Daniel Beck wrote:
>>
>>>
>>>
>>> > On 17. Oct 2021, at 10:15, Oleg Nenashev  wrote: 
>>> > 
>>> > Just to follow-up on 
>>> https://groups.google.com/g/jenkinsci-dev/c/e3T6QG24YVg , I propose 
>>> adding a new "Alumni" category to 
>>> https://github.com/jenkins-infra/repository-permissions-updater to 
>>> reference ex maintainers of the plugins. 
>>> > 
>>> > Such a category could serve two purposes: 
>>> > • Giving credit on plugins.jenkins.io while not keeping permissions 
>>> for older maintainers 
>>> > • Simplifying the return process if an old maintainer re-applies for 
>>> plugin ownership 
>>> > What do you think? 
>>> > 
>>>
>>> Seems like unnecessary clutter. 
>>>
>>> The former can be accomplished much more nicely by integrating with 
>>> GitHub's contributor information. 
>>>
>>> The latter is just noise, if you've been a maintainer before and 
>>> actually did something, it'll be easy enough to show that. 
>>>
>>> This only makes sense if the idea is that there are two classes of 
>>> former maintainers, those that are eligible to be credited and return, and 
>>> those that are not? 
>>>
>>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-de...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/775d379a-bc88-4cbc-997c-e5bfd5ab526fn%40googlegroups.com
>>  
>> 
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/48cc7703-7d52-4654-aaf2-93b276bc4a56n%40googlegroups.com.


Re: Requesting commit access for bitbucket-plugin

2020-07-20 Thread tzach....@gmail.com
Hi All,

Could someone please check my request?

Thanks,
Tzach

On Saturday, 4 July 2020 at 23:12:10 UTC+3 tzach@gmail.com wrote:

> Hello,
>
> I would like to help maintain the plugin BitBucket.
>
> My request details are as follows:
>
>- Plugin I want to maintain: https://plugins.jenkins.io/bitbucket/
>- Pull request: https://github.com/jenkinsci/bitbucket-plugin/pull/74
>- My GitHub profile is: https://github.com/tzachs
>- Jenkins account: tzach_solomon
>
>
> Thanks in advance,
> Tzach Solomon
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/23127045-a4b5-4b81-a7a7-ac1243916274n%40googlegroups.com.


DescriptorImpl which is not public static inside the parent class

2023-11-07 Thread tzach....@gmail.com
Hi,

I could not find the answer so sorry for asking something that might have 
been answered already but, can I create a class which will function 
as DescriptorImpl but not reside inside the parent class as public static 
class?

Thanks,
Tzach

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/d2253710-470b-4fcc-805d-4dbf0c2774b0n%40googlegroups.com.


How to integrate git plugin in my plugin?

2023-11-15 Thread tzach....@gmail.com
Hi,

I have a private that needs configuration.
That configuration is stored in a remote git repository.
I would like to harness git plugin and use it in my plugin.
Is there an example of how to do it?

Thanks,
Tzach

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/33209811-581c-434c-836f-6461e509d636n%40googlegroups.com.


Re: How to integrate git plugin in my plugin?

2023-11-15 Thread tzach....@gmail.com
My scenario is that i have a JSON file located in a remote repo.
In that file there is a configuration I need for the plugin.

I want to be able to pull that file and read it in my plugin.
The reason for it being in the remote repo as it serves also other 
applications and not just my plugin.

Is it doable?

Thanks,
Tzach

On Wednesday, 15 November 2023 at 18:01:39 UTC+2 jef...@gmail.com wrote:

> Have you looked at the source for the Github Branch Source plugin? I 
> imagine it has examples of how to do many things.
>
> From your description though, it sounds like you might be able to store 
> your configuration in Jenkins itself? Maybe as a secret? That said, I have 
> to admit I don't 100% understand your scenario.
>
> Best
> Jeff
>
> On Wed, Nov 15, 2023 at 7:14 AM tzach@gmail.com  
> wrote:
>
>> Hi,
>>
>> I have a private that needs configuration.
>> That configuration is stored in a remote git repository.
>> I would like to harness git plugin and use it in my plugin.
>> Is there an example of how to do it?
>>
>> Thanks,
>> Tzach
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-de...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/33209811-581c-434c-836f-6461e509d636n%40googlegroups.com
>>  
>> <https://groups.google.com/d/msgid/jenkinsci-dev/33209811-581c-434c-836f-6461e509d636n%40googlegroups.com?utm_medium=email&utm_source=footer>
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/6d1595d3-8c54-45b5-a3c2-910b5edd61aan%40googlegroups.com.


How to implement writing to console log in pipeline?

2023-11-19 Thread tzach....@gmail.com
Hi,

I'm developing a new plugin and I was able to write to log in FreeStyleJob  
but it does not work in pipeline. What I have done is:

1. Extend ParameterValue class
2. Override createBuildWrapper and return new SimpleBuildWrapper. In it, 
override setup() method and used the listener to reach the logger. But, 
this does not work in pipleine (i'm guessing because it has AbstractBuild 
as input)

This is my code:
 










*@Overridepublic BuildWrapper createBuildWrapper(AbstractBuild 
build) {return new SimpleBuildWrapper() {@Override  
  public boolean requiresWorkspace() {return false;
}@Overridepublic void setUp(Context 
context, Run build, TaskListener listener, EnvVars env) {*
*listener.getLogger().println("*** My plugin works ***");*

My question is, what do I need to do in order to be able to println also to 
console plugin?

Thanks,
Tzach




-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/f0bd9a71-43e4-4f05-9f41-c05b202aaa8bn%40googlegroups.com.


Re: bitbucket plugin - JENKINS-65697 - How to inject environment variable into WorkflowMultiBranchProject (buildEnvironment isn't called...)

2024-08-10 Thread tzach....@gmail.com
I think I've got it.
I should have used EnvironmentContributor.java as used in 
https://github.com/jenkinsci/branch-api-plugin/blob/master/src/main/java/jenkins/branch/BranchNameContributor.java#L56

An I right?

if so, what is the difference between 'EnvironmentContributor.java' 
and 'EnvironmentContributingAction.java'?
When should I use  EnvironmentContributor and when should I use 
EnvironmentContributingAction?

Thanks in advance,
Tzach

On Saturday 10 August 2024 at 15:32:11 UTC+3 tzach@gmail.com wrote:

> Reviving this old thread as I got a bit of time to try to fix this bug... 
> (Can you please help approve/disapprove my comment below?)
>
> I've tried to figure out why `buildEnvironment` is not called and it's 
> because when scheduling a `WorkflowMultiBranchProject` (using schedule2) 
> with my Actions, those actions will be ignored since the branch will always 
> be triggered with 
> *source.fetch(new SCMHeadObserverImpl(source, observer, listener, 
> _factory, new IndexingCauseFactory(), null), listener);*
>
> And that is why the console always has 'Branch indexing' and not my cause.
>
> Is that correct?
>
> Thanks,
> Tzach
>
> On Wed, Jul 26, 2023 at 12:27 AM 'Jesse Glick' via Jenkins Developers <
> jenkin...@googlegroups.com> wrote:
>
>> On Tue, Jul 25, 2023 at 2:24 AM tzach solomon  
>> wrote:
>>
>>> get build from the Queue Item
>>>
>>
>> I am not sure what that means. You are going to need to be more specific, 
>> preferably with code references, ideally a JenkinsRule-based test failing 
>> in the “right” way.
>>
>> -- 
>>
> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-de...@googlegroups.com.
>>
> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1%2B6wVKuRED8CmKXwp6aoj-UZnwiyohoSUce%3Dcr0ymJMg%40mail.gmail.com
>>  
>> <https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1%2B6wVKuRED8CmKXwp6aoj-UZnwiyohoSUce%3Dcr0ymJMg%40mail.gmail.com?utm_medium=email&utm_source=footer>
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/3018edfd-d498-4b1e-9961-c638c48f6762n%40googlegroups.com.