date:20250317

[jira] [Commented] (SOLR-17704) Change ZkDistributedLock to use Curator

2025-03-17 Thread Houston Putman (Jira)



[ 
https://issues.apache.org/jira/browse/SOLR-17704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936230#comment-17936230
 ] 

Houston Putman commented on SOLR-17704:
---

Yeah, definitely agree with the ticket, but not sure it should be a sub-task.

I'm also really thinking about how to best do the shardTerms as a Curator 
recipe, but that might be a bit more bespoke than this.

> Change ZkDistributedLock to use Curator
> ---
>
> Key: SOLR-17704
> URL: https://issues.apache.org/jira/browse/SOLR-17704
> Project: Solr
>  Issue Type: Sub-task
>Reporter: David Smiley
>Priority: Major
>
> Now that Solr is using Curator for connection management, we can finally use 
> it to replace Solr code.  ZkDistributedLock looks like very low-hanging 
> fruit, used by the non-Overseer distributed mode.  That mode is still 
> experimental so we can change it in backwards-incompatible ways in Solr 10.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Re: [PR] SOLR-17043: Remove SolrClient path pattern matching [solr]

2025-03-17 Thread via GitHub



dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1999350676


##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -185,8 +193,21 @@ public void setQueryParams(Set queryParams) {
 this.queryParams = queryParams;
   }
 
-  /** This method defines the type of this Solr request. */
-  public abstract String getRequestType();
+  /**
+   * The type of this Solr request.
+   *
+   * Pattern matches {@link SolrRequest#getPath} to identify ADMIN requests 
and other special
+   * cases. Overriding this method may affect request routing within various 
clients (i.e. {@link
+   * CloudSolrClient}).
+   */
+  public SolrRequestType getRequestType() {
+String path = getPath();
+if (path != null && CommonParams.ADMIN_PATHS.contains(path)) {

Review Comment:
   I see "qt" makes this harder.  I hate it; I _almost_ removed it completely 
as one of my first big actions as a committer, forever ago, but I went half-way 
by removing its processing server-side.  It's _still_ present in SolrJ as you 
see here; _sigh_.  I'd love to see this gone.  I know it's a convenience for 
tests that want a SolrParams to be sort of all-encompassing about the request.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Re: [PR] SOLR-17043: Remove SolrClient path pattern matching [solr]

2025-03-17 Thread via GitHub



dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1999351627


##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -185,8 +193,21 @@ public void setQueryParams(Set queryParams) {
 this.queryParams = queryParams;
   }
 
-  /** This method defines the type of this Solr request. */
-  public abstract String getRequestType();
+  /**
+   * The type of this Solr request.
+   *
+   * Pattern matches {@link SolrRequest#getPath} to identify ADMIN requests 
and other special
+   * cases. Overriding this method may affect request routing within various 
clients (i.e. {@link
+   * CloudSolrClient}).
+   */
+  public SolrRequestType getRequestType() {
+String path = getPath();
+if (path != null && CommonParams.ADMIN_PATHS.contains(path)) {

Review Comment:
   Are there any "real" risks of mis-classification of the request type in 
SolrJ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

[PR] SOLR-17584: Remove code and documentation for "trusted" configsets [solr]

2025-03-17 Thread via GitHub

abumarjikar opened a new pull request, #3272:
URL: https://github.com/apache/solr/pull/3272

https://issues.apache.org/jira/browse/SOLR-X

# Description

Please provide a short description of the changes you're making with this
pull request.

# Solution

Please provide a short description of the approach taken to implement your
solution.

# Tests

Please describe the tests you've developed or run to confirm this patch
implements the feature or solves the problem.

# Checklist

Please review the following and check all that apply:

- [ ] I have reviewed the guidelines for [How to
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my
code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request
title.
- [ ] I have given Solr maintainers
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
to contribute to my PR branch. (optional but recommended, not available for
branches on forks living under an organisation)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

58 matches

Mail list logo