Re: [PR] SOLR-17310: Configurable LeafSorter to customize segment search order [solr]

[via GitHub]

epugh commented on PR #2477:
URL: https://github.com/apache/solr/pull/2477#issuecomment-2629393983

   Seems like this ticket and https://github.com/apache/solr/pull/313 both have 
stalled out...   Thoughts on a thread on the dev mailing list to see if we 
think moving forward with this or the #313 approach gets us moving?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Re: [PR] SolrRequest.getParams never null; and clarify mutability [solr]

[via GitHub]

dsmiley commented on PR #3140:
URL: https://github.com/apache/solr/pull/3140#issuecomment-2629459790

   Not thinking a JIRA/CHANGES.txt is worth it but will do if asked.
   Proposed commit message:
   > Clarify getParams not null in SolrRequest, SolrQueryRequest, QParser
   > Clarify mutability of params for SolrRequest (SolrJ).  UpdateRequest 
changed; doesn't lazy-create params anymore.
   > New SolrParams.of() and of(key, value) for an empty or single-pair 
instance.
   
   Planning to merge Tuesday if no further comments.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Re: [PR] SolrRequest.getParams never null; and clarify mutability [solr]

[via GitHub]

dsmiley commented on code in PR #3140:
URL: https://github.com/apache/solr/pull/3140#discussion_r1938528244


##
solr/core/src/java/org/apache/solr/handler/api/V2ApiUtils.java:
##
@@ -91,9 +91,6 @@ public static void squashIntoNamedListWithoutHeader(
   }
 
   public static String getMediaTypeFromWtParam(SolrParams params, String 
defaultMediaType) {
-if (params == null) {

Review Comment:
   I brought this back and audited with data flow analysis that it'll never be 
null.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Re: [PR] SOLR-17310: Configurable LeafSorter to customize segment search order [solr]

[via GitHub]

weiwang19 commented on PR #2477:
URL: https://github.com/apache/solr/pull/2477#issuecomment-2629982518

   Thanks for bringing this up.  Would definitely like to have a discussion
   about moving this forward.
   
   Thanks,
   Wei
   
   On Sun, Feb 2, 2025 at 5:20 AM Eric Pugh ***@***.***> wrote:
   
   > Seems like this ticket and #313 
   > both have stalled out... Thoughts on a thread on the dev mailing list to
   > see if we think moving forward with this or the #313
   >  approach gets us moving?
   >
   > —
   > Reply to this email directly, view it on GitHub
   > , or
   > unsubscribe
   > 

   > .
   > You are receiving this because you authored the thread.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Re: [PR] SolrRequest.getParams never null; and clarify mutability [solr]

[via GitHub]

dsmiley commented on code in PR #3140:
URL: https://github.com/apache/solr/pull/3140#discussion_r1938508213


##
solr/core/src/java/org/apache/solr/handler/api/V2ApiUtils.java:
##
@@ -91,9 +91,6 @@ public static void squashIntoNamedListWithoutHeader(
   }
 
   public static String getMediaTypeFromWtParam(SolrParams params, String 
defaultMediaType) {
-if (params == null) {

Review Comment:
   It turns out SolrQueryRequest.getParams will always be non-null (because 
`org.apache.solr.servlet.SolrRequestParsers#parseQueryString(java.lang.String)` 
is what initializes it, always non-null) but this fact is not documented.  I'll 
increase the scope here a little to cover that since there's little to it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org