Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]
HoustonPutman commented on code in PR #2960:
URL: https://github.com/apache/solr/pull/2960#discussion_r1929053426
##
solr/core/src/java/org/apache/solr/search/EarlyTerminatingCollector.java:
##
@@ -29,11 +30,15 @@
*/
public class EarlyTerminatingCollector extends FilterCollector {
+ private final int chunkSize = 100; // Check across threads only at a chunk
size
+
private final int maxDocsToCollect;
private int numCollected = 0;
private int prevReaderCumulativeSize = 0;
private int currentReaderSize = 0;
+ private final AtomicInteger pendingDocsToCollect;
Review Comment:
Agreed, it looks like the chunking can go away if we switch to a LongAdder.
Much like the chunking implementation, we won't get absolute accuracy across
threads, but we will get higher throughput. (And we could sacrifice throughput
to increase accuracy if we wanted to, but I doubt we do)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Parse authors from git log [solr]
dsmiley commented on PR #2423: URL: https://github.com/apache/solr/pull/2423#issuecomment-2613064920 I suggest close without merging. As we embrace the logchange mechanism, we will then no longer have to do any parsing; it'll be a straight-forward reading of files with a strict format with common libs to do the parsing. No regular expressions to write or brittleness. This script has no role in that world, neither does the one I merged recently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] chore(deps): update dependency net.ltgt.errorprone to v4 [solr]
solrbot opened a new pull request, #3131: URL: https://github.com/apache/solr/pull/3131 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | net.ltgt.errorprone | plugin | major | `3.1.0` -> `4.1.0` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17630) Add CloudSolrClient instance for a Solr node
[
https://issues.apache.org/jira/browse/SOLR-17630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916849#comment-17916849
]
Jason Gerlowski commented on SOLR-17630:
(Arrived here by following a reference in
https://github.com/apache/solr/pull/3047/files#r1924452036.)
I'm a little confused about the status of SolrClientCache (and it's getter on
CoreContainer). Is the eventual goal for those things to go away entirely, or
for it to stick around but only be used in solrj-streaming?
What makes it a good fit for streaming-expressions but not for more general
usage?
> Add CloudSolrClient instance for a Solr node
>
>
> Key: SOLR-17630
> URL: https://issues.apache.org/jira/browse/SOLR-17630
> Project: Solr
> Issue Type: Improvement
> Components: SolrCloud
>Reporter: David Smiley
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There ought to be a general CloudSolrClient instance for the Solr node,
> without each potential user of such needing to create one. The closest
> substitute at the moment is
> {{cc.getSolrClientCache().getCloudSolrClient(cc.getZkController().getZkServerAddress())}}
> which is too verbose, not as discoverable, and it's debatable if
> SolrClientCache should be it's home.
> A scalability/simplicity advantage of a shared one instead of newly
> constructed one is that the existing ZkClientClusterStateProvider (same node
> ZkStateReader instance) can be used, thus improving scalability and
> simplifying interpretation of logs (as all logs from ZkStateReader on a node
> can be assumed to then be from the same instance). SolrClientCache creates
> new ones.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] remove deprecated (DocValues,Norms)FieldExistsQuery use [solr]
HoustonPutman commented on PR #2632: URL: https://github.com/apache/solr/pull/2632#issuecomment-2613152878 > As there is now FieldExistsQuery covering a range of cases (not just even docValues & norms), this probably obsoletes complexity inside FieldType.getExistenceQuery. Can we just call that and remove getSpecializedExistenceQuery as needless in lieu of subtypes overriding getExistenceQuery? > > CC @HoustonPutman as you worked on this method It looks like the range of cases are just docValues, norms and vectors. Not sure we can get rid of much of the complexity. `getSpecializedExistenceQuery` is still necessary for double/float fields without docValues or norms. and Spatial fields. I think this just moves the three query classes into one class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] remove deprecated (DocValues,Norms)FieldExistsQuery use [solr]
HoustonPutman commented on code in PR #2632:
URL: https://github.com/apache/solr/pull/2632#discussion_r1929118564
##
solr/core/src/java/org/apache/solr/search/facet/MissingAgg.java:
##
@@ -45,7 +45,7 @@ public SlotAcc createSlotAcc(FacetContext fcontext, long
numDocs, int numSlots)
if (sf.multiValued() || sf.getType().multiValuedFieldCache()) {
Query query = null;
if (sf.hasDocValues()) {
- query = new DocValuesFieldExistsQuery(sf.getName());
+ query = new FieldExistsQuery(sf.getName());
} else {
query = sf.getType().getRangeQuery(null, sf, null, null, false,
false);
}
Review Comment:
Did this whenever I could
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Workaround dist.apache.org download restrictions [solr-operator]
gerlowskija merged PR #752: URL: https://github.com/apache/solr-operator/pull/752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Avoid datetime deprecations in releaseWizard.py [solr-operator]
gerlowskija merged PR #751: URL: https://github.com/apache/solr-operator/pull/751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] chore(deps): update dependency com.nimbusds:nimbus-jose-jwt to v10 [solr]
solrbot opened a new pull request, #3128: URL: https://github.com/apache/solr/pull/3128 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.nimbusds:nimbus-jose-jwt](https://bitbucket.org/connect2id/nimbus-jose-jwt) | dependencies | major | `9.48` -> `10.0.1` | --- ### Release Notes connect2id/nimbus-jose-jwt (com.nimbusds:nimbus-jose-jwt) ### [`v10.0.1`](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/10.0.1%0D10.0) [Compare Source](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/10.0.1%0D10.0) ### [`v10.0`](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/10.0%0D9.48) [Compare Source](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/10.0%0D9.48) --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] chore(deps): update dependency com.nimbusds:nimbus-jose-jwt to v9.48 [solr]
janhoy merged PR #3092: URL: https://github.com/apache/solr/pull/3092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Resolved] (SOLR-17626) add RawTFSimilarityFactory class
[ https://issues.apache.org/jira/browse/SOLR-17626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke resolved SOLR-17626. Resolution: Fixed > add RawTFSimilarityFactory class > > > Key: SOLR-17626 > URL: https://issues.apache.org/jira/browse/SOLR-17626 > Project: Solr > Issue Type: Task >Reporter: Christine Poerschke >Assignee: Christine Poerschke >Priority: Minor > Labels: pull-request-available > Fix For: main (10.0), 9.9 > > Time Spent: 10m > Remaining Estimate: 0h > > Factory class for the RawTFSimilarity added in Lucene 9.12 version. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17626) add RawTFSimilarityFactory class
[ https://issues.apache.org/jira/browse/SOLR-17626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916677#comment-17916677 ] ASF subversion and git services commented on SOLR-17626: Commit 316cfc5c22973e3598c79fad540242bd426c0841 in solr's branch refs/heads/branch_9x from Christine Poerschke [ https://gitbox.apache.org/repos/asf?p=solr.git;h=316cfc5c229 ] SOLR-17626: add RawTFSimilarityFactory class (#2715) (cherry picked from commit b3b20d6564885e96f3881c6acea577be98be9a64) > add RawTFSimilarityFactory class > > > Key: SOLR-17626 > URL: https://issues.apache.org/jira/browse/SOLR-17626 > Project: Solr > Issue Type: Task >Reporter: Christine Poerschke >Assignee: Christine Poerschke >Priority: Minor > Labels: pull-request-available > Fix For: main (10.0), 9.9 > > Time Spent: 10m > Remaining Estimate: 0h > > Factory class for the RawTFSimilarity added in Lucene 9.12 version. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17623: Simple ordered map should implement map [solr]
renatoh commented on code in PR #3048:
URL: https://github.com/apache/solr/pull/3048#discussion_r1928511029
##
solr/solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java:
##
@@ -68,24 +74,153 @@ public SimpleOrderedMap(Map.Entry[]
nameValuePairs) {
public SimpleOrderedMap clone() {
ArrayList newList = new ArrayList<>(nvPairs.size());
newList.addAll(nvPairs);
-return new SimpleOrderedMap<>(newList);
+return new SimpleOrderedMap(newList);
+ }
+
+ @Override
+ public boolean isEmpty() {
+return nvPairs.isEmpty();
+ }
+
+ @Override
+ public boolean containsKey(final Object key) {
+return this.indexOf((String) key) >= 0;
}
/**
- * Returns a shared, empty, and immutable instance of SimpleOrderedMap.
+ * Returns {@code true} if this map maps one or more keys to the specified
value.
Review Comment:
the java-doc is automatically inherited? isn't that only the case if I use
the {@inheritDoc} tag in the java doc itself. And even then, it does not
inherit the param, return and throw part of the java-doc, unless I tag them one
by one. Nevertheless, I will move to {@inheritDoc} where possible, in order
not to repeat java doc.
With respect to "one or more", I did not come up with that phrasing, that is
on Map#contains, and although it sounds strange, it is technically correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17623: Simple ordered map should implement map [solr]
renatoh commented on code in PR #3048:
URL: https://github.com/apache/solr/pull/3048#discussion_r1928520200
##
solr/solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java:
##
@@ -68,24 +74,153 @@ public SimpleOrderedMap(Map.Entry[]
nameValuePairs) {
public SimpleOrderedMap clone() {
ArrayList newList = new ArrayList<>(nvPairs.size());
newList.addAll(nvPairs);
-return new SimpleOrderedMap<>(newList);
+return new SimpleOrderedMap(newList);
+ }
+
+ @Override
+ public boolean isEmpty() {
+return nvPairs.isEmpty();
+ }
+
+ @Override
+ public boolean containsKey(final Object key) {
+return this.indexOf((String) key) >= 0;
}
/**
- * Returns a shared, empty, and immutable instance of SimpleOrderedMap.
+ * Returns {@code true} if this map maps one or more keys to the specified
value.
*
- * @return Empty SimpleOrderedMap (immutable)
+ * @param value value whose presence in this map is to be tested
+ * @return {@code true} if this map maps one or more keys to the specified
value
*/
- public static SimpleOrderedMap of() {
-return EMPTY;
+ @Override
+ public boolean containsValue(final Object value) {
+int sz = size();
+for (int i = 0; i < sz; i++) {
+ T val = getVal(i);
+ if (Objects.equals(value, val)) {
+return true;
+ }
+}
+return false;
+ }
+
+ /**
+ * Has linear lookup time O(N)
+ *
+ * @see NamedList#get(String)
+ */
+ @Override
+ public T get(final Object key) {
+return super.get((String) key);
}
/**
- * Returns an immutable instance of SimpleOrderedMap with a single key-value
pair.
+ * Associates the specified value with the specified key in this map If the
map previously
+ * contained a mapping for the key, the old value is replaced by the
specified value.
*
- * @return SimpleOrderedMap containing one key-value pair
+ * @param key key with which the specified value is to be associated value –
value to be
+ * associated with the specified key
+ * @param value to be associated with the specified key
+ * @return the previous value associated with key, or null if there was no
mapping for key. (A
+ * null return can also indicate that the map previously associated null
with key)
+ */
+ @Override
+ public T put(String key, T value) {
+int idx = indexOf(key);
+if (idx == -1) {
+ add(key, value);
+ return null;
+} else {
+ T t = get(key);
+ setVal(idx, value);
+ return t;
+}
+ }
+
+ /**
+ * @see NamedList#remove(String)
+ */
+ @Override
+ public T remove(final Object key) {
+return super.remove((String) key);
+ }
+
+ /**
+ * Copies all of the mappings from the specified map to this map. These
mappings will replace any
+ * mappings that this map had for any of the keys currently in the specified
map.
+ *
+ * @param m mappings to be stored in this map
+ * @throws NullPointerException if the specified map is null
+ */
+ @Override
+ public void putAll(final Map m) {
+m.forEach(this::put);
+ }
+
+ /**
+ * return a {@link Set} of all keys in the map.
+ *
+ * @return {@link Set} of all keys in the map
+ */
+ @Override
+ public Set keySet() {
+return new InnerMap().keySet();
Review Comment:
I've tried using an AbstractList / AbstractSet for values() / keySet(), but
on the AbstractSet I need to implement an anonymous Iterator within
the anonymous implementation of AbstractSet. Hence the approach with the
InnerMap is much more concise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[PR] chore(deps): update dependency org.glassfish.jersey.containers:jersey-container-jetty-http to v2.46 [solr]
solrbot opened a new pull request, #3108: URL: https://github.com/apache/solr/pull/3108 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.glassfish.jersey.containers:jersey-container-jetty-http](https://projects.eclipse.org/projects/ee4j.jersey) ([source](https://redirect.github.com/eclipse-ee4j/jersey)) | dependencies | minor | `2.39.1` -> `2.46` | --- ### Release Notes eclipse-ee4j/jersey (org.glassfish.jersey.containers:jersey-container-jetty-http) ### [`v2.46`](https://redirect.github.com/eclipse-ee4j/jersey/releases/tag/2.46) [Compare Source](https://redirect.github.com/eclipse-ee4j/jersey/compare/2.45...2.46) [Pull 5749] - Jersey update from 3.1.3 to 3.1.4 slows down our external service res… [Pull 5750] - Use Skipping Analyzer always [Pull 5751] - test(flaky): fix paramter type assert in testBothAnnotatedConstructor test case [Pull 5754] - test(flaky): Sorting headers for deterministic order [Pull 5755] - Netty connector hang up after repeated buffer overflow errors when writing data #5753 [Pull 5758] - Bump commons-io:commons-io from 2.11.0 to 2.14.0 in /tools/jersey-release-notes-maven-plugin [Pull 5759] - Added test for JerseyChunkedInputStreamClose [Pull 5760] - Adopt ASM 9.7.1 (JDK 24) [Pull 5761] - Adopt Jackson 2.18.0 [Pull 5768] - fixed flaky test in testDisabledModule() [Pull 5784] - Jersey 3.1.9: java.lang.NoSuchMethodException: jakarta.inject.Inject.value() #5782 [Pull 5788] - Wrapping all methods of the EntityInputStream [Pull 5792] - [2.x] ParamConverterProvider constructors are now protected to allow extensibility [Pull 5800] - NettyConnector - HOST header contains port & 307 works with buffered post [Pull 5801] - Set correct HOST header for Netty & POST [Pull 5809] - Fixed memory leak in Micrometer code when exceptions are returned from the method [Pull 5813] - Fix memory leak when client does not use HK2 [Pull 5816] - Allow to configure Jackson's JaxRSFeature on Jersey DefaultJacksonJaxbJsonProvider [Pull 5819] - Build & run with JDK 24 ### [`v2.45`](https://redirect.github.com/eclipse-ee4j/jersey/releases/tag/2.45) [Compare Source](https://redirect.github.com/eclipse-ee4j/jersey/compare/2.44...2.45) [Pull 5715] - Release a reference to threadlocal on shutdown [Pull 5731] - Allow to disable JSON-B using System properties ### [`v2.44`](https://redirect.github.com/eclipse-ee4j/jersey/releases/tag/2.44) [Compare Source](https://redirect.github.com/eclipse-ee4j/jersey/compare/2.43...2.44) [Pull 5636] - Allow long content length in the JDK connector [Pull 5639] - Allow having multiple annotations for multipart endpoint with @FormDataParam in any order [Pull 5642] - Remove synchronized from Apache stream wrappers [Pull 5643] - Document Multipart Configuration. [Pull 5644] - Refactoring Maven build process [Pull 5648] - Support for Virtual Threads in Executor Services [Pull 5649] - MAX_HEADER_SIZE for the Netty connector [Pull 5652] - Unify the SniConfigurator with other branches [Pull 5664] - More release checks [Pull 5665] - update Jackson to 2.17.1 [Pull 5666] - [2.x] mvn build improvements [Pull 5669] - prevent calling ServletRequest#getInputStream if FILTER_FORWARD_ON_404 [Pull 5673] - Support missing Content-Length header [Pull 5677] - Prevent blowing connections number for reoccurring SSLContextFatories [Pull 5685] - Better explanation of missing jersey-hk2 module consequences. [Pull 5688] - Wrap call of deprecated HttpServletResponse#setStatus into try catch [Pull 5689] - Support Multipart with Buffered Entity and Netty Connector [Pull 5690] - Prevent NPE in micrometer when there is no response & 404 [Pull 5698] - Last-Modified header is garbled when accessing wadl document on Japanese locale [Pull 5705] - Allow ChunkedInput#close to close the underlying stream [Pull 5706] - Propagate WebApplicationException from SseEventSource to provided error handler [Pull 5707] - Fix intermittent failure in BroadcasterExecutorTest ### [`v2.43`](https://redirect.github.com/eclipse-ee4j/jersey/releases/tag/2.43) [Compare Source](https://redirect.github.com/eclipse-ee4j/jersey/compare/2.42...2.43) [Pull 5574] - Backing up CI/CD jobs into the Jersey project [Pull 5580] - Adopt ASM 9.7 [Pull 5592] - Micrometer - Add missing metrics for cases of client errors [Pull 5604] - Prevent Jackson failing while loading Modules (classloader issues) [Pull 5605] - Cleaning redundant plugins from plugin management [Pull 5606] - clean CI/CD scripts from the main project [Pull 5608] - ObjectMapper.findModules throws Error [Pull 5613] - Allow the internal package to be a part of the Jersey APIDoc [Pull 5614] - Adde
[PR] chore(deps): update dependency org.eclipse.jgit:org.eclipse.jgit to v6.10.0.202406032230-r [solr]
solrbot opened a new pull request, #3107: URL: https://github.com/apache/solr/pull/3107 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.eclipse.jgit:org.eclipse.jgit](https://eclipse.gerrithub.io/plugins/gitiles/eclipse-jgit/jgit) | dependencies | minor | `6.7.0.202309050840-r` -> `6.10.0.202406032230-r` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] chore(deps): update dependency org.eclipse.jdt:ecj to v3.40.0 [solr]
solrbot opened a new pull request, #3106: URL: https://github.com/apache/solr/pull/3106 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.eclipse.jdt:ecj](https://projects.eclipse.org/projects/eclipse.jdt) ([source](https://redirect.github.com/eclipse-jdt/eclipse.jdt.core)) | dependencies | minor | `3.39.0` -> `3.40.0` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] chore(deps): update mockito to v5.15.2 [solr]
HoustonPutman merged PR #2998: URL: https://github.com/apache/solr/pull/2998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]
HoustonPutman commented on code in PR #2960:
URL: https://github.com/apache/solr/pull/2960#discussion_r1929056967
##
solr/core/src/java/org/apache/solr/search/QueryResult.java:
##
@@ -22,6 +22,7 @@ public class QueryResult {
// Object for back compatibility so that we render true not "true" in json
private Object partialResults;
private Boolean segmentTerminatedEarly;
Review Comment:
Agreed, I'm not sure how people are going to respond differently between the
two
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17623: Simple ordered map should implement map [solr]
dsmiley commented on code in PR #3048:
URL: https://github.com/apache/solr/pull/3048#discussion_r1929111648
##
solr/solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java:
##
@@ -68,24 +74,153 @@ public SimpleOrderedMap(Map.Entry[]
nameValuePairs) {
public SimpleOrderedMap clone() {
ArrayList newList = new ArrayList<>(nvPairs.size());
newList.addAll(nvPairs);
-return new SimpleOrderedMap<>(newList);
+return new SimpleOrderedMap(newList);
+ }
+
+ @Override
+ public boolean isEmpty() {
+return nvPairs.isEmpty();
+ }
+
+ @Override
+ public boolean containsKey(final Object key) {
+return this.indexOf((String) key) >= 0;
}
/**
- * Returns a shared, empty, and immutable instance of SimpleOrderedMap.
+ * Returns {@code true} if this map maps one or more keys to the specified
value.
Review Comment:
If we don't have anything extra to say beyond the default javadoc, then add
nothing at all (no javadoc). If you want to add a tidbit of extra info to say
something O(N) then you can use `{@inheritDoc}` and add the sentence. But I
think you could just augment the class level javadocs to warn users about usage
of this as a general Map for large maps.
##
solr/solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java:
##
@@ -68,24 +74,153 @@ public SimpleOrderedMap(Map.Entry[]
nameValuePairs) {
public SimpleOrderedMap clone() {
ArrayList newList = new ArrayList<>(nvPairs.size());
newList.addAll(nvPairs);
-return new SimpleOrderedMap<>(newList);
+return new SimpleOrderedMap(newList);
+ }
+
+ @Override
+ public boolean isEmpty() {
+return nvPairs.isEmpty();
+ }
+
+ @Override
+ public boolean containsKey(final Object key) {
+return this.indexOf((String) key) >= 0;
}
/**
- * Returns a shared, empty, and immutable instance of SimpleOrderedMap.
+ * Returns {@code true} if this map maps one or more keys to the specified
value.
*
- * @return Empty SimpleOrderedMap (immutable)
+ * @param value value whose presence in this map is to be tested
+ * @return {@code true} if this map maps one or more keys to the specified
value
*/
- public static SimpleOrderedMap of() {
-return EMPTY;
+ @Override
+ public boolean containsValue(final Object value) {
+int sz = size();
Review Comment:
instead of all these lines, could be a one-liner values().contains(value).
It'll be rare if ever for any Solr code to call this.
##
solr/solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java:
##
@@ -68,24 +74,153 @@ public SimpleOrderedMap(Map.Entry[]
nameValuePairs) {
public SimpleOrderedMap clone() {
ArrayList newList = new ArrayList<>(nvPairs.size());
newList.addAll(nvPairs);
-return new SimpleOrderedMap<>(newList);
+return new SimpleOrderedMap(newList);
+ }
+
+ @Override
+ public boolean isEmpty() {
+return nvPairs.isEmpty();
+ }
+
+ @Override
+ public boolean containsKey(final Object key) {
+return this.indexOf((String) key) >= 0;
}
/**
- * Returns a shared, empty, and immutable instance of SimpleOrderedMap.
+ * Returns {@code true} if this map maps one or more keys to the specified
value.
*
- * @return Empty SimpleOrderedMap (immutable)
+ * @param value value whose presence in this map is to be tested
+ * @return {@code true} if this map maps one or more keys to the specified
value
*/
- public static SimpleOrderedMap of() {
-return EMPTY;
+ @Override
+ public boolean containsValue(final Object value) {
+int sz = size();
+for (int i = 0; i < sz; i++) {
+ T val = getVal(i);
+ if (Objects.equals(value, val)) {
+return true;
+ }
+}
+return false;
+ }
+
+ /**
+ * Has linear lookup time O(N)
+ *
+ * @see NamedList#get(String)
+ */
+ @Override
+ public T get(final Object key) {
+return super.get((String) key);
}
/**
- * Returns an immutable instance of SimpleOrderedMap with a single key-value
pair.
+ * Associates the specified value with the specified key in this map If the
map previously
+ * contained a mapping for the key, the old value is replaced by the
specified value.
*
- * @return SimpleOrderedMap containing one key-value pair
+ * @param key key with which the specified value is to be associated value –
value to be
+ * associated with the specified key
+ * @param value to be associated with the specified key
+ * @return the previous value associated with key, or null if there was no
mapping for key. (A
+ * null return can also indicate that the map previously associated null
with key)
+ */
+ @Override
+ public T put(String key, T value) {
+int idx = indexOf(key);
+if (idx == -1) {
+ add(key, value);
+ return null;
+} else {
+ T t = get(key);
+ setVal(idx, value);
+ return t;
+}
+ }
+
+ /**
+ * @see NamedList#remove(Str
[PR] chore(deps): update dependency com.lmax:disruptor to v4 [solr]
solrbot opened a new pull request, #3127: URL: https://github.com/apache/solr/pull/3127 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.lmax:disruptor](https://lmax-exchange.github.io/disruptor) ([source](https://redirect.github.com/LMAX-Exchange/disruptor)) | dependencies | major | `3.4.4` -> `4.0.0` | --- ### Release Notes LMAX-Exchange/disruptor (com.lmax:disruptor) ### [`v4.0.0`](https://redirect.github.com/LMAX-Exchange/disruptor/releases/tag/4.0.0) [Compare Source](https://redirect.github.com/LMAX-Exchange/disruptor/compare/3.4.4...4.0.0) - Minimum Java version now 11 - Issue [#323](https://redirect.github.com/LMAX-Exchange/disruptor/issues/323) - `WorkerPool` and `WorkProcessor` have been removed, no more `Disruptor::handleEventsWithWorkerPool` - `Disruptor` constructors using `Executor` have been removed. Use `ThreadFactory` instead. - Rolled up event handling extension interfaces on to `EventHandler`: - `BatchStartAware` - `LifecycleAware` - `SequenceReportingEventHandler` - `FatalExceptionHandler` and `IgnoreExceptionHandler` now use the JDK 9 Platform Logging API, i.e. `System.Logger` - Add rewind batch feature to the `BatchEventProcessor` - Add a maximum batch size argument to `BatchEventProcessor` - `EventHandler::onBatchStart` now gets both the `batchSize` as well as `queueDepth` (previously it had `batchSize` which reported queue depth) - Added documentation to `EventPoller` - `Util::log2` throws if passed a non-positive argument - Deprecations - Deprecated `ThreadHints.onSpinWait()` - Deprecated `Disruptor.handleExceptionsWith()` - this had been javadoc deprecated since 2015 but not in the code - Removed previously deprecated methods - `Ringbuffer.resetTo()` - `ConsumerRepository.getLastSequenceInChain()` --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] chore(deps): update dependency com.ibm.icu:icu4j to v76 [solr]
solrbot opened a new pull request, #3126: URL: https://github.com/apache/solr/pull/3126 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.ibm.icu:icu4j](https://icu.unicode.org/) ([source](https://redirect.github.com/unicode-org/icu)) | dependencies | major | `74.2` -> `76.1` | --- ### Release Notes unicode-org/icu (com.ibm.icu:icu4j) ### [`v76.1`](https://redirect.github.com/unicode-org/icu/compare/release-75-1...release-76-1) [Compare Source](https://redirect.github.com/unicode-org/icu/compare/release-75-1...release-76-1) ### [`v75.1`](https://redirect.github.com/unicode-org/icu/compare/release-74-2...release-75-1) [Compare Source](https://redirect.github.com/unicode-org/icu/compare/release-74-2...release-75-1) --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] chore(deps): update dependency biz.aqute.bnd:biz.aqute.bnd.annotation to v7 [solr]
solrbot opened a new pull request, #3124: URL: https://github.com/apache/solr/pull/3124 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [biz.aQute.bnd:biz.aQute.bnd.annotation](https://bnd.bndtools.org/) ([source](https://redirect.github.com/bndtools/bnd)) | dependencies | major | `6.4.1` -> `7.1.0` | --- ### Release Notes bndtools/bnd (biz.aQute.bnd:biz.aQute.bnd.annotation) ### [`v7.1.0`](https://redirect.github.com/bndtools/bnd/releases/tag/7.1.0): Bnd/Bndtools 7.1.0 [Compare Source](https://redirect.github.com/bndtools/bnd/compare/7.0.0...7.1.0) See [Release Notes](https://redirect.github.com/bndtools/bnd/wiki/Changes-in-7.1.0). ### [`v7.0.0`](https://redirect.github.com/bndtools/bnd/releases/tag/7.0.0): Bnd/Bndtools 7.0.0 [Compare Source](https://redirect.github.com/bndtools/bnd/compare/6.4.1...7.0.0) This is the first release on Java 17. See [Release Notes](https://redirect.github.com/bndtools/bnd/wiki/Changes-in-7.0.0). --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] chore(deps): update dependency com.diffplug.spotless to v7 [solr]
solrbot opened a new pull request, #3125: URL: https://github.com/apache/solr/pull/3125 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | com.diffplug.spotless | plugin | major | `6.5.2` -> `7.0.2` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] chore(deps): update dependency jakarta.annotation:jakarta.annotation-api to v3 [solr]
solrbot opened a new pull request, #3129: URL: https://github.com/apache/solr/pull/3129 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [jakarta.annotation:jakarta.annotation-api](https://projects.eclipse.org/projects/ee4j.ca) ([source](https://redirect.github.com/jakartaee/common-annotations-api)) | dependencies | major | `2.1.1` -> `3.0.0` | --- ### Release Notes jakartaee/common-annotations-api (jakarta.annotation:jakarta.annotation-api) ### [`v3.0.0`](https://redirect.github.com/jakartaee/common-annotations-api/compare/2.1.1...3.0.0) [Compare Source](https://redirect.github.com/jakartaee/common-annotations-api/compare/2.1.1...3.0.0) --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] chore(deps): update dependency jakarta.ws.rs:jakarta.ws.rs-api to v4 [solr]
solrbot opened a new pull request, #3130: URL: https://github.com/apache/solr/pull/3130 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [jakarta.ws.rs:jakarta.ws.rs-api](https://redirect.github.com/jakartaee/rest) | dependencies | major | `3.1.0` -> `4.0.0` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] chore(deps): update dependency no.nav.security:mock-oauth2-server to v2 [solr]
solrbot opened a new pull request, #3133:
URL: https://github.com/apache/solr/pull/3133
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
|
[no.nav.security:mock-oauth2-server](https://redirect.github.com/navikt/mock-oauth2-server)
| dependencies | major | `0.5.10` -> `2.1.10` |
---
### Release Notes
navikt/mock-oauth2-server
(no.nav.security:mock-oauth2-server)
###
[`v2.1.10`](https://redirect.github.com/navikt/mock-oauth2-server/releases/tag/2.1.10)
[Compare
Source](https://redirect.github.com/navikt/mock-oauth2-server/compare/2.1.9...2.1.10)
What's Changed
- fix(logback): set logback severity back to INFO
([#753](https://redirect.github.com/navikt/mock-oauth2-server/issues/753))
[@jenspav](https://redirect.github.com/jenspav)
- fix(readme): replace scope with code
([#754](https://redirect.github.com/navikt/mock-oauth2-server/issues/754))
[@jenspav](https://redirect.github.com/jenspav)
- feat: support custom TimeProvider when validating tokens (introspect,
userinfo)
([#730](https://redirect.github.com/navikt/mock-oauth2-server/issues/730))
[@tommytroen](https://redirect.github.com/tommytroen)
⬆️ Dependency upgrades
- chore(deps): bump the github group with 7 updates
([#734](https://redirect.github.com/navikt/mock-oauth2-server/issues/734))
[@dependabot](https://redirect.github.com/dependabot)
- chore(deps): bump the github group across 1 directory with 2 updates
([#733](https://redirect.github.com/navikt/mock-oauth2-server/issues/733))
[@dependabot](https://redirect.github.com/dependabot)
###
[`v2.1.9`](https://redirect.github.com/navikt/mock-oauth2-server/releases/tag/2.1.9)
[Compare
Source](https://redirect.github.com/navikt/mock-oauth2-server/compare/2.1.8...2.1.9)
What's Changed
- chore(build): netty-all with netty-codec-http
([#723](https://redirect.github.com/navikt/mock-oauth2-server/issues/723))
[@ybelMekk](https://redirect.github.com/ybelMekk)
- Fix/704 response types
([#710](https://redirect.github.com/navikt/mock-oauth2-server/issues/710))
[@pniederlag](https://redirect.github.com/pniederlag)
⬆️ Dependency upgrades
- chore(deps): bump the github group across 1 directory with 5 updates
([#726](https://redirect.github.com/navikt/mock-oauth2-server/issues/726))
[@dependabot](https://redirect.github.com/dependabot)
- chore: bumped gradle wrapper to 8.9
([#724](https://redirect.github.com/navikt/mock-oauth2-server/issues/724))
[@MikAoJk](https://redirect.github.com/MikAoJk)
- chore(deps): bump the github group across 1 directory with 17 updates
([#722](https://redirect.github.com/navikt/mock-oauth2-server/issues/722))
[@dependabot](https://redirect.github.com/dependabot)
- chore(deps): bump the github group across 1 directory with 2 updates
([#715](https://redirect.github.com/navikt/mock-oauth2-server/issues/715))
[@dependabot](https://redirect.github.com/dependabot)
###
[`v2.1.8`](https://redirect.github.com/navikt/mock-oauth2-server/releases/tag/2.1.8)
[Compare
Source](https://redirect.github.com/navikt/mock-oauth2-server/compare/2.1.7...2.1.8)
What's Changed
🐛 Bug Fixes
- fix: extend wellknown return values
([#704](https://redirect.github.com/navikt/mock-oauth2-server/issues/704))
([#706](https://redirect.github.com/navikt/mock-oauth2-server/issues/706))
[@pniederlag](https://redirect.github.com/pniederlag)
⬆️ Dependency upgrades
- chore(deps): bump the github group across 1 directory with 20 updates
([#709](https://redirect.github.com/navikt/mock-oauth2-server/issues/709))
[@dependabot](https://redirect.github.com/dependabot)
- chore(deps): bump org.jetbrains.kotlinx:kotlinx-serialization-json from
1.6.3 to 1.7.0 in the github group
([#702](https://redirect.github.com/navikt/mock-oauth2-server/issues/702))
[@dependabot](https://redirect.github.com/dependabot)
###
[`v2.1.7`](https://redirect.github.com/navikt/mock-oauth2-server/releases/tag/2.1.7)
[Compare
Source](https://redirect.github.com/navikt/mock-oauth2-server/compare/2.1.6...2.1.7)
What's Changed
🚀 Features
- feat: support objects and lists in request mapping claims
([#699](https://redirect.github.com/navikt/mock-oauth2-server/issues/699))
[@tommytroen](https://redirect.github.com/tommytroen)
###
[`v2.1.6`](https://redirect.github.com/navikt/mock-oauth2-server/releases/tag/2.1.6)
[Compare
Source](https://redirect.github.com/navikt/mock-oauth2-server/compare/2.1.5...2.1.6)
What's Changed
-
[#691](https://redirect.github.com/navikt/mock-oauth2-server/issues/691)
`OAuth2TokenProvider` should allow dynamic `systemTime`
([#693](https://redirect.github.com/navikt/mock-oauth2-ser
[PR] chore(deps): update dependency net.thisptr:jackson-jq to v1 [solr]
solrbot opened a new pull request, #3132: URL: https://github.com/apache/solr/pull/3132 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [net.thisptr:jackson-jq](https://redirect.github.com/eiiches/jackson-jq) ([source](https://redirect.github.com/juven/git-demo)) | dependencies | major | `0.0.13` -> `1.2.0` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Remove unused 9.7.1 section in CHANGES.txt [solr]
janhoy merged PR #3055: URL: https://github.com/apache/solr/pull/3055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-6122 POC new cancel handler for Collections api [solr]
cpoerschke commented on code in PR #3033:
URL: https://github.com/apache/solr/pull/3033#discussion_r1928365295
##
solr/core/src/java/org/apache/solr/cloud/api/collections/OverseerCancelMessageHandler.java:
##
@@ -0,0 +1,237 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.cloud.api.collections;
+
+import static
org.apache.solr.cloud.api.collections.CollectionHandlingUtils.REQUESTID;
+
+import java.io.IOException;
+import java.lang.invoke.MethodHandles;
+import java.util.HashSet;
+import java.util.Set;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.SynchronousQueue;
+import java.util.concurrent.TimeUnit;
+import org.apache.solr.client.solrj.cloud.SolrCloudManager;
+import org.apache.solr.cloud.Overseer;
+import org.apache.solr.cloud.OverseerMessageHandler;
+import org.apache.solr.cloud.OverseerSolrResponse;
+import org.apache.solr.cloud.OverseerTaskProcessor;
+import org.apache.solr.cloud.Stats;
+import org.apache.solr.common.SolrCloseable;
+import org.apache.solr.common.SolrException;
+import org.apache.solr.common.cloud.ZkNodeProps;
+import org.apache.solr.common.util.ExecutorUtil;
+import org.apache.solr.common.util.NamedList;
+import org.apache.solr.common.util.SimpleOrderedMap;
+import org.apache.solr.common.util.SolrNamedThreadFactory;
+import org.apache.solr.handler.component.HttpShardHandlerFactory;
+import org.apache.zookeeper.KeeperException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * A {@link OverseerMessageHandler} that handles cancelling API-related
overseer messages. Works
+ * closely with {@link OverseerTaskProcessor}.
+ */
+public class OverseerCancelMessageHandler implements OverseerMessageHandler,
SolrCloseable {
+
+ public static final String CANCEL_PREFIX = "cancel";
+
+
+ private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ private final Overseer overseer;
+ private final HttpShardHandlerFactory shardHandlerFactory;
+ private final SolrCloudManager cloudManager;
+ private final Stats stats;
+ private OverseerTaskProcessor overseerTaskProcessor;
+ private final Set cancelInProgressSet;
+
+ private final ExecutorService tpe =
+ new ExecutorUtil.MDCAwareThreadPoolExecutor(
+ 5,
+ 10,
+ 0L,
+ TimeUnit.MILLISECONDS,
+ new SynchronousQueue<>(),
+ new
SolrNamedThreadFactory("OverseerCancelMessageHandlerThreadFactory"));
+
+ private volatile boolean isClosed;
+
+ public OverseerCancelMessageHandler(
+ final HttpShardHandlerFactory shardHandlerFactory, Stats stats, Overseer
overseer) {
+this.shardHandlerFactory = shardHandlerFactory;
+this.stats = stats;
+this.overseer = overseer;
+this.cloudManager = overseer.getSolrCloudManager();
+this.isClosed = false;
+this.cancelInProgressSet = new HashSet<>();
+ }
+
+ @Override
+ public void close() throws IOException {
+isClosed = true;
+ExecutorUtil.shutdownAndAwaitTermination(tpe);
+ }
+
+ @Override
+ public OverseerSolrResponse processMessage(ZkNodeProps message, String
operation) {
+
+if (!operation.startsWith(CANCEL_PREFIX)) {
+ throw new SolrException(
+ SolrException.ErrorCode.BAD_REQUEST,
+ "Operation does not contain proper prefix: " + operation + "
expected: " + CANCEL_PREFIX);
+}
+
+String targetAsyncId = message.getStr(REQUESTID);
+if (targetAsyncId == null) {
+ throw new SolrException(
+ SolrException.ErrorCode.BAD_REQUEST,
+ "Cancel message must include 'REQUESTID' parameter.");
+}
+
+log.debug("OverseerCancelMessageHandler.processMessage : {} , {}",
operation, targetAsyncId);
+
+NamedList results = new SimpleOrderedMap<>();
+
+try {
+ boolean isInProgress =
overseerTaskProcessor.isAsyncTaskInProgress(targetAsyncId);
+ boolean isSubmitted =
overseerTaskProcessor.isAsyncTaskInSubmitted(targetAsyncId);
+
+ if (!isSubmitted && !isInProgress) {
+results =
+buildResponse(
+targetAsyncId, "not_found", "Task was not found or has already
completed.");
+return new OverseerSolrResponse(resul
[PR] SOLR-13360 StringIndexOutOfBoundsException: String index out of range [solr]
stillalex opened a new pull request, #3112: URL: https://github.com/apache/solr/pull/3112 https://issues.apache.org/jira/browse/SOLR-13360 # Description Please provide a short description of the changes you're making with this pull request. # Solution Please provide a short description of the approach taken to implement your solution. # Tests Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem. # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] chore(deps): update dependency org.semver4j:semver4j to v5.6.0 [solr]
solrbot opened a new pull request, #3113:
URL: https://github.com/apache/solr/pull/3113
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [org.semver4j:semver4j](https://redirect.github.com/semver4j/semver4j) |
dependencies | minor | `5.3.0` -> `5.6.0` |
---
### Release Notes
semver4j/semver4j (org.semver4j:semver4j)
###
[`v5.6.0`](https://redirect.github.com/semver4j/semver4j/releases/tag/v5.6.0)
What's Changed
🚀 Features
-
([#317](https://redirect.github.com/semver4j/semver4j/issues/317)) Add
NullAway checks by [@mk868](https://redirect.github.com/mk868)
📦 Dependency Updates
-
([#322](https://redirect.github.com/semver4j/semver4j/issues/322)) Bump
org.assertj:assertj-core from 3.27.2 to 3.27.3 by
@[dependabot\[bot\]](https://redirect.github.com/apps/dependabot)
-
([#321](https://redirect.github.com/semver4j/semver4j/issues/321)) Bump
org.assertj:assertj-core from 3.27.1 to 3.27.2 by
@[dependabot\[bot\]](https://redirect.github.com/apps/dependabot)
-
([#319](https://redirect.github.com/semver4j/semver4j/issues/319)) Bump
org.mockito:mockito-core from 5.14.2 to 5.15.2 by
@[dependabot\[bot\]](https://redirect.github.com/apps/dependabot)
-
([#318](https://redirect.github.com/semver4j/semver4j/issues/318)) Bump
org.assertj:assertj-core from 3.27.0 to 3.27.1 by
@[dependabot\[bot\]](https://redirect.github.com/apps/dependabot)
###
[`v5.5.0`](https://redirect.github.com/semver4j/semver4j/releases/tag/v5.5.0)
What's Changed
🚀 Features
-
([#313](https://redirect.github.com/semver4j/semver4j/issues/313))
Update Maven Wrapper by [@mk868](https://redirect.github.com/mk868)
-
([#309](https://redirect.github.com/semver4j/semver4j/issues/309))
Replace nullness annotations with JSpecify by
[@mk868](https://redirect.github.com/mk868)
📦 Dependency Updates
8 changes
-
([#315](https://redirect.github.com/semver4j/semver4j/issues/315)) Bump
peter-evans/create-pull-request from 7.0.5 to 7.0.6 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#314](https://redirect.github.com/semver4j/semver4j/issues/314)) Bump
org.assertj:assertj-core from 3.26.3 to 3.27.0 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#311](https://redirect.github.com/semver4j/semver4j/issues/311)) Bump
org.junit.jupiter:junit-jupiter from 5.11.3 to 5.11.4 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#310](https://redirect.github.com/semver4j/semver4j/issues/310)) Bump
org.apache.maven.plugins:maven-javadoc-plugin from 3.11.1 to 3.11.2 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#305](https://redirect.github.com/semver4j/semver4j/issues/305)) Bump
org.apache.maven.plugins:maven-javadoc-plugin from 3.10.1 to 3.11.1 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#306](https://redirect.github.com/semver4j/semver4j/issues/306)) Bump
org.apache.maven.plugins:maven-surefire-plugin from 3.5.1 to 3.5.2 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#304](https://redirect.github.com/semver4j/semver4j/issues/304)) Bump
org.apache.maven.plugins:maven-checkstyle-plugin from 3.5.0 to 3.6.0 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#303](https://redirect.github.com/semver4j/semver4j/issues/303)) Bump
org.junit.jupiter:junit-jupiter from 5.11.2 to 5.11.3 by
[@dependabot](https://redirect.github.com/dependabot)
###
[`v5.4.1`](https://redirect.github.com/semver4j/semver4j/releases/tag/v5.4.1)
What's Changed
🪳 Bug Fixes
-
([#293](https://redirect.github.com/semver4j/semver4j/issues/293)) Fix
OOBE, update README by
[@WarningImHack3r](https://redirect.github.com/WarningImHack3r)
🧹 Housekeeping
-
([#294](https://redirect.github.com/semver4j/semver4j/issues/294)) Add
Java 21 by [@piotrooo](https://redirect.github.com/piotrooo)
📦 Dependency Updates
15 changes
-
([#301](https://redirect.github.com/semver4j/semver4j/issues/301)) Bump
org.mockito:mockito-core from 5.14.1 to 5.14.2 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#300](https://redirect.github.com/semver4j/semver4j/issues/300)) Bump
org.jetbrains:annotations from 26.0.0 to 26.0.1 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#298](https://redirect.github.com/semver4j/semver4j/issues/298)) Bump
org.jetbrains:annotations from 25.0.0 to 26.0.0 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#296](https://redirect.github.com/semver4j/semver4j/issues/296)) Bump
de.thetaphi:forbiddenapis from 3.7 to 3.8 by
[@dependabot](https://redirect.github.com/dependabot)
-
([#297](https://redirect
[PR] chore(deps): update google.auth to v1.31.0 [solr]
solrbot opened a new pull request, #3115: URL: https://github.com/apache/solr/pull/3115 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.google.auth:google-auth-library-oauth2-http](https://redirect.github.com/googleapis/google-auth-library-java) | dependencies | minor | `1.19.0` -> `1.31.0` | | [com.google.auth:google-auth-library-credentials](https://redirect.github.com/googleapis/google-auth-library-java) | dependencies | minor | `1.19.0` -> `1.31.0` | --- ### Release Notes googleapis/google-auth-library-java (com.google.auth:google-auth-library-oauth2-http) ### [`v1.31.0`](https://redirect.github.com/googleapis/google-auth-library-java/blob/HEAD/CHANGELOG.md#1310-2025-01-22) # Features - ImpersonatedCredentials to support universe domain for idtoken and signblob ([#1566](https://redirect.github.com/googleapis/google-auth-library-java/issues/1566)) ([adc2ff3](https://redirect.github.com/googleapis/google-auth-library-java/commit/adc2ff3dcabb79e367d0d66b5b3fd8a51e35bc2b)) - Support transport and binding-enforcement MDS parameters. ([#1558](https://redirect.github.com/googleapis/google-auth-library-java/issues/1558)) ([9828a8e](https://redirect.github.com/googleapis/google-auth-library-java/commit/9828a8eeb9f144f7c341df0c03282a8790356962)) # Documentation - Promote use of bill of materials in quickstart documentation ([#1620](https://redirect.github.com/googleapis/google-auth-library-java/issues/1620)) ([fc20d9c](https://redirect.github.com/googleapis/google-auth-library-java/commit/fc20d9c9d33b7eada964cf41297f8a3e13c27fe1)), closes [#1552](https://redirect.github.com/googleapis/google-auth-library-java/issues/1552) ### [`v1.30.1`](https://redirect.github.com/googleapis/google-auth-library-java/blob/HEAD/CHANGELOG.md#1301-2024-12-11) # Bug Fixes - JSON parsing of S2A addresses. ([#1589](https://redirect.github.com/googleapis/google-auth-library-java/issues/1589)) ([9d5ebfe](https://redirect.github.com/googleapis/google-auth-library-java/commit/9d5ebfe8870a11d27af3a7c7f3fd9930ab207162)) ### [`v1.30.0`](https://redirect.github.com/googleapis/google-auth-library-java/blob/HEAD/CHANGELOG.md#1300-2024-11-08) # Features - Support querying S2A Addresses from MDS ([#1400](https://redirect.github.com/googleapis/google-auth-library-java/issues/1400)) ([df06bd1](https://redirect.github.com/googleapis/google-auth-library-java/commit/df06bd1f94d03c4f8807c2adf42d25d29b731531)) # Bug Fixes - Make it explicit that there is a network call to MDS to get SecureSessionAgentConfig ([#1573](https://redirect.github.com/googleapis/google-auth-library-java/issues/1573)) ([18020fe](https://redirect.github.com/googleapis/google-auth-library-java/commit/18020fedb855742ee27b6558f5de58d3818c6b48)) ### [`v1.29.0`](https://redirect.github.com/googleapis/google-auth-library-java/blob/HEAD/CHANGELOG.md#1290-2024-10-22) # Features - Service sccount to service account impersonation to support universe domain ([#1528](https://redirect.github.com/googleapis/google-auth-library-java/issues/1528)) ([c498ccf](https://redirect.github.com/googleapis/google-auth-library-java/commit/c498ccf67755c6ec619cb37962c2c86ae3ec9d4c)) # Bug Fixes - Make some enum fields final ([#1526](https://redirect.github.com/googleapis/google-auth-library-java/issues/1526)) ([8920155](https://redirect.github.com/googleapis/google-auth-library-java/commit/89201558db913d9a71b3acccbab8eb0045ada6de)) ### [`v1.28.0`](https://redirect.github.com/googleapis/google-auth-library-java/blob/HEAD/CHANGELOG.md#1280-2024-10-02) # Features - Add metric headers ([#1503](https://redirect.github.com/googleapis/google-auth-library-java/issues/1503)) ([7f0c1d3](https://redirect.github.com/googleapis/google-auth-library-java/commit/7f0c1d31176f9e634fac3b2c6b06f880a51b5fa6)) ### [`v1.27.0`](https://redirect.github.com/googleapis/google-auth-library-java/blob/HEAD/CHANGELOG.md#1270-2024-09-20) # Features - Add api key credential as client library authorization type ([#1483](https://redirect.github.com/googleapis/google-auth-library-java/issues/1483)) ([6401e51](https://redirect.github.com/googleapis/google-auth-library-java/commit/6401e51c04fa6bd819e8dff98a62b7f079608a43)) ### [`v1.26.0`](https://redirect.github.com/googleapis/google-auth-library-java/blob/HEAD/CHANGELOG.md#1260-2024-09-18) # Features - Updates UserAuthorizer to support retrieving token response directly with different client auth types ([#1486](https://redirect.github.com/googleapis/google-auth-library-java/issues/1486)) ([1651006](https://redirect.github.com/googleapis/google-auth-library-java/commit/16510064e861868f
[PR] chore(deps): update grpc to v1.70.0 [solr]
solrbot opened a new pull request, #3117: URL: https://github.com/apache/solr/pull/3117 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.grpc:grpc-util](https://redirect.github.com/grpc/grpc-java) | dependencies | minor | `1.65.1` -> `1.70.0` | | [io.grpc:grpc-stub](https://redirect.github.com/grpc/grpc-java) | dependencies | minor | `1.65.1` -> `1.70.0` | | [io.grpc:grpc-protobuf-lite](https://redirect.github.com/grpc/grpc-java) | dependencies | minor | `1.65.1` -> `1.70.0` | | [io.grpc:grpc-protobuf](https://redirect.github.com/grpc/grpc-java) | dependencies | minor | `1.65.1` -> `1.70.0` | | [io.grpc:grpc-netty](https://redirect.github.com/grpc/grpc-java) | dependencies | minor | `1.65.1` -> `1.70.0` | | [io.grpc:grpc-core](https://redirect.github.com/grpc/grpc-java) | dependencies | minor | `1.65.1` -> `1.70.0` | | [io.grpc:grpc-context](https://redirect.github.com/grpc/grpc-java) | dependencies | minor | `1.65.1` -> `1.70.0` | | [io.grpc:grpc-bom](https://redirect.github.com/grpc/grpc-java) | dependencies | minor | `1.65.1` -> `1.70.0` | | [io.grpc:grpc-api](https://redirect.github.com/grpc/grpc-java) | dependencies | minor | `1.65.1` -> `1.70.0` | --- ### Release Notes grpc/grpc-java (io.grpc:grpc-util) ### [`v1.70.0`](https://redirect.github.com/grpc/grpc-java/releases/tag/v1.70.0) # **Bug Fixes** - Re-enable animalsniffer, fixing most violations ([`8ea3629`](https://redirect.github.com/grpc/grpc-java/commit/8ea362937)). Violations would only have triggered on API level 23 and earlier, and the violations fixed here were highly unlikely to be triggered - api: Fix Android API level 23 and earlier compatibility for StatusRuntimeException without stacktrace ([#11072](https://redirect.github.com/grpc/grpc-java/issues/11072)) ([`ebe2b48`](https://redirect.github.com/grpc/grpc-java/commit/ebe2b4867)). This fixes a regression introduced in 1.64.0. The regression should have caused failures on API level 23 and earlier when a StatusRuntimeException or StatusException was created. However, for unknown reasons tests on old devices didn’t notice issues - okhttp: Improve certificate handling by rejecting non-ASCII subject alternative names and hostnames as seen in CVE-2021-0341 ([#11749](https://redirect.github.com/grpc/grpc-java/issues/11749)) ([`a0982ca`](https://redirect.github.com/grpc/grpc-java/commit/a0982ca0a)). Hostnames are considered trusted and CAs are required to use punycode for non-ASCII hostnames, so this is expected to provide defense-in-depth. See also the [related GoSecure blog post](https://gosecure.ai/blog/2020/10/27/weakness-in-java-tls-host-verification/) and the [AOSP fix](https://android.googlesource.com/platform/external/okhttp/+/ddc934efe3ed06ce34f3724d41cfbdcd7e7358fc) - okhttp: Fix for ipv6 link local with scope ([#11725](https://redirect.github.com/grpc/grpc-java/issues/11725)) ([`65b32e6`](https://redirect.github.com/grpc/grpc-java/commit/65b32e60e)) - xds: Preserve nonce when unsubscribing last watcher of a particular type so that new discovery requests of that type are handled correctly ([`1cf1927`](https://redirect.github.com/grpc/grpc-java/commit/1cf1927d1)). This (along with [`6c12c2b`](https://redirect.github.com/grpc/grpc-java/commit/6c12c2bd2)) fixes a nonce-handling regression introduced in 1.66.0 that could cause resources to appear to not exist until re-creating the ADS stream. Triggering the behavior required specific config changes. It is easiest to trigger when clusters use EDS and routes are changed from one cluster to another. The error “found 0 leaf (logical DNS or EDS) clusters for root cluster” might then be seen - xds: Remember nonces for unknown types ([`6c12c2b`](https://redirect.github.com/grpc/grpc-java/commit/6c12c2bd2)) - xds: Unexpected types in the bootstrap’s server_features should be ignored ([`e8ff6da`](https://redirect.github.com/grpc/grpc-java/commit/e8ff6da2c)). They were previously required to be strings - xds: Remove xds authority label from metric registration ([#11760](https://redirect.github.com/grpc/grpc-java/issues/11760)) ([`6516c73`](https://redirect.github.com/grpc/grpc-java/commit/6516c7387)). This fixes the error “Incorrect number of required labels provided. Expected: 4” introduced in 1.69.0 - xds: Fixed unsupported unsigned 32 bits issue for circuit breaker ([#11735](https://redirect.github.com/grpc/grpc-java/issues/11735)) ([`f8f6139`](https://redirect.github.com/grpc/grpc-java/commit/f8f613984)). This fixes clients treating large max_requests as “no requests” and failing all requests # **Improvements** - api: Introduce custom NameResolver.Args ([#11669](https://redirect.github.com/grpc/grpc-java/issues/11669)) ([`0b2d440`](https://redirect.github.com/grpc/grpc-java/commit/
[PR] chore(deps): update google.errorprone to v2.36.0 [solr]
solrbot opened a new pull request, #3116: URL: https://github.com/apache/solr/pull/3116 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.google.errorprone:error_prone_core](https://errorprone.info) ([source](https://redirect.github.com/google/error-prone)) | dependencies | minor | `2.31.0` -> `2.36.0` | | [com.google.errorprone:error_prone_annotations](https://errorprone.info) ([source](https://redirect.github.com/google/error-prone)) | dependencies | minor | `2.31.0` -> `2.36.0` | --- ### Release Notes google/error-prone (com.google.errorprone:error_prone_core) ### [`v2.36.0`](https://redirect.github.com/google/error-prone/releases/tag/v2.36.0): Error Prone 2.36.0 Changes: - Add new matcher interfaces to `ErrorProneScanner` for AST nodes introduced after Java 11 ([`e5fd194`](https://redirect.github.com/google/error-prone/commit/e5fd194fa21ef9a01e8d4c72489906247aad81c8)) - Fix compatibility with latest JDK 24 EA builds (https://github.com/google/error-prone/commit/d67bc156b737d13ac693d73a403a11a97804423f) - Check that `--should-stop=ifError=FLOW` is set when using the `-Xplugin` integration ([`e71db1f`](https://redirect.github.com/google/error-prone/commit/e71db1f369a9367f6f2db34c4fbd006b6d6238fd)) New checks: - [`DuplicateBranches`](https://errorprone.info/bugpattern/DuplicateBranches): Discourage conditional expressions and if statements where both branches are the same - [`RedundantControlFlow`](https://errorprone.info/bugpattern/RedundantControlFlow): Reports redundant `continue` statements. Closed issues: [#4633](https://redirect.github.com/google/error-prone/issues/4633), [#4646](https://redirect.github.com/google/error-prone/issues/4646) Full changelog: https://github.com/google/error-prone/compare/v2.35.1...v2.36.0 ### [`v2.35.1`](https://redirect.github.com/google/error-prone/releases/tag/v2.35.1): Error Prone 2.35.1 Error Prone's dependency on protobuf has been downgraded to 3.25.5 for this release. Version 3.25.5 of protobuf still fixes CVE-2024-7254. This release is provided for users who aren't ready to update to 4.x, see also [#4584](https://redirect.github.com/google/error-prone/issues/4584) and [#4634](https://redirect.github.com/google/error-prone/issues/4634). Future versions of Error Prone will upgrade back to protobuf 4.x. Full changelog: https://github.com/google/error-prone/compare/v2.35.0...v2.35.1 ### [`v2.35.0`](https://redirect.github.com/google/error-prone/releases/tag/v2.35.0): Error Prone 2.35.0 Changes: - Fix handling of `\s` before the trailing delimiter in [`MisleadingEscapedSpace`](https://errorprone.info/bugpattern/MisleadingEscapedSpace) - [`TimeUnitMismatch`](https://errorprone.info/bugpattern/TimeUnitMismatch) improvements: handle binary trees, consider trees like `fooSeconds * 1000` to have units of millis New checks: - [`JavaDurationGetSecondsToToSeconds`](https://errorprone.info/bugpattern/JavaDurationGetSecondsToToSeconds): Prefer `duration.toSeconds()` over `duration.getSeconds()` Full changelog: https://github.com/google/error-prone/compare/v2.34.0...v2.35.0 ### [`v2.34.0`](https://redirect.github.com/google/error-prone/releases/tag/v2.34.0): Error Prone 2.34.0 Changes: - Passing the javac flag `--should-stop=ifError=FLOW` is now required when running Error Prone ([#4595](https://redirect.github.com/google/error-prone/issues/4595)) - The `MemberName` check was renamed to [`IdentifierName`](https://errorprone.info/bugpattern/IdentifierName) New checks: - [`FutureTransformAsync`](https://errorprone.info/bugpattern/FutureTransformAsync): The usage of transformAsync is not necessary when all the return values of the transformation function are immediate futures. - [`MisformattedTestData`](https://errorprone.info/bugpattern/MisformattedTestData): Reformats Java source code inside Error Prone test cases. - [`MisleadingEscapedSpace`](https://errorprone.info/bugpattern/MisleadingEscapedSpace): Using `\s` anywhere except at the end of a line in a text block is potentially misleading. - [`ThrowIfUncheckedKnownUnchecked`](https://errorprone.info/bugpattern/ThrowIfUncheckedKnownUnchecked): `throwIfUnchecked(knownUnchecked)` is equivalent to `throw knownUnchecked`. Closed issues: [#4595](https://redirect.github.com/google/error-prone/issues/4595), [#4598](https://redirect.github.com/google/error-prone/issues/4598), [#4620](https://redirect.github.com/google/error-prone/issues/4620) Full changelog: https://github.com/google/error-prone/compare/v2.33.0...v2.34.0 ### [`v2.33.0`](https://redirect.github.com/google/error-prone/releases/tag/v2.33.0): Error Prone 2.33.0 Similar to release
[PR] chore(deps): update langchain4j to v0.36.2 [solr]
solrbot opened a new pull request, #3118: URL: https://github.com/apache/solr/pull/3118 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [dev.langchain4j:langchain4j-open-ai](https://redirect.github.com/langchain4j/langchain4j) | dependencies | minor | `0.35.0` -> `0.36.2` | | [dev.langchain4j:langchain4j-mistral-ai](https://redirect.github.com/langchain4j/langchain4j) | dependencies | minor | `0.35.0` -> `0.36.2` | | [dev.langchain4j:langchain4j-hugging-face](https://redirect.github.com/langchain4j/langchain4j) | dependencies | minor | `0.35.0` -> `0.36.2` | | [dev.langchain4j:langchain4j-core](https://redirect.github.com/langchain4j/langchain4j) | dependencies | minor | `0.35.0` -> `0.36.2` | | [dev.langchain4j:langchain4j-cohere](https://redirect.github.com/langchain4j/langchain4j) | dependencies | minor | `0.35.0` -> `0.36.2` | --- ### Release Notes langchain4j/langchain4j (dev.langchain4j:langchain4j-open-ai) ### [`v0.36.2`](https://redirect.github.com/langchain4j/langchain4j/releases/tag/0.36.2) [Compare Source](https://redirect.github.com/langchain4j/langchain4j/compare/0.36.1...0.36.2) # What's Changed - Fix [#2133](https://redirect.github.com/langchain4j/langchain4j/issues/2133) Spring boot starter breaks configuration classes by [@qing-wq](https://redirect.github.com/qing-wq) in [https://github.com/langchain4j/langchain4j-spring/pull/79](https://redirect.github.com/langchain4j/langchain4j-spring/pull/79) ### [`v0.36.1`](https://redirect.github.com/langchain4j/langchain4j/releases/tag/0.36.1) [Compare Source](https://redirect.github.com/langchain4j/langchain4j/compare/0.36.0...0.36.1) # Fixes - [Fixed](https://redirect.github.com/langchain4j/langchain4j/commit/8a1d755196a2c4ccac805ed0f04972c68befdf26#diff-12719e04c48f3263f90134aa98b8f63c2dcac5ffc06b2877baaf36e29f0ab4c1R30) [https://github.com/langchain4j/langchain4j/issues/2117](https://redirect.github.com/langchain4j/langchain4j/issues/2117) - [Fixed](https://redirect.github.com/langchain4j/langchain4j-embeddings/commit/5b1fc1dd9871222851b1742e648a99298b64d3a1) [https://github.com/langchain4j/langchain4j/issues/2117](https://redirect.github.com/langchain4j/langchain4j/issues/2117) # What's Changed - fix(deps): update dependency org.junit.platform:junit-platform-commons to v1.11.3 by [@renovate](https://redirect.github.com/renovate) in [https://github.com/langchain4j/langchain4j/pull/2099](https://redirect.github.com/langchain4j/langchain4j/pull/2099) - fix(deps): update dependency org.jetbrains.kotlin:kotlin-stdlib-jdk8 to v1.9.25 by [@renovate](https://redirect.github.com/renovate) in [https://github.com/langchain4j/langchain4j/pull/2097](https://redirect.github.com/langchain4j/langchain4j/pull/2097) - fix(deps): update dependency org.awaitility:awaitility to v4.2.2 by [@renovate](https://redirect.github.com/renovate) in [https://github.com/langchain4j/langchain4j/pull/2096](https://redirect.github.com/langchain4j/langchain4j/pull/2096) - [#1636](https://redirect.github.com/langchain4j/langchain4j/issues/1636) add lombok annotation processor by [@kpavlov](https://redirect.github.com/kpavlov) in [https://github.com/langchain4j/langchain4j/pull/2105](https://redirect.github.com/langchain4j/langchain4j/pull/2105) - Remove Lombok in langchain4j module by [@kpavlov](https://redirect.github.com/kpavlov) in [https://github.com/langchain4j/langchain4j/pull/2063](https://redirect.github.com/langchain4j/langchain4j/pull/2063) - Remove Lombok in LC4J-open-ai by [@kpavlov](https://redirect.github.com/kpavlov) in [https://github.com/langchain4j/langchain4j/pull/2064](https://redirect.github.com/langchain4j/langchain4j/pull/2064) - add EmbeddingStoreIT metadata assert closeTo by [@Martin7-1](https://redirect.github.com/Martin7-1) in [https://github.com/langchain4j/langchain4j/pull/2140](https://redirect.github.com/langchain4j/langchain4j/pull/2140) - langchain4j-onnx-scoring: [updated onnxruntime to 1.20.0 and djl to 0.30.0](https://redirect.github.com/langchain4j/langchain4j/commit/8a1d755196a2c4ccac805ed0f04972c68befdf26#diff-cc143402ec507219364406c7ca6776dad87829e4bbf47911641cabd3090dfb20R15) - Release 0.36.1 by [@langchain4j](https://redirect.github.com/langchain4j) in [https://github.com/langchain4j/langchain4j/pull/2149](https://redirect.github.com/langchain4j/langchain4j/pull/2149) **Full Changelog**: https://github.com/langchain4j/langchain4j/compare/0.36.0...0.36.1 ### [`v0.36.0`](https://redirect.github.com/langchain4j/langchain4j/releases/tag/0.36.0) [Compare Source](https://redirect.github.com/langchain4j/langchain4j/compare/0.35.0...0.36.0) # Core Features/Updates - Java 17 baseline by [@kpavlov](https://redirect.g
[PR] chore(deps): update org.apache.calcite to v1.38.0 [solr]
solrbot opened a new pull request, #3119: URL: https://github.com/apache/solr/pull/3119 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.apache.calcite:calcite-linq4j](https://calcite.apache.org) ([source](https://redirect.github.com/apache/calcite)) | dependencies | minor | `1.37.0` -> `1.38.0` | | [org.apache.calcite:calcite-core](https://calcite.apache.org) ([source](https://redirect.github.com/apache/calcite)) | dependencies | minor | `1.37.0` -> `1.38.0` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] chore(deps): update dependency org.threeten:threetenbp to v1.7.0 [solr]
solrbot opened a new pull request, #3114: URL: https://github.com/apache/solr/pull/3114 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.threeten:threetenbp](https://www.threeten.org/threetenbp) ([source](https://redirect.github.com/ThreeTen/threetenbp)) | dependencies | minor | `1.6.8` -> `1.7.0` | --- ### Release Notes ThreeTen/threetenbp (org.threeten:threetenbp) ### [`v1.7.0`](https://redirect.github.com/ThreeTen/threetenbp/releases/tag/v1.7.0) See the [change notes](https://www.threeten.org/threetenbp/changes-report.html) for more information. ### [`v1.6.9`](https://redirect.github.com/ThreeTen/threetenbp/releases/tag/v1.6.9) See the [change notes](https://www.threeten.org/threetenbp/changes-report.html) for more information. --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17631: Upgrade main to Lucene 10.x [solr]
cpoerschke commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r1928852796
##
solr/core/src/java/org/apache/solr/search/CollapsingQParserPlugin.java:
##
@@ -582,7 +572,6 @@ public float score() {
return score;
}
-@Override
public int docID() {
return docId;
}
Review Comment:
Likely this can be removed, haven't tried it yet though.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Parse authors from git log [solr]
janhoy commented on PR #2423: URL: https://github.com/apache/solr/pull/2423#issuecomment-2612822898 @dsmiley If this script gives any value beyond your existing CHANGES.txt parser, I could merge it. Else I'll close. When we move to logchange, we'll need yet another parser :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17631: Upgrade main to Lucene 10.x [solr]
cpoerschke commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r1928902341
##
solr/core/src/test/org/apache/solr/search/RankQueryTestPlugin.java:
##
@@ -476,7 +476,6 @@ private static class ScoreAndDoc extends Scorable {
this.score = score;
}
- @Override
public int docID() {
return docid;
}
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[PR] remove deprecated KnnVectorField use [solr]
cpoerschke opened a new pull request, #3121: URL: https://github.com/apache/solr/pull/3121 Split out from the Lucene 10.x upgrade #3053 PR. The class was marked experimental in/until Lucene 9.4 and in Lucene 9.5 became deprecated: * https://github.com/apache/lucene/blob/releases/lucene/9.4.2/lucene/core/src/java/org/apache/lucene/document/KnnVectorField.java#L36 * https://github.com/apache/lucene/blob/releases/lucene/9.5.0/lucene/core/src/java/org/apache/lucene/document/KnnVectorField.java#L33 So the removal here can go to both `main` and `branch_9x` branches with no JIRA or solr/CHANGES.txt entry needed in my opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] chore(deps): update prometheus.metrics to v1.3.5 [solr]
solrbot opened a new pull request, #3120: URL: https://github.com/apache/solr/pull/3120 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.prometheus:prometheus-metrics-model](https://redirect.github.com/prometheus/client_java) | dependencies | minor | `1.1.0` -> `1.3.5` | | [io.prometheus:prometheus-metrics-exposition-formats](https://redirect.github.com/prometheus/client_java) | dependencies | minor | `1.1.0` -> `1.3.5` | --- ### Release Notes prometheus/client_java (io.prometheus:prometheus-metrics-model) ### [`v1.3.5`](https://redirect.github.com/prometheus/client_java/releases/tag/v1.3.5) # What's Changed - Bump com.google.protobuf:protobuf-java from 4.28.3 to 4.29.1 by [@dependabot](https://redirect.github.com/dependabot) in [https://github.com/prometheus/client_java/pull/1222](https://redirect.github.com/prometheus/client_java/pull/1222) - Add support for dw-metrics 4.x by [@kingster](https://redirect.github.com/kingster) in [https://github.com/prometheus/client_java/pull/1228](https://redirect.github.com/prometheus/client_java/pull/1228) **Full Changelog**: https://github.com/prometheus/client_java/compare/v1.3.4...v1.3.5 ### [`v1.3.4`](https://redirect.github.com/prometheus/client_java/releases/tag/v1.3.4) # What's Changed - Add instrumentation for Guava & Caffeine to BOM by [@der-eismann](https://redirect.github.com/der-eismann) in [https://github.com/prometheus/client_java/pull/1175](https://redirect.github.com/prometheus/client_java/pull/1175) - fix register part of documentation for caffeine & guava instrumentati… by [@pheyken](https://redirect.github.com/pheyken) in [https://github.com/prometheus/client_java/pull/1203](https://redirect.github.com/prometheus/client_java/pull/1203) - \[prometheus-metrics-instrumentation-caffeine] implement getPrometheus… by [@pheyken](https://redirect.github.com/pheyken) in [https://github.com/prometheus/client_java/pull/1206](https://redirect.github.com/prometheus/client_java/pull/1206) - \[prometheus-metrics-instrumentation-guava] implement getPrometheusNames by [@pheyken](https://redirect.github.com/pheyken) in [https://github.com/prometheus/client_java/pull/1211](https://redirect.github.com/prometheus/client_java/pull/1211) - [make Protobuf optional](https://prometheus.github.io/client_java/exporters/formats/#exclude-protobuf-exposition-format) by [@zeitlinger](https://redirect.github.com/zeitlinger) in [https://github.com/prometheus/client_java/pull/1190](https://redirect.github.com/prometheus/client_java/pull/1190) # New Contributors - [@der-eismann](https://redirect.github.com/der-eismann) made their first contribution in [https://github.com/prometheus/client_java/pull/1175](https://redirect.github.com/prometheus/client_java/pull/1175) **Full Changelog**: https://github.com/prometheus/client_java/compare/v1.3.3...v1.3.4 ### [`v1.3.3`](https://redirect.github.com/prometheus/client_java/releases/tag/v1.3.3) # What's Changed - Bump com.google.protobuf:protobuf-java from 4.28.2 to 4.28.3 by [@dependabot](https://redirect.github.com/dependabot) in [https://github.com/prometheus/client_java/pull/1178](https://redirect.github.com/prometheus/client_java/pull/1178) - Bump io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha from 2.8.0-alpha to 2.9.0-alpha by [@dependabot](https://redirect.github.com/dependabot) in [https://github.com/prometheus/client_java/pull/1164](https://redirect.github.com/prometheus/client_java/pull/1164) - avoid ConcurrentModificationException by [@zeitlinger](https://redirect.github.com/zeitlinger) in [https://github.com/prometheus/client_java/pull/1191](https://redirect.github.com/prometheus/client_java/pull/1191) - revert incompatible api change by [@zeitlinger](https://redirect.github.com/zeitlinger) in [https://github.com/prometheus/client_java/pull/1192](https://redirect.github.com/prometheus/client_java/pull/1192) **Full Changelog**: https://github.com/prometheus/client_java/compare/v1.3.2...v1.3.3 ### [`v1.3.2`](https://redirect.github.com/prometheus/client_java/releases/tag/v1.3.2) # What's Changed - Simple MetricsSnapshot performance change by [@dhoard](https://redirect.github.com/dhoard) in [https://github.com/prometheus/client_java/pull/963](https://redirect.github.com/prometheus/client_java/pull/963) - feat: add bearerToken builder to pushgateway exporter by [@FUSAKLA](https://redirect.github.com/FUSAKLA) in [https://github.com/prometheus/client_java/pull/968](https://redirect.github.com/prometheus/client_java/pull/968) - Fix UnknownDataPointSnapshot constructor by [@mimaison](https://redirect.github.com/mimaison) in [https://github.com/prometheus/client_jav
[PR] chore(deps): update apache.tika to v3 (major) [solr]
solrbot opened a new pull request, #3123: URL: https://github.com/apache/solr/pull/3123 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.apache.tika:tika-parsers](https://tika.apache.org/) ([source](https://redirect.github.com/apache/tika)) | dependencies | major | `1.28.5` -> `3.0.0` | | [org.apache.tika:tika-core](https://tika.apache.org/) ([source](https://redirect.github.com/apache/tika)) | dependencies | major | `1.28.5` -> `3.0.0` | --- ### Release Notes apache/tika (org.apache.tika:tika-parsers) ### [`v3.0.0`](https://redirect.github.com/apache/tika/compare/2.9.2...3.0.0) [Compare Source](https://redirect.github.com/apache/tika/compare/2.9.2...3.0.0) ### [`v2.9.2`](https://redirect.github.com/apache/tika/compare/2.9.1...2.9.2) [Compare Source](https://redirect.github.com/apache/tika/compare/2.9.1...2.9.2) ### [`v2.9.1`](https://redirect.github.com/apache/tika/compare/2.9.0...2.9.1) [Compare Source](https://redirect.github.com/apache/tika/compare/2.9.0...2.9.1) ### [`v2.9.0`](https://redirect.github.com/apache/tika/compare/2.8.0...2.9.0) [Compare Source](https://redirect.github.com/apache/tika/compare/2.8.0...2.9.0) ### [`v2.8.0`](https://redirect.github.com/apache/tika/compare/2.7.0...2.8.0) [Compare Source](https://redirect.github.com/apache/tika/compare/2.7.0...2.8.0) ### [`v2.7.0`](https://redirect.github.com/apache/tika/compare/2.6.0...2.7.0) [Compare Source](https://redirect.github.com/apache/tika/compare/2.6.0...2.7.0) ### [`v2.6.0`](https://redirect.github.com/apache/tika/compare/2.5.0...2.6.0) [Compare Source](https://redirect.github.com/apache/tika/compare/2.5.0...2.6.0) ### [`v2.5.0`](https://redirect.github.com/apache/tika/compare/2.4.1...2.5.0) [Compare Source](https://redirect.github.com/apache/tika/compare/2.4.1...2.5.0) ### [`v2.4.1`](https://redirect.github.com/apache/tika/compare/2.4.0...2.4.1) [Compare Source](https://redirect.github.com/apache/tika/compare/2.4.0...2.4.1) ### [`v2.4.0`](https://redirect.github.com/apache/tika/compare/2.3.0...2.4.0) [Compare Source](https://redirect.github.com/apache/tika/compare/2.3.0...2.4.0) ### [`v2.3.0`](https://redirect.github.com/apache/tika/compare/2.2.1...2.3.0) [Compare Source](https://redirect.github.com/apache/tika/compare/2.2.1...2.3.0) ### [`v2.2.1`](https://redirect.github.com/apache/tika/compare/2.2.0...2.2.1) [Compare Source](https://redirect.github.com/apache/tika/compare/2.2.0...2.2.1) ### [`v2.2.0`](https://redirect.github.com/apache/tika/compare/2.1.0...2.2.0) [Compare Source](https://redirect.github.com/apache/tika/compare/2.1.0...2.2.0) ### [`v2.1.0`](https://redirect.github.com/apache/tika/compare/2.0.0...2.1.0) [Compare Source](https://redirect.github.com/apache/tika/compare/2.0.0...2.1.0) ### [`v2.0.0`](https://redirect.github.com/apache/tika/compare/1.28.5...2.0.0) [Compare Source](https://redirect.github.com/apache/tika/compare/1.28.5...2.0.0) --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] chore(deps): update adobe.testing.s3mock to v3 (major) [solr]
solrbot opened a new pull request, #3122: URL: https://github.com/apache/solr/pull/3122 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.adobe.testing:s3mock-testsupport-common](https://redirect.github.com/adobe/S3Mock) | dependencies | major | `2.17.0` -> `3.12.0` | | [com.adobe.testing:s3mock-junit4](https://redirect.github.com/adobe/S3Mock) | dependencies | major | `2.17.0` -> `3.12.0` | --- ### Release Notes adobe/S3Mock (com.adobe.testing:s3mock-testsupport-common) ### [`v3.12.0`](https://redirect.github.com/adobe/S3Mock/blob/HEAD/CHANGELOG.md#3120) [Compare Source](https://redirect.github.com/adobe/S3Mock/compare/3.11.0...3.12.0) 3.x is JDK17 LTS bytecode compatible, with Docker and JUnit / direct Java integration. - Features and fixes - none - Refactorings - none - Version updates (deliverable dependencies) - Bump aws-v2.version from 2.28.11 to 2.29.29 - Bump aws.version from 1.12.772 to 1.12.779 - Bump kotlin.version from 2.0.20 to 2.1.0 - Bump com.fasterxml.jackson:jackson-bom from 2.18.0 to 2.18.2 - Bump commons-io:commons-io from 2.17.0 to 2.18.0 - Bump testcontainers.version from 1.20.1 to 1.20.4 - Bump alpine from 3.20.3 to 3.21.0 in /docker - Version updates (build dependencies) - Bump io.fabric8:docker-maven-plugin from 0.45.0 to 0.45.1 - Bump com.puppycrawl.tools:checkstyle from 10.18.1 to 10.20.2 - Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.10.0 to 3.11.2 - Bump org.apache.maven.plugins:maven-surefire-plugin from 3.5.0 to 3.5.2 - Bump org.apache.maven.plugins:maven-failsafe-plugin from 3.5.0 to 3.5.2 - Bump org.apache.maven.plugins:maven-dependency-plugin from 3.8.0 to 3.8.1 - Bump org.apache.maven.plugins:maven-checkstyle-plugin from 3.5.0 to 3.6.0 - Bump org.codehaus.mojo:exec-maven-plugin from 3.4.1 to 3.5.0 - Bump actions/dependency-review-action from 4.3.4 to 4.5.0 - Bump actions/setup-java from 4.4.0 to 4.5.0 - Bump actions/upload-artifact from 3.1.0 to 4.4.3 - Bump actions/checkout from 4.2.0 to 4.2.2 - Bump github/codeql-action from 3.26.9 to 3.27.6 - Bump advanced-security/maven-dependency-submission-action from 3.0.3 to 4.1.1 - Bump step-security/harden-runner from 2.10.1 to 2.10.2 ### [`v3.11.0`](https://redirect.github.com/adobe/S3Mock/blob/HEAD/CHANGELOG.md#3110) [Compare Source](https://redirect.github.com/adobe/S3Mock/compare/3.10.3...3.11.0) 3.x is JDK17 LTS bytecode compatible, with Docker and JUnit / direct Java integration. - Features and fixes - none - Version updates (deliverable dependencies) - Bump aws-v2.version from 2.26.25 to 2.28.11 - Bump aws.version from 1.12.765 to 1.12.772 - Bump spring-boot.version from 3.3.2 to 3.3.3 - Bump commons-io:commons-io from 2.16.1 to 2.17.0 - Bump com.fasterxml.jackson:jackson-bom from 2.17.2 to 2.18.0 - Bump testcontainers.version from 1.20.0 to 1.20.1 - Bump alpine from 3.20.2 to 3.20.3 in /docker - Bump kotlin.version from 2.0.0 to 2.0.20 ### [`v3.10.3`](https://redirect.github.com/adobe/S3Mock/blob/HEAD/CHANGELOG.md#3103) [Compare Source](https://redirect.github.com/adobe/S3Mock/compare/3.10.2...3.10.3) Test release that incremented the patch version number. Please refer / update to version 3.11.0, thanks. ### [`v3.10.2`](https://redirect.github.com/adobe/S3Mock/blob/HEAD/CHANGELOG.md#3102) [Compare Source](https://redirect.github.com/adobe/S3Mock/compare/3.10.1...3.10.2) 3.x is JDK17 LTS bytecode compatible, with Docker and JUnit / direct Java integration. - Features and fixes - Let CopyObject overwrite store headers (fixes [#2005](https://redirect.github.com/adobe/S3Mock/issues/2005)) - Version updates (build dependencies) - Bump org.apache.maven.plugins:maven-deploy-plugin from 3.1.2 to 3.1.3 - Bump org.apache.maven.plugins:maven-dependency-plugin from 3.7.1 to 3.8.0 - Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.8.0 to 3.10.0 - Bump org.apache.maven.plugins:maven-gpg-plugin from 3.2.6 to 3.2.7 - Bump org.apache.maven.plugins:maven-checkstyle-plugin from 3.4.0 to 3.5.0 - Bump license-maven-plugin-git.version from 4.5 to 4.6 - Bump com.puppycrawl.tools:checkstyle from 10.17.0 to 10.18.1 - Bump actions/checkout from 4.1.7 to 4.2.0 - Bump github/codeql-action from 3.26.7 to 3.26.9 - Bump actions/setup-java from 4.3.0 to 4.4.0 ### [`v3.10.1`](https://redirect.github.com/adobe/S3Mock/blob/HEAD/CHANGELOG.md#3101) [Compare Source](https://
Re: [PR] chore(deps): update adobe.testing.s3mock to v3 (major) [solr]
malliaridis commented on PR #3122: URL: https://github.com/apache/solr/pull/3122#issuecomment-2612938855 See https://github.com/apache/solr/pull/3002#issuecomment-260822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17631: Upgrade main to Lucene 10.x [solr]
cpoerschke commented on code in PR #3053: URL: https://github.com/apache/solr/pull/3053#discussion_r1928419378 ## solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java: ## @@ -22,7 +22,7 @@ import java.io.UncheckedIOException; import org.apache.lucene.search.BooleanClause; import org.apache.lucene.search.BooleanQuery; -import org.apache.lucene.search.DocValuesFieldExistsQuery; +import org.apache.lucene.search.FieldExistsQuery; Review Comment: #2632 (draft) was/is about just removing deprecated `(DocValues,Norms)FieldExistsQuery` use (without Lucene dependency change). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] chore(deps): update dependency org.hsqldb:hsqldb to v2.7.4 [solr]
janhoy merged PR #3068: URL: https://github.com/apache/solr/pull/3068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-13360) StringIndexOutOfBoundsException: String index out of range: -3
[
https://issues.apache.org/jira/browse/SOLR-13360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916790#comment-17916790
]
Alex Deparvu commented on SOLR-13360:
-
Just trying to make some progress here, I was able to add a PR with some
minimal tests that reproduce the issue https://github.com/apache/solr/pull/3112
There is no proposed solution yet because I wanted to discuss options here
first. but I did leave some TODO notes where I think changes could do.
just a disclaimer I don't really have a lot of knowledge in this area so I did
spend some time trying to understand what the issue is so some of this might
not be 100% correct. also thanks to the wealth of details on this ticket I was
able to come up with a relatively simple test (see
SpellCheckCollatorWithSynonymTest) but also a more lower level unit test that
unpacks all the complexity of setting up a Solr instance with correct field
types and all (see SpellCheckCollatorCollationOnlyTest).
To me this looks like an overlapping interval problem. given a sufficiently
complicated analyzer, the tokens can have a lot of overlapping start/end
indexes and this can cause chaos on the collation code which seems to assume
tokens come in with strictly increasing start indexes. The twist to the PR that
was posted above is that not only can start index repeat BUT you can have
tokens inside other tokens which is a gap that also needs to be fixed. see the
unit test here
https://github.com/apache/solr/pull/3112/files#diff-a85c16ca4fe0d8747a0c76e21460c7ec5ede698a4a83eed47e39cdc197af0c48R110-R114
Not really sure what the solution is, I am leaning towards a cleanup of the
correction tokens (basically remove any overlapping intervals): sort by start
index first, remove anything that is inside the previous token's interval (this
will favor the first token over the others and I am not sure it is a good
approach).
example
- search `panthera pardus`
- synonim definition `panthera pardus, leopard|0.6`
- corrections are: leopard (0, 15), 0(0,15), 6(0,15), panthera(0, 8), pardu(9,
15)
- note the `0` and `6` tokens were generated from the syonym definition so
even if a possible bug - I am leaving the example in because it shows what can
happen
More open questions
1. I added a log capturing the data in case of a future
StringIndexOutOfBoundsException. curious what people think, is this useful or
not. I can remove it if it is too intrusive or can leak sensitive data in the
logs.
2. I can put this behind a system property (on by default) so if anything
happens this can be reverted to previous behavior.
3. there is some issue with boosts in synonyms. I tried documenting here
https://github.com/apache/solr/pull/3112/files#diff-8a4f8ed7cdb05bd73fcaaa4b688a166db1c28ab32eca3179ec19ec43138384ccR41
4. I think there might be an issue with the whitespace correction. I move this
code into a dedicated metod but did not have time to add any tests.
> StringIndexOutOfBoundsException: String index out of range: -3
> --
>
> Key: SOLR-13360
> URL: https://issues.apache.org/jira/browse/SOLR-13360
> Project: Solr
> Issue Type: Bug
>Affects Versions: 7.2.1
> Environment: Solr 7.2.1 - SAP Hybris 6.7.0.8
>Reporter: Ahmed Ghoneim
>Priority: Critical
> Labels: pull-request-available
> Attachments: managed-schema, managed-schema, resources.json,
> solr-config.zip
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> *{color:#ff}I cannot execute the following query:{color}*
> {noformat}
> http://localhost:8983/solr/master_Project_Product_flip/suggest?q=duotop&spellcheck.q=duotop&qt=/suggest&spellcheck.dictionary=de&spellcheck.collate=true{noformat}
> 4/1/2019, 1:16:07 PM ERROR true RequestHandlerBase
> java.lang.StringIndexOutOfBoundsException: String index out of range: -3
> {code:java}
> java.lang.StringIndexOutOfBoundsException: String index out of range: -3
> at
> java.lang.AbstractStringBuilder.replace(AbstractStringBuilder.java:851)
> at java.lang.StringBuilder.replace(StringBuilder.java:262)
> at
> org.apache.solr.spelling.SpellCheckCollator.getCollation(SpellCheckCollator.java:252)
> at
> org.apache.solr.spelling.SpellCheckCollator.collate(SpellCheckCollator.java:94)
> at
> org.apache.solr.handler.component.SpellCheckComponent.addCollationsToResponse(SpellCheckComponent.java:297)
> at
> org.apache.solr.handler.component.SpellCheckComponent.process(SpellCheckComponent.java:209)
> at
> org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:295)
> at
> org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:177)
> at org.apache.solr.core.SolrCore.execute(SolrCore.java:2503)
>
Re: [PR] chore(deps): update dependency org.glassfish.jersey.containers:jersey-container-jetty-http to v3 [solr]
solrbot commented on PR #3137: URL: https://github.com/apache/solr/pull/3137#issuecomment-2613682510 ### ⚠️ Artifact update problem Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, including artifacts, only when one of the following happens: - any of the package files in this branch needs updating, or - the branch becomes conflicted, or - you click the rebase/retry checkbox if found above, or - you rename this PR's title to start with "rebase!" to trigger it manually The artifact failure details are included below: # File name: undefined ``` Command failed: ./gradlew updateLicenses Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. /tmp/renovate/repos/github/apache/solr/solr/core/src/java/org/apache/solr/handler/admin/ShowFileRequestHandler.java:103: error: cannot find symbol KNOWN_MIME_TYPES = new HashSet<>(MimeTypes.getKnownMimeTypes()); ^ symbol: method getKnownMimeTypes() location: class MimeTypes Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. 1 error FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':solr:core:compileJava'. > Compilation failed; see the compiler error output for details. * Try: > Run with --info option to get more log output. BUILD FAILED in 31s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] chore(deps): update dependency org.owasp.dependencycheck to v12 [solr]
solrbot opened a new pull request, #3138: URL: https://github.com/apache/solr/pull/3138 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | org.owasp.dependencycheck | plugin | major | `9.0.8` -> `12.0.1` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] chore(deps): update google.protobuf to v4 (major) [solr]
solrbot opened a new pull request, #3139: URL: https://github.com/apache/solr/pull/3139 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.google.protobuf:protobuf-java-util](https://developers.google.com/protocol-buffers/) ([source](https://redirect.github.com/protocolbuffers/protobuf)) | dependencies | major | `3.25.3` -> `4.29.3` | | [com.google.protobuf:protobuf-java](https://developers.google.com/protocol-buffers/) ([source](https://redirect.github.com/protocolbuffers/protobuf)) | dependencies | major | `3.25.3` -> `4.29.3` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] add contributor to 9.8 release announcement (#139) [solr-site]
anshumg opened a new pull request, #140: URL: https://github.com/apache/solr-site/pull/140 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] chore(deps): update dependency org.glassfish.jersey.containers:jersey-container-jetty-http to v3 [solr]
solrbot opened a new pull request, #3137: URL: https://github.com/apache/solr/pull/3137 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.glassfish.jersey.containers:jersey-container-jetty-http](https://projects.eclipse.org/projects/ee4j.jersey) ([source](https://redirect.github.com/eclipse-ee4j/jersey)) | dependencies | major | `2.39.1` -> `3.1.10` | --- ### Release Notes eclipse-ee4j/jersey (org.glassfish.jersey.containers:jersey-container-jetty-http) ### [`v3.1.10`](https://redirect.github.com/eclipse-ee4j/jersey/releases/tag/3.1.10) [Compare Source](https://redirect.github.com/eclipse-ee4j/jersey/compare/3.1.9...3.1.10) # What's Changed - Keep only 2 builds with artifacts and disable concurrent builds by [@fredg02](https://redirect.github.com/fredg02) in [https://github.com/eclipse-ee4j/jersey/pull/5752](https://redirect.github.com/eclipse-ee4j/jersey/pull/5752) - test(flaky): fix paramter type assert in testBothAnnotatedConstructor test case by [@varsha-cl](https://redirect.github.com/varsha-cl) in [https://github.com/eclipse-ee4j/jersey/pull/5751](https://redirect.github.com/eclipse-ee4j/jersey/pull/5751) - test(flaky): Sorting headers for deterministic order by [@mumbler6](https://redirect.github.com/mumbler6) in [https://github.com/eclipse-ee4j/jersey/pull/5754](https://redirect.github.com/eclipse-ee4j/jersey/pull/5754) - Netty connector hang up after repeated buffer overflow errors when writing data [#5753](https://redirect.github.com/eclipse-ee4j/jersey/issues/5753) by [@jbescos](https://redirect.github.com/jbescos) in [https://github.com/eclipse-ee4j/jersey/pull/5755](https://redirect.github.com/eclipse-ee4j/jersey/pull/5755) - Adopt ASM 9.7.1 (JDK 24) by [@jansupol](https://redirect.github.com/jansupol) in [https://github.com/eclipse-ee4j/jersey/pull/5760](https://redirect.github.com/eclipse-ee4j/jersey/pull/5760) - Bump commons-io:commons-io from 2.11.0 to 2.14.0 in /tools/jersey-release-notes-maven-plugin by [@dependabot](https://redirect.github.com/dependabot) in [https://github.com/eclipse-ee4j/jersey/pull/5758](https://redirect.github.com/eclipse-ee4j/jersey/pull/5758) - Added test for JerseyChunkedInputStreamClose by [@jansupol](https://redirect.github.com/jansupol) in [https://github.com/eclipse-ee4j/jersey/pull/5759](https://redirect.github.com/eclipse-ee4j/jersey/pull/5759) - Adopt Jackson 2.18.0 by [@jansupol](https://redirect.github.com/jansupol) in [https://github.com/eclipse-ee4j/jersey/pull/5761](https://redirect.github.com/eclipse-ee4j/jersey/pull/5761) - merge of the actual 2.x into the 3.0 by [@senivam](https://redirect.github.com/senivam) in [https://github.com/eclipse-ee4j/jersey/pull/5762](https://redirect.github.com/eclipse-ee4j/jersey/pull/5762) - Technical merge of released branch 3.0.16-BRANCH by [@jersey-bot](https://redirect.github.com/jersey-bot) in [https://github.com/eclipse-ee4j/jersey/pull/5770](https://redirect.github.com/eclipse-ee4j/jersey/pull/5770) - merge of the actual 3.0 into the 3.1 by [@senivam](https://redirect.github.com/senivam) in [https://github.com/eclipse-ee4j/jersey/pull/5769](https://redirect.github.com/eclipse-ee4j/jersey/pull/5769) - Fix flaky 2 by [@mumbler6](https://redirect.github.com/mumbler6) in [https://github.com/eclipse-ee4j/jersey/pull/5775](https://redirect.github.com/eclipse-ee4j/jersey/pull/5775) - Technical merge of released branch 3.1.9-BRANCH by [@jersey-bot](https://redirect.github.com/jersey-bot) in [https://github.com/eclipse-ee4j/jersey/pull/5771](https://redirect.github.com/eclipse-ee4j/jersey/pull/5771) - Fixed typo: Class>?< should be Class\ by [@mkarg](https://redirect.github.com/mkarg) in [https://github.com/eclipse-ee4j/jersey/pull/5785](https://redirect.github.com/eclipse-ee4j/jersey/pull/5785) - Broken pipe Exception from Jersey layer while closing response in ServerRuntime.writeResponse() not handled or re-thrown [#5783](https://redirect.github.com/eclipse-ee4j/jersey/issues/5783) by [@jbescos](https://redirect.github.com/jbescos) in [https://github.com/eclipse-ee4j/jersey/pull/5786](https://redirect.github.com/eclipse-ee4j/jersey/pull/5786) - \[2.x] ParamConverterProvider constructors are now protected to allow extensibility by [@Spikhalskiy](https://redirect.github.com/Spikhalskiy) in [https://github.com/eclipse-ee4j/jersey/pull/5792](https://redirect.github.com/eclipse-ee4j/jersey/pull/5792) - Wrapping all methods of the EntityInputStream by [@senivam](https://redirect.github.com/senivam) in [https://github.com/eclipse-ee4j/jersey/pull/5788](https://redirect.github.com/eclipse-ee4j/jersey/pull/5788) - Jersey 3.1.9: java.lang.NoSuchMethodException: jakarta.inject.Inject.value() [#5782](https://redirect.github.com/eclipse-ee4j/jersey/is
Re: [PR] SOLR-17378: Add a RequestHandler metric for "number of outstanding concurrent requests" [solr]
github-actions[bot] commented on PR #2591: URL: https://github.com/apache/solr/pull/2591#issuecomment-2613624553 This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] add contributor to 9.8 release announcement (#139) [solr-site]
anshumg merged PR #140: URL: https://github.com/apache/solr-site/pull/140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] add contributor to 9.8 release announcement [solr-site]
anshumg merged PR #139: URL: https://github.com/apache/solr-site/pull/139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17477: Support custom aggregates in plugin code [solr]
github-actions[bot] commented on PR #2742: URL: https://github.com/apache/solr/pull/2742#issuecomment-2613624519 This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the d...@solr.apache.org mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] remove deprecated (DocValues,Norms)FieldExistsQuery use [solr]
cpoerschke commented on code in PR #2632:
URL: https://github.com/apache/solr/pull/2632#discussion_r1928413086
##
solr/core/src/java/org/apache/solr/search/facet/MissingAgg.java:
##
@@ -45,7 +45,7 @@ public SlotAcc createSlotAcc(FacetContext fcontext, long
numDocs, int numSlots)
if (sf.multiValued() || sf.getType().multiValuedFieldCache()) {
Query query = null;
if (sf.hasDocValues()) {
- query = new DocValuesFieldExistsQuery(sf.getName());
+ query = new FieldExistsQuery(sf.getName());
Review Comment:
> I suspect this code pre-dated FieldType.getExistenceQuery -- just call
that.
```suggestion
query = sf.getType().getExistenceQuery(null, sf);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] chore(deps): update bouncycastle to v1.80 [solr]
janhoy commented on PR #3081:
URL: https://github.com/apache/solr/pull/3081#issuecomment-2612173602
```
* What went wrong:
Could not determine the dependencies of task
':solr:modules:jwt-auth:collectJarInfos'.
> Could not resolve all dependencies for configuration
':solr:modules:jwt-auth:jarValidation'.
> Could not resolve org.bouncycastle:bcpkix-jdk18on:1.80.
Required by:
project :solr:modules:jwt-auth
project :solr:modules:jwt-auth > project :platform
> Cannot find a version of 'org.bouncycastle:bcpkix-jdk18on' that
satisfies the version constraints:
Dependency path 'org.apache.solr:jwt-auth:10.0.0-SNAPSHOT' -->
'org.bouncycastle:bcpkix-jdk18on:1.80'
Constraint path 'org.apache.solr:jwt-auth:10.0.0-SNAPSHOT' -->
'org.bouncycastle:bcpkix-jdk18on:{strictly 1.78.1}' because of the following
reason: dependency was locked to version '1.78.1'
Constraint path 'org.apache.solr:jwt-auth:10.0.0-SNAPSHOT' -->
'org.apache:platform:10.0.0-SNAPSHOT' (runtimeElements) -->
'org.bouncycastle:bcpkix-jdk18on:1.80'
> Could not resolve org.bouncycastle:bcprov-jdk18on:1.80.
Required by:
project :solr:modules:jwt-auth
project :solr:modules:jwt-auth > project :platform
> Cannot find a version of 'org.bouncycastle:bcprov-jdk18on' that
satisfies the version constraints:
Dependency path 'org.apache.solr:jwt-auth:10.0.0-SNAPSHOT' -->
'org.bouncycastle:bcprov-jdk18on:1.80'
Constraint path 'org.apache.solr:jwt-auth:10.0.0-SNAPSHOT' -->
'org.bouncycastle:bcprov-jdk18on:{strictly 1.78.1}' because of the following
reason: dependency was locked to version '1.78.1'
Constraint path 'org.apache.solr:jwt-auth:10.0.0-SNAPSHOT' -->
'org.apache:platform:10.0.0-SNAPSHOT' (runtimeElements) -->
'org.bouncycastle:bcprov-jdk18on:1.80'
Dependency path 'org.apache.solr:jwt-auth:10.0.0-SNAPSHOT' -->
'org.bouncycastle:bcpkix-jdk18on:1.80' (runtime) -->
'org.bouncycastle:bcutil-jdk18on:1.78.1' (runtime) -->
'org.bouncycastle:bcprov-jdk18on:1.78.1'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[PR] update slf4j to v2.0.16 (branch_9x) [solr]
janhoy opened a new pull request, #3101: URL: https://github.com/apache/solr/pull/3101 Cherry-picked from main 6e5c4c463e869020c984c9390249512285caf515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] chore(deps): update slf4j to v2.0.16 [solr]
janhoy merged PR #3076: URL: https://github.com/apache/solr/pull/3076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17631: Upgrade main to Lucene 10.x [solr]
cpoerschke commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r1928384222
##
solr/core/src/java/org/apache/solr/core/backup/repository/BackupRepository.java:
##
@@ -216,7 +216,7 @@ default void copyIndexFileFrom(
Directory sourceDir, String sourceFileName, Directory destDir, String
destFileName)
throws IOException {
boolean success = false;
-try (ChecksumIndexInput is = sourceDir.openChecksumInput(sourceFileName,
IOContext.READONCE);
+try (ChecksumIndexInput is = sourceDir.openChecksumInput(sourceFileName);
Review Comment:
links:
*
https://github.com/apache/lucene/blob/releases/lucene/9.12.1/lucene/core/src/java/org/apache/lucene/store/Directory.java#L155-L157
*
https://github.com/apache/lucene/blob/releases/lucene/10.1.0/lucene/core/src/java/org/apache/lucene/store/Directory.java#L155-L157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17631: Upgrade main to Lucene 10.x [solr]
cpoerschke commented on code in PR #3053:
URL: https://github.com/apache/solr/pull/3053#discussion_r1928398006
##
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java:
##
@@ -1755,7 +1755,6 @@ protected static class ScoreAndDoc extends Scorable {
this.score = score;
}
-@Override
public int docID() {
return docid;
}
Review Comment:
Maybe this can be removed, haven't tried it yet though.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17626: add RawTFSimilarityFactory class [solr]
cpoerschke merged PR #2715: URL: https://github.com/apache/solr/pull/2715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] remove deprecated (DocValues,Norms)FieldExistsQuery use [solr]
cpoerschke commented on PR #2632: URL: https://github.com/apache/solr/pull/2632#issuecomment-2612218867 Added @chatman and @noblepaul w.r.t. overlap with the #3053 upgrade to Lucene 10. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17626) add RawTFSimilarityFactory class
[ https://issues.apache.org/jira/browse/SOLR-17626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17626: -- Labels: pull-request-available (was: ) > add RawTFSimilarityFactory class > > > Key: SOLR-17626 > URL: https://issues.apache.org/jira/browse/SOLR-17626 > Project: Solr > Issue Type: Task >Reporter: Christine Poerschke >Assignee: Christine Poerschke >Priority: Minor > Labels: pull-request-available > Fix For: main (10.0), 9.9 > > Time Spent: 10m > Remaining Estimate: 0h > > Factory class for the RawTFSimilarity added in Lucene 9.12 version. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17378: Add a RequestHandler metric for "number of outstanding concurrent requests" [solr]
github-actions[bot] closed pull request #2591: SOLR-17378: Add a RequestHandler metric for "number of outstanding concurrent requests" URL: https://github.com/apache/solr/pull/2591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] add contributor to 9.8 release announcement [solr-site]
anshumg opened a new pull request, #139: URL: https://github.com/apache/solr-site/pull/139 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] chore(deps): update dependency org.glassfish.jaxb:jaxb-runtime to v4 [solr]
solrbot opened a new pull request, #3136: URL: https://github.com/apache/solr/pull/3136 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.glassfish.jaxb:jaxb-runtime](https://eclipse-ee4j.github.io/jaxb-ri/) ([source](https://redirect.github.com/eclipse-ee4j/jaxb-ri)) | dependencies | major | `2.3.8` -> `4.0.5` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] chore(deps): update dependency org.apache.opennlp:opennlp-tools to v2 [solr]
solrbot opened a new pull request, #3134: URL: https://github.com/apache/solr/pull/3134 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.apache.opennlp:opennlp-tools](https://www.apache.org/) ([source](https://redirect.github.com/apache/opennlp)) | dependencies | major | `1.9.4` -> `2.5.3` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] chore(deps): update dependency org.eclipse.jgit:org.eclipse.jgit to v7 [solr]
solrbot opened a new pull request, #3135: URL: https://github.com/apache/solr/pull/3135 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.eclipse.jgit:org.eclipse.jgit](https://eclipse.gerrithub.io/plugins/gitiles/eclipse-jgit/jgit) | dependencies | major | `6.7.0.202309050840-r` -> `7.1.0.202411261347-r` | --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/solrbot/renovate-github-action) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
