Re: [PR] SOLR-17589 First use of PUT/POST request with HttpJdkSolrClient generates error log entry on solr server due to initial HEAD request [solr]
Paul-Blanchaert commented on PR #2926: URL: https://github.com/apache/solr/pull/2926#issuecomment-2563580128 Thanks for the encouragement. Can you help me understand what you're asking with "an assert somewhere"? In order to be able to test the solr server exception, I'll need to change the scope of the function to "collect" the http statuscode (400 is returned in the case of the solr server exception). Currently, the http response (and status) is ignored (headSucceeded = true when no exception is thrown by the jdk http client; this probably goes for any 4xx/5xx statusses; but I didn't verify that). Should I change the function to set headSucceeded to false when http statuscode <> 200? That way, we're able to capture the exception prior to the change of this PR and we can build a unit test to validate the "enhanced" function. Is that what you had in mind? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-15751) Create a v2 equivalent for 'COLSTATUS'
[
https://issues.apache.org/jira/browse/SOLR-15751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17908457#comment-17908457
]
ASF subversion and git services commented on SOLR-15751:
Commit c058ea5dac37fbcc54f2944ce3d6fad2bded86fc in solr's branch
refs/heads/main from Jason Gerlowski
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=c058ea5dac3 ]
SOLR-15751: Add v2 COLSTATUS and "segments" APIs (#2912)
COLSTATUS functionality is offered at `GET /api/collections/collName`, and
segment
functionality at `GET /api/cores/coreName/segments`.
This also converts the APIs to JAX-RS, and creates generated SolrRequest
bindings for
these APIs as a result.
> Create a v2 equivalent for 'COLSTATUS'
> --
>
> Key: SOLR-15751
> URL: https://issues.apache.org/jira/browse/SOLR-15751
> Project: Solr
> Issue Type: Sub-task
> Components: v2 API
>Reporter: Jason Gerlowski
>Assignee: Jason Gerlowski
>Priority: Major
> Labels: V2, newdev, pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Solr's 'COLSTATUS' command under the v1 \{{/solr/admin/collections}} endpoint
> has no full v2 equivalent. The \{{/v2/collections/}} API has
> similar (identical?) output as a vanilla COLSTATUS request, but COLSTATUS can
> also return detailed index information that \{{/v2/collections/}}
> cannot expose. We should add parameters to this v2 API to expose similar data
> to achieve parity with the v1 COLSTATUS API.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-15751: Modify v2 `GET /collections/collName` to support full ColStatus response [solr]
gerlowskija commented on PR #2912: URL: https://github.com/apache/solr/pull/2912#issuecomment-2563629054 Alright, thanks all for the feedback. Merged and backported! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-15751: Modify v2 `GET /collections/collName` to support full ColStatus response [solr]
gerlowskija merged PR #2912: URL: https://github.com/apache/solr/pull/2912 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17589 First use of PUT/POST request with HttpJdkSolrClient generates error log entry on solr server due to initial HEAD request [solr]
jdyer1 commented on PR #2926: URL: https://github.com/apache/solr/pull/2926#issuecomment-2563894874 Here is an approach that won't need any change to the client itself. 1. See `DebugServlet.java' method 'doHead'. Here it records the request body in a variable named `requestBody`, but unfortunately any subsequent POST request will overwrite it before the test can examine it. `DebugServlet` will need to keep the HEAD request body in a separate variable. 2. See `HttpJdkSolrClientTest.java' method `assertNoHeadRequestWithSsl`. Here it asserts that if the randomized test runner configured an 'https' connection, then the HEAD request should not be fired. We can additionally assert that in the other case, whenever the HEAD request is fired, that it contains a body, by looking at the new variable created in `DebugServlet`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-15751) Create a v2 equivalent for 'COLSTATUS'
[
https://issues.apache.org/jira/browse/SOLR-15751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17908477#comment-17908477
]
ASF subversion and git services commented on SOLR-15751:
Commit cb51ffb062a24aa273d359e1b9861ba72f344bdd in solr's branch
refs/heads/branch_9x from Jason Gerlowski
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=cb51ffb062a ]
SOLR-15751: Add v2 COLSTATUS and "segments" APIs (#2912)
COLSTATUS functionality is offered at `GET /api/collections/collName`, and
segment
functionality at `GET /api/cores/coreName/segments`.
This also converts the APIs to JAX-RS, and creates generated SolrRequest
bindings for
these APIs as a result.
> Create a v2 equivalent for 'COLSTATUS'
> --
>
> Key: SOLR-15751
> URL: https://issues.apache.org/jira/browse/SOLR-15751
> Project: Solr
> Issue Type: Sub-task
> Components: v2 API
>Reporter: Jason Gerlowski
>Assignee: Jason Gerlowski
>Priority: Major
> Labels: V2, newdev, pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Solr's 'COLSTATUS' command under the v1 \{{/solr/admin/collections}} endpoint
> has no full v2 equivalent. The \{{/v2/collections/}} API has
> similar (identical?) output as a vanilla COLSTATUS request, but COLSTATUS can
> also return detailed index information that \{{/v2/collections/}}
> cannot expose. We should add parameters to this v2 API to expose similar data
> to achieve parity with the v1 COLSTATUS API.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Created] (SOLR-17611) SolrJ should pass Solr version in the user-agent
David Smiley created SOLR-17611: --- Summary: SolrJ should pass Solr version in the user-agent Key: SOLR-17611 URL: https://issues.apache.org/jira/browse/SOLR-17611 Project: Solr Issue Type: Improvement Components: SolrJ Reporter: David Smiley Assignee: David Smiley SolrJ clients should pass an HTTP User-Agent header that includes the version of Solr. This way, the Solr server may vary its behavior or response format based on the version. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Optimize dependency resolution via platform module [solr]
dsmiley commented on PR #2915: URL: https://github.com/apache/solr/pull/2915#issuecomment-2564228811 Ah; thanks for making the important distinction between constraints and dependencies. Your Gradle knowledge is impressive! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] SOLR-17611 SolrJ User-Agent, pass Solr version [solr]
dsmiley opened a new pull request, #2927: URL: https://github.com/apache/solr/pull/2927 https://issues.apache.org/jira/browse/SOLR-17611 (read this for context) No tests. I suppose the best test would be something in the smoke test which is at release time where we definitely have the "specification version" in the JAR manifest. Once we have something that detects the version to behave differently, we will need it to work in a unit test environment too, where we want the latest behavior but don't have a spec version in a manifest. Maybe the PR should include something in SolrVersion to parse it as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17611) SolrJ should pass Solr version in the user-agent
[ https://issues.apache.org/jira/browse/SOLR-17611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17611: -- Labels: pull-request-available (was: ) > SolrJ should pass Solr version in the user-agent > > > Key: SOLR-17611 > URL: https://issues.apache.org/jira/browse/SOLR-17611 > Project: Solr > Issue Type: Improvement > Components: SolrJ >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > SolrJ clients should pass an HTTP User-Agent header that includes the version > of Solr. This way, the Solr server may vary its behavior or response format > based on the version. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17321) Bump minimum required Java version to 21
[ https://issues.apache.org/jira/browse/SOLR-17321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17908550#comment-17908550 ] ASF subversion and git services commented on SOLR-17321: Commit 02cdf9e05dd4ff467fd456a0e3a3a3cedcfa0e0c in solr's branch refs/heads/main from David Smiley [ https://gitbox.apache.org/repos/asf?p=solr.git;h=02cdf9e05dd ] SOLR-17321 JDK 21: delete obsolete checks mostly in build (#2868) * Build checks * SSL checks not needed * Lookup.ensureInitialized > Bump minimum required Java version to 21 > > > Key: SOLR-17321 > URL: https://issues.apache.org/jira/browse/SOLR-17321 > Project: Solr > Issue Type: Task >Reporter: Sanjay Dutt >Priority: Major > Labels: pull-request-available > Time Spent: 11h 50m > Remaining Estimate: 0h > > We are upgrading the minimum Java version for Solr main branch to 21. > However, at the same, It has been suggested to be not so aggressive with > SolrJ (and thus solr-api, a dependency) Java version – setting it to 17. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17321 More jdk upgrade [solr]
dsmiley merged PR #2868: URL: https://github.com/apache/solr/pull/2868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Deprecate MapWriter.append [solr]
dsmiley merged PR #2919: URL: https://github.com/apache/solr/pull/2919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SolrTestCase now supports @LogLevel [solr]
dsmiley commented on PR #2869: URL: https://github.com/apache/solr/pull/2869#issuecomment-2564185125 I tweaked the tests based on feedback. Looking to merge this soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
