Re: [PR] SOLR-17579: Refactoring suggested by IDE in ReplicationHandler and tests [solr]
epugh merged PR #2893: URL: https://github.com/apache/solr/pull/2893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17579) Remove unused methods in IndexFetcher and ReplicationHandler
[ https://issues.apache.org/jira/browse/SOLR-17579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905692#comment-17905692 ] ASF subversion and git services commented on SOLR-17579: Commit 024f9737178624065d0ceada4d3b9fd5aac80341 in solr's branch refs/heads/main from Eric Pugh [ https://gitbox.apache.org/repos/asf?p=solr.git;h=024f9737178 ] SOLR-17579: Refactoring suggested by IDE in ReplicationHandler and tests (#2893) * Refactoring suggested by IDE. * Typos, some dead methods and dead variables. > Remove unused methods in IndexFetcher and ReplicationHandler > > > Key: SOLR-17579 > URL: https://issues.apache.org/jira/browse/SOLR-17579 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: replication (java) >Affects Versions: 9.8 >Reporter: Eric Pugh >Assignee: Eric Pugh >Priority: Minor > Labels: pull-request-available > Attachments: f7418bcb82a9668128c7bf72c1e25bbe31026fd9.patch > > Time Spent: 20m > Remaining Estimate: 0h > > There are dead methods and typos and unused exceptions! > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17595) CLI examples are broken on Windows
[ https://issues.apache.org/jira/browse/SOLR-17595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905718#comment-17905718 ] Christos Malliaridis commented on SOLR-17595: - I'll have a look later today and try to fix it. I hope it's an easy fix. :) > CLI examples are broken on Windows > -- > > Key: SOLR-17595 > URL: https://issues.apache.org/jira/browse/SOLR-17595 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: cli, examples, SolrCLI >Affects Versions: 9.7 >Reporter: Christos Malliaridis >Priority: Blocker > Labels: cli > Fix For: 9.8 > > Attachments: console-output-9.7.txt, console-output.txt > > > When trying to run the examples on Windows, it fails with an unspecified > error. I have attached the output for investigation. Bug is present in latest > changes. > A previous state was reporting more details about a potential cause. It was > mentioning the "*/xml" in in RunExampleTool.java, but that may not be anymore > the issue for the current failure (but could be a lead for the error). > The error is slightly different in the branches main, 9x and 9.8. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17548: Switch all public Java APIs from File to Path [solr]
epugh commented on PR #2907: URL: https://github.com/apache/solr/pull/2907#issuecomment-2543122319 Cool... I'll leave it open for a few days to see what else crops up.. Ping me if we don't merge it by mid week! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-7962) Passing additional arguments to solr.cmd using "-a" does not work on Windows
[ https://issues.apache.org/jira/browse/SOLR-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905719#comment-17905719 ] Rahul Goswami commented on SOLR-7962: - I’ll try this and report back > Passing additional arguments to solr.cmd using "-a" does not work on Windows > > > Key: SOLR-7962 > URL: https://issues.apache.org/jira/browse/SOLR-7962 > Project: Solr > Issue Type: Bug >Affects Versions: 5.3 >Reporter: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-7962) Passing additional arguments to solr.cmd using "-a" does not work on Windows
[ https://issues.apache.org/jira/browse/SOLR-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905705#comment-17905705 ] Eric Pugh commented on SOLR-7962: - I pinged Rahul Goswami to take a look since we had looked at other windows issues.. > Passing additional arguments to solr.cmd using "-a" does not work on Windows > > > Key: SOLR-7962 > URL: https://issues.apache.org/jira/browse/SOLR-7962 > Project: Solr > Issue Type: Bug >Affects Versions: 5.3 >Reporter: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-15441) Solr.cmd fails when SOLR_LOGS_DIR contains a space
[
https://issues.apache.org/jira/browse/SOLR-15441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905706#comment-17905706
]
Eric Pugh commented on SOLR-15441:
--
[~jbekker] would you be willing to open a PR with your suggested fix? Oddly
enough, I was just looking at those lines of code...
> Solr.cmd fails when SOLR_LOGS_DIR contains a space
> --
>
> Key: SOLR-15441
> URL: https://issues.apache.org/jira/browse/SOLR-15441
> Project: Solr
> Issue Type: Bug
> Components: SolrCLI
>Reporter: Jelle Bekker
>Priority: Minor
> Attachments: SOLR-15441.patch
>
>
> When the SOLR_LOGS_DIR (set through an environment variable) contains a
> space, the solr.cmd would fail.
> {noformat}
> C:\TestServer\M4_64657_SP4\AppServer\EASolrBin\bin>set
> SOLR_LOGS_DIR=C:\TestServer\M4_64657_SP4\Data\App Server\log
> C:\TestServer\M4_64657_SP4\AppServer\EASolrBin\bin>solr.cmd start -s
> "C:\TestServer\M4_64657_SP4\AppServer\EASolr" -p 8944
> Server\log] was unexpected at this time.{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17548: Switch all public Java APIs from File to Path [solr]
epugh commented on PR #2907: URL: https://github.com/apache/solr/pull/2907#issuecomment-2543060012 Sounds like you have a strong plan for moving forward @mlbiscoc and that's awesome. Do holler when you are ready for review and commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Resolved] (SOLR-17579) Remove unused methods in IndexFetcher and ReplicationHandler
[ https://issues.apache.org/jira/browse/SOLR-17579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17579. -- Fix Version/s: 9.8 Resolution: Fixed > Remove unused methods in IndexFetcher and ReplicationHandler > > > Key: SOLR-17579 > URL: https://issues.apache.org/jira/browse/SOLR-17579 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: replication (java) >Affects Versions: 9.8 >Reporter: Eric Pugh >Assignee: Eric Pugh >Priority: Minor > Labels: pull-request-available > Fix For: 9.8 > > Attachments: f7418bcb82a9668128c7bf72c1e25bbe31026fd9.patch > > Time Spent: 20m > Remaining Estimate: 0h > > There are dead methods and typos and unused exceptions! > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17579) Remove unused methods in IndexFetcher and ReplicationHandler
[ https://issues.apache.org/jira/browse/SOLR-17579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905699#comment-17905699 ] ASF subversion and git services commented on SOLR-17579: Commit 51275fda20e67e4d34cd35025c15d1bab9a554e2 in solr's branch refs/heads/branch_9x from Eric Pugh [ https://gitbox.apache.org/repos/asf?p=solr.git;h=51275fda20e ] SOLR-17579: Refactoring suggested by IDE in ReplicationHandler and tests (#2893) * Refactoring suggested by IDE. * Typos, some dead methods and dead variables. (cherry picked from commit 024f9737178624065d0ceada4d3b9fd5aac80341) > Remove unused methods in IndexFetcher and ReplicationHandler > > > Key: SOLR-17579 > URL: https://issues.apache.org/jira/browse/SOLR-17579 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: replication (java) >Affects Versions: 9.8 >Reporter: Eric Pugh >Assignee: Eric Pugh >Priority: Minor > Labels: pull-request-available > Fix For: 9.8 > > Attachments: f7418bcb82a9668128c7bf72c1e25bbe31026fd9.patch > > Time Spent: 20m > Remaining Estimate: 0h > > There are dead methods and typos and unused exceptions! > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17548: Switch all public Java APIs from File to Path [solr]
mlbiscoc commented on PR #2907: URL: https://github.com/apache/solr/pull/2907#issuecomment-2543112752 > Sounds like you have a strong plan for moving forward @mlbiscoc and that's awesome. Do holler when you are ready for review and commit. This should be ready for review unless you want me to bring in those other changes but was going for that in a separate PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17595) CLI examples are broken on Windows
[ https://issues.apache.org/jira/browse/SOLR-17595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905715#comment-17905715 ] Jan Høydahl commented on SOLR-17595: Perhaps it is simply a matter of quoting the -Dsolr.modules= argument? No idea why windows would like to split on comma.. > CLI examples are broken on Windows > -- > > Key: SOLR-17595 > URL: https://issues.apache.org/jira/browse/SOLR-17595 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: cli, examples, SolrCLI >Affects Versions: 9.7 >Reporter: Christos Malliaridis >Priority: Blocker > Labels: cli > Fix For: 9.8 > > Attachments: console-output-9.7.txt, console-output.txt > > > When trying to run the examples on Windows, it fails with an unspecified > error. I have attached the output for investigation. Bug is present in latest > changes. > A previous state was reporting more details about a potential cause. It was > mentioning the "*/xml" in in RunExampleTool.java, but that may not be anymore > the issue for the current failure (but could be a lead for the error). > The error is slightly different in the branches main, 9x and 9.8. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Assigned] (SOLR-17595) CLI examples are broken on Windows
[ https://issues.apache.org/jira/browse/SOLR-17595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christos Malliaridis reassigned SOLR-17595: --- Assignee: Christos Malliaridis > CLI examples are broken on Windows > -- > > Key: SOLR-17595 > URL: https://issues.apache.org/jira/browse/SOLR-17595 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: cli, examples, SolrCLI >Affects Versions: 9.7 >Reporter: Christos Malliaridis >Assignee: Christos Malliaridis >Priority: Blocker > Labels: cli > Fix For: 9.8 > > Attachments: console-output-9.7.txt, console-output.txt > > > When trying to run the examples on Windows, it fails with an unspecified > error. I have attached the output for investigation. Bug is present in latest > changes. > A previous state was reporting more details about a potential cause. It was > mentioning the "*/xml" in in RunExampleTool.java, but that may not be anymore > the issue for the current failure (but could be a lead for the error). > The error is slightly different in the branches main, 9x and 9.8. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17595) CLI examples are broken on Windows
[
https://issues.apache.org/jira/browse/SOLR-17595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905728#comment-17905728
]
Christos Malliaridis commented on SOLR-17595:
-
So there was a new bug introduced in SOLR-16781. The -D options are specially
treated and we have custom logic for parsing them. Handling them is quite
tricky and we have in multiple places workarounds. The RunExampleTool is
executing the solr script with the arguments, and during the argument parsing
in the script, it splits the \-D option at "=" and at ",". This causes the
values of {{\-Dsolr.moduels=...}} to be interpreted as separate arguments.
Adding quotes or adding the values to the jvm-options seems not to be
sufficient, even though the script correctly receives the arguments. Its
probably the logic in our cmd script that is not working.
And this is only one bug. The issue from 9.7 still persists if I remove the
additional arguments.
> CLI examples are broken on Windows
> --
>
> Key: SOLR-17595
> URL: https://issues.apache.org/jira/browse/SOLR-17595
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: cli, examples, SolrCLI
>Affects Versions: 9.7
>Reporter: Christos Malliaridis
>Assignee: Christos Malliaridis
>Priority: Blocker
> Labels: cli
> Fix For: 9.8
>
> Attachments: console-output-9.7.txt, console-output.txt
>
>
> When trying to run the examples on Windows, it fails with an unspecified
> error. I have attached the output for investigation. Bug is present in latest
> changes.
> A previous state was reporting more details about a potential cause. It was
> mentioning the "*/xml" in in RunExampleTool.java, but that may not be anymore
> the issue for the current failure (but could be a lead for the error).
> The error is slightly different in the branches main, 9x and 9.8.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17595) CLI examples are broken on Windows
[ https://issues.apache.org/jira/browse/SOLR-17595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905734#comment-17905734 ] Christos Malliaridis commented on SOLR-17595: - Well, I just realized there is no push protection on main. First fix for argument parsing is on main, accidentally. I will continue resolving the *.xml issue now and create a proper PR so that it can be backported. > CLI examples are broken on Windows > -- > > Key: SOLR-17595 > URL: https://issues.apache.org/jira/browse/SOLR-17595 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: cli, examples, SolrCLI >Affects Versions: 9.7 >Reporter: Christos Malliaridis >Assignee: Christos Malliaridis >Priority: Blocker > Labels: cli > Fix For: 9.8 > > Attachments: console-output-9.7.txt, console-output.txt > > > When trying to run the examples on Windows, it fails with an unspecified > error. I have attached the output for investigation. Bug is present in latest > changes. > A previous state was reporting more details about a potential cause. It was > mentioning the "*/xml" in in RunExampleTool.java, but that may not be anymore > the issue for the current failure (but could be a lead for the error). > The error is slightly different in the branches main, 9x and 9.8. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] SOLR-17595: Fix Solr examples for Windows [solr]
malliaridis opened a new pull request, #2909: URL: https://github.com/apache/solr/pull/2909 https://issues.apache.org/jira/browse/SOLR-17595 # Description Since 9.7 the Solr examples (specifically the techproducts) are not working properly and throw an error on startup. # Solution This PR fixes these issues. # Tests Some changes are related to the Windows solr.cmd script for which we do not have any tests (see [SOLR-17508](https://issues.apache.org/jira/browse/SOLR-17508)), and the other changes simply remove unsupported glob patterns. # Checklist - [X] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [X] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [X] I have developed this patch against the `main` branch. - [X] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17595) CLI examples are broken on Windows
[ https://issues.apache.org/jira/browse/SOLR-17595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17595: -- Labels: cli pull-request-available (was: cli) > CLI examples are broken on Windows > -- > > Key: SOLR-17595 > URL: https://issues.apache.org/jira/browse/SOLR-17595 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: cli, examples, SolrCLI >Affects Versions: 9.7 >Reporter: Christos Malliaridis >Assignee: Christos Malliaridis >Priority: Blocker > Labels: cli, pull-request-available > Fix For: 9.8 > > Attachments: console-output-9.7.txt, console-output.txt > > Time Spent: 10m > Remaining Estimate: 0h > > When trying to run the examples on Windows, it fails with an unspecified > error. I have attached the output for investigation. Bug is present in latest > changes. > A previous state was reporting more details about a potential cause. It was > mentioning the "*/xml" in in RunExampleTool.java, but that may not be anymore > the issue for the current failure (but could be a lead for the error). > The error is slightly different in the branches main, 9x and 9.8. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17412: Skip nested atomic updates for non-existent child docs [solr]
github-actions[bot] closed pull request #2652: SOLR-17412: Skip nested atomic updates for non-existent child docs URL: https://github.com/apache/solr/pull/2652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17412: Skip nested atomic updates for non-existent child docs [solr]
github-actions[bot] commented on PR #2652: URL: https://github.com/apache/solr/pull/2652#issuecomment-2543380816 This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
