[PR] upgrade-log4j2-2.24.2 [solr]
risdenk opened a new pull request, #2895: URL: https://github.com/apache/solr/pull/2895 https://issues.apache.org/jira/browse/SOLR-X This is a follow on to https://github.com/apache/solr/pull/2047 where `biz.aQute.bnd` doesn't need to be upgraded. However running into some test failures due to concurrent modification exceptions when updating loggers in some tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] chore(deps): update org.apache.logging.log4j:* to v2.24.1 - autoclosed [solr]
risdenk commented on PR #2047: URL: https://github.com/apache/solr/pull/2047#issuecomment-2523335365 New PR https://github.com/apache/solr/pull/2895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] upgrade-log4j2-2.24.2 [solr]
risdenk commented on PR #2895: URL: https://github.com/apache/solr/pull/2895#issuecomment-2523371681 Looks like we are running into: * https://github.com/apache/logging-log4j2/issues/3234 * https://github.com/apache/logging-log4j2/issues/3283 Once those are fixed (there is a PR it looks like) should be ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [I] [Regression] security.json is not uploaded during the first initialization of SolrCloud [solr-operator]
janhoy commented on issue #720:
URL: https://github.com/apache/solr-operator/issues/720#issuecomment-2523377989
I tagged it as a bug, feel free to work on a Pull Request trying to fix the
issue.
I did a quick test of the first command line on a 9.7 docker:
```bash
ZK_SECURITY_JSON=$(/opt/solr/server/scripts/cloud-scripts/zkcli.sh -zkhost
localhost:9983 -cmd get /security.json || echo 'failed-to-get-security.json');
```
I have an empty security.json file, so I'd expect the variable to be `{}`,
but instead it is
```
WARNING: The zkcli.sh script has been deprecated in favour of the bin/solr
equivalent commands. {}
```
When we deprecated the script in v9.7 we added an `echo` at line 3 printing
the deprecation warning. But it prints to stdout, meaning that it will be part
of the response always, breaking all scripts that rely on `-cmd get`. So in any
case that script should be fixed for 9.8 @epugh by prefixing the echo line with
`>&2`, i.e. `>&2 echo "WARNING:..."`.
This will fix the case where we have a security.json file which is empty
`{}` from next solr version. But it won't fix the case where the file does not
exist in ZK. In that case the same script would still return the string
"failed-to-get-security.json" which is longer than 2 chars, causing the same
effect, i.e. not uploading security.json since we believe the existing file
exists and is non-empty. The fix for this will be in operator to return empty
JSON object if file not found, triggering the upload: `|| echo '{}'`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-16781: Fix missing change in RunExampleTool [solr]
malliaridis commented on PR #2897: URL: https://github.com/apache/solr/pull/2897#issuecomment-2524217427 > OMG How did we miss this? How did our tests miss this? I think the tests reported the issue, but we just got used to failing jobs that it was just ignored. 😬 Or it was just a merge conflict that was resolved in a way that reset this specific line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17381 SolrJ fix to fetch entire ClusterState if asked [solr]
dsmiley commented on code in PR #2853:
URL: https://github.com/apache/solr/pull/2853#discussion_r1874029905
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -163,14 +145,11 @@ private ClusterState fetchClusterState(
}
for (Map.Entry e : collectionsMap.entrySet()) {
- @SuppressWarnings("rawtypes")
- Map m = (Map) e.getValue();
- Long creationTimeMillisFromClusterStatus = (Long)
m.get("creationTimeMillis");
- Instant creationTime =
- creationTimeMillisFromClusterStatus == null
- ? Instant.EPOCH
- : Instant.ofEpochMilli(creationTimeMillisFromClusterStatus);
- cs = cs.copyWith(e.getKey(), fillPrs(znodeVersion, e, creationTime, m));
+ String collectionName = e.getKey();
+ Map collStateMap = (Map) e.getValue();
+ cs =
+ cs.copyWith(
Review Comment:
Calling copyWith in a loop of collections is `O(N^2)` (N=#collections);
right? Not a problem introduced in this PR but I just want to confer with you
on this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17381 SolrJ fix to fetch entire ClusterState if asked [solr]
aparnasuresh85 commented on code in PR #2853:
URL: https://github.com/apache/solr/pull/2853#discussion_r1874058654
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -163,14 +145,11 @@ private ClusterState fetchClusterState(
}
for (Map.Entry e : collectionsMap.entrySet()) {
- @SuppressWarnings("rawtypes")
- Map m = (Map) e.getValue();
- Long creationTimeMillisFromClusterStatus = (Long)
m.get("creationTimeMillis");
- Instant creationTime =
- creationTimeMillisFromClusterStatus == null
- ? Instant.EPOCH
- : Instant.ofEpochMilli(creationTimeMillisFromClusterStatus);
- cs = cs.copyWith(e.getKey(), fillPrs(znodeVersion, e, creationTime, m));
+ String collectionName = e.getKey();
+ Map collStateMap = (Map) e.getValue();
+ cs =
+ cs.copyWith(
Review Comment:
Yes it is indeed O(N^2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [I] [Regression] security.json is not uploaded during the first initialization of SolrCloud [solr-operator]
janhoy commented on issue #720: URL: https://github.com/apache/solr-operator/issues/720#issuecomment-2524708971 Committed the fix to solr repo. It will (likely) make things work again with Solr 9.8, just like it worked with 9.6. Unfortunately there was also a need for a java level fix, so the proposed workaround mounting a patched script won't work since there was more deprecation noise ending up in the output, see SOLR-17586 for details. If you want to test this right now, you'd need to build a custom docker image for branch_9x and use that as your solr image. Easiest way is to wait for Jenkins to build the next nightly version of`apache/solr-nightly:9.8.0-SNAPSHOT`. I triggered a build, and once it completes (see https://ci-builds.apache.org/job/Solr/job/Solr-Docker-Nightly-9.x/) you will be able to pull it for testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Remove ingress and node-services during reconcile [solr-operator]
janhoy commented on PR #674: URL: https://github.com/apache/solr-operator/pull/674#issuecomment-2524716441 Suppose so. I think I got stuck with the test part. Anyone may feel free to grab this, I won't pick it up soonish. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17586 Print zkcli.sh deprecation msg to stderr (9x) [solr]
janhoy merged PR #2896: URL: https://github.com/apache/solr/pull/2896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Resolved] (SOLR-17586) Deprecation of zkcli.sh broke solr operator
[
https://issues.apache.org/jira/browse/SOLR-17586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-17586.
Resolution: Fixed
> Deprecation of zkcli.sh broke solr operator
> ---
>
> Key: SOLR-17586
> URL: https://issues.apache.org/jira/browse/SOLR-17586
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 9.7
>Reporter: Jan Høydahl
>Assignee: Jan Høydahl
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 9.8
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In SOLR-14115 we deprecated zkcli.sh. A deprecation echo was added to the
> script in 9.x and it was removed in 10.0.
> Turns out the deprecation message is always printed (stdout) thus breaking
> scripts that rely on capturing the output from the script when used with
> {{{}-cmd get{}}}.
> This can be fixed by echoing to stderr instead with
> {code:bash}
> >&2 echo "foo"
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Adding support for OpenShift securityContext [solr-operator]
computate commented on PR #706:
URL: https://github.com/apache/solr-operator/pull/706#issuecomment-2523536481
Thanks for following up @gerlowskija and @HoustonPutman , I am a big fan of
Solr. I would love to see the Zookeeper and Solr Operator work better on
OpenShift, because I have had problems with it and had to switch to using
bitnami helm charts instead. I haven't considered a solution like `if
apiGroups[i].Name == "route.openshift.io" {` before. I will keep this update in
mind, since this operator is also golang. I may need to create other issues for
other things, I think I was also mostly blocked with issues with the Zookeeper
Operator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Adding support for OpenShift securityContext [solr-operator]
gerlowskija commented on PR #706: URL: https://github.com/apache/solr-operator/pull/706#issuecomment-2523580815 > I would love to see the Zookeeper and Solr Operator work better on OpenShift, because I have had problems Sorry to hear it! ZK Operator stuff we can't do as much about, but we'd love to have better support for OpenShift on the Solr side - if you remember what the other issues were, please let us know with a ticket. We're blind in some ways without that feedback! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] fix: do not return metrics for prom-exporter probes re-fix (#694) [solr-operator]
gerlowskija commented on PR #729: URL: https://github.com/apache/solr-operator/pull/729#issuecomment-2523683357 Thanks for the PR @smoldenhauer-ish . Will start testing with an eye to merge soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]
zzBrunoBrito commented on PR #2382: URL: https://github.com/apache/solr/pull/2382#issuecomment-2523713325 Hi @kotman12 sorry for my late reply I wasn't able to check github lately and thank you for responding it. Yes I have interest in using it, that's a very interesting feature for me and has lots of potential to power impactful features. I'll follow your instructions to use it and I'm happy to provide any feedback from that. I'm curious to test that and see how it works -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] SOLR-16781: Fix missing change in RunExampleTool [solr]
malliaridis opened a new pull request, #2897: URL: https://github.com/apache/solr/pull/2897 https://issues.apache.org/jira/browse/SOLR-16781 # Description A specific change was missing in the PR https://github.com/apache/solr/pull/2875 but present in the backport https://github.com/apache/solr/pull/2894, which leads to job execution failure. # Solution Add the missing change. # Tests _none_ # Checklist - [X] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [X] I have developed this patch against the `main` branch. - [X] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-16781: Fix missing change in RunExampleTool [solr]
malliaridis merged PR #2897: URL: https://github.com/apache/solr/pull/2897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17583) Bring back documentation for Adding Custom Expressions
[
https://issues.apache.org/jira/browse/SOLR-17583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903766#comment-17903766
]
cfeldmann commented on SOLR-17583:
--
I'm hoping to have a Pull Request ready for this next week.
> Bring back documentation for Adding Custom Expressions
> --
>
> Key: SOLR-17583
> URL: https://issues.apache.org/jira/browse/SOLR-17583
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: documentation
>Affects Versions: 9.7
>Reporter: cfeldmann
>Priority: Major
> Labels: newdev
>
> A change was pushed to do a major revision of the Streaming Expressions guide
> almost 4 years ago in version 8.8: SOLR-13105 A visual guide to Solr Math
> Expressions and Streaming Expressions
>
> In this change, the following section was removed:
>
> {quote}Adding Custom Expressions
> Creating your own custom expressions can be easily done by implementing the
> [Expressible|https://lucene.apache.org/solr/8_5_0/solr-solrj/org/apache/solr/client/solrj/io/stream/expr/Expressible.html]
> interface. To add a custom expression to the list of known mappings for the
> /stream and /graph handlers, you just need to declare it as a plugin in
> solrconfig.xml via:
>
> {quote}
>
> There was no mention of deprecating the feature or removing this section.
> Given the massive size of the diff, it looks to be an inadvertent removal.
>
> The feature works. There’s no deprecation of this feature mentioned in any
> of the Solr docs since it was removed from the guide without explanation.
> The code itself is not deprecated.
>
> The Config API doc still includes
> add-expressible/update-expressible/delete-expressible
>
> Since the feature still works, has not been deprecated and seems to have been
> accidently removed from the documentation, let's bring this section back.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17381 SolrJ fix to fetch entire ClusterState if asked [solr]
aparnasuresh85 commented on code in PR #2853:
URL: https://github.com/apache/solr/pull/2853#discussion_r1873864651
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -182,6 +157,37 @@ private ClusterState fetchClusterState(
return cs;
}
+ private DocCollection getDocCollectionFromObjects(Map.Entry
e, int zNodeVersion) {
+@SuppressWarnings("rawtypes")
+Map m = (Map) e.getValue();
+Long creationTimeMillisFromClusterStatus = (Long)
m.get("creationTimeMillis");
Review Comment:
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-14115: Allow bin/solr zk commands to have parity with zkcli.sh commands. [solr]
janhoy commented on code in PR #2298: URL: https://github.com/apache/solr/pull/2298#discussion_r1873438627 ## solr/server/scripts/cloud-scripts/zkcli.sh: ## @@ -1,5 +1,7 @@ #!/usr/bin/env bash +echo "WARNING: The zkcli.sh script has been deprecated in favour of the bin/solr equivalent commands." Review Comment: This addition broke the solr-operator, see https://github.com/apache/solr-operator/issues/720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17586) Deprecation of zkcli.sh broken solr operator
[
https://issues.apache.org/jira/browse/SOLR-17586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-17586:
---
Description:
In SOLR-14115 we deprecated zkcli.sh. A deprecation echo was added to the
script in 9.x and it was removed in 10.0.
Turns out the deprecation message is always printed (stdout) thus breaking
scripts that rely on capturing the output from the script when used with
{{{}-cmd get{}}}.
This can be fixed by echoing to stderr instead with
{code:bash}
>&2 echo "foo"
{code}
was:
In SOLR-14115 we deprecated zkcli.sh. A deprecation echo was added to the
script in 9.x and it was removed in 10.0.
Turns out the deprecation message is always printed (stdout) thus breaking
scripts that rely on capturing the output from the script when used with
{{{}-cmd get{}}}.
This can be fixed by echoing to stderr instead with
>&2 echo "foo"
{{}}
> Deprecation of zkcli.sh broken solr operator
>
>
> Key: SOLR-17586
> URL: https://issues.apache.org/jira/browse/SOLR-17586
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 9.7
>Reporter: Jan Høydahl
>Priority: Major
>
> In SOLR-14115 we deprecated zkcli.sh. A deprecation echo was added to the
> script in 9.x and it was removed in 10.0.
> Turns out the deprecation message is always printed (stdout) thus breaking
> scripts that rely on capturing the output from the script when used with
> {{{}-cmd get{}}}.
> This can be fixed by echoing to stderr instead with
> {code:bash}
> >&2 echo "foo"
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17586) Deprecation of zkcli.sh broke solr operator
[
https://issues.apache.org/jira/browse/SOLR-17586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-17586:
---
Fix Version/s: 9.8
> Deprecation of zkcli.sh broke solr operator
> ---
>
> Key: SOLR-17586
> URL: https://issues.apache.org/jira/browse/SOLR-17586
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 9.7
>Reporter: Jan Høydahl
>Priority: Blocker
> Fix For: 9.8
>
>
> In SOLR-14115 we deprecated zkcli.sh. A deprecation echo was added to the
> script in 9.x and it was removed in 10.0.
> Turns out the deprecation message is always printed (stdout) thus breaking
> scripts that rely on capturing the output from the script when used with
> {{{}-cmd get{}}}.
> This can be fixed by echoing to stderr instead with
> {code:bash}
> >&2 echo "foo"
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17586) Deprecation of zkcli.sh broke solr operator
[
https://issues.apache.org/jira/browse/SOLR-17586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-17586:
---
Summary: Deprecation of zkcli.sh broke solr operator (was: Deprecation of
zkcli.sh broken solr operator)
> Deprecation of zkcli.sh broke solr operator
> ---
>
> Key: SOLR-17586
> URL: https://issues.apache.org/jira/browse/SOLR-17586
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 9.7
>Reporter: Jan Høydahl
>Priority: Major
>
> In SOLR-14115 we deprecated zkcli.sh. A deprecation echo was added to the
> script in 9.x and it was removed in 10.0.
> Turns out the deprecation message is always printed (stdout) thus breaking
> scripts that rely on capturing the output from the script when used with
> {{{}-cmd get{}}}.
> This can be fixed by echoing to stderr instead with
> {code:bash}
> >&2 echo "foo"
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17586) Deprecation of zkcli.sh broken solr operator
[
https://issues.apache.org/jira/browse/SOLR-17586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-17586:
---
Affects Version/s: 9.7
> Deprecation of zkcli.sh broken solr operator
>
>
> Key: SOLR-17586
> URL: https://issues.apache.org/jira/browse/SOLR-17586
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 9.7
>Reporter: Jan Høydahl
>Priority: Major
>
> In SOLR-14115 we deprecated zkcli.sh. A deprecation echo was added to the
> script in 9.x and it was removed in 10.0.
> Turns out the deprecation message is always printed (stdout) thus breaking
> scripts that rely on capturing the output from the script when used with
> {{{}-cmd get{}}}.
> This can be fixed by echoing to stderr instead with
> >&2 echo "foo"
>
> {{}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Created] (SOLR-17586) Deprecation of zkcli.sh broken solr operator
Jan Høydahl created SOLR-17586:
--
Summary: Deprecation of zkcli.sh broken solr operator
Key: SOLR-17586
URL: https://issues.apache.org/jira/browse/SOLR-17586
Project: Solr
Issue Type: Bug
Security Level: Public (Default Security Level. Issues are Public)
Components: scripts and tools
Reporter: Jan Høydahl
In SOLR-14115 we deprecated zkcli.sh. A deprecation echo was added to the
script in 9.x and it was removed in 10.0.
Turns out the deprecation message is always printed (stdout) thus breaking
scripts that rely on capturing the output from the script when used with
{{{}-cmd get{}}}.
This can be fixed by echoing to stderr instead with
>&2 echo "foo"
{{}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] upgrade-log4j2-2.24.2 [solr]
ppkarwasz commented on PR #2895: URL: https://github.com/apache/solr/pull/2895#issuecomment-2523609338 @risdenk, I'll cut a `2.24.3` release on Monday. The RC should solve your problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Adding support for OpenShift securityContext [solr-operator]
gerlowskija commented on PR #706: URL: https://github.com/apache/solr-operator/pull/706#issuecomment-2523521895 Hey @computate - starting to follow up on some of these outstanding PRs - what do you think about Houston's suggestion above regarding auto-detection? Is that something you'd be willing to add in here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17381 SolrJ fix to fetch entire ClusterState if asked [solr]
dsmiley commented on code in PR #2853:
URL: https://github.com/apache/solr/pull/2853#discussion_r1873806832
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -182,6 +157,37 @@ private ClusterState fetchClusterState(
return cs;
}
+ private DocCollection getDocCollectionFromObjects(Map.Entry
e, int zNodeVersion) {
Review Comment:
This is a weird method, taking a Map.Entry. I suggest never doing that.
It'd be clearer if it took the name & parsed object/Map.
Naming the parsed object/Map collection variable isn't clear but if you
can't think of something (better than 'm'!), then I propose `collStateMap`
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -182,6 +157,37 @@ private ClusterState fetchClusterState(
return cs;
}
+ private DocCollection getDocCollectionFromObjects(Map.Entry
e, int zNodeVersion) {
+@SuppressWarnings("rawtypes")
+Map m = (Map) e.getValue();
+Long creationTimeMillisFromClusterStatus = (Long)
m.get("creationTimeMillis");
+Instant creationTime =
+creationTimeMillisFromClusterStatus == null
+? Instant.EPOCH
+: Instant.ofEpochMilli(creationTimeMillisFromClusterStatus);
+return fillPrs(zNodeVersion, e, creationTime, m);
Review Comment:
ah, you chose Map.Entry because you want to pass it to `fillPrs`, which
already exists and takes this. I'd update that method as well instead.
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -182,6 +157,37 @@ private ClusterState fetchClusterState(
return cs;
}
+ private DocCollection getDocCollectionFromObjects(Map.Entry
e, int zNodeVersion) {
+@SuppressWarnings("rawtypes")
+Map m = (Map) e.getValue();
+Long creationTimeMillisFromClusterStatus = (Long)
m.get("creationTimeMillis");
Review Comment:
wow that's a long var name. I think the `FromClusterStatus` suffix isn't
needed; we aren't disambiguating multiple sources of creation time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[PR] SOLR-17586 Print zkcli.sh deprecation msg to stderr (9x) [solr]
janhoy opened a new pull request, #2896: URL: https://github.com/apache/solr/pull/2896 https://issues.apache.org/jira/browse/SOLR-17586 This is a partial fix for https://github.com/apache/solr-operator/issues/720 on the solr side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17586) Deprecation of zkcli.sh broke solr operator
[
https://issues.apache.org/jira/browse/SOLR-17586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17586:
--
Labels: pull-request-available (was: )
> Deprecation of zkcli.sh broke solr operator
> ---
>
> Key: SOLR-17586
> URL: https://issues.apache.org/jira/browse/SOLR-17586
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 9.7
>Reporter: Jan Høydahl
>Assignee: Jan Høydahl
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 9.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In SOLR-14115 we deprecated zkcli.sh. A deprecation echo was added to the
> script in 9.x and it was removed in 10.0.
> Turns out the deprecation message is always printed (stdout) thus breaking
> scripts that rely on capturing the output from the script when used with
> {{{}-cmd get{}}}.
> This can be fixed by echoing to stderr instead with
> {code:bash}
> >&2 echo "foo"
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [I] [Regression] security.json is not uploaded during the first initialization of SolrCloud [solr-operator]
janhoy commented on issue #720: URL: https://github.com/apache/solr-operator/issues/720#issuecomment-2523381719 I guess it would be possible to patch solr 9.7 docker container by mounting a fixed script as a volume on the POD at `/opt/solr/server/scripts/cloud-scripts/zkcli.sh` and thus work around the issue until 9.8 is out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17586) Deprecation of zkcli.sh broke solr operator
[
https://issues.apache.org/jira/browse/SOLR-17586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-17586:
---
Priority: Blocker (was: Major)
> Deprecation of zkcli.sh broke solr operator
> ---
>
> Key: SOLR-17586
> URL: https://issues.apache.org/jira/browse/SOLR-17586
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 9.7
>Reporter: Jan Høydahl
>Priority: Blocker
>
> In SOLR-14115 we deprecated zkcli.sh. A deprecation echo was added to the
> script in 9.x and it was removed in 10.0.
> Turns out the deprecation message is always printed (stdout) thus breaking
> scripts that rely on capturing the output from the script when used with
> {{{}-cmd get{}}}.
> This can be fixed by echoing to stderr instead with
> {code:bash}
> >&2 echo "foo"
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Solr 12276 angularjs to angular migration [solr]
NikolaiJDev commented on PR #2818: URL: https://github.com/apache/solr/pull/2818#issuecomment-2523460089 Regarding updating of the Gradle script, I'm looking for the solution that will easily integrate Angular build process into it, I found some of them, but they are outdated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17586) Deprecation of zkcli.sh broke solr operator
[
https://issues.apache.org/jira/browse/SOLR-17586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903676#comment-17903676
]
Jan Høydahl commented on SOLR-17586:
Testing the fix I also discovered that the tool also prints deprecation
warnings from CommonsCli to stdout
{code:java}
./server/scripts/cloud-scripts/zkcli.sh -zkhost localhost:9983 -cmd get
/security.json 2>/dev/null
Option 'zkhost': Deprecated for removal since 9.7: Use --zk-host instead
Option 'zkhost': Deprecated for removal since 9.7: Use --zk-host instead
{} {code}
This seems harder to fix if it is printed by commons CLI itself?
> Deprecation of zkcli.sh broke solr operator
> ---
>
> Key: SOLR-17586
> URL: https://issues.apache.org/jira/browse/SOLR-17586
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
>Affects Versions: 9.7
>Reporter: Jan Høydahl
>Assignee: Jan Høydahl
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 9.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In SOLR-14115 we deprecated zkcli.sh. A deprecation echo was added to the
> script in 9.x and it was removed in 10.0.
> Turns out the deprecation message is always printed (stdout) thus breaking
> scripts that rely on capturing the output from the script when used with
> {{{}-cmd get{}}}.
> This can be fixed by echoing to stderr instead with
> {code:bash}
> >&2 echo "foo"
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Remove ingress and node-services during reconcile [solr-operator]
gerlowskija commented on PR #674: URL: https://github.com/apache/solr-operator/pull/674#issuecomment-2523460698 Trying to follow up on some of these older PRs. AFAICT from the discussion above, the main thing holding up this PR is a test like the one Houston described [in his earlier comment](https://github.com/apache/solr-operator/pull/674#pullrequestreview-1902178369)? Is that right @janhoy ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-14115) Deprecate zkcli.sh
[ https://issues.apache.org/jira/browse/SOLR-14115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-14115: -- Labels: pull-request-available (was: ) > Deprecate zkcli.sh > -- > > Key: SOLR-14115 > URL: https://issues.apache.org/jira/browse/SOLR-14115 > Project: Solr > Issue Type: Improvement > Components: scripts and tools >Reporter: Erick Erickson >Assignee: Eric Pugh >Priority: Major > Labels: pull-request-available > Fix For: main (10.0), 9.7 > > Time Spent: 2h > Remaining Estimate: 0h > > I think it's a valid argument that these have outlived their usefulness and > we should remove them and have APIs to do what Solr requires. Especially if > we can find and point to a third-party visual ZK tool for _changing_ > arbitrary data in ZK. Zookeeper 3.5.5 has the admin server which has a UI > (although I don't see how to change data in ZK with it. Haven't looked very > much). > While we're ripping stuff out of Solr, are these candidates? It would break > my heart to rip ZK support out from bin/solr, but all good things must come > to an end. Why do we maintain three (zkcli, bin/solr and the APIs) ways of > doing the same thing? > Mark put the zkcli stuff in before we had APIs to do what Solr needs to do > with ZK, mainly uploading configsets at the time. I put the zk support in > bin/solr also before the APIs existed because I thought having to learn our > custom wrapper for ZK was yet another orphan bit of code laying around. All > before we had things like the configsets API. > Personally, I'd prefer removing zkcli rather than bin/solr, but that's > because I originated the bin/solr code ;) > This occurred when reading SOLR-14109, I'm not entirely sure what I _really_ > think about it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
