[jira] [Commented] (SOLR-17471) upgrade to Lucene 9.12.0
[
https://issues.apache.org/jira/browse/SOLR-17471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17886338#comment-17886338
]
Pierre Salagnac commented on SOLR-17471:
Thanks for the quick fix in Lucene.
Unfortunately, your suggestion to workaround missing constructors above breaks
some tests. {{DFISimilarityFactory}} fails because of the subclass, and
{{TestBulkSchemaAPI}} calls {{getDiscountOverlaps()}}. They are tests issues
only, with little value only. I think production code still works as expected.
I don't know whether a Lucene hot fix will be released soon. I think there is
no urgency to do the upgrade. In case one is planned, we may also wait for it .
> upgrade to Lucene 9.12.0
>
>
> Key: SOLR-17471
> URL: https://issues.apache.org/jira/browse/SOLR-17471
> Project: Solr
> Issue Type: Task
>Reporter: Christine Poerschke
>Priority: Major
> Fix For: main (10.0), 9.8
>
>
> Creating and leaving this Jira open for (new) devs to grab.
> * https://lucene.apache.org/core/9_12_0/changes/Changes.html
> * https://github.com/apache/solr/blob/main/dev-docs/lucene-upgrade.md
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17473) Apply formatting to build source files
[ https://issues.apache.org/jira/browse/SOLR-17473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17473: Summary: Apply formatting to build source files (was: Improve formatting in infrastructure classes) > Apply formatting to build source files > -- > > Key: SOLR-17473 > URL: https://issues.apache.org/jira/browse/SOLR-17473 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Gradle >Reporter: Christos Malliaridis >Priority: Minor > Labels: formatting, gradle > > Right now java classes in Gradle are not formatted or checked by tidy and > forbidden-apis. > This can be tackled in a similar way as demonstrated in > [Lucene#PR13484|https://github.com/apache/lucene/pull/13484.], by moving > affected files / classes into a composite included build and running tidy > etc. on it via "gradle.includedBuilds". > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17467) Start solr in Cloud mode, introduce --standalone switch for Standalone mode
[
https://issues.apache.org/jira/browse/SOLR-17467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17886473#comment-17886473
]
Jan Høydahl commented on SOLR-17467:
+1 to {{--user-managed}} to switch to user managed mode.
It could be useful to provide an additional way of reverting to previous
default than requiring user to start with the {{--user-managed}} argument.
Perhaps adding a new sysProp {{solr.mode.usermanaged=true}} /
{{SOLR_MODE_USERMANAGED=true}} will help some users to upgrade (and stick with
user managed) without having to modify the command line, which could be hard
coded..
> Start solr in Cloud mode, introduce --standalone switch for Standalone mode
> ---
>
> Key: SOLR-17467
> URL: https://issues.apache.org/jira/browse/SOLR-17467
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: cli
>Affects Versions: main (10.0)
>Reporter: Eric Pugh
>Assignee: Eric Pugh
>Priority: Major
>
> Introduce the --standalone switch and default to Cloud mode.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Resolved] (SOLR-17285) Move RemoteSolrException to SolrClient in v10
[ https://issues.apache.org/jira/browse/SOLR-17285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-17285. - Fix Version/s: main (10.0) Resolution: Fixed Thanks for contributing Samuel! > Move RemoteSolrException to SolrClient in v10 > - > > Key: SOLR-17285 > URL: https://issues.apache.org/jira/browse/SOLR-17285 > Project: Solr > Issue Type: Sub-task > Components: SolrJ >Reporter: David Smiley >Priority: Major > Labels: newdev, pull-request-available > Fix For: main (10.0) > > Time Spent: 50m > Remaining Estimate: 0h > > RemoteSolrException lives in BaseHttpSolrClient. BaseHttpSolrClient should > be deprecated; it's sort of replaced by HttpSolrClientBase. Even though this > exception is only for Http, SolrClient is a decent parent class. Or make top > level. > To make this transition from 9x to 10x better, we could simply add new > classes without removing the old ones in 9x. The old can subclass the new. > Eventually all of BaseHttpSolrClient will be removed. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17468) Revamp Ref Guide to feature SolrCloud.
[ https://issues.apache.org/jira/browse/SOLR-17468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17886483#comment-17886483 ] David Smiley commented on SOLR-17468: - See [this relevant dev-list thread|https://lists.apache.org/list?d...@solr.apache.org:2024-2] from February and that which makes reference to others. Cassandra, I urge you to reply to that thread and thus keep the context. Maybe copy-paste your argument here. (Sorry I hate "user managed") > Revamp Ref Guide to feature SolrCloud. > > > Key: SOLR-17468 > URL: https://issues.apache.org/jira/browse/SOLR-17468 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: documentation >Affects Versions: main (10.0) >Reporter: Eric Pugh >Assignee: Eric Pugh >Priority: Major > > Move SolrCloud mode to the top of each page, and update how we refer to > "user-managed" or "single node" as just "standalone". Standalone is what we > all agreed is the default term, despite attempts to move away after much bike > shedding! > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Resolved] (SOLR-17474) The snippet formatting does not work as intended when PassageSort is not startOffset.
[
https://issues.apache.org/jira/browse/SOLR-17474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Seunghan Jung resolved SOLR-17474.
--
Resolution: Duplicate
This should have been posted to the “Lucene” project, but it was mistakenly
posted to the “Solr” project. We are working on it in the following PR:
https://github.com/apache/lucene/pull/13832.
> The snippet formatting does not work as intended when PassageSort is not
> startOffset.
> -
>
> Key: SOLR-17474
> URL: https://issues.apache.org/jira/browse/SOLR-17474
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: highlighter
>Affects Versions: main (10.0)
>Reporter: Seunghan Jung
>Priority: Critical
> Attachments: image-2024-10-03-04-14-50-717.png
>
>
> DefaultPassageFormatter.format method에, 다음과 같이 (startOffset이 아닌 score순으로)
> 정렬되어 있는 passages가 주어졌다고 합시다.
> !image-2024-10-03-04-14-50-717.png!
> 이때 content는 "When indexing data in Solr, each document is composed of various
> fields. A document essentially represents a single record, and each document
> typically contains a unique ID field." 이므로 각 Passage는 다음과 같습니다.
> * Passages[0] -> "A document essentially represents a single record, and
> each document typically contains a unique ID field."
> * Passages[1] -> "When indexing data in Solr, each document is composed of
> various fields. "
>
> 의도한 formatting 결과는 다음과 같습니다.
> "A document essentially represents a single record, and each
> document typically contains a unique ID field.\{{ellipsis}}When
> indexing data in Solr, each document is composed of various fields."
>
> 하지만 두 passage가 이어져 있는지 판단하는 조건문이 passages가 startOffset으로 정렬을 전제로 작성되어 있어, 두
> passage가 ellipsis로 구분되어지지 않고 연결되어 하나의 snippet이 되어 버립니다.
>
> ""A document essentially represents a single record, and each
> document typically contains a unique ID field.When indexing data in
> Solr, each document is composed of various fields."
>
> 이에 해당 조건문을 수정합니다.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17474) The snippet formatting does not work as intended when PassageSort is not startOffset.
[
https://issues.apache.org/jira/browse/SOLR-17474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Seunghan Jung updated SOLR-17474:
-
Description:
DefaultPassageFormatter.format method에, 다음과 같이 (startOffset이 아닌 score순으로) 정렬되어
있는 passages가 주어졌다고 합시다.
!image-2024-10-03-04-14-50-717.png!
이때 content는 "When indexing data in Solr, each document is composed of various
fields. A document essentially represents a single record, and each document
typically contains a unique ID field." 이므로 각 Passage는 다음과 같습니다.
* Passages[0] -> "A document essentially represents a single record, and each
document typically contains a unique ID field."
* Passages[1] -> "When indexing data in Solr, each document is composed of
various fields. "
의도한 formatting 결과는 다음과 같습니다.
"A document essentially represents a single record, and each
document typically contains a unique ID field.\{{ellipsis}}When indexing
data in Solr, each document is composed of various fields."
하지만 두 passage가 이어져 있는지 판단하는 조건문이 passages가 startOffset으로 정렬을 전제로 작성되어 있어, 두
passage가 ellipsis로 구분되어지지 않고 연결되어 하나의 snippet이 되어 버립니다.
""A document essentially represents a single record, and each
document typically contains a unique ID field.When indexing data in
Solr, each document is composed of various fields."
이에 해당 조건문을 수정합니다.
> The snippet formatting does not work as intended when PassageSort is not
> startOffset.
> -
>
> Key: SOLR-17474
> URL: https://issues.apache.org/jira/browse/SOLR-17474
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: highlighter
>Affects Versions: main (10.0)
>Reporter: Seunghan Jung
>Priority: Critical
> Attachments: image-2024-10-03-04-14-50-717.png
>
>
> DefaultPassageFormatter.format method에, 다음과 같이 (startOffset이 아닌 score순으로)
> 정렬되어 있는 passages가 주어졌다고 합시다.
> !image-2024-10-03-04-14-50-717.png!
> 이때 content는 "When indexing data in Solr, each document is composed of various
> fields. A document essentially represents a single record, and each document
> typically contains a unique ID field." 이므로 각 Passage는 다음과 같습니다.
> * Passages[0] -> "A document essentially represents a single record, and
> each document typically contains a unique ID field."
> * Passages[1] -> "When indexing data in Solr, each document is composed of
> various fields. "
>
> 의도한 formatting 결과는 다음과 같습니다.
> "A document essentially represents a single record, and each
> document typically contains a unique ID field.\{{ellipsis}}When
> indexing data in Solr, each document is composed of various fields."
>
> 하지만 두 passage가 이어져 있는지 판단하는 조건문이 passages가 startOffset으로 정렬을 전제로 작성되어 있어, 두
> passage가 ellipsis로 구분되어지지 않고 연결되어 하나의 snippet이 되어 버립니다.
>
> ""A document essentially represents a single record, and each
> document typically contains a unique ID field.When indexing data in
> Solr, each document is composed of various fields."
>
> 이에 해당 조건문을 수정합니다.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Comment Edited] (SOLR-6122) API to cancel an already submitted/running Collections API call
[ https://issues.apache.org/jira/browse/SOLR-6122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17886253#comment-17886253 ] Yuntong Qu edited comment on SOLR-6122 at 10/2/24 8:40 PM: --- -To allow cancel submitted and not started task with later on support to cancel certain running task. We should only let overseer to decide what to remove in its work queue.- -Within the scope of using overseer:- - -I propose that we have a new queue (/overseer/collection-queue-work) on ZK. Each node can submit to cancel queue with async id they intended to cancel through CollectionsHandler.- - -On overseer (OverseerTaskProcessor), during each [run()|https://github.com/apache/solr/blob/383d21bac694d17ae64ddae5af30cfb9b5a0c615/solr/core/src/java/org/apache/solr/cloud/OverseerTaskProcessor.java#L168], we compare queued task from work queue with cancel queue first to cancel any not started task, right after- [-clenUpWorkQueue()-|https://github.com/apache/solr/blob/383d21bac694d17ae64ddae5af30cfb9b5a0c615/solr/core/src/java/org/apache/solr/cloud/OverseerTaskProcessor.java#L245] was (Author: yuntong): To allow cancel submitted and not started task with later on support to cancel certain running task. We should only let overseer to decide what to remove in its work queue. Within the scope of using overseer: - I propose that we have a new queue (/overseer/collection-queue-work) on ZK. Each node can submit to cancel queue with async id they intended to cancel through CollectionsHandler. - On overseer (OverseerTaskProcessor), during each [run()|https://github.com/apache/solr/blob/383d21bac694d17ae64ddae5af30cfb9b5a0c615/solr/core/src/java/org/apache/solr/cloud/OverseerTaskProcessor.java#L168], we compare queued task from work queue with cancel queue first to cancel any not started task, right after [clenUpWorkQueue()|https://github.com/apache/solr/blob/383d21bac694d17ae64ddae5af30cfb9b5a0c615/solr/core/src/java/org/apache/solr/cloud/OverseerTaskProcessor.java#L245] > API to cancel an already submitted/running Collections API call > --- > > Key: SOLR-6122 > URL: https://issues.apache.org/jira/browse/SOLR-6122 > Project: Solr > Issue Type: Wish > Components: SolrCloud >Reporter: Anshum Gupta >Priority: Major > > Right now we can trigger a long running task with no way to cancel it > cleanly. > We should have an API that interrupts the already running/submitted > collections API call. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] (SOLR-17473) Improve formatting in infrastructure classes
[ https://issues.apache.org/jira/browse/SOLR-17473 ] Christos Malliaridis deleted comment on SOLR-17473: - was (Author: JIRAUSER305622): This improvement was addressed in SOLR-17406 as part of the version catalogs and split from it. > Improve formatting in infrastructure classes > > > Key: SOLR-17473 > URL: https://issues.apache.org/jira/browse/SOLR-17473 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Gradle >Reporter: Christos Malliaridis >Priority: Minor > Labels: formatting, gradle > > Right now java classes in Gradle are not formatted or checked by tidy and > forbidden-apis. > This can be tackled in a similar way as demonstrated in > [Lucene#PR13484|https://github.com/apache/lucene/pull/13484.], by moving > affected files / classes into a composite included build and running tidy > etc. on it via "gradle.includedBuilds". > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17886479#comment-17886479 ] David Smiley commented on SOLR-16470: - If the API requires certain parameters to respond in a reasonable manner, it should be modified to throw a 400 and tell you what to do. It could also be modified to have different defaults than standard defaults, like org.apache.solr.handler.ExportHandler#handleRequestBody does. > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Priority: Major > Labels: V2, newdev > Time Spent: 4h 20m > Remaining Estimate: 0h > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |-GET /solr/collName/replication?command=indexversion-| > |GET /solr/collName/replication?command=filecontent| > |-GET /solr/collName/replication?command=filelist-| > Proposed API design > |-GET /api/cores/coreName/replication/indexversion-| > |GET /api/cores/coreName/replication/files/filePath| > |-GET /api/cores/coreName/replication/files-| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in ReplicationHandler > * [Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.)|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#apis-in-solr] > * [A step-by-step guide to creating APIs using the preferred v2 API > framework|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#writing-jax-rs-apis] > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/2144] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Created] (SOLR-17474) The snippet formatting does not work as intended when PassageSort is not startOffset.
Seunghan Jung created SOLR-17474: Summary: The snippet formatting does not work as intended when PassageSort is not startOffset. Key: SOLR-17474 URL: https://issues.apache.org/jira/browse/SOLR-17474 Project: Solr Issue Type: Bug Security Level: Public (Default Security Level. Issues are Public) Components: highlighter Affects Versions: main (10.0) Reporter: Seunghan Jung -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17474) The snippet formatting does not work as intended when PassageSort is not startOffset.
[ https://issues.apache.org/jira/browse/SOLR-17474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seunghan Jung updated SOLR-17474: - Attachment: image-2024-10-03-04-14-50-717.png > The snippet formatting does not work as intended when PassageSort is not > startOffset. > - > > Key: SOLR-17474 > URL: https://issues.apache.org/jira/browse/SOLR-17474 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: highlighter >Affects Versions: main (10.0) >Reporter: Seunghan Jung >Priority: Critical > Attachments: image-2024-10-03-04-14-50-717.png > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Created] (SOLR-17473) Improve formatting in infrastructure classes
Christos Malliaridis created SOLR-17473: --- Summary: Improve formatting in infrastructure classes Key: SOLR-17473 URL: https://issues.apache.org/jira/browse/SOLR-17473 Project: Solr Issue Type: Improvement Security Level: Public (Default Security Level. Issues are Public) Components: Gradle Reporter: Christos Malliaridis Right now java classes in Gradle are not formatted or checked by tidy and forbidden-apis. This can be tackled in a similar way as demonstrated in [Lucene#PR13484|https://github.com/apache/lucene/pull/13484.], by moving affected files / classes into a composite included build and running tidy etc. on it via "gradle.includedBuilds". -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17468) Revamp Ref Guide to feature SolrCloud.
[ https://issues.apache.org/jira/browse/SOLR-17468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17886408#comment-17886408 ] Eric Pugh commented on SOLR-17468: -- Something must have burped, as the PR: [https://github.com/apache/solr/pull/2730] should have been linked! A couple other folks mentioned that standalone might not be a good name as well, so I'm thinking I reached too far to both reorg the docs AND do a rename of a core concept. I'm going to roll back the name change, however I'd still like to keep the "put solrcloud" first. I don't have a specific SIP to point to, and maybe I need to generate that artifact. However, I've been pushing for us to have a simpler deploy structure that eliminates the need for users to think "Am I in SolrCLoud mode or not", and just have a Solr that scales from the smallest to the largest. Today we have essentially two products, with different apis, different conceptual models of how they wrok, and different featuresets, and it's not helping us thrive as a community and project. It doesn't have to be that way. This miro board describes where I've been thinking we need to go: [https://miro.com/app/board/o9J_lm8BmXE=/?moveToWidget=3458764558006503531&cot=14] Next week i'm going to be trying to articulate this goal in a more cohesive whole at C/C in Denver during my talk "Scaling Solr: From Desktop to Cloud Scale", and I hope that out of that is a vision that we can discuss on the mailing list more. Not to put too fine a point on it, but I want to see SolrCloud and "Non Solr Cloud Mode" as we have it today in 9x gone, and just "Solr Mode". > Revamp Ref Guide to feature SolrCloud. > > > Key: SOLR-17468 > URL: https://issues.apache.org/jira/browse/SOLR-17468 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: documentation >Affects Versions: main (10.0) >Reporter: Eric Pugh >Assignee: Eric Pugh >Priority: Major > > Move SolrCloud mode to the top of each page, and update how we refer to > "user-managed" or "single node" as just "standalone". Standalone is what we > all agreed is the default term, despite attempts to move away after much bike > shedding! > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
