[jira] [Commented] (SOLR-16691) Use Jackson for JSON serialization
[ https://issues.apache.org/jira/browse/SOLR-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752675#comment-17752675 ] Ovidiu Mihalcea commented on SOLR-16691: I'm seeing some very weird formatting using the default interface query output in SolrCloud mode. Either all the indented content is shifted by many white spaces (while keeping indents after this), either there is not indenting at all (keeping multiple lines, different from indent=false), either we get a new line between every line. Why was this made the instant default and not tested as an alternative in at least one release? 😕 > Use Jackson for JSON serialization > -- > > Key: SOLR-16691 > URL: https://issues.apache.org/jira/browse/SOLR-16691 > Project: Solr > Issue Type: Task >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Major > Fix For: 9.3 > > Time Spent: 2.5h > Remaining Estimate: 0h > > A user has reported significant performance gains from using Jackson over our > homegrown JSON writer -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] renatoh opened a new pull request, #1834: Cleaning up old code to prevent warnings
renatoh opened a new pull request, #1834: URL: https://github.com/apache/solr/pull/1834 Reading through the code in org.apache.solr.cli, I realized there are quite some warnings, which can be easily cleaned up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16691) Use Jackson for JSON serialization
[ https://issues.apache.org/jira/browse/SOLR-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752776#comment-17752776 ] Noble Paul commented on SOLR-16691: --- Indent is a property of the serializing library. JSON could be indented in anyway and it can still be a valid JSON. However, if we wish to change the style of indent, it can be done in a new ticket > Use Jackson for JSON serialization > -- > > Key: SOLR-16691 > URL: https://issues.apache.org/jira/browse/SOLR-16691 > Project: Solr > Issue Type: Task >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Major > Fix For: 9.3 > > Time Spent: 2.5h > Remaining Estimate: 0h > > A user has reported significant performance gains from using Jackson over our > homegrown JSON writer -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #1834: Cleaning up old code to prevent warnings
epugh commented on code in PR #1834:
URL: https://github.com/apache/solr/pull/1834#discussion_r1290029229
##
solr/core/src/java/org/apache/solr/cli/AssertTool.java:
##
@@ -30,6 +30,7 @@
import org.apache.solr.client.solrj.SolrClient;
import org.apache.solr.client.solrj.SolrServerException;
import org.apache.solr.client.solrj.request.HealthCheckRequest;
+import org.apache.solr.client.solrj.response.CollectionAdminResponse;
Review Comment:
is this import needed?
##
solr/core/src/java/org/apache/solr/cli/SimplePostTool.java:
##
@@ -544,14 +537,20 @@ public int postFiles(File[] files, int startIndexInArgs,
OutputStream out, Strin
reset();
int filesPosted = 0;
for (File srcFile : files) {
- boolean isValidPath = checkIsValidPath(srcFile);
- if (isValidPath && srcFile.isDirectory() && srcFile.canRead()) {
-filesPosted += postDirectory(srcFile, out, type);
- } else if (isValidPath && srcFile.isFile() && srcFile.canRead()) {
-filesPosted += postFiles(new File[] {srcFile}, out, type);
- } else {
-filesPosted += handleGlob(srcFile, out, type);
- }
+ filesPosted = getFilesPosted(out, type, filesPosted, srcFile);
Review Comment:
this nesting seems a bit odd... I would expect this entire method to
return all the files posted from the source `files` and not pass in and out the
counter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] renatoh commented on a diff in pull request #1834: Cleaning up old code to prevent warnings
renatoh commented on code in PR #1834:
URL: https://github.com/apache/solr/pull/1834#discussion_r1290046082
##
solr/core/src/java/org/apache/solr/cli/SimplePostTool.java:
##
@@ -544,14 +537,20 @@ public int postFiles(File[] files, int startIndexInArgs,
OutputStream out, Strin
reset();
int filesPosted = 0;
for (File srcFile : files) {
- boolean isValidPath = checkIsValidPath(srcFile);
- if (isValidPath && srcFile.isDirectory() && srcFile.canRead()) {
-filesPosted += postDirectory(srcFile, out, type);
- } else if (isValidPath && srcFile.isFile() && srcFile.canRead()) {
-filesPosted += postFiles(new File[] {srcFile}, out, type);
- } else {
-filesPosted += handleGlob(srcFile, out, type);
- }
+ filesPosted = getFilesPosted(out, type, filesPosted, srcFile);
Review Comment:
true, 'out' passed in to getFilesPosted is always 0 hence it does not need
be posted in. will fix it. thanks
##
solr/core/src/java/org/apache/solr/cli/AssertTool.java:
##
@@ -30,6 +30,7 @@
import org.apache.solr.client.solrj.SolrClient;
import org.apache.solr.client.solrj.SolrServerException;
import org.apache.solr.client.solrj.request.HealthCheckRequest;
+import org.apache.solr.client.solrj.response.CollectionAdminResponse;
Review Comment:
nope, not needed anymore, will remove the unused imports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1832: SOLR-16733: Toggle Sec Manager when OSX+JDK20 used
janhoy commented on PR #1832: URL: https://github.com/apache/solr/pull/1832#issuecomment-1673136120 Personally I switch to JDK11 or 17 when running tests on my Mac. The alternative is to fail loudly and ask the dev to choose JDK17. There's a tiny risk that if more committers start using JDK20 for their dev work on a mac, someone may commit code that is incompatible with secMan rules, but won't be caught by tests. Although it would be caught in PR Crave tests om Linux... Guess I'm +0.5 on this hack.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-15771) bin/solr auth enable should model best practices for security.json
[
https://issues.apache.org/jira/browse/SOLR-15771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752792#comment-17752792
]
Eric Pugh commented on SOLR-15771:
--
[~janhoy] would you be interested in picking this one up with me? I think I
can do a lot of the coding work, but my innate understanding of how it SHOULD
work is lacking ;-)
> bin/solr auth enable should model best practices for security.json
> --
>
> Key: SOLR-15771
> URL: https://issues.apache.org/jira/browse/SOLR-15771
> Project: Solr
> Issue Type: Bug
> Components: Authentication, SolrCLI
>Reporter: Eric Pugh
>Assignee: Eric Pugh
>Priority: Minor
>
> During discussion of SOLR-15770, the idea came up that the {{bin/solr auth
> enable}} command should model a best practices setup of {{security.json}},
> with the idea that it's sometimes easier to show versus tell people how to
> setup security.
>
> My wish for that default security.json
> * Add three users {{user}} , {{admin}} and {{superadmin}}
> * Add three roles with the same names
> * Map *every* permission in the system to one or more of those roles
> * End the chain with an {{all}} permission connected to the {{superadmin}}
> role
> Bonus points would be to have the {{security.json}} be a template file read
> in by {{AuthTool}} instead of a hard to edit/understand String generated in
> Java. Then we could also reference this file in the Ref Guide (the way we do
> with some SolrJ chunks of code) and provide more detailed explanation of
> thinking in the Ref Guide.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1768: SOLR-16824: Adopt Linux Command line tool pattern of -- for long option commands
epugh commented on PR #1768: URL: https://github.com/apache/solr/pull/1768#issuecomment-1673183998 I think this branch has definitly had some bit rot, and there is a lot of work to update it Thanks for looking @mkhludnev at this branch, glad to get some input on this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16691) Use Jackson for JSON serialization
[ https://issues.apache.org/jira/browse/SOLR-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752800#comment-17752800 ] Ovidiu Mihalcea commented on SOLR-16691: [~noble.paul] I believe it's a bug from the combination of the JacksonJsonWriter and indent=true. The Query component of the interface is quite an important feature for debugging. The workaround was to add and json to the default on the /select SearchHandler, as it seems when not specifying a default wt it defaults to the JacksonJsonWriter and not JSONResponseWriter. Should I create a new ticket for this? > Use Jackson for JSON serialization > -- > > Key: SOLR-16691 > URL: https://issues.apache.org/jira/browse/SOLR-16691 > Project: Solr > Issue Type: Task >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Major > Fix For: 9.3 > > Time Spent: 2.5h > Remaining Estimate: 0h > > A user has reported significant performance gains from using Jackson over our > homegrown JSON writer -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Comment Edited] (SOLR-16691) Use Jackson for JSON serialization
[ https://issues.apache.org/jira/browse/SOLR-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752800#comment-17752800 ] Ovidiu Mihalcea edited comment on SOLR-16691 at 8/10/23 1:06 PM: - [~noble.paul] I believe it's a bug from the combination of the JacksonJsonWriter and indent=true. The Query component of the interface is quite an important feature for debugging. The workaround was to add and json to the defaults on the /select SearchHandler, as it seems when not specifying a default wt it defaults to the JacksonJsonWriter and not JSONResponseWriter. Should I create a new ticket for this? was (Author: dizzu333): [~noble.paul] I believe it's a bug from the combination of the JacksonJsonWriter and indent=true. The Query component of the interface is quite an important feature for debugging. The workaround was to add and json to the default on the /select SearchHandler, as it seems when not specifying a default wt it defaults to the JacksonJsonWriter and not JSONResponseWriter. Should I create a new ticket for this? > Use Jackson for JSON serialization > -- > > Key: SOLR-16691 > URL: https://issues.apache.org/jira/browse/SOLR-16691 > Project: Solr > Issue Type: Task >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Major > Fix For: 9.3 > > Time Spent: 2.5h > Remaining Estimate: 0h > > A user has reported significant performance gains from using Jackson over our > homegrown JSON writer -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16691) Use Jackson for JSON serialization
[
https://issues.apache.org/jira/browse/SOLR-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752802#comment-17752802
]
Noble Paul commented on SOLR-16691:
---
{{ }}
If just specifying the above does not work, it should be fixed. please open a
ticket
> Use Jackson for JSON serialization
> --
>
> Key: SOLR-16691
> URL: https://issues.apache.org/jira/browse/SOLR-16691
> Project: Solr
> Issue Type: Task
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Major
> Fix For: 9.3
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> A user has reported significant performance gains from using Jackson over our
> homegrown JSON writer
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Created] (SOLR-16924) Restore: Have RESTORECORE set the UpdateLog state
David Smiley created SOLR-16924: --- Summary: Restore: Have RESTORECORE set the UpdateLog state Key: SOLR-16924 URL: https://issues.apache.org/jira/browse/SOLR-16924 Project: Solr Issue Type: Improvement Security Level: Public (Default Security Level. Issues are Public) Reporter: David Smiley This is a refactoring improvement designed to simplify & clarify a step in collection restores. One of the final phases of RestoreCmd (collection restore) is to call REQUESTAPPLYUPDATES on each newly restored replica in order to transition the state of the UpdateLog to ACTIVE (not actually to apply updates). The underlying call on the UpdateLog could instead be done inside RESTORECORE at the end with explanatory comments as to the intent. I think this makes more sense that RESTORECORE finish with its UpdateLog ready. And it's strange/curious to see requests in the cluster to apply updates from an updateLog when there is none to do! Adding clarifying comments is important. See my comment: https://issues.apache.org/jira/browse/SOLR-12065?focusedCommentId=17751792&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17751792 I think there isn't any back-compat concern. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16691) Use Jackson for JSON serialization
[ https://issues.apache.org/jira/browse/SOLR-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752825#comment-17752825 ] Ishan Chattopadhyaya commented on SOLR-16691: - Even without that workaround, what worked in the past should continue to work. If the bug can be fixed with the Jackson writer itself, that's good. Otherwise it should be fixed in the admin UI. In either case, I don't think it should be a blocker for changing the default response writer to Jackson. Ovidiu, thanks for your report. Please open a new issue. > Use Jackson for JSON serialization > -- > > Key: SOLR-16691 > URL: https://issues.apache.org/jira/browse/SOLR-16691 > Project: Solr > Issue Type: Task >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Major > Fix For: 9.3 > > Time Spent: 2.5h > Remaining Estimate: 0h > > A user has reported significant performance gains from using Jackson over our > homegrown JSON writer -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #1826: SOLR-16920: Test full package lifecycle
HoustonPutman commented on PR #1826: URL: https://github.com/apache/solr/pull/1826#issuecomment-1673359375 > One more idea, what if we comment out the test, so at least we have it someone wants to run it, but it isn't in the regular path? I'm +1 to this with a comment stating why the test is not enabled by default -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Created] (SOLR-16925) Broken JSON indentation using JacksonJsonWriter
Ovidiu Mihalcea created SOLR-16925: -- Summary: Broken JSON indentation using JacksonJsonWriter Key: SOLR-16925 URL: https://issues.apache.org/jira/browse/SOLR-16925 Project: Solr Issue Type: Bug Security Level: Public (Default Security Level. Issues are Public) Components: Response Writers Affects Versions: 9.3 Environment: Problem reproduces across 6+ SolrCloud clusters. Reporter: Ovidiu Mihalcea I'm seeing some very weird formatting using the default interface query output in SolrCloud mode. Either all the indented content is shifted by many white spaces (while keeping indents after this), either there is not indenting at all (keeping multiple lines, different from indent=false), either we get a new line between every line. I believe it's a bug from the combination of the JacksonJsonWriter and indent=true. The Query component of the interface is quite an important feature for debugging. The workaround was to add and json to the defaults on the /select SearchHandler, as it seems when not specifying a default wt it defaults to the JacksonJsonWriter and not JSONResponseWriter. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-16925) Broken JSON indentation using JacksonJsonWriter
[ https://issues.apache.org/jira/browse/SOLR-16925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ovidiu Mihalcea updated SOLR-16925: --- Security: (was: Public) > Broken JSON indentation using JacksonJsonWriter > --- > > Key: SOLR-16925 > URL: https://issues.apache.org/jira/browse/SOLR-16925 > Project: Solr > Issue Type: Bug > Components: Response Writers >Affects Versions: 9.3 > Environment: Problem reproduces across 6+ SolrCloud clusters. >Reporter: Ovidiu Mihalcea >Priority: Major > > I'm seeing some very weird formatting using the default interface query > output in SolrCloud mode. Either all the indented content is shifted by many > white spaces (while keeping indents after this), either there is not > indenting at all (keeping multiple lines, different from indent=false), > either we get a new line between every line. > I believe it's a bug from the combination of the JacksonJsonWriter and > indent=true. The Query component of the interface is quite an important > feature for debugging. > The workaround was to add class="solr.JSONResponseWriter" /> and json to the > defaults on the /select SearchHandler, as it seems when not specifying a > default wt it defaults to the JacksonJsonWriter and not JSONResponseWriter. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Comment Edited] (SOLR-16691) Use Jackson for JSON serialization
[ https://issues.apache.org/jira/browse/SOLR-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752836#comment-17752836 ] Ovidiu Mihalcea edited comment on SOLR-16691 at 8/10/23 2:59 PM: - I've opened a new issue: [SOLR-16925|https://issues.apache.org/jira/browse/SOLR-16925] was (Author: dizzu333): I've open a new issue: [SOLR-16925|https://issues.apache.org/jira/browse/SOLR-16925] > Use Jackson for JSON serialization > -- > > Key: SOLR-16691 > URL: https://issues.apache.org/jira/browse/SOLR-16691 > Project: Solr > Issue Type: Task >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Major > Fix For: 9.3 > > Time Spent: 2.5h > Remaining Estimate: 0h > > A user has reported significant performance gains from using Jackson over our > homegrown JSON writer -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16691) Use Jackson for JSON serialization
[ https://issues.apache.org/jira/browse/SOLR-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752836#comment-17752836 ] Ovidiu Mihalcea commented on SOLR-16691: I've open a new issue: [SOLR-16925|https://issues.apache.org/jira/browse/SOLR-16925] > Use Jackson for JSON serialization > -- > > Key: SOLR-16691 > URL: https://issues.apache.org/jira/browse/SOLR-16691 > Project: Solr > Issue Type: Task >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Major > Fix For: 9.3 > > Time Spent: 2.5h > Remaining Estimate: 0h > > A user has reported significant performance gains from using Jackson over our > homegrown JSON writer -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] renatoh commented on a diff in pull request #1834: Cleaning up old code to prevent warnings
renatoh commented on code in PR #1834:
URL: https://github.com/apache/solr/pull/1834#discussion_r1290046082
##
solr/core/src/java/org/apache/solr/cli/SimplePostTool.java:
##
@@ -544,14 +537,20 @@ public int postFiles(File[] files, int startIndexInArgs,
OutputStream out, Strin
reset();
int filesPosted = 0;
for (File srcFile : files) {
- boolean isValidPath = checkIsValidPath(srcFile);
- if (isValidPath && srcFile.isDirectory() && srcFile.canRead()) {
-filesPosted += postDirectory(srcFile, out, type);
- } else if (isValidPath && srcFile.isFile() && srcFile.canRead()) {
-filesPosted += postFiles(new File[] {srcFile}, out, type);
- } else {
-filesPosted += handleGlob(srcFile, out, type);
- }
+ filesPosted = getFilesPosted(out, type, filesPosted, srcFile);
Review Comment:
true, 'out' passed in to getFilesPosted is always 0 hence it does not need
be past in. will fix it. thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16644) Entropy warning thresholds need to be revisited
[
https://issues.apache.org/jira/browse/SOLR-16644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752863#comment-17752863
]
Raghavan Muthuregunathan commented on SOLR-16644:
-
I am working on a PR for this. i will give update by 8/12
> Entropy warning thresholds need to be revisited
> ---
>
> Key: SOLR-16644
> URL: https://issues.apache.org/jira/browse/SOLR-16644
> Project: Solr
> Issue Type: Bug
>Reporter: Ishan Chattopadhyaya
>Priority: Major
> Labels: newdev
>
> As per the following, newer kernels (5.15+) have recalibrated the entropy
> levels from 0-4096 to 0-256. Hence, everything is throwing a warning:
> {code}
> Warning: Available entropy is low. As a result, use of the UUIDField, SSL, or
> any other features that require
> RNG might not work properly. To check for the amount of available entropy,
> use 'cat /proc/sys/kernel/random/entropy_avail'.
> {code}
> Here's where I found out about this change:
> https://askubuntu.com/questions/1427470/entropy-is-stuck-at-256-after-upgrading-to-kernel-5-15-0-47
> We might need to intelligently report the low entropy (based on kernel
> version).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16925) Broken JSON indentation using JacksonJsonWriter
[ https://issues.apache.org/jira/browse/SOLR-16925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752862#comment-17752862 ] Raghavan Muthuregunathan commented on SOLR-16925: - I am working on a PR for this. i will give update by 8/12 > Broken JSON indentation using JacksonJsonWriter > --- > > Key: SOLR-16925 > URL: https://issues.apache.org/jira/browse/SOLR-16925 > Project: Solr > Issue Type: Bug > Components: Response Writers >Affects Versions: 9.3 > Environment: Problem reproduces across 6+ SolrCloud clusters. >Reporter: Ovidiu Mihalcea >Priority: Major > > I'm seeing some very weird formatting using the default interface query > output in SolrCloud mode. Either all the indented content is shifted by many > white spaces (while keeping indents after this), either there is not > indenting at all (keeping multiple lines, different from indent=false), > either we get a new line between every line. > I believe it's a bug from the combination of the JacksonJsonWriter and > indent=true. The Query component of the interface is quite an important > feature for debugging. > The workaround was to add class="solr.JSONResponseWriter" /> and json to the > defaults on the /select SearchHandler, as it seems when not specifying a > default wt it defaults to the JacksonJsonWriter and not JSONResponseWriter. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16920) Add Full Lifecycle Bats test for installing a Package
[ https://issues.apache.org/jira/browse/SOLR-16920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752876#comment-17752876 ] Eric Pugh commented on SOLR-16920: -- The attached PR goes part way, but because we don't actually have a Package as part of Solr project, we can't actually test it without relying on a external third party package. > Add Full Lifecycle Bats test for installing a Package > - > > Key: SOLR-16920 > URL: https://issues.apache.org/jira/browse/SOLR-16920 > Project: Solr > Issue Type: Sub-task > Components: packages >Affects Versions: 9.3 >Reporter: Eric Pugh >Assignee: Eric Pugh >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > Touching the package logic is difficult because it's a multi step area of the > code. The existing BATS test doesn't actually fully test the code becasue we > don't have any legit packages. > Add a BATS test. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] epugh merged pull request #1826: SOLR-16920: Test full package lifecycle
epugh merged PR #1826: URL: https://github.com/apache/solr/pull/1826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16920) Add Full Lifecycle Bats test for installing a Package
[ https://issues.apache.org/jira/browse/SOLR-16920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752882#comment-17752882 ] ASF subversion and git services commented on SOLR-16920: Commit 88990d640a89091a8f7b0b2493377ac24118afe8 in solr's branch refs/heads/main from Eric Pugh [ https://gitbox.apache.org/repos/asf?p=solr.git;h=88990d640a8 ] SOLR-16920: Add Test full package lifecycle (#1826), fix parsing of repository.json mimetype Github is a common place to store the repository.json file used by Solr Packages. While the file is .json, the mimetype from Github is text/plain, so this fixes the client being used to load the repository.json to accept text/plain as well as application/json mimetypes. > Add Full Lifecycle Bats test for installing a Package > - > > Key: SOLR-16920 > URL: https://issues.apache.org/jira/browse/SOLR-16920 > Project: Solr > Issue Type: Sub-task > Components: packages >Affects Versions: 9.3 >Reporter: Eric Pugh >Assignee: Eric Pugh >Priority: Minor > Time Spent: 50m > Remaining Estimate: 0h > > Touching the package logic is difficult because it's a multi step area of the > code. The existing BATS test doesn't actually fully test the code becasue we > don't have any legit packages. > Add a BATS test. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Comment Edited] (SOLR-16920) Add Full Lifecycle Bats test for installing a Package
[ https://issues.apache.org/jira/browse/SOLR-16920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752876#comment-17752876 ] Eric Pugh edited comment on SOLR-16920 at 8/10/23 4:52 PM: --- The attached PR goes part way, but because we don't actually have a Package as part of Solr project, we can't actually test it without relying on a external third party package, so I think leaving this ticket open is the right thing. was (Author: epugh): The attached PR goes part way, but because we don't actually have a Package as part of Solr project, we can't actually test it without relying on a external third party package. > Add Full Lifecycle Bats test for installing a Package > - > > Key: SOLR-16920 > URL: https://issues.apache.org/jira/browse/SOLR-16920 > Project: Solr > Issue Type: Sub-task > Components: packages >Affects Versions: 9.3 >Reporter: Eric Pugh >Assignee: Eric Pugh >Priority: Minor > Time Spent: 50m > Remaining Estimate: 0h > > Touching the package logic is difficult because it's a multi step area of the > code. The existing BATS test doesn't actually fully test the code becasue we > don't have any legit packages. > Add a BATS test. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16920) Add Full Lifecycle Bats test for installing a Package
[ https://issues.apache.org/jira/browse/SOLR-16920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752883#comment-17752883 ] ASF subversion and git services commented on SOLR-16920: Commit 8ad05dec8ac2439856bd7841448a5dbdcc080f2f in solr's branch refs/heads/branch_9x from Eric Pugh [ https://gitbox.apache.org/repos/asf?p=solr.git;h=8ad05dec8ac ] SOLR-16920: Add Test full package lifecycle (#1826), fix parsing of repository.json mimetype Github is a common place to store the repository.json file used by Solr Packages. While the file is .json, the mimetype from Github is text/plain, so this fixes the client being used to load the repository.json to accept text/plain as well as application/json mimetypes. > Add Full Lifecycle Bats test for installing a Package > - > > Key: SOLR-16920 > URL: https://issues.apache.org/jira/browse/SOLR-16920 > Project: Solr > Issue Type: Sub-task > Components: packages >Affects Versions: 9.3 >Reporter: Eric Pugh >Assignee: Eric Pugh >Priority: Minor > Time Spent: 50m > Remaining Estimate: 0h > > Touching the package logic is difficult because it's a multi step area of the > code. The existing BATS test doesn't actually fully test the code becasue we > don't have any legit packages. > Add a BATS test. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] laminelam commented on pull request #1798: Add/fix wrong/missing "solr.home" to zkcli scripts
laminelam commented on PR #1798: URL: https://github.com/apache/solr/pull/1798#issuecomment-1673715418 > Thanks for looking at this.. one thought, would you want to add some BATS test to confirm these fixes? They have been great for verifying a lot of the SolrCLI things... Down the road, I hope to eliminate the need for the `zkcli.sh` completely, in favour of using `bin/solr` commands... Having some BATS tests would help that migration ;-). Hi @epugh Thanks for the great suggestion. Didn't know about BATS. I have added a couple of BATS tests to test both 'solr,home" and "solrhome" options. Wondering if it's worth it keeping "solr.home" option, it's redundant and confusing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr-operator] sarkaramrit2 opened a new issue, #599: Solr 9.2.1 K8s issue
sarkaramrit2 opened a new issue, #599:
URL: https://github.com/apache/solr-operator/issues/599
Solr 9.2.1 facing two issues:
* except solr home dir, read/write permissions are needed and hence fails
```
"solrClientTLS": {
"mountedTLSDir": {
"path": "/abv-client-tls", # see
`spec.customSolrKubeOptions.podOptions.volumes` below
"path": "/opt/solr-9.2.1.0-apple/abv-client-tls",
```
* SNI 400s
```2023-07-25 17:19:34.649 WARN (qtp912747546-37) [] o.e.j.s.HttpChannel
handleException /solr/admin/info/system
org.eclipse.jetty.http.BadMessageException: 400: Invalid SNI
2023-07-25 17:19:34.649 WARN (qtp912747546-98) [] o.e.j.s.HttpChannel
handleException /solr/admin/info/system
org.eclipse.jetty.http.BadMessageException: 400: Invalid SNI
2023-07-25 17:19:34.656 WARN (qtp912747546-35) [] o.e.j.s.HttpChannel
handleException /solr/admin/info/system
org.eclipse.jetty.http.BadMessageException: 400: Invalid SNI
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] iamsanjay commented on pull request #1119: [SOLR-16461] Create v2 equivalent of v1 ReplicationHandler 'BACKUP'
iamsanjay commented on PR #1119: URL: https://github.com/apache/solr/pull/1119#issuecomment-1673749396 > @iamsanjay are you ok with me pushing some changes to this PR's branch to get things goin again? Yes @stillalex go ahead. Let me know if you have any questions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Created] (SOLR-16926) Embedded ZK not reachable via docker v9.2.1
Amrit Sarkar created SOLR-16926: --- Summary: Embedded ZK not reachable via docker v9.2.1 Key: SOLR-16926 URL: https://issues.apache.org/jira/browse/SOLR-16926 Project: Solr Issue Type: Bug Security Level: Public (Default Security Level. Issues are Public) Components: Docker Affects Versions: 9.2.1 Reporter: Amrit Sarkar Embedded ZK running within Solr docker image for v9.2.1 is not reachable. ZK running: ```2023-08-10 16:05:13.009 INFO (main) [] o.a.s.c.SolrZkServer STARTING EMBEDDED STANDALONE ZOOKEEPER SERVER at port 9983 2023-08-10 16:05:13.009 WARN (main) [] o.a.s.c.SolrZkServer Embedded Zookeeper is not recommended in production environments. See Reference Guide for details. 2023-08-10 16:05:13.039 WARN (embeddedZkServer) [] o.a.z.s.ServerCnxnFactory maxCnxns is not configured, using default value 0. 2023-08-10 16:05:13.515 INFO (main) [] o.a.s.c.ZkContainer Zookeeper client=127.0.0.1:9983``` `nc -vz localhost:9983` works. `echo ruok | nc localhost 9983` does not work. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-16926) Embedded ZK not reachable via docker v9.2.1
[
https://issues.apache.org/jira/browse/SOLR-16926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amrit Sarkar updated SOLR-16926:
Description:
Embedded ZK running within Solr docker image for v9.2.1 is not reachable.
ZK running:
{{2023-08-10 16:05:13.009 INFO (main) [] o.a.s.c.SolrZkServer STARTING
EMBEDDED STANDALONE ZOOKEEPER SERVER at port 9983
2023-08-10 16:05:13.009 WARN (main) [] o.a.s.c.SolrZkServer Embedded Zookeeper
is not recommended in production environments. See Reference Guide for details.
2023-08-10 16:05:13.039 WARN (embeddedZkServer) [] o.a.z.s.ServerCnxnFactory
maxCnxns is not configured, using default value 0.
2023-08-10 16:05:13.515 INFO (main) [] o.a.s.c.ZkContainer Zookeeper
client=127.0.0.1:9983}}
{{nc -vz localhost:9983}} works.
{{echo ruok | nc localhost 9983}} does not work.
was:
Embedded ZK running within Solr docker image for v9.2.1 is not reachable.
ZK running:
```2023-08-10 16:05:13.009 INFO (main) [] o.a.s.c.SolrZkServer STARTING
EMBEDDED STANDALONE ZOOKEEPER SERVER at port 9983
2023-08-10 16:05:13.009 WARN (main) [] o.a.s.c.SolrZkServer Embedded Zookeeper
is not recommended in production environments. See Reference Guide for details.
2023-08-10 16:05:13.039 WARN (embeddedZkServer) [] o.a.z.s.ServerCnxnFactory
maxCnxns is not configured, using default value 0.
2023-08-10 16:05:13.515 INFO (main) [] o.a.s.c.ZkContainer Zookeeper
client=127.0.0.1:9983```
`nc -vz localhost:9983` works.
`echo ruok | nc localhost 9983` does not work.
> Embedded ZK not reachable via docker v9.2.1
> ---
>
> Key: SOLR-16926
> URL: https://issues.apache.org/jira/browse/SOLR-16926
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Docker
>Affects Versions: 9.2.1
>Reporter: Amrit Sarkar
>Priority: Critical
>
> Embedded ZK running within Solr docker image for v9.2.1 is not reachable.
> ZK running:
> {{2023-08-10 16:05:13.009 INFO (main) [] o.a.s.c.SolrZkServer STARTING
> EMBEDDED STANDALONE ZOOKEEPER SERVER at port 9983
> 2023-08-10 16:05:13.009 WARN (main) [] o.a.s.c.SolrZkServer Embedded
> Zookeeper is not recommended in production environments. See Reference Guide
> for details.
> 2023-08-10 16:05:13.039 WARN (embeddedZkServer) [] o.a.z.s.ServerCnxnFactory
> maxCnxns is not configured, using default value 0.
> 2023-08-10 16:05:13.515 INFO (main) [] o.a.s.c.ZkContainer Zookeeper
> client=127.0.0.1:9983}}
> {{nc -vz localhost:9983}} works.
> {{echo ruok | nc localhost 9983}} does not work.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-16926) Embedded ZK not reachable via docker v9.2.1
[
https://issues.apache.org/jira/browse/SOLR-16926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amrit Sarkar updated SOLR-16926:
Description:
Embedded ZK running within Solr docker image for v9.2.1 is not reachable.
ZK running:
{quote}2023-08-10 16:05:13.009 INFO (main) [] o.a.s.c.SolrZkServer STARTING
EMBEDDED STANDALONE ZOOKEEPER SERVER at port 9983
2023-08-10 16:05:13.009 WARN (main) [] o.a.s.c.SolrZkServer Embedded Zookeeper
is not recommended in production environments. See Reference Guide for details.
2023-08-10 16:05:13.039 WARN (embeddedZkServer) [] o.a.z.s.ServerCnxnFactory
maxCnxns is not configured, using default value 0.
2023-08-10 16:05:13.515 INFO (main) [] o.a.s.c.ZkContainer Zookeeper
client=127.0.0.1:9983{quote}
{{nc -vz localhost:9983}} works.
{{echo ruok | nc localhost 9983}} does not work.
was:
Embedded ZK running within Solr docker image for v9.2.1 is not reachable.
ZK running:
{{2023-08-10 16:05:13.009 INFO (main) [] o.a.s.c.SolrZkServer STARTING
EMBEDDED STANDALONE ZOOKEEPER SERVER at port 9983
2023-08-10 16:05:13.009 WARN (main) [] o.a.s.c.SolrZkServer Embedded Zookeeper
is not recommended in production environments. See Reference Guide for details.
2023-08-10 16:05:13.039 WARN (embeddedZkServer) [] o.a.z.s.ServerCnxnFactory
maxCnxns is not configured, using default value 0.
2023-08-10 16:05:13.515 INFO (main) [] o.a.s.c.ZkContainer Zookeeper
client=127.0.0.1:9983}}
{{nc -vz localhost:9983}} works.
{{echo ruok | nc localhost 9983}} does not work.
> Embedded ZK not reachable via docker v9.2.1
> ---
>
> Key: SOLR-16926
> URL: https://issues.apache.org/jira/browse/SOLR-16926
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Docker
>Affects Versions: 9.2.1
>Reporter: Amrit Sarkar
>Priority: Critical
>
> Embedded ZK running within Solr docker image for v9.2.1 is not reachable.
> ZK running:
> {quote}2023-08-10 16:05:13.009 INFO (main) [] o.a.s.c.SolrZkServer STARTING
> EMBEDDED STANDALONE ZOOKEEPER SERVER at port 9983
> 2023-08-10 16:05:13.009 WARN (main) [] o.a.s.c.SolrZkServer Embedded
> Zookeeper is not recommended in production environments. See Reference Guide
> for details.
> 2023-08-10 16:05:13.039 WARN (embeddedZkServer) [] o.a.z.s.ServerCnxnFactory
> maxCnxns is not configured, using default value 0.
> 2023-08-10 16:05:13.515 INFO (main) [] o.a.s.c.ZkContainer Zookeeper
> client=127.0.0.1:9983{quote}
> {{nc -vz localhost:9983}} works.
> {{echo ruok | nc localhost 9983}} does not work.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16926) Embedded ZK not reachable via docker v9.2.1
[
https://issues.apache.org/jira/browse/SOLR-16926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752914#comment-17752914
]
Amrit Sarkar commented on SOLR-16926:
-
CC [~houston], team: let me know if need more information.
> Embedded ZK not reachable via docker v9.2.1
> ---
>
> Key: SOLR-16926
> URL: https://issues.apache.org/jira/browse/SOLR-16926
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Docker
>Affects Versions: 9.2.1
>Reporter: Amrit Sarkar
>Priority: Critical
>
> Embedded ZK running within Solr docker image for v9.2.1 is not reachable.
> ZK running:
> {quote}2023-08-10 16:05:13.009 INFO (main) [] o.a.s.c.SolrZkServer STARTING
> EMBEDDED STANDALONE ZOOKEEPER SERVER at port 9983
> 2023-08-10 16:05:13.009 WARN (main) [] o.a.s.c.SolrZkServer Embedded
> Zookeeper is not recommended in production environments. See Reference Guide
> for details.
> 2023-08-10 16:05:13.039 WARN (embeddedZkServer) [] o.a.z.s.ServerCnxnFactory
> maxCnxns is not configured, using default value 0.
> 2023-08-10 16:05:13.515 INFO (main) [] o.a.s.c.ZkContainer Zookeeper
> client=127.0.0.1:9983{quote}
> {{nc -vz localhost:9983}} works.
> {{echo ruok | nc localhost 9983}} does not work.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-16926) Embedded ZK not reachable via docker v9.2.1
[
https://issues.apache.org/jira/browse/SOLR-16926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman updated SOLR-16926:
--
Affects Version/s: 9.0
(was: 9.2.1)
> Embedded ZK not reachable via docker v9.2.1
> ---
>
> Key: SOLR-16926
> URL: https://issues.apache.org/jira/browse/SOLR-16926
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Docker
>Affects Versions: 9.0
>Reporter: Amrit Sarkar
>Priority: Critical
>
> Embedded ZK running within Solr docker image for v9.2.1 is not reachable.
> ZK running:
> {quote}2023-08-10 16:05:13.009 INFO (main) [] o.a.s.c.SolrZkServer STARTING
> EMBEDDED STANDALONE ZOOKEEPER SERVER at port 9983
> 2023-08-10 16:05:13.009 WARN (main) [] o.a.s.c.SolrZkServer Embedded
> Zookeeper is not recommended in production environments. See Reference Guide
> for details.
> 2023-08-10 16:05:13.039 WARN (embeddedZkServer) [] o.a.z.s.ServerCnxnFactory
> maxCnxns is not configured, using default value 0.
> 2023-08-10 16:05:13.515 INFO (main) [] o.a.s.c.ZkContainer Zookeeper
> client=127.0.0.1:9983{quote}
> {{nc -vz localhost:9983}} works.
> {{echo ruok | nc localhost 9983}} does not work.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1798: Add/fix wrong/missing "solr.home" to zkcli scripts
epugh commented on PR #1798: URL: https://github.com/apache/solr/pull/1798#issuecomment-1673843170 i had no idea that behind the zkcli scripts was a Java class! I think we should only have one variable name, whichever we have been using the most. One more thought... I've been slowly moving various scripts under the "bin/solr" SolrCLI as tools. Once this get's merged, would you be interested in migrating this over to "bin/solr"? I wonder how much of what is in the "bin/solr zk" command is duplicated htere in zkcli? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1798: Add/fix wrong/missing "solr.home" to zkcli scripts
epugh commented on PR #1798: URL: https://github.com/apache/solr/pull/1798#issuecomment-1673847349 Might be worth a grep thorugh the ref guide re "solrHome" versus "solr.home" too! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] laminelam commented on pull request #1798: Add/fix wrong/missing "solr.home" to zkcli scripts
laminelam commented on PR #1798: URL: https://github.com/apache/solr/pull/1798#issuecomment-1673852267 > One more thought... I've been slowly moving various scripts under the "bin/solr" SolrCLI as tools. Once this get's merged, would you be interested in migrating this over to "bin/solr"? I wonder how much of what is in the "bin/solr zk" command is duplicated htere in zkcli? Yes sure, will be more than happy to help on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] laminelam commented on pull request #1798: Add/fix wrong/missing "solr.home" to zkcli scripts
laminelam commented on PR #1798: URL: https://github.com/apache/solr/pull/1798#issuecomment-1673869102 > Might be worth a grep thorugh the ref guide re "solrHome" versus "solr.home" too! The only place where "solr.home" is used is [here](https://github.com/apache/solr/blob/707043872b42f8dd986b0c066504cebf5fbc91ca/solr/core/src/java/org/apache/solr/cloud/ZkCLI.java#L245C39-L245C50) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] stillalex commented on pull request #1779: SOLR-16859 Missing Proxy support for Http2SolrClient
stillalex commented on PR #1779: URL: https://github.com/apache/solr/pull/1779#issuecomment-1673926139 > I noticed that we have a test_ssl.bats test that exercises Solr. I wonder if extending those tests would help validate this fix? no, we'd need a proxy server for testing ...unless there is some command line proxy server that is easy to integrate into a bats test. I manually installed one on my local to smoke test this and was able to check http1 and http2 modes. @epugh would you say this is sufficient to push the code in? if there are bugs in more complex setups we can fix them as they come (as opposed to not having this feature in). I would hate to leave this PR open for much longer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Created] (SOLR-16927) Allow SolrClientCache clients to use Jetty HTTP2 clients
Alex Deparvu created SOLR-16927: --- Summary: Allow SolrClientCache clients to use Jetty HTTP2 clients Key: SOLR-16927 URL: https://issues.apache.org/jira/browse/SOLR-16927 Project: Solr Issue Type: Sub-task Reporter: Alex Deparvu Assignee: Alex Deparvu Looking at introducing a change to SolrClientCache to allow it to work with http2 clients in a backwards compatible way, leaving the old clients usage in place. The use of SolrClientCache can be seem as dual: server side, based on the internal client (SOLR-16503) so blocked on this task, and client side which could be extended to use whatever clients want to use (old or new impls). I am calling this change a 'client facing' change because it will allow app side users of streaming module to setup calls based on the new http2 clients, ignoring the Solr internals which are move involved to move. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] stillalex opened a new pull request, #1835: SOLR-16927 Allow SolrClientCache clients to use Jetty HTTP2 clients
stillalex opened a new pull request, #1835: URL: https://github.com/apache/solr/pull/1835 https://issues.apache.org/jira/browse/SOLR-X # Description Please provide a short description of the changes you're making with this pull request. # Solution Please provide a short description of the approach taken to implement your solution. # Tests Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem. # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] stillalex commented on pull request #1835: SOLR-16927 Allow SolrClientCache clients to use Jetty HTTP2 clients
stillalex commented on PR #1835: URL: https://github.com/apache/solr/pull/1835#issuecomment-1674002231 looking for a review on this. @dsmiley, @epugh @joel-bernstein I hope you don't mind I added you. looking forward to your thoughts! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-14201) some SolrCore are not released after being removed
[ https://issues.apache.org/jira/browse/SOLR-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752987#comment-17752987 ] Diego Estrada commented on SOLR-14201: -- Using solr 8.11.2 we were able to stop the memory leak by disabling the metrics API > some SolrCore are not released after being removed > -- > > Key: SOLR-14201 > URL: https://issues.apache.org/jira/browse/SOLR-14201 > Project: Solr > Issue Type: Bug >Affects Versions: 7.7.2, 8.8 >Reporter: Christine Poerschke >Priority: Major > Attachments: image-2020-01-22-10-39-15-301.png, > image-2020-01-22-10-42-17-511.png, image-2020-01-22-12-28-46-241.png, > image-2020-01-22-14-45-52-730.png, image-2020-01-28-16-17-44-030.png, > image-2020-01-28-16-19-43-760.png, image-2020-01-28-16-20-50-709.png, > image-2020-01-28-16-59-51-813.png > > > [~vinhlh] reported in SOLR-10506 (affecting 6.5 with fixes in 6.6.6 and 7.0): > bq. In 7.7.2, some SolrCore still are not released after being removed. > https://issues.apache.org/jira/secure/attachment/12991357/image-2020-01-20-14-51-26-411.png > Starting this ticket for a separate investigation and fix. A next > investigative step could be to try and reproduce the issue on the latest 8.x > release. > > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1835: SOLR-16927 Allow SolrClientCache clients to use Jetty HTTP2 clients
risdenk commented on code in PR #1835:
URL: https://github.com/apache/solr/pull/1835#discussion_r1290795542
##
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/CommitStream.java:
##
@@ -55,6 +55,7 @@ public class CommitStream extends TupleStream implements
Expressible {
private TupleStream tupleSource;
private transient SolrClientCache clientCache;
+ private transient boolean isCloseCache;
Review Comment:
Do we need this new boolean `isCloseCache`? Can't we just check if
`clientCache == null` in the close method and set it to `clientCache = null`
after `clientCache.close();`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[GitHub] [solr] stillalex commented on a diff in pull request #1835: SOLR-16927 Allow SolrClientCache clients to use Jetty HTTP2 clients
stillalex commented on code in PR #1835:
URL: https://github.com/apache/solr/pull/1835#discussion_r1290830940
##
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/CommitStream.java:
##
@@ -55,6 +55,7 @@ public class CommitStream extends TupleStream implements
Expressible {
private TupleStream tupleSource;
private transient SolrClientCache clientCache;
+ private transient boolean isCloseCache;
Review Comment:
you are right. there are 2 patterns of doing this in the PR (flag vs null
check). I will switch to this one, it's cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
