[jira] [Commented] (IGNITE-22317) [Extensions] Release Ignite Spring Extensions
[ https://issues.apache.org/jira/browse/IGNITE-22317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864505#comment-17864505 ] Aleksey Plekhanov commented on IGNITE-22317: [~anovikov] can you please don't break compilation for JDK<17? It's a second time already when you break the master branch with this activity ([https://github.com/apache/ignite-extensions/commit/8f50f512ac48fe8be9660b4c78e99a55a7a41ae2|https://github.com/apache/ignite-extensions/commit/8f50f512ac48fe8be9660b4c78e99a55a7a41ae2,] [https://github.com/apache/ignite-extensions/commit/49cec55354df85ad592ed14d28d2e1dda53e072b]) We are still on java 8, and project should be compiled on java 8 and java 11, not only on java 17. Github workflow should use minimal supported java version. What for spring-auto-restdocs-json-doclet-jdk9 has been added? No information in the ticket about this. Are we use generated JSON javadoc anywhere? This plugin: * Break java8 compilation * Has some problem with jackson dependency version and check each version from all available repositories (and in some time in the future can be broken by the new jackson version, since version is not fixed) * Has been deprecated by the authors several years ago I propose to revert changes from [https://github.com/apache/ignite-extensions/commit/49cec55354df85ad592ed14d28d2e1dda53e072b] not related to release notes and maven-deploy-plugin. > [Extensions] Release Ignite Spring Extensions > - > > Key: IGNITE-22317 > URL: https://issues.apache.org/jira/browse/IGNITE-22317 > Project: Ignite > Issue Type: Task > Components: extensions >Reporter: Andrey Novikov >Assignee: Andrey Novikov >Priority: Major > Fix For: 2.16 > > > The following extenstions must be released: > - ignite-spring-data-ext > - ignite-spring-session-ext > - ignite-spring-cache-ext > - ignite-spring-tx-ext -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22696) Add prometheus libs to opensensus module
[ https://issues.apache.org/jira/browse/IGNITE-22696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matvei Kalistratov updated IGNITE-22696: Ignite Flags: (was: Docs Required,Release Notes Required) > Add prometheus libs to opensensus module > > > Key: IGNITE-22696 > URL: https://issues.apache.org/jira/browse/IGNITE-22696 > Project: Ignite > Issue Type: Improvement >Reporter: Matvei Kalistratov >Assignee: Matvei Kalistratov >Priority: Major > > For now I have to download number of jars to configure metrics in prometheus > format for AI and point JVM_OPTS to these jar. Or build the jar by myself as > described in > [https://www.gridgain.com/resources/blog/setting-prometheus-apache-ignite-and-gridgain]. > Only after that it becomes possible to configure metrics using AI config. > That's quite uncomfortable to do that running AI in container in docker or > k8s and requires additional storage and init container to download, build and > store these jars, change config after that and restart AI. > Needed to add necessary libs to opensensus module to make it possible to > configure prometheus metrics exposing from the box. It should be enough just > to change AI config to get prometheus metrics work. > Libs needs to be added: > - io.prometheus simpleclient_httpserver > - io.opencensus opencensus-exporter-stats-prometheus -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-22701) Sql. Use compiled code to evaluate values of literals
Maksim Zhuravkov created IGNITE-22701: - Summary: Sql. Use compiled code to evaluate values of literals Key: IGNITE-22701 URL: https://issues.apache.org/jira/browse/IGNITE-22701 Project: Ignite Issue Type: Improvement Components: sql Reporter: Maksim Zhuravkov ExpressionFactory evaluates values of RexLiterals manually instead of using the code generated RexToLitTranslator. This creates two distinct code paths to do the same thing. Update ExpressionFactory use the same code as RexToLitTranslator. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-22702) Rewrite CREATE TABLE FROM QUERY RESULT in tests.
Iurii Gerzhedovich created IGNITE-22702: --- Summary: Rewrite CREATE TABLE FROM QUERY RESULT in tests. Key: IGNITE-22702 URL: https://issues.apache.org/jira/browse/IGNITE-22702 Project: Ignite Issue Type: Improvement Components: sql Reporter: Iurii Gerzhedovich We have muted a bunch of tests under IGNITE-17268, as we don't support CREATE TABLE from a query result. We could quickly unmute such tests just to rewrite them to separate create table statement and insert statement. Let's unmute all such tests. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22701) Sql. Use compiled code to evaluate values of literals
[ https://issues.apache.org/jira/browse/IGNITE-22701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maksim Zhuravkov updated IGNITE-22701: -- Description: ExpressionFactory evaluates values of RexLiterals manually instead of using the code generated by RexToLitTranslator. This creates two distinct code paths to do the same thing. ExpressionFactory should use code generated by RexToLitTranslator for evaluating RexLiterals. was: ExpressionFactory evaluates values of RexLiterals manually instead of using the code generated RexToLitTranslator. This creates two distinct code paths to do the same thing. Update ExpressionFactory use the same code as RexToLitTranslator. > Sql. Use compiled code to evaluate values of literals > - > > Key: IGNITE-22701 > URL: https://issues.apache.org/jira/browse/IGNITE-22701 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Maksim Zhuravkov >Priority: Major > Labels: ignite-3 > > ExpressionFactory evaluates values of RexLiterals manually instead of using > the code generated by RexToLitTranslator. This creates two distinct code > paths to do the same thing. > ExpressionFactory should use code generated by RexToLitTranslator for > evaluating RexLiterals. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-22703) Sql. Low performance for select with mixed projection
Iurii Gerzhedovich created IGNITE-22703: --- Summary: Sql. Low performance for select with mixed projection Key: IGNITE-22703 URL: https://issues.apache.org/jira/browse/IGNITE-22703 Project: Ignite Issue Type: Improvement Components: sql Reporter: Iurii Gerzhedovich We have low performance in case we reorder columns in SELECT statement. Below result of my laptop for SELECT from a table with 600k rows. The first one is to select all columns in the same order as was declared during creating the table, the second one - reorder the first and the second columns in the select list. ||Benchmark||(queryId) ||Mode||Cnt||Score||Error||Units|| |TpchBenchmark.run |1|avgt|20|206.522|± 1.167|ms/op| |TpchBenchmark.run |2|avgt|20|784.153|± 1.792|ms/op| -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22703) Sql. Low performance for select with mixed projection
[ https://issues.apache.org/jira/browse/IGNITE-22703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Iurii Gerzhedovich updated IGNITE-22703: Labels: ignite-3 (was: sql) > Sql. Low performance for select with mixed projection > - > > Key: IGNITE-22703 > URL: https://issues.apache.org/jira/browse/IGNITE-22703 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Iurii Gerzhedovich >Priority: Major > Labels: ignite-3 > > We have low performance in case we reorder columns in SELECT statement. > Below result of my laptop for SELECT from a table with 600k rows. The first > one is to select all columns in the same order as was declared during > creating the table, the second one - reorder the first and the second columns > in the select list. > > ||Benchmark||(queryId) ||Mode||Cnt||Score||Error||Units|| > |TpchBenchmark.run |1|avgt|20|206.522|± 1.167|ms/op| > |TpchBenchmark.run |2|avgt|20|784.153|± 1.792|ms/op| -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22700) Improve SQL quality in AI3
[ https://issues.apache.org/jira/browse/IGNITE-22700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Iurii Gerzhedovich updated IGNITE-22700: Description: We have many bugs and discrepancies with SQL Standard. Let's combine under the epic part of such issues, to divide all works into parts. was:We have many bugs and discrepancies with SQL Standard. Let's combine under the epic part of such issues, to divide all works into parts. > Improve SQL quality in AI3 > -- > > Key: IGNITE-22700 > URL: https://issues.apache.org/jira/browse/IGNITE-22700 > Project: Ignite > Issue Type: Epic > Components: sql >Reporter: Iurii Gerzhedovich >Priority: Major > Labels: ignite-3 > > We have many bugs and discrepancies with SQL Standard. Let's combine under > the epic part of such issues, to divide all works into parts. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-22704) Missing '--only-primary' argument of snapshot creation command
Vladimir Steshin created IGNITE-22704: - Summary: Missing '--only-primary' argument of snapshot creation command Key: IGNITE-22704 URL: https://issues.apache.org/jira/browse/IGNITE-22704 Project: Ignite Issue Type: Improvement Reporter: Vladimir Steshin The command 'control.sh --snapshot create --only-primary'' might create only-primaries snapshot. But the argument '--only-primary' is skipped now. Also, there is no test for that. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22704) Missing '--only-primary' argument of snapshot creation command
[ https://issues.apache.org/jira/browse/IGNITE-22704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Steshin updated IGNITE-22704: -- Description: The command `control.sh --snapshot create --only-primary` might create an only-primaries snapshot. But the argument '--only-primary' is skipped now. Also, there is no test for that. (was: The command 'control.sh --snapshot create --only-primary'' might create only-primaries snapshot. But the argument '--only-primary' is skipped now. Also, there is no test for that.) > Missing '--only-primary' argument of snapshot creation command > -- > > Key: IGNITE-22704 > URL: https://issues.apache.org/jira/browse/IGNITE-22704 > Project: Ignite > Issue Type: Improvement >Reporter: Vladimir Steshin >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The command `control.sh --snapshot create --only-primary` might create an > only-primaries snapshot. But the argument '--only-primary' is skipped now. > Also, there is no test for that. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22704) Missing '--only-primary' argument of snapshot creation command
[ https://issues.apache.org/jira/browse/IGNITE-22704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Steshin updated IGNITE-22704: -- Description: The command "_control.sh --snapshot create --only-primary_" might create an only-primaries snapshot. But the argument '--only-primary' is skipped now. Also, there is no test for that. (was: The command `control.sh --snapshot create --only-primary` might create an only-primaries snapshot. But the argument '--only-primary' is skipped now. Also, there is no test for that.) > Missing '--only-primary' argument of snapshot creation command > -- > > Key: IGNITE-22704 > URL: https://issues.apache.org/jira/browse/IGNITE-22704 > Project: Ignite > Issue Type: Improvement >Reporter: Vladimir Steshin >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The command "_control.sh --snapshot create --only-primary_" might create an > only-primaries snapshot. But the argument '--only-primary' is skipped now. > Also, there is no test for that. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-22150) .NET Thin 3.0: Implement Table partition API
[ https://issues.apache.org/jira/browse/IGNITE-22150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864574#comment-17864574 ] Pavel Tupitsyn commented on IGNITE-22150: - Merged to main: [be15cc7c9504b1c735b998ea8ff376c22a505c91|https://github.com/apache/ignite-3/commit/be15cc7c9504b1c735b998ea8ff376c22a505c91] > .NET Thin 3.0: Implement Table partition API > > > Key: IGNITE-22150 > URL: https://issues.apache.org/jira/browse/IGNITE-22150 > Project: Ignite > Issue Type: Improvement > Components: platforms, thin client >Reporter: Mikhail Pochatkin >Assignee: Pavel Tupitsyn >Priority: Major > Labels: ignite-3 > Time Spent: 50m > Remaining Estimate: 0h > > Need to implement *org.apache.ignite.table.partition.PartitionManager* > interface in .NET Thin Client. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (IGNITE-22153) Support partition filter in Criteria API
[ https://issues.apache.org/jira/browse/IGNITE-22153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Pochatkin resolved IGNITE-22153. Resolution: Won't Fix > Support partition filter in Criteria API > > > Key: IGNITE-22153 > URL: https://issues.apache.org/jira/browse/IGNITE-22153 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Mikhail Pochatkin >Priority: Major > Labels: ignite-3 > > After IGNITE-22065 and IGNITE-22152 we need to support partition filter in > Criteria API -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (IGNITE-22261) Deadlock on configuration application in NodeImpl when disruptors are full
[ https://issues.apache.org/jira/browse/IGNITE-22261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladislav Pyatkov reassigned IGNITE-22261: -- Assignee: Vladislav Pyatkov > Deadlock on configuration application in NodeImpl when disruptors are full > -- > > Key: IGNITE-22261 > URL: https://issues.apache.org/jira/browse/IGNITE-22261 > Project: Ignite > Issue Type: Bug >Reporter: Roman Puchkovskiy >Assignee: Vladislav Pyatkov >Priority: Major > Labels: ignite-3 > > # NodeImpl#executeApplyingTasks() takes NodeImpl.writeLock and calls > LogManager.appendEntries() > # LogManager tries to enqueue a task to diskQueue which is full, hence it > blocks until a task gets consumed from diskQueue > # diskQueue is consumed by StableClosureEventHandler > # StableClosureEventHandler tries to enqueue a task to > FSMCallerImpl#taskQueue, which is also full, so this also blocks until a task > gets consumed from FSMCallerImpl#taskQueue > # FSMCallerImpl#taskQueue is consumed by ApplyTaskHandler > # ApplyTaskHandler calls NodeImpl#onConfigurationChangeDone(), which tries > to take NodeImpl#writeLock > As a result, there is a deadlock: > NodeImpl#writeLock->LogManager#diskQueue->FSMCallerImpl#taskQueue->NodeImpl#writeLock > (disruptors are used as blocking queues in JRaft, so, when full, they act > like locks). > This was caught by ItNodeTest#testNodeTaskOverload() which uses extremely > short disruptors (2 items max each). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22519) Sql. Numerics. Conversion produces incorrect results
[ https://issues.apache.org/jira/browse/IGNITE-22519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Orlov updated IGNITE-22519: -- Fix Version/s: 3.0.0-beta2 > Sql. Numerics. Conversion produces incorrect results > > > Key: IGNITE-22519 > URL: https://issues.apache.org/jira/browse/IGNITE-22519 > Project: Ignite > Issue Type: Bug > Components: sql >Reporter: Maksim Zhuravkov >Assignee: Maksim Zhuravkov >Priority: Major > Labels: ignite-3 > Fix For: 3.0.0-beta2 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > 1. > {noformat} > SELECT CAST('100.1' AS BIGINT); > Values(tuples=[[{ 100 }]]): > {noformat} > *Expected result* > It should be an error because '100.1' can not be converted to BIGINT/long. > 2. > {noformat} > SELECT CAST(1e39 AS REAL); > Values(tuples=[[{ 1E39 }]]): > {noformat} > *Expected result* > Should be an overflow error > 3. > {noformat} > SELECT CAST(1e39 AS FLOAT); > Values(tuples=[[{ 1E39 }]]): > {noformat} > *Expected result* > Should be an overflow error -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-22696) Add prometheus libs to opensensus module
[ https://issues.apache.org/jira/browse/IGNITE-22696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864635#comment-17864635 ] Ignite TC Bot commented on IGNITE-22696: {panel:title=Branch: [pull/11426/head] Base: [master] : Possible Blockers (6)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1} {color:#d04437}Cache 7{color} [[tests 0 Exit Code , Failure on metric |https://ci.ignite.apache.org/viewLog.html?buildId=8305168]] {color:#d04437}Disk Page Compressions 1{color} [[tests 0 Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=8305255]] {color:#d04437}Calcite SQL{color} [[tests 1|https://ci.ignite.apache.org/viewLog.html?buildId=8305183]] * IgniteCalciteTestSuite: TableDdlIntegrationTest.alterTableLogging - Test has low fail rate in base branch 2,5% and is not flaky {color:#d04437}Snapshots 1{color} [[tests 1 Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=8305238]] * IgniteSnapshotTestSuite: IgniteSnapshotMXBeanTest.testCreateSnapshot[encryption=false, onlyPrimay=true] - Test has low fail rate in base branch 2,6% and is not flaky {color:#d04437}Basic 4{color} [[tests 1|https://ci.ignite.apache.org/viewLog.html?buildId=8305156]] * IgniteBasicTestSuite2: IgniteDiagnosticMessagesMultipleConnectionsTest.testTimeOutTxLock - Test has low fail rate in base branch 0,0% and is not flaky {panel} {panel:title=Branch: [pull/11426/head] Base: [master] : New Tests (4)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1} {color:#8b}Platform .NET (Windows){color} [[tests 4|https://ci.ignite.apache.org/viewLog.html?buildId=8305226]] * {color:#013220}exe: PartitionAwarenessTest.CachePut_AllPrimitiveTypes_RequestIsRoutedToPrimaryNode("???",2) - PASSED{color} * {color:#013220}exe: PartitionAwarenessWithClusterDiscoveryTest.CachePut_AllPrimitiveTypes_RequestIsRoutedToPrimaryNode("???",2) - PASSED{color} * {color:#013220}exe: ComputeTaskSessionTest.DistributesTaskSessionAttributeLocally - PASSED{color} * {color:#013220}exe: ComputeTaskSessionTest.DistributesTaskSessionAttributeRemotely - PASSED{color} {panel} [TeamCity *--> Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=8305260&buildTypeId=IgniteTests24Java8_RunAll] > Add prometheus libs to opensensus module > > > Key: IGNITE-22696 > URL: https://issues.apache.org/jira/browse/IGNITE-22696 > Project: Ignite > Issue Type: Improvement >Reporter: Matvei Kalistratov >Assignee: Matvei Kalistratov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > For now I have to download number of jars to configure metrics in prometheus > format for AI and point JVM_OPTS to these jar. Or build the jar by myself as > described in > [https://www.gridgain.com/resources/blog/setting-prometheus-apache-ignite-and-gridgain]. > Only after that it becomes possible to configure metrics using AI config. > That's quite uncomfortable to do that running AI in container in docker or > k8s and requires additional storage and init container to download, build and > store these jars, change config after that and restart AI. > Needed to add necessary libs to opensensus module to make it possible to > configure prometheus metrics exposing from the box. It should be enough just > to change AI config to get prometheus metrics work. > Libs needs to be added: > - io.prometheus simpleclient_httpserver > - io.opencensus opencensus-exporter-stats-prometheus -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-22705) FIx javadocs warnings under jdk11
Maksim Timonin created IGNITE-22705: --- Summary: FIx javadocs warnings under jdk11 Key: IGNITE-22705 URL: https://issues.apache.org/jira/browse/IGNITE-22705 Project: Ignite Issue Type: Improvement Reporter: Maksim Timonin It's required to fix all javadocs warnings under jdk11. Steps to reproduce: # Setup local jdk version to 11 # ./mvnw -DskipTests -Pall-java clean install # ./mvnw initialize -Pjavadoc It produces a lot of warnings like {code:java} [WARNING] /Users/maksim/work/ignite/modules/core/src/main/java/org/apache/ignite/cluster/ClusterNode.java:48: warning - invalid usage of tag > {code} Let's fix all of them and provide automatic check of PR that no warnings appeared. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22705) FIx javadocs warnings under jdk11
[ https://issues.apache.org/jira/browse/IGNITE-22705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maksim Timonin updated IGNITE-22705: Labels: good-first-issue (was: ) > FIx javadocs warnings under jdk11 > - > > Key: IGNITE-22705 > URL: https://issues.apache.org/jira/browse/IGNITE-22705 > Project: Ignite > Issue Type: Improvement >Reporter: Maksim Timonin >Priority: Major > Labels: good-first-issue > > It's required to fix all javadocs warnings under jdk11. > Steps to reproduce: > # Setup local jdk version to 11 > # ./mvnw -DskipTests -Pall-java clean install > # ./mvnw initialize -Pjavadoc > It produces a lot of warnings like > {code:java} > [WARNING] > /Users/maksim/work/ignite/modules/core/src/main/java/org/apache/ignite/cluster/ClusterNode.java:48: > warning - invalid usage of tag > > {code} > Let's fix all of them and provide automatic check of PR that no warnings > appeared. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22705) FIx javadocs warnings under jdk11
[ https://issues.apache.org/jira/browse/IGNITE-22705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maksim Timonin updated IGNITE-22705: Priority: Minor (was: Major) > FIx javadocs warnings under jdk11 > - > > Key: IGNITE-22705 > URL: https://issues.apache.org/jira/browse/IGNITE-22705 > Project: Ignite > Issue Type: Improvement >Reporter: Maksim Timonin >Priority: Minor > Labels: good-first-issue > > It's required to fix all javadocs warnings under jdk11. > Steps to reproduce: > # Setup local jdk version to 11 > # ./mvnw -DskipTests -Pall-java clean install > # ./mvnw initialize -Pjavadoc > It produces a lot of warnings like > {code:java} > [WARNING] > /Users/maksim/work/ignite/modules/core/src/main/java/org/apache/ignite/cluster/ClusterNode.java:48: > warning - invalid usage of tag > > {code} > Let's fix all of them and provide automatic check of PR that no warnings > appeared. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22705) FIx javadocs warnings under jdk11
[ https://issues.apache.org/jira/browse/IGNITE-22705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maksim Timonin updated IGNITE-22705: Ignite Flags: (was: Docs Required,Release Notes Required) > FIx javadocs warnings under jdk11 > - > > Key: IGNITE-22705 > URL: https://issues.apache.org/jira/browse/IGNITE-22705 > Project: Ignite > Issue Type: Improvement >Reporter: Maksim Timonin >Priority: Major > Labels: good-first-issue > > It's required to fix all javadocs warnings under jdk11. > Steps to reproduce: > # Setup local jdk version to 11 > # ./mvnw -DskipTests -Pall-java clean install > # ./mvnw initialize -Pjavadoc > It produces a lot of warnings like > {code:java} > [WARNING] > /Users/maksim/work/ignite/modules/core/src/main/java/org/apache/ignite/cluster/ClusterNode.java:48: > warning - invalid usage of tag > > {code} > Let's fix all of them and provide automatic check of PR that no warnings > appeared. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22705) FIx javadocs warnings under jdk11
[ https://issues.apache.org/jira/browse/IGNITE-22705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maksim Timonin updated IGNITE-22705: Description: It's required to fix all javadocs warnings under jdk11. Steps to reproduce: # Setup local jdk version to 11 # ./mvnw -DskipTests -Pall-java clean install # ./mvnw initialize -Pjavadoc It produces a lot of warnings to stdout like {code:java} [WARNING] /Users/maksim/work/ignite/modules/core/src/main/java/org/apache/ignite/cluster/ClusterNode.java:48: warning - invalid usage of tag > {code} Let's fix all of them and provide automatic check of PR that no warnings appeared. was: It's required to fix all javadocs warnings under jdk11. Steps to reproduce: # Setup local jdk version to 11 # ./mvnw -DskipTests -Pall-java clean install # ./mvnw initialize -Pjavadoc It produces a lot of warnings like {code:java} [WARNING] /Users/maksim/work/ignite/modules/core/src/main/java/org/apache/ignite/cluster/ClusterNode.java:48: warning - invalid usage of tag > {code} Let's fix all of them and provide automatic check of PR that no warnings appeared. > FIx javadocs warnings under jdk11 > - > > Key: IGNITE-22705 > URL: https://issues.apache.org/jira/browse/IGNITE-22705 > Project: Ignite > Issue Type: Improvement >Reporter: Maksim Timonin >Priority: Minor > Labels: good-first-issue > > It's required to fix all javadocs warnings under jdk11. > Steps to reproduce: > # Setup local jdk version to 11 > # ./mvnw -DskipTests -Pall-java clean install > # ./mvnw initialize -Pjavadoc > It produces a lot of warnings to stdout like > {code:java} > [WARNING] > /Users/maksim/work/ignite/modules/core/src/main/java/org/apache/ignite/cluster/ClusterNode.java:48: > warning - invalid usage of tag > > {code} > Let's fix all of them and provide automatic check of PR that no warnings > appeared. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22295) Sql. Allow comparable types for common columns in NATURAL / USING join conditions
[ https://issues.apache.org/jira/browse/IGNITE-22295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Iurii Gerzhedovich updated IGNITE-22295: Epic Link: IGNITE-22700 > Sql. Allow comparable types for common columns in NATURAL / USING join > conditions > - > > Key: IGNITE-22295 > URL: https://issues.apache.org/jira/browse/IGNITE-22295 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Maksim Zhuravkov >Assignee: Pavel Pereslegin >Priority: Minor > Labels: ignite-3 > > As type coercion for NATURAL/USING join conditions is not invoked, such > queries produce incorrect results when column types of common columns do not > match. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (IGNITE-22704) Missing '--only-primary' argument of snapshot creation command
[ https://issues.apache.org/jira/browse/IGNITE-22704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Steshin closed IGNITE-22704. - > Missing '--only-primary' argument of snapshot creation command > -- > > Key: IGNITE-22704 > URL: https://issues.apache.org/jira/browse/IGNITE-22704 > Project: Ignite > Issue Type: Improvement >Reporter: Vladimir Steshin >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > The command "_control.sh --snapshot create --only-primary_" might create an > only-primaries snapshot. But the argument '--only-primary' is skipped now. > Also, there is no test for that. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22704) Missing '--only-primary' argument of snapshot creation command
[ https://issues.apache.org/jira/browse/IGNITE-22704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Steshin updated IGNITE-22704: -- Priority: Minor (was: Major) > Missing '--only-primary' argument of snapshot creation command > -- > > Key: IGNITE-22704 > URL: https://issues.apache.org/jira/browse/IGNITE-22704 > Project: Ignite > Issue Type: Improvement >Reporter: Vladimir Steshin >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > The command "_control.sh --snapshot create --only-primary_" might create an > only-primaries snapshot. But the argument '--only-primary' is skipped now. > Also, there is no test for that. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22704) Missing '--only-primary' argument of snapshot creation command
[ https://issues.apache.org/jira/browse/IGNITE-22704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Steshin updated IGNITE-22704: -- Ignite Flags: (was: Docs Required,Release Notes Required) > Missing '--only-primary' argument of snapshot creation command > -- > > Key: IGNITE-22704 > URL: https://issues.apache.org/jira/browse/IGNITE-22704 > Project: Ignite > Issue Type: Improvement >Reporter: Vladimir Steshin >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > The command "_control.sh --snapshot create --only-primary_" might create an > only-primaries snapshot. But the argument '--only-primary' is skipped now. > Also, there is no test for that. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (IGNITE-22704) Missing '--only-primary' argument of snapshot creation command
[ https://issues.apache.org/jira/browse/IGNITE-22704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Steshin resolved IGNITE-22704. --- Release Note: Irrelevant Resolution: Won't Fix > Missing '--only-primary' argument of snapshot creation command > -- > > Key: IGNITE-22704 > URL: https://issues.apache.org/jira/browse/IGNITE-22704 > Project: Ignite > Issue Type: Improvement >Reporter: Vladimir Steshin >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > The command "_control.sh --snapshot create --only-primary_" might create an > only-primaries snapshot. But the argument '--only-primary' is skipped now. > Also, there is no test for that. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-15570) JOIN with USING with common column names failed.
[ https://issues.apache.org/jira/browse/IGNITE-15570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Iurii Gerzhedovich updated IGNITE-15570: Epic Link: IGNITE-22700 > JOIN with USING with common column names failed. > > > Key: IGNITE-15570 > URL: https://issues.apache.org/jira/browse/IGNITE-15570 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Evgeny Stanilovsky >Priority: Major > Labels: calcite, calcite2-required, calcite3-required, ignite-3 > > {noformat} > statement ok > CREATE TABLE t1 (a INTEGER, b INTEGER, c INTEGER) > statement ok > INSERT INTO t1 VALUES (1,2,3) > statement ok > CREATE TABLE t2 (a INTEGER, b INTEGER, c INTEGER) > statement ok > INSERT INTO t2 VALUES (1,2,3), (2,2,4), (1,3,4) > query I > SELECT a+1 FROM t1 JOIN t2 USING(a) ORDER BY a > > 2 > 2 > {noformat} > failed with > {noformat} > org.apache.calcite.runtime.CalciteContextException: At line 1, column 46: > Column 'A' is ambiguous > at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) > at > sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) > at > sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) > at java.lang.reflect.Constructor.newInstance(Constructor.java:423) > at > org.apache.calcite.runtime.Resources$ExInstWithCause.ex(Resources.java:506) > at org.apache.calcite.sql.SqlUtil.newContextException(SqlUtil.java:917) > at org.apache.calcite.sql.SqlUtil.newContextException(SqlUtil.java:902) > {noformat} > {noformat} > /join/inner/test_using_join.test[_ignore] > {noformat} > checked with mysql - all ok there. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-15605) Calcite. Unexpected result with aggregate inside subquery.
[ https://issues.apache.org/jira/browse/IGNITE-15605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Iurii Gerzhedovich updated IGNITE-15605: Epic Link: IGNITE-22700 > Calcite. Unexpected result with aggregate inside subquery. > -- > > Key: IGNITE-15605 > URL: https://issues.apache.org/jira/browse/IGNITE-15605 > Project: Ignite > Issue Type: Bug > Components: sql >Reporter: Evgeny Stanilovsky >Assignee: Konstantin Orlov >Priority: Major > Labels: calcite, calcite2-required, calcite3-required, ignite-3 > > {noformat} > statement ok > CREATE TABLE integers(i INTEGER) > statement ok > INSERT INTO integers VALUES (1), (2), (3), (NULL) > query R SELECT i, SUM(i), (SELECT SUM(i)+SUM(i1.i) FROM integers) FROM > integers i1 GROUP BY i ORDER BY i; > > 1 1.00 10 > 2 2.00 14 > 3 3.00 18 > NULL NULL NULL {noformat} > {noformat} > /subquery/scalar/test_correlated_aggregate_subquery.test_ignore > /subquery/scalar/test_varchar_correlated_subquery.test_ignore > {noformat} > > {code:java} > Caused by: java.lang.ClassCastException: class java.lang.Long cannot be cast > to class java.lang.Integer (java.lang.Long and java.lang.Integer are in > module java.base of loader 'bootstrap') > at SC.execute(Unknown Source) > at > org.apache.ignite.internal.sql.engine.exec.exp.ExpressionFactoryImpl$ProjectImpl.apply(ExpressionFactoryImpl.java:654) > at > org.apache.ignite.internal.sql.engine.exec.rel.StorageScanNode.push(StorageScanNode.java:197) > at > org.apache.ignite.internal.sql.engine.exec.rel.StorageScanNode$SubscriberImpl.lambda$onComplete$2(StorageScanNode.java:303) > at > org.apache.ignite.internal.sql.engine.exec.ExecutionContext.lambda$execute$0(ExecutionContext.java:315){code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22697) Sql. Comparison on BIGINT cast brings overflow
[ https://issues.apache.org/jira/browse/IGNITE-22697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Iurii Gerzhedovich updated IGNITE-22697: Epic Link: IGNITE-22700 > Sql. Comparison on BIGINT cast brings overflow > -- > > Key: IGNITE-22697 > URL: https://issues.apache.org/jira/browse/IGNITE-22697 > Project: Ignite > Issue Type: Bug > Components: sql >Affects Versions: 3.0.0-beta1 >Reporter: Evgeny Stanilovsky >Priority: Major > Labels: ignite-3 > > {noformat} > create table tbl(v BIGINT); > insert into tbl values(9223372036854775807); > SELECT * FROM tbl WHERE v < 9223372036854775808::DECIMAL(19, 0); > {noformat} > will compile into: > {noformat} > try { > final Long input_value = (Long) ctx.rowHandler().get(0, in1); > final java.math.BigDecimal cast_value = input_value == null ? null : > org.apache.ignite.internal.sql.engine.exec.exp.IgniteSqlFunctions.toBigDecimal(input_value.longValue(), > 19, 0); > out.addField(cast_value == null ? null : > Boolean.valueOf(org.apache.calcite.runtime.SqlFunctions.lt(cast_value, > org.apache.ignite.internal.sql.engine.exec.exp.IgniteSqlFunctions.toBigDecimal("-9223372036854775808", > 19, 0; > } catch (Exception e) { > throw new org.apache.ignite.sql.SqlException( > 262151, > e); > } > {noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-20889) Sql. Change type derivation for literals and expressions for overflowed BIGINT
[ https://issues.apache.org/jira/browse/IGNITE-20889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Iurii Gerzhedovich updated IGNITE-20889: Epic Link: IGNITE-22700 > Sql. Change type derivation for literals and expressions for overflowed BIGINT > -- > > Key: IGNITE-20889 > URL: https://issues.apache.org/jira/browse/IGNITE-20889 > Project: Ignite > Issue Type: Improvement > Components: sql >Affects Versions: 3.0.0-beta1 >Reporter: Evgeny Stanilovsky >Priority: Major > Labels: ignite-3 > > After [1] will be merged, it become possible to control overflow with numeric > operations, there are 3 places in code (will be notified under this issue) > which have been changed but seems it`s all due to partially incorrect > (calcite?) implementation. I spend a bit time and found that case with > overflowed BIGINT insertion: *ItDmlTest#testInsertValueOverflow* can be fixed > by correct implementing: *SqlNumericLiteral#createSqlType*, i fast check and > seems it will began work properly well, without additional code changes (all > core manipulations in scope of [1] can be reverted). The second case: > insertion for overflowed SUM of BIGINT additional fix need to be done, > check: *SqlValidatorImpl#getValidatedNodeType* > Further research is required here. > [1] https://issues.apache.org/jira/browse/IGNITE-18662 > Just for note, for all above checks - i made dirty hack here: > IgniteSqlValidator#deriveType > {code:java} > if (expr instanceof SqlNumericLiteral) { > SqlNumericLiteral expr0 = (SqlNumericLiteral) expr; > if (expr0.toValue().length() > 10 && expr0.getTypeName() == > SqlTypeName.DECIMAL) { > return typeFactory.createSqlType( > SqlTypeName.DECIMAL, > requireNonNull(20, "prec"), > 0); > } > } > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-18414) SQL. Cannot use BigInteger class as parameters for query
[ https://issues.apache.org/jira/browse/IGNITE-18414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Iurii Gerzhedovich updated IGNITE-18414: Epic Link: IGNITE-22700 > SQL. Cannot use BigInteger class as parameters for query > > > Key: IGNITE-18414 > URL: https://issues.apache.org/jira/browse/IGNITE-18414 > Project: Ignite > Issue Type: Bug > Components: sql >Reporter: Iurii Gerzhedovich >Priority: Major > Labels: ignite-3 > > imple broken scenario looks as > {code:java} > assertQuery("SELECT typeof( ? > )").withParams(BigInteger.valueOf(1)).returns(toSqlType(NUMBER)).check();{code} > In the case we have the following error: > {code:java} > org.opentest4j.AssertionFailedError: Collections are not equal (position 0): > Expected: [NUMBER] > Actual: [RecordType()] {code} > Let's use NUMERIC SQL type for BigInteger. > I check a bit more and found strange in some cases: > 1. assertQuery("SELECT UPPER(TYPEOF(? + ?))").withParams(1, 1d) : INTEGER > 2. assertQuery("SELECT UPPER(TYPEOF(? + ?))").withParams(1d, 1) : DOUBLE ??? > is it ok > 3. assertQuery("SELECT UPPER(TYPEOF(?::FLOAT + ?))").withParams(1, 1) : FLOAT > 4. assertQuery("SELECT UPPER(TYPEOF(? + ?::DOUBLE))").withParams(1, 1d) : > DOUBLE ??? change from 1 only by cast - changes return, is it ok > 5. assertQuery("SELECT UPPER(TYPEOF(?::FLOAT + ?))").withParams(1, 1d) : > FLOAT ??? i expect double here. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22605) Wrong certificate chain might lead to split brain
[ https://issues.apache.org/jira/browse/IGNITE-22605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maksim Timonin updated IGNITE-22605: Description: There is a flaky test {code:java} TcpDiscoverySslTrustedUntrustedTest#testMismatchingCaFirst{code} Connection might close on writing header or message to the open socket. It might happen due to a recipient ultimately closes connection on SSL handshake. In a such case sender decides that connection can't be established due to no alive nodes are exist. It starts creating own topology instead of failing with SSL error. Instead, node should additionally check a socket for SSL errors. was: There is a flaky test {code:java} TcpDiscoverySslTrustedUntrustedTest#testMismatchingCaFirst{code} Connection might close on writing header or message to the open socket. It might happen due to a recipient ultimately closes connection on SSL handshake. In a such case sender decides that connection can't be established due to no alive nodes are exist. It starts creating own topology instead of failing with SSL error. Instead, node should additionally check a socket for SSL errors. > Wrong certificate chain might lead to split brain > - > > Key: IGNITE-22605 > URL: https://issues.apache.org/jira/browse/IGNITE-22605 > Project: Ignite > Issue Type: Bug >Reporter: Maksim Timonin >Assignee: Maksim Timonin >Priority: Major > Labels: ise > Fix For: 2.17 > > > There is a flaky test > {code:java} > TcpDiscoverySslTrustedUntrustedTest#testMismatchingCaFirst{code} > Connection might close on writing header or message to the open socket. It > might happen due to a recipient ultimately closes connection on SSL > handshake. In a such case sender decides that connection can't be established > due to no alive nodes are exist. It starts creating own topology instead of > failing with SSL error. > Instead, node should additionally check a socket for SSL errors. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22605) Wrong certificate chain might lead to split brain
[ https://issues.apache.org/jira/browse/IGNITE-22605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maksim Timonin updated IGNITE-22605: Description: There is a flaky test {code:java} TcpDiscoverySslTrustedUntrustedTest#testMismatchingCaFirst{code} Connection might close on writing header or message to the open socket. It might happen due to a recipient ultimately closes connection on SSL handshake. In a such case sender decides that connection can't be established due to no alive nodes are exist. It starts creating own topology instead of failing with SSL error. Instead, node should additionally check a socket for SSL errors. was: There is a flaky test TcpDiscoverySslTrustedUntrustedTest#testMismatchingCaFirst Connection might fail on writing to the open socket while writing header or message. It might happen due to a receipent ultimately close connection on SSL handshake. The sender make a wrong decision that there is no cluster at all and it's a first node. > Wrong certificate chain might lead to split brain > - > > Key: IGNITE-22605 > URL: https://issues.apache.org/jira/browse/IGNITE-22605 > Project: Ignite > Issue Type: Bug >Reporter: Maksim Timonin >Assignee: Maksim Timonin >Priority: Major > Labels: ise > Fix For: 2.17 > > > There is a flaky test > > {code:java} > TcpDiscoverySslTrustedUntrustedTest#testMismatchingCaFirst{code} > > Connection might close on writing header or message to the open socket. It > might happen due to a recipient ultimately closes connection on SSL > handshake. In a such case sender decides that connection can't be established > due to no alive nodes are exist. It starts creating own topology instead of > failing with SSL error. > Instead, node should additionally check a socket for SSL errors. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22605) Wrong certificate chain might lead to split brain
[ https://issues.apache.org/jira/browse/IGNITE-22605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maksim Timonin updated IGNITE-22605: Description: There is a flaky test, it actually fails due to the bug. {code:java} TcpDiscoverySslTrustedUntrustedTest#testMismatchingCaFirst{code} Case is like as following: # Start node A # Try start node B with mismatching certificates (check them in the test) # Node B doesn't fail but starts new topology. Logic that leads to the error: # Node A started # Node B open socket to node A # Node B writes sequentially {{IGNITE_HEADER }}to the socket. # Node A receives the header, fails to handshake and close the connection with ssl error. # Node B doesn't read any ack after sending {{IGNITE_HEADER}} and tries send {{TcpDiscoveryHandshakeRequest}} # Socket is closed from node A and then node B decides that node A doesn't exist # Node B creates own topology. To fix this error, in case of SSL enabled the node B should wait for ack from node A and check it for errors. was: There is a flaky test {code:java} TcpDiscoverySslTrustedUntrustedTest#testMismatchingCaFirst{code} Connection might close on writing header or message to the open socket. It might happen due to a recipient ultimately closes connection on SSL handshake. In a such case sender decides that connection can't be established due to no alive nodes are exist. It starts creating own topology instead of failing with SSL error. Instead, node should additionally check a socket for SSL errors. > Wrong certificate chain might lead to split brain > - > > Key: IGNITE-22605 > URL: https://issues.apache.org/jira/browse/IGNITE-22605 > Project: Ignite > Issue Type: Bug >Reporter: Maksim Timonin >Assignee: Maksim Timonin >Priority: Major > Labels: ise > Fix For: 2.17 > > > There is a flaky test, it actually fails due to the bug. > {code:java} > TcpDiscoverySslTrustedUntrustedTest#testMismatchingCaFirst{code} > Case is like as following: > # Start node A > # Try start node B with mismatching certificates (check them in the test) > # Node B doesn't fail but starts new topology. > Logic that leads to the error: > # Node A started > # Node B open socket to node A > # Node B writes sequentially {{IGNITE_HEADER }}to the socket. > # Node A receives the header, fails to handshake and close the connection > with ssl error. > # Node B doesn't read any ack after sending {{IGNITE_HEADER}} and tries send > {{TcpDiscoveryHandshakeRequest}} > # Socket is closed from node A and then node B decides that node A doesn't > exist > # Node B creates own topology. > To fix this error, in case of SSL enabled the node B should wait for ack from > node A and check it for errors. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-22706) Sql. Unignore sql test related to group by alias
Iurii Gerzhedovich created IGNITE-22706: --- Summary: Sql. Unignore sql test related to group by alias Key: IGNITE-22706 URL: https://issues.apache.org/jira/browse/IGNITE-22706 Project: Ignite Issue Type: Improvement Components: sql Reporter: Iurii Gerzhedovich AI3 has a few muted tests under IGNITE-14885 however the ticket related just to AI3. Let's unmute it and check what another issue we have here. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22706) Sql. Unignore sql test related to group by alias
[ https://issues.apache.org/jira/browse/IGNITE-22706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Iurii Gerzhedovich updated IGNITE-22706: Epic Link: IGNITE-22700 > Sql. Unignore sql test related to group by alias > > > Key: IGNITE-22706 > URL: https://issues.apache.org/jira/browse/IGNITE-22706 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Iurii Gerzhedovich >Priority: Major > Labels: ignite-3 > > AI3 has a few muted tests under IGNITE-14885 however the ticket related just > to AI3. > Let's unmute it and check what another issue we have here. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (IGNITE-22477) BinaryTuple serialization format: Specification
[ https://issues.apache.org/jira/browse/IGNITE-22477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr resolved IGNITE-22477. Resolution: Fixed https://cwiki.apache.org/confluence/display/IGNITE/IEP-124%3A+User+Object+Serialization I've added the specification for plain inline schema but not for nested one. I think it is better to implement the plain part and then add support for nested types. > BinaryTuple serialization format: Specification > > > Key: IGNITE-22477 > URL: https://issues.apache.org/jira/browse/IGNITE-22477 > Project: Ignite > Issue Type: Improvement > Components: compute >Reporter: Aleksandr >Assignee: Aleksandr >Priority: Major > Labels: ignite-3 > > Specify the common binary tuple format that is going to be supported by Kv, > Record, and Compute apis. The specification should be defined in IEP. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-22707) Node fails when runtime exception occurs on snapshot start stage
Aleksey Plekhanov created IGNITE-22707: -- Summary: Node fails when runtime exception occurs on snapshot start stage Key: IGNITE-22707 URL: https://issues.apache.org/jira/browse/IGNITE-22707 Project: Ignite Issue Type: Bug Reporter: Aleksey Plekhanov Assignee: Aleksey Plekhanov Reproducer: {code:java} /** Any node failed. */ private boolean failed; /** {@inheritDoc} */ @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception { return super.getConfiguration(igniteInstanceName).setFailureHandler((ignite, ctx) -> failed = true); } /** @throws Exception If fails. */ @Test public void testExceptionOnStartStage() throws Exception { IgniteEx ignite = startGridsWithCache(2, dfltCacheCfg, CACHE_KEYS_RANGE); IgniteFuture fut = snp(ignite).createSnapshot(SNAPSHOT_NAME, null, false, onlyPrimary); File snpDir = snp(ignite).snapshotLocalDir(SNAPSHOT_NAME); assertTrue(snpDir.mkdirs()); File snpMeta = new File(snpDir, IgniteSnapshotManager.snapshotMetaFileName(ignite.localNode().consistentId().toString())); assertTrue(snpMeta.createNewFile()); assertThrowsAnyCause(log, fut::get, IgniteException.class, "Snapshot metafile must not exist"); assertFalse(failed); } {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-22564) Decouple metastore and CMG RAFT log from data partitions RAFT log
[ https://issues.apache.org/jira/browse/IGNITE-22564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864696#comment-17864696 ] Kirill Sizov commented on IGNITE-22564: Created a PR with the PoC of Raft decoupling. Now it's possible to host CMG and Metastore in separate dirs, though by default they're placed inside node's working dir. At the moment this change is not backward compatible with the existing schema. Need more development to add backward compatibility. > Decouple metastore and CMG RAFT log from data partitions RAFT log > - > > Key: IGNITE-22564 > URL: https://issues.apache.org/jira/browse/IGNITE-22564 > Project: Ignite > Issue Type: Improvement >Reporter: Vladimir Pligin >Assignee: Kirill Sizov >Priority: Major > Labels: ignite-3 > > Currently, RAFT logs for all subsystems are stored in subdirectories within > the same working directory. During high load, Ignite may reach the disk I/O > throughput limits. To mitigate this, splitting RAFT storage access across > multiple disks can be beneficial. > One solution is to separate the metadata (CMG and Metastore) RAFT logs from > the data partitions RAFT logs, placing them on different disks. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (IGNITE-22564) Decouple metastore and CMG RAFT log from data partitions RAFT log
[ https://issues.apache.org/jira/browse/IGNITE-22564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864696#comment-17864696 ] Kirill Sizov edited comment on IGNITE-22564 at 7/10/24 2:52 PM: - Created a PR with the PoC of Raft decoupling. [https://github.com/apache/ignite-3/pull/4005] Now it's possible to host CMG and Metastore in separate dirs, though by default they're placed inside node's working dir. At the moment this change is not backward compatible with the existing schema. Need more development to add backward compatibility. was (Author: JIRAUSER301198): Created a PR with the PoC of Raft decoupling. Now it's possible to host CMG and Metastore in separate dirs, though by default they're placed inside node's working dir. At the moment this change is not backward compatible with the existing schema. Need more development to add backward compatibility. > Decouple metastore and CMG RAFT log from data partitions RAFT log > - > > Key: IGNITE-22564 > URL: https://issues.apache.org/jira/browse/IGNITE-22564 > Project: Ignite > Issue Type: Improvement >Reporter: Vladimir Pligin >Assignee: Kirill Sizov >Priority: Major > Labels: ignite-3 > > Currently, RAFT logs for all subsystems are stored in subdirectories within > the same working directory. During high load, Ignite may reach the disk I/O > throughput limits. To mitigate this, splitting RAFT storage access across > multiple disks can be beneficial. > One solution is to separate the metadata (CMG and Metastore) RAFT logs from > the data partitions RAFT logs, placing them on different disks. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (IGNITE-22310) Handling of TxCleanupMessage takes too much time on the network thread
[ https://issues.apache.org/jira/browse/IGNITE-22310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirill Sizov reassigned IGNITE-22310: -- Assignee: Kirill Sizov > Handling of TxCleanupMessage takes too much time on the network thread > --- > > Key: IGNITE-22310 > URL: https://issues.apache.org/jira/browse/IGNITE-22310 > Project: Ignite > Issue Type: Improvement >Reporter: Aleksandr Polovtsev >Assignee: Kirill Sizov >Priority: Major > Labels: ignite-3 > > When running tests on my local machine, I've encountered a lot of messages > like "Message handling has been too long" for messages of type > {{{}TxCleanupMessage{}}}. Looks like the sync part of the > {{TxCleanupRequestHandler}} should either be optimized or dispatched onto a > different thread. > The reason is that we have the following flow: tx finish (on commit > partition) -> tx cleanup (on every node containing enlisted partitions) -> tx > write intent switch (on every enlisted partition). In the case of commit > partition all of this is executed on the same node, so the network engine > does "send to self" without changing the thread. In other words, on commit > partition the flow is following: tx finish (partition operations thread) -> > tx cleanup (same thread) -> tx write intent switch (same thread). > There is a network message handler measuring the time and writing the > mentioned message to log. In the case of tx cleanup on commit partition it > actually measures the tx write intent switch, which is not very fast and > happens synchronously because we started tx cleanup already being within a > partition operations thread. Seems that this time measuring handler should be > aware of the thread permissions and not write any warnings when the current > thread has (storage_read, storage_write) permissions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-22670) Test cases update for KafkaToIgniteLoaderTest
[ https://issues.apache.org/jira/browse/IGNITE-22670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864702#comment-17864702 ] Maksim Davydov commented on IGNITE-22670: - https://ci2.ignite.apache.org/buildConfiguration/IgniteExtensions_Tests_Cdc/7954843?expandBuildDeploymentsSection=false&hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildChangesSection=true > Test cases update for KafkaToIgniteLoaderTest > - > > Key: IGNITE-22670 > URL: https://issues.apache.org/jira/browse/IGNITE-22670 > Project: Ignite > Issue Type: Test > Components: extensions >Reporter: Maksim Davydov >Assignee: Maksim Davydov >Priority: Trivial > Labels: IEP-59, ise > > KafkaToIgniteLoaderTest doesn't cover all possible errors in > KafkaToIgniteCdcStreamerConfiguration. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (IGNITE-22658) Obsolete documentation in IgniteCatalog
[ https://issues.apache.org/jira/browse/IGNITE-22658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr reassigned IGNITE-22658: -- Assignee: Aleksandr > Obsolete documentation in IgniteCatalog > --- > > Key: IGNITE-22658 > URL: https://issues.apache.org/jira/browse/IGNITE-22658 > Project: Ignite > Issue Type: Bug >Reporter: Roman Puchkovskiy >Assignee: Aleksandr >Priority: Major > Labels: ignite-3 > > IgniteCatalog contains examples that are obsolete. They can be identified by > grepping for 'ignite.catalog().create'. > All these examples mention a method called execute(), but it's not there > anymore. Also, some of them mention methods called created() which don't seem > to exist as well. > Also, createZone() lacks javadoc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (IGNITE-22646) Java Client Marshaler API
[ https://issues.apache.org/jira/browse/IGNITE-22646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr reassigned IGNITE-22646: -- Assignee: Aleksandr > Java Client Marshaler API > - > > Key: IGNITE-22646 > URL: https://issues.apache.org/jira/browse/IGNITE-22646 > Project: Ignite > Issue Type: Improvement >Reporter: Aleksandr >Assignee: Aleksandr >Priority: Major > Labels: ignite-3 > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-124%3A+User+Object+Serialization > KV and Compute API should support marshalers. As a result of this ticket, I > should be able to define any marshaller from the user type to byte[] and call > mentioned APIs with them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (IGNITE-22658) Obsolete documentation in IgniteCatalog
[ https://issues.apache.org/jira/browse/IGNITE-22658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr reassigned IGNITE-22658: -- Assignee: (was: Aleksandr) > Obsolete documentation in IgniteCatalog > --- > > Key: IGNITE-22658 > URL: https://issues.apache.org/jira/browse/IGNITE-22658 > Project: Ignite > Issue Type: Bug >Reporter: Roman Puchkovskiy >Priority: Major > Labels: ignite-3 > > IgniteCatalog contains examples that are obsolete. They can be identified by > grepping for 'ignite.catalog().create'. > All these examples mention a method called execute(), but it's not there > anymore. Also, some of them mention methods called created() which don't seem > to exist as well. > Also, createZone() lacks javadoc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22708) ItIgniteDistributionZoneManagerNodeRestartTest.testCreationZoneWhenDataNodesAreDeletedIsNotSuccessful is flaky
[ https://issues.apache.org/jira/browse/IGNITE-22708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Lapin updated IGNITE-22708: - Labels: ignite-3 (was: ) > ItIgniteDistributionZoneManagerNodeRestartTest.testCreationZoneWhenDataNodesAreDeletedIsNotSuccessful > is flaky > -- > > Key: IGNITE-22708 > URL: https://issues.apache.org/jira/browse/IGNITE-22708 > Project: Ignite > Issue Type: Bug >Reporter: Alexander Lapin >Priority: Major > Labels: ignite-3 > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22708) ItIgniteDistributionZoneManagerNodeRestartTest.testCreationZoneWhenDataNodesAreDeletedIsNotSuccessful is flaky
[ https://issues.apache.org/jira/browse/IGNITE-22708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Lapin updated IGNITE-22708: - Epic Link: IGNITE-21389 > ItIgniteDistributionZoneManagerNodeRestartTest.testCreationZoneWhenDataNodesAreDeletedIsNotSuccessful > is flaky > -- > > Key: IGNITE-22708 > URL: https://issues.apache.org/jira/browse/IGNITE-22708 > Project: Ignite > Issue Type: Bug >Reporter: Alexander Lapin >Assignee: Alexander Lapin >Priority: Major > Labels: ignite-3 > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-22708) ItIgniteDistributionZoneManagerNodeRestartTest.testCreationZoneWhenDataNodesAreDeletedIsNotSuccessful is flaky
Alexander Lapin created IGNITE-22708: Summary: ItIgniteDistributionZoneManagerNodeRestartTest.testCreationZoneWhenDataNodesAreDeletedIsNotSuccessful is flaky Key: IGNITE-22708 URL: https://issues.apache.org/jira/browse/IGNITE-22708 Project: Ignite Issue Type: Bug Reporter: Alexander Lapin -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22708) ItIgniteDistributionZoneManagerNodeRestartTest.testCreationZoneWhenDataNodesAreDeletedIsNotSuccessful is flaky
[ https://issues.apache.org/jira/browse/IGNITE-22708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Lapin updated IGNITE-22708: - Description: {code:java} [2024-07-10T14:57:41,202][ERROR][%iidzmnrt_tczwdnadins_0%metastorage-watch-executor-0][FailureProcessor] Critical system error detected. Will be handled accordingly to configured handler [hnd=NoOpFailureHandler [super=AbstractFailureHandler [ignoredFailureTypes=UnmodifiableSet [SYSTEM_WORKER_BLOCKED, SYSTEM_CRITICAL_OPERATION_TIMEOUT]]], failureCtx=FailureContext [type=CRITICAL_ERROR, err=java.lang.NullPointerException]] java.lang.NullPointerException: null at org.apache.ignite.internal.distributionzones.rebalance.ZoneRebalanceUtil.zoneAssignments(ZoneRebalanceUtil.java:588) ~[ignite-distribution-zones-3.0.0-SNAPSHOT.jar:?] at org.apache.ignite.internal.distributionzones.rebalance.ZoneRebalanceUtil.triggerZonePartitionsRebalance(ZoneRebalanceUtil.java:281) ~[ignite-distribution-zones-3.0.0-SNAPSHOT.jar:?] at org.apache.ignite.internal.distributionzones.rebalance.DistributionZoneRebalanceEngineV2$2.lambda$onUpdate$0(DistributionZoneRebalanceEngineV2.java:171) ~[ignite-distribution-zones-3.0.0-SNAPSHOT.jar:?] at org.apache.ignite.internal.util.IgniteUtils.inBusyLockAsync(IgniteUtils.java:890) ~[ignite-core-3.0.0-SNAPSHOT.jar:?] at org.apache.ignite.internal.distributionzones.rebalance.DistributionZoneRebalanceEngineV2$2.onUpdate(DistributionZoneRebalanceEngineV2.java:141) ~[ignite-distribution-zones-3.0.0-SNAPSHOT.jar:?] at org.apache.ignite.internal.metastorage.server.Watch.onUpdate(Watch.java:67) ~[ignite-metastorage-3.0.0-SNAPSHOT.jar:?] at org.apache.ignite.internal.metastorage.server.WatchProcessor.notifyWatches(WatchProcessor.java:245) ~[ignite-metastorage-3.0.0-SNAPSHOT.jar:?] at org.apache.ignite.internal.metastorage.server.WatchProcessor.lambda$notifyWatches$4(WatchProcessor.java:193) ~[ignite-metastorage-3.0.0-SNAPSHOT.jar:?] {code} > ItIgniteDistributionZoneManagerNodeRestartTest.testCreationZoneWhenDataNodesAreDeletedIsNotSuccessful > is flaky > -- > > Key: IGNITE-22708 > URL: https://issues.apache.org/jira/browse/IGNITE-22708 > Project: Ignite > Issue Type: Bug >Reporter: Alexander Lapin >Assignee: Alexander Lapin >Priority: Major > Labels: ignite-3 > > {code:java} > [2024-07-10T14:57:41,202][ERROR][%iidzmnrt_tczwdnadins_0%metastorage-watch-executor-0][FailureProcessor] > Critical system error detected. Will be handled accordingly to configured > handler [hnd=NoOpFailureHandler [super=AbstractFailureHandler > [ignoredFailureTypes=UnmodifiableSet [SYSTEM_WORKER_BLOCKED, > SYSTEM_CRITICAL_OPERATION_TIMEOUT]]], failureCtx=FailureContext > [type=CRITICAL_ERROR, err=java.lang.NullPointerException]] > java.lang.NullPointerException: null > at > org.apache.ignite.internal.distributionzones.rebalance.ZoneRebalanceUtil.zoneAssignments(ZoneRebalanceUtil.java:588) > ~[ignite-distribution-zones-3.0.0-SNAPSHOT.jar:?] > at > org.apache.ignite.internal.distributionzones.rebalance.ZoneRebalanceUtil.triggerZonePartitionsRebalance(ZoneRebalanceUtil.java:281) > ~[ignite-distribution-zones-3.0.0-SNAPSHOT.jar:?] > at > org.apache.ignite.internal.distributionzones.rebalance.DistributionZoneRebalanceEngineV2$2.lambda$onUpdate$0(DistributionZoneRebalanceEngineV2.java:171) > ~[ignite-distribution-zones-3.0.0-SNAPSHOT.jar:?] > at > org.apache.ignite.internal.util.IgniteUtils.inBusyLockAsync(IgniteUtils.java:890) > ~[ignite-core-3.0.0-SNAPSHOT.jar:?] > at > org.apache.ignite.internal.distributionzones.rebalance.DistributionZoneRebalanceEngineV2$2.onUpdate(DistributionZoneRebalanceEngineV2.java:141) > ~[ignite-distribution-zones-3.0.0-SNAPSHOT.jar:?] > at > org.apache.ignite.internal.metastorage.server.Watch.onUpdate(Watch.java:67) > ~[ignite-metastorage-3.0.0-SNAPSHOT.jar:?] > at > org.apache.ignite.internal.metastorage.server.WatchProcessor.notifyWatches(WatchProcessor.java:245) > ~[ignite-metastorage-3.0.0-SNAPSHOT.jar:?] > at > org.apache.ignite.internal.metastorage.server.WatchProcessor.lambda$notifyWatches$4(WatchProcessor.java:193) > ~[ignite-metastorage-3.0.0-SNAPSHOT.jar:?] {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (IGNITE-22708) ItIgniteDistributionZoneManagerNodeRestartTest.testCreationZoneWhenDataNodesAreDeletedIsNotSuccessful is flaky
[ https://issues.apache.org/jira/browse/IGNITE-22708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Lapin reassigned IGNITE-22708: Assignee: Alexander Lapin > ItIgniteDistributionZoneManagerNodeRestartTest.testCreationZoneWhenDataNodesAreDeletedIsNotSuccessful > is flaky > -- > > Key: IGNITE-22708 > URL: https://issues.apache.org/jira/browse/IGNITE-22708 > Project: Ignite > Issue Type: Bug >Reporter: Alexander Lapin >Assignee: Alexander Lapin >Priority: Major > Labels: ignite-3 > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22708) ItIgniteDistributionZoneManagerNodeRestartTest.testCreationZoneWhenDataNodesAreDeletedIsNotSuccessful is flaky
[ https://issues.apache.org/jira/browse/IGNITE-22708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Lapin updated IGNITE-22708: - Ignite Flags: (was: Docs Required,Release Notes Required) > ItIgniteDistributionZoneManagerNodeRestartTest.testCreationZoneWhenDataNodesAreDeletedIsNotSuccessful > is flaky > -- > > Key: IGNITE-22708 > URL: https://issues.apache.org/jira/browse/IGNITE-22708 > Project: Ignite > Issue Type: Bug >Reporter: Alexander Lapin >Priority: Major > Labels: ignite-3 > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-22709) Use IndexMeta in ChangeIndexStatusTask
Kirill Tkalenko created IGNITE-22709: Summary: Use IndexMeta in ChangeIndexStatusTask Key: IGNITE-22709 URL: https://issues.apache.org/jira/browse/IGNITE-22709 Project: Ignite Issue Type: Improvement Reporter: Kirill Tkalenko Assignee: Kirill Tkalenko Use index metadata in *org.apache.ignite.internal.index.ChangeIndexStatusTask* to prevent problems associated with catalog compaction. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22682) Use IndexMeta in FullStateTransferIndexChooser
[ https://issues.apache.org/jira/browse/IGNITE-22682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirill Tkalenko updated IGNITE-22682: - Fix Version/s: 3.0.0-beta2 > Use IndexMeta in FullStateTransferIndexChooser > -- > > Key: IGNITE-22682 > URL: https://issues.apache.org/jira/browse/IGNITE-22682 > Project: Ignite > Issue Type: Improvement >Reporter: Kirill Tkalenko >Assignee: Kirill Tkalenko >Priority: Major > Labels: ignite-3 > Fix For: 3.0.0-beta2 > > Time Spent: 10m > Remaining Estimate: 0h > > Use index metadata in > *org.apache.ignite.internal.table.distributed.raft.snapshot.FullStateTransferIndexChooser* > to prevent problems associated with catalog compaction. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (IGNITE-22710) Add exception translation to implementations of Transaction
Roman Puchkovskiy created IGNITE-22710: -- Summary: Add exception translation to implementations of Transaction Key: IGNITE-22710 URL: https://issues.apache.org/jira/browse/IGNITE-22710 Project: Ignite Issue Type: Improvement Reporter: Roman Puchkovskiy -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (IGNITE-22710) Add exception translation to implementations of Transaction
[ https://issues.apache.org/jira/browse/IGNITE-22710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Puchkovskiy reassigned IGNITE-22710: -- Assignee: Roman Puchkovskiy > Add exception translation to implementations of Transaction > --- > > Key: IGNITE-22710 > URL: https://issues.apache.org/jira/browse/IGNITE-22710 > Project: Ignite > Issue Type: Improvement >Reporter: Roman Puchkovskiy >Assignee: Roman Puchkovskiy >Priority: Major > Labels: ignite-3 > > All methods that can throw exceptions should translate them to public ones. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (IGNITE-22710) Add exception translation to implementations of Transaction
[ https://issues.apache.org/jira/browse/IGNITE-22710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Puchkovskiy updated IGNITE-22710: --- Description: All methods that can throw exceptions should translate them to public ones. > Add exception translation to implementations of Transaction > --- > > Key: IGNITE-22710 > URL: https://issues.apache.org/jira/browse/IGNITE-22710 > Project: Ignite > Issue Type: Improvement >Reporter: Roman Puchkovskiy >Priority: Major > Labels: ignite-3 > > All methods that can throw exceptions should translate them to public ones. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-22636) Catalog compaction. Implement catalog compaction coordinator.
[ https://issues.apache.org/jira/browse/IGNITE-22636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864937#comment-17864937 ] Pavel Pereslegin commented on IGNITE-22636: --- [~korlov], [~mzhuravkov], please review the proposed changes. > Catalog compaction. Implement catalog compaction coordinator. > - > > Key: IGNITE-22636 > URL: https://issues.apache.org/jira/browse/IGNITE-22636 > Project: Ignite > Issue Type: Improvement >Reporter: Maksim Zhuravkov >Assignee: Pavel Pereslegin >Priority: Major > Labels: ignite-3 > Time Spent: 10m > Remaining Estimate: 0h > > Compaction coordinator initiates the process of catalog compaction: > 1. Ask each node in logical topology for its minimal required timed (for > node_i let's call this time Tmin_node_i ). > 2. Choose minimum required time of Tmin_node_i (let's call it Tmin) > 3. Select catalog version Cv with catalog timestamp Ct which Ct < Tmin. > 4. Invoke CatalogManager::compactCatalog with Ct on coordinator. > If Catalog up to version Cv has tables T1, ... Tn, then: > Each compaction initiation run should be postponed (step 4 is not performed), > if at least one node that owns partitions for tables (T1,.., Tn) is missing > from the current logical topology. > -If a remote node leaves the cluster, then:- > -If this node hosts at least one partition, the coordinator should wait until > this node either enters the cluster and then retry asking for Minimal Time, > or is removed from all assignments. In the latter case the absence of the > node may be simply ignored.- (should be done in a separate ticket) -- This message was sent by Atlassian Jira (v8.20.10#820010)