[GitHub] flink pull request #3538: FLINK-6051: Correct metrics scope names
GitHub user hadronzoo opened a pull request: https://github.com/apache/flink/pull/3538 FLINK-6051: Correct metrics scope names Closes FLINK-6051. You can merge this pull request into a Git repository by running: $ git pull https://github.com/orgsync/flink FLINK-6051 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3538.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3538 commit ab4332801428e14b8077a2a7669a51f8a1607ca3 Author: Joshua Griffith Date: 2017-03-14T17:10:12Z Correct metrics scope names Closes FLINK-6051. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3576: [FLINK-6132]Remove redundant code in CliFrontend.java
Github user hadronzoo commented on the issue: https://github.com/apache/flink/pull/3576 LGTM @zhengcanbin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3833: [FLINK-6221] Add PrometheusReporter
Github user hadronzoo commented on the issue: https://github.com/apache/flink/pull/3833 @mbode thanks for working on this! One thing that I've found useful when exporting Flink's statsd metrics to Prometheus is to make several of the metric fields tags: like `job_name`, `task_name`, `operator_name`, etc. This [statsd-exporter mapping](https://gist.github.com/hadronzoo/621b6a6dce7e2596d5643ce8d1e954ea) has tags that have worked well for me. I'm not tagging host names or IP addresses because Prometheus's Kubernetes support does that already, but that could be useful for people running standalone clusters. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---