[GitHub] [flink] flinkbot edited a comment on pull request #17814: [FLINK-24899][runtime] Enable data compression for blocking shuffle by default

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17814:
URL: https://github.com/apache/flink/pull/17814#issuecomment-971129699


   
   ## CI report:
   
   * e3269ea84366f74f9c04a6b3f7be723207958e1e Azure: 
[CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26635)
 
   * 24f77cae435bd8dfed5832b25b0d0bfb1791afb9 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26636)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] MartijnVisser commented on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2021-11-17 Thread GitBox


MartijnVisser commented on pull request #14376:
URL: https://github.com/apache/flink/pull/14376#issuecomment-971329553


   @maosuhan I can find a committer for a review. I do see two things currently 
standing out:
   
   1. It would be good to make sure that the commits are meeting the commit 
requirements, as per 
https://flink.apache.org/contributing/code-style-and-quality-pull-requests.html 
   2. The CI is not yet green due to a couple of issues. Have you seen them and 
can you resolve them?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-24727) Running Kerberized YARN per-job on Docker test (no fat-jar) fails on Azure

2021-11-17 Thread Arseniy Tashoyan (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-24727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444996#comment-17444996
 ] 

Arseniy Tashoyan commented on FLINK-24727:
--

[~guoyangze] thank you for this pointer.
I have deleted the PR, so this issue can be closed now.

> Running Kerberized YARN per-job on Docker test (no fat-jar) fails on Azure
> --
>
> Key: FLINK-24727
> URL: https://issues.apache.org/jira/browse/FLINK-24727
> Project: Flink
>  Issue Type: Bug
>  Components: Deployment / YARN, Tests
>Affects Versions: 1.14.0
>Reporter: Till Rohrmann
>Priority: Critical
>  Labels: test-stability
> Fix For: 1.15.0, 1.14.1
>
>
> The e2e {{Running Kerberized YARN per-job on Docker test (no fat-jar)}} fails 
> on Azure.
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=25772&view=logs&j=c88eea3b-64a0-564d-0031-9fdcd7b8abee&t=070ff179-953e-5bda-71fa-d6599415701c



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink-ml] HuangXingBo opened a new pull request #36: [FLINK-24933][ML] Support ML Python API

2021-11-17 Thread GitBox


HuangXingBo opened a new pull request #36:
URL: https://github.com/apache/flink-ml/pull/36


   ## What is the purpose of the change
   This PR adds the ML python API.
   
   ## Brief change log
   This PR adds classes in the package of api/core and param.
   
   ## Verifying this change
   `test_pipeline.py` and `test_stage.py`.
   
   ## Does this pull request potentially affect one of the following parts:
   Dependencies (does it add or upgrade a dependency): (yes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-24894) Flink on k8s, open the HA mode based on KubernetesHaServicesFactory ,When I deleted the job, the config map created under the HA mechanism was not deleted.

2021-11-17 Thread Yangze Guo (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-24894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444997#comment-17444997
 ] 

Yangze Guo commented on FLINK-24894:


 > I think whether it is `delete deployment` or `cancel job`, HA data should be 
 > cleared at the same time

When the deployment is deleted, we do not know whether user still needs the HA 
data(jobGraph, checkpoints, etc.), and thus we do not delete it. The reason why 
the configMap is retained is to avoid resource leaks. Without the configMap, 
user cannot find where the HA data is. Also, user might want to create a new 
deployment with the same cluster-id and resume the job from the latest ckp.

[~spoon-lz] Please ask questions in u...@flink.apache.org instead of JIRA.

> Flink on k8s, open the HA mode based on KubernetesHaServicesFactory ,When I 
> deleted the job, the config map created under the HA mechanism was not 
> deleted.
> ---
>
> Key: FLINK-24894
> URL: https://issues.apache.org/jira/browse/FLINK-24894
> Project: Flink
>  Issue Type: Bug
>  Components: Deployment / Kubernetes
> Environment: 1.13.2 
>Reporter: john
>Priority: Major
>
> Flink on k8s, open the HA mode based on KubernetesHaServicesFactory. When I 
> deleted the job, the config map created under the HA mechanism was not 
> deleted. This leads to a problem: if my last concurrency was 100, changing to 
> 40 this time will not take effect. This can be understood because jobgraph 
> recovered from high-availability.storageDir and ignored the client's.
> My question is: When deleting a job, the config map created under the HA 
> mechanism is not deleted. Is this the default mechanism of HA, or is it a bug?



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (FLINK-24933) Support ML Python API

2021-11-17 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-24933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated FLINK-24933:
---
Labels: pull-request-available  (was: )

> Support ML Python API
> -
>
> Key: FLINK-24933
> URL: https://issues.apache.org/jira/browse/FLINK-24933
> Project: Flink
>  Issue Type: New Feature
>  Components: Library / Machine Learning
>Reporter: Huang Xingbo
>Assignee: Huang Xingbo
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.1.0
>
>
> Support ML Python API



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (FLINK-24727) Running Kerberized YARN per-job on Docker test (no fat-jar) fails on Azure

2021-11-17 Thread Yangze Guo (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-24727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yangze Guo closed FLINK-24727.
--
Resolution: Not A Problem

> Running Kerberized YARN per-job on Docker test (no fat-jar) fails on Azure
> --
>
> Key: FLINK-24727
> URL: https://issues.apache.org/jira/browse/FLINK-24727
> Project: Flink
>  Issue Type: Bug
>  Components: Deployment / YARN, Tests
>Affects Versions: 1.14.0
>Reporter: Till Rohrmann
>Priority: Critical
>  Labels: test-stability
> Fix For: 1.15.0, 1.14.1
>
>
> The e2e {{Running Kerberized YARN per-job on Docker test (no fat-jar)}} fails 
> on Azure.
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=25772&view=logs&j=c88eea3b-64a0-564d-0031-9fdcd7b8abee&t=070ff179-953e-5bda-71fa-d6599415701c



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (FLINK-24934) Python CI job fails with exit code 143

2021-11-17 Thread Matthias (Jira)
Matthias created FLINK-24934:


 Summary: Python CI job fails with exit code 143
 Key: FLINK-24934
 URL: https://issues.apache.org/jira/browse/FLINK-24934
 Project: Flink
  Issue Type: Bug
  Components: API / Python
Affects Versions: 1.15.0
Reporter: Matthias


I experienced a failure in the python stage which looks like a problem in the 
linter code?
https://dev.azure.com/mapohl/flink/_build/results?buildId=479&view=logs&j=fba17979-6d2e-591d-72f1-97cf42797c11&t=727942b6-6137-54f7-1ef9-e66e706ea068&l=22004
{code}
Nov 16 22:29:05 ==sphinx checks... [SUCCESS]==
Nov 16 22:29:05 ==tox checks==
Nov 16 22:29:05 GLOB sdist-make: /__w/1/s/flink-python/setup.py
Nov 16 22:29:06 py38 create: /__w/1/s/flink-python/.tox/py38
Nov 16 22:29:08 py38 installdeps: pytest, apache-beam==2.27.0, cython==0.29.24, 
grpcio>=1.29.0,<2, grpcio-tools>=1.3.5,<=1.14.2, apache-flink-libraries
Nov 16 22:44:25 
==
Nov 16 22:44:25 Process produced no output for 900 seconds.
Nov 16 22:44:25 
==
Nov 16 22:44:25 
==
Nov 16 22:44:25 The following Java processes are running (JPS)
Nov 16 22:44:25 
==
Picked up JAVA_TOOL_OPTIONS: -XX:+HeapDumpOnOutOfMemoryError
Nov 16 22:44:26 7241 Jps
Nov 16 22:44:26 
==
Nov 16 22:44:26 Printing stack trace of Java process 7241
Nov 16 22:44:26 
==
Picked up JAVA_TOOL_OPTIONS: -XX:+HeapDumpOnOutOfMemoryError
7241: No such process
Nov 16 22:44:26 Killing process with pid=662 and all descendants
./flink-python/dev/lint-python.sh: line 580:  1957 Terminated  
$TOX_PATH -c $FLINK_PYTHON_DIR/tox.ini -e ${LATEST_PYTHON} --recreate 2>&1
  1958 Done| tee -a $LOG_FILE
/__w/1/s/tools/ci/watchdog.sh: line 113:   662 Terminated  $cmd
Nov 16 22:44:26 Process exited with EXIT CODE: 143.
Nov 16 22:44:26 Trying to KILL watchdog (657).
{code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (FLINK-24934) Python CI job fails with exit code 143

2021-11-17 Thread Matthias (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-24934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matthias updated FLINK-24934:
-
Labels: test-stability  (was: )

> Python CI job fails with exit code 143
> --
>
> Key: FLINK-24934
> URL: https://issues.apache.org/jira/browse/FLINK-24934
> Project: Flink
>  Issue Type: Bug
>  Components: API / Python
>Affects Versions: 1.15.0
>Reporter: Matthias
>Priority: Major
>  Labels: test-stability
>
> I experienced a failure in the python stage which looks like a problem in the 
> linter code?
> https://dev.azure.com/mapohl/flink/_build/results?buildId=479&view=logs&j=fba17979-6d2e-591d-72f1-97cf42797c11&t=727942b6-6137-54f7-1ef9-e66e706ea068&l=22004
> {code}
> Nov 16 22:29:05 ==sphinx checks... [SUCCESS]==
> Nov 16 22:29:05 ==tox checks==
> Nov 16 22:29:05 GLOB sdist-make: /__w/1/s/flink-python/setup.py
> Nov 16 22:29:06 py38 create: /__w/1/s/flink-python/.tox/py38
> Nov 16 22:29:08 py38 installdeps: pytest, apache-beam==2.27.0, 
> cython==0.29.24, grpcio>=1.29.0,<2, grpcio-tools>=1.3.5,<=1.14.2, 
> apache-flink-libraries
> Nov 16 22:44:25 
> ==
> Nov 16 22:44:25 Process produced no output for 900 seconds.
> Nov 16 22:44:25 
> ==
> Nov 16 22:44:25 
> ==
> Nov 16 22:44:25 The following Java processes are running (JPS)
> Nov 16 22:44:25 
> ==
> Picked up JAVA_TOOL_OPTIONS: -XX:+HeapDumpOnOutOfMemoryError
> Nov 16 22:44:26 7241 Jps
> Nov 16 22:44:26 
> ==
> Nov 16 22:44:26 Printing stack trace of Java process 7241
> Nov 16 22:44:26 
> ==
> Picked up JAVA_TOOL_OPTIONS: -XX:+HeapDumpOnOutOfMemoryError
> 7241: No such process
> Nov 16 22:44:26 Killing process with pid=662 and all descendants
> ./flink-python/dev/lint-python.sh: line 580:  1957 Terminated  
> $TOX_PATH -c $FLINK_PYTHON_DIR/tox.ini -e ${LATEST_PYTHON} --recreate 2>&1
>   1958 Done| tee -a $LOG_FILE
> /__w/1/s/tools/ci/watchdog.sh: line 113:   662 Terminated  $cmd
> Nov 16 22:44:26 Process exited with EXIT CODE: 143.
> Nov 16 22:44:26 Trying to KILL watchdog (657).
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink] xiangqiao123 opened a new pull request #17816: [FLINK-24922][docs] Backport fix spelling errors in the word "parallism"

2021-11-17 Thread GitBox


xiangqiao123 opened a new pull request #17816:
URL: https://github.com/apache/flink/pull/17816


   ## What is the purpose of the change
   Fix the spelling error of "parallism" in the document of SQL client.
   
   ## Brief change log
 - Replace "parallism" to  "parallelism"  in the document of SQL client.
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): no
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
 - The serializers: no
 - The runtime per-record code paths (performance sensitive): no
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
 - The S3 file system connector: no
   
   ## Documentation
   
 - Does this pull request introduce a new feature? no
 - If yes, how is the feature documented? docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] Airblader commented on a change in pull request #17133: [Proof of Concept][FLINK-24138] Architectural tests

2021-11-17 Thread GitBox


Airblader commented on a change in pull request #17133:
URL: https://github.com/apache/flink/pull/17133#discussion_r701627280



##
File path: 
flink-table/flink-table-common/src/test/java/org/apache/flink/table/architecture/ArchitectureTests.java
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.architecture;
+
+import org.apache.flink.annotation.Experimental;
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.annotation.Public;
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.configuration.ConfigOption;
+import org.apache.flink.table.factories.DynamicTableFactory;
+import org.apache.flink.testutils.architecture.ApiRules;
+
+import com.tngtech.archunit.core.domain.JavaClass;
+import com.tngtech.archunit.core.domain.JavaField;
+import com.tngtech.archunit.core.domain.JavaModifier;
+import com.tngtech.archunit.core.importer.ImportOption;
+import com.tngtech.archunit.junit.AnalyzeClasses;
+import com.tngtech.archunit.junit.ArchTest;
+import com.tngtech.archunit.junit.ArchTests;
+import com.tngtech.archunit.junit.ArchUnitRunner;
+import com.tngtech.archunit.lang.ArchCondition;
+import com.tngtech.archunit.lang.ArchRule;
+import com.tngtech.archunit.lang.ConditionEvents;
+import com.tngtech.archunit.lang.SimpleConditionEvent;
+import org.junit.runner.RunWith;
+
+import java.util.Set;
+
+import static com.tngtech.archunit.lang.syntax.ArchRuleDefinition.classes;
+import static 
org.apache.flink.testutils.architecture.Predicates.areAnnotatedWithAtLeastOneOf;
+import static org.apache.flink.testutils.architecture.Predicates.fulfill;
+
+/** TODO. */
+@RunWith(ArchUnitRunner.class)
+@AnalyzeClasses(
+packages = "org.apache.flink.table",
+importOptions = ImportOption.DoNotIncludeTests.class)
+public class ArchitectureTests {
+@ArchTest public static final ArchTests APIS = 
ArchTests.in(ApiRules.class);
+
+/** Ensure that all classes in the API package have a proper annotation. */
+@ArchTest
+public static final ArchRule ANNOTATED_APIS =

Review comment:
   In flink-table-common this test currently identifies a couple of classes 
(all exceptions) which are not annotated.

##
File path: 
flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/architecture/ApiRules.java
##
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.testutils.architecture;
+
+import org.apache.flink.annotation.Public;
+import org.apache.flink.annotation.PublicEvolving;
+
+import com.tngtech.archunit.junit.ArchTest;
+import com.tngtech.archunit.lang.ArchRule;
+
+import static 
com.tngtech.archunit.core.domain.JavaClass.Predicates.resideOutsideOfPackage;
+import static com.tngtech.archunit.lang.syntax.ArchRuleDefinition.methods;
+import static 
org.apache.flink.testutils.architecture.Predicates.areAnnotatedWithAtLeastOneOf;
+import static 
org.apache.flink.testutils.architecture.Predicates.haveLeafArgumentTypes;
+import static 
org.apache.flink.testutils.architecture.Predicates.haveLeafReturnTypes;
+
+/** Architecture rules for APIs. */
+public class ApiRules {
+
+/**
+ * Ensure that public methods marked {@link Public} only use return and 
argument types which are
+ * also marked {@link Public}.
+ *
+ * Note that this is a stronger requirement than {@link
+ * #PUB

[jira] [Commented] (FLINK-24851) KafkaSourceBuilder: auto.offset.reset is ignored

2021-11-17 Thread Arseniy Tashoyan (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-24851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445000#comment-17445000
 ] 

Arseniy Tashoyan commented on FLINK-24851:
--

[~renqs] thank you for your proposal - looks good to me.
I would also suggest to have an overloaded method:

{code:java}
setProperties(Map settings)
{code}

This makes coding easier - no need to create the Properties object.

> KafkaSourceBuilder: auto.offset.reset is ignored
> 
>
> Key: FLINK-24851
> URL: https://issues.apache.org/jira/browse/FLINK-24851
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Kafka
>Affects Versions: 1.14.0
>Reporter: Arseniy Tashoyan
>Assignee: liwei li
>Priority: Major
>  Labels: pull-request-available
>
> Creating KafkaSource like this:
> {code:scala}
> val props = new Properties()
> props.put("bootstrap.servers", "localhost:9092")
> props.put("group.id", "group1")
> props.put("auto.offset.reset", "latest")
> val kafkaSource = KafkaSource.builder[String]()
>   .setProperties(props)
>   .build()
> {code}
> The actually used value for _"auto.offset.reset"_ is *"earliest"* instead of 
> configured *"latest"*.
> This occurs because _"auto.offset.reset"_ gets overridden by 
> _startingOffsetsInitializer.getAutoOffsetResetStrategy().name().toLowerCase()_.
>  The default value for _startingOffsetsInitializer_ is _"earliest"_.
> This behavior is misleading.
> This behavior imposes an inconvenience on configuring the Kafka connector. We 
> cannot use the Kafka setting _"auto.offset.reset"_ as-is. Instead we must 
> extract this particular setting from other settings and propagate to 
> _KafkaSourceBuilder.setStartingOffsets()_:
> {code:scala}
> val kafkaSource = KafkaSource.builder[String]()
>   .setProperties(props)
>   .setStartingOffsets(
> OffsetsInitializer.committedOffsets(
>   OffsetResetStrategy.valueOf(
> props.get(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG)
>   .asInstanceOf[String]
>   .toUpperCase(Locale.ROOT)
>   )
> )
>   )
>   .build()
> {code}
> The expected behavior is to use the value of _"auto.offset.reset"_ provided 
> by _KafkaSourceBuilder.setProperties()_ - unless overridden via 
> _KafkaSourceBuilder. setStartingOffsets()_.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink] flinkbot commented on pull request #17816: [FLINK-24922][docs] Backport fix spelling errors in the word "parallism"

2021-11-17 Thread GitBox


flinkbot commented on pull request #17816:
URL: https://github.com/apache/flink/pull/17816#issuecomment-971338462


   
   ## CI report:
   
   * 251f55c950101b10454bfb031469e8cd643ea512 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #17816: [FLINK-24922][docs] Backport fix spelling errors in the word "parallism"

2021-11-17 Thread GitBox


flinkbot commented on pull request #17816:
URL: https://github.com/apache/flink/pull/17816#issuecomment-971338716


   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit 251f55c950101b10454bfb031469e8cd643ea512 (Wed Nov 17 
08:17:16 UTC 2021)
   
   **Warnings:**
* **This pull request references an unassigned [Jira 
ticket](https://issues.apache.org/jira/browse/FLINK-24922).** According to the 
[code contribution 
guide](https://flink.apache.org/contributing/contribute-code.html), tickets 
need to be assigned before starting with the implementation work.
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17816: [FLINK-24922][docs] Backport fix spelling errors in the word "parallism"

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17816:
URL: https://github.com/apache/flink/pull/17816#issuecomment-971338462


   
   ## CI report:
   
   * 251f55c950101b10454bfb031469e8cd643ea512 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26641)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] xiangqiao123 opened a new pull request #17817: [FLINK-24922][docs] Backport fix spelling errors in the word "parallism"

2021-11-17 Thread GitBox


xiangqiao123 opened a new pull request #17817:
URL: https://github.com/apache/flink/pull/17817


   ## What is the purpose of the change
   Fix the spelling error of "parallism" in the document of SQL client.
   
   ## Brief change log
 - Replace "parallism" to  "parallelism"  in the document of SQL client.
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): no
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
 - The serializers: no
 - The runtime per-record code paths (performance sensitive): no
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
 - The S3 file system connector: no
   
   ## Documentation
   
 - Does this pull request introduce a new feature? no
 - If yes, how is the feature documented? docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #17817: [FLINK-24922][docs] Backport fix spelling errors in the word "parallism"

2021-11-17 Thread GitBox


flinkbot commented on pull request #17817:
URL: https://github.com/apache/flink/pull/17817#issuecomment-971344300


   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit 999fa42b698ec2d652d9e9b7c7db32b946231797 (Wed Nov 17 
08:25:42 UTC 2021)
   
   **Warnings:**
* **This pull request references an unassigned [Jira 
ticket](https://issues.apache.org/jira/browse/FLINK-24922).** According to the 
[code contribution 
guide](https://flink.apache.org/contributing/contribute-code.html), tickets 
need to be assigned before starting with the implementation work.
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #17817: [FLINK-24922][docs] Backport fix spelling errors in the word "parallism"

2021-11-17 Thread GitBox


flinkbot commented on pull request #17817:
URL: https://github.com/apache/flink/pull/17817#issuecomment-971344993


   
   ## CI report:
   
   * 999fa42b698ec2d652d9e9b7c7db32b946231797 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17817: [FLINK-24922][docs] Backport fix spelling errors in the word "parallism"

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17817:
URL: https://github.com/apache/flink/pull/17817#issuecomment-971344993


   
   ## CI report:
   
   * 999fa42b698ec2d652d9e9b7c7db32b946231797 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26642)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink-statefun] igalshilman closed pull request #275: Use JDK 8 Optional instead of shaded Optional class from Guava.

2021-11-17 Thread GitBox


igalshilman closed pull request #275:
URL: https://github.com/apache/flink-statefun/pull/275


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-24903) AdaptiveSchedulerTest.testJobStatusListenerNotifiedOfJobStatusChanges unstable

2021-11-17 Thread Yun Gao (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-24903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445007#comment-17445007
 ] 

Yun Gao commented on FLINK-24903:
-

[https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=26624&view=logs&j=77a9d8e1-d610-59b3-fc2a-4766541e0e33&t=125e07e7-8de0-5c6c-a541-a567415af3ef&l=7747]

> AdaptiveSchedulerTest.testJobStatusListenerNotifiedOfJobStatusChanges unstable
> --
>
> Key: FLINK-24903
> URL: https://issues.apache.org/jira/browse/FLINK-24903
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Coordination
>Affects Versions: 1.15.0
>Reporter: Roman Khachatryan
>Assignee: Chesnay Schepler
>Priority: Major
>  Labels: test-stability
> Fix For: 1.15.0
>
>
> [https://dev.azure.com/khachatryanroman/flink/_build/results?buildId=1225&view=logs&j=9dc1b5dc-bcfa-5f83-eaa7-0cb181ddc267&t=511d2595-ec54-5ab7-86ce-92f328796f20&l=7753]
>  {code}
>  2021-11-14T20:22:23.1142812Z Nov 14 20:22:23 [ERROR] Failures:
>  2021-11-14T20:22:23.1149388Z Nov 14 20:22:23 [ERROR]   
> AdaptiveSchedulerTest.testJobStatusListenerNotifiedOfJobStatusChanges:684
>  2021-11-14T20:22:23.1150058Z Nov 14 20:22:23 Expected: (a collection 
> containing  and a collection containing )
>  2021-11-14T20:22:23.1150581Z Nov 14 20:22:23  but: a collection 
> containing  was 
>  2021-11-14T20:22:23.1152966Z Nov 14 20:22:23 [INFO]
>  2021-11-14T20:22:23.1156414Z Nov 14 20:22:23 [ERROR] Tests run: 6048, 
> Failures: 1, Errors: 0, Skipped: 97
> {code}
> Locally, it fails ~14 runs out of 100 (when running only 
> testJobStatusListenerNotifiedOfJobStatusChanges in a loop).
> Also on master.
> It looks like job termination future is always completed before the 
> jobStatusChangeListener is notified (AdaptiveScheduler.transitionToState, 
> targetState.getState() completes the future).
> Sleeping for 1ms before checking the assertion prevents the failure.
>  
> cc: [~trohrmann] 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (FLINK-24495) Python installdeps hangs

2021-11-17 Thread Yun Gao (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-24495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445009#comment-17445009
 ] 

Yun Gao commented on FLINK-24495:
-

[https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=26624&view=logs&j=821b528f-1eed-5598-a3b4-7f748b13f261&t=6bb545dd-772d-5d8c-f258-f5085fba3295&l=23583]

> Python installdeps hangs
> 
>
> Key: FLINK-24495
> URL: https://issues.apache.org/jira/browse/FLINK-24495
> Project: Flink
>  Issue Type: Bug
>  Components: API / Python
>Affects Versions: 1.15.0
>Reporter: Xintong Song
>Assignee: Huang Xingbo
>Priority: Critical
>  Labels: test-stability
> Fix For: 1.15.0
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=24922&view=logs&j=821b528f-1eed-5598-a3b4-7f748b13f261&t=6bb545dd-772d-5d8c-f258-f5085fba3295&l=23587
> {code}
> Oct 10 02:30:01 py38-cython create: /__w/1/s/flink-python/.tox/py38-cython
> Oct 10 02:30:04 py38-cython installdeps: pytest, apache-beam==2.27.0, 
> cython==0.29.16, grpcio>=1.29.0,<2, grpcio-tools>=1.3.5,<=1.14.2, 
> apache-flink-libraries
> Oct 10 02:45:22 
> ==
> Oct 10 02:45:22 Process produced no output for 900 seconds.
> Oct 10 02:45:22 
> ==
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (FLINK-24763) ParquetFileSystemITCase.testLimitableBulkFormat failed on Azure

2021-11-17 Thread Yun Gao (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-24763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445010#comment-17445010
 ] 

Yun Gao commented on FLINK-24763:
-

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=26624&view=logs&j=ba53eb01-1462-56a3-8e98-0dd97fbcaab5&t=2e426bf0-b717-56bb-ab62-d63086457354&l=13842

> ParquetFileSystemITCase.testLimitableBulkFormat failed on Azure
> ---
>
> Key: FLINK-24763
> URL: https://issues.apache.org/jira/browse/FLINK-24763
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / FileSystem, Formats (JSON, Avro, Parquet, 
> ORC, SequenceFile)
>Affects Versions: 1.15.0
>Reporter: Till Rohrmann
>Assignee: Jingsong Lee
>Priority: Critical
>  Labels: pull-request-available, test-stability
> Fix For: 1.15.0
>
>
> The test {{ParquetFileSystemITCase.testLimitableBulkFormat}} fails with 
> {code}
> 2021-11-03T22:10:11.5106075Z Nov 03 22:10:11 [ERROR] 
> testLimitableBulkFormat[false]  Time elapsed: 9.177 s  <<< ERROR!
> 2021-11-03T22:10:11.5106643Z Nov 03 22:10:11 java.lang.RuntimeException: 
> Failed to fetch next result
> 2021-11-03T22:10:11.5107213Z Nov 03 22:10:11  at 
> org.apache.flink.streaming.api.operators.collect.CollectResultIterator.nextResultFromFetcher(CollectResultIterator.java:109)
> 2021-11-03T22:10:11.5111034Z Nov 03 22:10:11  at 
> org.apache.flink.streaming.api.operators.collect.CollectResultIterator.hasNext(CollectResultIterator.java:80)
> 2021-11-03T22:10:11.5112190Z Nov 03 22:10:11  at 
> org.apache.flink.table.planner.connectors.CollectDynamicSink$CloseableRowIteratorWrapper.hasNext(CollectDynamicSink.java:188)
> 2021-11-03T22:10:11.5112892Z Nov 03 22:10:11  at 
> java.util.Iterator.forEachRemaining(Iterator.java:115)
> 2021-11-03T22:10:11.5113393Z Nov 03 22:10:11  at 
> org.apache.flink.util.CollectionUtil.iteratorToList(CollectionUtil.java:109)
> 2021-11-03T22:10:11.5114157Z Nov 03 22:10:11  at 
> org.apache.flink.formats.parquet.ParquetFileSystemITCase.testLimitableBulkFormat(ParquetFileSystemITCase.java:128)
> 2021-11-03T22:10:11.5114951Z Nov 03 22:10:11  at 
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 2021-11-03T22:10:11.5115568Z Nov 03 22:10:11  at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 2021-11-03T22:10:11.5116115Z Nov 03 22:10:11  at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 2021-11-03T22:10:11.5116591Z Nov 03 22:10:11  at 
> java.lang.reflect.Method.invoke(Method.java:498)
> 2021-11-03T22:10:11.5117088Z Nov 03 22:10:11  at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> 2021-11-03T22:10:11.5117807Z Nov 03 22:10:11  at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> 2021-11-03T22:10:11.5118821Z Nov 03 22:10:11  at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> 2021-11-03T22:10:11.5119417Z Nov 03 22:10:11  at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> 2021-11-03T22:10:11.5119944Z Nov 03 22:10:11  at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> 2021-11-03T22:10:11.5120427Z Nov 03 22:10:11  at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> 2021-11-03T22:10:11.5120919Z Nov 03 22:10:11  at 
> org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
> 2021-11-03T22:10:11.5121571Z Nov 03 22:10:11  at 
> org.apache.flink.util.TestNameProvider$1.evaluate(TestNameProvider.java:45)
> 2021-11-03T22:10:11.5122526Z Nov 03 22:10:11  at 
> org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
> 2021-11-03T22:10:11.5123245Z Nov 03 22:10:11  at 
> org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> 2021-11-03T22:10:11.5123804Z Nov 03 22:10:11  at 
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> 2021-11-03T22:10:11.5124314Z Nov 03 22:10:11  at 
> org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> 2021-11-03T22:10:11.5124806Z Nov 03 22:10:11  at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> 2021-11-03T22:10:11.5125313Z Nov 03 22:10:11  at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> 2021-11-03T22:10:11.5125810Z Nov 03 22:10:11  at 
> org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> 2021-11-03T22:10:11.5126281Z Nov 03 22:10:11  at 
> org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> 2021-11-03T22:10:11.5126739Z Nov 03 22:10:11  at 
> org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> 2021-11-03T22:10:11.5127349Z Nov 0

[jira] [Commented] (FLINK-24924) TO_TIMESTAMP and TO_DATE should fail

2021-11-17 Thread Timo Walther (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445014#comment-17445014
 ] 

Timo Walther commented on FLINK-24924:
--

I agree that exceptions are not optimal for streaming pipelines. But even for 
batch jobs, this is a reoccurring problem. Take a batch job for example that 
runs every night and suddenly produces an exception due to some corrupt data in 
the current batch. It is basically the same problem.

Flink is a framework for general purpose data processing. It is not our 
responsibility to catch all potential errors that can occur with the faulty 
data of the user. This is the responsibility of the user. We offer a TRY_CAST 
for making things easier, and we can even provide a TRY_OR_NULL(any_expression) 
to make the development easier. Catching potential errors could be 
infrastructure of a hosted SQL services that ingests some helper functions 
automatically.

We should not let NULLs flow through the pipeline. This magic is highly 
confusing during development and downstream operators at various locations fail 
regularly because of a NULL that should not be present. Take this recent 
example that is strictly violating the SQL semantics and difficult to explain 
to users:

{code}
COALESCE(NULL, 0) => 0

COALESCE(CAST('aa' AS INT), 0) => NULL
{code}

I'm against such a strict mode. Because the more options we provide, the bigger 
the testing matrix. A strict-mode would mean that functions stick to the input 
and result data types that they have declared. And this should be the default 
anyway. A non-strict mode would modify all built-in function signatures.

> TO_TIMESTAMP and TO_DATE should fail
> 
>
> Key: FLINK-24924
> URL: https://issues.apache.org/jira/browse/FLINK-24924
> Project: Flink
>  Issue Type: Sub-task
>Reporter: Francesco Guardiani
>Priority: Major
>
> In a similar fashion to what described 
> https://issues.apache.org/jira/browse/FLINK-24385, TO_TIMESTAMP and TO_DATE 
> should fail instead of returning {{null}}.
> In particular for these two functions, a failure in parsing could lead to 
> very unexpected behavior, for example it could lead to records with null 
> rowtime.
> We should change these functions to fail by default when parsing generates an 
> error. We can let users handle errors by letting them use TRY_CAST for the 
> same functionality:
> {code:sql}
> -- This fails when input is invalid
> TO_TIMESTAMP(input)
> -- Behaves the same as above
> CAST(input AS TIMESTAMP)
> -- This returns null when input is invalid
> TRY_CAST(input AS TIMESTAMP)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink] Airblader commented on a change in pull request #17133: [Proof of Concept][FLINK-24138] Architectural tests

2021-11-17 Thread GitBox


Airblader commented on a change in pull request #17133:
URL: https://github.com/apache/flink/pull/17133#discussion_r751018743



##
File path: flink-architecture-tests/src/test/resources/archunit.properties
##
@@ -0,0 +1,24 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Path under which known violations will be stored for frozen rules
+freeze.store.default.path=violations
+
+# Enable this to update the violations files

Review comment:
   Based on someone's feedback I actually verified that this already 
behaves the way we want to, i.e. when run locally new violations will lead to a 
failure, but removed violations will be updated. On the CI we fail for any 
change to the violation store, even removal, since that removal needs to be 
committed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] Myasuka commented on a change in pull request #16582: [FLINK-21504][checkpoint] Introduce notification of subsumed checkpoint

2021-11-17 Thread GitBox


Myasuka commented on a change in pull request #16582:
URL: https://github.com/apache/flink/pull/16582#discussion_r751022321



##
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointSubsumeHelper.java
##
@@ -46,18 +46,24 @@
 class CheckpointSubsumeHelper {
 private static final Logger LOG = 
LoggerFactory.getLogger(CheckpointSubsumeHelper.class);
 
-public static void subsume(
+public static Optional subsume(
 Deque checkpoints, int numRetain, 
SubsumeAction subsumeAction)
 throws Exception {
 if (checkpoints.isEmpty() || checkpoints.size() <= numRetain) {
-return;
+return Optional.empty();
 }
 CompletedCheckpoint latest = checkpoints.peekLast();
+CompletedCheckpoint lastSubsumedCheckpoint = null;

Review comment:
   Thanks for the suggestion, I will refactor it in the next upadte.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17810: [BP-1.13][FLINK-24631][k8s] Use a stable subset of labels to select jobManager and taskManager pods

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17810:
URL: https://github.com/apache/flink/pull/17810#issuecomment-970348193


   
   ## CI report:
   
   * c23c23508617dd88a3b66ef383af3d53c2a83f09 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26612)
 
   * 75185c64d632a7a4ee1e5293773d238781de786e UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17685: [FLINK-24631][Kubernetes]Use minimal selector to select jobManager and taskManager pod

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17685:
URL: https://github.com/apache/flink/pull/17685#issuecomment-961148655


   
   ## CI report:
   
   * 3f7a57dd1d7274cee626d46b4e7d050300d17031 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26613)
 
   * 2471d36bd4c3a7a91c9651e32a836f3b045dbb7f Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26637)
 
   * 164b09750d797e4686133ca89af9f84895eab8a2 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17809: [BP-1.14][FLINK-24631][k8s] Use a stable subset of labels to select jobManager and taskManager pods

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17809:
URL: https://github.com/apache/flink/pull/17809#issuecomment-970332023


   
   ## CI report:
   
   * 8c2f74c0aa0f7c58c39b45e0310f976078ba2dc9 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26611)
 
   * e03bc3af99dca743c20766e18eb3ef94b18e98ce UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17810: [BP-1.13][FLINK-24631][k8s] Use a stable subset of labels to select jobManager and taskManager pods

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17810:
URL: https://github.com/apache/flink/pull/17810#issuecomment-970348193


   
   ## CI report:
   
   * c23c23508617dd88a3b66ef383af3d53c2a83f09 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26612)
 
   * 75185c64d632a7a4ee1e5293773d238781de786e Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26643)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (FLINK-24935) Python module failed to compile due to "Could not create local repository"

2021-11-17 Thread Yun Gao (Jira)
Yun Gao created FLINK-24935:
---

 Summary: Python module failed to compile due to "Could not create 
local repository"
 Key: FLINK-24935
 URL: https://issues.apache.org/jira/browse/FLINK-24935
 Project: Flink
  Issue Type: Bug
  Components: Build System / Azure Pipelines
Affects Versions: 1.12.5
Reporter: Yun Gao


{code:java}
Invoking mvn with 'mvn -Dmaven.wagon.http.pool=false --settings 
/__w/1/s/tools/ci/google-mirror-settings.xml 
-Dorg.slf4j.simpleLogger.showDateTime=true 
-Dorg.slf4j.simpleLogger.dateTimeFormat=HH:mm:ss.SSS 
-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
 --no-snapshot-updates -B -Dhadoop.version=2.8.3 -Dinclude_hadoop_aws 
-Dscala-2.11  clean deploy 
-DaltDeploymentRepository=validation_repository::default::file:/tmp/flink-validation-deployment
 -Dmaven.repo.local=/home/vsts/work/1/.m2/repository 
-Dflink.convergence.phase=install -Pcheck-convergence -Dflink.forkCount=2 
-Dflink.forkCountTestPackage=2 -Dmaven.javadoc.skip=true -U -DskipTests'
[ERROR] Could not create local repository at /home/vsts/work/1/.m2/repository 
-> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/LocalRepositoryNotAccessibleException
 {code}
[https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=26625&view=logs&j=a29bcfe1-064d-50b9-354f-07802213a3c0&t=47ff6576-c9dc-5eab-9db8-183dcca3bede]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink] Myasuka commented on a change in pull request #16582: [FLINK-21504][checkpoint] Introduce notification of subsumed checkpoint

2021-11-17 Thread GitBox


Myasuka commented on a change in pull request #16582:
URL: https://github.com/apache/flink/pull/16582#discussion_r751027356



##
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##
@@ -1405,59 +1406,80 @@ private void declineCheckpoint(
 }
 
 public void notifyCheckpointComplete(final long checkpointID) {
-final TaskInvokable invokable = this.invokable;
-
-if (executionState == ExecutionState.RUNNING) {
-checkState(invokable instanceof CheckpointableTask, "invokable is 
not checkpointable");
-try {
-((CheckpointableTask) 
invokable).notifyCheckpointCompleteAsync(checkpointID);
-} catch (RejectedExecutionException ex) {
-// This may happen if the mailbox is closed. It means that the 
task is shutting
-// down, so we just ignore it.
-LOG.debug(
-"Notify checkpoint complete {} for {} ({}) was 
rejected by the mailbox",
-checkpointID,
-taskNameWithSubtask,
-executionId);
-} catch (Throwable t) {
-if (getExecutionState() == ExecutionState.RUNNING) {
-// fail task if checkpoint confirmation failed.
-failExternally(new RuntimeException("Error while 
confirming checkpoint", t));
-}
-}
-} else {
-LOG.debug(
-"Ignoring checkpoint commit notification for non-running 
task {}.",
-taskNameWithSubtask);
-}
+notifyCheckpoint(
+checkpointID,
+CheckpointStoreUtil.INVALID_CHECKPOINT_ID,
+NotifyCheckpointOperation.COMPLETE);
 }
 
 public void notifyCheckpointAborted(
 final long checkpointID, final long latestCompletedCheckpointId) {
-final TaskInvokable invokable = this.invokable;
+notifyCheckpoint(
+checkpointID, latestCompletedCheckpointId, 
NotifyCheckpointOperation.ABORT);
+}
 
-if (executionState == ExecutionState.RUNNING) {
+public void notifyCheckpointSubsumed(long checkpointID) {
+notifyCheckpoint(
+checkpointID,
+CheckpointStoreUtil.INVALID_CHECKPOINT_ID,
+NotifyCheckpointOperation.SUBSUME);
+}
+
+private void notifyCheckpoint(
+long checkpointId,
+long latestCompletedCheckpointId,
+NotifyCheckpointOperation notifyCheckpointOperation) {
+TaskInvokable invokable = this.invokable;
+
+if (executionState == ExecutionState.RUNNING && invokable != null) {
 checkState(invokable instanceof CheckpointableTask, "invokable is 
not checkpointable");
 try {
-((CheckpointableTask) invokable)
-.notifyCheckpointAbortAsync(checkpointID, 
latestCompletedCheckpointId);
+switch (notifyCheckpointOperation) {
+case ABORT:
+((CheckpointableTask) invokable)
+.notifyCheckpointAbortAsync(
+checkpointId, 
latestCompletedCheckpointId);
+break;
+case COMPLETE:
+((CheckpointableTask) invokable)
+.notifyCheckpointCompleteAsync(checkpointId);
+break;
+case SUBSUME:
+((CheckpointableTask) invokable)
+.notifyCheckpointSubsumedAsync(checkpointId);
+}
 } catch (RejectedExecutionException ex) {
 // This may happen if the mailbox is closed. It means that the 
task is shutting
 // down, so we just ignore it.
 LOG.debug(
-"Notify checkpoint abort {} for {} ({}) was rejected 
by the mailbox",
-checkpointID,
+"Notify checkpoint {}} {} for {} ({}) was rejected by 
the mailbox.",
+notifyCheckpointOperation,
+checkpointId,
 taskNameWithSubtask,
 executionId);
 } catch (Throwable t) {
-if (getExecutionState() == ExecutionState.RUNNING) {
-// fail task if checkpoint aborted notification failed.
-failExternally(new RuntimeException("Error while aborting 
checkpoint", t));
+switch (notifyCheckpointOperation) {
+case ABORT:
+case COMPLETE:
+if (getExecutionState() == ExecutionState.RUNNING) {
+failExternally(
+new RuntimeException(
+

[GitHub] [flink] flinkbot edited a comment on pull request #17685: [FLINK-24631][Kubernetes]Use minimal selector to select jobManager and taskManager pod

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17685:
URL: https://github.com/apache/flink/pull/17685#issuecomment-961148655


   
   ## CI report:
   
   * 3f7a57dd1d7274cee626d46b4e7d050300d17031 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26613)
 
   * 2471d36bd4c3a7a91c9651e32a836f3b045dbb7f Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26637)
 
   * 164b09750d797e4686133ca89af9f84895eab8a2 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26644)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17809: [BP-1.14][FLINK-24631][k8s] Use a stable subset of labels to select jobManager and taskManager pods

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17809:
URL: https://github.com/apache/flink/pull/17809#issuecomment-970332023


   
   ## CI report:
   
   * 8c2f74c0aa0f7c58c39b45e0310f976078ba2dc9 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26611)
 
   * e03bc3af99dca743c20766e18eb3ef94b18e98ce Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26645)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-24935) Python module failed to compile due to "Could not create local repository"

2021-11-17 Thread Yun Gao (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-24935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445019#comment-17445019
 ] 

Yun Gao commented on FLINK-24935:
-

Hi [~chesnay] ~~ Might this issue also related to the disk space~?

> Python module failed to compile due to "Could not create local repository"
> --
>
> Key: FLINK-24935
> URL: https://issues.apache.org/jira/browse/FLINK-24935
> Project: Flink
>  Issue Type: Bug
>  Components: Build System / Azure Pipelines
>Affects Versions: 1.12.5
>Reporter: Yun Gao
>Priority: Major
>  Labels: test-stability
>
> {code:java}
> Invoking mvn with 'mvn -Dmaven.wagon.http.pool=false --settings 
> /__w/1/s/tools/ci/google-mirror-settings.xml 
> -Dorg.slf4j.simpleLogger.showDateTime=true 
> -Dorg.slf4j.simpleLogger.dateTimeFormat=HH:mm:ss.SSS 
> -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
>  --no-snapshot-updates -B -Dhadoop.version=2.8.3 -Dinclude_hadoop_aws 
> -Dscala-2.11  clean deploy 
> -DaltDeploymentRepository=validation_repository::default::file:/tmp/flink-validation-deployment
>  -Dmaven.repo.local=/home/vsts/work/1/.m2/repository 
> -Dflink.convergence.phase=install -Pcheck-convergence -Dflink.forkCount=2 
> -Dflink.forkCountTestPackage=2 -Dmaven.javadoc.skip=true -U -DskipTests'
> [ERROR] Could not create local repository at /home/vsts/work/1/.m2/repository 
> -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/LocalRepositoryNotAccessibleException
>  {code}
> [https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=26625&view=logs&j=a29bcfe1-064d-50b9-354f-07802213a3c0&t=47ff6576-c9dc-5eab-9db8-183dcca3bede]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (FLINK-24800) BufferTimeoutITCase.testDisablingBufferTimeout failed on Azure

2021-11-17 Thread Yun Gao (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-24800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yun Gao updated FLINK-24800:

Affects Version/s: 1.13.3

> BufferTimeoutITCase.testDisablingBufferTimeout failed on Azure
> --
>
> Key: FLINK-24800
> URL: https://issues.apache.org/jira/browse/FLINK-24800
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Network
>Affects Versions: 1.13.3, 1.15.0
>Reporter: Yun Gao
>Assignee: Anton Kalashnikov
>Priority: Blocker
>  Labels: pull-request-available, test-stability
> Fix For: 1.15.0, 1.14.1
>
>
> {code:java}
> 2021-11-05T12:18:50.5272055Z Nov 05 12:18:50 [INFO] Results:
> 2021-11-05T12:18:50.5273369Z Nov 05 12:18:50 [INFO] 
> 2021-11-05T12:18:50.5274011Z Nov 05 12:18:50 [ERROR] Failures: 
> 2021-11-05T12:18:50.5274518Z Nov 05 12:18:50 [ERROR]   
> BufferTimeoutITCase.testDisablingBufferTimeout:85 
> 2021-11-05T12:18:50.5274871Z Nov 05 12:18:50 Expected: <0>
> 2021-11-05T12:18:50.5275150Z Nov 05 12:18:50  but: was <1>
> 2021-11-05T12:18:50.5276136Z Nov 05 12:18:50 [INFO] 
> 2021-11-05T12:18:50.5276667Z Nov 05 12:18:50 [ERROR] Tests run: 1849, 
> Failures: 1, Errors: 0, Skipped: 58
> {code}
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=26018&view=logs&j=a57e0635-3fad-5b08-57c7-a4142d7d6fa9&t=2ef0effc-1da1-50e5-c2bd-aab434b1c5b7&l=10850



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (FLINK-24800) BufferTimeoutITCase.testDisablingBufferTimeout failed on Azure

2021-11-17 Thread Yun Gao (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-24800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445025#comment-17445025
 ] 

Yun Gao commented on FLINK-24800:
-

[https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=26626&view=logs&j=2c3cbe13-dee0-5837-cf47-3053da9a8a78&t=2c7d57b9-7341-5a87-c9af-2cf7cc1a37dc&l=4712]

 

Hi [~akalashnikov] , Might we pick the fix also to 1.13.x ~?

> BufferTimeoutITCase.testDisablingBufferTimeout failed on Azure
> --
>
> Key: FLINK-24800
> URL: https://issues.apache.org/jira/browse/FLINK-24800
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Network
>Affects Versions: 1.13.3, 1.15.0
>Reporter: Yun Gao
>Assignee: Anton Kalashnikov
>Priority: Blocker
>  Labels: pull-request-available, test-stability
> Fix For: 1.15.0, 1.14.1
>
>
> {code:java}
> 2021-11-05T12:18:50.5272055Z Nov 05 12:18:50 [INFO] Results:
> 2021-11-05T12:18:50.5273369Z Nov 05 12:18:50 [INFO] 
> 2021-11-05T12:18:50.5274011Z Nov 05 12:18:50 [ERROR] Failures: 
> 2021-11-05T12:18:50.5274518Z Nov 05 12:18:50 [ERROR]   
> BufferTimeoutITCase.testDisablingBufferTimeout:85 
> 2021-11-05T12:18:50.5274871Z Nov 05 12:18:50 Expected: <0>
> 2021-11-05T12:18:50.5275150Z Nov 05 12:18:50  but: was <1>
> 2021-11-05T12:18:50.5276136Z Nov 05 12:18:50 [INFO] 
> 2021-11-05T12:18:50.5276667Z Nov 05 12:18:50 [ERROR] Tests run: 1849, 
> Failures: 1, Errors: 0, Skipped: 58
> {code}
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=26018&view=logs&j=a57e0635-3fad-5b08-57c7-a4142d7d6fa9&t=2ef0effc-1da1-50e5-c2bd-aab434b1c5b7&l=10850



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink] flinkbot edited a comment on pull request #17538: [FLINK-24325][connectors/elasticsearch] Create Elasticsearch 6 Sink

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914


   
   ## CI report:
   
   * 2d2e314314c0aca9b334ff09dd744d075b47cb53 UNKNOWN
   * 4527c1d3c6f5113b4e345845a2ec08a90954c8d5 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26608)
 
   * 08960150f629869f5aa92a706e96d4a9c036e059 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17538: [FLINK-24325][connectors/elasticsearch] Create Elasticsearch 6 Sink

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914


   
   ## CI report:
   
   * 2d2e314314c0aca9b334ff09dd744d075b47cb53 UNKNOWN
   * 4527c1d3c6f5113b4e345845a2ec08a90954c8d5 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26608)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (FLINK-24936) Python test_data_stream.py hangs on azure

2021-11-17 Thread Yun Gao (Jira)
Yun Gao created FLINK-24936:
---

 Summary: Python test_data_stream.py hangs on azure
 Key: FLINK-24936
 URL: https://issues.apache.org/jira/browse/FLINK-24936
 Project: Flink
  Issue Type: Bug
  Components: API / Python
Affects Versions: 1.14.0
Reporter: Yun Gao


{code:java}
Nov 17 04:36:57 pyflink/datastream/tests/test_data_stream.py 
... [ 33%]
Nov 17 04:52:58 
==
Nov 17 04:52:58 Process produced no output for 900 seconds.
Nov 17 04:52:58 
==
Nov 17 04:52:58 
==
 {code}
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=26627&view=logs&j=821b528f-1eed-5598-a3b4-7f748b13f261&t=6bb545dd-772d-5d8c-f258-f5085fba3295



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink] Airblader commented on pull request #17133: [Proof of Concept][FLINK-24138] Architectural tests

2021-11-17 Thread GitBox


Airblader commented on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-971381711


   I've rebased the PR and addressed most of the feedback; in particular, I've 
changed it to not check API annotations on the enclosing class anymore but on 
the classes directly. This of course produces a lot of violations, as do some 
other rules; many of them are immediate fixes, and I plan on doing a bunch of 
those directly in this PR.
   
   There are also a lot of violations that need to be addressed properly. Once 
the list of violations is cut down a bit I might investigate and possibly open 
JIRA issues for them.
   
   Once the CI passes I'll also intentionally push a change to verify that 
removing or adding a violation correctly fails in the CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17133: [Proof of Concept][FLINK-24138] Architectural tests

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602


   
   ## CI report:
   
   * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN
   * baebf8dcd90968968de5d6363449fa39345b2f55 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23657)
 
   * fb6f79fcd02cc13837d20024592b8aa3b486520d UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17538: [FLINK-24325][connectors/elasticsearch] Create Elasticsearch 6 Sink

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914


   
   ## CI report:
   
   * 2d2e314314c0aca9b334ff09dd744d075b47cb53 UNKNOWN
   * 4527c1d3c6f5113b4e345845a2ec08a90954c8d5 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26608)
 
   * 08960150f629869f5aa92a706e96d4a9c036e059 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-24936) Python test_data_stream.py hangs on azure

2021-11-17 Thread Yun Gao (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-24936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445029#comment-17445029
 ] 

Yun Gao commented on FLINK-24936:
-

Hi [~hxbks2ks] , could you also have a look at this issue when convenient~?

> Python test_data_stream.py hangs on azure
> -
>
> Key: FLINK-24936
> URL: https://issues.apache.org/jira/browse/FLINK-24936
> Project: Flink
>  Issue Type: Bug
>  Components: API / Python
>Affects Versions: 1.14.0
>Reporter: Yun Gao
>Priority: Major
>  Labels: test-stability
>
> {code:java}
> Nov 17 04:36:57 pyflink/datastream/tests/test_data_stream.py 
> ... [ 33%]
> Nov 17 04:52:58 
> ==
> Nov 17 04:52:58 Process produced no output for 900 seconds.
> Nov 17 04:52:58 
> ==
> Nov 17 04:52:58 
> ==
>  {code}
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=26627&view=logs&j=821b528f-1eed-5598-a3b4-7f748b13f261&t=6bb545dd-772d-5d8c-f258-f5085fba3295



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Assigned] (FLINK-15816) Limit the maximum length of the value of kubernetes.cluster-id configuration option

2021-11-17 Thread Alexander Preuss (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Preuss reassigned FLINK-15816:


Assignee: Alexander Preuss

> Limit the maximum length of the value of kubernetes.cluster-id configuration 
> option
> ---
>
> Key: FLINK-15816
> URL: https://issues.apache.org/jira/browse/FLINK-15816
> Project: Flink
>  Issue Type: Sub-task
>  Components: Deployment / Kubernetes
>Affects Versions: 1.10.0, 1.14.1
>Reporter: Canbin Zheng
>Assignee: Alexander Preuss
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.0
>
> Attachments: image-2020-01-31-20-54-33-340.png
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Two Kubernetes Service will be created when a session cluster is deployed, 
> one is the internal Service and the other is the rest Service, we set the 
> internal Service name to the value of the _kubernetes.cluster-id_ 
> configuration option and then set the rest Service name to  
> _${kubernetes.cluster-id}_ with a suffix *-rest* appended, said if we set the 
> _kubernetes.cluster-id_ to *session-test*, then the internal Service name 
> will be *session-test* and the rest Service name be *session-test-rest;* 
> there is a constraint in Kubernetes that the Service name must be no more 
> than 63 characters, for the current naming convention it leads to that the 
> value of _kubernetes.cluster-id_ should not be more than 58 characters, 
> otherwise there are scenarios that the internal Service is created 
> successfully then comes up with a ClusterDeploymentException when trying to 
> create the rest Service.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink] flinkbot edited a comment on pull request #17538: [FLINK-24325][connectors/elasticsearch] Create Elasticsearch 6 Sink

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914


   
   ## CI report:
   
   * 2d2e314314c0aca9b334ff09dd744d075b47cb53 UNKNOWN
   * 4527c1d3c6f5113b4e345845a2ec08a90954c8d5 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26608)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17133: [Proof of Concept][FLINK-24138] Architectural tests

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602


   
   ## CI report:
   
   * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN
   * baebf8dcd90968968de5d6363449fa39345b2f55 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23657)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602


   
   ## CI report:
   
   * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN
   * baebf8dcd90968968de5d6363449fa39345b2f55 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23657)
 
   * 89b1db5b650484d255a469e62e480f0f9df496a4 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17538: [FLINK-24325][connectors/elasticsearch] Create Elasticsearch 6 Sink

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914


   
   ## CI report:
   
   * 2d2e314314c0aca9b334ff09dd744d075b47cb53 UNKNOWN
   * 4527c1d3c6f5113b4e345845a2ec08a90954c8d5 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26608)
 
   * 08960150f629869f5aa92a706e96d4a9c036e059 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (FLINK-24138) Automated architectural tests

2021-11-17 Thread Jira


 [ 
https://issues.apache.org/jira/browse/FLINK-24138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ingo Bürk updated FLINK-24138:
--
Labels: pull-request-available  (was: pull-request-available stale-assigned)

> Automated architectural tests
> -
>
> Key: FLINK-24138
> URL: https://issues.apache.org/jira/browse/FLINK-24138
> Project: Flink
>  Issue Type: Improvement
>  Components: Build System, Tests
>Reporter: Ingo Bürk
>Assignee: Ingo Bürk
>Priority: Major
>  Labels: pull-request-available
>
> See ML thread: 
> https://lists.apache.org/thread.html/r35b679f0b0d83be8a4912dcd2155e28b316f476547ae5dab601bda65%40%3Cdev.flink.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink] flinkbot edited a comment on pull request #17814: [FLINK-24899][runtime] Enable data compression for blocking shuffle by default

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17814:
URL: https://github.com/apache/flink/pull/17814#issuecomment-971129699


   
   ## CI report:
   
   * 24f77cae435bd8dfed5832b25b0d0bfb1791afb9 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26636)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (FLINK-24937) "kubernetes application HA test" hangs on azure

2021-11-17 Thread Yun Gao (Jira)
Yun Gao created FLINK-24937:
---

 Summary: "kubernetes application HA test" hangs on azure
 Key: FLINK-24937
 URL: https://issues.apache.org/jira/browse/FLINK-24937
 Project: Flink
  Issue Type: Bug
  Components: Runtime / Coordination
Affects Versions: 1.14.1
Reporter: Yun Gao


{code:java}
2021-11-17T02:15:23.4319085Z Nov 17 02:15:23 ##[endgroup]
2021-11-17T02:15:23.4319779Z Nov 17 02:15:23 Searching for .dump, .dumpstream 
and related files in '/home/vsts/work/1/s'
2021-11-17T02:15:24.7906640Z dmesg: read kernel buffer failed: Operation not 
permitted
2021-11-17T02:15:25.1156830Z Nov 17 02:15:25 No taskexecutor daemon to stop on 
host fv-az123-364.
2021-11-17T02:15:25.3229454Z Nov 17 02:15:25 No standalonesession daemon to 
stop on host fv-az123-364.
2021-11-17T06:09:57.2488148Z 
==
2021-11-17T06:09:57.2489380Z === WARNING: This task took already 95% of the 
available time budget of 281 minutes ===
2021-11-17T06:09:57.2490646Z 
==
 {code}
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=26628&view=logs&j=c88eea3b-64a0-564d-0031-9fdcd7b8abee&t=070ff179-953e-5bda-71fa-d6599415701c&l=2562



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602


   
   ## CI report:
   
   * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN
   * baebf8dcd90968968de5d6363449fa39345b2f55 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23657)
 
   * 89b1db5b650484d255a469e62e480f0f9df496a4 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26646)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17538: [FLINK-24325][connectors/elasticsearch] Create Elasticsearch 6 Sink

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914


   
   ## CI report:
   
   * 2d2e314314c0aca9b334ff09dd744d075b47cb53 UNKNOWN
   * 4527c1d3c6f5113b4e345845a2ec08a90954c8d5 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26608)
 
   * 08960150f629869f5aa92a706e96d4a9c036e059 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26647)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-24937) "kubernetes application HA test" hangs on azure

2021-11-17 Thread Yun Gao (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-24937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445034#comment-17445034
 ] 

Yun Gao commented on FLINK-24937:
-

Hi [~wangyang0918] ~ Are you convenient to have a look at this issue~?

> "kubernetes application HA test" hangs on azure
> ---
>
> Key: FLINK-24937
> URL: https://issues.apache.org/jira/browse/FLINK-24937
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Coordination
>Affects Versions: 1.14.1
>Reporter: Yun Gao
>Priority: Major
>  Labels: test-stability
>
> {code:java}
> 2021-11-17T02:15:23.4319085Z Nov 17 02:15:23 ##[endgroup]
> 2021-11-17T02:15:23.4319779Z Nov 17 02:15:23 Searching for .dump, .dumpstream 
> and related files in '/home/vsts/work/1/s'
> 2021-11-17T02:15:24.7906640Z dmesg: read kernel buffer failed: Operation not 
> permitted
> 2021-11-17T02:15:25.1156830Z Nov 17 02:15:25 No taskexecutor daemon to stop 
> on host fv-az123-364.
> 2021-11-17T02:15:25.3229454Z Nov 17 02:15:25 No standalonesession daemon to 
> stop on host fv-az123-364.
> 2021-11-17T06:09:57.2488148Z 
> ==
> 2021-11-17T06:09:57.2489380Z === WARNING: This task took already 95% of the 
> available time budget of 281 minutes ===
> 2021-11-17T06:09:57.2490646Z 
> ==
>  {code}
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=26628&view=logs&j=c88eea3b-64a0-564d-0031-9fdcd7b8abee&t=070ff179-953e-5bda-71fa-d6599415701c&l=2562



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink] flinkbot edited a comment on pull request #17815: [FLINK-22702][tests] Add test data supplier which provide null timestamp field to kafka connector tests

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17815:
URL: https://github.com/apache/flink/pull/17815#issuecomment-971312244


   
   ## CI report:
   
   * c654feccc34582ec2f2c6c22513c7a67bcd3de65 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26639)
 
   * 167488b16e036f8e3db30e4758d5ba14e2fea337 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] akalash opened a new pull request #17818: [FLINK-24800][runtime] Changed the assert condition for checking buff…

2021-11-17 Thread GitBox


akalash opened a new pull request #17818:
URL: https://github.com/apache/flink/pull/17818


   …er timeout disabling test
   
   
   
   ## What is the purpose of the change
   
   Backport of https://github.com/apache/flink/pull/17758
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): (yes / **no**)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
 - The serializers: (yes / **no** / don't know)
 - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't 
know)
 - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (yes / **no**)
 - If yes, how is the feature documented? (not applicable / docs / JavaDocs 
/ not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17637: [FLINK-24708][planner] Fix wrong results of the IN operator

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17637:
URL: https://github.com/apache/flink/pull/17637#issuecomment-957122792


   
   ## CI report:
   
   * 8f68a316bd96c317619d264fe8818f558253b97b Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26509)
 
   * 8e136dd10f4da8c8eba2c4d53424cdcae79e1eb6 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17815: [FLINK-22702][tests] Add test data supplier which provide null timestamp field to kafka connector tests

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17815:
URL: https://github.com/apache/flink/pull/17815#issuecomment-971312244


   
   ## CI report:
   
   * c654feccc34582ec2f2c6c22513c7a67bcd3de65 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26639)
 
   * 167488b16e036f8e3db30e4758d5ba14e2fea337 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26648)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-24800) BufferTimeoutITCase.testDisablingBufferTimeout failed on Azure

2021-11-17 Thread Anton Kalashnikov (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-24800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445039#comment-17445039
 ] 

Anton Kalashnikov commented on FLINK-24800:
---

[~gaoyunhaii] , yes, sure, I have prepared the PR - 
https://github.com/apache/flink/pull/17818.

> BufferTimeoutITCase.testDisablingBufferTimeout failed on Azure
> --
>
> Key: FLINK-24800
> URL: https://issues.apache.org/jira/browse/FLINK-24800
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Network
>Affects Versions: 1.13.3, 1.15.0
>Reporter: Yun Gao
>Assignee: Anton Kalashnikov
>Priority: Blocker
>  Labels: pull-request-available, test-stability
> Fix For: 1.15.0, 1.14.1
>
>
> {code:java}
> 2021-11-05T12:18:50.5272055Z Nov 05 12:18:50 [INFO] Results:
> 2021-11-05T12:18:50.5273369Z Nov 05 12:18:50 [INFO] 
> 2021-11-05T12:18:50.5274011Z Nov 05 12:18:50 [ERROR] Failures: 
> 2021-11-05T12:18:50.5274518Z Nov 05 12:18:50 [ERROR]   
> BufferTimeoutITCase.testDisablingBufferTimeout:85 
> 2021-11-05T12:18:50.5274871Z Nov 05 12:18:50 Expected: <0>
> 2021-11-05T12:18:50.5275150Z Nov 05 12:18:50  but: was <1>
> 2021-11-05T12:18:50.5276136Z Nov 05 12:18:50 [INFO] 
> 2021-11-05T12:18:50.5276667Z Nov 05 12:18:50 [ERROR] Tests run: 1849, 
> Failures: 1, Errors: 0, Skipped: 58
> {code}
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=26018&view=logs&j=a57e0635-3fad-5b08-57c7-a4142d7d6fa9&t=2ef0effc-1da1-50e5-c2bd-aab434b1c5b7&l=10850



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602


   
   ## CI report:
   
   * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN
   * baebf8dcd90968968de5d6363449fa39345b2f55 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23657)
 
   * 89b1db5b650484d255a469e62e480f0f9df496a4 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26646)
 
   * 971b874f8e0fd6483924dac21fbade6d31558f0d UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17637: [FLINK-24708][planner] Fix wrong results of the IN operator

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17637:
URL: https://github.com/apache/flink/pull/17637#issuecomment-957122792


   
   ## CI report:
   
   * 8f68a316bd96c317619d264fe8818f558253b97b Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26509)
 
   * 8e136dd10f4da8c8eba2c4d53424cdcae79e1eb6 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26649)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #17818: [FLINK-24800][runtime] Changed the assert condition for checking buff…

2021-11-17 Thread GitBox


flinkbot commented on pull request #17818:
URL: https://github.com/apache/flink/pull/17818#issuecomment-971400530


   
   ## CI report:
   
   * d4a68e7a626463d81df6315e622551106588cf8e UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #17818: [FLINK-24800][runtime] Changed the assert condition for checking buff…

2021-11-17 Thread GitBox


flinkbot commented on pull request #17818:
URL: https://github.com/apache/flink/pull/17818#issuecomment-971400920


   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit d4a68e7a626463d81df6315e622551106588cf8e (Wed Nov 17 
09:36:04 UTC 2021)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602


   
   ## CI report:
   
   * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN
   * baebf8dcd90968968de5d6363449fa39345b2f55 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23657)
 
   * 89b1db5b650484d255a469e62e480f0f9df496a4 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26646)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17818: [FLINK-24800][runtime] Changed the assert condition for checking buff…

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17818:
URL: https://github.com/apache/flink/pull/17818#issuecomment-971400530


   
   ## CI report:
   
   * d4a68e7a626463d81df6315e622551106588cf8e Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26650)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602


   
   ## CI report:
   
   * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN
   * baebf8dcd90968968de5d6363449fa39345b2f55 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23657)
 
   * 89b1db5b650484d255a469e62e480f0f9df496a4 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26646)
 
   * 971b874f8e0fd6483924dac21fbade6d31558f0d UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602


   
   ## CI report:
   
   * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN
   * baebf8dcd90968968de5d6363449fa39345b2f55 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23657)
 
   * 89b1db5b650484d255a469e62e480f0f9df496a4 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26646)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (FLINK-24938) Checkpoint cleaner is closed before checkpoints are discarded

2021-11-17 Thread Roman Khachatryan (Jira)
Roman Khachatryan created FLINK-24938:
-

 Summary: Checkpoint cleaner is closed before checkpoints are 
discarded
 Key: FLINK-24938
 URL: https://issues.apache.org/jira/browse/FLINK-24938
 Project: Flink
  Issue Type: Bug
  Components: Runtime / Checkpointing
Affects Versions: 1.14.0, 1.15.0
Reporter: Roman Khachatryan
 Fix For: 1.15.0, 1.14.1


When CompletedCheckpointStore shuts down it tries to discard some checkpoints 
using CheckpointCleaner. The latter is closed asynchronously since FLINK-23647 
and before the Store.

Visible as warning when running 
ResumeCheckpointManuallyITCase.testExternalizedIncrementalRocksDBCheckpointsZookeeper:

{code}
2021-11-17 10:47:10,599 Fail to remove checkpoint during shutdown. 
[DefaultCompletedCheckpointStore flink-akka.actor.default-dispatcher-5]
 java.lang.IllegalStateException: CheckpointsCleaner has already been closed
 at 
org.apache.flink.util.Preconditions.checkState(Preconditions.java:193) 
~[classes/:?]
 at 
org.apache.flink.runtime.checkpoint.CheckpointsCleaner.incrementNumberOfCheckpointsToClean(CheckpointsCleaner.java:105)
 ~[classes/:?]
 at 
org.apache.flink.runtime.checkpoint.CheckpointsCleaner.cleanup(CheckpointsCleaner.java:87)
 ~[classes/:?]
 at 
org.apache.flink.runtime.checkpoint.CheckpointsCleaner.cleanCheckpoint(CheckpointsCleaner.java:62)
 ~[classes/:?]
 at 
org.apache.flink.runtime.checkpoint.DefaultCompletedCheckpointStore.tryRemoveCompletedCheckpoint(DefaultCompletedCheckpointStore.java:2
 at 
org.apache.flink.runtime.checkpoint.DefaultCompletedCheckpointStore.shutdown(DefaultCompletedCheckpointStore.java:172)
 ~[classes/:?]
 at 
org.apache.flink.runtime.scheduler.SchedulerBase.shutDownCheckpointServices(SchedulerBase.java:222)
 ~[classes/:?]

{code}

But the test still passes.


cc: [~pnowojski]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink] maver1ck commented on pull request #17795: [FLINK-23230] Upgrade frontend-maven-plugin

2021-11-17 Thread GitBox


maver1ck commented on pull request #17795:
URL: https://github.com/apache/flink/pull/17795#issuecomment-971410229


   @rmetzger 
   I think the best solution for protoc will be adding this file to maven 
central. Do we have any friends in protobuf project ?
   https://developers.google.com/protocol-buffers/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602


   
   ## CI report:
   
   * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN
   * baebf8dcd90968968de5d6363449fa39345b2f55 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23657)
 
   * 89b1db5b650484d255a469e62e480f0f9df496a4 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26646)
 
   * 971b874f8e0fd6483924dac21fbade6d31558f0d UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-24938) Checkpoint cleaner is closed before checkpoints are discarded

2021-11-17 Thread Roman Khachatryan (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-24938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445046#comment-17445046
 ] 

Roman Khachatryan commented on FLINK-24938:
---

Doesn't happen without FLINK-23647.

> Checkpoint cleaner is closed before checkpoints are discarded
> -
>
> Key: FLINK-24938
> URL: https://issues.apache.org/jira/browse/FLINK-24938
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Checkpointing
>Affects Versions: 1.14.0, 1.15.0
>Reporter: Roman Khachatryan
>Priority: Major
> Fix For: 1.15.0, 1.14.1
>
>
> When CompletedCheckpointStore shuts down it tries to discard some checkpoints 
> using CheckpointCleaner. The latter is closed asynchronously since 
> FLINK-23647 and before the Store.
> Visible as warning when running 
> ResumeCheckpointManuallyITCase.testExternalizedIncrementalRocksDBCheckpointsZookeeper:
> {code}
> 2021-11-17 10:47:10,599 Fail to remove checkpoint during shutdown. 
> [DefaultCompletedCheckpointStore flink-akka.actor.default-dispatcher-5]
>  java.lang.IllegalStateException: CheckpointsCleaner has already been closed
>  at 
> org.apache.flink.util.Preconditions.checkState(Preconditions.java:193) 
> ~[classes/:?]
>  at 
> org.apache.flink.runtime.checkpoint.CheckpointsCleaner.incrementNumberOfCheckpointsToClean(CheckpointsCleaner.java:105)
>  ~[classes/:?]
>  at 
> org.apache.flink.runtime.checkpoint.CheckpointsCleaner.cleanup(CheckpointsCleaner.java:87)
>  ~[classes/:?]
>  at 
> org.apache.flink.runtime.checkpoint.CheckpointsCleaner.cleanCheckpoint(CheckpointsCleaner.java:62)
>  ~[classes/:?]
>  at 
> org.apache.flink.runtime.checkpoint.DefaultCompletedCheckpointStore.tryRemoveCompletedCheckpoint(DefaultCompletedCheckpointStore.java:2
>  at 
> org.apache.flink.runtime.checkpoint.DefaultCompletedCheckpointStore.shutdown(DefaultCompletedCheckpointStore.java:172)
>  ~[classes/:?]
>  at 
> org.apache.flink.runtime.scheduler.SchedulerBase.shutDownCheckpointServices(SchedulerBase.java:222)
>  ~[classes/:?]
> {code}
> But the test still passes.
> cc: [~pnowojski]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (FLINK-24938) Checkpoint cleaner is closed before checkpoints are discarded

2021-11-17 Thread Roman Khachatryan (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-24938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Roman Khachatryan updated FLINK-24938:
--
Priority: Critical  (was: Major)

> Checkpoint cleaner is closed before checkpoints are discarded
> -
>
> Key: FLINK-24938
> URL: https://issues.apache.org/jira/browse/FLINK-24938
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Checkpointing
>Affects Versions: 1.14.0, 1.15.0
>Reporter: Roman Khachatryan
>Priority: Critical
> Fix For: 1.15.0, 1.14.1
>
>
> When CompletedCheckpointStore shuts down it tries to discard some checkpoints 
> using CheckpointCleaner. The latter is closed asynchronously since 
> FLINK-23647 and before the Store.
> Visible as warning when running 
> ResumeCheckpointManuallyITCase.testExternalizedIncrementalRocksDBCheckpointsZookeeper:
> {code}
> 2021-11-17 10:47:10,599 Fail to remove checkpoint during shutdown. 
> [DefaultCompletedCheckpointStore flink-akka.actor.default-dispatcher-5]
>  java.lang.IllegalStateException: CheckpointsCleaner has already been closed
>  at 
> org.apache.flink.util.Preconditions.checkState(Preconditions.java:193) 
> ~[classes/:?]
>  at 
> org.apache.flink.runtime.checkpoint.CheckpointsCleaner.incrementNumberOfCheckpointsToClean(CheckpointsCleaner.java:105)
>  ~[classes/:?]
>  at 
> org.apache.flink.runtime.checkpoint.CheckpointsCleaner.cleanup(CheckpointsCleaner.java:87)
>  ~[classes/:?]
>  at 
> org.apache.flink.runtime.checkpoint.CheckpointsCleaner.cleanCheckpoint(CheckpointsCleaner.java:62)
>  ~[classes/:?]
>  at 
> org.apache.flink.runtime.checkpoint.DefaultCompletedCheckpointStore.tryRemoveCompletedCheckpoint(DefaultCompletedCheckpointStore.java:2
>  at 
> org.apache.flink.runtime.checkpoint.DefaultCompletedCheckpointStore.shutdown(DefaultCompletedCheckpointStore.java:172)
>  ~[classes/:?]
>  at 
> org.apache.flink.runtime.scheduler.SchedulerBase.shutDownCheckpointServices(SchedulerBase.java:222)
>  ~[classes/:?]
> {code}
> But the test still passes.
> cc: [~pnowojski]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602


   
   ## CI report:
   
   * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN
   * baebf8dcd90968968de5d6363449fa39345b2f55 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23657)
 
   * 89b1db5b650484d255a469e62e480f0f9df496a4 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26646)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-24433) "No space left on device" in Azure e2e tests

2021-11-17 Thread Roman Khachatryan (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-24433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445048#comment-17445048
 ] 

Roman Khachatryan commented on FLINK-24433:
---

Probably caused by FLINK-24938.

> "No space left on device" in Azure e2e tests
> 
>
> Key: FLINK-24433
> URL: https://issues.apache.org/jira/browse/FLINK-24433
> Project: Flink
>  Issue Type: Bug
>  Components: Build System / Azure Pipelines
>Affects Versions: 1.15.0
>Reporter: Dawid Wysakowicz
>Priority: Major
>  Labels: test-stability
> Fix For: 1.15.0
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=24668&view=logs&j=c88eea3b-64a0-564d-0031-9fdcd7b8abee&t=070ff179-953e-5bda-71fa-d6599415701c&l=19772
> {code}
> Sep 30 17:08:42 Job has been submitted with JobID 
> 5594c18e128a328ede39cfa59cb3cb07
> Sep 30 17:08:56 2021-09-30 17:08:56,809 main ERROR Recovering from 
> StringBuilderEncoder.encode('2021-09-30 17:08:56,807 WARN  
> org.apache.flink.streaming.api.operators.collect.CollectResultFetcher [] - An 
> exception occurred when fetching query results
> Sep 30 17:08:56 java.util.concurrent.ExecutionException: 
> org.apache.flink.runtime.rest.util.RestClientException: [Internal server 
> error.,  Sep 30 17:08:56 org.apache.flink.runtime.messages.FlinkJobNotFoundException: 
> Could not find Flink job (5594c18e128a328ede39cfa59cb3cb07)
> Sep 30 17:08:56   at 
> org.apache.flink.runtime.dispatcher.Dispatcher.getJobMasterGateway(Dispatcher.java:923)
> Sep 30 17:08:56   at 
> org.apache.flink.runtime.dispatcher.Dispatcher.performOperationOnJobMasterGateway(Dispatcher.java:937)
> Sep 30 17:08:56   at 
> org.apache.flink.runtime.dispatcher.Dispatcher.deliverCoordinationRequestToCoordina2021-09-30T17:08:57.1584224Z
>  ##[error]No space left on device
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602


   
   ## CI report:
   
   * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN
   * baebf8dcd90968968de5d6363449fa39345b2f55 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23657)
 
   * 89b1db5b650484d255a469e62e480f0f9df496a4 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26646)
 
   * 971b874f8e0fd6483924dac21fbade6d31558f0d UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17817: [FLINK-24922][docs] Backport fix spelling errors in the word "parallism"

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17817:
URL: https://github.com/apache/flink/pull/17817#issuecomment-971344993


   
   ## CI report:
   
   * 999fa42b698ec2d652d9e9b7c7db32b946231797 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26642)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602


   
   ## CI report:
   
   * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN
   * baebf8dcd90968968de5d6363449fa39345b2f55 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23657)
 
   * 89b1db5b650484d255a469e62e480f0f9df496a4 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26646)
 
   * c0f52636331adf1db6268b504e674f1f41e3f07d UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17773: [FLINK-24409][kafka] Fix collection of KafkaSourceReaderMetrics for t…

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17773:
URL: https://github.com/apache/flink/pull/17773#issuecomment-966918976


   
   ## CI report:
   
   * d2e43591620e4cbef556a60ef82694351381099f Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26523)
 
   * f6c57afdafb62ad077745dea97effbcc942a689a UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602


   
   ## CI report:
   
   * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN
   * baebf8dcd90968968de5d6363449fa39345b2f55 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23657)
 
   * 89b1db5b650484d255a469e62e480f0f9df496a4 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26646)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17773: [FLINK-24409][kafka] Fix collection of KafkaSourceReaderMetrics for t…

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17773:
URL: https://github.com/apache/flink/pull/17773#issuecomment-966918976


   
   ## CI report:
   
   * d2e43591620e4cbef556a60ef82694351381099f Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26523)
 
   * f6c57afdafb62ad077745dea97effbcc942a689a Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26651)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17816: [FLINK-24922][docs] Backport fix spelling errors in the word "parallism"

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17816:
URL: https://github.com/apache/flink/pull/17816#issuecomment-971338462


   
   ## CI report:
   
   * 251f55c950101b10454bfb031469e8cd643ea512 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26641)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602


   
   ## CI report:
   
   * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN
   * baebf8dcd90968968de5d6363449fa39345b2f55 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23657)
 
   * 89b1db5b650484d255a469e62e480f0f9df496a4 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26646)
 
   * c0f52636331adf1db6268b504e674f1f41e3f07d UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17685: [FLINK-24631][Kubernetes]Use minimal selector to select jobManager and taskManager pod

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17685:
URL: https://github.com/apache/flink/pull/17685#issuecomment-961148655


   
   ## CI report:
   
   * 2471d36bd4c3a7a91c9651e32a836f3b045dbb7f Azure: 
[CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26637)
 
   * 164b09750d797e4686133ca89af9f84895eab8a2 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26644)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602


   
   ## CI report:
   
   * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN
   * baebf8dcd90968968de5d6363449fa39345b2f55 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23657)
 
   * 89b1db5b650484d255a469e62e480f0f9df496a4 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26646)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602


   
   ## CI report:
   
   * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN
   * baebf8dcd90968968de5d6363449fa39345b2f55 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23657)
 
   * 89b1db5b650484d255a469e62e480f0f9df496a4 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26646)
 
   * c0f52636331adf1db6268b504e674f1f41e3f07d UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17799: [FLINK-24409][kafka] Fix collection of KafkaSourceReaderMetrics for topics containing periods

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17799:
URL: https://github.com/apache/flink/pull/17799#issuecomment-969089865


   
   ## CI report:
   
   * 075ae2263d7cc68a9bcd4d6e336494c104d670a9 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26556)
 
   * 8e7cbb60cd774d89cfde15ac5062b9ebb44d2c3a UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602


   
   ## CI report:
   
   * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN
   * baebf8dcd90968968de5d6363449fa39345b2f55 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23657)
 
   * 89b1db5b650484d255a469e62e480f0f9df496a4 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26646)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17799: [FLINK-24409][kafka] Fix collection of KafkaSourceReaderMetrics for topics containing periods

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17799:
URL: https://github.com/apache/flink/pull/17799#issuecomment-969089865


   
   ## CI report:
   
   * 075ae2263d7cc68a9bcd4d6e336494c104d670a9 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26556)
 
   * 8e7cbb60cd774d89cfde15ac5062b9ebb44d2c3a Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26652)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602


   
   ## CI report:
   
   * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN
   * baebf8dcd90968968de5d6363449fa39345b2f55 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23657)
 
   * 89b1db5b650484d255a469e62e480f0f9df496a4 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26646)
 
   * c0f52636331adf1db6268b504e674f1f41e3f07d UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-24936) Python test_data_stream.py hangs on azure

2021-11-17 Thread Huang Xingbo (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-24936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445063#comment-17445063
 ] 

Huang Xingbo commented on FLINK-24936:
--

[~gaoyunhaii] Thanks for the reporting this issue. The error reasons for the  
these hanging tests are the same. When the Azure machine creates multiple 
python processes, some of them cannot be started. The concurrency of udf tests 
adjusted to 1 can solve this problem. I'm still thinking about whether there is 
a better solution.

> Python test_data_stream.py hangs on azure
> -
>
> Key: FLINK-24936
> URL: https://issues.apache.org/jira/browse/FLINK-24936
> Project: Flink
>  Issue Type: Bug
>  Components: API / Python
>Affects Versions: 1.14.0
>Reporter: Yun Gao
>Priority: Major
>  Labels: test-stability
>
> {code:java}
> Nov 17 04:36:57 pyflink/datastream/tests/test_data_stream.py 
> ... [ 33%]
> Nov 17 04:52:58 
> ==
> Nov 17 04:52:58 Process produced no output for 900 seconds.
> Nov 17 04:52:58 
> ==
> Nov 17 04:52:58 
> ==
>  {code}
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=26627&view=logs&j=821b528f-1eed-5598-a3b4-7f748b13f261&t=6bb545dd-772d-5d8c-f258-f5085fba3295



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Assigned] (FLINK-24936) Python test_data_stream.py hangs on azure

2021-11-17 Thread Huang Xingbo (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-24936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Huang Xingbo reassigned FLINK-24936:


Assignee: Huang Xingbo

> Python test_data_stream.py hangs on azure
> -
>
> Key: FLINK-24936
> URL: https://issues.apache.org/jira/browse/FLINK-24936
> Project: Flink
>  Issue Type: Bug
>  Components: API / Python
>Affects Versions: 1.14.0
>Reporter: Yun Gao
>Assignee: Huang Xingbo
>Priority: Major
>  Labels: test-stability
>
> {code:java}
> Nov 17 04:36:57 pyflink/datastream/tests/test_data_stream.py 
> ... [ 33%]
> Nov 17 04:52:58 
> ==
> Nov 17 04:52:58 Process produced no output for 900 seconds.
> Nov 17 04:52:58 
> ==
> Nov 17 04:52:58 
> ==
>  {code}
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=26627&view=logs&j=821b528f-1eed-5598-a3b4-7f748b13f261&t=6bb545dd-772d-5d8c-f258-f5085fba3295



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602


   
   ## CI report:
   
   * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN
   * baebf8dcd90968968de5d6363449fa39345b2f55 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23657)
 
   * 89b1db5b650484d255a469e62e480f0f9df496a4 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26646)
 
   * c0f52636331adf1db6268b504e674f1f41e3f07d Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26653)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] alpreu opened a new pull request #17819: [FLINK-15816][k8s] Limit kubernetes.cluster-id to a maximum of 40 characters

2021-11-17 Thread GitBox


alpreu opened a new pull request #17819:
URL: https://github.com/apache/flink/pull/17819


   ## What is the purpose of the change
   
   Kubernetes labels have a maximum length of 63 characters. The longest 
created label is {cluster-id}-resourcemanager-leader, therefore the cluster-id 
has to be limited to 40 characters to not create failures on deployment.
   
   
   ## Brief change log
   
 - Updated MAXIMUM_CHARACTERS_OF_CLUSTER_ID to 40
 - Updated docs
   
   ## Verifying this change
   
   
   This change is already covered by existing tests, such as *(please describe 
tests)*.
   
- AbstractKubernetesParametersTest#testClusterIdLengthLimitation
   
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): (no)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
 - The serializers: (no)
 - The runtime per-record code paths (performance sensitive): (no)
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes - kubernetes)
 - The S3 file system connector: (no)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (no)
 - If yes, how is the feature documented? (docs + JavaDocs)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Comment Edited] (FLINK-24921) FileSourceSplit should not be visible in the user API in ParquetColumnarRowInputFormat

2021-11-17 Thread Etienne Chauchot (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-24921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444592#comment-17444592
 ] 

Etienne Chauchot edited comment on FLINK-24921 at 11/17/21, 10:31 AM:
--

I took a deeper look at the code, [~arvid] you're right (thanks) Parquet Format 
is used to support hive format hence the parametrized type. And indeed, it can 
difficultly be removed. But the factory I see in the parquet format package 
(ParquetFileFormatFactory) is for the table API. So _FileSourceSplit_ will 
surface in the parquet API when using DataStream API unless I'm missing 
something.

While documenting the DataStream connectors from the user point of view, I 
searched how to use _ParquetColumnarRowInputFormat_ by taking a look at the 
tests and they refer either explicitly _FileSourceSplit_ or do a raw use of the 
parametrized _ParquetColumnarRowInputFormat_ class so I though we could improve 
the API.

For now, I'll document as is.


was (Author: echauchot):
I took a deeper look at the code, [~arvid] you're right (thanks) Parquet Format 
is used to support hive format hence the parametrized type. And indeed, it can 
difficultly be removed. But the factory I see in the parquet format package 
(ParquetFileFormatFactory) is for the table API.

While documenting the DataStream connectors from the user point of view, I 
searched how to use _ParquetColumnarRowInputFormat_ by taking a look at the 
tests and they refer either explicitly _FileSourceSplit_ or do a raw use of the 
parametrized _ParquetColumnarRowInputFormat_ class so I though we could improve 
the API.

For now, I'll document as is.

> FileSourceSplit should not be visible in the user API in 
> ParquetColumnarRowInputFormat
> --
>
> Key: FLINK-24921
> URL: https://issues.apache.org/jira/browse/FLINK-24921
> Project: Flink
>  Issue Type: Improvement
>  Components: Connectors / FileSystem
>Reporter: Etienne Chauchot
>Assignee: Etienne Chauchot
>Priority: Major
>
> _FileSourceSplit_ is an internal class that should not be visible in the user 
> API like 
> [here|https://github.com/apache/flink/blob/6f2d8fe3007464343c5312e27612be448b415148/flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetColumnarRowInputFormatTest.java#L235].
>  The fact that _FileSourceSplit_ surfaces in the API also influences the user 
> to do a raw use of the parametrized class like 
> [here|https://github.com/apache/flink/blob/6f2d8fe3007464343c5312e27612be448b415148/flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetColumnarRowInputFormatTest.java#L407]
> It could be better to make parquet format a not parametrized class as it is 
> done for hive connector
> _class_  HiveBulkFormatAdapter
> _implements BulkFormat_
> rather than
> _class ParquetColumnarRowInputFormat_
> _extends ParquetVectorizedInputFormat_
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink-ml] zhipeng93 commented on pull request #34: [hotfix] fix nullpointer exception when broadcast variables are cleaned

2021-11-17 Thread GitBox


zhipeng93 commented on pull request #34:
URL: https://github.com/apache/flink-ml/pull/34#issuecomment-971445800


   Hi @gaoyunhaii and @lindong28 ,
   
   Thanks for the review. I have added a unit test. Please check out for 
`BroadcastVariableReceiverOperatorTest`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #17819: [FLINK-15816][k8s] Limit kubernetes.cluster-id to a maximum of 40 characters

2021-11-17 Thread GitBox


flinkbot commented on pull request #17819:
URL: https://github.com/apache/flink/pull/17819#issuecomment-971446006


   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit 7f0824c6027e9fdd23acd9c6f742614662e2fba2 (Wed Nov 17 
10:33:28 UTC 2021)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #17819: [FLINK-15816][k8s] Limit kubernetes.cluster-id to a maximum of 40 characters

2021-11-17 Thread GitBox


flinkbot commented on pull request #17819:
URL: https://github.com/apache/flink/pull/17819#issuecomment-971446182


   
   ## CI report:
   
   * 7f0824c6027e9fdd23acd9c6f742614662e2fba2 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17819: [FLINK-15816][k8s] Limit kubernetes.cluster-id to a maximum of 40 characters

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17819:
URL: https://github.com/apache/flink/pull/17819#issuecomment-971446182


   
   ## CI report:
   
   * 7f0824c6027e9fdd23acd9c6f742614662e2fba2 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26654)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #17133: [FLINK-24138] Architectural tests

2021-11-17 Thread GitBox


flinkbot edited a comment on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-912323602


   
   ## CI report:
   
   * cfb98c4cc708adb38ced719788af16a50625a1c1 UNKNOWN
   * baebf8dcd90968968de5d6363449fa39345b2f55 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23657)
 
   * 89b1db5b650484d255a469e62e480f0f9df496a4 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26646)
 
   * c0f52636331adf1db6268b504e674f1f41e3f07d Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26653)
 
   * c6ec114588077e7db35ec0ece0dee799e06bfc94 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




  1   2   3   4   5   >