[jira] [Created] (CXF-8640) Missing OSGi import javax.xml.ws in cxf bundles

2022-01-18 Thread Jan Filipski (Jira)
Jan Filipski created CXF-8640:
-

 Summary: Missing OSGi import javax.xml.ws in cxf bundles
 Key: CXF-8640
 URL: https://issues.apache.org/jira/browse/CXF-8640
 Project: CXF
  Issue Type: Bug
  Components: OSGi
 Environment: Issue is only visible on JDK9 or higher (where 
javax.xml.ws package is not present in JDK directly).
Can be easily reproduced on Karaf container if you try to install 
cxf-logging-feature.
Reporter: Jan Filipski


cxf-rt-features-logging bundle has missing import to javax.xml.ws package. This 
affects probably all versions.

LoggingFeature class has indirect dependency to javax.xml.ws.WebServiceFeature, 
by extending AbstractFeature.

Issue is directly visible, because OSGi Activator calls constructor in start 
method. That's blocking bundle activation. Probably all bundles with classes 
extending AbstractFeature has the same issue.

Not-so-elegant solution is to add javax.xml.ws package to classpath, imitating 
JDK8 and lower behavior (as I do for years). Target resolution should be 
provided by importing required package by cxf bundles.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (CXF-8641) NPE on NamePasswordCallbackHandler

2022-01-18 Thread Jan Filipski (Jira)
Jan Filipski created CXF-8641:
-

 Summary: NPE on NamePasswordCallbackHandler
 Key: CXF-8641
 URL: https://issues.apache.org/jira/browse/CXF-8641
 Project: CXF
  Issue Type: Bug
  Components: Core
Reporter: Jan Filipski


If Basic Auth password is empty, AbstractHTTPDestination sets password to null.
Later, if NamePasswordCallbackHandler is used, it calls String.toCharArray() on 
null password.
Standard authentication error should be present, without NullPointerException

Stacktrace looks like that
{code:java}
org.apache.cxf.interceptor.security.AuthenticationException: Authentication 
failed: java.lang.NullPointerException
    at 
org.apache.cxf.interceptor.security.NamePasswordCallbackHandler.handle(NamePasswordCallbackHandler.java:67)
    at 
java.base/javax.security.auth.login.LoginContext$SecureCallbackHandler$1.run(LoginContext.java:904)
    at 
java.base/javax.security.auth.login.LoginContext$SecureCallbackHandler$1.run(LoginContext.java:901)
    at java.base/java.security.AccessController.doPrivileged(Native Method)
    at 
java.base/javax.security.auth.login.LoginContext$SecureCallbackHandler.handle(LoginContext.java:901)
    at 
org.apache.karaf.jaas.modules.ldap.LDAPLoginModule.doLogin(LdapLoginModule.java:49)
    at 
org.apache.karaf.jaas.modules.ldap.LDAPLoginModule.login(LdapLoginModule.java:37)
    at 
org.apache.karaf.jaas.boot.ProxyLoginModule.login(ProxyLoginModule.java:83)
    at 
java.base/javax.security.auth.login.LoginContext.invoke(LoginContext.java:726)
    at 
java.base/javax.security.auth.login.LoginContext$4.run(LoginContext.java:665)
    at 
java.base/javax.security.auth.login.LoginContext$4.run(LoginContext.java:663)
    at java.base/java.security.AccessController.doPrivileged(Native Method)
    at 
java.base/javax.security.auth.login.LoginContext.invokePriv(LoginContext.java:663)
    at 
java.base/javax.security.auth.login.LoginContext.login(LoginContext.java:574)
    at 
org.apache.cxf.interceptor.security.JAASLoginInterceptor.handleMessage(JAASLoginInterceptor.java:140)
    at 
org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)
    at 
org.apache.cxf.transport.ChainInitiationObserver.onMessage(ChainInitiationObserver.java:121)
    at 
org.apache.cxf.transport.http.AbstractHTTPDestination.invoke(AbstractHTTPDestination.java:267)
    at 
org.apache.cxf.transport.servlet.ServletController.invokeDestination(ServletController.java:234)
    at 
org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:208)
    at 
org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:160)
    at 
org.apache.cxf.transport.servlet.CXFNonSpringServlet.invoke(CXFNonSpringServlet.java:225)
    at 
org.apache.cxf.transport.servlet.AbstractHTTPServlet.handleRequest(AbstractHTTPServlet.java:301)
    at 
org.apache.cxf.transport.servlet.AbstractHTTPServlet.doPost(AbstractHTTPServlet.java:220)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
    at 
org.apache.cxf.transport.servlet.AbstractHTTPServlet.service(AbstractHTTPServlet.java:276)
    at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:763)
    at 
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1631)
    at 
org.eclipse.jetty.websocket.server.WebSocketUpgradeFilter.doFilter(WebSocketUpgradeFilter.java:226)
    at 
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1618)
    at 
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:549)
    at 
org.ops4j.pax.web.service.jetty.internal.HttpServiceServletHandler.doHandle(HttpServiceServletHandler.java:71)
    at 
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
    at 
org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:602)
    at 
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
    at 
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235)
    at 
org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1610)
    at 
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
    at 
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1363)
    at 
org.ops4j.pax.web.service.jetty.internal.HttpServiceContext.doHandle(HttpServiceContext.java:298)
    at 
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
    at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:489)
    at 
org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1580)
    at 
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
    at 
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1278)
    at 
org.eclipse.jetty.server.handler

[jira] [Commented] (CXF-8640) Missing OSGi import javax.xml.ws in cxf bundles

2022-01-18 Thread Jan Filipski (Jira)


[ 
https://issues.apache.org/jira/browse/CXF-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477970#comment-17477970
 ] 

Jan Filipski commented on CXF-8640:
---

yes, you're right. That's a karaf issue in my own configuration.

Anyway, if someone is looking for issue with stacktrace like that, double check 
your configuration at etc/config.properties in 
org.osgi.framework.system.packages.extra property. Remainings from karaf 4.1.x 
endorsed libs causes a problem.
{code:java}
Caused by: java.lang.ClassNotFoundException: javax.xml.ws.WebServiceFeature
   at java.net.URLClassLoader.findClass(URLClassLoader.java:445) ~[?:?]
   at java.lang.ClassLoader.loadClass(ClassLoader.java:587) ~[?:?]
   at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
   at 
org.apache.felix.framework.ExtensionManager$ExtensionManagerWiring.getClassByDelegation(ExtensionManager.java:1179)
 ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl.searchImports(BundleWiringImpl.java:1586)
 ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl.findClassOrResourceByDelegation(BundleWiringImpl.java:1516)
 ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl.access$300(BundleWiringImpl.java:78)
 ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.loadClass(BundleWiringImpl.java:1950)
 ~[?:?]
   at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
   at java.lang.ClassLoader.defineClass1(Native Method) ~[?:?]
   at java.lang.ClassLoader.defineClass(ClassLoader.java:1012) ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.defineClass(BundleWiringImpl.java:2312)
 ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.defineClassParallel(BundleWiringImpl.java:2130)
 ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.findClass(BundleWiringImpl.java:2064)
 ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl.findClassOrResourceByDelegation(BundleWiringImpl.java:1533)
 ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl.access$300(BundleWiringImpl.java:78)
 ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.loadClass(BundleWiringImpl.java:1950)
 ~[?:?]
   at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
   at java.lang.ClassLoader.defineClass1(Native Method) ~[?:?]
   at java.lang.ClassLoader.defineClass(ClassLoader.java:1012) ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.defineClass(BundleWiringImpl.java:2312)
 ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.defineClassParallel(BundleWiringImpl.java:2130)
 ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.findClass(BundleWiringImpl.java:2064)
 ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl.findClassOrResourceByDelegation(BundleWiringImpl.java:1533)
 ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl.access$300(BundleWiringImpl.java:78)
 ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.loadClass(BundleWiringImpl.java:1950)
 ~[?:?]
   at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl.getClassByDelegation(BundleWiringImpl.java:1343)
 ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl.searchImports(BundleWiringImpl.java:1586)
 ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl.findClassOrResourceByDelegation(BundleWiringImpl.java:1516)
 ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl.access$300(BundleWiringImpl.java:78)
 ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.loadClass(BundleWiringImpl.java:1950)
 ~[?:?]
   at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
   at java.lang.ClassLoader.defineClass1(Native Method) ~[?:?]
   at java.lang.ClassLoader.defineClass(ClassLoader.java:1012) ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.defineClass(BundleWiringImpl.java:2312)
 ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.defineClassParallel(BundleWiringImpl.java:2130)
 ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.findClass(BundleWiringImpl.java:2064)
 ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl.findClassOrResourceByDelegation(BundleWiringImpl.java:1533)
 ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl.access$300(BundleWiringImpl.java:78)
 ~[?:?]
   at 
org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.loadClass(BundleWiringImpl.java:1950)
 ~[?:?]
   at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
   at 
org.apache.cxf.ext.logging.osgi.Activator$ConfigUpdater.(Activator.java:59)
 ~[?:?]
   at org.apache.cxf.ext.logging.osgi.Activator.start(Activator.java:44) ~[?:?]
   at 
org.apache.felix.framework.util.SecureAction.startActivator(SecureAction.java

[jira] [Closed] (CXF-8640) Missing OSGi import javax.xml.ws in cxf bundles

2022-01-18 Thread Jan Filipski (Jira)


 [ 
https://issues.apache.org/jira/browse/CXF-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Filipski closed CXF-8640.
-
Resolution: Invalid

> Missing OSGi import javax.xml.ws in cxf bundles
> ---
>
> Key: CXF-8640
> URL: https://issues.apache.org/jira/browse/CXF-8640
> Project: CXF
>  Issue Type: Bug
>  Components: OSGi
> Environment: Issue is only visible on JDK9 or higher (where 
> javax.xml.ws package is not present in JDK directly).
> Can be easily reproduced on Karaf container if you try to install 
> cxf-logging-feature.
>Reporter: Jan Filipski
>Assignee: Freeman Yue Fang
>Priority: Minor
>
> cxf-rt-features-logging bundle has missing import to javax.xml.ws package. 
> This affects probably all versions.
> LoggingFeature class has indirect dependency to 
> javax.xml.ws.WebServiceFeature, by extending AbstractFeature.
> Issue is directly visible, because OSGi Activator calls constructor in start 
> method. That's blocking bundle activation. Probably all bundles with classes 
> extending AbstractFeature has the same issue.
> Not-so-elegant solution is to add javax.xml.ws package to classpath, 
> imitating JDK8 and lower behavior (as I do for years). Target resolution 
> should be provided by importing required package by cxf bundles.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (CXF-8885) HttpClient SelectorManager threads run indefinitely causing OOM

2023-07-26 Thread Jan Filipski (Jira)


[ 
https://issues.apache.org/jira/browse/CXF-8885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17747489#comment-17747489
 ] 

Jan Filipski commented on CXF-8885:
---

workaround is to use old UrlConnectionHTTPConduit
Magic string to set in properties (should be public constant, found in source 
code) - force.urlconnection.http.conduit = true


Current implementation of HttpClientHTTPConduit is too buggy ATM. I'm normally 
using HC transport, but sometimes code fall back to default implementation.

> HttpClient SelectorManager threads run indefinitely causing OOM
> ---
>
> Key: CXF-8885
> URL: https://issues.apache.org/jira/browse/CXF-8885
> Project: CXF
>  Issue Type: Bug
>  Components: Transports
>Affects Versions: 4.0.0, 3.6.0
>Reporter: Cardo Eggert
>Priority: Major
> Attachments: image (5).png
>
>
> Probably caused by https://issues.apache.org/jira/browse/CXF-8840 .
> Started to notice that when updating from 3.5.x to 3.6.0 that our servers 
> started getting OOM. Noticed from the resulting logs that a lot of threads 
> were active that were in the format 
> HttpClient--SelectorManager
> when reverted to 3.5.6 then it did not occur anymore.
>  
> Tried to use VirtualVM when debugging it and saw when the thread was started, 
> it never died, basically meaning that it ran indefinitely. OOM happened when 
> there were about over 1000 of these threads.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)