[jira] [Commented] (CXF-8893) Hard coded slashes at the end of SOAP namespaces are not always appreciated

2023-06-29 Thread Mark Kahl (Jira)


[ 
https://issues.apache.org/jira/browse/CXF-8893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738382#comment-17738382
 ] 

Mark Kahl commented on CXF-8893:


[~reta]: yes, exactly, and thank you for your commitment

I'm still investigating, but so far, I'm quite sure it is line 178 in 
"PackageUtils" that generates the slash.

I would be happy to supply a pull-request that allows an option to stear the 
behaviour.  Unfortunally, I have no clue how to introduce a new option.

> Hard coded slashes at the end of SOAP namespaces are not always appreciated
> ---
>
> Key: CXF-8893
> URL: https://issues.apache.org/jira/browse/CXF-8893
> Project: CXF
>  Issue Type: Improvement
>  Components: Core, JAX-WS Runtime
>Affects Versions: 4.0.2
>Reporter: Mark Kahl
>Priority: Major
>
> There are some functions that explicitly append a slash to URL's (see below), 
> which is not always helpful. I have a client, unfortunately not under my 
> jurisdiction, that refuses to work with my SOAP-service, since the service 
> exports a WSDL-file, generated by CXF, that has a slash appended.
> I understand that just skipping the slash probably will affect a plethora of 
> applications that rely on it, so maybe an option could be introduced 
> modifying line 178 in the class: "PackageUtils" to:
>  * return "http://"; + String.join(".", parts) + *((optionNoTrailingSlash) ? 
> "" :* '/'{*}){*};
> instead of the current:
>  * return "http://"; + String.join(".", parts) + '/';
> for example.
> h1. Statements that immutably append slashes
> The following list is the result of a regular expression search, probably not 
> all of them are relevant.
> core/src/main/java/org/apache/cxf/common/util/PackageUtils.java:178:        
> return "http://"; + String.join(".", parts) + '/';
> core/src/main/java/org/apache/cxf/helpers/ServiceUtils.java:211:        
> return protocol + "://" + String.join(".", words) + "/";
> rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/NewCookieHeaderProvider.java:43:
>     private static final String TSPECIALS_ALL = TSPECIALS_PATH + "/";
> rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/UriInfoImpl.java:230:
>             address = address + "/";
> rt/rs/description-swagger-ui/src/main/java/org/apache/cxf/jaxrs/swagger/ui/SwaggerUiResolver.java:69:
>             return urlStr + UI_RESOURCES_ROOT_START + version + "/";
> rt/transports/http/src/main/java/org/apache/cxf/transport/http/HttpUrlUtil.java:30:
>             pathString = pathString + "/";
> systests/microprofile/client/jaxrs/src/test/java/org/apache/cxf/systest/microprofile/rest/client/regex/JaxrsPathRegexTest.java:76:
>         String endpointAddress = "http://localhost:"; + PORT + "/";
> systests/microprofile/client/jaxrs/src/test/java/org/apache/cxf/systest/microprofile/rest/client/regex/JaxrsPathRegexTest.java:121:
>         String endpointAddress = "http://localhost:"; + PORT + "/";
> systests/uncategorized/src/test/java/org/apache/cxf/systest/transform/feature/TransformFeatureTest.java:95:
>         String endpoint = "http://127.0.0.1:"; + socket.getLocalPort() + "/";
> tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/idl/ModuleToNSMapper.java:108:
>                     parentURI = parentURI + "/";



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (CXF-8861) Get rid of EasyMock in cxf-rt-ws-policy

2023-06-29 Thread Andriy Redko (Jira)


 [ 
https://issues.apache.org/jira/browse/CXF-8861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andriy Redko resolved CXF-8861.
---
Resolution: Fixed

> Get rid of EasyMock in cxf-rt-ws-policy
> ---
>
> Key: CXF-8861
> URL: https://issues.apache.org/jira/browse/CXF-8861
> Project: CXF
>  Issue Type: Sub-task
>Reporter: Andriy Redko
>Assignee: Andriy Redko
>Priority: Major
> Fix For: 3.6.2, 4.0.3
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (CXF-8892) CXF fails to compile in project cxf-tools-wsdlto-test

2023-06-29 Thread Mark Kahl (Jira)


[ 
https://issues.apache.org/jira/browse/CXF-8892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738708#comment-17738708
 ] 

Mark Kahl commented on CXF-8892:


Sorry [~reta] for coming back to you so late, however I was under the 
impression of having answered already!  I don't know what went wrong.

Yes, syntactically you are right: these are test failures, semantically it 
makes no difference for me, since they stop the compilation process.  The 
problem is, on the one hand, that tests that don't work are always a warning 
signal, and on the other hand - even worse - our Gitlab pipelines do not allow 
the tests to be switched off.

> CXF fails to compile in project cxf-tools-wsdlto-test
> -
>
> Key: CXF-8892
> URL: https://issues.apache.org/jira/browse/CXF-8892
> Project: CXF
>  Issue Type: Bug
>  Components: Build system
>Affects Versions: 4.0.2
> Environment: Windows 11
> JDK Eclipse Adoptium 17.7.2
>Reporter: Mark Kahl
>Priority: Major
> Attachments: CXF-Compile-Log-Failure-tools-wsdlto-test.log
>
>
> When compiling CXF the compilation succeeds when using the -DskipTests 
> switch.  When the tests are run they fail in the step "cxf-tools-wsdlto-test".
> See attached log.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)