[jira] [Commented] (CXF-7289) CXF wsdl2java fails when using existing compilation expisodes of schemata
[ https://issues.apache.org/jira/browse/CXF-7289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934707#comment-15934707 ] Daniel Kulp commented on CXF-7289: -- If that would work... sure.That would be great. > CXF wsdl2java fails when using existing compilation expisodes of schemata > - > > Key: CXF-7289 > URL: https://issues.apache.org/jira/browse/CXF-7289 > Project: CXF > Issue Type: Bug > Components: JAXB Databinding >Affects Versions: 3.1.10 >Reporter: Niels Bertram > > Including a schema from an earlier compilation episode in a wsdl schema with > the same namespace will cause to CXF fail when resolving the Java type when > constructing the wsdl operation parameter. > the issue is rather complex to demonstrate so I created a fully functioning > compilation project at https://github.com/bertramn/cxf-wsdlgen-issue -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (CXF-7293) AbstractSpringComponentScanServer must ignore client proxy classes
Dennis Kieselhorst created CXF-7293: --- Summary: AbstractSpringComponentScanServer must ignore client proxy classes Key: CXF-7293 URL: https://issues.apache.org/jira/browse/CXF-7293 Project: CXF Issue Type: Bug Affects Versions: 3.1.10 Reporter: Dennis Kieselhorst Fix For: 3.2.0 Follow-up to discussion: https://lists.apache.org/thread.html/f0982d37f633ab831ecba95fda6b7e97c4b79d62f879914d495c9593@%3Cusers.cxf.apache.org%3E In applications that expose some JAX-RS resources and use some JAX-RS clients to access other systems, currently also these client proxies are exposed (if the application is configured with component-scan=true and classes-scan-packages). I'll create a PR with a fix for it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CXF-7293) AbstractSpringComponentScanServer must ignore client proxy classes
[ https://issues.apache.org/jira/browse/CXF-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934783#comment-15934783 ] Sergey Beryozkin commented on CXF-7293: --- Hi Dennis I'm just about to commit some other change to this class, please wait for may be 30 mins Sergey > AbstractSpringComponentScanServer must ignore client proxy classes > -- > > Key: CXF-7293 > URL: https://issues.apache.org/jira/browse/CXF-7293 > Project: CXF > Issue Type: Bug >Affects Versions: 3.1.10 >Reporter: Dennis Kieselhorst > Fix For: 3.2.0 > > > Follow-up to discussion: > https://lists.apache.org/thread.html/f0982d37f633ab831ecba95fda6b7e97c4b79d62f879914d495c9593@%3Cusers.cxf.apache.org%3E > In applications that expose some JAX-RS resources and use some > JAX-RS clients to access other systems, currently also these client proxies > are exposed (if the application is configured with component-scan=true and > classes-scan-packages). > I'll create a PR with a fix for it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CXF-7293) AbstractSpringComponentScanServer must ignore client proxy classes
[ https://issues.apache.org/jira/browse/CXF-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934786#comment-15934786 ] Dennis Kieselhorst commented on CXF-7293: - Ok I'll update and rebase before creating the PR. > AbstractSpringComponentScanServer must ignore client proxy classes > -- > > Key: CXF-7293 > URL: https://issues.apache.org/jira/browse/CXF-7293 > Project: CXF > Issue Type: Bug > Components: JAX-RS >Affects Versions: 3.1.10 >Reporter: Dennis Kieselhorst > Fix For: 3.2.0 > > > Follow-up to discussion: > https://lists.apache.org/thread.html/f0982d37f633ab831ecba95fda6b7e97c4b79d62f879914d495c9593@%3Cusers.cxf.apache.org%3E > In applications that expose some JAX-RS resources and use some > JAX-RS clients to access other systems, currently also these client proxies > are exposed (if the application is configured with component-scan=true and > classes-scan-packages). > I'll create a PR with a fix for it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (CXF-7293) AbstractSpringComponentScanServer must ignore client proxy classes
[ https://issues.apache.org/jira/browse/CXF-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Kieselhorst updated CXF-7293: Component/s: JAX-RS > AbstractSpringComponentScanServer must ignore client proxy classes > -- > > Key: CXF-7293 > URL: https://issues.apache.org/jira/browse/CXF-7293 > Project: CXF > Issue Type: Bug > Components: JAX-RS >Affects Versions: 3.1.10 >Reporter: Dennis Kieselhorst > Fix For: 3.2.0 > > > Follow-up to discussion: > https://lists.apache.org/thread.html/f0982d37f633ab831ecba95fda6b7e97c4b79d62f879914d495c9593@%3Cusers.cxf.apache.org%3E > In applications that expose some JAX-RS resources and use some > JAX-RS clients to access other systems, currently also these client proxies > are exposed (if the application is configured with component-scan=true and > classes-scan-packages). > I'll create a PR with a fix for it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (CXF-7290) Restrict which @Bean components are treated as JAX-RS providers
[ https://issues.apache.org/jira/browse/CXF-7290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Beryozkin resolved CXF-7290. --- Resolution: Fixed Assignee: Sergey Beryozkin > Restrict which @Bean components are treated as JAX-RS providers > --- > > Key: CXF-7290 > URL: https://issues.apache.org/jira/browse/CXF-7290 > Project: CXF > Issue Type: Improvement > Components: JAX-RS >Reporter: Sergey Beryozkin >Assignee: Sergey Beryozkin > Fix For: 3.2.0, 3.1.11 > > > if a @Bean component is a singleton then we can try and restrict on the class > package basis or we can check the bean names -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CXF-7290) Restrict which @Bean components are treated as JAX-RS providers
[ https://issues.apache.org/jira/browse/CXF-7290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934817#comment-15934817 ] Sergey Beryozkin commented on CXF-7290: --- cxf.jaxrs.component-scan-packages and cxf.jaxrs.component-scan-beans properties are introduced. The former, if set, can only be effective if a given bean is a singleton > Restrict which @Bean components are treated as JAX-RS providers > --- > > Key: CXF-7290 > URL: https://issues.apache.org/jira/browse/CXF-7290 > Project: CXF > Issue Type: Improvement > Components: JAX-RS >Reporter: Sergey Beryozkin > Fix For: 3.2.0, 3.1.11 > > > if a @Bean component is a singleton then we can try and restrict on the class > package basis or we can check the bean names -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CXF-7293) AbstractSpringComponentScanServer must ignore client proxy classes
[ https://issues.apache.org/jira/browse/CXF-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934823#comment-15934823 ] Sergey Beryozkin commented on CXF-7293: --- Please check https://issues.apache.org/jira/browse/CXF-7290 By the way, if we skip Proxies, can we miss for example CGLIB-proxified JAX-RS service beans ? > AbstractSpringComponentScanServer must ignore client proxy classes > -- > > Key: CXF-7293 > URL: https://issues.apache.org/jira/browse/CXF-7293 > Project: CXF > Issue Type: Bug > Components: JAX-RS >Affects Versions: 3.1.10 >Reporter: Dennis Kieselhorst > Fix For: 3.2.0 > > > Follow-up to discussion: > https://lists.apache.org/thread.html/f0982d37f633ab831ecba95fda6b7e97c4b79d62f879914d495c9593@%3Cusers.cxf.apache.org%3E > In applications that expose some JAX-RS resources and use some > JAX-RS clients to access other systems, currently also these client proxies > are exposed (if the application is configured with component-scan=true and > classes-scan-packages). > I'll create a PR with a fix for it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CXF-7293) AbstractSpringComponentScanServer must ignore client proxy classes
[ https://issues.apache.org/jira/browse/CXF-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934863#comment-15934863 ] ASF GitHub Bot commented on CXF-7293: - GitHub user deki opened a pull request: https://github.com/apache/cxf/pull/249 CXF-7293: AbstractSpringComponentScanServer must ignore client proxy … …classes You can merge this pull request into a Git repository by running: $ git pull https://github.com/deki/cxf CXF-7293 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cxf/pull/249.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #249 commit 6c66f7477d32c05a27bd29101fe376a92b0e7398 Author: Dennis Kieselhorst Date: 2017-03-21T15:48:57Z CXF-7293: AbstractSpringComponentScanServer must ignore client proxy classes > AbstractSpringComponentScanServer must ignore client proxy classes > -- > > Key: CXF-7293 > URL: https://issues.apache.org/jira/browse/CXF-7293 > Project: CXF > Issue Type: Bug > Components: JAX-RS >Affects Versions: 3.1.10 >Reporter: Dennis Kieselhorst > Fix For: 3.2.0 > > > Follow-up to discussion: > https://lists.apache.org/thread.html/f0982d37f633ab831ecba95fda6b7e97c4b79d62f879914d495c9593@%3Cusers.cxf.apache.org%3E > In applications that expose some JAX-RS resources and use some > JAX-RS clients to access other systems, currently also these client proxies > are exposed (if the application is configured with component-scan=true and > classes-scan-packages). > I'll create a PR with a fix for it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CXF-7293) AbstractSpringComponentScanServer must ignore client proxy classes
[ https://issues.apache.org/jira/browse/CXF-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934868#comment-15934868 ] Dennis Kieselhorst commented on CXF-7293: - You mean instead of Proxy.class we should be more specific and use ClientProxyImpl? Looks like it makes sense to move this also to your newly introduced isValidComponent method, what do you think? > AbstractSpringComponentScanServer must ignore client proxy classes > -- > > Key: CXF-7293 > URL: https://issues.apache.org/jira/browse/CXF-7293 > Project: CXF > Issue Type: Bug > Components: JAX-RS >Affects Versions: 3.1.10 >Reporter: Dennis Kieselhorst > Fix For: 3.2.0 > > > Follow-up to discussion: > https://lists.apache.org/thread.html/f0982d37f633ab831ecba95fda6b7e97c4b79d62f879914d495c9593@%3Cusers.cxf.apache.org%3E > In applications that expose some JAX-RS resources and use some > JAX-RS clients to access other systems, currently also these client proxies > are exposed (if the application is configured with component-scan=true and > classes-scan-packages). > I'll create a PR with a fix for it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CXF-7293) AbstractSpringComponentScanServer must ignore client proxy classes
[ https://issues.apache.org/jira/browse/CXF-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934886#comment-15934886 ] Sergey Beryozkin commented on CXF-7293: --- We can't refer to the ClientProxyImpl because it is in the other module. Can you use the newly added properties to make sure the client proxies are not included ? > AbstractSpringComponentScanServer must ignore client proxy classes > -- > > Key: CXF-7293 > URL: https://issues.apache.org/jira/browse/CXF-7293 > Project: CXF > Issue Type: Bug > Components: JAX-RS >Affects Versions: 3.1.10 >Reporter: Dennis Kieselhorst > Fix For: 3.2.0 > > > Follow-up to discussion: > https://lists.apache.org/thread.html/f0982d37f633ab831ecba95fda6b7e97c4b79d62f879914d495c9593@%3Cusers.cxf.apache.org%3E > In applications that expose some JAX-RS resources and use some > JAX-RS clients to access other systems, currently also these client proxies > are exposed (if the application is configured with component-scan=true and > classes-scan-packages). > I'll create a PR with a fix for it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CXF-7291) sharedPackageName for Swagger description should ignore proxy classes
[ https://issues.apache.org/jira/browse/CXF-7291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934911#comment-15934911 ] ASF GitHub Bot commented on CXF-7291: - Github user sberyozkin commented on the issue: https://github.com/apache/cxf/pull/247 Hi Dennis, is it related to the client proxy thing ? > sharedPackageName for Swagger description should ignore proxy classes > - > > Key: CXF-7291 > URL: https://issues.apache.org/jira/browse/CXF-7291 > Project: CXF > Issue Type: Bug > Components: JAX-RS >Affects Versions: 3.1.10 >Reporter: Dennis Kieselhorst > Fix For: 3.2.0 > > > A com.sun.proxy class causes empty Swagger description because the > resourcePackage is empty in this case. > I'll create a PR with a fix. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CXF-7291) sharedPackageName for Swagger description should ignore proxy classes
[ https://issues.apache.org/jira/browse/CXF-7291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934917#comment-15934917 ] ASF GitHub Bot commented on CXF-7291: - Github user deki commented on the issue: https://github.com/apache/cxf/pull/247 yes but in my view this should be fixed in any case > sharedPackageName for Swagger description should ignore proxy classes > - > > Key: CXF-7291 > URL: https://issues.apache.org/jira/browse/CXF-7291 > Project: CXF > Issue Type: Bug > Components: JAX-RS >Affects Versions: 3.1.10 >Reporter: Dennis Kieselhorst > Fix For: 3.2.0 > > > A com.sun.proxy class causes empty Swagger description because the > resourcePackage is empty in this case. > I'll create a PR with a fix. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CXF-7291) sharedPackageName for Swagger description should ignore proxy classes
[
https://issues.apache.org/jira/browse/CXF-7291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934922#comment-15934922
]
ASF GitHub Bot commented on CXF-7291:
-
Github user reta commented on a diff in the pull request:
https://github.com/apache/cxf/pull/247#discussion_r107218893
--- Diff: core/src/main/java/org/apache/cxf/common/util/PackageUtils.java
---
@@ -56,7 +57,9 @@ public static String getSharedPackageName(List>
classes) {
List> lParts = new
ArrayList>(classes.size());
List currentParts = new ArrayList<>();
for (Class cls : classes) {
-lParts.add(StringUtils.getParts(getPackageName(cls), "\\."));
+if (!Proxy.isProxyClass(cls)) {
--- End diff --
In this case, should we get the real class using `getProxyClass` and
extract the package from it?
> sharedPackageName for Swagger description should ignore proxy classes
> -
>
> Key: CXF-7291
> URL: https://issues.apache.org/jira/browse/CXF-7291
> Project: CXF
> Issue Type: Bug
> Components: JAX-RS
>Affects Versions: 3.1.10
>Reporter: Dennis Kieselhorst
> Fix For: 3.2.0
>
>
> A com.sun.proxy class causes empty Swagger description because the
> resourcePackage is empty in this case.
> I'll create a PR with a fix.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CXF-7293) AbstractSpringComponentScanServer must ignore client proxy classes
[ https://issues.apache.org/jira/browse/CXF-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934923#comment-15934923 ] Dennis Kieselhorst commented on CXF-7293: - Should work, I'll give it a try tomorrow. I still think it makes sense to ignore proxies by default because nobody is aware of that they get exposed automatically and this causes side-effects. > AbstractSpringComponentScanServer must ignore client proxy classes > -- > > Key: CXF-7293 > URL: https://issues.apache.org/jira/browse/CXF-7293 > Project: CXF > Issue Type: Bug > Components: JAX-RS >Affects Versions: 3.1.10 >Reporter: Dennis Kieselhorst > Fix For: 3.2.0 > > > Follow-up to discussion: > https://lists.apache.org/thread.html/f0982d37f633ab831ecba95fda6b7e97c4b79d62f879914d495c9593@%3Cusers.cxf.apache.org%3E > In applications that expose some JAX-RS resources and use some > JAX-RS clients to access other systems, currently also these client proxies > are exposed (if the application is configured with component-scan=true and > classes-scan-packages). > I'll create a PR with a fix for it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CXF-7293) AbstractSpringComponentScanServer must ignore client proxy classes
[ https://issues.apache.org/jira/browse/CXF-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934951#comment-15934951 ] Sergey Beryozkin commented on CXF-7293: --- But we don't want to lose the proxified service beans which can also happen, say if Spring transactions are enabled ? This is what I'm concerned about. > AbstractSpringComponentScanServer must ignore client proxy classes > -- > > Key: CXF-7293 > URL: https://issues.apache.org/jira/browse/CXF-7293 > Project: CXF > Issue Type: Bug > Components: JAX-RS >Affects Versions: 3.1.10 >Reporter: Dennis Kieselhorst > Fix For: 3.2.0 > > > Follow-up to discussion: > https://lists.apache.org/thread.html/f0982d37f633ab831ecba95fda6b7e97c4b79d62f879914d495c9593@%3Cusers.cxf.apache.org%3E > In applications that expose some JAX-RS resources and use some > JAX-RS clients to access other systems, currently also these client proxies > are exposed (if the application is configured with component-scan=true and > classes-scan-packages). > I'll create a PR with a fix for it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CXF-7291) sharedPackageName for Swagger description should ignore proxy classes
[ https://issues.apache.org/jira/browse/CXF-7291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934957#comment-15934957 ] Sergey Beryozkin commented on CXF-7291: --- Sure let me have a look > sharedPackageName for Swagger description should ignore proxy classes > - > > Key: CXF-7291 > URL: https://issues.apache.org/jira/browse/CXF-7291 > Project: CXF > Issue Type: Bug > Components: JAX-RS >Affects Versions: 3.1.10 >Reporter: Dennis Kieselhorst > Fix For: 3.2.0 > > > A com.sun.proxy class causes empty Swagger description because the > resourcePackage is empty in this case. > I'll create a PR with a fix. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
