[jira] [Created] (CXF-6869) Consider adding Spring Boot starter

2016-04-17 Thread Vedran Pavic (JIRA)
Vedran Pavic created CXF-6869:
-

 Summary: Consider adding Spring Boot starter
 Key: CXF-6869
 URL: https://issues.apache.org/jira/browse/CXF-6869
 Project: CXF
  Issue Type: New Feature
  Components: Integration
Reporter: Vedran Pavic


I've recently authored a PR in Spring Boot to add support for 
auto-configuration of {{CXFServlet}} and default CXF's configuration:
https://github.com/spring-projects/spring-boot/pull/5659

The PR was closed with "won't fix" resolution since Boot team are unwilling to 
add CXF as a dependency to the project. Instead a 3rd party starter was 
suggested.

The concept of a 3rd party starter is generally encouraged for technologies 
that don't have first-class support in projects from Spring portfolio. Such 3rd 
party starters are listed here:
https://github.com/spring-projects/spring-boot/blob/master/spring-boot-starters/README.adoc

If CXF team is interested, I'm willing to port my PR to CXF.

Note that the original PR was focused around JAX-WS support, but can be easily 
expanded to include JAX-RS support as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CXF-6834) add support for CXF inside Spring Boot

2016-04-17 Thread Vedran Pavic (JIRA)

[ 
https://issues.apache.org/jira/browse/CXF-6834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244842#comment-15244842
 ] 

Vedran Pavic commented on CXF-6834:
---

Somewhat related to CXF-6869, note that Spring Boot team is unwilling to add 
CXF as a dependency to the project and have instead suggested a 3rd party 
starter.

> add support for CXF inside Spring Boot
> --
>
> Key: CXF-6834
> URL: https://issues.apache.org/jira/browse/CXF-6834
> Project: CXF
>  Issue Type: Improvement
>  Components: JAX-RS
>Reporter: james strachan
>Assignee: Sergey Beryozkin
> Fix For: 3.1.7, 3.2.0
>
>
> right now spring boot has support for Jersey; it'd be great to integrate 
> support for CXF too.
> e.g.
> * 
> https://github.com/spring-projects/spring-boot/tree/master/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jersey
> * 
> https://github.com/spring-projects/spring-boot/tree/master/spring-boot-starters/spring-boot-starter-jersey
> * 
> https://github.com/spring-projects/spring-boot/tree/master/spring-boot-samples/spring-boot-sample-jersey
> * 
> https://github.com/spring-projects/spring-boot/tree/master/spring-boot-samples/spring-boot-sample-jersey1
> mostly this is about submitting a PR against the spring-boot project; but it 
> may require a few changes in CXF to be more spring/spring-boot ready or to 
> work better with Spring Boot's auto configuration mechanism and tooling:
> * 
> https://docs.spring.io/spring-boot/docs/current/reference/html/using-boot-auto-configuration.html
> * 
> https://docs.spring.io/spring-boot/docs/current/reference/html/boot-features-external-config.html
> Docs on creating auto configuration here:
> https://docs.spring.io/spring-boot/docs/current/reference/html/boot-features-developing-auto-configuration.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CXF-6869) Consider adding Spring Boot starter

2016-04-17 Thread Sergey Beryozkin (JIRA)

[ 
https://issues.apache.org/jira/browse/CXF-6869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244878#comment-15244878
 ] 

Sergey Beryozkin commented on CXF-6869:
---

+1, can you please consider porting your PR ? Supporting both frontends would 
be great

Cheers, Sergey 

> Consider adding Spring Boot starter
> ---
>
> Key: CXF-6869
> URL: https://issues.apache.org/jira/browse/CXF-6869
> Project: CXF
>  Issue Type: New Feature
>  Components: Integration
>Reporter: Vedran Pavic
>
> I've recently authored a PR in Spring Boot to add support for 
> auto-configuration of {{CXFServlet}} and default CXF's configuration:
> https://github.com/spring-projects/spring-boot/pull/5659
> The PR was closed with "won't fix" resolution since Boot team are unwilling 
> to add CXF as a dependency to the project. Instead a 3rd party starter was 
> suggested.
> The concept of a 3rd party starter is generally encouraged for technologies 
> that don't have first-class support in projects from Spring portfolio. Such 
> 3rd party starters are listed here:
> https://github.com/spring-projects/spring-boot/blob/master/spring-boot-starters/README.adoc
> If CXF team is interested, I'm willing to port my PR to CXF.
> Note that the original PR was focused around JAX-WS support, but can be 
> easily expanded to include JAX-RS support as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CXF-6834) add support for CXF inside Spring Boot

2016-04-17 Thread Sergey Beryozkin (JIRA)

[ 
https://issues.apache.org/jira/browse/CXF-6834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244887#comment-15244887
 ] 

Sergey Beryozkin commented on CXF-6834:
---

Hi, yes, +1 to having CXF-6869 addressed. If you already have some material 
then it is really great.

Can you please educate me a bit and explain what does having CXF more closely 
integrated with Spring Boot would give CXF users ?  

So we've talked with James, we ship a demo and the demo shows a not-too-bad 
level of the integration (ex, SampleRestScanApplication). However there we 
create CXFServlet manually. And say if need to configure something that we have 
a @Bean method (though I suspect the injection can be done via the external 
properties automatically). And I appreciate that more is achievable. But what 
additional coolness can a closer integration bring ? 

I fully support for the better integration be done, but would like to 
understand what are we aiming at.

Thanks, Sergey

> add support for CXF inside Spring Boot
> --
>
> Key: CXF-6834
> URL: https://issues.apache.org/jira/browse/CXF-6834
> Project: CXF
>  Issue Type: Improvement
>  Components: JAX-RS
>Reporter: james strachan
>Assignee: Sergey Beryozkin
> Fix For: 3.1.7, 3.2.0
>
>
> right now spring boot has support for Jersey; it'd be great to integrate 
> support for CXF too.
> e.g.
> * 
> https://github.com/spring-projects/spring-boot/tree/master/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jersey
> * 
> https://github.com/spring-projects/spring-boot/tree/master/spring-boot-starters/spring-boot-starter-jersey
> * 
> https://github.com/spring-projects/spring-boot/tree/master/spring-boot-samples/spring-boot-sample-jersey
> * 
> https://github.com/spring-projects/spring-boot/tree/master/spring-boot-samples/spring-boot-sample-jersey1
> mostly this is about submitting a PR against the spring-boot project; but it 
> may require a few changes in CXF to be more spring/spring-boot ready or to 
> work better with Spring Boot's auto configuration mechanism and tooling:
> * 
> https://docs.spring.io/spring-boot/docs/current/reference/html/using-boot-auto-configuration.html
> * 
> https://docs.spring.io/spring-boot/docs/current/reference/html/boot-features-external-config.html
> Docs on creating auto configuration here:
> https://docs.spring.io/spring-boot/docs/current/reference/html/boot-features-developing-auto-configuration.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (CXF-6834) add support for CXF inside Spring Boot

2016-04-17 Thread Sergey Beryozkin (JIRA)

[ 
https://issues.apache.org/jira/browse/CXF-6834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244887#comment-15244887
 ] 

Sergey Beryozkin edited comment on CXF-6834 at 4/17/16 8:22 PM:


Hi, yes, +1 to having CXF-6869 addressed. If you already have some material 
then it is really great.

Can you please educate me a bit and explain what does having CXF more closely 
integrated with Spring Boot would give CXF users ?  

So we've talked with James, we ship a demo and the demo shows a not-too-bad 
level of the integration (ex, SampleRestScanApplication). However there we 
create CXFServlet manually. And say if we need to configure something that we 
have a @Bean method (though I suspect the injection can be done via the 
external properties automatically). And I appreciate that more is achievable. 
But what additional coolness can a closer integration bring ? 

I fully support for the better integration be done, but would like to 
understand what are we aiming at.

Thanks, Sergey


was (Author: sergey_beryozkin):
Hi, yes, +1 to having CXF-6869 addressed. If you already have some material 
then it is really great.

Can you please educate me a bit and explain what does having CXF more closely 
integrated with Spring Boot would give CXF users ?  

So we've talked with James, we ship a demo and the demo shows a not-too-bad 
level of the integration (ex, SampleRestScanApplication). However there we 
create CXFServlet manually. And say if need to configure something that we have 
a @Bean method (though I suspect the injection can be done via the external 
properties automatically). And I appreciate that more is achievable. But what 
additional coolness can a closer integration bring ? 

I fully support for the better integration be done, but would like to 
understand what are we aiming at.

Thanks, Sergey

> add support for CXF inside Spring Boot
> --
>
> Key: CXF-6834
> URL: https://issues.apache.org/jira/browse/CXF-6834
> Project: CXF
>  Issue Type: Improvement
>  Components: JAX-RS
>Reporter: james strachan
>Assignee: Sergey Beryozkin
> Fix For: 3.1.7, 3.2.0
>
>
> right now spring boot has support for Jersey; it'd be great to integrate 
> support for CXF too.
> e.g.
> * 
> https://github.com/spring-projects/spring-boot/tree/master/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jersey
> * 
> https://github.com/spring-projects/spring-boot/tree/master/spring-boot-starters/spring-boot-starter-jersey
> * 
> https://github.com/spring-projects/spring-boot/tree/master/spring-boot-samples/spring-boot-sample-jersey
> * 
> https://github.com/spring-projects/spring-boot/tree/master/spring-boot-samples/spring-boot-sample-jersey1
> mostly this is about submitting a PR against the spring-boot project; but it 
> may require a few changes in CXF to be more spring/spring-boot ready or to 
> work better with Spring Boot's auto configuration mechanism and tooling:
> * 
> https://docs.spring.io/spring-boot/docs/current/reference/html/using-boot-auto-configuration.html
> * 
> https://docs.spring.io/spring-boot/docs/current/reference/html/boot-features-external-config.html
> Docs on creating auto configuration here:
> https://docs.spring.io/spring-boot/docs/current/reference/html/boot-features-developing-auto-configuration.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CXF-6870) CXF doesn't check the message body's generic type

2016-04-17 Thread Neal Hu (JIRA)
Neal Hu created CXF-6870:


 Summary: CXF doesn't check the message body's generic type
 Key: CXF-6870
 URL: https://issues.apache.org/jira/browse/CXF-6870
 Project: CXF
  Issue Type: Bug
  Components: JAX-RS
Affects Versions: 3.0.9, 3.1.6, 3.1.3
 Environment: mac, windows
Reporter: Neal Hu
 Fix For: 3.0.10, 3.1.7, 3.2.0


CXF doesn't check the message body's generic type, please see the sample below.
{code:java}
public class ListAProvider implements MessageBodyWriter> 
public class ListBProvider implements MessageBodyWriter> 

resource class:

@GET
@Path("/echo/{param}")
@Produces("application/json")
public List echo(@PathParam("param")String name){
List list = new ArrayList();
list.add("hello");
list.add(name);
return list;
}

@GET
@Path("/echo2/{param}")
@Produces("application/json")
public List echo2(@PathParam("param")String name){
List list = new ArrayList();
list.add(1);
list.add(2);
return list;
}
{code}

No matter you request echo or echo2 resource method, the selected provider is 
ListBProvider



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (CXF-6870) CXF doesn't check the message body's generic type

2016-04-17 Thread Neal Hu (JIRA)

 [ 
https://issues.apache.org/jira/browse/CXF-6870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neal Hu updated CXF-6870:
-
Attachment: beans.xml
Resource.java
ListBProvider.java
ListAProvider.java

> CXF doesn't check the message body's generic type
> -
>
> Key: CXF-6870
> URL: https://issues.apache.org/jira/browse/CXF-6870
> Project: CXF
>  Issue Type: Bug
>  Components: JAX-RS
>Affects Versions: 3.1.3, 3.1.6, 3.0.9
> Environment: mac, windows
>Reporter: Neal Hu
> Fix For: 3.0.10, 3.1.7, 3.2.0
>
> Attachments: ListAProvider.java, ListBProvider.java, Resource.java, 
> beans.xml
>
>
> CXF doesn't check the message body's generic type, please see the sample 
> below.
> {code:java}
> public class ListAProvider implements MessageBodyWriter> 
> public class ListBProvider implements MessageBodyWriter> 
> resource class:
>   @GET
>   @Path("/echo/{param}")
>   @Produces("application/json")
>   public List echo(@PathParam("param")String name){
>   List list = new ArrayList();
>   list.add("hello");
>   list.add(name);
>   return list;
>   }
>   
>   @GET
>   @Path("/echo2/{param}")
>   @Produces("application/json")
>   public List echo2(@PathParam("param")String name){
>   List list = new ArrayList();
>   list.add(1);
>   list.add(2);
>   return list;
>   }
> {code}
> No matter you request echo or echo2 resource method, the selected provider is 
> ListBProvider



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)