[jira] Commented: (DOSGI-76) EndpointListener.endpointRemoved
[
https://issues.apache.org/jira/browse/DOSGI-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904574#action_12904574
]
Marco Mauri commented on DOSGI-76:
--
I think to have pinned down the error: the method removeService of the
TopologyManager should notify all the registered EndpointListener of the
removed service.
I attach a patch that I wrote to solve my problem.
> EndpointListener.endpointRemoved
>
>
> Key: DOSGI-76
> URL: https://issues.apache.org/jira/browse/DOSGI-76
> Project: CXF Distributed OSGi
> Issue Type: Bug
> Environment: Eclipse 3.5
> CXF Dosgi 1.2
>Reporter: Marco Mauri
> Attachments: TopMan.diff
>
>
> The endpointRemoved method of a registered EndpointListener is never called
> even if an exported service is unregistered.
> I've written a simple Endpoint listener:
> public class EndpointListenerImpl implements EndpointListener {
> private static final Logger logger =
> Logger.getLogger(EndpointListenerImpl.class.getName());
> @Override
> public void endpointAdded(EndpointDescription arg0, String arg1) {
> logger.severe("Added: " + arg0);
>
> }
> @Override
> public void endpointRemoved(EndpointDescription arg0, String arg1) {
> logger.severe("Removed: " + arg0);
>
> }
> }
> and registered it in my activator:
> public void start(BundleContext context) throws Exception {
> Properties props = new Properties();
> props.put(EndpointListener.ENDPOINT_LISTENER_SCOPE, "(" +
> Constants.OBJECTCLASS + "=*)");
> reg = context.registerService(EndpointListener.class.getName(),
> new EndpointListenerImpl(), props);
> logger.severe("REGISTRATO");
> }
> the endpointAded is correctly called for every exported service but the
> endpointRemoved is never called, even if I start/stop several time the bundle
> that registers the exported services.
> I discovered this because a service published on Zookeper via the remote
> discovery bundle is never unpublished until i stop all the Dosgi bundles even
> if I stop the service that register the service.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DOSGI-76) EndpointListener.endpointRemoved
[
https://issues.apache.org/jira/browse/DOSGI-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marco Mauri updated DOSGI-76:
-
Attachment: TopMan.diff
Patch that (IHMO) fixes this bug
> EndpointListener.endpointRemoved
>
>
> Key: DOSGI-76
> URL: https://issues.apache.org/jira/browse/DOSGI-76
> Project: CXF Distributed OSGi
> Issue Type: Bug
> Environment: Eclipse 3.5
> CXF Dosgi 1.2
>Reporter: Marco Mauri
> Attachments: TopMan.diff
>
>
> The endpointRemoved method of a registered EndpointListener is never called
> even if an exported service is unregistered.
> I've written a simple Endpoint listener:
> public class EndpointListenerImpl implements EndpointListener {
> private static final Logger logger =
> Logger.getLogger(EndpointListenerImpl.class.getName());
> @Override
> public void endpointAdded(EndpointDescription arg0, String arg1) {
> logger.severe("Added: " + arg0);
>
> }
> @Override
> public void endpointRemoved(EndpointDescription arg0, String arg1) {
> logger.severe("Removed: " + arg0);
>
> }
> }
> and registered it in my activator:
> public void start(BundleContext context) throws Exception {
> Properties props = new Properties();
> props.put(EndpointListener.ENDPOINT_LISTENER_SCOPE, "(" +
> Constants.OBJECTCLASS + "=*)");
> reg = context.registerService(EndpointListener.class.getName(),
> new EndpointListenerImpl(), props);
> logger.severe("REGISTRATO");
> }
> the endpointAded is correctly called for every exported service but the
> endpointRemoved is never called, even if I start/stop several time the bundle
> that registers the exported services.
> I discovered this because a service published on Zookeper via the remote
> discovery bundle is never unpublished until i stop all the Dosgi bundles even
> if I stop the service that register the service.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (CXF-2965) WrapperClassInInterceptor should check for null wrapperClass
WrapperClassInInterceptor should check for null wrapperClass
Key: CXF-2965
URL: https://issues.apache.org/jira/browse/CXF-2965
Project: CXF
Issue Type: Bug
Components: JAX-WS Runtime
Reporter: William Tam
Fix For: 2.3, 2.2.11
Index:
rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperClassInInterceptor.java
===
---
rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperClassInInterceptor.java
(revision 34)
+++
rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperClassInInterceptor.java
(working copy)
@@ -108,7 +108,7 @@
MessagePartInfo wrapperPart = wrappedMessageInfo.getMessagePart(0);
Class wrapperClass = wrapperPart.getTypeClass();
Object wrappedObject = lst.get(wrapperPart.getIndex());
-if (!wrapperClass.isInstance(wrappedObject)) {
+if (wrapperClass != null &&
!wrapperClass.isInstance(wrappedObject)) {
wrappedObject = null;
wrapperPart = null;
wrapperClass = null;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CXF-2965) WrapperClassInInterceptor should check for null wrapperClass
[
https://issues.apache.org/jira/browse/CXF-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
William Tam updated CXF-2965:
-
Description:
I'd suggest to add null pointer check.
{code}
Index:
rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperClassInInterceptor.java
===
---
rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperClassInInterceptor.java
(revision 34)
+++
rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperClassInInterceptor.java
(working copy)
@@ -108,7 +108,7 @@
MessagePartInfo wrapperPart = wrappedMessageInfo.getMessagePart(0);
Class wrapperClass = wrapperPart.getTypeClass();
Object wrappedObject = lst.get(wrapperPart.getIndex());
-if (!wrapperClass.isInstance(wrappedObject)) {
+if (wrapperClass != null &&
!wrapperClass.isInstance(wrappedObject)) {
wrappedObject = null;
wrapperPart = null;
wrapperClass = null;
{code}
was:
Index:
rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperClassInInterceptor.java
===
---
rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperClassInInterceptor.java
(revision 34)
+++
rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperClassInInterceptor.java
(working copy)
@@ -108,7 +108,7 @@
MessagePartInfo wrapperPart = wrappedMessageInfo.getMessagePart(0);
Class wrapperClass = wrapperPart.getTypeClass();
Object wrappedObject = lst.get(wrapperPart.getIndex());
-if (!wrapperClass.isInstance(wrappedObject)) {
+if (wrapperClass != null &&
!wrapperClass.isInstance(wrappedObject)) {
wrappedObject = null;
wrapperPart = null;
wrapperClass = null;
> WrapperClassInInterceptor should check for null wrapperClass
>
>
> Key: CXF-2965
> URL: https://issues.apache.org/jira/browse/CXF-2965
> Project: CXF
> Issue Type: Bug
> Components: JAX-WS Runtime
>Reporter: William Tam
> Fix For: 2.3, 2.2.11
>
>
> I'd suggest to add null pointer check.
> {code}
> Index:
> rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperClassInInterceptor.java
> ===
> ---
> rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperClassInInterceptor.java
> (revision 34)
> +++
> rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperClassInInterceptor.java
> (working copy)
> @@ -108,7 +108,7 @@
> MessagePartInfo wrapperPart =
> wrappedMessageInfo.getMessagePart(0);
> Class wrapperClass = wrapperPart.getTypeClass();
> Object wrappedObject = lst.get(wrapperPart.getIndex());
> -if (!wrapperClass.isInstance(wrappedObject)) {
> +if (wrapperClass != null &&
> !wrapperClass.isInstance(wrappedObject)) {
> wrappedObject = null;
> wrapperPart = null;
> wrapperClass = null;
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CXF-2961) JAXRS Web Client pre-connect errors can be better propagated
[ https://issues.apache.org/jira/browse/CXF-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Beryozkin resolved CXF-2961. --- Assignee: Sergey Beryozkin Fix Version/s: 2.2.11 Resolution: Fixed > JAXRS Web Client pre-connect errors can be better propagated > > > Key: CXF-2961 > URL: https://issues.apache.org/jira/browse/CXF-2961 > Project: CXF > Issue Type: Bug > Components: JAX-RS >Affects Versions: 2.2.10, 2.3 >Reporter: Peter Easton >Assignee: Sergey Beryozkin >Priority: Minor > Fix For: 2.3, 2.2.11 > > Attachments: patch.txt > > > HTTP client errors fall into 2 categories: > i. The connect succeeds, a non-2xx HTTP response is returned by the service. > ii. The connect does not succeed because of local HTTP client runtime issues > (bad hostname, port unavailable, unsupported method). > In the later error cases a WebApplication exceptions is returned BUT no root > cause exception is available. > A suggested patch is included. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CXF-2965) WrapperClassInInterceptor should check for null wrapperClass
[
https://issues.apache.org/jira/browse/CXF-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Willem Jiang reassigned CXF-2965:
-
Assignee: Willem Jiang
> WrapperClassInInterceptor should check for null wrapperClass
>
>
> Key: CXF-2965
> URL: https://issues.apache.org/jira/browse/CXF-2965
> Project: CXF
> Issue Type: Bug
> Components: JAX-WS Runtime
>Reporter: William Tam
>Assignee: Willem Jiang
> Fix For: 2.3, 2.2.11
>
>
> I'd suggest to add null pointer check.
> {code}
> Index:
> rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperClassInInterceptor.java
> ===
> ---
> rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperClassInInterceptor.java
> (revision 34)
> +++
> rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperClassInInterceptor.java
> (working copy)
> @@ -108,7 +108,7 @@
> MessagePartInfo wrapperPart =
> wrappedMessageInfo.getMessagePart(0);
> Class wrapperClass = wrapperPart.getTypeClass();
> Object wrappedObject = lst.get(wrapperPart.getIndex());
> -if (!wrapperClass.isInstance(wrappedObject)) {
> +if (wrapperClass != null &&
> !wrapperClass.isInstance(wrappedObject)) {
> wrappedObject = null;
> wrapperPart = null;
> wrapperClass = null;
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
