[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483722#comment-16483722 ] ASF GitHub Bot commented on CLOUDSTACK-10276: - rafaelweingartner commented on issue #2639: [CLOUDSTACK-10276] listVolumes not working when storage UUID is not a UUID URL: https://github.com/apache/cloudstack/pull/2639#issuecomment-390929227 I really do not see any other smaller/simpler solution for this issue. Moreover, it does not affect/break anything in the client side. The client is already seeing an ID, which is a UUID. The changes are only internal to ACS. I changed the type of `storageId` from `long` to `String` to avoid using that method that converts the given UUID to an internal database ID. That method is validating the input, and ignoring anything that is not an UUID. Then, I am using the UUID as the filter at `QueryManagerImpl.java`. The changed lines are only 2. The other lines are a result of a code cleanup that I did, and the code formatting I applied. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > View volumes from primary storage not working when storage UUID is not a UUID > - > > Key: CLOUDSTACK-10276 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > > When configuration a pre-setup primary storage we can enter the name-label of > the storage that is going to be used by ACS and is already set up in the > host. The problem is that we can use any String of characters there, and this > String does not need to be a UUID one. When listing volumes from a primary > storage that has such conditions, the list will return all of the volumes in > the cloud because the ad-hoc “API framework” will ignore that value as it is > not a UUID type. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483803#comment-16483803 ] ASF GitHub Bot commented on CLOUDSTACK-10276: - DaanHoogland commented on issue #2639: [CLOUDSTACK-10276] listVolumes not working when storage UUID is not a UUID URL: https://github.com/apache/cloudstack/pull/2639#issuecomment-390955253 @rafaelweingartner I am fine with merging this so far as we don't allow for manually entering a non-uuid storage id. In my understanding it doesn't. Is that correct? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > View volumes from primary storage not working when storage UUID is not a UUID > - > > Key: CLOUDSTACK-10276 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > > When configuration a pre-setup primary storage we can enter the name-label of > the storage that is going to be used by ACS and is already set up in the > host. The problem is that we can use any String of characters there, and this > String does not need to be a UUID one. When listing volumes from a primary > storage that has such conditions, the list will return all of the volumes in > the cloud because the ad-hoc “API framework” will ignore that value as it is > not a UUID type. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael Weingärtner resolved CLOUDSTACK-10276. - Resolution: Fixed Fix Version/s: 4.11.1.0 > View volumes from primary storage not working when storage UUID is not a UUID > - > > Key: CLOUDSTACK-10276 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.11.1.0 > > > When configuration a pre-setup primary storage we can enter the name-label of > the storage that is going to be used by ACS and is already set up in the > host. The problem is that we can use any String of characters there, and this > String does not need to be a UUID one. When listing volumes from a primary > storage that has such conditions, the list will return all of the volumes in > the cloud because the ad-hoc “API framework” will ignore that value as it is > not a UUID type. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483812#comment-16483812 ] ASF subversion and git services commented on CLOUDSTACK-10276: -- Commit 8b09620d777805bdbb59255ef722e0a6ddbb85b8 in cloudstack's branch refs/heads/master from [~rafaelweingartner] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=8b09620 ] CLOUDSTACK-10276: listVolumes not working when storage UUID is not a UUID (#2639) When configuring a pre-setup primary storage we can enter the name-label of the storage that is going to be used by ACS and is already set up in the host. The problem is that we can use any String of characters there, and this String does not need to be a UUID. When listing volumes from a primary storage that has such conditions, the list will return all of the volumes in the cloud because the “API framework” will ignore that value as it is not a UUID type. > View volumes from primary storage not working when storage UUID is not a UUID > - > > Key: CLOUDSTACK-10276 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > > When configuration a pre-setup primary storage we can enter the name-label of > the storage that is going to be used by ACS and is already set up in the > host. The problem is that we can use any String of characters there, and this > String does not need to be a UUID one. When listing volumes from a primary > storage that has such conditions, the list will return all of the volumes in > the cloud because the ad-hoc “API framework” will ignore that value as it is > not a UUID type. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10276) View volumes from primary storage not working when storage UUID is not a UUID
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483810#comment-16483810 ] ASF subversion and git services commented on CLOUDSTACK-10276: -- Commit 8b09620d777805bdbb59255ef722e0a6ddbb85b8 in cloudstack's branch refs/heads/4.11 from [~rafaelweingartner] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=8b09620 ] CLOUDSTACK-10276: listVolumes not working when storage UUID is not a UUID (#2639) When configuring a pre-setup primary storage we can enter the name-label of the storage that is going to be used by ACS and is already set up in the host. The problem is that we can use any String of characters there, and this String does not need to be a UUID. When listing volumes from a primary storage that has such conditions, the list will return all of the volumes in the cloud because the “API framework” will ignore that value as it is not a UUID type. > View volumes from primary storage not working when storage UUID is not a UUID > - > > Key: CLOUDSTACK-10276 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > > When configuration a pre-setup primary storage we can enter the name-label of > the storage that is going to be used by ACS and is already set up in the > host. The problem is that we can use any String of characters there, and this > String does not need to be a UUID one. When listing volumes from a primary > storage that has such conditions, the list will return all of the volumes in > the cloud because the ad-hoc “API framework” will ignore that value as it is > not a UUID type. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
