[PHP-DEV] PHP 4 Bug Summary Report
PHP 4 Bug Database summary - http://bugs.php.net Num Status Summary (634 total including feature requests) ===[*Directory/Filesystem functions] 40661 Open cwd is reset when shutdown handler runs ===[*Programming Data Structures]= 40496 Assigned Test bug35239.phpt still fails ===[Apache2 related]== 38670 Open Whole 4.4.x branch has problem with open_basedir option nested from Apache2 41473 Open PHP locks prefork apache2 childs ===[Arrays related]=== 31114 Assigned foreach modify array (works with PHP 5.1) 37451 Open array_multisort fails to trigger by val copy of data (works in PHP 5.1) 39764 Suspended array_key_exists inconsistent behavior 41372 Open Internal pointer of source array resets during array copying ===[CGI related]== 38476 Open PATH_INFO, ORIG_PATH_INFO, and PHP_SELF not set in Lighttpd1.4.11/PHP4.4.3 ===[Class/Object related]= 39254 Open Refcount error with static variables and object references (PHP4 only) 39681 Open this assignment outside class breaks static function call (PHP4 only) ===[COM related]== 37899 Assigned [PATCH] php_char_to _OLECHAR copies junk bytes ===[Compile Failure]== 41478 Feedback undefined reference to zend_strtod ===[Documentation problem] 29045 Suspended gzopen for URL 36663 Open unexpected difference between "zlib.output_compression" and "ob_gzhandler" 37009 Open I got wrong letter Å and å ! 37901 Verified Unable to find the wrapper "file" 38965 Assigned mssql_connect doesn't use TCP 1433 for external SQL Server 39874 Open gztell returns incorrect file pointer number 39894 Open IniFilePath and PHPRC 40586 Open _ENV vars get espcaped when magic_quotes_gpc is on ===[DOM XML related]== 41452 Open possible memory leak in DomNode->first_child ===[EXIF related]= 39617 Assigned Erroneously uses the GPS version tag to determine byte order of GPS fields ===[FDF related]== 34811 Assigned fdf_get_value max size ===[Feature/Change Request]=== 3066 Open Parameter for dns functions to select different DNS 3799 Suspended default_charset brings small incompatibility 3830 Open Function to timeout/break off a function 5007 Analyzed enable no-resolve mode for here docs 5169 Open Missing recursive behavior 5311 Analyzed implement checkdnsrr() and getmxrr() on windows 5575 Open open_basedir to ~ 5601 Analyzed @function() should not turn of error reporting for critical errors 5804 Open parser error if any spaces follow indentifier in with here doc syntax 5883 Assigned --enable-trans-sid modification request 5954 Open Informix can't reliably figure if a text result column is NULL 5975 Open version of strip_tags() that specifies tags to strip (instead of tags to keep) 6118 Open Can not supress runtime warnings on foreach 6268 Open ternary op return only by value 6399 Open checkdate should be able to validate a time as well as a date (timestamp) 6427 Open func_get_arg() does not support references 6503 Open no support for multiple resultset query? 6512 Analyzed sort() Does not sort stings as expected 6574 Open SMTP functions via IMAP c-client library 6680 Open regexps (ereg*) ignores locale settings 6911 Open Problem with array_merge(_recursive) 6927 Suspended 6932 Open Filesize / File_exists and include_path 6993 Open uninstalling is a pain in the ass 7006 Open preg_replace ( string pattern, array replacement, string subject ); 7028 Analyzed xml=shared and wddx do not work together 7132 Assigned fsockopen doesn't report dns lookup failure 7398 Open Stored procedure error return values not passed through 7507 Open Better ODBC error reporting/fetching 7541 Open please consider also support HPUX shl_* 7553 Open RFC: Uplevel Block structure 7559 Open zend_hash_get_current_key_ex returning persistent strings 7578 Open next() and current() do not return referenceing arrays 7808 Open variable value triggerd by function 7923 Analyzed htmlentities doesn't work for ISO 8859-2 7930 Open List() constructor reference assignment 8100 Assigned extract(), extra feature 8108 Analyzed implement trans-sid as output handler
Re: [PHP-DEV] Re: Merging patches to HEAD [ was: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard html.c html.h /ext/standard/tests/strings htmlentities18.phpt ]
Hi all, On 5/26/07, Ilia Alshanetsky <[EMAIL PROTECTED]> wrote: On 26-May-07, at 6:51 AM, Edin Kadribasic wrote: > Ilia, I would really like to know why you are not merging patches > to head? Unfortunately I don't have as much time to spend on PHP as I'd like and I focus my attention on the aspects of PHP I use and can tests using the dev environments I have. I do not have a ready PHP6 environment and do not have time to test thing with php6 code, with which I do not have as much familiarity. Rather then making commits that may break the builds or spending hours resolving conflicts I focus my attention on PHP5 where fixes and improvements have tangible benefits to users. That said the commits are all public and if someone who is more familiar with php6 code then I can merge them, it would be great. Ilia has a good point here. All commits are public and he already said numerous times that he cannot merge his fixes to all branches (no matter the reasons :). For the record, for all extensions I maintain or co maintain, I have no problem to have to merge his fixes (I do it for zip, it has 4 branches!). I prefer to have fix for the stable tree shortly instead of waiting weeks. Maybe we can find other persons (I saw Tony's merge yesterday) to do it for other parts of PHP. It should not be a big problem. --Pierre -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: Merging patches to HEAD [ was: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard html.c html.h /ext/standard/tests/strings htmlentities18.phpt ]
Hello Pierre, Monday, May 28, 2007, 11:47:22 AM, you wrote: > Hi all, > On 5/26/07, Ilia Alshanetsky <[EMAIL PROTECTED]> wrote: >> >> On 26-May-07, at 6:51 AM, Edin Kadribasic wrote: >> >> > Ilia, I would really like to know why you are not merging patches >> > to head? >> >> Unfortunately I don't have as much time to spend on PHP as I'd like >> and I focus my attention on the aspects of PHP I use and can tests >> using the dev environments I have. I do not have a ready PHP6 >> environment and do not have time to test thing with php6 code, with >> which I do not have as much familiarity. Rather then making commits >> that may break the builds or spending hours resolving conflicts I >> focus my attention on PHP5 where fixes and improvements have tangible >> benefits to users. >> >> That said the commits are all public and if someone who is more >> familiar with php6 code then I can merge them, it would be great. > Ilia has a good point here. All commits are public and he already said > numerous times that he cannot merge his fixes to all branches (no > matter the reasons :). What? His fingers get burned or he just likes to screw all of us who already put an endless amount of time into head? Not merging to active trees means destroying PHP. There is nothing more to argue here. > For the record, for all extensions I maintain or co maintain, I have > no problem to have to merge his fixes (I do it for zip, it has 4 > branches!). I prefer to have fix for the stable tree shortly instead > of waiting weeks. Maybe we can find other persons (I saw Tony's merge > yesterday) to do it for other parts of PHP. It should not be a big > problem. That won't help unless you are willing to be his secretary and merge everything he does. Becuase otherwise stuff will get lost. No matter what. And that is very bad for PHP. Best regards, Marcus -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] PHP 6 Bug Summary Report
PHP 6 Bug Database summary - http://bugs.php.net Num Status Summary (45 total including feature requests) ===[*General Issues]== 26771 Suspended register_tick_funtions crash under threaded webservers 27372 Verified parse error loading browscap.ini at apache startup (new parser required) ===[Arrays related]=== 35277 Suspended incorrect recursion detection ===[Class/Object related]= 33595 Assigned recursive references leak memory ===[Compile Failure]== 34089 Open Configure fails build test for libxml2 ===[Feature/Change Request]=== 20377 Open php_admin_value affects _only_ .htaccess 27618 Open curl_multi_info_read does not appear to work 29479 Suspended changing current process name 34211 Open PDO_OCI: Allow for data type "TIMESTAMP(0) WITH LOCAL TIME ZONE" 34252 Open Base functions extension and refactoring 34527 Open trim functions extension 34775 Open parse_url() provide better error description on failure 34882 Open Unable to access *original* posted variable name with dot in 35309 Open Database connection pooling 37081 Open Make the include-errors mention faulty permissions 37380 Open DOMDocument->createAttribute[NS] can't set value 37546 Open DOMDocumentFragment->appendXML namespace support 37796 Open t_is_not_identical for <> ? 37814 Open Php shoul have class friends 38622 Open Proposed new security scheme for shared hosting (safe mode substitute) 38946 Open pecl/docblock should be merged into ext/tokenizer 40013 Open php_uname() doesnt return nodename 40499 Open filter sapi does not register any highlightning filter 40713 Open set_magic_quotes_runtime(0) causes Fatal Error 41019 Assigned auto update feature for FastCGI for IIS 41119 Open range() function behavior different on PHP6 and PHP5 41450 Open New operator feature request ===[Filesystem function related]== 27792 Assigned Functions fail on large files (filesize,is_file,is_dir) 41516 Open fgets() returns a line of text when length parameter is <= 0 ===[GD related]=== 34670 Assigned imageTTFText for Indian scripts (Devanagari) ===[ODBC related]= 39756 Assigned Crashes in fetching resultsets with LONG ASCII columns from MaxDB ===[OpenSSL related]== 25614 Suspended openssl_pkey_get_public() fails when given a private key ===[Other web server]= 26495 Suspended Using WebSite Pro 2.5 with ISAPI, cookies are not working ===[PDO related]== 35368 Suspended PDO query does not work properly with serialize 39171 Assigned pdo_mysql configure script sets empty default socket ===[Program Execution] 39992 Open proc_terminate() leaves children of child running ===[Scripting Engine problem]= 29687 Open By-reference passed value inside foreach() is no longer working 33487 Assigned Memory allocated for objects created in object methods is not released 39216 Assigned call_user_func and friends don't accept array($this, "func") callback anymore ===[Session related]== 32330 Open session_destroy, "Failed to initialize storage module", custom session handler ===[SimpleXML related] 37076 Assigned SimpleXML ignores .= ===[Unknown/Other Function]=== 39710 Open getprotobyname is not thread-safe 41482 Open get_declared_classes() returns non-existing classes ===[XSLT related]= 38218 Assigned php:functionString tries to access objects with their names in lowercase ===[Zlib Related]= 30153 Suspended FATAL erealloc() error when using gzinflate() Assigned bugs: (reminders sent) dmitry 33595: recursive references leak memory dmitry 41019: auto update feature for FastCGI for IIS dmitry 33487: Memory allocated for objects created in object methods is not released wez 27792: Functions fail on large files (filesize,is_file,is_dir) wez 39171: pdo_mysql configure script sets empty default socket pajoye 34670: imageTTFText for Indian scripts (Devanagari)
Re: [PHP-DEV] Re: Merging patches to HEAD [ was: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard html.c html.h /ext/standard/tests/strings htmlentities18.phpt ]
On 5/28/07, Marcus Boerger <[EMAIL PROTECTED]> wrote: That won't help unless you are willing to be his secretary and merge everything he does. It is a voluntary work. I'm very happy to see him (or anybody else) fixing issues within days and I will not do or say anything to stop them. If I have to adapt a patch for a given branch, that's fine with me, I don't feel like being a secretary. Becuase otherwise stuff will get lost. No matter what. And that is very bad for PHP. It does help. If you have doubts, see all his zip or gd commit. Tony has merged his recent openssl commits as well. If you don't like Ilia to fix issues in your extensions and only in the stable branche, ask him to send you patches and adapt/merge them for the required branches. --Pierre -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] CVS Account Request: richyabbey
Email account. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] TSRM changes broke windows compile
On Fri, 25 May 2007, Stanislav Malyshev wrote: > It's great to have a benchmark, thanks! > > > The standard of deviation was rather high though. Over 10 runs on each > > the averages were: > > > > time: 646 req/sec > > sapi: 659 req/sec > > So it's 2%, not that big a deal... I think it is... as all the little bits add up to make things quicker. regards, Derick -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] CVS Account Request: richyabbey
Hello Richard, What is wrong witho your yahoo.pl? -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] RFC: adding a callback for determining if a method is static
Hello,
This weekend I've been building an Objective-C runtime bridge for PHP.
This is somewhat like the COM extension in that it is possible to
dynamically interrogate the Objective-C runtime to determine all the
interfaces (known as protocols) and classes and map those into PHP.
(it's also possible to go the other way, but that's not relevant to my
topic here).
Now, Objective-C allows one to enumerate static methods defined on
interfaces, but not in classes. Furthermore, there is something
vaguely akin to our __call mechanism that allows classes and instances
to magically handle methods without explicitly defining them in the
class description.
What I'd like to be able to do is this:
$NSApp = NSApplication::sharedApplication();
but the sharedApplication() static method doesn't appear in the
enumerated list of methods in the runtime, so I can't simply add it to
my function table when I register the NSApplication class.
So what I need to do is this to work around the issue:
$NSApp = NSApplication::__staticInvoke('sharedApplication');
This can ask the runtime if "sharedApplication" is a static method and
invoke it appropriately.
This wouldn't be especially bad if it was only for one or two classes
that were no often used, but it crops up a lot.
I'd like to see an additional callback in the zend_class_entry that
operates similarly to the existing get_method callback, but that takes
the zend_class_entry instead of the object pointer as its parameter.
That would enable more natural syntax for this application, and likely
other bridging extensions too.
Thoughts?
--Wez.
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] RFC: adding a callback for determining if a method is static
Hello Wez,
Monday, May 28, 2007, 5:33:37 PM, you wrote:
> Hello,
> This weekend I've been building an Objective-C runtime bridge for PHP.
> This is somewhat like the COM extension in that it is possible to
> dynamically interrogate the Objective-C runtime to determine all the
> interfaces (known as protocols) and classes and map those into PHP.
> (it's also possible to go the other way, but that's not relevant to my
> topic here).
> Now, Objective-C allows one to enumerate static methods defined on
> interfaces, but not in classes. Furthermore, there is something
> vaguely akin to our __call mechanism that allows classes and instances
> to magically handle methods without explicitly defining them in the
> class description.
> What I'd like to be able to do is this:
> $NSApp = NSApplication::sharedApplication();
> but the sharedApplication() static method doesn't appear in the
> enumerated list of methods in the runtime, so I can't simply add it to
> my function table when I register the NSApplication class.
> So what I need to do is this to work around the issue:
> $NSApp = NSApplication::__staticInvoke('sharedApplication');
> This can ask the runtime if "sharedApplication" is a static method and
> invoke it appropriately.
> This wouldn't be especially bad if it was only for one or two classes
> that were no often used, but it crops up a lot.
> I'd like to see an additional callback in the zend_class_entry that
> operates similarly to the existing get_method callback, but that takes
> the zend_class_entry instead of the object pointer as its parameter.
> That would enable more natural syntax for this application, and likely
> other bridging extensions too.
> Thoughts?
yes :-)
Along with __call and what you propose, we're missing:
__method_exists(string $name, [bool $static = false]);
Best regards,
Marcus
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] better changeset tracking
As a fellow busy person, I completely understand this situation. I also recognize that we need to find a way to guarantee that patches don't slip through the cracks and don't get lost. I think we could do with investing a little bit of time into finding a way to automatically review commits to see if they have been merged to all relevant branches. For this to be viable, we should probably adopt the practice of explicitly referencing a bug number in all commits (could be enforced by the commit hook); we can then analyze the commit messages to make sure that commits referencing a particular bug number have a corresponding set of commits in the branches, and vice versa. Once we have that data, we could have job that periodically (daily) reviews the activity per bug report and sends an email reminder about reports that have missing merge activity for longer than a week. --Wez. PS: We could also consider posting links to commit URLs to the associated bug report; this is a feature I really value in our subversion/trac repositories at OmniTI. On 5/26/07, Ilia Alshanetsky <[EMAIL PROTECTED]> wrote: On 26-May-07, at 6:51 AM, Edin Kadribasic wrote: > Ilia, I would really like to know why you are not merging patches > to head? Unfortunately I don't have as much time to spend on PHP as I'd like and I focus my attention on the aspects of PHP I use and can tests using the dev environments I have. I do not have a ready PHP6 environment and do not have time to test thing with php6 code, with which I do not have as much familiarity. Rather then making commits that may break the builds or spending hours resolving conflicts I focus my attention on PHP5 where fixes and improvements have tangible benefits to users. That said the commits are all public and if someone who is more familiar with php6 code then I can merge them, it would be great. Ilia Alshanetsky -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] better changeset tracking
Sorry for my initial offlist reply. My evil gmail does not "reply-all" by default :P Here is an answer from Wez to my reply: On 5/28/07, Pierre <[EMAIL PROTECTED]> wrote: I'm all for this solution. I asked to do it a couple of years ago (and a couple of times since). All commits besides CS or docs (inline) should have a bug report. It is then much easier to track the changes, the discussions and, as you said here, be sure that all active branches have it. To be effective, we'd need to require that all commits reference a bug report, otherwise one could forget to reference it and we'd "lose" the commit. We can create CS and Doc reports to allow those to be made without opening a report for each one. What I would like to provide is a way to get the patches related to an issue from our bug tracker. I'm not sure what's the best way to do it but at least all related commits can be associated. A cron job can fetch the commit mails and add them to the respective issues. Or can we have a special mail sent to a [EMAIL PROTECTED] with the complete patch and commit message? Yeah, I'd love that to work too. I think mailing into the bugs box would be the way to make it work. --Wez. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] better changeset tracking
Wez Furlong wrote: Once we have that data, we could have job that periodically (daily) reviews the activity per bug report and sends an email reminder about reports that have missing merge activity for longer than a week. Wouldnt we then also have to have some flag on the bug to make it clear what branches of PHP are affected? Otherwise we would have a fair number of false positives for patches that are fixes that are only required for a specific branch? regards, Lukas -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] late static binding
parties involved could help clear up for me. Basically, I am wondering if anybody has tossed around the idea of having a scope of child::, just like Well, this exactly name makes little sense, since class has only one self and one parent, but can have many children, so child:: does not uniquely identify the context. However, the idea of having dynamic scope that refers to the class which was mentioned during the static call was indeed raised a number of times. The problem there is that since currently the engine does not preserve that class scope, it is not accessible inside the static call. My second question on this topic would be how hard would it be to create a child scope in the Zend Engine? Since I am not a very experienced C I don't really understand - what is "child scope"? programmer, this may be a naive question, but if Zend is smart enough to know who the inherited class object is, could it be much more difficult to know who did the inheriting? Yes, it could and it is. There's an unique link from child to parent, but there's no any link from parent to child, neither this link is possible since parent can have many children which could come into existence at any time during the lifecycle of the script. -- Stanislav Malyshev, Zend Products Engineer [EMAIL PROTECTED] http://www.zend.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Merge GD tests update to 5.2
Hi, HEAD (php6) supports now external GD libraries for almost all tests. It is a first step to support both bundled library and external libraries with all features enabled (like imagefilter, antialiasing, etc.). I would like to merge the tests change in 5.2. It makes my life easier to maintain both libraries and keep them 100% compatible, is there any objection? --Pierre -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Re: Merge GD tests update to 5.2
Pierre, That sounds like a great idea, my only request is that this change be done after then 5.2.3 release. On 28-May-07, at 4:23 PM, Pierre wrote: Hi, HEAD (php6) supports now external GD libraries for almost all tests. It is a first step to support both bundled library and external libraries with all features enabled (like imagefilter, antialiasing, etc.). I would like to merge the tests change in 5.2. It makes my life easier to maintain both libraries and keep them 100% compatible, is there any objection? --Pierre Ilia Alshanetsky -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Merge GD tests update to 5.2
On 5/28/07, Pierre <[EMAIL PROTECTED]> wrote: Hi, HEAD (php6) supports now external GD libraries for almost all tests. It is a first step to support both bundled library and external libraries with all features enabled (like imagefilter, antialiasing, etc.). I would like to merge the tests change in 5.2. It makes my life easier to maintain both libraries and keep them 100% compatible, is there any objection? --Pierre -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php I'm all for it, good work -- David Coallier, Founder & Software Architect, Agora Production (http://agoraproduction.com) 51.42.06.70.18 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] When is PHP 6 release scheduled?
Hi, Are there a dates scheduled for the public releases of PHP 6 (beta, rc, stable)? Thank you, Arnold PS. I've searched the mailing lists, but couldn't find an answer. If the question is asked already, my apologies. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] better changeset tracking
hi folks, On Monday 28 May 2007 17:56:54 Wez Furlong wrote: > I think we could do with investing a little bit of time into finding a > way to automatically review commits to see if they have been merged to > all relevant branches. For this to be viable, we should probably > adopt the practice of explicitly referencing a bug number in all > commits (could be enforced by the commit hook); we can then analyze > the commit messages to make sure that commits referencing a particular > bug number have a corresponding set of commits in the branches, and > vice versa. this would be of immense, immense help to 3rd party distributors of php, such as debian (and redhat, and others, i'm sure). currently it's a rather trying experience to go digging through commit histories for something that was fixed "in the latest cvs snapshot" at some point in time. i think i posted a feature request along these lines at some time in the past... :) sean signature.asc Description: This is a digitally signed message part.
Re: [PHP-DEV] When is PHP 6 release scheduled?
Hello, No such schedule exists yet. Edin Arnold Daniels wrote: > Hi, > > Are there a dates scheduled for the public releases of PHP 6 (beta, rc, > stable)? > > Thank you, > Arnold > > PS. I've searched the mailing lists, but couldn't find an answer. If the > question is asked already, my apologies. > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] When is PHP 6 release scheduled?
On 5/28/07, Edin Kadribasic <[EMAIL PROTECTED]> wrote: Hello, No such schedule exists yet. Edin Arnold Daniels wrote: > Hi, > > Are there a dates scheduled for the public releases of PHP 6 (beta, rc, > stable)? > > Thank you, > Arnold > > PS. I've searched the mailing lists, but couldn't find an answer. If the > question is asked already, my apologies. > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php Look at this: http://php.net/~scoates/unicode/render_func_data.php Try to find around when PHP6's development started and add the same amount of time since some of the most present contributors have less time and some others do have some, let's say taht with testing, there's about half to be done (according to lcov - even if it says 60%) -- David Coallier -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] better changeset tracking
Hi Wez, I think the key is in forcing every commit to reference a ticket; that way you can't "lose" a changeset by forgetting to put a bug number in there. Going back on-list... It's a good idea in principle, but I can foresee some problems with it. Many (most?) of the unnumbered fixes Ilia's been making have been alterations to internal string or memory function calls. Generally those are either performance or security changes, replicated throughout the code base and starting with a single 'blast' aimed at upgrading everything, followed by lots of smaller catch-up fixes over the next several weeks. This kind of thing isn't really worthy of a bug report, unless you have an entirely new concept of what a bug might be and allow for change types like 'maintenance', 'security' or 'performance' via the bug database somehow. The nearest we've come to that recently is MOPB - everyone marked those fixes as such - and occasionally coverity. If the bug db allows it it might make sense to put an initial function change as a 'maintenance' report with some explanation and a number, e.g.: helly Sat Feb 24 18:20:46 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/main snprintf.c snprintf.h Log: - Add [v]slprintf to overcome the returnvalues issue of snprintf would get a fuller explanation on the report, and every subsequent "snprintf() -> slprintf()" commit would reference that maintenance report number. Fine, but what to do about "malloc() -> pemalloc()"? Would all 'maintenance' fixes require a test script? Wouldn't the need to check for a maintenance number put devs off making a simple one-line fix? Branch-specific fixes are generally (but not always) marked as such at present. People tend to mention it in the 5_2 branch but not in 4_4. - Steph -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
