Re: [Intel-wired-lan] [PATCH iwl-next v5 1/2] ixgbe: Refactor overtemp event handling

2023-12-29 Thread Mekala, SunithaX D
> Currently ixgbe driver is notified of overheating events
> via internal IXGBE_ERR_OVERTEMP error code.
>
> Change the approach for handle_lasi() to use freshly introduced
> is_overtemp function parameter which set when such event occurs.
> Change check_overtemp() to bool and return true if overtemp
> event occurs.
>
> Reviewed-by: Przemek Kitszel 
> Signed-off-by: Jedrzej Jagielski 
> ---
> v2: change aproach to use additional function parameter to notify when 
> overheat
> v4: change check_overtemp to bool
> v5: adress Simon's comments
>
> https://lore.kernel.org/netdev/20231217093800.gx6...@kernel.org/
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 16 +++-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c  | 21 +-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h  |  2 +-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_type.h |  4 +-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 41 +++
>  5 files changed, 43 insertions(+), 41 deletions(-)
>
Tested-by: Sunitha Mekala  (A Contingent worker at 
Intel)


Re: [Intel-wired-lan] [PATCH iwl-next v5 2/2] ixgbe: Refactor returning internal error codes

2023-12-29 Thread Mekala, SunithaX D
> Change returning codes to the kernel ones instead of
> the internal ones for the entire ixgbe driver.
>
> Reviewed-by: Jacob Keller 
> Reviewed-by: Przemek Kitszel 
> Reviewed-by: Simon Horman 
> Signed-off-by: Jedrzej Jagielski 
> ---
> v3: do not use ENOSYS; rebase
> ---
>  .../net/ethernet/intel/ixgbe/ixgbe_82598.c|  36 ++---
>  .../net/ethernet/intel/ixgbe/ixgbe_82599.c|  61 
>  .../net/ethernet/intel/ixgbe/ixgbe_common.c   | 145 --
>  .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c  |   2 +-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |  26 ++--
>  drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.c  |  34 ++--
>  drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h  |   1 -
>  drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c  |  84 +-
>  .../net/ethernet/intel/ixgbe/ixgbe_sriov.c|   2 +-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_type.h |  39 -
>  drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c |  44 +++---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 109 ++---
>  12 files changed, 266 insertions(+), 317 deletions(-)
>
Tested-by: Sunitha Mekala  (A Contingent worker at 
Intel)