Re: [Intel-wired-lan] [PATCH iwl-next] ice: Fix SRIOV LAG disable on non-compliant aggreagate
On Fri, Oct 06, 2023 at 02:02:11PM -0700, Dave Ertman wrote:
> If an attribute of an aggregate interface disqualifies it from supporting
> SRIOV, the driver will unwind the SRIOV support. Currently the driver is
> clearing the feature bit for all interfaces in the aggregate, but this is
> not allowing the other interfaces to unwind successfully on driver unload.
>
> Only clear the feature bit for the interface that is currently unwinding.
>
> Fixes: bf65da2eb279 ("ice: enforce interface eligibility and add messaging
> for SRIOV LAG")
> Signed-off-by: Dave Ertman
> ---
> drivers/net/ethernet/intel/ice/ice_lag.c | 11 +++
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_lag.c
> b/drivers/net/ethernet/intel/ice/ice_lag.c
> index 2c96d1883e19..c9071228b1ea 100644
> --- a/drivers/net/ethernet/intel/ice/ice_lag.c
> +++ b/drivers/net/ethernet/intel/ice/ice_lag.c
> @@ -1513,17 +1513,12 @@ static void ice_lag_chk_disabled_bond(struct ice_lag
> *lag, void *ptr)
> */
> static void ice_lag_disable_sriov_bond(struct ice_lag *lag)
> {
> - struct ice_lag_netdev_list *entry;
> struct ice_netdev_priv *np;
> - struct net_device *netdev;
> struct ice_pf *pf;
>
> - list_for_each_entry(entry, lag->netdev_head, node) {
> - netdev = entry->netdev;
> - np = netdev_priv(netdev);
> - pf = np->vsi->back;
> -
> - ice_clear_feature_support(pf, ICE_F_SRIOV_LAG);
> + np = netdev_priv(lag->netdev);
> + pf = np->vsi->back;
> + ice_clear_feature_support(pf, ICE_F_SRIOV_LAG);
> }
> }
Hi Dave,
unfortunately applying this patch results in a build failure.
--
pw-bot: changes-requested
___
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: fix over-shifted variable
> -Original Message-
> From: Intel-wired-lan On Behalf Of Jesse
> Brandeburg
> Sent: Tuesday, October 3, 2023 11:01 AM
> To: intel-wired-...@lists.osuosl.org
> Cc: net...@vger.kernel.org; Brandeburg, Jesse ;
> sta...@vger.kernel.org; Kitszel, Przemyslaw
> Subject: [Intel-wired-lan] [PATCH iwl-net v1] ice: fix over-shifted variable
>
> Since the introduction of the ice driver the code has been
> double-shifting the RSS enabling field, because the define already has
> shifts in it and can't have the regular pattern of "a << shiftval &
> mask" applied.
>
> Most places in the code got it right, but one line was still wrong. Fix
> this one location for easy backports to stable. An in-progress patch
> fixes the defines to "standard" and will be applied as part of the
> regular -next process sometime after this one.
>
> Fixes: d76a60ba7afb ("ice: Add support for VLANs and offloads")
> Reviewed-by: Przemek Kitszel
> CC: sta...@vger.kernel.org
> Signed-off-by: Jesse Brandeburg
> ---
> drivers/net/ethernet/intel/ice/ice_lib.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Tested-by: Pucha Himasekhar Reddy (A
Contingent worker at Intel)
___
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: Fix safe mode when DDP is missing
> -Original Message-
> From: Intel-wired-lan On Behalf Of Jan
> Sokolowski
> Sent: Tuesday, October 3, 2023 4:48 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: Pacuszka, MateuszX ; Sokolowski, Jan
>
> Subject: [Intel-wired-lan] [PATCH iwl-net v1] ice: Fix safe mode when DDP is
> missing
>
> From: Mateusz Pacuszka
>
> One thing is broken in the safe mode, that is
> ice_deinit_features() is being executed even
> that ice_init_features() was not causing stack
> trace during pci_unregister_driver().
>
> Add check on the top of the function.
>
> Fixes: 5b246e533d01 ("ice: split probe into smaller functions")
> Signed-off-by: Mateusz Pacuszka
> Signed-off-by: Jan Sokolowski
> ---
> drivers/net/ethernet/intel/ice/ice_main.c | 3 +++
> 1 file changed, 3 insertions(+)
>
Tested-by: Pucha Himasekhar Reddy (A
Contingent worker at Intel)
___
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
