Re: [Intel-gfx] [PATCH] drm/i915: Adjustable Render Power State policies
Test patch on Harris Beach, max frequency: 1100 lowest frequency : 200 For doom3, When waking from idle, boost the render frequency to RP1(200). At every upclock request, increase to halfway between the current frequency and maximum. attached the frequency changing of doom3. Applied the patch, performance improved, but consumed more power, except smokin-guns workload, performance improved and consumed less power. workloads with patch without patch with patch VS without patch Average watt Watt-hour Fps Time Average watt Watt-hour Fps Time Average watt FPS idle 12.5 0.7 4′ 11.7 0.7 4′106.84% doom333.3 1.2 35.1 2’22” 33.1 1.2 34.2 2'21" 100.60%102.63% openarena31.5 2.2 28.8 4’32” 30.5 2.2 27.9 4'25" 103.28%103.23% smokin-guns 27.2 1.2 75.8 2'50" 28.8 1.2 72.8 2'50" 94.44% 104.12% urbanterror 25.7 257.8 5’4” 25.3 2 55.9 4'57" 101.58%103.40% > -Original Message- > From: Jesse Barnes [mailto:jbar...@virtuousgeek.org] > Sent: Saturday, July 27, 2013 6:33 AM > To: Chris Wilson > Cc: intel-gfx@lists.freedesktop.org; Zhang, Ouping; Meng, Mengmeng > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Adjustable Render Power State > policies > > Cool... I'd like to see if Ouping and Mengmeng can work together to get power > & power numbers across a bunch of workloads for these policies. > > Ouping & Mengmeng, can you run your usual battery of stuff against each of > these settings and report back the results? > > Thanks, > Jesse > > On Fri, 26 Jul 2013 23:24:11 +0100 > Chris Wilson wrote: > > > As a complement to the suggestions put forward by Jesse in > > > > drm/i915: "Scotty, I need more power!" > > (1372436290-3297-1-git-send-email-jbar...@virtuousgeek.org) > > > > and > > > > drm/i915: boost GPU and CPU freq when leaving idle > > (1372438472-3233-1-git-send-email-jbar...@virtuousgeek.org) > > > > we also have the ability to fine tune how we respond to the GPU's > > requests for more power. > > > > This patch introduces the i915.rps_policy module parameter that > > adjusts how we respond to the upclock request: > > > > 1 - Powersaving (current implementation) > > Increase the frequency by one bin on every upclock request. > > > > 2 - Conservative (new default) > > When waking from idle, boost the render frequency to the > > default render frequency (RP1) > > > > 3 - Ondemand > > At every upclock request, increase to halfway between the current > > frequency and maximum. This should give rapid upclocking similar > > to tcp window scaling. > > > > 4 - Performance > > Every time the GPU wants more power, give it everything we have. > > > > Signed-off-by: Chris Wilson > > --- > > drivers/gpu/drm/i915/i915_drv.c | 8 +++ > > drivers/gpu/drm/i915/i915_drv.h | 2 ++ > > drivers/gpu/drm/i915/i915_irq.c | 46 > > + > > drivers/gpu/drm/i915/intel_pm.c | 1 + > > 4 files changed, 44 insertions(+), 13 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_drv.c > > b/drivers/gpu/drm/i915/i915_drv.c index 1d8cedc..7ad80f4 100644 > > --- a/drivers/gpu/drm/i915/i915_drv.c > > +++ b/drivers/gpu/drm/i915/i915_drv.c > > @@ -72,6 +72,14 @@ MODULE_PARM_DESC(i915_enable_rc6, > > "For example, 3 would enable rc6 and deep rc6, and 7 would > > enable > everything. " > > "default: -1 (use per-chip default)"); > > > > +int i915_rps_policy __read_mostly = 1; module_param_named(rps_policy, > > +i915_rps_policy, int, 0600); MODULE_PARM_DESC(rps_policy, > > + "Specify a policy to use to respond to requests to change the > > render > clock. " > > + "Different levels of uplocking agressiveness can be selected" > > + "(0 = Powersaving, slowly uplock; 1 = Conservative, when the gpu > wakes from idle go straight to RP1/RPe (recommended minimum active GPU > frequency); 2 = Ondemand, rapidly increase frequency whilst upclocking; 4 = > Performance, always upclock to maximum frequency). " > > + &qu
Re: [Intel-gfx] [PATCH] drm/i915: Adjustable Render Power State policies
for the attachment, the first line is max frequency: 1100, and the second line is lowest frequency : 200 we captured current frequency every one second during workloads. > -Original Message- > From: Zhang, Ouping > Sent: Thursday, August 01, 2013 1:16 PM > To: 'Jesse Barnes'; Chris Wilson > Cc: intel-gfx@lists.freedesktop.org; Meng, Mengmeng; Jin, Gordon > Subject: RE: [Intel-gfx] [PATCH] drm/i915: Adjustable Render Power State > policies > > Test patch on Harris Beach, > max frequency: 1100 > lowest frequency : 200 > > For doom3, When waking from idle, boost the render frequency to RP1(200). At > every upclock request, increase to halfway between the current frequency and > maximum. attached the frequency changing of doom3. > Applied the patch, performance improved, but consumed more power, except > smokin-guns workload, performance improved and consumed less power. > > workloads with patch without > patch with patch VS without patch > Average watt Watt-hour Fps Time Average watt > Watt-hour Fps Time Average watt FPS > idle 12.5 0.7 4′ 11.7 > 0.7 4′106.84% > doom3 33.3 1.2 35.1 2’22” 33.1 > 1.2 34.2 2'21" 100.60%102.63% > openarena 31.5 2.2 28.8 4’32” 30.5 > 2.2 27.9 4'25" 103.28%103.23% > smokin-guns27.2 1.2 75.8 2'50" 28.8 > 1.2 72.8 2'50" 94.44% 104.12% > urbanterror25.7 257.8 5’4” 25.3 > 2 55.9 4'57" 101.58%103.40% > > > > -Original Message- > > From: Jesse Barnes [mailto:jbar...@virtuousgeek.org] > > Sent: Saturday, July 27, 2013 6:33 AM > > To: Chris Wilson > > Cc: intel-gfx@lists.freedesktop.org; Zhang, Ouping; Meng, Mengmeng > > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Adjustable Render Power > > State policies > > > > Cool... I'd like to see if Ouping and Mengmeng can work together to > > get power & power numbers across a bunch of workloads for these policies. > > > > Ouping & Mengmeng, can you run your usual battery of stuff against > > each of these settings and report back the results? > > > > Thanks, > > Jesse > > > > On Fri, 26 Jul 2013 23:24:11 +0100 > > Chris Wilson wrote: > > > > > As a complement to the suggestions put forward by Jesse in > > > > > > drm/i915: "Scotty, I need more power!" > > > (1372436290-3297-1-git-send-email-jbar...@virtuousgeek.org) > > > > > > and > > > > > > drm/i915: boost GPU and CPU freq when leaving idle > > > (1372438472-3233-1-git-send-email-jbar...@virtuousgeek.org) > > > > > > we also have the ability to fine tune how we respond to the GPU's > > > requests for more power. > > > > > > This patch introduces the i915.rps_policy module parameter that > > > adjusts how we respond to the upclock request: > > > > > > 1 - Powersaving (current implementation) > > > Increase the frequency by one bin on every upclock request. > > > > > > 2 - Conservative (new default) > > > When waking from idle, boost the render frequency to the > > > default render frequency (RP1) > > > > > > 3 - Ondemand > > > At every upclock request, increase to halfway between the current > > > frequency and maximum. This should give rapid upclocking similar > > > to tcp window scaling. > > > > > > 4 - Performance > > > Every time the GPU wants more power, give it everything we have. > > > > > > Signed-off-by: Chris Wilson > > > --- > > > drivers/gpu/drm/i915/i915_drv.c | 8 +++ > > > drivers/gpu/drm/i915/i915_drv.h | 2 ++ > > > drivers/gpu/drm/i915/i915_irq.c | 46 > > > + > > > drivers/gpu/drm/i915/intel_pm.c | 1 + > > > 4 files changed, 44 insertions(+), 13 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/i915/i915_drv.c > > > b/drivers/gpu/drm/i915/i915_drv.c index 1d8cedc..7ad80f4 100644 > > > --- a/drivers/gpu/drm/i915/i915_drv.c > > > +++ b/drivers/gpu/drm/i915/i915_drv.c > > > @@ -72,6 +72,14 @@ MODULE_PARM_DESC(i915_enable_rc6, > > > "For example, 3 would enable rc6 an
Re: [Intel-gfx] [PATCH] drm/i915: Adjustable Render Power State policies
HI Chris, I retested idle power, idle power is the same(12.5 w) with patch and without patch. maybe the machine is unstable after plugged in power. > -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Thursday, August 01, 2013 3:44 PM > To: Zhang, Ouping > Cc: Jesse Barnes; intel-gfx@lists.freedesktop.org; Meng, Mengmeng; Jin, > Gordon > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Adjustable Render Power State > policies > > On Thu, Aug 01, 2013 at 05:15:36AM +, Zhang, Ouping wrote: > > Test patch on Harris Beach, > > max frequency: 1100 > > lowest frequency : 200 > > > > For doom3, When waking from idle, boost the render frequency to RP1(200). > At every upclock request, increase to halfway between the current frequency > and maximum. attached the frequency changing of doom3. > > Applied the patch, performance improved, but consumed more power, except > smokin-guns workload, performance improved and consumed less power. > > Hmm, the plan was not to affect idle power consumption. Can you log > measured frequency and rc6 state whilst idle? I wonder if something is > preventing the system from idling. Maybe we need something like perf > timechart to measure wakeups over time. > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm/i915: Increase the RC6p threshold.
Hi Jesse, Do you mean increase /sys/class/drm/card0/power/rc6p_residency_ms from 10 to 15, and measure power difference on IVB when system is on idle? -Original Message- From: Jesse Barnes [mailto:jbar...@virtuousgeek.org] Sent: Wednesday, February 20, 2013 8:16 AM To: Stéphane Marchesin Cc: intel-gfx@lists.freedesktop.org; Zhang, Ouping Subject: Re: [Intel-gfx] [PATCH] drm/i915: Increase the RC6p threshold. On Tue, 19 Feb 2013 15:53:56 -0800 Stéphane Marchesin wrote: > On Tue, Jan 29, 2013 at 7:41 PM, Stéphane Marchesin > wrote: > > > This increases GEN6_RC6p_THRESHOLD from 10 to 15. For some > > reason this avoids the gen6_gt_check_fifodbg.isra warnings and > > associated GPU lockups, which makes my ivy bridge machine stable. > > > > > Ping? Seems ok to me. Ouping, can you measure any power difference between the two values? Thanks, -- Jesse Barnes, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm/i915: Increase the RC6p threshold.
running video workload, video avg watt = 38.4 and watt-hour = 6.9 cat /sys/class/drm/card0/power/rc6_residency_ms cat /sys/class/drm/card0/power/rc6p_residency_ms rc6_residency_ms increase from 6708 to 483627 rc6p_residency_ms increase from 410092 to 423378 -Original Message- From: Jesse Barnes [mailto:jbar...@virtuousgeek.org] Sent: Friday, February 22, 2013 12:50 AM To: Zhang, Ouping Cc: Stéphane Marchesin; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: Increase the RC6p threshold. You have to modify the kernel to make the change Stephane suggested, then measure the energy consumption across your workloads. I'd expect the residency to change, but I'm ultimately concerned with the energy used. Jesse On Thu, 21 Feb 2013 05:08:10 +0000 "Zhang, Ouping" wrote: > Hi Jesse, > > Do you mean increase /sys/class/drm/card0/power/rc6p_residency_ms from 10 > to 15, and measure power difference on IVB when system is on idle? > > -Original Message- > From: Jesse Barnes [mailto:jbar...@virtuousgeek.org] > Sent: Wednesday, February 20, 2013 8:16 AM > To: Stéphane Marchesin > Cc: intel-gfx@lists.freedesktop.org; Zhang, Ouping > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Increase the RC6p threshold. > > On Tue, 19 Feb 2013 15:53:56 -0800 > Stéphane Marchesin wrote: > > > On Tue, Jan 29, 2013 at 7:41 PM, Stéphane Marchesin > > wrote: > > > > > This increases GEN6_RC6p_THRESHOLD from 10 to 15. For some > > > reason this avoids the gen6_gt_check_fifodbg.isra warnings and > > > associated GPU lockups, which makes my ivy bridge machine stable. > > > > > > > > Ping? > > Seems ok to me. Ouping, can you measure any power difference between the two > values? > > Thanks, > -- > Jesse Barnes, Intel Open Source Technology Center -- Jesse Barnes, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm/i915: Increase the RC6p threshold.
Increase the RC6p threshold from 10 to 15, there is no power difference between the two values. for example: (1) I915_WRITE(GEN6_RC6p_THRESHOLD, 10); video time: 11' video avg watt 31.3 watt-hour: 5.6 (2) I915_WRITE(GEN6_RC6p_THRESHOLD, 15); video time: 11' video avg watt 31.2 watt-hour: 5.6 -Original Message- From: Jesse Barnes [mailto:jbar...@virtuousgeek.org] Sent: Tuesday, February 26, 2013 12:14 AM To: Zhang, Ouping Cc: Stéphane Marchesin; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: Increase the RC6p threshold. How does the watt-hour result compare to before the patch? Thanks, Jesse On Mon, 25 Feb 2013 07:33:38 +0000 "Zhang, Ouping" wrote: > running video workload, video avg watt = 38.4 and watt-hour = 6.9 cat > /sys/class/drm/card0/power/rc6_residency_ms > cat /sys/class/drm/card0/power/rc6p_residency_ms > rc6_residency_ms increase from 6708 to 483627 rc6p_residency_ms > increase from 410092 to 423378 > > -Original Message- > From: Jesse Barnes [mailto:jbar...@virtuousgeek.org] > Sent: Friday, February 22, 2013 12:50 AM > To: Zhang, Ouping > Cc: Stéphane Marchesin; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Increase the RC6p threshold. > > You have to modify the kernel to make the change Stephane suggested, then > measure the energy consumption across your workloads. I'd expect the > residency to change, but I'm ultimately concerned with the energy used. > > Jesse > > On Thu, 21 Feb 2013 05:08:10 + > "Zhang, Ouping" wrote: > > > Hi Jesse, > > > > Do you mean increase /sys/class/drm/card0/power/rc6p_residency_ms from > > 10 to 15, and measure power difference on IVB when system is on > > idle? > > > > -Original Message- > > From: Jesse Barnes [mailto:jbar...@virtuousgeek.org] > > Sent: Wednesday, February 20, 2013 8:16 AM > > To: Stéphane Marchesin > > Cc: intel-gfx@lists.freedesktop.org; Zhang, Ouping > > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Increase the RC6p threshold. > > > > On Tue, 19 Feb 2013 15:53:56 -0800 > > Stéphane Marchesin wrote: > > > > > On Tue, Jan 29, 2013 at 7:41 PM, Stéphane Marchesin > > > wrote: > > > > > > > This increases GEN6_RC6p_THRESHOLD from 10 to 15. For > > > > some reason this avoids the gen6_gt_check_fifodbg.isra warnings > > > > and associated GPU lockups, which makes my ivy bridge machine stable. > > > > > > > > > > > Ping? > > > > Seems ok to me. Ouping, can you measure any power difference between the > > two values? > > > > Thanks, > > -- > > Jesse Barnes, Intel Open Source Technology Center > > > -- > Jesse Barnes, Intel Open Source Technology Center -- Jesse Barnes, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
