Re: [Intel-gfx] [PATCH v4 0/2] drm/i915/opregion: proper handling of DIDL and CADL
Found a problem: After screensaver kicked in and display was turned off the brightness keys stop working. Problem can be reproduced like that: 1. Boot laptop 2. Test brightness keys, they are working 3. open Terminal and issue "xset -display :0 dpms force off" 4. the screen goes blank (like after the screensaver timeout) 5. push a key to bring the screen back 6. test brightness keys again, now they don't work If the system is sent to suspend and woken up everything is fine again. Behaviour happens on the 4.7.0-rc5 kernel from the opregion-didl-v4 branch. Before I compiled the 4.7.0-r4 from the same git repository. On this (v3) everything still works after the screen was blanked. Best regards Rainer Am 30.06.2016 um 11:19 schrieb Rainer Koenig: > Am 29.06.2016 um 17:36 schrieb Jani Nikula: >> This is v4 of [1]. The first three have already been pushed to >> drm-intel-next-queued. The only change here is the atomic commit. >> >> Review and testing would be much appreciated to move this forward. For >> testing, I've pushed this to opregion-didl-v4 branch of my repo at [2]. >> > Tested on a Fujitsu LIFEBOOK E736: Brightness keys are working now. > > Best regards > Rainer > -- Dipl.-Inf. (FH) Rainer Koenig Project Manager Linux Clients FJ EMEIA PR PSO PM&D CCD ENG SW OSS&C Fujitsu Technology Solutions Bürgermeister-Ullrich-Str. 100 86199 Augsburg Germany Telephone: +49-821-804-3321 Telefax: +49-821-804-2131 Mail: mailto:rainer.koe...@ts.fujitsu.com Internet ts.fujtsu.com Company Details ts.fujitsu.com/imprint.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v4 0/2] drm/i915/opregion: proper handling of DIDL and CADL
Am 29.06.2016 um 17:36 schrieb Jani Nikula: > This is v4 of [1]. The first three have already been pushed to > drm-intel-next-queued. The only change here is the atomic commit. > > Review and testing would be much appreciated to move this forward. For > testing, I've pushed this to opregion-didl-v4 branch of my repo at [2]. > Tested on a Fujitsu LIFEBOOK E736: Brightness keys are working now. Best regards Rainer -- Dipl.-Inf. (FH) Rainer Koenig Project Manager Linux Clients FJ EMEIA PR PSO PM&D CCD ENG SW OSS&C Fujitsu Technology Solutions Bürgermeister-Ullrich-Str. 100 86199 Augsburg Germany Telephone: +49-821-804-3321 Telefax: +49-821-804-2131 Mail: mailto:rainer.koe...@ts.fujitsu.com Internet ts.fujtsu.com Company Details ts.fujitsu.com/imprint.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL
Hi Jani, one quick questions: What happened to those CADL patches. I was expecting them to showup in the mainstream kernel.org kernel some day, but even in 4.9rc3 I cant't find them. Best regards Rainer Am 25.08.2016 um 14:53 schrieb Jani Nikula: > This is the next iteration of [1] and [2]. Please review and/or test, > according to your abilities. > > Thanks, > Jani. > > Cc: Peter Wu > Cc: Rainer Koenig > Cc: Jan-Marek Glogowski > Cc: Maarten Lankhorst > Cc: Marcos Paulo de Souza > Cc: Paolo Stivanin > > [1] http://mid.mail-archive.com/cover.1467214151.git.jani.nikula@intel.com > [2] > http://mid.mail-archive.com/1471315782-925-1-git-send-email-marcos.souza.org@gmail.com > > Jani Nikula (2): > drm/i915: make i915 the source of acpi device ids for _DOD > drm/i915/opregion: update cadl based on actually active outputs > > drivers/gpu/drm/i915/i915_drv.h | 4 + > drivers/gpu/drm/i915/intel_display.c | 6 ++ > drivers/gpu/drm/i915/intel_drv.h | 3 + > drivers/gpu/drm/i915/intel_opregion.c | 157 > +----- > 4 files changed, 74 insertions(+), 96 deletions(-) > -- Dipl.-Inf. (FH) Rainer Koenig Project Manager Linux Clients FJ EMEIA PR PSO PM&D CCD ENG SW OSS&C Fujitsu Technology Solutions Bürgermeister-Ullrich-Str. 100 86199 Augsburg Germany Telephone: +49-821-804-3321 Telefax: +49-821-804-2131 Mail: mailto:rainer.koe...@ts.fujitsu.com Internet ts.fujtsu.com Company Details ts.fujitsu.com/imprint.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL
Hi Jani, this is sad and also bad news. Means that actually we don't have any driver which makes the brightness keys on the Fujitsu LIFEBOOK E7x6 series work. On the other hand I saw that recent patches to intel_opregion.c introduced quirks based on the DMI strings for some machines. I consider this as a very bad idea, but if we do those crazy things, then is there a possibility to create similar quirks for the models we know that are working with your patch? ;-) Best regards Rainer Am 25.08.2016 um 14:53 schrieb Jani Nikula: > This is the next iteration of [1] and [2]. Please review and/or test, > according to your abilities. > > Thanks, > Jani. > > Cc: Peter Wu > Cc: Rainer Koenig > Cc: Jan-Marek Glogowski > Cc: Maarten Lankhorst > Cc: Marcos Paulo de Souza > Cc: Paolo Stivanin > > [1] http://mid.mail-archive.com/cover.1467214151.git.jani.nikula@intel.com > [2] > http://mid.mail-archive.com/1471315782-925-1-git-send-email-marcos.souza.org@gmail.com > > Jani Nikula (2): > drm/i915: make i915 the source of acpi device ids for _DOD > drm/i915/opregion: update cadl based on actually active outputs > > drivers/gpu/drm/i915/i915_drv.h | 4 + > drivers/gpu/drm/i915/intel_display.c | 6 ++ > drivers/gpu/drm/i915/intel_drv.h | 3 + > drivers/gpu/drm/i915/intel_opregion.c | 157 > +----- > 4 files changed, 74 insertions(+), 96 deletions(-) > -- Dipl.-Inf. (FH) Rainer Koenig Project Manager Linux Clients FJ EMEIA PR PSO PM&D CCD ENG SW OSS&C Fujitsu Technology Solutions Bürgermeister-Ullrich-Str. 100 86199 Augsburg Germany Telephone: +49-821-804-3321 Telefax: +49-821-804-2131 Mail: mailto:rainer.koe...@ts.fujitsu.com Internet ts.fujtsu.com Company Details ts.fujitsu.com/imprint.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 0/3] drm/i915/opregion: proper handling of DIDL, and some hacks on CADL
Hi Jani, applied those patches to the 4.9.0-rc4 from http://anongit.freedesktop.org/git/drm-intel.git and tested it on the Fujitsu LIFEBOOK E736. Works perfectly, even after suspend and resume. Adding my hopes that this will be merged into the mainline soon. Best regards and thanks a lot Rainer Am 16.11.2016 um 12:29 schrieb Jani Nikula: > Another spin of [1]. The pain point seems to be the CADL update based on > the list of active connectors. So I left it out for now, and instead > just hack it to ensure CADL contains the internal displays. > > Let's see if this sticks. It shouldn't prevent us from fixing CADL > update properly down the line. > > BR, > Jani. > > > [1] http://mid.mail-archive.com/cover.1472129339.git.jani.nikula@intel.com > > Jani Nikula (3): > drm/i915: make i915 the source of acpi device ids for _DOD > drm/i915/opregion: fill in the CADL from connector list, not DIDL > drm/i915/opregion: put internal panels to the front of CADL > > drivers/gpu/drm/i915/intel_drv.h | 3 + > drivers/gpu/drm/i915/intel_opregion.c | 152 > +- > 2 files changed, 61 insertions(+), 94 deletions(-) > -- Dipl.-Inf. (FH) Rainer Koenig Project Manager Linux Clients FJ EMEIA PR PSO PM&D CCD ENG SW OSS&C Fujitsu Technology Solutions Bürgermeister-Ullrich-Str. 100 86199 Augsburg Germany Telephone: +49-821-804-3321 Telefax: +49-821-804-2131 Mail: mailto:rainer.koe...@ts.fujitsu.com Internet ts.fujtsu.com Company Details ts.fujitsu.com/imprint.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] Problem with i915 driver when mixing Skylake CPU with Kabylake chipset
Hello,
I'm investigating a problem on a machine that has a Kabylake PCH but a
Skylake CPU i5-6500.
Problem is that I can install and use distributions that are based on an
older kernel, but newer Linux dristributions fail to boot even the
installer.
So far I managed to get Fedora 25 with a 4.9 kernel installed, but I
cannot reach runlevel 5. Booting to runlevel 3 shows this message in the
dmesg:
[1.816627] [ cut here ]
[1.816943] WARNING: CPU: 5 PID: 373 at
drivers/gpu/drm/i915/i915_drv.c:210 i915_driver_load+0x1157/0x1410 [i915]
[1.817193] WARN_ON(!((&({ struct drm_i915_private *__p; if
(__builtin_types_compatible_p(typeof(*dev), struct drm_i915_private))
__p = (struct drm_i915_private *)dev; else if
(__builtin_types_compatible_p(typeof(*dev), struct drm_device)) __p =
to_i915((struct drm_device *)dev); else do { bool __cond = !(!(1));
extern void __compiletime_assert_210(void)
__attribute__((error("BUILD_BUG failed"))); if (__cond)
__compiletime_assert_210(); do { } while (0); } while (0); __p;
})->info)->is_kabylake))
[1.817251] e1000e :00:1f.6 enp0s31f6: renamed from eth0
[1.818020] Modules linked in:
[1.818185] i915(+) i2c_algo_bit e1000e drm_kms_helper crc32c_intel
drm ptp serio_raw pps_core video i2c_hid fjes
[1.819091] CPU: 5 PID: 373 Comm: systemd-udevd Not tainted
4.9.5-200.fc25.x86_64 #1
Looking at i95_drv.c I find this code snipped that seems to be
responsible:
} else if (id == INTEL_PCH_SPT_DEVICE_ID_TYPE) {
dev_priv->pch_type = PCH_SPT;
DRM_DEBUG_KMS("Found SunrisePoint PCH\n");
WARN_ON(!IS_SKYLAKE(dev_priv) &&
!IS_KABYLAKE(dev_priv));
} else if (id == INTEL_PCH_SPT_LP_DEVICE_ID_TYPE) {
dev_priv->pch_type = PCH_SPT;
DRM_DEBUG_KMS("Found SunrisePoint LP
PCH\n");
WARN_ON(!IS_SKYLAKE(dev_priv) &&
!IS_KABYLAKE(dev_priv));
} else if (id == INTEL_PCH_KBP_DEVICE_ID_TYPE) {
dev_priv->pch_type = PCH_KBP;
DRM_DEBUG_KMS("Found KabyPoint PCH\n");
WARN_ON(!IS_KABYLAKE(dev_priv));
I read from that, that the driver issues the warning when PCH is a
Kabypoint PCH, but the CPU based graphics is not from a Kabylake CPU.
This explains the warnings in the dmesg. But if I want to start the GUI,
the next problem rises:
[ 125.777880] gnome-shell[1665]: segfault at 0 ip 7f49b6712789 sp
7fff9100ca30 error 4 in libEGL.so.1.0.0[7f49b66f8000+3]
So from my perspective it looks like, that something inside the i915
driver is going wrong when we mix up Skylake CPUs with Kabylake
Chipsets. The same system works pretty well when I replace the Skylake
CPU with a Kabylake CPU.
On the other hand we have boards with a H110 chipset (Sunrise Point)
that also support Kabylake CPUs and where this problem doesn't occur.
So my questions is what is the status of the driver regarding the
combination of Skylake CPU with Kabylake chipset?
Thanks
Rainer
--
Dipl.-Inf. (FH) Rainer Koenig
Project Manager Linux Clients
FJ EMEIA PR PSO PM&D CCD ENG SW OSS&C
Fujitsu Technology Solutions
Bürgermeister-Ullrich-Str. 100
86199 Augsburg
Germany
Telephone: +49-821-804-3321
Telefax: +49-821-804-2131
Mail: mailto:rainer.koe...@ts.fujitsu.com
Internet ts.fujtsu.com
Company Details ts.fujitsu.com/imprint.html
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] Problem with i915 driver when mixing Skylake CPU with Kabylake chipset
Am 01.02.2017 um 14:50 schrieb Jani Nikula: >> I read from that, that the driver issues the warning when PCH is a >> Kabypoint PCH, but the CPU based graphics is not from a Kabylake CPU. > > It's just a warning. But if there really are such combos out there, we > should get rid of the warning. Patch sent [1]. Seent the patch, thanks. Those combos are defined by our product managers to satisfy the demand for systems with the latest chipset that can be used with Windows 7. ;-) My job is to make them usable for Linux and now I run into problemns... >> So my questions is what is the status of the driver regarding the >> combination of Skylake CPU with Kabylake chipset? > > I'm not aware of any issues, IIUC there shouldn't be differences between > the PCHs that would affect your perceived userspace segfault, and it > shouldn't segfault anyway based on what i915 does. Ack. The segfault thing was the best I could get so far. Other distros like SLED 12 SP2 just die during bootup. I have to find a way to get debugger access / serial console working on that system so that I can find out more... Thanks Rainer -- Dipl.-Inf. (FH) Rainer Koenig Project Manager Linux Clients FJ EMEIA PR PSO PM&D CCD ENG SW OSS&C Fujitsu Technology Solutions Bürgermeister-Ullrich-Str. 100 86199 Augsburg Germany Telephone: +49-821-804-3321 Telefax: +49-821-804-2131 Mail: mailto:rainer.koe...@ts.fujitsu.com Internet ts.fujtsu.com Company Details ts.fujitsu.com/imprint.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] Experiencing FIFO underruns on Intel Skylake platform
Am 19.05.2015 um 13:41 schrieb Jani Nikula: > > For brand new platforms you should be running drm-intel-nightly branch > from http://cgit.freedesktop.org/drm-intel. Thanks, will try out next. > Double check that you have either i915.preliminary_hw_support=1 module > parameter set or CONFIG_DRM_I915_PRELIMINARY_HW_SUPPORT=y config option > set. ACK. That option is set (otherwise the audio-driver wouldn't work. :-) Regards, Rainer -- Dipl.-Inf. (FH) Rainer Koenig Project Manager Linux Clients Dept. PDG WPS R&D SW OSE Fujitsu Technology Solutions Bürgermeister-Ullrich-Str. 100 86199 Augsburg Germany Telephone: +49-821-804-3321 Telefax: +49-821-804-2131 Mail: mailto:rainer.koe...@ts.fujitsu.com Internet ts.fujtsu.com Company Details ts.fujitsu.com/imprint.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] Experiencing FIFO underruns on Intel Skylake platform
Am 19.05.2015 um 13:41 schrieb Jani Nikula: > > +intel-gfx > For brand new platforms you should be running drm-intel-nightly branch > from http://cgit.freedesktop.org/drm-intel. Tested now, drm-intel-nightly solves the problem. Thanks a lot Rainer -- Dipl.-Inf. (FH) Rainer Koenig Project Manager Linux Clients Dept. PDG WPS R&D SW OSE Fujitsu Technology Solutions Bürgermeister-Ullrich-Str. 100 86199 Augsburg Germany Telephone: +49-821-804-3321 Telefax: +49-821-804-2131 Mail: mailto:rainer.koe...@ts.fujitsu.com Internet ts.fujtsu.com Company Details ts.fujitsu.com/imprint.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
