Re: [Intel-gfx] [kbuild-all] [PATCH] drm: Convert all helpers to drm_connector_list_iter

2016-12-15 Thread Fengguang Wu 

Hi Daniel,

On Fri, Dec 16, 2016 at 08:29:43AM +0100, Daniel Vetter wrote:

Hi Kbuild folks

So yeah this doesn't apply because it's just 1 patch resent out of a
big patch series, in-reply-to the patch it replaces. So applying this
alone and telling me (and all the mailing lists) that it doesn't apply
isn't all that useful.

And it shouldn't be too hard to detect this, since the fdo patchwork
instance does catch most of these partial resends successfully and
correctly, and will retest the entire patch series.


Good point! CC Xiaolong. This scenario seems happen frequent enough in
LKML to worth the efforts to add auto detect logic for.

Thanks,
Fengguang


On Thu, Dec 15, 2016 at 11:59 PM, kbuild test robot  wrote:

Hi Daniel,

[auto build test ERROR on drm/drm-next]
[also build test ERROR on next-20161215]
[cannot apply to v4.9]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-Convert-all-helpers-to-drm_connector_list_iter/20161216-061508
base:   git://people.freedesktop.org/~airlied/linux.git drm-next
config: i386-randconfig-x003-201650 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All error/warnings (new ones prefixed by >>):

   drivers/gpu/drm/drm_crtc_helper.c: In function 'drm_helper_encoder_in_use':

drivers/gpu/drm/drm_crtc_helper.c:91:33: error: storage size of 'conn_iter' 
isn't known

 struct drm_connector_list_iter conn_iter;
^

drivers/gpu/drm/drm_crtc_helper.c:104:2: error: implicit declaration of 
function 'drm_connector_list_iter_get' [-Werror=implicit-function-declaration]

 drm_connector_list_iter_get(dev, &conn_iter);
 ^~~

drivers/gpu/drm/drm_crtc_helper.c:105:2: error: implicit declaration of 
function 'drm_for_each_connector_iter' [-Werror=implicit-function-declaration]

 drm_for_each_connector_iter(connector, &conn_iter) {
 ^~~

drivers/gpu/drm/drm_crtc_helper.c:105:53: error: expected ';' before '{' token

 drm_for_each_connector_iter(connector, &conn_iter) {
^
   drivers/gpu/drm/drm_crtc_helper.c:91:33: warning: unused variable 
'conn_iter' [-Wunused-variable]
 struct drm_connector_list_iter conn_iter;
^
   drivers/gpu/drm/drm_crtc_helper.c: In function 'drm_crtc_helper_disable':
   drivers/gpu/drm/drm_crtc_helper.c:446:34: error: storage size of 'conn_iter' 
isn't known
  struct drm_connector_list_iter conn_iter;
 ^
   drivers/gpu/drm/drm_crtc_helper.c:452:54: error: expected ';' before '{' 
token
  drm_for_each_connector_iter(connector, &conn_iter) {
 ^
   drivers/gpu/drm/drm_crtc_helper.c:446:34: warning: unused variable 
'conn_iter' [-Wunused-variable]
  struct drm_connector_list_iter conn_iter;
 ^
   drivers/gpu/drm/drm_crtc_helper.c: In function 'drm_crtc_helper_set_config':
   drivers/gpu/drm/drm_crtc_helper.c:521:33: error: storage size of 'conn_iter' 
isn't known
 struct drm_connector_list_iter conn_iter;
^

drivers/gpu/drm/drm_crtc_helper.c:588:3: error: expected ';' before 
'save_connector_encoders'

  save_connector_encoders[count++] = connector->encoder;
  ^~~

drivers/gpu/drm/drm_crtc_helper.c:589:2: error: implicit declaration of 
function 'drm_connector_list_iter_put' [-Werror=implicit-function-declaration]

 drm_connector_list_iter_put(&conn_iter);
 ^~~
   drivers/gpu/drm/drm_crtc_helper.c:633:53: error: expected ';' before '{' 
token
 drm_for_each_connector_iter(connector, &conn_iter) {
^
   drivers/gpu/drm/drm_crtc_helper.c:675:53: error: expected ';' before '{' 
token
 drm_for_each_connector_iter(connector, &conn_iter) {
^

drivers/gpu/drm/drm_crtc_helper.c:767:3: error: expected ';' before 'connector'

  connector->encoder = save_connector_encoders[count++];
  ^
   drivers/gpu/drm/drm_crtc_helper.c:521:33: warning: unused variable 
'conn_iter' [-Wunused-variable]
 struct drm_connector_list_iter conn_iter;
^
   drivers/gpu/drm/drm_crtc_helper.c:517:49: warning: unused variable 
'new_encoder' [-Wunused-variable]
 struct drm_encoder **save_connector_encoders, *new_encoder, *encoder;
^~~
   drivers/gpu/drm/drm_crtc_helper.c:516:41: warning: unused variable 
'new_crtc' [-Wunused-variable]
 struct drm_crtc **save

Re: [Intel-gfx] [kbuild-all] [RFC PATCH drm-intel] drm: arcpgu: arc_pgu_crtc_mode_valid() can be static

2017-06-23 Thread Fengguang Wu 

Hi Daniel,

On Fri, Jun 23, 2017 at 12:30:17PM +0200, Daniel Vetter wrote:

On Fri, Jun 23, 2017 at 05:54:18PM +0800, kbuild test robot wrote:


Signed-off-by: Fengguang Wu 


Oops, missed that, applied.

Btw, for regression fixes like that, could you perhaps auto-generate the
Fixes: line per the kernel process? Makes it easier for me to know where
to apply something :-)


That's a good idea for commits in mainline, where the Fixes tag will
look like

   Fixes: e21d2170f366 ("video: remove unnecessary platform_set_drvdata()")

However typically 0day auto-generated patches are pre-mainline ones,
in which case only patch subject is available. How are we going to
deal with this?

Thanks,
Fengguang


---
 arcpgu_crtc.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/arc/arcpgu_crtc.c 
b/drivers/gpu/drm/arc/arcpgu_crtc.c
index 99fbdae..611af74 100644
--- a/drivers/gpu/drm/arc/arcpgu_crtc.c
+++ b/drivers/gpu/drm/arc/arcpgu_crtc.c
@@ -64,8 +64,8 @@ static const struct drm_crtc_funcs arc_pgu_crtc_funcs = {
.atomic_destroy_state = drm_atomic_helper_crtc_destroy_state,
 };

-enum drm_mode_status arc_pgu_crtc_mode_valid(struct drm_crtc *crtc,
-const struct drm_display_mode 
*mode)
+static enum drm_mode_status arc_pgu_crtc_mode_valid(struct drm_crtc *crtc,
+   const struct 
drm_display_mode *mode)
 {
struct arcpgu_drm_private *arcpgu = crtc_to_arcpgu_priv(crtc);
long rate, clk_rate = mode->clock * 1000;


--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
kbuild-all mailing list
kbuild-...@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild-all

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [kbuild-all] [RFC PATCH drm-intel] drm: arcpgu: arc_pgu_crtc_mode_valid() can be static

2017-06-23 Thread Fengguang Wu 

On Fri, Jun 23, 2017 at 01:08:17PM +0200, Daniel Vetter wrote:

On Fri, Jun 23, 2017 at 06:51:05PM +0800, Fengguang Wu wrote:

Hi Daniel,

On Fri, Jun 23, 2017 at 12:30:17PM +0200, Daniel Vetter wrote:
> On Fri, Jun 23, 2017 at 05:54:18PM +0800, kbuild test robot wrote:
> >
> > Signed-off-by: Fengguang Wu 
>
> Oops, missed that, applied.
>
> Btw, for regression fixes like that, could you perhaps auto-generate the
> Fixes: line per the kernel process? Makes it easier for me to know where
> to apply something :-)

That's a good idea for commits in mainline, where the Fixes tag will
look like

   Fixes: e21d2170f366 ("video: remove unnecessary platform_set_drvdata()")

However typically 0day auto-generated patches are pre-mainline ones,
in which case only patch subject is available. How are we going to
deal with this?


Well many trees you're testing are stable and will never rebase (at least
all the drm-intel|misc.git ones are supposed to be stable), hence the sha1
is stable. I guess other maintainers could just remove the line if they
prefer to squash it in?

Also makes it easier to know where to squash it into :-)


Fair enough. I'll add the Fixes line. :)

Thanks,
Fengguang


> > ---
> >  arcpgu_crtc.c |4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/arc/arcpgu_crtc.c 
b/drivers/gpu/drm/arc/arcpgu_crtc.c
> > index 99fbdae..611af74 100644
> > --- a/drivers/gpu/drm/arc/arcpgu_crtc.c
> > +++ b/drivers/gpu/drm/arc/arcpgu_crtc.c
> > @@ -64,8 +64,8 @@ static const struct drm_crtc_funcs arc_pgu_crtc_funcs = {
> >   .atomic_destroy_state = drm_atomic_helper_crtc_destroy_state,
> >  };
> >
> > -enum drm_mode_status arc_pgu_crtc_mode_valid(struct drm_crtc *crtc,
> > -  const struct drm_display_mode 
*mode)
> > +static enum drm_mode_status arc_pgu_crtc_mode_valid(struct drm_crtc *crtc,
> > + const struct 
drm_display_mode *mode)
> >  {
> >   struct arcpgu_drm_private *arcpgu = crtc_to_arcpgu_priv(crtc);
> >   long rate, clk_rate = mode->clock * 1000;
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
> ___
> kbuild-all mailing list
> kbuild-...@lists.01.org
> https://lists.01.org/mailman/listinfo/kbuild-all


--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
kbuild-all mailing list
kbuild-...@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild-all

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [lib/rbtree, drm/mm] 653c9f9a4d: BUG:kernel_hang_in_boot_stage

2017-11-25 Thread Fengguang Wu 
FYI, we noticed the following commit (built with gcc-5):

commit: 653c9f9a4dd8037ffc5afbb1040d15566aa8f533 ("lib/rbtree,drm/mm: Add 
rbtree_replace_node_cached()")
git://anongit.freedesktop.org/drm-intel topic/core-for-CI

in testcase: boot

on test machine: qemu-system-i386 -enable-kvm -smp 2 -m 320M

caused below changes (please refer to attached dmesg/kmsg for entire 
log/backtrace):

++++
|| 70c1cedd5c | 653c9f9a4d |
++++
| boot_successes | 0  | 0  |
| boot_failures  | 8  | 8  |
| genirq:Flags_mismatch_irq##(ttyS0)vs.#(sir_ir) | 7  | 4  |
| BUG:soft_lockup-CPU##stuck_for#s   | 1  ||
| EIP:insert_augmented   | 1  ||
| Kernel_panic-not_syncing:softlockup:hung_tasks | 1  ||
| BUG:kernel_hang_in_boot_stage  | 0  | 4  |
++++


 [   77.806701] Linux agpgart interface v0.103
 [   77.825237] Hangcheck: starting hangcheck timer 0.9.1 (tick is 180 
seconds, margin is 60 seconds).
 [   77.860502] drm_mm: Testing DRM range manger (struct drm_mm), with 
random_seed=0xbac20086 max_iterations=8192 max_prime=128
 [   77.898934] drm_mm: igt_sanitycheck - ok!
 [  328.297497] kworker/dying (33) used greatest stack depth: 7396 
bytes left
 BUG: kernel hang in boot stage

 Elapsed time: 440

To reproduce:

 git clone https://github.com/intel/lkp-tests.git
 cd lkp-tests
 bin/lkp qemu -k  job-script  # job-script is attached in this 
email

Thanks,
Fengguang
#
# Automatically generated file; DO NOT EDIT.
# Linux/i386 4.14.0 Kernel Configuration
#
# CONFIG_64BIT is not set
CONFIG_X86_32=y
CONFIG_X86=y
CONFIG_INSTRUCTION_DECODER=y
CONFIG_OUTPUT_FORMAT="elf32-i386"
CONFIG_ARCH_DEFCONFIG="arch/x86/configs/i386_defconfig"
CONFIG_LOCKDEP_SUPPORT=y
CONFIG_STACKTRACE_SUPPORT=y
CONFIG_MMU=y
CONFIG_ARCH_MMAP_RND_BITS_MIN=8
CONFIG_ARCH_MMAP_RND_BITS_MAX=16
CONFIG_ARCH_MMAP_RND_COMPAT_BITS_MIN=8
CONFIG_ARCH_MMAP_RND_COMPAT_BITS_MAX=16
CONFIG_NEED_DMA_MAP_STATE=y
CONFIG_NEED_SG_DMA_LENGTH=y
CONFIG_GENERIC_ISA_DMA=y
CONFIG_GENERIC_BUG=y
CONFIG_GENERIC_HWEIGHT=y
CONFIG_ARCH_MAY_HAVE_PC_FDC=y
CONFIG_RWSEM_XCHGADD_ALGORITHM=y
CONFIG_GENERIC_CALIBRATE_DELAY=y
CONFIG_ARCH_HAS_CPU_RELAX=y
CONFIG_ARCH_HAS_CACHE_LINE_SIZE=y
CONFIG_HAVE_SETUP_PER_CPU_AREA=y
CONFIG_NEED_PER_CPU_EMBED_FIRST_CHUNK=y
CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK=y
CONFIG_ARCH_HIBERNATION_POSSIBLE=y
CONFIG_ARCH_SUSPEND_POSSIBLE=y
CONFIG_ARCH_WANT_HUGE_PMD_SHARE=y
CONFIG_ARCH_WANT_GENERAL_HUGETLB=y
CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING=y
CONFIG_ARCH_SUPPORTS_DEBUG_PAGEALLOC=y
CONFIG_ARCH_SUPPORTS_UPROBES=y
CONFIG_FIX_EARLYCON_MEM=y
CONFIG_PGTABLE_LEVELS=3
CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config"
CONFIG_CONSTRUCTORS=y
CONFIG_IRQ_WORK=y
CONFIG_BUILDTIME_EXTABLE_SORT=y
CONFIG_THREAD_INFO_IN_TASK=y

#
# General setup
#
CONFIG_BROKEN_ON_SMP=y
CONFIG_INIT_ENV_ARG_LIMIT=32
CONFIG_CROSS_COMPILE=""
# CONFIG_COMPILE_TEST is not set
CONFIG_LOCALVERSION=""
CONFIG_LOCALVERSION_AUTO=y
CONFIG_HAVE_KERNEL_GZIP=y
CONFIG_HAVE_KERNEL_BZIP2=y
CONFIG_HAVE_KERNEL_LZMA=y
CONFIG_HAVE_KERNEL_XZ=y
CONFIG_HAVE_KERNEL_LZO=y
CONFIG_HAVE_KERNEL_LZ4=y
# CONFIG_KERNEL_GZIP is not set
CONFIG_KERNEL_BZIP2=y
# CONFIG_KERNEL_LZMA is not set
# CONFIG_KERNEL_XZ is not set
# CONFIG_KERNEL_LZO is not set
# CONFIG_KERNEL_LZ4 is not set
CONFIG_DEFAULT_HOSTNAME="(none)"
CONFIG_SWAP=y
# CONFIG_SYSVIPC is not set
# CONFIG_POSIX_MQUEUE is not set
# CONFIG_CROSS_MEMORY_ATTACH is not set
CONFIG_FHANDLE=y
# CONFIG_USELIB is not set
# CONFIG_AUDIT is not set
CONFIG_HAVE_ARCH_AUDITSYSCALL=y

#
# IRQ subsystem
#
CONFIG_GENERIC_IRQ_PROBE=y
CONFIG_GENERIC_IRQ_SHOW=y
CONFIG_GENERIC_IRQ_CHIP=y
CONFIG_IRQ_DOMAIN=y
CONFIG_IRQ_SIM=y
CONFIG_IRQ_DOMAIN_HIERARCHY=y
CONFIG_GENERIC_MSI_IRQ=y
CONFIG_GENERIC_MSI_IRQ_DOMAIN=y
CONFIG_IRQ_DOMAIN_DEBUG=y
CONFIG_IRQ_FORCED_THREADING=y
CONFIG_SPARSE_IRQ=y
# CONFIG_GENERIC_IRQ_DEBUGFS is not set
CONFIG_CLOCKSOURCE_WATCHDOG=y
CONFIG_ARCH_CLOCKSOURCE_DATA=y
CONFIG_CLOCKSOURCE_VALIDATE_LAST_CYCLE=y
CONFIG_GENERIC_TIME_VSYSCALL=y
CONFIG_GENERIC_CLOCKEVENTS=y
CONFIG_GENERIC_CLOCKEVENTS_BROADCAST=y
CONFIG_GENERIC_CLOCKEVENTS_MIN_ADJUST=y
CONFIG_GENERIC_CMOS_UPDATE=y

#
# Timers subsystem
#
CONFIG_HZ_PERIODIC=y
# CONFIG_NO_HZ_IDLE is not set
CONFIG_NO_HZ=y
# CONFIG_HIGH_RES_TIMERS is not set

#
# CPU/Task time and stats accounting
#
CONFIG_TICK_CPU_ACCOUNTING=y
CONFIG_IRQ_TIME_ACCOUNTING=y
CONFIG_BSD_PROCESS_ACCT=y
CONFIG_BSD_PROCESS_ACCT_V3=y
# CONFIG_TASKSTATS is not set

#
# RCU Subsystem
#
CONFIG_TINY_RCU=y
#

Re: [Intel-gfx] [haswell_crtc_enable] WARNING: CPU: 3 PID: 109 at drivers/gpu/drm/drm_vblank.c:1066 drm_wait_one_vblank+0x18f/0x1a0 [drm]

2017-10-30 Thread Fengguang Wu 

On Mon, Oct 30, 2017 at 12:10:11PM -0700, Linus Torvalds wrote:

On Mon, Oct 30, 2017 at 12:00 AM, Fengguang Wu  wrote:

CC intel-gfx.


Thanks, these are all interesting (even if some of them seem to be
from random kernels).

Fengguang, is this a new script that you started running? Because I'm
*hoping* it's not that rc6 suddenly seems so flaky, and it's really
that you now have a nice new script that started reporting these
things better, even though many of them may be old?


Yes they are mostly not new issues to rc6. Just that I happen to start
this form of summary reporting now.

It's a bit late for rc6 and sorry about that! Next time when reporting
from rc1, we'll have much more time for working out proper fixes and
testing them out thoroughly.

Regards,
Fengguang
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [drm-intel:drm-intel-nightly 341/365] drivers/gpu/drm//selftests/test-drm_mm.c:58:1: fatal error: opening dependency file drivers/gpu/drm//selftests/.test-drm_mm.o.d: No such file or d

2016-12-28 Thread Fengguang Wu 

On Tue, Dec 27, 2016 at 07:46:55PM +0100, Daniel Vetter wrote:

On Wed, Dec 28, 2016 at 12:57:07AM +0800, kbuild test robot wrote:

tree:   git://anongit.freedesktop.org/drm-intel drm-intel-nightly
head:   0d15e733fab5dd48154dda2bebdacd1d87069d08
commit: 50f0033d1a0f3a8e9eed09ab68067fbb57b0669d [341/365] drm: Add some 
kselftests for the DRM range manager (struct drm_mm)
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget 
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
 -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 50f0033d1a0f3a8e9eed09ab68067fbb57b0669d
# save the attached .config to linux build tree
make.cross ARCH=arm

All errors (new ones prefixed by >>):

>> drivers/gpu/drm//selftests/test-drm_mm.c:58:1: fatal error: opening 
dependency file drivers/gpu/drm//selftests/.test-drm_mm.o.d: No such file or directory
MODULE_LICENSE("GPL");
^~
   compilation terminated.


Hm, it compiles fine here. Is there anything different than normal in your
build setup? Like compiling to a different target using O=$output_path?


Yes we use separated .o dir. Is that the problem?

Thanks,
Fengguang


vim +58 drivers/gpu/drm//selftests/test-drm_mm.c

42  
43  return err > 0 ? 0 : err;
44  }
45  
46  static void __exit test_drm_mm_exit(void)
47  {
48  }
49  
50  module_init(test_drm_mm_init);
51  module_exit(test_drm_mm_exit);
52  
53  module_param(random_seed, uint, 0400);
54  module_param(max_iterations, uint, 0400);
55  module_param(max_prime, uint, 0400);
56  
57  MODULE_AUTHOR("Intel Corporation");
  > 58   MODULE_LICENSE("GPL");

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation




___
dri-devel mailing list
dri-de...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel



--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [drm-intel:drm-intel-fixes 52/52] ERROR: Unrecognized email address: 'stable.]'

2013-07-18 Thread Fengguang Wu 
Joe,

> (It would have been nice to get the content that failes
>  instead of having to pull the tree)

Good suggestion! I'll attach the git-format-patch result in the
checkpatch.pl reports in future.

Thanks,
Fengguang
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] MAINTAINERS: Update drm/i915 git repo

2014-02-05 Thread Fengguang Wu 
On Wed, Feb 05, 2014 at 08:54:15AM +0100, Daniel Vetter wrote:
> On Tue, Feb 4, 2014 at 8:37 PM, Daniel Vetter  wrote:
> > On Tue, Feb 4, 2014 at 8:00 PM, Daniel Vetter  
> > wrote:
> >> Moved to a common location so that Jani also can push to it, to avoid
> >> moving it every time I go on vacation. Please update autobuilders and
> >> everything else pointing at the drm-intel.git repo, the old one won't
> >> be updated any more.
> >>
> >> Cc: Dave Airlie 
> >> Cc: Jani Nikula 
> >> Signed-off-by: Daniel Vetter 
> >
> > Also forgotten to cc our QA people ...
> 
> And Wu Fengguang with his 0-day builder also needs to know about the
> new git repo!

Yeah updated, thank you for the info!

Fengguang

> -Daniel
> 
> >> ---
> >>  MAINTAINERS | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/MAINTAINERS b/MAINTAINERS
> >> index 31a046213274..e3aaf277cf58 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -2832,7 +2832,7 @@ M:Jani Nikula 
> >>  L: intel-gfx@lists.freedesktop.org
> >>  L: dri-de...@lists.freedesktop.org
> >>  Q: http://patchwork.freedesktop.org/project/intel-gfx/
> >> -T: git git://people.freedesktop.org/~danvet/drm-intel
> >> +T: git git://anongit.freedesktop.org/drm-intel
> >>  S: Supported
> >>  F: drivers/gpu/drm/i915/
> >>  F: include/drm/i915*
> >> --
> >> 1.8.5.2
> >>
> >
> >
> >
> > --
> > Daniel Vetter
> > Software Engineer, Intel Corporation
> > +41 (0) 79 365 57 48 - http://blog.ffwll.ch
> 
> 
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH V2 1/2] intel_audio_dump: fix wrong port definition

2012-08-15 Thread Fengguang Wu 
Thanks for catching this!

Acked-by: Fengguang Wu 

On Tue, Aug 07, 2012 at 04:52:49PM +0800, Wang Xingchao wrote:
> There're three Ports B/C/D used for selection by each transcoder A/B/C.
> 
> Signed-off-by: Wang Xingchao 
> ---
>  tools/intel_audio_dump.c |6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/intel_audio_dump.c b/tools/intel_audio_dump.c
> index 077e096..8a0f6ee 100644
> --- a/tools/intel_audio_dump.c
> +++ b/tools/intel_audio_dump.c
> @@ -126,9 +126,9 @@ static const char *video_dip_trans[] = {
>  static const char *trans_to_port_sel[] = {
>   [0] = "no port",
>   [1] = "Digital Port B",
> - [2] = "Digital Port B",
> - [3] = "Digital Port B",
> - [4] = "Digital Port B",
> + [2] = "Digital Port C",
> + [3] = "Digital Port D",
> + [4] = "reserved",
>   [5] = "reserved",
>   [6] = "reserved",
>   [7] = "reserved",
> -- 
> 1.7.9.5
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH V2 2/2] intel_audio_dump: add Haswell audio dump support

2012-08-15 Thread Fengguang Wu 
Xingchao,

Have you tested the patch in haswell as well as in older hardwares?
In general it would be better if you have run this tool for some time
on several hardwares -- that's the best way to smooth out possible bugs.

> +/*Haswell registers*/

Please fix the style to (ditto for lots of other comments)

> +/* Haswell registers */

Thanks,
Fengguang
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: ELD info update during HDMI hot plug

2012-09-04 Thread Fengguang Wu 
Xingchao,

We have the drm_i915_display_funcs.write_eld() for such
functionalities.

Thanks,
Fengguang

On Wed, Sep 05, 2012 at 01:06:16PM +0800, Wang Xingchao wrote:
> ELD infomation should update immediately when detected HDMI hot plug event.
> The related ELD_VALID bit should be set/clear to generate unsolicited event
> to notify Alsa driver this change.
> 
> Signed-off-by: Wang Xingchao 
> ---
>  drivers/gpu/drm/i915/intel_hdmi.c |   28 
>  1 file changed, 28 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c 
> b/drivers/gpu/drm/i915/intel_hdmi.c
> index e4c37bb..1d9aaa9 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -719,6 +719,10 @@ intel_hdmi_detect(struct drm_connector *connector, bool 
> force)
>   struct drm_i915_private *dev_priv = connector->dev->dev_private;
>   struct edid *edid;
>   enum drm_connector_status status = connector_status_disconnected;
> + enum drm_connector_status old_status = connector->status;
> + int aud_cntrl_st2;
> + uint32_t eldv;
> + int i;
>  
>   if (IS_G4X(connector->dev) && !g4x_hdmi_connected(intel_hdmi))
>   return status;
> @@ -747,6 +751,30 @@ intel_hdmi_detect(struct drm_connector *connector, bool 
> force)
>   (intel_hdmi->force_audio == HDMI_AUDIO_ON);
>   }
>  
> + if (status != old_status) {
> + if (HAS_PCH_IBX(connector->dev))
> + aud_cntrl_st2 = IBX_AUD_CNTL_ST2;
> + else if (IS_HASWELL(connector->dev))
> + aud_cntrl_st2 = HSW_AUD_PIN_ELD_CP_VLD;
> + else
> + aud_cntrl_st2 = CPT_AUD_CNTRL_ST2;
> +
> + eldv = (AUDIO_ELD_VALID_A |
> + AUDIO_ELD_VALID_B |
> + AUDIO_ELD_VALID_C) ;
> + if (status == connector_status_connected) {
> + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Pluged In\n", 
> connector->base.id,
> + drm_get_connector_name(connector));
> + I915_WRITE(aud_cntrl_st2, eldv);
> + } else {
> + i = I915_READ(aud_cntrl_st2);
> + i &= ~eldv;
> + I915_WRITE(aud_cntrl_st2, i);
> + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Pluged Out\n", 
> connector->base.id,
> + drm_get_connector_name(connector));
> + }
> + }
> +
>   return status;
>  }
>  
> -- 
> 1.7.9.5
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: HDMI - Clear Audio Enable bit for Hot Plug unconditionally

2012-09-12 Thread Fengguang Wu 
>   u32 enable_bits = SDVO_ENABLE;
>  
> - if (intel_hdmi->has_audio)
> - enable_bits |= SDVO_AUDIO_ENABLE;
> + enable_bits |= SDVO_AUDIO_ENABLE;

The two lines can be combined:

u32 enable_bits = SDVO_ENABLE | SDVO_AUDIO_ENABLE;

Thanks,
Fengguang
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [kbuild-all] [RFC 4/6] drm/i915: Add i915 perf event for Haswell OA unit

2015-09-29 Thread Fengguang Wu 
On Tue, Sep 29, 2015 at 05:18:45PM +0200, Peter Zijlstra wrote:
> On Tue, Sep 29, 2015 at 10:55:39PM +0800, kbuild test robot wrote:
> > Hi Robert,
> > 
> > [auto build test results on v4.3-rc3 -- if it's inappropriate base, please 
> > ignore]
> > 
> > config: i386-defconfig (attached as .config)
> > reproduce:
> >   git checkout a1d59679ae8f3e7e7659e9723ae3fc69af2532e6
> >   # save the attached .config to linux build tree
> >   make ARCH=i386 
> > 
> > All warnings (new ones prefixed by >>):
> > 
> 
> @Wu, hehe, another series pattern to match ;-)

Thanks! I'm now matching ^([...])? ?[... ii/NN] as patch series. :-)

Regards,
Fengguang
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [drm-intel:topic/drm-misc 35/36] drivers/gpu/drm/virtio/virtgpu_drm_bus.c:55:2: error: implicit declaration of function 'drm_fb_helper_remove_conflicting_framebuffers'

2015-07-13 Thread Fengguang Wu 
tree:   git://anongit.freedesktop.org/drm-intel topic/drm-misc
head:   6198447760ed3c684fbcc93b5f91b4e84861e8f3
commit: 7bd870e7b1c8b4ff0b1624778d9ab17bfe6b903d [35/36] drm/virtio: Use new 
drm_fb_helper functions
config: x86_64-randconfig-i0-201528 (attached as .config)
reproduce:
  git checkout 7bd870e7b1c8b4ff0b1624778d9ab17bfe6b903d
  # save the attached .config to linux build tree
  make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

   drivers/gpu/drm/virtio/virtgpu_drm_bus.c: In function 
'virtio_pci_kick_out_firmware_fb':
>> drivers/gpu/drm/virtio/virtgpu_drm_bus.c:55:2: error: implicit declaration 
>> of function 'drm_fb_helper_remove_conflicting_framebuffers' 
>> [-Werror=implicit-function-declaration]
 drm_fb_helper_remove_conflicting_framebuffers(ap, "virtiodrmfb",
 ^
   cc1: some warnings being treated as errors
--
   drivers/gpu/drm/virtio/virtgpu_fb.c: In function 'virtio_gpufb_create':
>> drivers/gpu/drm/virtio/virtgpu_fb.c:233:17: warning: unused variable 
>> 'device' [-Wunused-variable]
 struct device *device = vgdev->dev;
^
   drivers/gpu/drm/virtio/virtgpu_fb.c: In function 'virtio_gpu_fbdev_destroy':
>> drivers/gpu/drm/virtio/virtgpu_fb.c:365:18: warning: unused variable 'info' 
>> [-Wunused-variable]
 struct fb_info *info;
 ^

vim +/drm_fb_helper_remove_conflicting_framebuffers +55 
drivers/gpu/drm/virtio/virtgpu_drm_bus.c

50cb941a Gerd Hoffmann 2015-03-26  49   ap->ranges[0].base = 
pci_resource_start(pci_dev, 0);
50cb941a Gerd Hoffmann 2015-03-26  50   ap->ranges[0].size = 
pci_resource_len(pci_dev, 0);
50cb941a Gerd Hoffmann 2015-03-26  51  
50cb941a Gerd Hoffmann 2015-03-26  52   primary = 
pci_dev->resource[PCI_ROM_RESOURCE].flags
50cb941a Gerd Hoffmann 2015-03-26  53   & IORESOURCE_ROM_SHADOW;
50cb941a Gerd Hoffmann 2015-03-26  54  
7bd870e7 Archit Taneja 2015-07-13 @55   
drm_fb_helper_remove_conflicting_framebuffers(ap, "virtiodrmfb",
7bd870e7 Archit Taneja 2015-07-13  56   primary);
50cb941a Gerd Hoffmann 2015-03-26  57  
50cb941a Gerd Hoffmann 2015-03-26  58   kfree(ap);

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation
#
# Automatically generated file; DO NOT EDIT.
# Linux/x86_64 4.1.0-rc6 Kernel Configuration
#
CONFIG_64BIT=y
CONFIG_X86_64=y
CONFIG_X86=y
CONFIG_INSTRUCTION_DECODER=y
CONFIG_PERF_EVENTS_INTEL_UNCORE=y
CONFIG_OUTPUT_FORMAT="elf64-x86-64"
CONFIG_ARCH_DEFCONFIG="arch/x86/configs/x86_64_defconfig"
CONFIG_LOCKDEP_SUPPORT=y
CONFIG_STACKTRACE_SUPPORT=y
CONFIG_HAVE_LATENCYTOP_SUPPORT=y
CONFIG_MMU=y
CONFIG_NEED_DMA_MAP_STATE=y
CONFIG_NEED_SG_DMA_LENGTH=y
CONFIG_GENERIC_BUG=y
CONFIG_GENERIC_BUG_RELATIVE_POINTERS=y
CONFIG_GENERIC_HWEIGHT=y
CONFIG_RWSEM_XCHGADD_ALGORITHM=y
CONFIG_GENERIC_CALIBRATE_DELAY=y
CONFIG_ARCH_HAS_CPU_RELAX=y
CONFIG_ARCH_HAS_CACHE_LINE_SIZE=y
CONFIG_HAVE_SETUP_PER_CPU_AREA=y
CONFIG_NEED_PER_CPU_EMBED_FIRST_CHUNK=y
CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK=y
CONFIG_ARCH_HIBERNATION_POSSIBLE=y
CONFIG_ARCH_SUSPEND_POSSIBLE=y
CONFIG_ARCH_WANT_HUGE_PMD_SHARE=y
CONFIG_ARCH_WANT_GENERAL_HUGETLB=y
CONFIG_ZONE_DMA32=y
CONFIG_AUDIT_ARCH=y
CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING=y
CONFIG_ARCH_SUPPORTS_DEBUG_PAGEALLOC=y
CONFIG_X86_64_SMP=y
CONFIG_X86_HT=y
CONFIG_ARCH_HWEIGHT_CFLAGS="-fcall-saved-rdi -fcall-saved-rsi -fcall-saved-rdx 
-fcall-saved-rcx -fcall-saved-r8 -fcall-saved-r9 -fcall-saved-r10 
-fcall-saved-r11"
CONFIG_ARCH_SUPPORTS_UPROBES=y
CONFIG_FIX_EARLYCON_MEM=y
CONFIG_PGTABLE_LEVELS=4
CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config"
CONFIG_IRQ_WORK=y
CONFIG_BUILDTIME_EXTABLE_SORT=y

#
# General setup
#
CONFIG_INIT_ENV_ARG_LIMIT=32
CONFIG_CROSS_COMPILE=""
# CONFIG_COMPILE_TEST is not set
CONFIG_LOCALVERSION=""
CONFIG_LOCALVERSION_AUTO=y
CONFIG_HAVE_KERNEL_GZIP=y
CONFIG_HAVE_KERNEL_BZIP2=y
CONFIG_HAVE_KERNEL_LZMA=y
CONFIG_HAVE_KERNEL_XZ=y
CONFIG_HAVE_KERNEL_LZO=y
CONFIG_HAVE_KERNEL_LZ4=y
# CONFIG_KERNEL_GZIP is not set
# CONFIG_KERNEL_BZIP2 is not set
# CONFIG_KERNEL_LZMA is not set
CONFIG_KERNEL_XZ=y
# CONFIG_KERNEL_LZO is not set
# CONFIG_KERNEL_LZ4 is not set
CONFIG_DEFAULT_HOSTNAME="(none)"
# CONFIG_SYSVIPC is not set
# CONFIG_POSIX_MQUEUE is not set
CONFIG_CROSS_MEMORY_ATTACH=y
CONFIG_FHANDLE=y
CONFIG_USELIB=y
CONFIG_AUDIT=y
CONFIG_HAVE_ARCH_AUDITSYSCALL=y
CONFIG_AUDITSYSCALL=y
CONFIG_AUDIT_WATCH=y
CONFIG_AUDIT_TREE=y

#
# IRQ subsystem
#
CONFIG_GENERIC_IRQ_PROBE=y
CONFIG_GENERIC_IRQ_SHOW=y
CONFIG_GENERIC_IRQ_LEGACY_ALLOC_HWIRQ=y
CONFIG_GENERIC_PENDING_IRQ=y
CONFIG_GENERIC_IRQ_CHIP=y
CONFIG_IRQ_DOMAIN=y
CONFIG_GENERIC_MSI_IRQ=y
CONFIG_IRQ_DOMAIN_DEBUG=y
CONFIG_IRQ_FORCED_THREADING=y
CONFIG_SPARSE_IRQ=y
CONFIG_CLOCKSOURCE_WATCHDOG=y
CONFIG_ARCH_CLOCKSOURCE_DATA=y
CONFIG_CLOCKSOURCE_VALIDATE_LAST_CYCLE=y
CONFIG_GENERIC_TIME_VSYSCALL=y
CONFIG_GENERIC_CLOCKEVENTS=y
CONFIG_GENERIC_CLOCKEVENTS_BROADCAST=y
CONFIG_GENERIC_CLOCKEVENTS_MIN_ADJUST=y
CONF