Re: [Intel-gfx] [PATCH v4] drm/i915/vbt: update DP max link rate table
On Thu, Feb 18, 2021 at 01:23:33PM +0800, Lee Shawn C wrote:
> According to Bspec #20124, max link rate table for DP was updated
> at BDB version 230. Max link rate can support upto UHBR.
>
> After migrate to BDB v230, the definition for LBR, HBR2 and HBR3
> were changed. For backward compatibility. If BDB version was
> from 216 to 229. Driver have to follow original rule to configure
> DP max link rate value from VBT.
>
> v2: split the mapping table to two for old and new BDB definition.
> v3: return link rate instead of assigning it.
> v4: remove the useless variable.
>
> Cc: Ville Syrjala
> Cc: Imre Deak
> Cc: Jani Nikula
> Cc: Cooper Chiou
> Cc: William Tseng
> Signed-off-by: Lee Shawn C
> ---
> @@ -445,8 +456,8 @@ struct child_device_config {
> u16 dp_gpio_pin_num;/* 195 */
> u8 dp_iboost_level:4; /* 196 */
> u8 hdmi_iboost_level:4; /* 196 */
> - u8 dp_max_link_rate:2; /* 216 CNL+ */
> - u8 dp_max_link_rate_reserved:6; /* 216 */
> + u8 dp_max_link_rate:3; /* 230 CNL+ */
> + u8 dp_max_link_rate_reserved:5; /* 230 */
I tweaked the comments here to say "216/230" to retain some hint
that version 216 already added some of this.
And now pushed. Thanks.
> } __packed;
>
> struct bdb_general_definitions {
> --
> 2.17.1
--
Ville Syrjälä
Intel
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH] drm/i915: Workaround async flip + VT-d corruption on HSW/BDW
From: Ville Syrjälä
On HSW/BDW with VT-d active the first tile row scanned out
after the first async flip of the frame often ends up corrupted.
Whether the corruption happens or not depends on the scanline
on which the async flip happens, but the behaviour seems very
consistent. Ie. the same set of scanlines (which are most scanlines)
always show the corruption. And another set of scanlines (far less
of them) never shows the corruption.
I discovered that disabling the fetch-stride stretching
feature cures the corruption. This is some kind of TLB related
prefetch thing AFAIK. We already disable it on SNB primary
planes due to a documented workaround. The hardware folks
indicated that disabling this should be fine, so let's go
with that.
And while we're here, let's document the relevant bits on all
pre-skl platforms.
Fixes: 2a636e240c77 ("drm/i915: Implement async flip for ivb/hsw")
Fixes: cda195f13abd ("drm/i915: Implement async flips for bdw")
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/i915_reg.h | 23 ++-
drivers/gpu/drm/i915/intel_pm.c | 16 +++-
2 files changed, 37 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 224ad897af34..0bb0229a2e49 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -3319,7 +3319,18 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)
#define ILK_DISPLAY_CHICKEN1 _MMIO(0x42000)
#define ILK_FBCQ_DIS (1 << 22)
-#define ILK_PABSTRETCH_DIS(1 << 21)
+#define ILK_PABSTRETCH_DIS REG_BIT(21)
+#define ILK_SABSTRETCH_DIS REG_BIT(20)
+#define IVB_PRI_STRETCH_MAX_MASK REG_GENMASK(21, 20)
+#define IVB_PRI_STRETCH_MAX_X8
REG_FIELD_PREP(IVB_PRI_STRETCH_MAX_MASK, 0)
+#define IVB_PRI_STRETCH_MAX_X4
REG_FIELD_PREP(IVB_PRI_STRETCH_MAX_MASK, 1)
+#define IVB_PRI_STRETCH_MAX_X2
REG_FIELD_PREP(IVB_PRI_STRETCH_MAX_MASK, 2)
+#define IVB_PRI_STRETCH_MAX_X1
REG_FIELD_PREP(IVB_PRI_STRETCH_MAX_MASK, 3)
+#define IVB_SPR_STRETCH_MAX_MASK REG_GENMASK(19, 18)
+#define IVB_SPR_STRETCH_MAX_X8
REG_FIELD_PREP(IVB_SPR_STRETCH_MAX_MASK, 0)
+#define IVB_SPR_STRETCH_MAX_X4
REG_FIELD_PREP(IVB_SPR_STRETCH_MAX_MASK, 1)
+#define IVB_SPR_STRETCH_MAX_X2
REG_FIELD_PREP(IVB_SPR_STRETCH_MAX_MASK, 2)
+#define IVB_SPR_STRETCH_MAX_X1
REG_FIELD_PREP(IVB_SPR_STRETCH_MAX_MASK, 3)
/*
@@ -8042,6 +8053,16 @@ enum {
#define _CHICKEN_PIPESL_1_A0x420b0
#define _CHICKEN_PIPESL_1_B0x420b4
+#define HSW_PRI_STRETCH_MAX_MASK REG_GENMASK(28, 27)
+#define HSW_PRI_STRETCH_MAX_X8
REG_FIELD_PREP(HSW_PRI_STRETCH_MAX_MASK, 0)
+#define HSW_PRI_STRETCH_MAX_X4
REG_FIELD_PREP(HSW_PRI_STRETCH_MAX_MASK, 1)
+#define HSW_PRI_STRETCH_MAX_X2
REG_FIELD_PREP(HSW_PRI_STRETCH_MAX_MASK, 2)
+#define HSW_PRI_STRETCH_MAX_X1
REG_FIELD_PREP(HSW_PRI_STRETCH_MAX_MASK, 3)
+#define HSW_SPR_STRETCH_MAX_MASK REG_GENMASK(26, 25)
+#define HSW_SPR_STRETCH_MAX_X8
REG_FIELD_PREP(HSW_SPR_STRETCH_MAX_MASK, 0)
+#define HSW_SPR_STRETCH_MAX_X4
REG_FIELD_PREP(HSW_SPR_STRETCH_MAX_MASK, 1)
+#define HSW_SPR_STRETCH_MAX_X2
REG_FIELD_PREP(HSW_SPR_STRETCH_MAX_MASK, 2)
+#define HSW_SPR_STRETCH_MAX_X1
REG_FIELD_PREP(HSW_SPR_STRETCH_MAX_MASK, 3)
#define HSW_FBCQ_DIS (1 << 22)
#define BDW_DPRS_MASK_VBLANK_SRD (1 << 0)
#define CHICKEN_PIPESL_1(pipe) _MMIO_PIPE(pipe, _CHICKEN_PIPESL_1_A,
_CHICKEN_PIPESL_1_B)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 8cc67f9c4e58..53b04800f9d0 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -7243,11 +7243,16 @@ static void bdw_init_clock_gating(struct
drm_i915_private *dev_priv)
intel_uncore_write(&dev_priv->uncore, CHICKEN_PAR1_1,
intel_uncore_read(&dev_priv->uncore, CHICKEN_PAR1_1) |
DPA_MASK_VBLANK_SRD);
- /* WaPsrDPRSUnmaskVBlankInSRD:bdw */
for_each_pipe(dev_priv, pipe) {
+ /* WaPsrDPRSUnmaskVBlankInSRD:bdw */
intel_uncore_write(&dev_priv->uncore, CHICKEN_PIPESL_1(pipe),
intel_uncore_read(&dev_priv->uncore,
CHICKEN_PIPESL_1(pipe)) |
BDW_DPRS_MASK_VBLANK_SRD);
+
+ /* Undocumented but fixes async flip + VT-d corruption */
+ if (intel_vtd_active())
+ intel_uncore_rmw(&dev_priv->uncore,
CHICKEN_PIPESL_1(pipe),
+HSW_PRI_STRETCH_MAX_MASK,
HSW_PRI_STRETCH_MAX_X1);
}
/* WaVSRefCountFullforceMissDisable:bdw */
@@ -7283,11 +7288,20 @@ static void bdw_init_clock_gating(struct
drm_i915_private *dev_priv)
static void hsw_init_clock_gating(struct drm_i915_private *dev_priv)
{
+ enum pipe
[Intel-gfx] [PATCH] drm/i915: Refine VT-d scanout workaround
VT-d may cause overfetch of the scanout PTE, both before and after the
vma (depending on the scanout orientation). bspec recommends that we
provide a tile-row in either directions, and suggests using 168 PTE,
warning that the accesses will wrap around the ends of the GGTT.
Currently, we fill the entire GGTT with scratch pages when using VT-d to
always ensure there are valid entries around every vma, including
scanout. However, writing every PTE is slow as on recent devices we
perform 8MiB of uncached writes, incurring an extra 100ms during resume.
If instead we focus on only putting guard pages around scanout, we can
avoid touching the whole GGTT. To avoid having to introduce extra nodes
around each scanout vma, we adjust the scanout drm_mm_node to be smaller
than the allocated space, and fixup the extra PTE during dma binding.
v2: Move the guard from modifying drm_mm_node.start which is still used
by the drm_mm itself, into an adjustment of node.start at the point of
use.
v3: Pass the requested guard padding from the caller, so we can drop the
VT-d w/a knowledge from the i915_vma allocator.
v4: Bump minimum padding to 168 PTE and cautiously ensure that a full
tile row around the vma is included with the guard.
Signed-off-by: Chris Wilson
Cc: Ville Syrjälä
Cc: Matthew Auld
Cc: Imre Deak
Reviewed-by: Matthew Auld
---
drivers/gpu/drm/i915/gem/i915_gem_domain.c | 13 +++
drivers/gpu/drm/i915/gt/intel_ggtt.c | 25 +-
drivers/gpu/drm/i915/i915_gem_gtt.h| 1 +
drivers/gpu/drm/i915/i915_vma.c| 8 +++
4 files changed, 23 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_domain.c
b/drivers/gpu/drm/i915/gem/i915_gem_domain.c
index 0478b069c202..32b13af0d3df 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_domain.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_domain.c
@@ -16,6 +16,8 @@
#include "i915_gem_lmem.h"
#include "i915_gem_mman.h"
+#define VTD_GUARD (168u * I915_GTT_PAGE_SIZE) /* 168 or tile-row PTE padding */
+
static bool gpu_write_needs_clflush(struct drm_i915_gem_object *obj)
{
return !(obj->cache_level == I915_CACHE_NONE ||
@@ -345,6 +347,17 @@ i915_gem_object_pin_to_display_plane(struct
drm_i915_gem_object *obj,
if (ret)
goto err;
+ /* VT-d may overfetch before/after the vma, so pad with scratch */
+ if (intel_scanout_needs_vtd_wa(i915)) {
+ unsigned int guard = VTD_GUARD;
+
+ if (i915_gem_object_is_tiled(obj))
+ guard = max(guard,
+ i915_gem_object_get_tile_row_size(obj));
+
+ flags |= PIN_OFFSET_GUARD | guard;
+ }
+
/*
* As the user may map the buffer once pinned in the display plane
* (e.g. libkms for the bootup splash), we have to ensure that we
diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt.c
b/drivers/gpu/drm/i915/gt/intel_ggtt.c
index 6b326138e765..251b50884d1c 100644
--- a/drivers/gpu/drm/i915/gt/intel_ggtt.c
+++ b/drivers/gpu/drm/i915/gt/intel_ggtt.c
@@ -319,27 +319,6 @@ static void nop_clear_range(struct i915_address_space *vm,
{
}
-static void gen8_ggtt_clear_range(struct i915_address_space *vm,
- u64 start, u64 length)
-{
- struct i915_ggtt *ggtt = i915_vm_to_ggtt(vm);
- unsigned int first_entry = start / I915_GTT_PAGE_SIZE;
- unsigned int num_entries = length / I915_GTT_PAGE_SIZE;
- const gen8_pte_t scratch_pte = vm->scratch[0]->encode;
- gen8_pte_t __iomem *gtt_base =
- (gen8_pte_t __iomem *)ggtt->gsm + first_entry;
- const int max_entries = ggtt_total_entries(ggtt) - first_entry;
- int i;
-
- if (WARN(num_entries > max_entries,
-"First entry = %d; Num entries = %d (max=%d)\n",
-first_entry, num_entries, max_entries))
- num_entries = max_entries;
-
- for (i = 0; i < num_entries; i++)
- gen8_set_pte(>t_base[i], scratch_pte);
-}
-
static void bxt_vtd_ggtt_wa(struct i915_address_space *vm)
{
/*
@@ -907,8 +886,6 @@ static int gen8_gmch_probe(struct i915_ggtt *ggtt)
ggtt->vm.cleanup = gen6_gmch_remove;
ggtt->vm.insert_page = gen8_ggtt_insert_page;
ggtt->vm.clear_range = nop_clear_range;
- if (intel_scanout_needs_vtd_wa(i915))
- ggtt->vm.clear_range = gen8_ggtt_clear_range;
ggtt->vm.insert_entries = gen8_ggtt_insert_entries;
@@ -1054,7 +1031,7 @@ static int gen6_gmch_probe(struct i915_ggtt *ggtt)
ggtt->vm.alloc_pt_dma = alloc_pt_dma;
ggtt->vm.clear_range = nop_clear_range;
- if (!HAS_FULL_PPGTT(i915) || intel_scanout_needs_vtd_wa(i915))
+ if (!HAS_FULL_PPGTT(i915))
ggtt->vm.clear_range = gen6_ggtt_clear_range;
ggtt->vm.insert_page = gen6_ggtt_insert_page;
ggtt->vm.insert_entries = gen6_ggtt_insert_entries;
diff --git a/drivers/gpu/drm/
[Intel-gfx] [PATCH] drm/i915: Refine VT-d scanout workaround
VT-d may cause overfetch of the scanout PTE, both before and after the
vma (depending on the scanout orientation). bspec recommends that we
provide a tile-row in either directions, and suggests using 168 PTE,
warning that the accesses will wrap around the ends of the GGTT.
Currently, we fill the entire GGTT with scratch pages when using VT-d to
always ensure there are valid entries around every vma, including
scanout. However, writing every PTE is slow as on recent devices we
perform 8MiB of uncached writes, incurring an extra 100ms during resume.
If instead we focus on only putting guard pages around scanout, we can
avoid touching the whole GGTT. To avoid having to introduce extra nodes
around each scanout vma, we adjust the scanout drm_mm_node to be smaller
than the allocated space, and fixup the extra PTE during dma binding.
v2: Move the guard from modifying drm_mm_node.start which is still used
by the drm_mm itself, into an adjustment of node.start at the point of
use.
v3: Pass the requested guard padding from the caller, so we can drop the
VT-d w/a knowledge from the i915_vma allocator.
v4: Bump minimum padding to 168 PTE and cautiously ensure that a full
tile row around the vma is included with the guard.
Signed-off-by: Chris Wilson
Cc: Ville Syrjälä
Cc: Matthew Auld
Cc: Imre Deak
Reviewed-by: Matthew Auld
---
drivers/gpu/drm/i915/gem/i915_gem_domain.c | 13 +++
drivers/gpu/drm/i915/gt/intel_ggtt.c | 25 +-
drivers/gpu/drm/i915/i915_gem_gtt.h| 1 +
drivers/gpu/drm/i915/i915_vma.c| 8 +++
4 files changed, 23 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_domain.c
b/drivers/gpu/drm/i915/gem/i915_gem_domain.c
index 0478b069c202..32b13af0d3df 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_domain.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_domain.c
@@ -16,6 +16,8 @@
#include "i915_gem_lmem.h"
#include "i915_gem_mman.h"
+#define VTD_GUARD (168u * I915_GTT_PAGE_SIZE) /* 168 or tile-row PTE padding */
+
static bool gpu_write_needs_clflush(struct drm_i915_gem_object *obj)
{
return !(obj->cache_level == I915_CACHE_NONE ||
@@ -345,6 +347,17 @@ i915_gem_object_pin_to_display_plane(struct
drm_i915_gem_object *obj,
if (ret)
goto err;
+ /* VT-d may overfetch before/after the vma, so pad with scratch */
+ if (intel_scanout_needs_vtd_wa(i915)) {
+ unsigned int guard = VTD_GUARD;
+
+ if (i915_gem_object_is_tiled(obj))
+ guard = max(guard,
+ i915_gem_object_get_tile_row_size(obj));
+
+ flags |= PIN_OFFSET_GUARD | guard;
+ }
+
/*
* As the user may map the buffer once pinned in the display plane
* (e.g. libkms for the bootup splash), we have to ensure that we
diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt.c
b/drivers/gpu/drm/i915/gt/intel_ggtt.c
index 6b326138e765..251b50884d1c 100644
--- a/drivers/gpu/drm/i915/gt/intel_ggtt.c
+++ b/drivers/gpu/drm/i915/gt/intel_ggtt.c
@@ -319,27 +319,6 @@ static void nop_clear_range(struct i915_address_space *vm,
{
}
-static void gen8_ggtt_clear_range(struct i915_address_space *vm,
- u64 start, u64 length)
-{
- struct i915_ggtt *ggtt = i915_vm_to_ggtt(vm);
- unsigned int first_entry = start / I915_GTT_PAGE_SIZE;
- unsigned int num_entries = length / I915_GTT_PAGE_SIZE;
- const gen8_pte_t scratch_pte = vm->scratch[0]->encode;
- gen8_pte_t __iomem *gtt_base =
- (gen8_pte_t __iomem *)ggtt->gsm + first_entry;
- const int max_entries = ggtt_total_entries(ggtt) - first_entry;
- int i;
-
- if (WARN(num_entries > max_entries,
-"First entry = %d; Num entries = %d (max=%d)\n",
-first_entry, num_entries, max_entries))
- num_entries = max_entries;
-
- for (i = 0; i < num_entries; i++)
- gen8_set_pte(>t_base[i], scratch_pte);
-}
-
static void bxt_vtd_ggtt_wa(struct i915_address_space *vm)
{
/*
@@ -907,8 +886,6 @@ static int gen8_gmch_probe(struct i915_ggtt *ggtt)
ggtt->vm.cleanup = gen6_gmch_remove;
ggtt->vm.insert_page = gen8_ggtt_insert_page;
ggtt->vm.clear_range = nop_clear_range;
- if (intel_scanout_needs_vtd_wa(i915))
- ggtt->vm.clear_range = gen8_ggtt_clear_range;
ggtt->vm.insert_entries = gen8_ggtt_insert_entries;
@@ -1054,7 +1031,7 @@ static int gen6_gmch_probe(struct i915_ggtt *ggtt)
ggtt->vm.alloc_pt_dma = alloc_pt_dma;
ggtt->vm.clear_range = nop_clear_range;
- if (!HAS_FULL_PPGTT(i915) || intel_scanout_needs_vtd_wa(i915))
+ if (!HAS_FULL_PPGTT(i915))
ggtt->vm.clear_range = gen6_ggtt_clear_range;
ggtt->vm.insert_page = gen6_ggtt_insert_page;
ggtt->vm.insert_entries = gen6_ggtt_insert_entries;
diff --git a/drivers/gpu/drm/
[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Workaround async flip + VT-d corruption on HSW/BDW
== Series Details ==
Series: drm/i915: Workaround async flip + VT-d corruption on HSW/BDW
URL : https://patchwork.freedesktop.org/series/87255/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9791 -> Patchwork_19707
Summary
---
**SUCCESS**
No regressions found.
External URL:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19707/index.html
Known issues
Here are the changes found in Patchwork_19707 that come from known issues:
### IGT changes ###
Issues hit
* igt@amdgpu/amd_basic@query-info:
- fi-tgl-y: NOTRUN -> [SKIP][1] ([fdo#109315])
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19707/fi-tgl-y/igt@amdgpu/amd_ba...@query-info.html
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-y: [PASS][2] -> [DMESG-WARN][3] ([i915#2411] /
[i915#402])
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-tgl-y/igt@gem_exec_susp...@basic-s3.html
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19707/fi-tgl-y/igt@gem_exec_susp...@basic-s3.html
* igt@gem_flink_basic@basic:
- fi-tgl-y: [PASS][4] -> [DMESG-WARN][5] ([i915#402]) +2 similar
issues
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-tgl-y/igt@gem_flink_ba...@basic.html
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19707/fi-tgl-y/igt@gem_flink_ba...@basic.html
* igt@i915_module_load@reload:
- fi-tgl-y: [PASS][6] -> [DMESG-WARN][7] ([i915#1982] /
[k.org#205379])
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-tgl-y/igt@i915_module_l...@reload.html
[7]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19707/fi-tgl-y/igt@i915_module_l...@reload.html
* igt@i915_pm_rpm@module-reload:
- fi-kbl-guc: [PASS][8] -> [FAIL][9] ([i915#2203] / [i915#579])
[8]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-kbl-guc/igt@i915_pm_...@module-reload.html
[9]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19707/fi-kbl-guc/igt@i915_pm_...@module-reload.html
Possible fixes
* igt@fbdev@read:
- fi-tgl-y: [DMESG-WARN][10] ([i915#402]) -> [PASS][11] +2
similar issues
[10]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-tgl-y/igt@fb...@read.html
[11]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19707/fi-tgl-y/igt@fb...@read.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1222]: https://gitlab.freedesktop.org/drm/intel/issues/1222
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579
[k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379
Participating hosts (45 -> 39)
--
Additional (1): fi-ehl-2
Missing(7): fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-bsw-cyan
fi-ctg-p8600 fi-bsw-nick fi-bdw-samus
Build changes
-
* Linux: CI_DRM_9791 -> Patchwork_19707
CI-20190529: 20190529
CI_DRM_9791: c1991e1c98008d13d9773744a9f9da0884644917 @
git://anongit.freedesktop.org/gfx-ci/linux
IGT_6009: a4dccf189b34a55338feec9927dac57c467c4100 @
git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19707: 1babc2a37be11e239bb41298cb84d7332b970d1a @
git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
1babc2a37be1 drm/i915: Workaround async flip + VT-d corruption on HSW/BDW
== Logs ==
For more details see:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19707/index.html
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH] drm/i915/guc: Keep strict GuC ABI definitions separate
Our fwif.h file is now mix of strict firmware ABI definitions and
set of our helpers. In anticipation of upcoming changes to the GuC
interface try to keep them separate in smaller maintainable files.
Signed-off-by: Michal Wajdeczko
Cc: Daniele Ceraolo Spurio
Cc: John Harrison
Cc: Jon Ewins
---
.../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 55
.../gt/uc/abi/guc_communication_ctb_abi.h | 106
.../gt/uc/abi/guc_communication_mmio_abi.h| 52
.../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h | 14 +
.../drm/i915/gt/uc/abi/guc_log_buffer_abi.h | 56
.../gpu/drm/i915/gt/uc/abi/guc_messages_abi.h | 21 ++
drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h | 257 +-
7 files changed, 312 insertions(+), 249 deletions(-)
create mode 100644 drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h
create mode 100644 drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h
create mode 100644 drivers/gpu/drm/i915/gt/uc/abi/guc_communication_mmio_abi.h
create mode 100644 drivers/gpu/drm/i915/gt/uc/abi/guc_errors_abi.h
create mode 100644 drivers/gpu/drm/i915/gt/uc/abi/guc_log_buffer_abi.h
create mode 100644 drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h
diff --git a/drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h
b/drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h
new file mode 100644
index ..665e051afd01
--- /dev/null
+++ b/drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h
@@ -0,0 +1,55 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2014-2021 Intel Corporation
+ */
+
+#ifndef _ABI_GUC_ACTIONS_ABI_H
+#define _ABI_GUC_ACTIONS_ABI_H
+
+enum intel_guc_action {
+ INTEL_GUC_ACTION_DEFAULT = 0x0,
+ INTEL_GUC_ACTION_REQUEST_PREEMPTION = 0x2,
+ INTEL_GUC_ACTION_REQUEST_ENGINE_RESET = 0x3,
+ INTEL_GUC_ACTION_ALLOCATE_DOORBELL = 0x10,
+ INTEL_GUC_ACTION_DEALLOCATE_DOORBELL = 0x20,
+ INTEL_GUC_ACTION_LOG_BUFFER_FILE_FLUSH_COMPLETE = 0x30,
+ INTEL_GUC_ACTION_UK_LOG_ENABLE_LOGGING = 0x40,
+ INTEL_GUC_ACTION_FORCE_LOG_BUFFER_FLUSH = 0x302,
+ INTEL_GUC_ACTION_ENTER_S_STATE = 0x501,
+ INTEL_GUC_ACTION_EXIT_S_STATE = 0x502,
+ INTEL_GUC_ACTION_SLPC_REQUEST = 0x3003,
+ INTEL_GUC_ACTION_SAMPLE_FORCEWAKE = 0x3005,
+ INTEL_GUC_ACTION_AUTHENTICATE_HUC = 0x4000,
+ INTEL_GUC_ACTION_REGISTER_COMMAND_TRANSPORT_BUFFER = 0x4505,
+ INTEL_GUC_ACTION_DEREGISTER_COMMAND_TRANSPORT_BUFFER = 0x4506,
+ INTEL_GUC_ACTION_LIMIT
+};
+
+enum intel_guc_preempt_options {
+ INTEL_GUC_PREEMPT_OPTION_DROP_WORK_Q = 0x4,
+ INTEL_GUC_PREEMPT_OPTION_DROP_SUBMIT_Q = 0x8,
+};
+
+enum intel_guc_report_status {
+ INTEL_GUC_REPORT_STATUS_UNKNOWN = 0x0,
+ INTEL_GUC_REPORT_STATUS_ACKED = 0x1,
+ INTEL_GUC_REPORT_STATUS_ERROR = 0x2,
+ INTEL_GUC_REPORT_STATUS_COMPLETE = 0x4,
+};
+
+enum intel_guc_sleep_state_status {
+ INTEL_GUC_SLEEP_STATE_SUCCESS = 0x1,
+ INTEL_GUC_SLEEP_STATE_PREEMPT_TO_IDLE_FAILED = 0x2,
+ INTEL_GUC_SLEEP_STATE_ENGINE_RESET_FAILED = 0x3
+#define INTEL_GUC_SLEEP_STATE_INVALID_MASK 0x8000
+};
+
+#define GUC_LOG_CONTROL_LOGGING_ENABLED(1 << 0)
+#define GUC_LOG_CONTROL_VERBOSITY_SHIFT4
+#define GUC_LOG_CONTROL_VERBOSITY_MASK (0xF << GUC_LOG_CONTROL_VERBOSITY_SHIFT)
+#define GUC_LOG_CONTROL_DEFAULT_LOGGING(1 << 8)
+
+#define GUC_FORCEWAKE_RENDER (1 << 0)
+#define GUC_FORCEWAKE_MEDIA(1 << 1)
+
+#endif /* _ABI_GUC_ACTIONS_ABI_H */
diff --git a/drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h
b/drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h
new file mode 100644
index ..ebd8c3e0e4bb
--- /dev/null
+++ b/drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h
@@ -0,0 +1,106 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2014-2021 Intel Corporation
+ */
+
+#ifndef _ABI_GUC_COMMUNICATION_CTB_ABI_H
+#define _ABI_GUC_COMMUNICATION_CTB_ABI_H
+
+#include
+
+/**
+ * DOC: CTB based communication
+ *
+ * The CTB (command transport buffer) communication between Host and GuC
+ * is based on u32 data stream written to the shared buffer. One buffer can
+ * be used to transmit data only in one direction (one-directional channel).
+ *
+ * Current status of the each buffer is stored in the buffer descriptor.
+ * Buffer descriptor holds tail and head fields that represents active data
+ * stream. The tail field is updated by the data producer (sender), and head
+ * field is updated by the data consumer (receiver)::
+ *
+ * ++
+ * | DESCRIPTOR | +=+++
+ * ++ | | MESSAGE(s) ||
+ * | address|->+=+++
+ * ++
+ * | head | ^-head^
+ * ++
+ * | tail | ^-tail-^
+ * ++
+ * | size |
[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Wrap all access to i915_vma.node.start|size (rev5)
== Series Details ==
Series: series starting with [1/3] drm/i915: Wrap all access to
i915_vma.node.start|size (rev5)
URL : https://patchwork.freedesktop.org/series/87102/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9791 -> Patchwork_19708
Summary
---
**SUCCESS**
No regressions found.
External URL:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/index.html
Known issues
Here are the changes found in Patchwork_19708 that come from known issues:
### IGT changes ###
Issues hit
* igt@amdgpu/amd_basic@semaphore:
- fi-bsw-nick:NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/fi-bsw-nick/igt@amdgpu/amd_ba...@semaphore.html
* igt@amdgpu/amd_basic@userptr:
- fi-byt-j1900: NOTRUN -> [SKIP][2] ([fdo#109271]) +17 similar issues
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/fi-byt-j1900/igt@amdgpu/amd_ba...@userptr.html
* igt@debugfs_test@read_all_entries:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#1982] /
[i915#402])
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-tgl-y/igt@debugfs_test@read_all_entries.html
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/fi-tgl-y/igt@debugfs_test@read_all_entries.html
* igt@gem_tiled_blits@basic:
- fi-tgl-y: [PASS][5] -> [DMESG-WARN][6] ([i915#402]) +1 similar
issue
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-tgl-y/igt@gem_tiled_bl...@basic.html
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/fi-tgl-y/igt@gem_tiled_bl...@basic.html
Possible fixes
* igt@fbdev@read:
- fi-tgl-y: [DMESG-WARN][7] ([i915#402]) -> [PASS][8] +2 similar
issues
[7]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-tgl-y/igt@fb...@read.html
[8]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/fi-tgl-y/igt@fb...@read.html
* igt@i915_pm_rpm@module-reload:
- fi-byt-j1900: [INCOMPLETE][9] ([i915#142] / [i915#2405]) ->
[PASS][10]
[9]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-byt-j1900/igt@i915_pm_...@module-reload.html
[10]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/fi-byt-j1900/igt@i915_pm_...@module-reload.html
* igt@i915_selftest@live@execlists:
- fi-bsw-nick:[INCOMPLETE][11] ([i915#2940]) -> [PASS][12]
[11]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-bsw-nick/igt@i915_selftest@l...@execlists.html
[12]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/fi-bsw-nick/igt@i915_selftest@l...@execlists.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1222]: https://gitlab.freedesktop.org/drm/intel/issues/1222
[i915#142]: https://gitlab.freedesktop.org/drm/intel/issues/142
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Participating hosts (45 -> 41)
--
Additional (1): fi-ehl-2
Missing(5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600
fi-bdw-samus
Build changes
-
* Linux: CI_DRM_9791 -> Patchwork_19708
CI-20190529: 20190529
CI_DRM_9791: c1991e1c98008d13d9773744a9f9da0884644917 @
git://anongit.freedesktop.org/gfx-ci/linux
IGT_6009: a4dccf189b34a55338feec9927dac57c467c4100 @
git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19708: 2cf0b46b2c988b75a357e85370df2ce4e8367684 @
git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
2cf0b46b2c98 drm/i915: Refine VT-d scanout workaround
cb68bc3ad306 drm/i915: Introduce guard pages to i915_vma
20e692ab64dc drm/i915: Wrap all access to i915_vma.node.start|size
== Logs ==
For more details see:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/index.html
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Keep strict GuC ABI definitions separate
== Series Details == Series: drm/i915/guc: Keep strict GuC ABI definitions separate URL : https://patchwork.freedesktop.org/series/87256/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1e8af930db8a drm/i915/guc: Keep strict GuC ABI definitions separate -:16: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 601 lines checked ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc: Keep strict GuC ABI definitions separate
== Series Details ==
Series: drm/i915/guc: Keep strict GuC ABI definitions separate
URL : https://patchwork.freedesktop.org/series/87256/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9791 -> Patchwork_19709
Summary
---
**FAILURE**
Serious unknown changes coming with Patchwork_19709 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_19709, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19709/index.html
Possible new issues
---
Here are the unknown changes that may have been introduced in Patchwork_19709:
### IGT changes ###
Possible regressions
* igt@i915_selftest@live@hangcheck:
- fi-snb-2600:[PASS][1] -> [DMESG-FAIL][2]
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-snb-2600/igt@i915_selftest@l...@hangcheck.html
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19709/fi-snb-2600/igt@i915_selftest@l...@hangcheck.html
Known issues
Here are the changes found in Patchwork_19709 that come from known issues:
### IGT changes ###
Issues hit
* igt@amdgpu/amd_basic@query-info:
- fi-tgl-y: NOTRUN -> [SKIP][3] ([fdo#109315])
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19709/fi-tgl-y/igt@amdgpu/amd_ba...@query-info.html
* igt@amdgpu/amd_basic@userptr:
- fi-byt-j1900: NOTRUN -> [SKIP][4] ([fdo#109271]) +17 similar issues
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19709/fi-byt-j1900/igt@amdgpu/amd_ba...@userptr.html
* igt@debugfs_test@read_all_entries:
- fi-tgl-y: [PASS][5] -> [DMESG-WARN][6] ([i915#402]) +2 similar
issues
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-tgl-y/igt@debugfs_test@read_all_entries.html
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19709/fi-tgl-y/igt@debugfs_test@read_all_entries.html
* igt@i915_pm_rpm@module-reload:
- fi-kbl-7500u: [PASS][7] -> [DMESG-WARN][8] ([i915#2605])
[7]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-kbl-7500u/igt@i915_pm_...@module-reload.html
[8]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19709/fi-kbl-7500u/igt@i915_pm_...@module-reload.html
* igt@i915_selftest@live@late_gt_pm:
- fi-snb-2600:[PASS][9] -> [SKIP][10] ([fdo#109271]) +3 similar
issues
[9]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-snb-2600/igt@i915_selftest@live@late_gt_pm.html
[10]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19709/fi-snb-2600/igt@i915_selftest@live@late_gt_pm.html
* igt@runner@aborted:
- fi-snb-2600:NOTRUN -> [FAIL][11] ([i915#698])
[11]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19709/fi-snb-2600/igt@run...@aborted.html
Possible fixes
* igt@fbdev@read:
- fi-tgl-y: [DMESG-WARN][12] ([i915#402]) -> [PASS][13] +2
similar issues
[12]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-tgl-y/igt@fb...@read.html
[13]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19709/fi-tgl-y/igt@fb...@read.html
* igt@i915_pm_rpm@module-reload:
- fi-byt-j1900: [INCOMPLETE][14] ([i915#142] / [i915#2405]) ->
[PASS][15]
[14]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-byt-j1900/igt@i915_pm_...@module-reload.html
[15]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19709/fi-byt-j1900/igt@i915_pm_...@module-reload.html
Warnings
* igt@runner@aborted:
- fi-bsw-nick:[FAIL][16] ([i915#1436]) -> [FAIL][17] ([i915#1436] /
[i915#2722])
[16]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-bsw-nick/igt@run...@aborted.html
[17]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19709/fi-bsw-nick/igt@run...@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1222]: https://gitlab.freedesktop.org/drm/intel/issues/1222
[i915#142]: https://gitlab.freedesktop.org/drm/intel/issues/142
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
[i915#2605]: https://gitlab.freedesktop.org/drm/intel/issues/2605
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#402]: https://gitlab.freedesktop.or
[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Workaround async flip + VT-d corruption on HSW/BDW
== Series Details == Series: drm/i915: Workaround async flip + VT-d corruption on HSW/BDW URL : https://patchwork.freedesktop.org/series/87255/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9791_full -> Patchwork_19707_full Summary --- **FAILURE** Serious unknown changes coming with Patchwork_19707_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_19707_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues --- Here are the unknown changes that may have been introduced in Patchwork_19707_full: ### IGT changes ### Possible regressions * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite: - shard-kbl: NOTRUN -> [DMESG-WARN][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19707/shard-kbl7/igt@kms_frontbuffer_track...@fbc-rgb565-draw-pwrite.html Warnings * igt@runner@aborted: - shard-kbl: ([FAIL][2], [FAIL][3], [FAIL][4]) ([i915#1814] / [i915#2505] / [i915#92]) -> ([FAIL][5], [FAIL][6], [FAIL][7]) ([i915#3002]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-kbl1/igt@run...@aborted.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-kbl1/igt@run...@aborted.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-kbl6/igt@run...@aborted.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19707/shard-kbl2/igt@run...@aborted.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19707/shard-kbl7/igt@run...@aborted.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19707/shard-kbl2/igt@run...@aborted.html - shard-skl: ([FAIL][8], [FAIL][9]) ([i915#3002]) -> ([FAIL][10], [FAIL][11], [FAIL][12], [FAIL][13]) ([i915#2029] / [i915#2426] / [i915#3002]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-skl7/igt@run...@aborted.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-skl8/igt@run...@aborted.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19707/shard-skl5/igt@run...@aborted.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19707/shard-skl3/igt@run...@aborted.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19707/shard-skl3/igt@run...@aborted.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19707/shard-skl7/igt@run...@aborted.html Known issues Here are the changes found in Patchwork_19707_full that come from known issues: ### IGT changes ### Issues hit * igt@feature_discovery@psr2: - shard-iclb: [PASS][14] -> [SKIP][15] ([i915#658]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-iclb2/igt@feature_discov...@psr2.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19707/shard-iclb5/igt@feature_discov...@psr2.html * igt@gem_create@create-massive: - shard-kbl: NOTRUN -> [DMESG-WARN][16] ([i915#3002]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19707/shard-kbl2/igt@gem_cre...@create-massive.html - shard-apl: NOTRUN -> [DMESG-WARN][17] ([i915#3002]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19707/shard-apl6/igt@gem_cre...@create-massive.html * igt@gem_ctx_persistence@smoketest: - shard-snb: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#1099]) +4 similar issues [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19707/shard-snb6/igt@gem_ctx_persiste...@smoketest.html * igt@gem_eio@unwedge-stress: - shard-tglb: [PASS][19] -> [TIMEOUT][20] ([i915#3063]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-tglb8/igt@gem_...@unwedge-stress.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19707/shard-tglb8/igt@gem_...@unwedge-stress.html * igt@gem_exec_fair@basic-none@vcs1: - shard-iclb: NOTRUN -> [FAIL][21] ([i915#2842]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19707/shard-iclb4/igt@gem_exec_fair@basic-n...@vcs1.html - shard-kbl: NOTRUN -> [FAIL][22] ([i915#2842]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19707/shard-kbl1/igt@gem_exec_fair@basic-n...@vcs1.html * igt@gem_exec_fair@basic-none@vecs0: - shard-apl: [PASS][23] -> [FAIL][24] ([i915#2842]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-apl7/igt@gem_exec_fair@basic-n...@vecs0.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19707/shard-apl2/igt@gem_exec_fair@basic-n...@vecs0.html * igt@gem_exec_fair@basic-pace@rcs0: - shard-kbl: [PASS][25] -> [SKIP][26] ([fdo#109271]) +1 similar issue [25]: https://intel-gfx-ci.01.org/tree/drm-tip
[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915: Wrap all access to i915_vma.node.start|size (rev5)
== Series Details == Series: series starting with [1/3] drm/i915: Wrap all access to i915_vma.node.start|size (rev5) URL : https://patchwork.freedesktop.org/series/87102/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9791_full -> Patchwork_19708_full Summary --- **FAILURE** Serious unknown changes coming with Patchwork_19708_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_19708_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues --- Here are the unknown changes that may have been introduced in Patchwork_19708_full: ### IGT changes ### Possible regressions * igt@gem_mmap_gtt@fault-concurrent-y: - shard-snb: [PASS][1] -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-snb7/igt@gem_mmap_...@fault-concurrent-y.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/shard-snb5/igt@gem_mmap_...@fault-concurrent-y.html Warnings * igt@runner@aborted: - shard-kbl: ([FAIL][3], [FAIL][4], [FAIL][5]) ([i915#1814] / [i915#2505] / [i915#92]) -> ([FAIL][6], [FAIL][7]) ([i915#1436]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-kbl1/igt@run...@aborted.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-kbl1/igt@run...@aborted.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-kbl6/igt@run...@aborted.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/shard-kbl1/igt@run...@aborted.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/shard-kbl1/igt@run...@aborted.html - shard-apl: ([FAIL][8], [FAIL][9]) -> ([FAIL][10], [FAIL][11], [FAIL][12], [FAIL][13]) ([i915#1814] / [i915#3002]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-apl8/igt@run...@aborted.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-apl8/igt@run...@aborted.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/shard-apl7/igt@run...@aborted.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/shard-apl6/igt@run...@aborted.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/shard-apl8/igt@run...@aborted.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/shard-apl1/igt@run...@aborted.html - shard-skl: ([FAIL][14], [FAIL][15]) ([i915#3002]) -> ([FAIL][16], [FAIL][17], [FAIL][18], [FAIL][19]) ([i915#1436] / [i915#2426] / [i915#3002]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-skl7/igt@run...@aborted.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-skl8/igt@run...@aborted.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/shard-skl1/igt@run...@aborted.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/shard-skl3/igt@run...@aborted.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/shard-skl6/igt@run...@aborted.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/shard-skl10/igt@run...@aborted.html Known issues Here are the changes found in Patchwork_19708_full that come from known issues: ### IGT changes ### Issues hit * igt@feature_discovery@psr2: - shard-iclb: [PASS][20] -> [SKIP][21] ([i915#658]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-iclb2/igt@feature_discov...@psr2.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/shard-iclb4/igt@feature_discov...@psr2.html * igt@gem_create@create-massive: - shard-apl: NOTRUN -> [DMESG-WARN][22] ([i915#3002]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/shard-apl7/igt@gem_cre...@create-massive.html * igt@gem_ctx_isolation@preservation-s3@vcs0: - shard-kbl: NOTRUN -> [DMESG-WARN][23] ([i915#180]) +2 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/shard-kbl1/igt@gem_ctx_isolation@preservation...@vcs0.html * igt@gem_ctx_persistence@smoketest: - shard-snb: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#1099]) +3 similar issues [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/shard-snb2/igt@gem_ctx_persiste...@smoketest.html * igt@gem_eio@unwedge-stress: - shard-tglb: [PASS][25] -> [TIMEOUT][26] ([i915#3063]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-tglb8/igt@gem_...@unwedge-stress.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19708/shard-tglb6/igt@gem_...@unwedge-stress.html * igt@gem_exec_fair@basic-none-rrul@rcs0: - shard-glk: [PASS][27] -> [FAIL
[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Keep strict GuC ABI definitions separate (rev2)
== Series Details == Series: drm/i915/guc: Keep strict GuC ABI definitions separate (rev2) URL : https://patchwork.freedesktop.org/series/87256/ State : warning == Summary == $ dim checkpatch origin/drm-tip 222321649ab1 drm/i915/guc: Keep strict GuC ABI definitions separate -:16: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 601 lines checked ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Keep strict GuC ABI definitions separate (rev2)
== Series Details ==
Series: drm/i915/guc: Keep strict GuC ABI definitions separate (rev2)
URL : https://patchwork.freedesktop.org/series/87256/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9791 -> Patchwork_19710
Summary
---
**SUCCESS**
No regressions found.
External URL:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/index.html
Known issues
Here are the changes found in Patchwork_19710 that come from known issues:
### IGT changes ###
Issues hit
* igt@amdgpu/amd_basic@semaphore:
- fi-bsw-nick:NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/fi-bsw-nick/igt@amdgpu/amd_ba...@semaphore.html
* igt@amdgpu/amd_basic@userptr:
- fi-byt-j1900: NOTRUN -> [SKIP][2] ([fdo#109271]) +17 similar issues
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/fi-byt-j1900/igt@amdgpu/amd_ba...@userptr.html
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-u2: [PASS][3] -> [FAIL][4] ([i915#1888])
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-tgl-u2/igt@gem_exec_susp...@basic-s0.html
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/fi-tgl-u2/igt@gem_exec_susp...@basic-s0.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-bsw-nick:[PASS][5] -> [DMESG-FAIL][6] ([i915#2675] /
[i915#541])
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-bsw-nick/igt@i915_selftest@live@gt_heartbeat.html
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/fi-bsw-nick/igt@i915_selftest@live@gt_heartbeat.html
* igt@prime_vgem@basic-fence-flip:
- fi-tgl-y: [PASS][7] -> [DMESG-WARN][8] ([i915#402]) +2 similar
issues
[7]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-tgl-y/igt@prime_v...@basic-fence-flip.html
[8]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/fi-tgl-y/igt@prime_v...@basic-fence-flip.html
Possible fixes
* igt@fbdev@read:
- fi-tgl-y: [DMESG-WARN][9] ([i915#402]) -> [PASS][10] +2 similar
issues
[9]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-tgl-y/igt@fb...@read.html
[10]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/fi-tgl-y/igt@fb...@read.html
* igt@i915_pm_rpm@module-reload:
- fi-byt-j1900: [INCOMPLETE][11] ([i915#142] / [i915#2405]) ->
[PASS][12]
[11]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-byt-j1900/igt@i915_pm_...@module-reload.html
[12]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/fi-byt-j1900/igt@i915_pm_...@module-reload.html
* igt@i915_selftest@live@execlists:
- fi-bsw-nick:[INCOMPLETE][13] ([i915#2940]) -> [PASS][14]
[13]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-bsw-nick/igt@i915_selftest@l...@execlists.html
[14]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/fi-bsw-nick/igt@i915_selftest@l...@execlists.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1222]: https://gitlab.freedesktop.org/drm/intel/issues/1222
[i915#142]: https://gitlab.freedesktop.org/drm/intel/issues/142
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
[i915#2675]: https://gitlab.freedesktop.org/drm/intel/issues/2675
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
Participating hosts (45 -> 41)
--
Additional (1): fi-ehl-2
Missing(5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600
fi-bdw-samus
Build changes
-
* Linux: CI_DRM_9791 -> Patchwork_19710
CI-20190529: 20190529
CI_DRM_9791: c1991e1c98008d13d9773744a9f9da0884644917 @
git://anongit.freedesktop.org/gfx-ci/linux
IGT_6009: a4dccf189b34a55338feec9927dac57c467c4100 @
git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19710: 222321649ab124d452f7481a005bed89cd64976f @
git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
222321649ab1 drm/i915/guc: Keep strict GuC ABI definitions separate
== Logs ==
For more details see:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/index.html
[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc: Keep strict GuC ABI definitions separate (rev2)
== Series Details == Series: drm/i915/guc: Keep strict GuC ABI definitions separate (rev2) URL : https://patchwork.freedesktop.org/series/87256/ State : success == Summary == CI Bug Log - changes from CI_DRM_9791_full -> Patchwork_19710_full Summary --- **WARNING** Minor unknown changes coming with Patchwork_19710_full need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_19710_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues --- Here are the unknown changes that may have been introduced in Patchwork_19710_full: ### IGT changes ### Warnings * igt@runner@aborted: - shard-kbl: ([FAIL][1], [FAIL][2], [FAIL][3]) ([i915#1814] / [i915#2505] / [i915#92]) -> ([FAIL][4], [FAIL][5], [FAIL][6]) ([i915#1436] / [i915#2505]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-kbl1/igt@run...@aborted.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-kbl1/igt@run...@aborted.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-kbl6/igt@run...@aborted.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/shard-kbl6/igt@run...@aborted.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/shard-kbl1/igt@run...@aborted.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/shard-kbl7/igt@run...@aborted.html Known issues Here are the changes found in Patchwork_19710_full that come from known issues: ### IGT changes ### Issues hit * igt@feature_discovery@psr2: - shard-iclb: [PASS][7] -> [SKIP][8] ([i915#658]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-iclb2/igt@feature_discov...@psr2.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/shard-iclb6/igt@feature_discov...@psr2.html * igt@gem_ctx_isolation@preservation-s3@bcs0: - shard-kbl: NOTRUN -> [DMESG-WARN][9] ([i915#180]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/shard-kbl7/igt@gem_ctx_isolation@preservation...@bcs0.html * igt@gem_ctx_persistence@smoketest: - shard-snb: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#1099]) +3 similar issues [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/shard-snb7/igt@gem_ctx_persiste...@smoketest.html * igt@gem_eio@unwedge-stress: - shard-tglb: [PASS][11] -> [TIMEOUT][12] ([i915#3063]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-tglb8/igt@gem_...@unwedge-stress.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/shard-tglb8/igt@gem_...@unwedge-stress.html * igt@gem_exec_fair@basic-none-rrul@rcs0: - shard-glk: [PASS][13] -> [FAIL][14] ([i915#2842]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-glk5/igt@gem_exec_fair@basic-none-r...@rcs0.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/shard-glk1/igt@gem_exec_fair@basic-none-r...@rcs0.html * igt@gem_exec_fair@basic-pace@rcs0: - shard-kbl: [PASS][15] -> [FAIL][16] ([i915#2842]) +1 similar issue [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-kbl6/igt@gem_exec_fair@basic-p...@rcs0.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/shard-kbl1/igt@gem_exec_fair@basic-p...@rcs0.html * igt@gem_exec_params@no-vebox: - shard-skl: NOTRUN -> [SKIP][17] ([fdo#109271]) +57 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/shard-skl10/igt@gem_exec_par...@no-vebox.html * igt@gem_exec_reloc@basic-many-active@vcs1: - shard-iclb: NOTRUN -> [FAIL][18] ([i915#2389]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/shard-iclb4/igt@gem_exec_reloc@basic-many-act...@vcs1.html * igt@gem_exec_reloc@basic-parallel: - shard-kbl: NOTRUN -> [TIMEOUT][19] ([i915#1729]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/shard-kbl4/igt@gem_exec_re...@basic-parallel.html * igt@gem_pwrite@basic-exhaustion: - shard-snb: NOTRUN -> [WARN][20] ([i915#2658]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/shard-snb7/igt@gem_pwr...@basic-exhaustion.html * igt@gem_userptr_blits@input-checking: - shard-snb: NOTRUN -> [DMESG-WARN][21] ([i915#3002]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/shard-snb6/igt@gem_userptr_bl...@input-checking.html * igt@gem_userptr_blits@process-exit-mmap@wb: - shard-glk: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#1699]) +3 similar issues [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19710/shard-glk3/igt@gem_userptr_blits@process-exit-m...@wb.html *
Re: [Intel-gfx] [RFC PATCH 3/9] drm/i915/spi: add driver for on-die spi device
> On Thu, Feb 18, 2021 at 10:06:08PM -0800, Winkler, Tomas wrote: > > > >> > >> On Wed, Feb 17, 2021 at 08:58:12PM +, Winkler, Tomas wrote: > >> >> > >> >> On Tue, 16 Feb 2021, Tomas Winkler > wrote: > >> >> > Add the platform driver for i915 on-die spi device, exposed via > >> >> > mfd framework. > >> >> > > >> >> > Cc: Rodrigo Vivi > >> >> > Cc: Lucas De Marchi > >> >> > Signed-off-by: Tomas Winkler > >> >> > --- > >> >> > drivers/gpu/drm/i915/Kconfig | 2 + > >> >> > drivers/gpu/drm/i915/Makefile| 3 + > >> >> > drivers/gpu/drm/i915/spi/intel_spi_drv.c | 116 > >> >> > +++ > >> >> > 3 files changed, 121 insertions(+) create mode 100644 > >> >> > drivers/gpu/drm/i915/spi/intel_spi_drv.c > >> >> > > >> >> > diff --git a/drivers/gpu/drm/i915/Kconfig > >> >> > b/drivers/gpu/drm/i915/Kconfig index abcaa8da45ac..13c870e5878e > >> >> > 100644 > >> >> > --- a/drivers/gpu/drm/i915/Kconfig > >> >> > +++ b/drivers/gpu/drm/i915/Kconfig > >> >> > @@ -27,6 +27,8 @@ config DRM_I915 > >> >> > select CEC_CORE if CEC_NOTIFIER > >> >> > select VMAP_PFN > >> >> > select MFD_CORE > >> >> > + select MTD > >> >> > >> >> Selecting MTD does not seem to be a popular thing to do, which is > >> >> usually a clue it's probably the wrong thing to do. > >> >Depends, if it is not selected you'll end with wrongly configured system. > >> > >> no. I believe the idea is that having a CONFIG_I915_SPI, you could do > >> > >>depends on MTD > >> > >> like the other drivers doing similar thing: > >> > >>git grep MTD -- ':(exclude)drivers/mtd' ':(exclude)arch/' '*Kconfig' > > I know the pattern and it can be done, the issue is that mtd is used mostly > in embedded systems so it is not selected by the desktop distros. > >The intel spi both on PCH and in GFX takes this into different direction and > usage. > > humn... but then we have a problem here. You're saying most of the people > won't need it because it's used only for manufacturing*. > And yet you want it to be force selected on everybody? That doesn't sound > like a good plan. It depends, whether manufacturing is done on shipping OS or not, both approaches are in use. One approach for the first case can be that the distro prevent the module loading via modprobe.d and it's forcefully loaded during manufacturing. Still it should be compiled and signed. > > Lucas De Marchi > > > * it may actually also be useful for kernel developers too, to dump its > content > and validate the parser, help debug other systems, etc. True. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.BAT: success for drm/vblank: Avoid storing a timestamp for the same frame twice (rev3)
== Series Details ==
Series: drm/vblank: Avoid storing a timestamp for the same frame twice (rev3)
URL : https://patchwork.freedesktop.org/series/86672/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9791 -> Patchwork_19711
Summary
---
**SUCCESS**
No regressions found.
External URL:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19711/index.html
Known issues
Here are the changes found in Patchwork_19711 that come from known issues:
### IGT changes ###
Issues hit
* igt@amdgpu/amd_basic@semaphore:
- fi-bsw-nick:NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19711/fi-bsw-nick/igt@amdgpu/amd_ba...@semaphore.html
* igt@amdgpu/amd_basic@userptr:
- fi-byt-j1900: NOTRUN -> [SKIP][2] ([fdo#109271]) +17 similar issues
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19711/fi-byt-j1900/igt@amdgpu/amd_ba...@userptr.html
Possible fixes
* igt@i915_pm_rpm@module-reload:
- fi-byt-j1900: [INCOMPLETE][3] ([i915#142] / [i915#2405]) ->
[PASS][4]
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-byt-j1900/igt@i915_pm_...@module-reload.html
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19711/fi-byt-j1900/igt@i915_pm_...@module-reload.html
* igt@i915_selftest@live@execlists:
- fi-bsw-nick:[INCOMPLETE][5] ([i915#2940]) -> [PASS][6]
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/fi-bsw-nick/igt@i915_selftest@l...@execlists.html
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19711/fi-bsw-nick/igt@i915_selftest@l...@execlists.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1222]: https://gitlab.freedesktop.org/drm/intel/issues/1222
[i915#142]: https://gitlab.freedesktop.org/drm/intel/issues/142
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Participating hosts (45 -> 40)
--
Additional (1): fi-ehl-2
Missing(6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-tgl-y
fi-bdw-samus
Build changes
-
* Linux: CI_DRM_9791 -> Patchwork_19711
CI-20190529: 20190529
CI_DRM_9791: c1991e1c98008d13d9773744a9f9da0884644917 @
git://anongit.freedesktop.org/gfx-ci/linux
IGT_6009: a4dccf189b34a55338feec9927dac57c467c4100 @
git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19711: 201c60e18cf69bd374d5c01f894d129ac7f1d170 @
git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
201c60e18cf6 drm/vblank: Do not store a new vblank timestamp in
drm_vblank_restore()
== Logs ==
For more details see:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19711/index.html
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.IGT: success for drm/vblank: Avoid storing a timestamp for the same frame twice (rev3)
== Series Details == Series: drm/vblank: Avoid storing a timestamp for the same frame twice (rev3) URL : https://patchwork.freedesktop.org/series/86672/ State : success == Summary == CI Bug Log - changes from CI_DRM_9791_full -> Patchwork_19711_full Summary --- **WARNING** Minor unknown changes coming with Patchwork_19711_full need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_19711_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues --- Here are the unknown changes that may have been introduced in Patchwork_19711_full: ### IGT changes ### Warnings * igt@runner@aborted: - shard-kbl: ([FAIL][1], [FAIL][2], [FAIL][3]) ([i915#1814] / [i915#2505] / [i915#92]) -> ([FAIL][4], [FAIL][5], [FAIL][6]) ([i915#1814] / [i915#2505] / [i915#602]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-kbl1/igt@run...@aborted.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-kbl1/igt@run...@aborted.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-kbl6/igt@run...@aborted.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19711/shard-kbl1/igt@run...@aborted.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19711/shard-kbl7/igt@run...@aborted.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19711/shard-kbl6/igt@run...@aborted.html - shard-apl: ([FAIL][7], [FAIL][8]) -> ([FAIL][9], [FAIL][10], [FAIL][11]) ([i915#3002]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-apl8/igt@run...@aborted.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-apl8/igt@run...@aborted.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19711/shard-apl1/igt@run...@aborted.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19711/shard-apl2/igt@run...@aborted.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19711/shard-apl3/igt@run...@aborted.html - shard-skl: ([FAIL][12], [FAIL][13]) ([i915#3002]) -> ([FAIL][14], [FAIL][15], [FAIL][16], [FAIL][17]) ([i915#1436] / [i915#2426] / [i915#3002]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-skl7/igt@run...@aborted.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-skl8/igt@run...@aborted.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19711/shard-skl5/igt@run...@aborted.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19711/shard-skl10/igt@run...@aborted.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19711/shard-skl6/igt@run...@aborted.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19711/shard-skl4/igt@run...@aborted.html Known issues Here are the changes found in Patchwork_19711_full that come from known issues: ### IGT changes ### Issues hit * igt@feature_discovery@psr2: - shard-iclb: [PASS][18] -> [SKIP][19] ([i915#658]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-iclb2/igt@feature_discov...@psr2.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19711/shard-iclb6/igt@feature_discov...@psr2.html * igt@gem_create@create-massive: - shard-apl: NOTRUN -> [DMESG-WARN][20] ([i915#3002]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19711/shard-apl2/igt@gem_cre...@create-massive.html * igt@gem_ctx_persistence@close-replace-race: - shard-glk: NOTRUN -> [TIMEOUT][21] ([i915#2918]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19711/shard-glk4/igt@gem_ctx_persiste...@close-replace-race.html * igt@gem_ctx_persistence@smoketest: - shard-snb: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#1099]) +4 similar issues [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19711/shard-snb6/igt@gem_ctx_persiste...@smoketest.html * igt@gem_exec_fair@basic-none-rrul@rcs0: - shard-glk: [PASS][23] -> [FAIL][24] ([i915#2842]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-glk5/igt@gem_exec_fair@basic-none-r...@rcs0.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19711/shard-glk9/igt@gem_exec_fair@basic-none-r...@rcs0.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-tglb: [PASS][25] -> [FAIL][26] ([i915#2842]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9791/shard-tglb2/igt@gem_exec_fair@basic-none-sh...@rcs0.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19711/shard-tglb5/igt@gem_exec_fair@basic-none-sh...@rcs0.html * igt@gem_exec_fair@basic-pace@vcs1: - shard-kbl: [PASS][27] -> [SKIP][28] ([fdo#109271]) [2
Re: [Intel-gfx] [RFC PATCH 0/9] drm/i915/spi: discrete graphics internal spi
> > > > > > )On Tue, Feb 16, 2021 at 7:26 PM Tomas Winkler > > > > wrote: > > > Because the graphic card may undergo reset at any time and basically > > > hot unplug all its child devices, this series also provides a fix to > > > the mtd framework to make the reset graceful. > > > > Well, just because MTD does not work as you expect, it is not broken. > > :-) > I'm not saying it's broken by design it just didn't fit this use case. > > > > In your case i915_spi_remove() blindly removes the MTD, this is not > allowed. > > You may remove the MTD only if there are no more users. > > I'm not sure it's good idea to stall the removal on user space. > This is just asking for a deadlock as user space is not getting what it needs > and > may stall I think it's better the user space will fail gracefully the hw is > not > accessible in that stage anyway. > > > > The current model in MTD is that the driver is in charge of all life > > cycle management. > > Using ->_get_device() and ->_put_device() a driver can implement > > refcounting and deny new users if the MTD is about to disappear. > > Please note that this use case you are describing is still valid, I haven't > removed _get_device() _put_device() handlers, You can still stall the > removal of mtd, If this is not that way it's a bug > > > > > In the upcoming MUSE driver that mechanism is used too. > > MUSE allows to implement a MTD in userspace. So the FUSE server can > > disappear at > > *any* time. Just like in your case. Even worse, it can be hostile. > > In MUSE the MTD life time is tied to the FUSE connection object, > > muse_mtd_get_device() > > increments the FUSE connection refcount, and muse_mtd_put_device() > > decrements it. > > That means if the FUSE server disappears all of a sudden but the MTD > > still has users, the MTD will stay. But in this state no new > > references are allowed and all MTD operations of existing users will fail > with -ENOTCONN (via FUSE). > > As soon the last user is gone (can be userspace via /dev/mtd* or a > > in-kernel user such as UBIFS), the MTD will be removed. > > But in our case whole i915 is taken hostage, it cannot reset because of > misbehaving user space. > > > For the full details, please see: > > https://git.kernel.org/pub/scm/linux/kernel/git/rw/misc.git/tree/fs/fu > > se/m > > use.c?h=muse_v3#n1034 > > > > Is in your case *really* not possible to do it that way? > > Maybe it's possible but I don't think it's good to stall i915 removal. Also > It's > very easily to crash the kernel. > I've posted a sniped to the mailing list that tried to do that, the kernel > still has > crashed. Can you looked at? > > > On the other hand, your last patch moves some part of the life cycle > > management into MTD core. > > The MTD will stay as long it has users. > > But that's only one part. The driver is still in charge to make sure > > that all operations fail immediately and that no new users arrive. > > I think that case I would need to validate every HW access to make sure it's > still valid. > > > If we want to do all in MTD core we'd have to do it like SCSI disks. > > That means having devices states such as SDEV_RUNNING, SDEV_CANCEL, > > SDEV_OFFLINE, > > That way the MTD could be shutdown gracefully, first no new users are > > allowed, then ongoing operations will be cancelled, next all operation > > will fail with -EIO or such, then the device is being removed from > > sysfs and finally if the last user is gone, the MTD can be removed. > > Isn't that already that way? You cannot open new handler. That I would need > more of your insights. > > > > I'm not sure whether we want to take that path. Hi Richard is there any way we can try to unclutter this ? Thanks Tomas ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
