Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data
- Original Message - > Hello, > > Please review the JDK8 changes for JEP 127: Improve Locale Data > Packaging and Adopt Unicode CLDR Data > (http://openjdk.java.net/jeps/127). The webrev is located at: > > http://cr.openjdk.java.net/~naoto/6336885/webrev.00/ > > The main bug id for this enhancement is: > > 6336885: RFE: Locale Data Deployment Enhancements > > Along with this, the following bugs/enhancements are also implemented > in > this change: > > 4609153 Provide locale data for Indic locales > 5104387 Support for gl_ES locale (galician language) > 6337471 desktop/system locale preferences support > 7056139 (cal) SPI support for locale-dependent Calendar parameters > 7058206 Provide CalendarData SPI for week params and display field > value > names > 7073852 Support multiple scripts for digits and decimal symbols per > locale > 7079560 [Fmt-Da] Context dependent month names support in > SimpleDateFormat > 7171324 getAvailableLocales() of locale sensitive services should > return > the actual availability of locales > 7151414 (cal) Support calendar type identification > 7168528 LocaleServiceProvider needs to be aware of Locale extensions > 7171372 (cal) locale's default Calendar should be created if unknown > calendar is specified > > Please note that packaging changes that relate to Jigsaw module > system > aren't included in this changeset. > > Naoto Sato and Masayoshi Okutsu > First of all, I'd like to say congratulations on completing this week and adopting the CLDR as a source for locale data. This is something we've used for GNU Classpath's locale data for many years, and, with these changes, it should mean that the Java API itself should see changes which allow it to support some of the features present in the CLDR data. However, I am a little concerned by the inclusion of CLDR data files in this webrev with a GPL header assigning copyright to Oracle e.g. http://cr.openjdk.java.net/~naoto/6336885/webrev.00/src/share/classes/sun/util/cldr/resources/21_0_1/common/main/agq.xml.patch Is this legal? IANAL, but http://unicode.org/copyright.html#Exhibit1 seems to state that the header given there should be present on this data. The current files make it look like this data was created by Oracle this year, which is clearly inaccurate. Thanks, -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
Re: Additional source to guess the local timezone ID on linux
- Original Message - > On 08/27/2013 03:00 AM, Masayoshi Okutsu wrote: > > /etc/sysconfig/clock used to be supported, but it was removed in JDK 7. > > The problem is discussed in bug #6456628. > > > > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6456628 > > Thanks for that link. I did not know that this support was present in > JDK7 but then removed. I did not expect various distributions and > versions to have significant differences in that file either. > To bring things full circle: https://bugzilla.redhat.com/show_bug.cgi?id=489586 "BTW: I'll change the warning boilerplate to this to make it more clear: # The time zone of the system is defined by the contents of /etc/localtime. # This file is only for evaluation by system-config-date, do not rely on its # contents elsewhere." https://bugzilla.redhat.com/show_bug.cgi?id=489586#c2 > > Have you tested your fix on all Red Hat-like distros, including some > > older releases, with all the time zone IDs? > > No, I tested this with Red Hat Enterprise Linux 6. I did not try it on > older versions. I know newer versions of Fedora don't ship with this > file any more. > > Given that this support was removed because there were significant > differences in that file making maintenance harder in OpenJDK, I am > going to withdraw this patch. > > Thanks to everyone who reviewed and commented on it. > > Omair > > -- > PGP Key: 66484681 (http://pgp.mit.edu/) > Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
Re: RFR[JDK10]: 8195837: (tz) Support tzdata2018c
On 29 January 2018 at 14:42, Seán Coffey wrote: > The changes look fine to me Ramanand. The europe file contains some > interesting comments about the rolled back changes that have been made for > 2018c. A plan on how to resolve these pending changes can be followed up via > JDK-8195595 > Yes... I've been following the discussion on the tzdb list about these changes to the Irish timezone and the breakage they cause. It's good to see that, at least for now, these changes will be reverted locally for OpenJDK. My thanks to those who've put forward the case on that list for the compatibility issues these changes cause, particularly Stephen Colebourne. > Regards, > Sean. > > -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Web Site: http://fuseyism.com Twitter: https://twitter.com/gnu_andrew_java PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
