Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. Marked as reviewed by serb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7189
Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7189
Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v4]
On Fri, 21 Jan 2022 07:43:17 GMT, Sergey Bylokhov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix > > src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java > line 353: > >> 351: * File(parent, fileName) except when the parent and child >> are both >> 352: * special folders, in which case the File is a >> wrapper containing >> 353: * a ShellFolder object. > > Is a "ShellFolder" part of the public API? If not should we mention it in the > spec? It is already mentioned in getSystemDisplayName, getSystemTypeDescription, getSystemIcon, isRoot. Anyways, I have removed the linkage for the new addition as it will not be able to resolve. - PR: https://git.openjdk.java.net/jdk/pull/7004
Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v5]
> The changes done under JDK-8278175 suppress on a per-file basis various > missing comments that would otherwise trigger doclint warnings. Fixed them so > as to remove the doclint:missing warnings. Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Address review comment - Changes: - all: https://git.openjdk.java.net/jdk/pull/7004/files - new: https://git.openjdk.java.net/jdk/pull/7004/files/16d76ed3..752b7a09 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7004&range=04 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7004&range=03-04 Stats: 7 lines in 3 files changed: 0 ins; 0 del; 7 mod Patch: https://git.openjdk.java.net/jdk/pull/7004.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7004/head:pull/7004 PR: https://git.openjdk.java.net/jdk/pull/7004
