Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v2]
> Hi, > > Could someone please review my code for updating the code in the `java.time` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge remote-tracking branch 'origin/master' into JDK-8263668 - Merge remote-tracking branch 'origin/master' into JDK-8263668 - 8263668: Update java.time to use instanceof pattern variable - Changes: - all: https://git.openjdk.java.net/jdk/pull/3170/files - new: https://git.openjdk.java.net/jdk/pull/3170/files/43a57378..b72e658e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3170&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3170&range=00-01 Stats: 4370 lines in 292 files changed: 2129 ins; 651 del; 1590 mod Patch: https://git.openjdk.java.net/jdk/pull/3170.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3170/head:pull/3170 PR: https://git.openjdk.java.net/jdk/pull/3170
RFR: 8262110: DST starts from incorrect time in 2038
Please review the fix to the DST transition bug after the year 2037. The logic had the side effect that it adjusted the dst offset every time the method `getOffsets()` is issued. Only adjust the offset when issued with wall time. - Commit messages: - Set time zone to the formatter. - Added eof - Added a test case for 8073446 - 8262110: DST starts from incorrect time in 2038 Changes: https://git.openjdk.java.net/jdk/pull/3165/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3165&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8262110 Stats: 75 lines in 2 files changed: 73 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/3165.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3165/head:pull/3165 PR: https://git.openjdk.java.net/jdk/pull/3165
Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations
On Wed, 10 Mar 2021 18:33:37 GMT, Andy Herrick wrote: > implementation of > JDK-8256145: JEP 398: Deprecate the Applet API for Removal src/java.desktop/share/classes/java/applet/package-info.java line 39: > 37: * applet development environment. > 38: * > 39: * @deprecated. This package has been deprecated and may be removed in Package declarations cannot have `@deprecated` tags, so `make docs` fails with this change. Also, since there is a tag here, the previous `` is now empty and causes a warning. Both problems will be fixed by removing the `@deprecated` tag, while leaving the added text. - PR: https://git.openjdk.java.net/jdk/pull/2920
Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations [v2]
> implementation of > JDK-8256145: JEP 398: Deprecate the Applet API for Removal Andy Herrick has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 301 additional commits since the last revision: - 8189198: Add "forRemoval = true" to Applet API deprecations - Merge branch 'master' into 8189198 - 8260862: JFR: New configure command for the jfr tool Reviewed-by: mgronlun - 8264161: BigDecimal#stripTrailingZeros can throw undocumented ArithmeticException Reviewed-by: bpb - 8262081: vmTestbase/nsk/jdi/ThreadDeathRequest/addThreadFilter/addthreadfilter001/TestDescription.java failed with "ERROR: eventSet1.size() != 3 :: 2" Reviewed-by: cjplummer, lmesnik, sspitsyn - 8261502: ECDHKeyAgreement: Allows alternate ECPrivateKey impl and revised exception handling Reviewed-by: jnimeh - 8253795: Implementation of JEP 391: macOS/AArch64 Port 8253816: Support macOS W^X 8253817: Support macOS Aarch64 ABI in Interpreter 8253818: Support macOS Aarch64 ABI for compiled wrappers 8253819: Implement os/cpu for macOS/AArch64 8253839: Update tests and JDK code for macOS/Aarch64 8254941: Implement Serviceability Agent for macOS/AArch64 8255776: Change build system for macOS/AArch64 8262903: [macos_aarch64] Thread::current() called on detached thread Co-authored-by: Vladimir Kempik Co-authored-by: Bernhard Urban-Forster Co-authored-by: Ludovic Henry Co-authored-by: Monica Beckwith Reviewed-by: erikj, ihse, prr, cjplummer, stefank, gziemski, aph, mbeckwit, luhenry - 4833719: (bf) Views of MappedByteBuffers are not MappedByteBuffers, and cannot be forced Reviewed-by: adinn - 8264165: jpackage BasicTest fails after JDK-8220266: Check help text contains plaform specific parameters Reviewed-by: herrick, dcubed - 8263454: com.apple.laf.AquaFileChooserUI ignores the result of String.trim() Reviewed-by: serb, pbansal, kizune, trebari, psadhukhan - ... and 291 more: https://git.openjdk.java.net/jdk/compare/ddfe8ec5...026f09c8 - Changes: - all: https://git.openjdk.java.net/jdk/pull/2920/files - new: https://git.openjdk.java.net/jdk/pull/2920/files/1148f208..026f09c8 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2920&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2920&range=00-01 Stats: 64315 lines in 2948 files changed: 41333 ins; 13022 del; 9960 mod Patch: https://git.openjdk.java.net/jdk/pull/2920.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2920/head:pull/2920 PR: https://git.openjdk.java.net/jdk/pull/2920
Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations [v2]
On Wed, 17 Mar 2021 20:33:09 GMT, Andy Herrick wrote:
>>> I cannot find any instances where the scope can be narrowed
>>
>> Are you about AquaInternalFrameUI.mouseRelased, BasicPopupMenuUI.
>> stateChanged, and other non-trivial methods?
>
>>
>>
>> > I cannot find any instances where the scope can be narrowed
>>
>> Are you about AquaInternalFrameUI.mouseRelased, BasicPopupMenuUI.
>> stateChanged, and other non-trivial methods?
>
> These have the code pattern such as:
> } else if (c instanceof JApplet) {
> putting '@SuppressWarnings("removal")' before the declaration of 'c' does not
> help, because the code is not an assignment to 'c'
pushed minor change to
src/java.desktop/share/classes/java/applet/package-info.java as well as merge
with master.
-
PR: https://git.openjdk.java.net/jdk/pull/2920
Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations [v2]
On Thu, 25 Mar 2021 22:58:53 GMT, Andy Herrick wrote: >> implementation of >> JDK-8256145: JEP 398: Deprecate the Applet API for Removal > > Andy Herrick has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 301 additional > commits since the last revision: > > - 8189198: Add "forRemoval = true" to Applet API deprecations > - Merge branch 'master' into 8189198 > - 8260862: JFR: New configure command for the jfr tool > >Reviewed-by: mgronlun > - 8264161: BigDecimal#stripTrailingZeros can throw undocumented > ArithmeticException > >Reviewed-by: bpb > - 8262081: > vmTestbase/nsk/jdi/ThreadDeathRequest/addThreadFilter/addthreadfilter001/TestDescription.java > failed with "ERROR: eventSet1.size() != 3 :: 2" > >Reviewed-by: cjplummer, lmesnik, sspitsyn > - 8261502: ECDHKeyAgreement: Allows alternate ECPrivateKey impl and revised > exception handling > >Reviewed-by: jnimeh > - 8253795: Implementation of JEP 391: macOS/AArch64 Port >8253816: Support macOS W^X >8253817: Support macOS Aarch64 ABI in Interpreter >8253818: Support macOS Aarch64 ABI for compiled wrappers >8253819: Implement os/cpu for macOS/AArch64 >8253839: Update tests and JDK code for macOS/Aarch64 >8254941: Implement Serviceability Agent for macOS/AArch64 >8255776: Change build system for macOS/AArch64 >8262903: [macos_aarch64] Thread::current() called on detached thread > >Co-authored-by: Vladimir Kempik >Co-authored-by: Bernhard Urban-Forster >Co-authored-by: Ludovic Henry >Co-authored-by: Monica Beckwith >Reviewed-by: erikj, ihse, prr, cjplummer, stefank, gziemski, aph, > mbeckwit, luhenry > - 4833719: (bf) Views of MappedByteBuffers are not MappedByteBuffers, and > cannot be forced > >Reviewed-by: adinn > - 8264165: jpackage BasicTest fails after JDK-8220266: Check help text > contains plaform specific parameters > >Reviewed-by: herrick, dcubed > - 8263454: com.apple.laf.AquaFileChooserUI ignores the result of > String.trim() > >Reviewed-by: serb, pbansal, kizune, trebari, psadhukhan > - ... and 291 more: > https://git.openjdk.java.net/jdk/compare/e2285595...026f09c8 Looks good. - Marked as reviewed by kcr (Author). PR: https://git.openjdk.java.net/jdk/pull/2920
Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations [v2]
On Thu, 25 Mar 2021 22:58:53 GMT, Andy Herrick wrote: >> implementation of >> JDK-8256145: JEP 398: Deprecate the Applet API for Removal > > Andy Herrick has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 301 additional > commits since the last revision: > > - 8189198: Add "forRemoval = true" to Applet API deprecations > - Merge branch 'master' into 8189198 > - 8260862: JFR: New configure command for the jfr tool > >Reviewed-by: mgronlun > - 8264161: BigDecimal#stripTrailingZeros can throw undocumented > ArithmeticException > >Reviewed-by: bpb > - 8262081: > vmTestbase/nsk/jdi/ThreadDeathRequest/addThreadFilter/addthreadfilter001/TestDescription.java > failed with "ERROR: eventSet1.size() != 3 :: 2" > >Reviewed-by: cjplummer, lmesnik, sspitsyn > - 8261502: ECDHKeyAgreement: Allows alternate ECPrivateKey impl and revised > exception handling > >Reviewed-by: jnimeh > - 8253795: Implementation of JEP 391: macOS/AArch64 Port >8253816: Support macOS W^X >8253817: Support macOS Aarch64 ABI in Interpreter >8253818: Support macOS Aarch64 ABI for compiled wrappers >8253819: Implement os/cpu for macOS/AArch64 >8253839: Update tests and JDK code for macOS/Aarch64 >8254941: Implement Serviceability Agent for macOS/AArch64 >8255776: Change build system for macOS/AArch64 >8262903: [macos_aarch64] Thread::current() called on detached thread > >Co-authored-by: Vladimir Kempik >Co-authored-by: Bernhard Urban-Forster >Co-authored-by: Ludovic Henry >Co-authored-by: Monica Beckwith >Reviewed-by: erikj, ihse, prr, cjplummer, stefank, gziemski, aph, > mbeckwit, luhenry > - 4833719: (bf) Views of MappedByteBuffers are not MappedByteBuffers, and > cannot be forced > >Reviewed-by: adinn > - 8264165: jpackage BasicTest fails after JDK-8220266: Check help text > contains plaform specific parameters > >Reviewed-by: herrick, dcubed > - 8263454: com.apple.laf.AquaFileChooserUI ignores the result of > String.trim() > >Reviewed-by: serb, pbansal, kizune, trebari, psadhukhan > - ... and 291 more: > https://git.openjdk.java.net/jdk/compare/8fcfe0bd...026f09c8 Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2920
Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations [v2]
On Thu, 25 Mar 2021 22:58:53 GMT, Andy Herrick wrote: >> implementation of >> JDK-8256145: JEP 398: Deprecate the Applet API for Removal > > Andy Herrick has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 301 additional > commits since the last revision: > > - 8189198: Add "forRemoval = true" to Applet API deprecations > - Merge branch 'master' into 8189198 > - 8260862: JFR: New configure command for the jfr tool > >Reviewed-by: mgronlun > - 8264161: BigDecimal#stripTrailingZeros can throw undocumented > ArithmeticException > >Reviewed-by: bpb > - 8262081: > vmTestbase/nsk/jdi/ThreadDeathRequest/addThreadFilter/addthreadfilter001/TestDescription.java > failed with "ERROR: eventSet1.size() != 3 :: 2" > >Reviewed-by: cjplummer, lmesnik, sspitsyn > - 8261502: ECDHKeyAgreement: Allows alternate ECPrivateKey impl and revised > exception handling > >Reviewed-by: jnimeh > - 8253795: Implementation of JEP 391: macOS/AArch64 Port >8253816: Support macOS W^X >8253817: Support macOS Aarch64 ABI in Interpreter >8253818: Support macOS Aarch64 ABI for compiled wrappers >8253819: Implement os/cpu for macOS/AArch64 >8253839: Update tests and JDK code for macOS/Aarch64 >8254941: Implement Serviceability Agent for macOS/AArch64 >8255776: Change build system for macOS/AArch64 >8262903: [macos_aarch64] Thread::current() called on detached thread > >Co-authored-by: Vladimir Kempik >Co-authored-by: Bernhard Urban-Forster >Co-authored-by: Ludovic Henry >Co-authored-by: Monica Beckwith >Reviewed-by: erikj, ihse, prr, cjplummer, stefank, gziemski, aph, > mbeckwit, luhenry > - 4833719: (bf) Views of MappedByteBuffers are not MappedByteBuffers, and > cannot be forced > >Reviewed-by: adinn > - 8264165: jpackage BasicTest fails after JDK-8220266: Check help text > contains plaform specific parameters > >Reviewed-by: herrick, dcubed > - 8263454: com.apple.laf.AquaFileChooserUI ignores the result of > String.trim() > >Reviewed-by: serb, pbansal, kizune, trebari, psadhukhan > - ... and 291 more: > https://git.openjdk.java.net/jdk/compare/00b7b36f...026f09c8 Marked as reviewed by prr (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2920
