RFR: 8168512: (tz) Support tzdata2016h

2016-10-24 Thread Ramanand Patil
Hi all,

Please review the latest TZDATA integration (tzdata2016h) to JDK9.

Bug: https://bugs.openjdk.java.net/browse/JDK-8168512

Webrev: http://cr.openjdk.java.net/~rpatil/8168512/webrev.00/

 

All the TimeZone related tests are passed after integration.

 

Regards,

Ramanand.

 


Re: RFR: 8165804: Revisit the way of loading BreakIterator rules/dictionaries

2016-10-24 Thread Erik Joelsson

Build change looks good.

/Erik


On 2016-10-20 10:33, Masayoshi Okutsu wrote:

Hi,

Please review the changes for JDK-8165804 which is a follow-up of 
JDK-8076757. Some notes on the changes.


- Removed INCLUDES := $(TEXT_PKG_LD) from 
make/gendata/GendataBreakIterator.gmk in order to avoid compiling 
non-BreakIterator*.java for the build tool with boot JDK.


- Added sun.util.resources.BreakIteratorResourceBundle which handles 
loading of rule data and dictionaries. BreadIteratorResources* are its 
subclasses in the java.base and jdk.localedata modules.


- In BreakIteratorResources*, regular ResourceBundle loading of 
BreakIteratorInfo* is avoided because a BreakIteratorInfo can't have 
its parent chain. For example, BreakIteratorInfo_th doesn't have the 
value for key "CharacterData" and 
BreakIteratorResources_th.handleGetObject() must return null for 
"CharacterData" rather than loading rule data given by the parent 
BreakIteratorInfo.


- Moved RuleBasedBreakIterator, DictionaryBasedBreakIterator, and 
BreakDictionary to sun.text. BreakIteratorProviderTest.java was 
changed to deal with this refactoring.


Issue:
https://bugs.openjdk.java.net/browse/JDK-8165804

Webrev:
http://cr.openjdk.java.net/~okutsu/9/8165804/webrev.01

Thanks,
Masayoshi





Re: RFR: 8168512: (tz) Support tzdata2016h

2016-10-24 Thread Martin Buchholz
Looks good to me!

On Mon, Oct 24, 2016 at 12:28 AM, Ramanand Patil 
wrote:

> Hi all,
>
> Please review the latest TZDATA integration (tzdata2016h) to JDK9.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8168512
>
> Webrev: http://cr.openjdk.java.net/~rpatil/8168512/webrev.00/
>
>
>
> All the TimeZone related tests are passed after integration.
>
>
>
> Regards,
>
> Ramanand.
>
>
>


Re: RFR: 8168512: (tz) Support tzdata2016h

2016-10-24 Thread Masayoshi Okutsu

+1

Masayoshi


On 10/24/2016 11:14 PM, Martin Buchholz wrote:

Looks good to me!

On Mon, Oct 24, 2016 at 12:28 AM, Ramanand Patil 
wrote:


Hi all,

Please review the latest TZDATA integration (tzdata2016h) to JDK9.

Bug: https://bugs.openjdk.java.net/browse/JDK-8168512

Webrev: http://cr.openjdk.java.net/~rpatil/8168512/webrev.00/



All the TimeZone related tests are passed after integration.



Regards,

Ramanand.