Re: Review Request for JDK-8145136:Upgrade CLDR locale data
Other than the copyright year things, all looks good to me. I don't think further review is required for copyright update. Masayoshi On 5/28/2016 3:25 AM, Naoto Sato wrote: Hi Rachna, Here are my comments to the webrev (I am assuming the tool that extracts JavaTime*.java are working correctly, i.e., have not reviewed the data itself): - (All JavaTime*.java files): Unicode copyright notice is outdated. It should include the one that has "1991-2016" as the copyright year. So as the file "unicode-license.txt" - JavaTimeSupplementary_iw.java has the copyright year of "2016,". It should be "2013, 2016,". Others look OK. Naoto On 5/26/16 4:30 AM, Rachna Goel wrote: Hi all, Please review fix for JDK-8145136. Bug: https://bugs.openjdk.java.net/browse/JDK-8145136 webrev: http://cr.openjdk.java.net/~nishjain/rachna/CLDR29/8145136/webrev.00/ Fix: Currently JDK supports CLDR V27 which is upgraded to latest version 29. For more info: http://cldr.unicode.org/
RFR: 8039565: Remove test exclusion for java/util/ResourceBundle/RestrictedBundleTest.java
Hi, Please review the fix for JDK-8039565. I don't think it's worth keeping this old test and decided to remove it. Issue: https://bugs.openjdk.java.net/browse/JDK-8039565 Webrev: http://cr.openjdk.java.net/~okutsu/9/8039565/webrev.00 Thanks, Masayoshi
Re: RFR: 8039565: Remove test exclusion for java/util/ResourceBundle/RestrictedBundleTest.java
Hi, The fix looks good to me. Thanks, -- Yuka On 2016/05/30 14:05, Masayoshi Okutsu wrote: Hi, Please review the fix for JDK-8039565. I don't think it's worth keeping this old test and decided to remove it. Issue: https://bugs.openjdk.java.net/browse/JDK-8039565 Webrev: http://cr.openjdk.java.net/~okutsu/9/8039565/webrev.00 Thanks, Masayoshi
Review Request for JDK-8158025: Typo in java.util.Locale
Hi, Please review the fix for JDK-8158025. Webrev : http://cr.openjdk.java.net/~nishjain/8158025/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8158025 Fix: corrected a small typo in Locale.java. Regards, Nishit Jain
Re: Review Request for JDK-8158025: Typo in java.util.Locale
Looks good to me. Masayoshi On 5/30/2016 3:00 PM, Nishit Jain wrote: Hi, Please review the fix for JDK-8158025. Webrev : http://cr.openjdk.java.net/~nishjain/8158025/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8158025 Fix: corrected a small typo in Locale.java. Regards, Nishit Jain
Re: Review Request for JDK-8158025: Typo in java.util.Locale
+1 On 2016/05/30 15:04, Masayoshi Okutsu wrote: Looks good to me. Masayoshi On 5/30/2016 3:00 PM, Nishit Jain wrote: Hi, Please review the fix for JDK-8158025. Webrev : http://cr.openjdk.java.net/~nishjain/8158025/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8158025 Fix: corrected a small typo in Locale.java. Regards, Nishit Jain
Re: Review Request for JDK-8145136:Upgrade CLDR locale data
+1 On 2016/05/30 8:15, Masayoshi Okutsu wrote: Other than the copyright year things, all looks good to me. I don't think further review is required for copyright update. Masayoshi On 5/28/2016 3:25 AM, Naoto Sato wrote: Hi Rachna, Here are my comments to the webrev (I am assuming the tool that extracts JavaTime*.java are working correctly, i.e., have not reviewed the data itself): - (All JavaTime*.java files): Unicode copyright notice is outdated. It should include the one that has "1991-2016" as the copyright year. So as the file "unicode-license.txt" - JavaTimeSupplementary_iw.java has the copyright year of "2016,". It should be "2013, 2016,". Others look OK. Naoto On 5/26/16 4:30 AM, Rachna Goel wrote: Hi all, Please review fix for JDK-8145136. Bug: https://bugs.openjdk.java.net/browse/JDK-8145136 webrev: http://cr.openjdk.java.net/~nishjain/rachna/CLDR29/8145136/webrev.00/ Fix: Currently JDK supports CLDR V27 which is upgraded to latest version 29. For more info: http://cldr.unicode.org/
