[8] Request for review: 8015960: java/util/Locale/LocaleProviders.java failing again on Windows
Hello, Please review an one-liner fix for the following bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015960 The fix is simply to set the time zone in the formatter to "PST": http://cr.openjdk.java.net/~naoto/8015960/webrev.00/ Naoto
Re: [8] Request for review: 8015960: java/util/Locale/LocaleProviders.java failing again on Windows
On 11/06/2013 18:55, Naoto Sato wrote: Hello, Please review an one-liner fix for the following bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015960 The fix is simply to set the time zone in the formatter to "PST": http://cr.openjdk.java.net/~naoto/8015960/webrev.00/ Naoto This looks okay to me (and doesn't need to be restored because the test runs in its own VM). -Alan.
Re: [8] Request for review: 8015960: java/util/Locale/LocaleProviders.java failing again on Windows
On 6/11/13 11:07 AM, Alan Bateman wrote: On 11/06/2013 18:55, Naoto Sato wrote: Hello, Please review an one-liner fix for the following bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015960 The fix is simply to set the time zone in the formatter to "PST": http://cr.openjdk.java.net/~naoto/8015960/webrev.00/ Naoto This looks okay to me (and doesn't need to be restored because the test runs in its own VM). Thanks for the review. Actually the time zone is set to a SimpleDateFormat instance, not to the system default, so it is ok to not restore anyway. Naoto
Re: [8] Request for review: 8015960: java/util/Locale/LocaleProviders.java failing again on Windows
On 11/06/2013 19:16, Naoto Sato wrote: Thanks for the review. Actually the time zone is set to a SimpleDateFormat instance, not to the system default, so it is ok to not restore anyway. Oh right, I had setDefault(TZ) on the brain from another discussion.
Re: [8] Request for review: 8015960: java/util/Locale/LocaleProviders.java failing again on Windows
I prefer to avoid use of deprecated 3-letter IDs of JDK 1.1. "PST" should be "America/Los_Angeles". Masayoshi On 6/12/2013 2:55 AM, Naoto Sato wrote: Hello, Please review an one-liner fix for the following bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015960 The fix is simply to set the time zone in the formatter to "PST": http://cr.openjdk.java.net/~naoto/8015960/webrev.00/ Naoto
Re: [8] Request for review: 8015960: java/util/Locale/LocaleProviders.java failing again on Windows
Right. However, I've already pushed the changeset, so I will fix it next time I modify the test case. Naoto On 6/11/13 4:09 PM, Masayoshi Okutsu wrote: I prefer to avoid use of deprecated 3-letter IDs of JDK 1.1. "PST" should be "America/Los_Angeles". Masayoshi On 6/12/2013 2:55 AM, Naoto Sato wrote: Hello, Please review an one-liner fix for the following bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015960 The fix is simply to set the time zone in the formatter to "PST": http://cr.openjdk.java.net/~naoto/8015960/webrev.00/ Naoto
