Re: [hibernate-dev] Is bytecode enhancement enabled by default in 5.3?

[Scott Marlow]

There is a tradeoff in WF deployment, between Hibernate bytecode (runtime)
enhancing class transformers, being registered before CDI deployment, reads
the entity classes.

There is also the tradeoff between Hibernate bytecode (runtime) enhancing
class transformers being registered too late because the persistent unit
uses a datasourcedefinition.

I asked Gail's question for 5.1.x and the answer was no.

Now, for 5.3, I don't understand the answers yet.

Anyway, wanted to mention the above, to share more info with all, as to why
we are asking.

Regards,
Scott

On Sat, May 19, 2018, 6:30 AM Sanne Grinovero  wrote:

> Hi Gail,
>
> perhaps your question is related to WildFly? As far as I know, WildFly
> does enhance entities automatically during deployment.
>
> But as Luis suggested, Hibernate doesn't control this process so I'm
> not sure if that's still the case in any development branch of
> WildFly; probably a question for Scott.
>
> If not WildFly, other platforms might do the same but it's up to them
> to decide on the defaults.
>
> Thanks,
> Sanne
>
>
> On 19 May 2018 at 01:28, Luis Barreiro  wrote:
> > I don't get your question.
> >
> > Hibernate does not enhance the entities by itself, you have to
> > explicitly use one of the build tool plugins (maven, gradle, ant) to
> > perform that step.
> >
> > Even then, the plugins have all the features disabled by default.
> >
> > The support for enhanced entities in hibernate is not something you can
> > enable or disable.
> >
> > The only thing configurable is the bytecode provider, and that is
> > something that has indeed changed for 5.3. AFAICT the generated bytecode
> > should be identical.
> >
> > Luis Barreiro
> >
> > Middleware Performance Team
> >
> > 
> >
> > On 05/18/2018 08:38 PM, Gail Badner wrote:
> >> I don't think it is, just need to confirm.
> >>
> >> Thanks,
> >> Gail
> >> ___
> >> hibernate-dev mailing list
> >> hibernate-dev@lists.jboss.org
> >> https://lists.jboss.org/mailman/listinfo/hibernate-dev
> >
> > ___
> > hibernate-dev mailing list
> > hibernate-dev@lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/hibernate-dev
> ___
> hibernate-dev mailing list
> hibernate-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] Is bytecode enhancement enabled by default in 5.3?

[Sanne Grinovero]

Hi Scott,

could you explain what you mean by "tradeoff" in this context?

Thanks!


On 20 May 2018 at 12:06, Scott Marlow  wrote:
> There is a tradeoff in WF deployment, between Hibernate bytecode (runtime)
> enhancing class transformers, being registered before CDI deployment, reads
> the entity classes.
>
> There is also the tradeoff between Hibernate bytecode (runtime) enhancing
> class transformers being registered too late because the persistent unit
> uses a datasourcedefinition.
>
> I asked Gail's question for 5.1.x and the answer was no.
>
> Now, for 5.3, I don't understand the answers yet.
>
> Anyway, wanted to mention the above, to share more info with all, as to why
> we are asking.
>
> Regards,
> Scott
>
> On Sat, May 19, 2018, 6:30 AM Sanne Grinovero  wrote:
>>
>> Hi Gail,
>>
>> perhaps your question is related to WildFly? As far as I know, WildFly
>> does enhance entities automatically during deployment.
>>
>> But as Luis suggested, Hibernate doesn't control this process so I'm
>> not sure if that's still the case in any development branch of
>> WildFly; probably a question for Scott.
>>
>> If not WildFly, other platforms might do the same but it's up to them
>> to decide on the defaults.
>>
>> Thanks,
>> Sanne
>>
>>
>> On 19 May 2018 at 01:28, Luis Barreiro  wrote:
>> > I don't get your question.
>> >
>> > Hibernate does not enhance the entities by itself, you have to
>> > explicitly use one of the build tool plugins (maven, gradle, ant) to
>> > perform that step.
>> >
>> > Even then, the plugins have all the features disabled by default.
>> >
>> > The support for enhanced entities in hibernate is not something you can
>> > enable or disable.
>> >
>> > The only thing configurable is the bytecode provider, and that is
>> > something that has indeed changed for 5.3. AFAICT the generated bytecode
>> > should be identical.
>> >
>> > Luis Barreiro
>> >
>> > Middleware Performance Team
>> >
>> > 
>> >
>> > On 05/18/2018 08:38 PM, Gail Badner wrote:
>> >> I don't think it is, just need to confirm.
>> >>
>> >> Thanks,
>> >> Gail
>> >> ___
>> >> hibernate-dev mailing list
>> >> hibernate-dev@lists.jboss.org
>> >> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>> >
>> > ___
>> > hibernate-dev mailing list
>> > hibernate-dev@lists.jboss.org
>> > https://lists.jboss.org/mailman/listinfo/hibernate-dev
>> ___
>> hibernate-dev mailing list
>> hibernate-dev@lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev