Re: [hibernate-dev] Hibernate ORM 5.2 backports
In some cases - maybe not these specifically - I know people ask your review when it gets tricky, as you're the most thorough reviewer and have deep knowledge of most areas :) Maybe that was the case, maybe not. Good to clarify either way. Thanks! Sanne On 30 January 2018 at 00:59, Gail Badner wrote: > I've seen at least one jira comment asking if I approve backporting to 5.2, > and I also remember seeing a PR that had "Requires Gail" label with a > comment suggesting bugfixes in older branches (including 5.2) must be > approved by me. > > I just wanted to make this clear so that bugfixes that should be backported > don't fall through the cracks. > > On Thu, Jan 25, 2018 at 9:51 AM, Steve Ebersole wrote: > >> I don't think anyone mentioned expecting you to do this. In fact the >> discussions I have had about this was that others would help with this >> (after 5.2.13). >> >> >> >> On Wed, Jan 24, 2018 at 5:20 PM Gail Badner wrote: >> >>> People seem to be relying on me to backport to 5.2. From a product >>> standpoint, there is no need to backport to 5.2 anymore once 5.3.0 is >>> released. Maybe 5.3.0 and 5.2.13 should be released together, with 5.2.13 >>> being the last 5.2 release. >>> >>> >From an earlier thread, it sounds like there is concern outside the ORM >>> team that we need to keep 5.2.x releases going for some time. >>> >>> What is the criteria for backporting? >>> >>> Steve, Andrea, and I had a brief discussion about backporting bugfixes >>> from >>> master to 5.2 when the bugs apply to master. Is there more discussion to >>> be >>> done about this? >>> >>> FWIW, backporting to active community branches is everyone's >>> responsibility, not mine alone. >>> >>> Regards, >>> Gail >>> ___ >>> hibernate-dev mailing list >>> hibernate-dev@lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/hibernate-dev >>> >> > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Hibernate ORM 5.2 backports
If it's a matter of reviewing code, I'm happy to help. In that case, my name should be added as a reviewer. BTW, I forget to check all the various ways I can be contacted, so a personal email or hipchat message. helps. On Tue, Jan 30, 2018 at 5:52 AM, Sanne Grinovero wrote: > In some cases - maybe not these specifically - I know people ask your > review when it gets tricky, as you're the most thorough reviewer and > have deep knowledge of most areas :) Maybe that was the case, maybe > not. Good to clarify either way. > > Thanks! > Sanne > > > On 30 January 2018 at 00:59, Gail Badner wrote: > > I've seen at least one jira comment asking if I approve backporting to > 5.2, > > and I also remember seeing a PR that had "Requires Gail" label with a > > comment suggesting bugfixes in older branches (including 5.2) must be > > approved by me. > > > > I just wanted to make this clear so that bugfixes that should be > backported > > don't fall through the cracks. > > > > On Thu, Jan 25, 2018 at 9:51 AM, Steve Ebersole > wrote: > > > >> I don't think anyone mentioned expecting you to do this. In fact the > >> discussions I have had about this was that others would help with this > >> (after 5.2.13). > >> > >> > >> > >> On Wed, Jan 24, 2018 at 5:20 PM Gail Badner wrote: > >> > >>> People seem to be relying on me to backport to 5.2. From a product > >>> standpoint, there is no need to backport to 5.2 anymore once 5.3.0 is > >>> released. Maybe 5.3.0 and 5.2.13 should be released together, with > 5.2.13 > >>> being the last 5.2 release. > >>> > >>> >From an earlier thread, it sounds like there is concern outside the > ORM > >>> team that we need to keep 5.2.x releases going for some time. > >>> > >>> What is the criteria for backporting? > >>> > >>> Steve, Andrea, and I had a brief discussion about backporting bugfixes > >>> from > >>> master to 5.2 when the bugs apply to master. Is there more discussion > to > >>> be > >>> done about this? > >>> > >>> FWIW, backporting to active community branches is everyone's > >>> responsibility, not mine alone. > >>> > >>> Regards, > >>> Gail > >>> ___ > >>> hibernate-dev mailing list > >>> hibernate-dev@lists.jboss.org > >>> https://lists.jboss.org/mailman/listinfo/hibernate-dev > >>> > >> > > ___ > > hibernate-dev mailing list > > hibernate-dev@lists.jboss.org > > https://lists.jboss.org/mailman/listinfo/hibernate-dev > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
[hibernate-dev] 5.3.0 release tomorrow
Wanted to remind everyone that tomorrow is the next time-boxed release for 5.3. I wanted to get everyone's opinions about the version number, whether this should be Beta2 or CR1. IMO It depends how you view the remaining challenges with the JPA TCK, with CR1 being the optimistic view. ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] 5.3.0 release tomorrow
On Tue, Jan 30, 2018 at 11:00 PM, Steve Ebersole wrote: > Wanted to remind everyone that tomorrow is the next time-boxed release for > 5.3. > > I wanted to get everyone's opinions about the version number, whether this > should be Beta2 or CR1. IMO It depends how you view the remaining > challenges with the JPA TCK, with CR1 being the optimistic view. > I like Beta2 better but if you need to move on, CR1 would be okay as a JPA 2.2 preview, as long as we later release 5.3.1 with any further changes that are needed (we still have to also pass the EE TCK). > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
[hibernate-dev] Could we have a Hibernate 5.3 compatibility layer that includes the ORM 5.1 Hibernate Session class
WildFly would like to have a version of 5.3+, that is compatible with ORM 5.1, with regard to the org.hibernate.session changes (including mapping of exceptions thrown, so that the same exceptions are thrown). Is it even possible to have an extra org.hibernate.Session interface + impl (bridge) that matches the same session included in 5.1? The impl would delegate to the real underlying org.hibernate.Session impl classes and also wrap thrown exceptions, so that Hibernate 5.1 native ORM apps, continue to work without code changes Or something like that. I could see how some users wouldn't want to use the compatibility layer to avoid extra overhead, so in WildFly, we would have to make that possible also. What do you think? We would need something similar in ORM 6.0+ that is also compatible with 5.1, if this is possible. Scott ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
