Re: [hibernate-dev] Hibernate ORM version for WildFly 10.1

[Gail Badner]

I've been reviewing the differences in APIs/SPIs for 5.0 vs 5.1. They are
primarily changes in SPI (which is OK), but there are a couple of changes
that I need to investigate further to ensure they won't affect
applications. I don't see anything insurmountable at this point. If
necessary, I think we can deal with these changes in a compatible way.

I'm running out of time to be able to release 5.1.1 today, so I will finish
looking at the API/SPI differences next week and post the results. If
something needs to be changed to be compatible, I will make those changes
in 5.1.2.

On to releasing 5.1.1...

On Thu, Aug 11, 2016 at 1:20 PM, Gail Badner  wrote:

> 5.0.10 and 5.1.1 needed to be delayed while we dealt with a critical bug,
> HHH-10795. I am also working with John O'Hara to fix a performance
> regression that was introduced into 5.0.10 and, presumably, would be in
> 5.1.1.
>
> Another reason I've been holding off on releasing 5.1.1 was because of the
> failures for https://github.com/wildfly/wildfly/pull/8984. It is only
> today that we got a clean build.
>
> The last couple of days I've been furiously backporting more bugfixes for
> regressions and longstanding bugs. I review everything going into 5.0 and
> 5.1 to reduce the risk of introducing new bugs and that takes time. I have
> found a couple of bugs doing this and I think this time is well spent.
>
> I ran the tck last night and it passed. I started reviewing changes using
> japi-compliance-checker and I need to finish that.
>
> I am on track to release 5.1.1 this week.
>
> Please be patient.
>
> Regards,
> Gail
>
> On Thu, Aug 11, 2016 at 11:57 AM, Scott Marlow  wrote:
>
>> ORM 5.1, has an improvement for how we interact with CDI, that I really
>> want to finish coding the WildFly side of, so I feel the *pain* of not
>> having this yet.
>>
>> On 08/11/2016 02:04 PM, Gunnar Morling wrote:
>> > Hi Scott,
>> >
>> >> As part of bringing ORM 5.1.1+ into WF 10.1 or 11, we need to first
>> >> ensure that ORM 5.1.1 is completely *compatible* with ORM 5.0.x.
>> >
>> > How does this ensuring look like? Is passing the WF test suite enough,
>> > or are there further criteria? If identifying changes to the API is what
>> > you are after, tools such as Japicmp
>> > (see https://github.com/siom79/japicmp) may help.
>>
>> Great tool, we are using it! :)
>>
>> >
>> > It would be great to have some sort of formalized guideline here,
>> > because otherwise there's potential for frustration on both sides. E.g.
>> > Sanne and me are waiting for an update, as it will make our lives for
>> > HSEARCH/OGM much easier, whereas you may feel pressurized to do some
>> > update you are not 100% comfortable about). Happy about any pointers if
>> > there are such rules already somewhere.
>>
>> I believe that the remaining analysis is to look through the git commits
>> that have been merged to the ORM 5.1.x branch, that are not already
>> merged to ORM 5.0.x.  I believe that only the git commits that Gail
>> hasn't yet reviewed, will be checked.  I'm not sure what the count or
>> complexity of those git commits are that need to be checked.  I'm not
>> sure of what else that we can do, to prove that ORM 5.1.x is ready for
>> WildFly 10.1/11.
>>
>> There are guideline documents that describe the agile development
>> process that we are following.  Send me a private email if your really
>> interested in reading them.
>>
>> >
>> > That said, doing the 5.1 upgrade in WF 10.1 would seem as the sensible
>> > thing to me, bringing new ORM features released quite a while ago to WF
>> > community users and allowing to hone/harden them there as needed. So I
>> > still haven't lost the hope that it might be happen :)
>>
>> We already have ORM 5.0.x as the baseline that we are hardening off of.
>> I'm fine with bringing ORM 5.1 in, as long as it's equally as hardened.
>>
>> >
>> > As a user, I'd be surprised otherwise and be wondering why I had to
>> > resort to the ORM module ZIP (see
>> > http://in.relation.to/2016/07/07/updating-hibernate-orm-in-wildfly/)
>> > instead of WF coming with the newer version OOTB.
>> >
>> > Thanks,
>> >
>> > --Gunnar
>> >
>> >
>> > 2016-08-11 17:05 GMT+02:00 Scott Marlow > > >:
>> >
>> >
>> >
>> > On 08/11/2016 10:45 AM, Sanne Grinovero wrote:
>> > > On 11 August 2016 at 15:19, Scott Marlow > > wrote:
>> > >>
>> > >> On 08/11/2016 06:19 AM, Sanne Grinovero wrote:
>> > >>>
>> > >>> I've been watching this:
>> > >>>  - https://github.com/wildfly/wildfly/pull/8984
>> > 
>> > >>>
>> > >>> And that's the reason I've been asking for a 5.1 release, as it
>> has
>> > >>> been blocked by issues for long.
>> > >>>
>> > >>> Indeed if this wasn't being tracked for 10.1 that's sad as we
>> need
>> > >>> WildFly releases with up to date versions of ORM to make better
>> > >>> progress on OGM and Search, I'm sorry i

[hibernate-dev] Preparing to release 5.1.1.Final

[Gail Badner]

Please do not push anything to 5.0 branch until 5.1.1.Final is released.

Thanks,
Gail
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev

[hibernate-dev] Build failure when building 5.1.1.Final

[Gail Badner]

I'm getting a build failure. [1]

Unless someone gets back to me shortly to help, I will have to postpone
releasing 5.1.1.Final until Monday.

Regards,
Gail

[1]
POM relocation to an other version number is not fully supported in Gradle
: xml-apis#xml-apis;2.0.2 relocated to xml-apis#xml-apis;1.0.b2.

FAILURE: Build failed with an exception.

* Where:
Build file
'/home/gbadner/git/hibernate-orm-5.1.1/hibernate-orm-modules/hibernate-orm-modules.gradle'
line: 146

* What went wrong:
A problem occurred configuring project ':hibernate-orm-modules'.
> Exception thrown while executing model rule:
org.gradle.api.publish.maven.plugins.MavenPublishPlugin$Rules#realizePublishingTasks(org.gradle.model.collection.CollectionBuilder,
org.gradle.api.Task, org.gradle.api.Task,
org.gradle.api.publish.PublishingExtension) >
create(publishMavenJavaPublicationToJboss-releases-repositoryRepository)
   > Cannot get property 'name' on null object
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] Build failure when building 5.1.1.Final

[Steve Ebersole]

Which version of Gradle are you using?

On Fri, Aug 12, 2016 at 4:51 PM Gail Badner  wrote:

> I'm getting a build failure. [1]
>
> Unless someone gets back to me shortly to help, I will have to postpone
> releasing 5.1.1.Final until Monday.
>
> Regards,
> Gail
>
> [1]
> POM relocation to an other version number is not fully supported in Gradle
> : xml-apis#xml-apis;2.0.2 relocated to xml-apis#xml-apis;1.0.b2.
>
> FAILURE: Build failed with an exception.
>
> * Where:
> Build file
>
> '/home/gbadner/git/hibernate-orm-5.1.1/hibernate-orm-modules/hibernate-orm-modules.gradle'
> line: 146
>
> * What went wrong:
> A problem occurred configuring project ':hibernate-orm-modules'.
> > Exception thrown while executing model rule:
>
> org.gradle.api.publish.maven.plugins.MavenPublishPlugin$Rules#realizePublishingTasks(org.gradle.model.collection.CollectionBuilder,
> org.gradle.api.Task, org.gradle.api.Task,
> org.gradle.api.publish.PublishingExtension) >
> create(publishMavenJavaPublicationToJboss-releases-repositoryRepository)
>> Cannot get property 'name' on null object
> ___
> hibernate-dev mailing list
> hibernate-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] Build failure when building 5.1.1.Final

[Gail Badner]

I executed `./gradlew --version`:


Gradle 2.10


Build time:   2015-12-21 21:15:04 UTC
Build number: none
Revision: 276bdcded730f53aa8c11b479986aafa58e124a6

Groovy:   2.4.4
Ant:  Apache Ant(TM) version 1.9.3 compiled on December 23 2013
JVM:  1.8.0_40 (Oracle Corporation 25.40-b25)
OS:   Linux 3.19.8-100.fc20.x86_64 amd64


On Fri, Aug 12, 2016 at 3:16 PM, Steve Ebersole  wrote:

> Which version of Gradle are you using?
>
> On Fri, Aug 12, 2016 at 4:51 PM Gail Badner  wrote:
>
>> I'm getting a build failure. [1]
>>
>> Unless someone gets back to me shortly to help, I will have to postpone
>> releasing 5.1.1.Final until Monday.
>>
>> Regards,
>> Gail
>>
>> [1]
>> POM relocation to an other version number is not fully supported in Gradle
>> : xml-apis#xml-apis;2.0.2 relocated to xml-apis#xml-apis;1.0.b2.
>>
>> FAILURE: Build failed with an exception.
>>
>> * Where:
>> Build file
>> '/home/gbadner/git/hibernate-orm-5.1.1/hibernate-orm-
>> modules/hibernate-orm-modules.gradle'
>> line: 146
>>
>> * What went wrong:
>> A problem occurred configuring project ':hibernate-orm-modules'.
>> > Exception thrown while executing model rule:
>> org.gradle.api.publish.maven.plugins.MavenPublishPlugin$
>> Rules#realizePublishingTasks(org.gradle.model.collection.
>> CollectionBuilder,
>> org.gradle.api.Task, org.gradle.api.Task,
>> org.gradle.api.publish.PublishingExtension) >
>> create(publishMavenJavaPublicationToJboss-releases-repositoryRepository)
>>> Cannot get property 'name' on null object
>> ___
>> hibernate-dev mailing list
>> hibernate-dev@lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>
>
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] Build failure when building 5.1.1.Final

[Steve Ebersole]

Ah, you may need to update that to 3 m1

On Fri, Aug 12, 2016, 5:29 PM Gail Badner  wrote:

> I executed `./gradlew --version`:
>
> 
> Gradle 2.10
> 
>
> Build time:   2015-12-21 21:15:04 UTC
> Build number: none
> Revision: 276bdcded730f53aa8c11b479986aafa58e124a6
>
> Groovy:   2.4.4
> Ant:  Apache Ant(TM) version 1.9.3 compiled on December 23 2013
> JVM:  1.8.0_40 (Oracle Corporation 25.40-b25)
> OS:   Linux 3.19.8-100.fc20.x86_64 amd64
>
>
> On Fri, Aug 12, 2016 at 3:16 PM, Steve Ebersole 
> wrote:
>
>> Which version of Gradle are you using?
>>
>> On Fri, Aug 12, 2016 at 4:51 PM Gail Badner  wrote:
>>
>>> I'm getting a build failure. [1]
>>>
>>> Unless someone gets back to me shortly to help, I will have to postpone
>>> releasing 5.1.1.Final until Monday.
>>>
>>> Regards,
>>> Gail
>>>
>>> [1]
>>> POM relocation to an other version number is not fully supported in
>>> Gradle
>>> : xml-apis#xml-apis;2.0.2 relocated to xml-apis#xml-apis;1.0.b2.
>>>
>>> FAILURE: Build failed with an exception.
>>>
>>> * Where:
>>> Build file
>>>
>>> '/home/gbadner/git/hibernate-orm-5.1.1/hibernate-orm-modules/hibernate-orm-modules.gradle'
>>> line: 146
>>>
>>> * What went wrong:
>>> A problem occurred configuring project ':hibernate-orm-modules'.
>>> > Exception thrown while executing model rule:
>>>
>>> org.gradle.api.publish.maven.plugins.MavenPublishPlugin$Rules#realizePublishingTasks(org.gradle.model.collection.CollectionBuilder,
>>> org.gradle.api.Task, org.gradle.api.Task,
>>> org.gradle.api.publish.PublishingExtension) >
>>> create(publishMavenJavaPublicationToJboss-releases-repositoryRepository)
>>>> Cannot get property 'name' on null object
>>> ___
>>> hibernate-dev mailing list
>>> hibernate-dev@lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>>
>>
>
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] Build failure when building 5.1.1.Final

[Gail Badner]

I updated Gradle to 2.14.1 and was able to continue the release process. :)

On Fri, Aug 12, 2016 at 4:04 PM, Steve Ebersole  wrote:

> Ah, you may need to update that to 3 m1
>
> On Fri, Aug 12, 2016, 5:29 PM Gail Badner  wrote:
>
>> I executed `./gradlew --version`:
>>
>> 
>> Gradle 2.10
>> 
>>
>> Build time:   2015-12-21 21:15:04 UTC
>> Build number: none
>> Revision: 276bdcded730f53aa8c11b479986aafa58e124a6
>>
>> Groovy:   2.4.4
>> Ant:  Apache Ant(TM) version 1.9.3 compiled on December 23 2013
>> JVM:  1.8.0_40 (Oracle Corporation 25.40-b25)
>> OS:   Linux 3.19.8-100.fc20.x86_64 amd64
>>
>>
>> On Fri, Aug 12, 2016 at 3:16 PM, Steve Ebersole 
>> wrote:
>>
>>> Which version of Gradle are you using?
>>>
>>> On Fri, Aug 12, 2016 at 4:51 PM Gail Badner  wrote:
>>>
 I'm getting a build failure. [1]

 Unless someone gets back to me shortly to help, I will have to postpone
 releasing 5.1.1.Final until Monday.

 Regards,
 Gail

 [1]
 POM relocation to an other version number is not fully supported in
 Gradle
 : xml-apis#xml-apis;2.0.2 relocated to xml-apis#xml-apis;1.0.b2.

 FAILURE: Build failed with an exception.

 * Where:
 Build file
 '/home/gbadner/git/hibernate-orm-5.1.1/hibernate-orm-
 modules/hibernate-orm-modules.gradle'
 line: 146

 * What went wrong:
 A problem occurred configuring project ':hibernate-orm-modules'.
 > Exception thrown while executing model rule:
 org.gradle.api.publish.maven.plugins.MavenPublishPlugin$
 Rules#realizePublishingTasks(org.gradle.model.collection.
 CollectionBuilder,
 org.gradle.api.Task, org.gradle.api.Task,
 org.gradle.api.publish.PublishingExtension) >
 create(publishMavenJavaPublicationToJboss-releases-
 repositoryRepository)
> Cannot get property 'name' on null object
 ___
 hibernate-dev mailing list
 hibernate-dev@lists.jboss.org
 https://lists.jboss.org/mailman/listinfo/hibernate-dev

>>>
>>
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev

[hibernate-dev] Hibernate ORM 5.1.1.Final has been released

[Gail Badner]

For details:
http://in.relation.to/2016/08/12/hibernate-orm-511-final-release/
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev

[hibernate-dev] Locale to/from String

[Steve Ebersole]

I have had a comment in LocaleType for quite some time to convert
fromString handling to use the Locale.Builder introduced in Java 7.  As
part of the 6.0 work I took a quick look at this.

I think we handle this incorrectly for certain cases currently.

Currently we implement toString(Locale) via Locale#toString, where the
authors specifically say "If both the language and country fields are
missing, this function will return the empty string, even if the variant,
script, or extensions field is present (you can't have a locale with just a
variant, the variant must accompany a well-formed language or country
code)."

However in fromString we actually allow for such cases.  Consider this test:

assertEquals(
"___ch123",
LocaleTypeDescriptor.INSTANCE.toString(
LocaleTypeDescriptor.INSTANCE.fromString( "__ch123" )
)
);

This actually ends up failing.  The assertion fails.
LocaleTypeDescriptor.INSTANCE.fromString(
"__ch123" ) does in fact parse us a Locale with no language, no
country/region and a variant of "ch123".  In fact if I check the Locale
fields individually they are all set that way.

However, as per that javadoc note, the call to LocaleTypeDescriptor#toString
(Locale#toString) returns "".

So the question becomes what we want to support here.  If the described
Java behavior is to not allow a Locale with just a variant (no language nor
country/region) I think we may want to enforce that here too.

Thoughts?
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] Locale to/from String

[Steve Ebersole]

We could also redo our toString support to support "__ch123" if we want.  I
just think its better to standardize if we are talking externalizations.


On Fri, Aug 12, 2016 at 8:47 PM Steve Ebersole  wrote:

> I have had a comment in LocaleType for quite some time to convert
> fromString handling to use the Locale.Builder introduced in Java 7.  As
> part of the 6.0 work I took a quick look at this.
>
> I think we handle this incorrectly for certain cases currently.
>
> Currently we implement toString(Locale) via Locale#toString, where the
> authors specifically say "If both the language and country fields are
> missing, this function will return the empty string, even if the variant,
> script, or extensions field is present (you can't have a locale with just
> a variant, the variant must accompany a well-formed language or country
> code)."
>
> However in fromString we actually allow for such cases.  Consider this
> test:
>
> assertEquals(
> "___ch123",
> LocaleTypeDescriptor.INSTANCE.toString(
> LocaleTypeDescriptor.INSTANCE.fromString( "__ch123" )
> )
> );
>
> This actually ends up failing.  The assertion fails.  
> LocaleTypeDescriptor.INSTANCE.fromString(
> "__ch123" ) does in fact parse us a Locale with no language, no
> country/region and a variant of "ch123".  In fact if I check the Locale
> fields individually they are all set that way.
>
> However, as per that javadoc note, the call to LocaleTypeDescriptor#toString
> (Locale#toString) returns "".
>
> So the question becomes what we want to support here.  If the described
> Java behavior is to not allow a Locale with just a variant (no language nor
> country/region) I think we may want to enforce that here too.
>
> Thoughts?
>
>
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev