Re: [hibernate-dev] CI slave 1 again (was Trouble with blog for ORM 5.0.9)

2016-03-15 Thread Emmanuel Bernard
Sanne, Davide, we had another of those extremely slow builds of slave1.
Incidentally, it is roughly the same time of day as my slow experience.

http://ci.hibernate.org/view/Website/job/in.relation.to/buildTimeTrend

Could we kill and restart it, we might have a bad neighbour.

Gail, I don't know about your local env, but you can follow build
progress on the CI server (check the Website builds tab).

On Mon 2016-03-14 22:27, Gail Badner wrote:
> Hibernate ORM 5.0.9.Final is released. Everything is done except the
> announcements.
> 
> I did `rake preview` and saw that my blog displayed correctly locally, so I
> cherry-picked the commit with my blog to production and pushed the commit.
> It's been over an hour and I still don't see it on http://in.relation.to/.
> 
> I tried `rake clean preview` on the production branch and now I see:
> 
> ***
> Starting preview server at http://localhost:4242 (Press Ctrl-C to shutdown)
> ***
> [2016-03-14 22:23:50] INFO  WEBrick 1.3.1
> [2016-03-14 22:23:50] INFO  ruby 2.2.1 (2015-02-26) [x86_64-linux]
> rake aborted!
> ERROR: Running Awestruct failed.
> /home/gbadner/git/in.relation.to-again/Rakefile:104:in `run_awestruct'
> /home/gbadner/git/in.relation.to-again/Rakefile:64:in `block in  (required)>'
> /home/gbadner/.rvm/gems/ruby-2.2.1/bin/ruby_executable_hooks:15:in `eval'
> /home/gbadner/.rvm/gems/ruby-2.2.1/bin/ruby_executable_hooks:15:in `'
> Tasks: TOP => preview
> (See full trace by running task with --trace)
> 
> Anyone have any idea what is wrong?
> 
> Thanks,
> Gail
> ___
> hibernate-dev mailing list
> hibernate-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


Re: [hibernate-dev] Trouble with blog for ORM 5.0.9

2016-03-15 Thread Gunnar Morling
Hi Gail,

Your post is there:
http://in.relation.to/2016/03/14/hibernate-orm-509-final-release/

The build ran exceptionally long (52 min, see here:
http://ci.hibernate.org/view/Website/job/in.relation.to/buildTimeTrend).
I'm not sure why, let's hope it was a one-time issue.

Regarding your local error, it's not clear from that message.
Appending "--trace" would help to reveal more information should the
issue remain.

--Gunnar



2016-03-15 6:27 GMT+01:00 Gail Badner :
> Hibernate ORM 5.0.9.Final is released. Everything is done except the
> announcements.
>
> I did `rake preview` and saw that my blog displayed correctly locally, so I
> cherry-picked the commit with my blog to production and pushed the commit.
> It's been over an hour and I still don't see it on http://in.relation.to/.
>
> I tried `rake clean preview` on the production branch and now I see:
>
> ***
> Starting preview server at http://localhost:4242 (Press Ctrl-C to shutdown)
> ***
> [2016-03-14 22:23:50] INFO  WEBrick 1.3.1
> [2016-03-14 22:23:50] INFO  ruby 2.2.1 (2015-02-26) [x86_64-linux]
> rake aborted!
> ERROR: Running Awestruct failed.
> /home/gbadner/git/in.relation.to-again/Rakefile:104:in `run_awestruct'
> /home/gbadner/git/in.relation.to-again/Rakefile:64:in `block in  (required)>'
> /home/gbadner/.rvm/gems/ruby-2.2.1/bin/ruby_executable_hooks:15:in `eval'
> /home/gbadner/.rvm/gems/ruby-2.2.1/bin/ruby_executable_hooks:15:in `'
> Tasks: TOP => preview
> (See full trace by running task with --trace)
>
> Anyone have any idea what is wrong?
>
> Thanks,
> Gail
> ___
> hibernate-dev mailing list
> hibernate-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


Re: [hibernate-dev] Trouble with blog for ORM 5.0.9

2016-03-15 Thread Vlad Mihalcea
I announced the release on Twitter.

Vlad

On Tue, Mar 15, 2016 at 10:17 AM, Gunnar Morling 
wrote:

> Hi Gail,
>
> Your post is there:
> http://in.relation.to/2016/03/14/hibernate-orm-509-final-release/
>
> The build ran exceptionally long (52 min, see here:
> http://ci.hibernate.org/view/Website/job/in.relation.to/buildTimeTrend).
> I'm not sure why, let's hope it was a one-time issue.
>
> Regarding your local error, it's not clear from that message.
> Appending "--trace" would help to reveal more information should the
> issue remain.
>
> --Gunnar
>
>
>
> 2016-03-15 6:27 GMT+01:00 Gail Badner :
> > Hibernate ORM 5.0.9.Final is released. Everything is done except the
> > announcements.
> >
> > I did `rake preview` and saw that my blog displayed correctly locally,
> so I
> > cherry-picked the commit with my blog to production and pushed the
> commit.
> > It's been over an hour and I still don't see it on
> http://in.relation.to/.
> >
> > I tried `rake clean preview` on the production branch and now I see:
> >
> >
> ***
> > Starting preview server at http://localhost:4242 (Press Ctrl-C to
> shutdown)
> >
> ***
> > [2016-03-14 22:23:50] INFO  WEBrick 1.3.1
> > [2016-03-14 22:23:50] INFO  ruby 2.2.1 (2015-02-26) [x86_64-linux]
> > rake aborted!
> > ERROR: Running Awestruct failed.
> > /home/gbadner/git/in.relation.to-again/Rakefile:104:in `run_awestruct'
> > /home/gbadner/git/in.relation.to-again/Rakefile:64:in `block in  > (required)>'
> > /home/gbadner/.rvm/gems/ruby-2.2.1/bin/ruby_executable_hooks:15:in `eval'
> > /home/gbadner/.rvm/gems/ruby-2.2.1/bin/ruby_executable_hooks:15:in
> `'
> > Tasks: TOP => preview
> > (See full trace by running task with --trace)
> >
> > Anyone have any idea what is wrong?
> >
> > Thanks,
> > Gail
> > ___
> > hibernate-dev mailing list
> > hibernate-dev@lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/hibernate-dev
> ___
> hibernate-dev mailing list
> hibernate-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


Re: [hibernate-dev] Trouble with blog for ORM 5.0.9

2016-03-15 Thread Davide D'Alto
> The build ran exceptionally long (52 min, see here:
> http://ci.hibernate.org/view/Website/job/in.relation.to/buildTimeTrend
).
> I'm not sure why, let's hope it was a one-time issue.

It seems to happen more often lately.
The same thing happened for the release of beanvalidation.org:
http://ci.hibernate.org/job/beanvalidation.org/buildTimeTrend
I suspect sometimes OS1 gets too much work and tends to slow down.




On Tue, Mar 15, 2016 at 8:46 AM, Vlad Mihalcea 
wrote:

> I announced the release on Twitter.
>
> Vlad
>
> On Tue, Mar 15, 2016 at 10:17 AM, Gunnar Morling 
> wrote:
>
> > Hi Gail,
> >
> > Your post is there:
> > http://in.relation.to/2016/03/14/hibernate-orm-509-final-release/
> >
> > The build ran exceptionally long (52 min, see here:
> > http://ci.hibernate.org/view/Website/job/in.relation.to/buildTimeTrend).
> > I'm not sure why, let's hope it was a one-time issue.
> >
> > Regarding your local error, it's not clear from that message.
> > Appending "--trace" would help to reveal more information should the
> > issue remain.
> >
> > --Gunnar
> >
> >
> >
> > 2016-03-15 6:27 GMT+01:00 Gail Badner :
> > > Hibernate ORM 5.0.9.Final is released. Everything is done except the
> > > announcements.
> > >
> > > I did `rake preview` and saw that my blog displayed correctly locally,
> > so I
> > > cherry-picked the commit with my blog to production and pushed the
> > commit.
> > > It's been over an hour and I still don't see it on
> > http://in.relation.to/.
> > >
> > > I tried `rake clean preview` on the production branch and now I see:
> > >
> > >
> >
> ***
> > > Starting preview server at http://localhost:4242 (Press Ctrl-C to
> > shutdown)
> > >
> >
> ***
> > > [2016-03-14 22:23:50] INFO  WEBrick 1.3.1
> > > [2016-03-14 22:23:50] INFO  ruby 2.2.1 (2015-02-26) [x86_64-linux]
> > > rake aborted!
> > > ERROR: Running Awestruct failed.
> > > /home/gbadner/git/in.relation.to-again/Rakefile:104:in `run_awestruct'
> > > /home/gbadner/git/in.relation.to-again/Rakefile:64:in `block in  > > (required)>'
> > > /home/gbadner/.rvm/gems/ruby-2.2.1/bin/ruby_executable_hooks:15:in
> `eval'
> > > /home/gbadner/.rvm/gems/ruby-2.2.1/bin/ruby_executable_hooks:15:in
> > `'
> > > Tasks: TOP => preview
> > > (See full trace by running task with --trace)
> > >
> > > Anyone have any idea what is wrong?
> > >
> > > Thanks,
> > > Gail
> > > ___
> > > hibernate-dev mailing list
> > > hibernate-dev@lists.jboss.org
> > > https://lists.jboss.org/mailman/listinfo/hibernate-dev
> > ___
> > hibernate-dev mailing list
> > hibernate-dev@lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/hibernate-dev
> >
> ___
> hibernate-dev mailing list
> hibernate-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


[hibernate-dev] [HSEARCH] Rename elasticsearch artifact

2016-03-15 Thread Davide D'Alto
At the moment the elasticsearch integration artifactid is:

hibernate-search-backend-elasticsearch

Elasticsearch is actually more than just a backend (we use this term for
the jGroups and JMS integration). I think we should rename it to:

hibernate-search-elasticsearch


Thanks,
Davide
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


Re: [hibernate-dev] [HSEARCH] Rename elasticsearch artifact

2016-03-15 Thread Sanne Grinovero
On 15 March 2016 at 17:21, Davide D'Alto  wrote:
> At the moment the elasticsearch integration artifactid is:
>
> hibernate-search-backend-elasticsearch
>
> Elasticsearch is actually more than just a backend (we use this term for
> the jGroups and JMS integration). I think we should rename it to:
>
> hibernate-search-elasticsearch

+1 (since I forced you to send this email...)
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


Re: [hibernate-dev] Trouble with blog for ORM 5.0.9

2016-03-15 Thread Gail Badner
I know I've never had to wait so long before. I'm glad it's OK.

Vlad, thanks for announcing on Twitter. I'll re-push the commits for
HHH-10592 and HHH-10608 to 5.0 shortly.

On Tue, Mar 15, 2016 at 3:28 AM, Davide D'Alto 
wrote:

> > The build ran exceptionally long (52 min, see here:
> > http://ci.hibernate.org/view/Website/job/in.relation.to/buildTimeTrend
> ).
> > I'm not sure why, let's hope it was a one-time issue.
>
> It seems to happen more often lately.
> The same thing happened for the release of beanvalidation.org:
> http://ci.hibernate.org/job/beanvalidation.org/buildTimeTrend
> I suspect sometimes OS1 gets too much work and tends to slow down.
>
>
>
>
> On Tue, Mar 15, 2016 at 8:46 AM, Vlad Mihalcea 
> wrote:
>
> > I announced the release on Twitter.
> >
> > Vlad
> >
> > On Tue, Mar 15, 2016 at 10:17 AM, Gunnar Morling 
> > wrote:
> >
> > > Hi Gail,
> > >
> > > Your post is there:
> > > http://in.relation.to/2016/03/14/hibernate-orm-509-final-release/
> > >
> > > The build ran exceptionally long (52 min, see here:
> > > http://ci.hibernate.org/view/Website/job/in.relation.to/buildTimeTrend
> ).
> > > I'm not sure why, let's hope it was a one-time issue.
> > >
> > > Regarding your local error, it's not clear from that message.
> > > Appending "--trace" would help to reveal more information should the
> > > issue remain.
> > >
> > > --Gunnar
> > >
> > >
> > >
> > > 2016-03-15 6:27 GMT+01:00 Gail Badner :
> > > > Hibernate ORM 5.0.9.Final is released. Everything is done except the
> > > > announcements.
> > > >
> > > > I did `rake preview` and saw that my blog displayed correctly
> locally,
> > > so I
> > > > cherry-picked the commit with my blog to production and pushed the
> > > commit.
> > > > It's been over an hour and I still don't see it on
> > > http://in.relation.to/.
> > > >
> > > > I tried `rake clean preview` on the production branch and now I see:
> > > >
> > > >
> > >
> >
> ***
> > > > Starting preview server at http://localhost:4242 (Press Ctrl-C to
> > > shutdown)
> > > >
> > >
> >
> ***
> > > > [2016-03-14 22:23:50] INFO  WEBrick 1.3.1
> > > > [2016-03-14 22:23:50] INFO  ruby 2.2.1 (2015-02-26) [x86_64-linux]
> > > > rake aborted!
> > > > ERROR: Running Awestruct failed.
> > > > /home/gbadner/git/in.relation.to-again/Rakefile:104:in
> `run_awestruct'
> > > > /home/gbadner/git/in.relation.to-again/Rakefile:64:in `block in  > > > (required)>'
> > > > /home/gbadner/.rvm/gems/ruby-2.2.1/bin/ruby_executable_hooks:15:in
> > `eval'
> > > > /home/gbadner/.rvm/gems/ruby-2.2.1/bin/ruby_executable_hooks:15:in
> > > `'
> > > > Tasks: TOP => preview
> > > > (See full trace by running task with --trace)
> > > >
> > > > Anyone have any idea what is wrong?
> > > >
> > > > Thanks,
> > > > Gail
> > > > ___
> > > > hibernate-dev mailing list
> > > > hibernate-dev@lists.jboss.org
> > > > https://lists.jboss.org/mailman/listinfo/hibernate-dev
> > > ___
> > > hibernate-dev mailing list
> > > hibernate-dev@lists.jboss.org
> > > https://lists.jboss.org/mailman/listinfo/hibernate-dev
> > >
> > ___
> > hibernate-dev mailing list
> > hibernate-dev@lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/hibernate-dev
> >
> ___
> hibernate-dev mailing list
> hibernate-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


[hibernate-dev] Hibernate ORM 5.0.9.Final has been released

2016-03-15 Thread Gail Badner
For details:
http://in.relation.to/2016/03/14/hibernate-orm-509-final-release/
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


Re: [hibernate-dev] HHH-8999/HHH-10413 and Comparable IDs

2016-03-15 Thread Gail Badner
HHH-9322 involves a custom user type for an ID.

On Mon, Mar 14, 2016 at 12:38 AM, Gail Badner  wrote:

> In addition to affecting entity IDs [1], this also affects collection keys
> [2].
>
> I've also reproduced a similar problem when an implementation of UserType
> in a composite ID or collection key will fail, unless the implementation
> extends Comparator. This is because CustomType#getComparator returns
> (Comparator) userType [3]; UserType and EnhancedUserType do not implement
> Comparator.
>
> IMO, we should not add a requirement that classes used for an ID or
> collection key must implement Comparable. I'm also not crazy about using
> IncomparableComparator for ID types that don't implement Comparable.
>
> My preference would be for EntityAction#compareTo only compare the IDs if:
>
> Comparable.class.isAssignableFrom(
> persister.getIdentifierType().getReturnedClass()
> )
>
> Similarly for CollectionAction#compareTo, the collection keys would only
> be compared if:
>
> Comparable.class.isAssignableFrom(
> persister.getKeyType().getReturnedClass()
> )
>
> Can the Javadoc for Type#compare be changed to say that Type#compare
> should only be called if Comparable.class.isAssignableFrom(
> getReturnedClass() )? The ways that Hibernate uses Type#compare is very
> limited, I *think* this should be OK.
>
> A comparator for VersionType is important when using the 2nd-level cache.
>
> The Javadoc for org.hibernate.cache.spi.CacheDataDescription#isVersioned
> says:
>
> "If {@code true}, it is illegal for {@link #getVersionComparator} to
> return {@code null}."  [4]
>
> Since byte[] is used for versions, then BinaryType#getComparator needs to
> return a non-null Comparator that actually compares the values (not
> IncomparableComparator).
>
> IMO, it would be a little strange for BinaryType#compare to throw an
> exception but have BinaryType#getComparator return a non-null Comparator
> that actually compares the values. I could be convinced it's OK though.
>
> FWIW, an advantage of having BinaryType#getComparator return the
> Comparator direction (instead of delegating to
> PrimitiveByteArrayTypeDescriptor) is that the other types that use
> PrimitiveByteArrayTypeDescriptor, ImageType and MaterializedBlobType, will
> not have a Comparator defined. I think that makes sense since ImageType and
> MaterializedBlobType really should not be compared.
>
> Please let me know what you think about all this.
>
> Unfortunately it looks like this fix will not make it into 5.0.9.
>
> [1]
> https://github.com/hibernate/hibernate-orm/blob/master/hibernate-core/src/main/java/org/hibernate/action/internal/EntityAction.java#L154
> [2]
> https://github.com/hibernate/hibernate-orm/blob/master/hibernate-core/src/main/java/org/hibernate/action/internal/CollectionAction.java#L159
> [3]
> https://github.com/hibernate/hibernate-orm/blob/master/hibernate-core/src/main/java/org/hibernate/type/CustomType.java#L182
> [4]
> https://github.com/hibernate/hibernate-orm/blob/master/hibernate-core/src/main/java/org/hibernate/cache/spi/CacheDataDescription.java#L29
>
>
> On Fri, Mar 11, 2016 at 11:47 AM, Gail Badner  wrote:
>
>> Hibernate supports byte[] versions. You can see that 
>> org.hibernate.type.BinaryType implements VersionType. [1]
>>
>> The comment in BinaryType#seed says:
>>  // Note : simply returns null for seed() and next() as the only 
>> known
>>  //  application of binary types for versioning is 
>> for use with the
>>  //  TIMESTAMP datatype supported by Sybase and SQL 
>> Server, which
>>  //  are completely db-generated values...
>>
>> There is also a unit test, 
>> org.hibernate.test.version.sybase.SybaseTimestampVersioningTest that maps:
>>
>> 
>> 
>> 
>>
>> [1] 
>> https://github.com/hibernate/hibernate-orm/blob/master/hibernate-core/src/main/java/org/hibernate/type/BinaryType.java
>>
>>
>> On Fri, Mar 11, 2016 at 7:36 AM, Emmanuel Bernard > > wrote:
>>
>>> Version can be a byte[] ? I thought JPA was restricting version types
>>> actually.
>>>
>>> On Thu 2016-03-10 12:19, Gail Badner wrote:
>>> > As I mentioned before, it is not acceptable for the comparator for
>>> > PrimitiveByteArrayTypeDescripter to be IncomparableComparator because a
>>> > version attribute can be of type byte[]. We definitely do not want all
>>> > byte[] version values to compare as equal. A Comparator needs to be
>>> > implemented at least for PrimitiveByteArrayTypeDescripter.
>>> >
>>> > I'm OK with changing getComparator() for
>>> PrimitiveCharacterArrayTypeDescriptor,
>>> > ByteArrayTypeDescriptor, and
>>> > CharacterArrayTypeDescriptor to return
>>> IncomparableComparator.INSTANCE. I
>>> > think that is a safer option than B) (making
>>> > IncomparableComparator.INSTANCE the default if the type is not
>>> assignable
>>> > to Comparable).
>>> >
>>> > I'm also OK with using what I implemented in the pull request.
>>> >
>>> > On Thu, Mar 10, 2016 at 7:27