Re: [hibernate-dev] http://www.hibernatespatial.org/
Hi Karel, I pushed the first version of the Spatial chapter into the new User Guide. I basically integrated the hibernatespatial.org documentation and changed all examples to match the current API in Hibernate 5. You can build the User Guide as follows: $ cd documentation $ gradle rUG $ ls target/asciidoc/userguide/html_single/Hibernate_User_Guide.html Let me know what you think and what else do you suggest we should add. Thanks, Vlad On Wed, Feb 24, 2016 at 8:38 PM, Vlad Mihalcea wrote: > Hi, > > I already started the Spatial chapter in the new User Guide. > I'm using your documentation as a starting point and build on top of that. > > All examples are built as unit tests so we are notified when things will > change. > I'll integrate it when I'm done and I'll send you an email with some steps > to build the User Guide. > After you review it, I'll collect all your findings improve it further. > > Vlad > > On Wed, Feb 24, 2016 at 8:30 PM, Karel Maesen wrote: > >> Hi Vlad, >> >> I think this is a good idea. I’m away on conference the second week of >> March, but afterwards I can make some time to help you write it up. >> >> Regards, >> >> Karel >> >> > On 20 Feb 2016, at 22:22, Vlad Mihalcea >> wrote: >> > >> > Hi Karel, >> > >> > Next week, I'm going to finish the SQL native chapter and then I have >> just the OSGI and Envers chapters to review. >> > But since Hibernate Spatial is not covered at all, I think it's good to >> start with Hibernate Spatial right after I'm done with the SQL native one. >> > >> > What do you think of this? >> > >> > Vlad >> > >> > On Sat, Feb 20, 2016 at 4:18 PM, Karel Maesen >> wrote: >> > HI all, >> > >> > First, there seems to be a problem with the hibernate-spatial mailing >> list that I was unaware of. The user in question reached out to me >> yesterday. I will investigate shortly. >> > >> > Fair point about the website not mentioning the move to Hibernate 5. I >> will put up a message for this on the site. >> > >> > For the near future what I’m hoping for is that first, we can have the >> hibernate spatial tutorial updated to version 5, and integrated into the >> Hibernate User Guide. After that I can have the hibernatespatial.org >> URL’s redirect to that chapter. To support users of the older versions (3.x >> and 4.x), we should also make sure that users can download older versions >> of hibernate-spatial jars, and can consult older versions of the spatial >> tutorial from the hibernate.org website. >> > >> > As for the mailing lists, I plan on announcing shortly that they will >> be discontinued by end of year, and that questions should be asked on the >> usual hibernate channels. Btw, how can I be notified about questions about >> Spatial on the hibernate forums? >> > >> > Vlad, have you some idea about time frame for starting on the Hibernate >> Spatial chapter? >> > >> > Regards, >> > >> > Karel >> > >> > >> > > On 20 Feb 2016, at 09:18, Vlad Mihalcea >> wrote: >> > > >> > > I also plan on writing a Hibernate Spatial Chapter in the new User >> Guide so >> > > we can complete the migration. >> > > But first, I need to finish the remaining chapters from the current >> User >> > > Guide. >> > > >> > > Vlad >> > > >> > > On Fri, Feb 19, 2016 at 6:03 PM, Davide D'Alto > > >> > > wrote: >> > > >> > >> The user registered to the hibernate-spatial mailing list but none >> of his >> > >> messages >> > >> appeared in the archive. >> > >> >> > >> On Fri, Feb 19, 2016 at 3:25 PM, Steve Ebersole > > >> > >> wrote: >> > >> >> > >>> Karel, a user was asking about problems using the hibernate-spatial >> > >> mailing >> > >>> list on IRC which precipitated a discussion about how we want deal >> with >> > >>> these things moving forward. For example, the >> > >>> http://www.hibernatespatial.org/ site is still up and running and >> really >> > >>> has no indication that the move to integrate Spatial into Hibernate >> > >> proper >> > >>> was completed. What do you want to have happen with that >> website/URL? >> > >>> >> > >>> As for other infrastructure, what would you like to have happen? It >> > >> seems >> > >>> like hibernate-spatial is a more user-focused mailing list, as >> opposed >> > >> to a >> > >>> dev mailing list? If so, Hibernate does not really do user mailing >> > >> lists. >> > >>> We prefer the forums or StackOverflow for user questions, so there >> is >> > >> not a >> > >>> straight "migration". You can obviously keep the hibernate-spatial >> > >> mailing >> > >>> list running too, but we should have some idea how to help users >> who are >> > >>> having trouble with it on the website (which website depends on >> what you >> > >>> decide to do with http://www.hibernatespatial.org/. >> > >>> >> > >>> Any other things we should discuss in terms of infrastructure? >> > >>> >> > >>> Davide, what was the exact problem the user on IRC was complaining >> about >> > >>> wrt the hibernate-spatial mailing list? >> > >>>
[hibernate-dev] Dealing with CI failures due to javadoc warnings during spikes
We're doing fast iterations on the experimental Elasticsearch support for Hibernate Search, and by doing so there have been introduced temporary changes so we can make progress while sharing code with each other. CI is used to highly polished code, so it's failing the builds for petty warning like an @arg or @return missing on a javadoc documented method. I'm proposing to disable this validation and open a JIRA to fix all javadocs at the end of the iteration, i.e. making it a blocker task for a candidate release, yet ignore them until we get so far. Or would you rather try to keep javadoc polished during the process? Thanks, Sanne ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
[hibernate-dev] [Search] Elasticsearch TermQuery translation
Hi Gunnar, In ToElasticsearch, you have translated the Lucene TermQuery to a match query [1] in Elasticsearch. >From what I see, it should be a term query [2] instead. Don't you agree? [1] https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-match-query.html [2] https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-term-query.html If you agree, I'll fix it in my tree. FYI, I'm working on getting the DSLTest working. -- Guillaume ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] [Search] Elasticsearch TermQuery translation
Hi Guillaume, Yes, that seems reasonable. Thanks for fixing it! @Sanne, can we aim for another Alpha release tomorrow? Then I can show released bits in my talk :) @Guillaume, do you think you could provide the fix for such release? It's ok if still some tests of DSLTest fail, any progress is beneficial. Thanks, --Gunnar 2016-02-25 15:51 GMT+01:00 Guillaume Smet : > Hi Gunnar, > > In ToElasticsearch, you have translated the Lucene TermQuery to a match > query [1] in Elasticsearch. > > >From what I see, it should be a term query [2] instead. Don't you agree? > > [1] > https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-match-query.html > [2] > https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-term-query.html > > If you agree, I'll fix it in my tree. > > FYI, I'm working on getting the DSLTest working. > > -- > Guillaume > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] [Search] Elasticsearch TermQuery translation
On 25 February 2016 at 15:03, Gunnar Morling wrote: > Hi Guillaume, > > Yes, that seems reasonable. Thanks for fixing it! > > @Sanne, can we aim for another Alpha release tomorrow? Then I can show > released bits in my talk :) +1. When exactly is your presentation? I'd like we could blog about what we have, but a MVP requires docs. So we need to identify a "pencils down" deadline and give docs writing some love before the release. > > @Guillaume, do you think you could provide the fix for such release? > It's ok if still some tests of DSLTest fail, any progress is > beneficial. > > Thanks, > > --Gunnar > > > > > 2016-02-25 15:51 GMT+01:00 Guillaume Smet : >> Hi Gunnar, >> >> In ToElasticsearch, you have translated the Lucene TermQuery to a match >> query [1] in Elasticsearch. >> >> >From what I see, it should be a term query [2] instead. Don't you agree? >> >> [1] >> https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-match-query.html >> [2] >> https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-term-query.html >> >> If you agree, I'll fix it in my tree. >> >> FYI, I'm working on getting the DSLTest working. >> >> -- >> Guillaume >> ___ >> hibernate-dev mailing list >> hibernate-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] [Search] Elasticsearch TermQuery translation
It's Monday morning. Having at least rudimentary docs would be great, but I won't be able to contribute to that by then :/ How about doing another "stealth Alpha" tomorrow and then do another, properly announced, one by the end of the current HSEARCH sprint? Then we can include some more useful stuff into the first "official" Alpha and also have a tad more time to work on docs. WDYT? --Gunnar 2016-02-25 16:06 GMT+01:00 Sanne Grinovero : > On 25 February 2016 at 15:03, Gunnar Morling wrote: >> Hi Guillaume, >> >> Yes, that seems reasonable. Thanks for fixing it! >> >> @Sanne, can we aim for another Alpha release tomorrow? Then I can show >> released bits in my talk :) > > +1. When exactly is your presentation? I'd like we could blog about > what we have, but a MVP requires docs. > > So we need to identify a "pencils down" deadline and give docs writing > some love before the release. > >> >> @Guillaume, do you think you could provide the fix for such release? >> It's ok if still some tests of DSLTest fail, any progress is >> beneficial. >> >> Thanks, >> >> --Gunnar >> >> >> >> >> 2016-02-25 15:51 GMT+01:00 Guillaume Smet : >>> Hi Gunnar, >>> >>> In ToElasticsearch, you have translated the Lucene TermQuery to a match >>> query [1] in Elasticsearch. >>> >>> >From what I see, it should be a term query [2] instead. Don't you agree? >>> >>> [1] >>> https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-match-query.html >>> [2] >>> https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-term-query.html >>> >>> If you agree, I'll fix it in my tree. >>> >>> FYI, I'm working on getting the DSLTest working. >>> >>> -- >>> Guillaume >>> ___ >>> hibernate-dev mailing list >>> hibernate-dev@lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/hibernate-dev >> ___ >> hibernate-dev mailing list >> hibernate-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] [Search] Elasticsearch TermQuery translation
On Thu, Feb 25, 2016 at 4:03 PM, Gunnar Morling wrote: > @Guillaume, do you think you could provide the fix for such release? > It's ok if still some tests of DSLTest fail, any progress is > beneficial. > Mmmh, I can push the fixes I made but we can't run the DSLTest yet as it's depending on spatial (and we can't initialize spatial fields yet). Or maybe, we should move the spatial stuff to another test? It makes sense to me. I'll see what I have tomorrow. Keep me posted of the release time. -- Guillaume ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] [Search] Elasticsearch TermQuery translation
> Or maybe, we should move the spatial stuff to another test? It makes sense > to me. Yes, that sounds good. I hope it's not too much trouble to split the test entities etc. 2016-02-25 16:15 GMT+01:00 Guillaume Smet : > On Thu, Feb 25, 2016 at 4:03 PM, Gunnar Morling > wrote: >> >> @Guillaume, do you think you could provide the fix for such release? >> It's ok if still some tests of DSLTest fail, any progress is >> beneficial. > > > Mmmh, I can push the fixes I made but we can't run the DSLTest yet as it's > depending on spatial (and we can't initialize spatial fields yet). > > Or maybe, we should move the spatial stuff to another test? It makes sense > to me. > > I'll see what I have tomorrow. Keep me posted of the release time. > > -- > Guillaume ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] [Search] Elasticsearch TermQuery translation
On 25 February 2016 at 15:14, Gunnar Morling wrote: > It's Monday morning. > > Having at least rudimentary docs would be great, but I won't be able > to contribute to that by then :/ > > How about doing another "stealth Alpha" tomorrow and then do another, > properly announced, one by the end of the current HSEARCH sprint? Then > we can include some more useful stuff into the first "official" Alpha > and also have a tad more time to work on docs. If you want a "stealth release" then you're not allowed to talk about it in public ;) I'd rather we start thinking about docs and get a bit of traction in the news; I don't expect massive chapters, but at least let's provide some instructions for people to start playing with it. Think of the people coming at your presentaion, then wanting to play with it home.. Sanne > > WDYT? > > --Gunnar > > > > > 2016-02-25 16:06 GMT+01:00 Sanne Grinovero : >> On 25 February 2016 at 15:03, Gunnar Morling wrote: >>> Hi Guillaume, >>> >>> Yes, that seems reasonable. Thanks for fixing it! >>> >>> @Sanne, can we aim for another Alpha release tomorrow? Then I can show >>> released bits in my talk :) >> >> +1. When exactly is your presentation? I'd like we could blog about >> what we have, but a MVP requires docs. >> >> So we need to identify a "pencils down" deadline and give docs writing >> some love before the release. >> >>> >>> @Guillaume, do you think you could provide the fix for such release? >>> It's ok if still some tests of DSLTest fail, any progress is >>> beneficial. >>> >>> Thanks, >>> >>> --Gunnar >>> >>> >>> >>> >>> 2016-02-25 15:51 GMT+01:00 Guillaume Smet : Hi Gunnar, In ToElasticsearch, you have translated the Lucene TermQuery to a match query [1] in Elasticsearch. >From what I see, it should be a term query [2] instead. Don't you agree? [1] https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-match-query.html [2] https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-term-query.html If you agree, I'll fix it in my tree. FYI, I'm working on getting the DSLTest working. -- Guillaume ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev >>> ___ >>> hibernate-dev mailing list >>> hibernate-dev@lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] [Search] Elasticsearch TermQuery translation
2016-02-25 16:28 GMT+01:00 Sanne Grinovero : > On 25 February 2016 at 15:14, Gunnar Morling wrote: >> It's Monday morning. >> >> Having at least rudimentary docs would be great, but I won't be able >> to contribute to that by then :/ >> >> How about doing another "stealth Alpha" tomorrow and then do another, >> properly announced, one by the end of the current HSEARCH sprint? Then >> we can include some more useful stuff into the first "official" Alpha >> and also have a tad more time to work on docs. > > If you want a "stealth release" then you're not allowed to talk about > it in public ;) Hehe. > > I'd rather we start thinking about docs and get a bit of traction in the news; > I don't expect massive chapters, but at least let's provide some instructions > for people to start playing with it. Yes, I'd love that, too. It's just that I cannot do it myself right now, as I need to wrap up the slides/demo. So any help with some sort of "Getting started" guide would be greatly appreciated. Otherwise I can work on this next week. > > Think of the people coming at your presentaion, then wanting to play > with it home.. They can play with the released bits, applying what they memorized from the talk ;) > > Sanne > >> >> WDYT? >> >> --Gunnar >> >> >> >> >> 2016-02-25 16:06 GMT+01:00 Sanne Grinovero : >>> On 25 February 2016 at 15:03, Gunnar Morling wrote: Hi Guillaume, Yes, that seems reasonable. Thanks for fixing it! @Sanne, can we aim for another Alpha release tomorrow? Then I can show released bits in my talk :) >>> >>> +1. When exactly is your presentation? I'd like we could blog about >>> what we have, but a MVP requires docs. >>> >>> So we need to identify a "pencils down" deadline and give docs writing >>> some love before the release. >>> @Guillaume, do you think you could provide the fix for such release? It's ok if still some tests of DSLTest fail, any progress is beneficial. Thanks, --Gunnar 2016-02-25 15:51 GMT+01:00 Guillaume Smet : > Hi Gunnar, > > In ToElasticsearch, you have translated the Lucene TermQuery to a match > query [1] in Elasticsearch. > > >From what I see, it should be a term query [2] instead. Don't you agree? > > [1] > https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-match-query.html > [2] > https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-term-query.html > > If you agree, I'll fix it in my tree. > > FYI, I'm working on getting the DSLTest working. > > -- > Guillaume > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] [Search] Elasticsearch TermQuery translation
On 25 February 2016 at 15:37, Gunnar Morling wrote: > 2016-02-25 16:28 GMT+01:00 Sanne Grinovero : >> On 25 February 2016 at 15:14, Gunnar Morling wrote: >>> It's Monday morning. >>> >>> Having at least rudimentary docs would be great, but I won't be able >>> to contribute to that by then :/ >>> >>> How about doing another "stealth Alpha" tomorrow and then do another, >>> properly announced, one by the end of the current HSEARCH sprint? Then >>> we can include some more useful stuff into the first "official" Alpha >>> and also have a tad more time to work on docs. >> >> If you want a "stealth release" then you're not allowed to talk about >> it in public ;) > > Hehe. >> >> I'd rather we start thinking about docs and get a bit of traction in the >> news; >> I don't expect massive chapters, but at least let's provide some instructions >> for people to start playing with it. > > Yes, I'd love that, too. > > It's just that I cannot do it myself right now, as I need to wrap up > the slides/demo. So any help with some sort of "Getting started" guide > would be greatly appreciated. Otherwise I can work on this next week. Of course. It's probably not effective to have more than 2 people working on docs at the same time anyway. I'll start myself and find a review peer.. I can do the release process over the weekend and push the announcement on Monday, or maybe you want to reveal it on stage :) >> Think of the people coming at your presentaion, then wanting to play >> with it home.. > > They can play with the released bits, applying what they memorized > from the talk ;) > >> >> Sanne >> >>> >>> WDYT? >>> >>> --Gunnar >>> >>> >>> >>> >>> 2016-02-25 16:06 GMT+01:00 Sanne Grinovero : On 25 February 2016 at 15:03, Gunnar Morling wrote: > Hi Guillaume, > > Yes, that seems reasonable. Thanks for fixing it! > > @Sanne, can we aim for another Alpha release tomorrow? Then I can show > released bits in my talk :) +1. When exactly is your presentation? I'd like we could blog about what we have, but a MVP requires docs. So we need to identify a "pencils down" deadline and give docs writing some love before the release. > > @Guillaume, do you think you could provide the fix for such release? > It's ok if still some tests of DSLTest fail, any progress is > beneficial. > > Thanks, > > --Gunnar > > > > > 2016-02-25 15:51 GMT+01:00 Guillaume Smet : >> Hi Gunnar, >> >> In ToElasticsearch, you have translated the Lucene TermQuery to a match >> query [1] in Elasticsearch. >> >> >From what I see, it should be a term query [2] instead. Don't you agree? >> >> [1] >> https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-match-query.html >> [2] >> https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-term-query.html >> >> If you agree, I'll fix it in my tree. >> >> FYI, I'm working on getting the DSLTest working. >> >> -- >> Guillaume >> ___ >> hibernate-dev mailing list >> hibernate-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
[hibernate-dev] [Search] Elasticsearch - Thoughts about analyzers and fieldbridges
Hi, Running the DSLTest is quite interesting as it runs a lot of different queries with different configurations. Here are some thoughts while working on it. 1/ Analyzers = Gunnar, I was wondering what you had in mind for analyzers: a) deal with them in Hibernate Search or b) let Elasticsearch do the analyze thingy. I'm not sure we can get a/ to work correctly (see below) and for b) we're going to need a way to disable the analyzers in Search for the entities managed by Elasticsearch. Take a phrase query "colder and whitening" extracted from DSLTest. As "and" is considered a stopword, the resulting PhraseQuery only contains colder & whitening so it's not possible to rebuild the phrase before sending it to Elasticsearch. We could try to use span queries but I'm not sure we'll be able to get it right with synonyms and so on. 2/ FieldBridges === Currently, the conversion from Date to JSON string is managed by a fieldbridge specific to the Elasticsearch backend (and it's not that easy to plug it in as we have seen it in a ticket). I'm wondering if it's a good fit and if we should not invent an entirely new thing to deal with the transformation between a given Java type and what a backend is waiting for. What made me think of it is that a test from DSLTest is using ignoreFieldBridge() on a date field and it disables the Date -> JSON string conversion entirely. Comments, thoughts? -- Guillaume ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] [Search] Elasticsearch - Thoughts about analyzers and fieldbridges
On 25 February 2016 at 17:16, Guillaume Smet wrote: > Hi, > > Running the DSLTest is quite interesting as it runs a lot of different > queries with different configurations. > > Here are some thoughts while working on it. > > 1/ Analyzers > = > > Gunnar, I was wondering what you had in mind for analyzers: a) deal with > them in Hibernate Search or b) let Elasticsearch do the analyze thingy. > > I'm not sure we can get a/ to work correctly (see below) and for b) we're > going to need a way to disable the analyzers in Search for the entities > managed by Elasticsearch. Right we need to validate and/or push the analyzers configuration to Elasticsearch, and then let him do the analysis work. https://hibernate.atlassian.net/browse/HSEARCH-2108 Davide is exploring this. We were just now discussing in chat how (if?) to validate the analyzer names which a user is attempting to use, when the named analyzer is not otherwise defined (on a Lucene backend this would cause an error during bootstrap as a "model validation failure"). For example, Elasticsearch defines a bunch of default analyzers out of the box, such as one named "whitespace". We should be able to validate that this is a valid analyzer name even though this wasn't explicitly defined using an @AnalyzerDef. By using the "analysis test" API of ES we should be able to validate names which have been configured on the ES server by other means too. One catch is the QueryDSL: AFAIR there are a couple of cases in which we invoke the analyzer directly to "preprocess" the tokens.. this either needs to be killed, or we invoke the ES server to do the same operation but that seems inefficient.. we'll see, I don't remember now for which cases we need such things and hopefully there will be an alternative strategy when it comes to run queries on ES. As a second step, we should also see if we can "push" new analyzer definitions to the ES server, taking them from our @AnalyzerDef.. not sure if that's doable. > Take a phrase query "colder and whitening" extracted from DSLTest. As "and" > is considered a stopword, the resulting PhraseQuery only contains colder & > whitening so it's not possible to rebuild the phrase before sending it to > Elasticsearch. We could try to use span queries but I'm not sure we'll be > able to get it right with synonyms and so on. > > 2/ FieldBridges > === > > Currently, the conversion from Date to JSON string is managed by a > fieldbridge specific to the Elasticsearch backend (and it's not that easy > to plug it in as we have seen it in a ticket). > > I'm wondering if it's a good fit and if we should not invent an entirely > new thing to deal with the transformation between a given Java type and > what a backend is waiting for. I agree, the current abstraction model doesn't cut it. Other than discussing a "FieldBriedge 2" which is significantly different and will take quite some work (and probably require a 6.0 due to API changes) I don't have a concrete plan for the short term.. you might want to propose something in the scope of current APIs? Keep in mind I'm working now to remove the Lucene Document notion from the LuceneWork types; in this pre-6 phase I think we'll want to have a translation phase between what the old fieldbridges are producing and the modernized backends. Essentially I hope we'll be rewriting it from the backend upwards, public API as last step.. until we're done there needs to be a translation processing, and this might live at a certain level initially and need to be moved while we make progress. > > What made me think of it is that a test from DSLTest is using > ignoreFieldBridge() on a date field and it disables the Date -> JSON string > conversion entirely. > > Comments, thoughts? > > -- > Guillaume > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] [Search] Elasticsearch - Thoughts about analyzers and fieldbridges
2016-02-25 18:48 GMT+01:00 Sanne Grinovero : > On 25 February 2016 at 17:16, Guillaume Smet wrote: >> Hi, >> >> Running the DSLTest is quite interesting as it runs a lot of different >> queries with different configurations. >> >> Here are some thoughts while working on it. >> >> 1/ Analyzers >> = >> >> Gunnar, I was wondering what you had in mind for analyzers: a) deal with >> them in Hibernate Search or b) let Elasticsearch do the analyze thingy. >> >> I'm not sure we can get a/ to work correctly (see below) and for b) we're >> going to need a way to disable the analyzers in Search for the entities >> managed by Elasticsearch. > > Right we need to validate and/or push the analyzers configuration to > Elasticsearch, > and then let him do the analysis work. > > https://hibernate.atlassian.net/browse/HSEARCH-2108 > > Davide is exploring this. We were just now discussing in chat how (if?) to > validate the analyzer names which a user is attempting to use, when the named > analyzer is not otherwise defined (on a Lucene backend this would cause an > error > during bootstrap as a "model validation failure"). > > For example, Elasticsearch defines a bunch of default analyzers out of the > box, > such as one named "whitespace". > We should be able to validate that this is a valid analyzer name > even though this wasn't explicitly defined using an @AnalyzerDef. > > By using the "analysis test" API of ES we should be able to validate names > which > have been configured on the ES server by other means too. That's nice, exactly what I was looking for. That way we can validate analyzer refs. > > One catch is the QueryDSL: AFAIR there are a couple of cases in which we > invoke > the analyzer directly to "preprocess" the tokens.. this either needs > to be killed, > or we invoke the ES server to do the same operation but that seems > inefficient.. we'll > see, I don't remember now for which cases we need such things and hopefully > there will be an alternative strategy when it comes to run queries on ES. Right, I'd disable analyzers in queries targeted at ES completely for now. I see there is an ignoreAnalyzer() option, seems like this should be implicitly set for ES? But then this setting seems not to be applied in the case at hand AFAICS. Or is this even a glitch in the current impl? > > As a second step, we should also see if we can "push" new analyzer definitions > to the ES server, taking them from our @AnalyzerDef.. not sure if that's > doable. Yes, I am not sure how well @AnalyzerDef can be mapped. The attributes are largely semantically similar to what's there in ES, but the specific annotations on our side may still not be a good fit. We'll see :) I don't think it's a blocker, in the worst case people can still push definitions through native API calls, at least in the first iteration. > >> Take a phrase query "colder and whitening" extracted from DSLTest. As "and" >> is considered a stopword, the resulting PhraseQuery only contains colder & >> whitening so it's not possible to rebuild the phrase before sending it to >> Elasticsearch. We could try to use span queries but I'm not sure we'll be >> able to get it right with synonyms and so on. >> >> 2/ FieldBridges >> === >> >> Currently, the conversion from Date to JSON string is managed by a >> fieldbridge specific to the Elasticsearch backend (and it's not that easy >> to plug it in as we have seen it in a ticket). >> >> I'm wondering if it's a good fit and if we should not invent an entirely >> new thing to deal with the transformation between a given Java type and >> what a backend is waiting for. > > I agree, the current abstraction model doesn't cut it. > Other than discussing a "FieldBriedge 2" which is significantly > different and will take quite some work > (and probably require a 6.0 due to API changes) I don't have a > concrete plan for the short term.. > you might want to propose something in the scope of current APIs? > > Keep in mind I'm working now to remove the Lucene Document notion from > the LuceneWork types; > in this pre-6 phase I think we'll want to have a translation phase > between what the old fieldbridges > are producing and the modernized backends. Essentially I hope we'll be > rewriting it from the backend upwards, > public API as last step.. until we're done there needs to be a > translation processing, and this might live > at a certain level initially and need to be moved while we make progress. +1 > >> >> What made me think of it is that a test from DSLTest is using >> ignoreFieldBridge() on a date field and it disables the Date -> JSON string >> conversion entirely. I think we can ignore this one for now. >> >> Comments, thoughts? >> >> -- >> Guillaume >> ___ >> hibernate-dev mailing list >> hibernate-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > ___ > hibernate-dev mailing list
[hibernate-dev] Welcome Martin Braun to the Hibernate committers club!
Hi all, Martin has been contributing to Hibernate Search since a year, and developed some very interesting extensions this summer in the scope of Google Summer of Code, and is still evolving those and generally helping and monitoring the project. He recently volunteered to try helping us with pull request review duty, and today he survived my most annoying and pedantic review, forcing him to show off with pretty advanced Git-fu and managing a complex rebase :) So we decided to award him with a set of keys to the reference repository, and he just pushed his first PR! Martin: do you want to introduce yourself to the others? I suspect you're the youngest committer we ever had? Welcome again! Sanne ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
