Re: [hibernate-dev] WildFly 10 + Hibernate ORM 5 integration status update...

2015-06-26 Thread Scott Marlow
The ISE message is:
"
Can not set java.lang.Long field 
org.jboss.as.test.integration.hibernate.search.Book.id to 
org.jboss.as.test.integration.hibernate.search.Book
", which does sound like a bug.


On 06/18/2015 01:41 PM, Steve Ebersole wrote:
> That should still be ok.  If it does not work, that would be a bug.
>
> On Thu, Jun 18, 2015 at 11:38 AM Sanne Grinovero  > wrote:
>
> On 18 June 2015 at 17:17, Scott Marlow  > wrote:
>  >
>  >
>  > On 06/18/2015 11:59 AM, Sanne Grinovero wrote:
>  >>
>  >> On 18 June 2015 at 15:55, Scott Marlow  > wrote:
>  >>>
>  >>> Sanne,
>  >>>
>  >>> The [1] pull request to bring Jipijapa source into WildFly
> master is
>  >>> merged.
>  >>>
>  >>> I pushed a copy of the (work in progress) ORM 5 changes to
> github [2].
>  >>>
>  >>> Is there a WildFly pull request for the changes to upgrade to
> Hibernate
>  >>> Search 5.4.0.Alpha1?  I didn't see one but I might of missed it.
>  >>
>  >>
>  >> No there isn't, as Hibernate Search 5.4.0.Alpha1 *requires*
> Hibernate
>  >> ORM 5.0.0.CR1.
>  >
>  >
>  > What needs to change on WildFly for the Hibernate Search upgrade?
>
>
> Nothing else changes. Just change the Hibernate Search version when
> you change the Hibernate ORM version.
>
>  > I started
>  > with just changing the WildFly (top level) pom.xml to reference HS
>  > 5.4.0.Alpha1.
>
> +1
>
>  >  Do you expect that the latest ORM master branch will work
>  > with HS 5.4.0.Alpha1 or is ORM 5.0.0.CR1 better?
>
> I didn't test the latest ORM master branch, but it will work with
> ORM 5.0.0.CR1.
>
>  > Locally, I am building the latest ORM master (built from source)
> and using
>  > Hibernate Search 5.4.0.Alpha1.  When running the WildFly
> testsuite, I see a
>  > few different errors.  One of them is from the
>  > HibernateSearchJPATestCase.testFullTextQuery test.
>  > http://pastebin.com/Q5xLrkpT shows the WildFly server.log
> contents from the
>  > Hibernate Search test.
>
> That looks like related to an Hibernate ORM change, not Search.
> The entity used for that test doesn't declare the fields as "public";
> that used to be ok in previous versions.
> You could workaround it by changing the test to use either public
> fields or traditional getters/setters?
> But we should check with Steve if that change was intentional? For
> now, better to workaround it in the test so we don't get stuck.
>
> Thanks!
> Sanne
>
>  >
>  >
>  >>
>  >> The two should be updated in synch this time, in future there
> will be
>  >> more flexibility.
>  >>
>  >>>
>  >>> Scott
>  >>>
>  >>> [1] https://github.com/wildfly/wildfly/pull/7509
>  >>>
>  >>> [2] https://github.com/scottmarlow/wildfly/tree/hibernate5_june18
> ___
> hibernate-dev mailing list
> hibernate-dev@lists.jboss.org 
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


Re: [hibernate-dev] WildFly 10 + Hibernate ORM 5 integration status update...

2015-06-26 Thread Sanne Grinovero
On 26 June 2015 at 15:02, Scott Marlow  wrote:
> The ISE message is:
> "
> Can not set java.lang.Long field
> org.jboss.as.test.integration.hibernate.search.Book.id to
> org.jboss.as.test.integration.hibernate.search.Book
> ", which does sound like a bug.

Hi Scott, could you just make those fields in the test "public", so we
can get an ORM5 version of WildFly to play with? We've lots more work
to do which is blocked by that.

I've opened HHH-9887 to track this, but I'd treat it as a minor
regression which shouldn't slow us down with integration in WildFly;
not least it would be much more convenient for us to reproduce this if
we upgrade WildFly first.

Thanks,
Sanne


>
> On 06/18/2015 01:41 PM, Steve Ebersole wrote:
>>
>> That should still be ok.  If it does not work, that would be a bug.
>>
>> On Thu, Jun 18, 2015 at 11:38 AM Sanne Grinovero > > wrote:
>>
>> On 18 June 2015 at 17:17, Scott Marlow > > wrote:
>>  >
>>  >
>>  > On 06/18/2015 11:59 AM, Sanne Grinovero wrote:
>>  >>
>>  >> On 18 June 2015 at 15:55, Scott Marlow > > wrote:
>>  >>>
>>  >>> Sanne,
>>  >>>
>>  >>> The [1] pull request to bring Jipijapa source into WildFly
>> master is
>>  >>> merged.
>>  >>>
>>  >>> I pushed a copy of the (work in progress) ORM 5 changes to
>> github [2].
>>  >>>
>>  >>> Is there a WildFly pull request for the changes to upgrade to
>> Hibernate
>>  >>> Search 5.4.0.Alpha1?  I didn't see one but I might of missed it.
>>  >>
>>  >>
>>  >> No there isn't, as Hibernate Search 5.4.0.Alpha1 *requires*
>> Hibernate
>>  >> ORM 5.0.0.CR1.
>>  >
>>  >
>>  > What needs to change on WildFly for the Hibernate Search upgrade?
>>
>>
>> Nothing else changes. Just change the Hibernate Search version when
>> you change the Hibernate ORM version.
>>
>>  > I started
>>  > with just changing the WildFly (top level) pom.xml to reference HS
>>  > 5.4.0.Alpha1.
>>
>> +1
>>
>>  >  Do you expect that the latest ORM master branch will work
>>  > with HS 5.4.0.Alpha1 or is ORM 5.0.0.CR1 better?
>>
>> I didn't test the latest ORM master branch, but it will work with
>> ORM 5.0.0.CR1.
>>
>>  > Locally, I am building the latest ORM master (built from source)
>> and using
>>  > Hibernate Search 5.4.0.Alpha1.  When running the WildFly
>> testsuite, I see a
>>  > few different errors.  One of them is from the
>>  > HibernateSearchJPATestCase.testFullTextQuery test.
>>  > http://pastebin.com/Q5xLrkpT shows the WildFly server.log
>> contents from the
>>  > Hibernate Search test.
>>
>> That looks like related to an Hibernate ORM change, not Search.
>> The entity used for that test doesn't declare the fields as "public";
>> that used to be ok in previous versions.
>> You could workaround it by changing the test to use either public
>> fields or traditional getters/setters?
>> But we should check with Steve if that change was intentional? For
>> now, better to workaround it in the test so we don't get stuck.
>>
>> Thanks!
>> Sanne
>>
>>  >
>>  >
>>  >>
>>  >> The two should be updated in synch this time, in future there
>> will be
>>  >> more flexibility.
>>  >>
>>  >>>
>>  >>> Scott
>>  >>>
>>  >>> [1] https://github.com/wildfly/wildfly/pull/7509
>>  >>>
>>  >>> [2] https://github.com/scottmarlow/wildfly/tree/hibernate5_june18
>> ___
>> hibernate-dev mailing list
>> hibernate-dev@lists.jboss.org 
>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>
>
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


[hibernate-dev] test case templates

2015-06-26 Thread Brett Meyer
Just wanted to point out a new repo in our GitHub org: 
https://github.com/hibernate/hibernate-test-case-templates

Many users have asked to have templates to use when creating 
reproducer/regression tests for bug reports.  As a starting point, I included 
both a standalone example, as well as one that uses our unit-test framework's 
BaseCoreFunctionalTest.

Feel free to make modifications to these, upstream, as necessary.  ORM is 
currently the only project with templates, but I assume this might be helpful 
for Search, Validator, and OGM as well.
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev