[hibernate-dev] [Validator] Build problems!?
Hi,
I seem to have a odd build problem and wondering whether someone could verify
the problem
or in any ways enlighten me regarding what's going on.
I can build the Validator master branch w/o problem ('mvn clean install'), but
a 'mvn deploy' (SNAPSHOT deploy)
fails (output below). The funny thing is that the failure seems to occur during
the main
compilation task which seems odd, since the classes compile fine when using the
'install' target.
It might be related to the fact that a 'deploy' enables different
profiles/settings, but a start
would be to figure out whether others have the same problem.
-- Hardy
P.S.: The Cloudbees HV-5.2-SNAPSHOT-DEPLOY job recently also fails erratically.
It might be the same problem.
mvn deploy
[INFO] Scanning for projects...
[INFO]
[INFO] Reactor Build Order:
[INFO]
[INFO] Hibernate Validator Aggregator
[INFO] Hibernate Validator Test Utils
[INFO] Hibernate Validator Engine
[INFO] Hibernate Validator Engine JDK 1.8 Tests
[INFO] Hibernate Validator Portable Extension
[INFO] Hibernate Validator TCK Runner
[INFO] Hibernate Validator Wildfly Integration Tests
[INFO] Hibernate Validator Annotation Processor
[INFO] Hibernate Validator Performance Tests
[INFO] Hibernate Validator OSGi Modules
[INFO] Hibernate Validator Karaf Features
[INFO] Hibernate Validator OSGi integration test
[INFO] Hibernate Validator Manual
[INFO] Hibernate Validator Distribution
[INFO]
[INFO]
[INFO] Building Hibernate Validator Aggregator 5.2.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-enforcer-plugin:1.0.1:enforce (enforce-java) @
hibernate-validator-parent ---
[INFO]
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @
hibernate-validator-parent ---
[INFO] Installing
/Users/hardy/work/hibernate/git/beanvalidation/validator/pom.xml to
/Users/hardy/tmp/m2/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/hibernate-validator-parent-5.2.0-SNAPSHOT.pom
[INFO]
[INFO] --- maven-deploy-plugin:2.7:deploy (default-deploy) @
hibernate-validator-parent ---
Downloading:
https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/maven-metadata.xml
Downloaded:
https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/maven-metadata.xml
(620 B at 0.3 KB/sec)
Uploading:
https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/hibernate-validator-parent-5.2.0-20150421.083018-230.pom
Uploaded:
https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/hibernate-validator-parent-5.2.0-20150421.083018-230.pom
(33 KB at 8.2 KB/sec)
Downloading:
https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/maven-metadata.xml
Downloaded:
https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/maven-metadata.xml
(839 B at 0.9 KB/sec)
Uploading:
https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/maven-metadata.xml
Uploaded:
https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/maven-metadata.xml
(620 B at 0.3 KB/sec)
Uploading:
https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/maven-metadata.xml
Uploaded:
https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/maven-metadata.xml
(839 B at 0.5 KB/sec)
[INFO]
[INFO]
[INFO] Building Hibernate Validator Test Utils 5.2.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-enforcer-plugin:1.0.1:enforce (enforce-java) @
hibernate-validator-test-utils ---
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @
hibernate-validator-test-utils ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory
/Users/hardy/work/hibernate/git/beanvalidation/validator/test-utils/src/main/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @
hibernate-validator-test-utils ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 11 source files to
/Users/hardy/work/hibernate/git/beanvalidation/validator/test-utils/target/classes
[INFO]
[INFO] --- maven
Re: [hibernate-dev] [Validator] Build problems!?
Interesting, an exception in the compiler?!
I'll try it too, but could you try a more up to date JDK?
On 21 April 2015 at 09:41, Hardy Ferentschik wrote:
> Hi,
>
> I seem to have a odd build problem and wondering whether someone could verify
> the problem
> or in any ways enlighten me regarding what's going on.
>
> I can build the Validator master branch w/o problem ('mvn clean install'),
> but a 'mvn deploy' (SNAPSHOT deploy)
> fails (output below). The funny thing is that the failure seems to occur
> during the main
> compilation task which seems odd, since the classes compile fine when using
> the 'install' target.
> It might be related to the fact that a 'deploy' enables different
> profiles/settings, but a start
> would be to figure out whether others have the same problem.
>
> -- Hardy
>
> P.S.: The Cloudbees HV-5.2-SNAPSHOT-DEPLOY job recently also fails
> erratically. It might be the same problem.
>
>
> mvn deploy
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO] Reactor Build Order:
> [INFO]
> [INFO] Hibernate Validator Aggregator
> [INFO] Hibernate Validator Test Utils
> [INFO] Hibernate Validator Engine
> [INFO] Hibernate Validator Engine JDK 1.8 Tests
> [INFO] Hibernate Validator Portable Extension
> [INFO] Hibernate Validator TCK Runner
> [INFO] Hibernate Validator Wildfly Integration Tests
> [INFO] Hibernate Validator Annotation Processor
> [INFO] Hibernate Validator Performance Tests
> [INFO] Hibernate Validator OSGi Modules
> [INFO] Hibernate Validator Karaf Features
> [INFO] Hibernate Validator OSGi integration test
> [INFO] Hibernate Validator Manual
> [INFO] Hibernate Validator Distribution
> [INFO]
> [INFO]
>
> [INFO] Building Hibernate Validator Aggregator 5.2.0-SNAPSHOT
> [INFO]
>
> [INFO]
> [INFO] --- maven-enforcer-plugin:1.0.1:enforce (enforce-java) @
> hibernate-validator-parent ---
> [INFO]
> [INFO] --- maven-install-plugin:2.3.1:install (default-install) @
> hibernate-validator-parent ---
> [INFO] Installing
> /Users/hardy/work/hibernate/git/beanvalidation/validator/pom.xml to
> /Users/hardy/tmp/m2/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/hibernate-validator-parent-5.2.0-SNAPSHOT.pom
> [INFO]
> [INFO] --- maven-deploy-plugin:2.7:deploy (default-deploy) @
> hibernate-validator-parent ---
> Downloading:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/maven-metadata.xml
> Downloaded:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/maven-metadata.xml
> (620 B at 0.3 KB/sec)
> Uploading:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/hibernate-validator-parent-5.2.0-20150421.083018-230.pom
> Uploaded:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/hibernate-validator-parent-5.2.0-20150421.083018-230.pom
> (33 KB at 8.2 KB/sec)
> Downloading:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/maven-metadata.xml
> Downloaded:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/maven-metadata.xml
> (839 B at 0.9 KB/sec)
> Uploading:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/maven-metadata.xml
> Uploaded:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/maven-metadata.xml
> (620 B at 0.3 KB/sec)
> Uploading:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/maven-metadata.xml
> Uploaded:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/maven-metadata.xml
> (839 B at 0.5 KB/sec)
> [INFO]
> [INFO]
>
> [INFO] Building Hibernate Validator Test Utils 5.2.0-SNAPSHOT
> [INFO]
>
> [INFO]
> [INFO] --- maven-enforcer-plugin:1.0.1:enforce (enforce-java) @
> hibernate-validator-test-utils ---
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @
> hibernate-validator-test-utils ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory
> /Users/hardy/work/hibernate/git/beanvalidation/validator/test-utils/src/main/resources
> [INFO]
> [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @
> hibernate-validator-test
Re: [hibernate-dev] [Validator] Build problems!?
Hi,
I cannot reproduce that issue in HV.
Could you try and run the Logging AP not via the compiler plug-in but via
the maven-annotation-plugin (
https://code.google.com/p/maven-annotation-plugin/)? E.g. like so:
maven-compiler-plugin
1.8
1.8
UTF-8
-proc:none
org.bsc.maven
maven-processor-plugin
2.2.4
${project.build.directory}/generated-sources
org.jboss.logging.processor.apt.LoggingToolsProcessor
process
generate-sources
process
org.jboss.logging
jboss-logging-processor
${jboss.logging.version}
--Gunnar
2015-04-21 10:41 GMT+02:00 Hardy Ferentschik :
> Hi,
>
> I seem to have a odd build problem and wondering whether someone could
> verify the problem
> or in any ways enlighten me regarding what's going on.
>
> I can build the Validator master branch w/o problem ('mvn clean install'),
> but a 'mvn deploy' (SNAPSHOT deploy)
> fails (output below). The funny thing is that the failure seems to occur
> during the main
> compilation task which seems odd, since the classes compile fine when
> using the 'install' target.
> It might be related to the fact that a 'deploy' enables different
> profiles/settings, but a start
> would be to figure out whether others have the same problem.
>
> -- Hardy
>
> P.S.: The Cloudbees HV-5.2-SNAPSHOT-DEPLOY job recently also fails
> erratically. It might be the same problem.
>
>
> mvn deploy
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO] Reactor Build Order:
> [INFO]
> [INFO] Hibernate Validator Aggregator
> [INFO] Hibernate Validator Test Utils
> [INFO] Hibernate Validator Engine
> [INFO] Hibernate Validator Engine JDK 1.8 Tests
> [INFO] Hibernate Validator Portable Extension
> [INFO] Hibernate Validator TCK Runner
> [INFO] Hibernate Validator Wildfly Integration Tests
> [INFO] Hibernate Validator Annotation Processor
> [INFO] Hibernate Validator Performance Tests
> [INFO] Hibernate Validator OSGi Modules
> [INFO] Hibernate Validator Karaf Features
> [INFO] Hibernate Validator OSGi integration test
> [INFO] Hibernate Validator Manual
> [INFO] Hibernate Validator Distribution
> [INFO]
> [INFO]
>
> [INFO] Building Hibernate Validator Aggregator 5.2.0-SNAPSHOT
> [INFO]
>
> [INFO]
> [INFO] --- maven-enforcer-plugin:1.0.1:enforce (enforce-java) @
> hibernate-validator-parent ---
> [INFO]
> [INFO] --- maven-install-plugin:2.3.1:install (default-install) @
> hibernate-validator-parent ---
> [INFO] Installing
> /Users/hardy/work/hibernate/git/beanvalidation/validator/pom.xml to
> /Users/hardy/tmp/m2/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/hibernate-validator-parent-5.2.0-SNAPSHOT.pom
> [INFO]
> [INFO] --- maven-deploy-plugin:2.7:deploy (default-deploy) @
> hibernate-validator-parent ---
> Downloading:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/maven-metadata.xml
> Downloaded:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/maven-metadata.xml
> (620 B at 0.3 KB/sec)
> Uploading:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/hibernate-validator-parent-5.2.0-20150421.083018-230.pom
> Uploaded:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/hibernate-validator-parent-5.2.0-20150421.083018-230.pom
> (33 KB at 8.2 KB/sec)
> Downloading:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/maven-metadata.xml
> Downloaded:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/maven-metadata.xml
> (839 B at 0.9 KB/sec)
> Uploading:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/maven-metadata.xml
> Uploaded:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/maven-metadata.xml
> (620 B at 0.3 KB/sec)
> Uploa
Re: [hibernate-dev] [Validator] Build problems!?
Ah, you may be running into this issue:
https://jira.codehaus.org/browse/MCOMPILER-236 ("Compilation error due to
MCOMPILER-157 in deploy phase").
Setting useIncrementalCompilation=false is named as a work-around there.
Either that or using the annotation-plugin as I described probably both
should do the trick.
2015-04-21 11:12 GMT+02:00 Sanne Grinovero :
> Interesting, an exception in the compiler?!
> I'll try it too, but could you try a more up to date JDK?
>
> On 21 April 2015 at 09:41, Hardy Ferentschik wrote:
> > Hi,
> >
> > I seem to have a odd build problem and wondering whether someone could
> verify the problem
> > or in any ways enlighten me regarding what's going on.
> >
> > I can build the Validator master branch w/o problem ('mvn clean
> install'), but a 'mvn deploy' (SNAPSHOT deploy)
> > fails (output below). The funny thing is that the failure seems to occur
> during the main
> > compilation task which seems odd, since the classes compile fine when
> using the 'install' target.
> > It might be related to the fact that a 'deploy' enables different
> profiles/settings, but a start
> > would be to figure out whether others have the same problem.
> >
> > -- Hardy
> >
> > P.S.: The Cloudbees HV-5.2-SNAPSHOT-DEPLOY job recently also fails
> erratically. It might be the same problem.
> >
> >
> > mvn deploy
> > [INFO] Scanning for projects...
> > [INFO]
>
> > [INFO] Reactor Build Order:
> > [INFO]
> > [INFO] Hibernate Validator Aggregator
> > [INFO] Hibernate Validator Test Utils
> > [INFO] Hibernate Validator Engine
> > [INFO] Hibernate Validator Engine JDK 1.8 Tests
> > [INFO] Hibernate Validator Portable Extension
> > [INFO] Hibernate Validator TCK Runner
> > [INFO] Hibernate Validator Wildfly Integration Tests
> > [INFO] Hibernate Validator Annotation Processor
> > [INFO] Hibernate Validator Performance Tests
> > [INFO] Hibernate Validator OSGi Modules
> > [INFO] Hibernate Validator Karaf Features
> > [INFO] Hibernate Validator OSGi integration test
> > [INFO] Hibernate Validator Manual
> > [INFO] Hibernate Validator Distribution
> > [INFO]
> > [INFO]
>
> > [INFO] Building Hibernate Validator Aggregator 5.2.0-SNAPSHOT
> > [INFO]
>
> > [INFO]
> > [INFO] --- maven-enforcer-plugin:1.0.1:enforce (enforce-java) @
> hibernate-validator-parent ---
> > [INFO]
> > [INFO] --- maven-install-plugin:2.3.1:install (default-install) @
> hibernate-validator-parent ---
> > [INFO] Installing
> /Users/hardy/work/hibernate/git/beanvalidation/validator/pom.xml to
> /Users/hardy/tmp/m2/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/hibernate-validator-parent-5.2.0-SNAPSHOT.pom
> > [INFO]
> > [INFO] --- maven-deploy-plugin:2.7:deploy (default-deploy) @
> hibernate-validator-parent ---
> > Downloading:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/maven-metadata.xml
> > Downloaded:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/maven-metadata.xml
> (620 B at 0.3 KB/sec)
> > Uploading:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/hibernate-validator-parent-5.2.0-20150421.083018-230.pom
> > Uploaded:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/hibernate-validator-parent-5.2.0-20150421.083018-230.pom
> (33 KB at 8.2 KB/sec)
> > Downloading:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/maven-metadata.xml
> > Downloaded:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/maven-metadata.xml
> (839 B at 0.9 KB/sec)
> > Uploading:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/maven-metadata.xml
> > Uploaded:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/5.2.0-SNAPSHOT/maven-metadata.xml
> (620 B at 0.3 KB/sec)
> > Uploading:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/maven-metadata.xml
> > Uploaded:
> https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator-parent/maven-metadata.xml
> (839 B at 0.5 KB/sec)
> > [INFO]
> > [INFO]
>
> > [INFO] Building Hibernate Validator Test Utils 5.2.0-SNAPSHOT
> > [INFO]
>
> > [INFO]
> > [INFO] --- maven-enforcer-plugin:1.0.1:enforce (enforce-ja
Re: [hibernate-dev] org.hibernate.cfg.Settings deprecated
Ok, silence will be taken as a vote to do whatever I feel is best regardless of impact on these integration impls... So anyone? On Thu, Apr 16, 2015 at 7:20 AM, Steve Ebersole wrote: > Last night I pushed some changes which included deprecating > org.hibernate.cfg.Settings in favor > of org.hibernate.boot.spi.SessionFactoryOptions. The main reason for this > was to make it easier for OGM and others to hook into the SessionFactory > creation process. For now, I have made Settings delegate > to SessionFactoryOptions. > > I am not sure if anything external relies on this Settings contract. But > there are a few usages I wanted to discuss. > > First is caching. Part of the SPI for building RegionFactrory is passing > along the Settings object. Ideally I'd just swap this with > SessionFactoryOptions. And given that this targets a major release (5.0), > that should be ok. Anyone against that? Sanne? Galder? Alex? > > Second is the initiation of BV integration. The TypesafeActivator > accesses the Settings object in order to > call org.hibernate.cfg.Settings#setCheckNullability. As of now, this is > the only setter method I have left on Settings (it simply passes that call > on to the SessionFactoryOptions, which exposes just this one setter for > just this one case). I'd like to make it so that SessionFactoryOptions is > immutable at the time SessionFactory is built. This was largely true for > Settings already aside from this one use case. I am just not sure yet of > the best way to allow an Integrator to affect this SessionFactoryBuilder > process. Thoughts? > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] org.hibernate.cfg.Settings deprecated
On Tue, Apr 21, 2015 at 01:09:53PM -0500, Steve Ebersole wrote: > Ok, silence will be taken as a vote to do whatever I feel is best > regardless of impact on these integration impls... So anyone? Sorry, I forgot about this one. TBH, I have not much useful to say on what the best way to do this is. It seems to make sense to disable ORM based null checking if Bean Validation is used (even though Emmanuel wrote this code initially. I am not 100% which kinds of scenarios this tries to prevent. My guess is that when this option is enabled and Bean Valdation's @NotNull is used as well, the ORM validation kicks in first and throws some ORM specific exception instead of the ConstraintViolationException one would expect in this case). So whatever you come up with, I would expect some possibility for the integrator to make sure ORM null checking is disabled. --Hardy > > On Thu, Apr 16, 2015 at 7:20 AM, Steve Ebersole wrote: > > > Last night I pushed some changes which included deprecating > > org.hibernate.cfg.Settings in favor > > of org.hibernate.boot.spi.SessionFactoryOptions. The main reason for this > > was to make it easier for OGM and others to hook into the SessionFactory > > creation process. For now, I have made Settings delegate > > to SessionFactoryOptions. > > > > I am not sure if anything external relies on this Settings contract. But > > there are a few usages I wanted to discuss. > > > > First is caching. Part of the SPI for building RegionFactrory is passing > > along the Settings object. Ideally I'd just swap this with > > SessionFactoryOptions. And given that this targets a major release (5.0), > > that should be ok. Anyone against that? Sanne? Galder? Alex? > > > > Second is the initiation of BV integration. The TypesafeActivator > > accesses the Settings object in order to > > call org.hibernate.cfg.Settings#setCheckNullability. As of now, this is > > the only setter method I have left on Settings (it simply passes that call > > on to the SessionFactoryOptions, which exposes just this one setter for > > just this one case). I'd like to make it so that SessionFactoryOptions is > > immutable at the time SessionFactory is built. This was largely true for > > Settings already aside from this one use case. I am just not sure yet of > > the best way to allow an Integrator to affect this SessionFactoryBuilder > > process. Thoughts? > > > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] org.hibernate.cfg.Settings deprecated
As long as we can explicitly disable things via API like we could in past this should be fine. i.e. in tools we used setting properties to disable second level caching, hibernate validator, connection pooling, tx management and search setup since it just doesn't either make sense or won't work when trying to load hibernate model outside an app server. /max > Ok, silence will be taken as a vote to do whatever I feel is best > regardless of impact on these integration impls... So anyone? > > On Thu, Apr 16, 2015 at 7:20 AM, Steve Ebersole > wrote: > >> Last night I pushed some changes which included deprecating >> org.hibernate.cfg.Settings in favor >> of org.hibernate.boot.spi.SessionFactoryOptions. The main reason for >> this >> was to make it easier for OGM and others to hook into the >> SessionFactory >> creation process. For now, I have made Settings delegate >> to SessionFactoryOptions. >> >> I am not sure if anything external relies on this Settings contract. >> But >> there are a few usages I wanted to discuss. >> >> First is caching. Part of the SPI for building RegionFactrory is >> passing >> along the Settings object. Ideally I'd just swap this with >> SessionFactoryOptions. And given that this targets a major release >> (5.0), >> that should be ok. Anyone against that? Sanne? Galder? Alex? >> >> Second is the initiation of BV integration. The TypesafeActivator >> accesses the Settings object in order to >> call org.hibernate.cfg.Settings#setCheckNullability. As of now, this >> is >> the only setter method I have left on Settings (it simply passes that >> call >> on to the SessionFactoryOptions, which exposes just this one setter >> for >> just this one case). I'd like to make it so that >> SessionFactoryOptions is >> immutable at the time SessionFactory is built. This was largely true >> for >> Settings already aside from this one use case. I am just not sure >> yet of >> the best way to allow an Integrator to affect this >> SessionFactoryBuilder >> process. Thoughts? >> > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev /max http://about.me/maxandersen ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] org.hibernate.cfg.Settings deprecated
That's really more a function of bootstrapping, not the actual Settings object. And yes, these hibernate.properties et al are still picked up and used. On Tue, Apr 21, 2015 at 4:14 PM, Max Rydahl Andersen wrote: > As long as we can explicitly disable things via API like we could in past > this should be fine. > > i.e. in tools we used setting properties to disable second level caching, > hibernate validator, connection pooling, tx management and search setup > since it just doesn't either make sense or won't work when trying > to load hibernate model outside an app server. > > /max > > Ok, silence will be taken as a vote to do whatever I feel is best >> regardless of impact on these integration impls... So anyone? >> >> On Thu, Apr 16, 2015 at 7:20 AM, Steve Ebersole >> wrote: >> >> Last night I pushed some changes which included deprecating >>> org.hibernate.cfg.Settings in favor >>> of org.hibernate.boot.spi.SessionFactoryOptions. The main reason for >>> this >>> was to make it easier for OGM and others to hook into the SessionFactory >>> creation process. For now, I have made Settings delegate >>> to SessionFactoryOptions. >>> >>> I am not sure if anything external relies on this Settings contract. But >>> there are a few usages I wanted to discuss. >>> >>> First is caching. Part of the SPI for building RegionFactrory is passing >>> along the Settings object. Ideally I'd just swap this with >>> SessionFactoryOptions. And given that this targets a major release >>> (5.0), >>> that should be ok. Anyone against that? Sanne? Galder? Alex? >>> >>> Second is the initiation of BV integration. The TypesafeActivator >>> accesses the Settings object in order to >>> call org.hibernate.cfg.Settings#setCheckNullability. As of now, this is >>> the only setter method I have left on Settings (it simply passes that >>> call >>> on to the SessionFactoryOptions, which exposes just this one setter for >>> just this one case). I'd like to make it so that SessionFactoryOptions >>> is >>> immutable at the time SessionFactory is built. This was largely true for >>> Settings already aside from this one use case. I am just not sure yet of >>> the best way to allow an Integrator to affect this SessionFactoryBuilder >>> process. Thoughts? >>> >>> ___ >> hibernate-dev mailing list >> hibernate-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev >> > > > /max > http://about.me/maxandersen > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
