Re: [hibernate-dev] Documentation on OGM + JBoss AS
Which failure do we want to address? 1. The integrator approach is not helping when using OGM/ORM on AS7. 2. The earlier failure that I haven't yet seen when the place holder is removed and we bootstrap with HibernateOgmPersistence.createContainerEntityManagerFactory(). Something else? On 11/13/2012 09:20 AM, Emmanuel Bernard wrote: > If you remove the place holder it will fail as well. Earlier actually, > so no. > On Tue 2012-11-13 8:20, Scott Marlow wrote: >> Let me know if you want me to try changing the OGM code that sets >> "---PlaceHolderDSForOGM---" to only set the datasource if its not >> already specified. >> >> For resolving why the OGM integrator being on the ORM classpath, is >> not enough to avoid the ORM datasource lookup, I'm not sure. >> >> On 11/12/2012 01:43 PM, Scott Marlow wrote: >>> Hardy pointed me to >>> https://github.com/hferentschik/ogm-kitchensink/blob/master/.openshift/config/modules/org/hibernate/ogm/module.xml >>> which duplicates some other AS modules jars in the OGM module. That is >>> going to be specific to which version of AS is being targeted (IMO) and >>> not something I recommend that we depend on. >>> >>> On 11/12/2012 12:46 PM, Emmanuel Bernard wrote: Hum, yes make sure to check the pom. There has been a few changes to some superclasses we extend. I did some changes in master for that. >>> >>> I was able to build OGM master against ORM 4.1.6 without getting build >>> errors. >>> Emmanuel On Mon 2012-11-12 12:00, Scott Marlow wrote: > Does it matter which version of Hibernate ORM is used (4.1.6 is what > we are currently using on AS master branch)? > > Which version of OGM should I try to use? Previously, I built OGM >from git master but I noticed that there is a beta1 available also. > > On 11/10/2012 05:41 PM, Scott Marlow wrote: >> Hi Sanne, >> >> I'm not sure why the module names didn't show for ogm/orm. >> >> I'll try again with the demo app. >> >> Scott >> >> >> Sent from my tardis >> >> >> -Original Message- >> From: Sanne Grinovero [sa...@hibernate.org] >> Received: Saturday, 10 Nov 2012, 2:56pm >> To: Scott Marlow [smar...@redhat.com] >> CC: Emmanuel Bernard [emman...@hibernate.org]; Hibernate Dev >> [hibernate-dev@lists.jboss.org] >> Subject: Re: [hibernate-dev] Documentation on OGM + JBoss AS >> >> >> Hi Scott, >> we don't have that error when testing on AS 7.1.1 with the >> kitchensink-ogm demo [1] so I'm confident the error is caused by some >> difference in the module; indeed I remember it being tricky to put the >> right things together: I can't test it on 7.2-SNAPSHOT now. >> >> We definitely don't specify any datasource in the demo configuration, >> but a custom module is required. >> >> Side question on the stacktrace you posted: why is the version number >> missing in the stack for Hibernate packages? Do we need to add that in >> the manifest? >> >> Sanne >> >> 1 - latest version at https://github.com/hferentschik/ogm-kitchensink >> >> On 9 November 2012 20:08, Scott Marlow wrote: >>> On 11/09/2012 11:37 AM, Emmanuel Bernard wrote: On Fri 2012-11-09 11:15, Scott Marlow wrote: > On 10/01/2012 11:12 AM, Emmanuel Bernard wrote: >> On Mon 2012-10-01 10:51, Scott Marlow wrote: >>> I got further yesterday (after removing the >>> ---PlaceHolderDSForOGM--- property from HibernateOgmPersistence). >>> Not sure what the long term change is (perhaps we should only add >>> the ---PlaceHolderDSForOGM--- for the non-container case). >> >> That may have changed but this place holder was mandatory to get OGM >> to start in some environment. >> At least make sure that these change does not break the SE mode. >> > > People are still hitting the "Caused by: > org.hibernate.service.jndi.JndiException: Unable to lookup JNDI name > [---PlaceHolderDSForOGM---]" error. > > Since people are still hitting the ---PlaceHolderDSForOGM--- induced > failure (on AS7), we should create a jira for addressing it. The > fix could be to only add ---PlaceHolderDSForOGM--- when booting in > standalone mode but not container. The placeholder is there because otherwise, some part of Hibernate EntityManager's configuration bootstrap complain. But this value should never be used because Hibernate OGM has an integrator that overrides the ConnectionProviderInitiator with a Noop version. The fact that Sergio's stacktrace shows Caused by: org.hibernate.service.jndi.JndiException: Unable to lookup JNDI name [---PlaceHolderDSForOGM---] at org.hibernate.service.jndi.int
Re: [hibernate-dev] Documentation on OGM + JBoss AS
Integrator is not working why? On 11/14/2012 10:05 AM, Scott Marlow wrote: > Which failure do we want to address? > > 1. The integrator approach is not helping when using OGM/ORM on AS7. > > 2. The earlier failure that I haven't yet seen when the place holder is > removed and we bootstrap with > HibernateOgmPersistence.createContainerEntityManagerFactory(). > > Something else? > > On 11/13/2012 09:20 AM, Emmanuel Bernard wrote: >> If you remove the place holder it will fail as well. Earlier actually, >> so no. >> On Tue 2012-11-13 8:20, Scott Marlow wrote: >>> Let me know if you want me to try changing the OGM code that sets >>> "---PlaceHolderDSForOGM---" to only set the datasource if its not >>> already specified. >>> >>> For resolving why the OGM integrator being on the ORM classpath, is >>> not enough to avoid the ORM datasource lookup, I'm not sure. >>> >>> On 11/12/2012 01:43 PM, Scott Marlow wrote: Hardy pointed me to https://github.com/hferentschik/ogm-kitchensink/blob/master/.openshift/config/modules/org/hibernate/ogm/module.xml which duplicates some other AS modules jars in the OGM module. That is going to be specific to which version of AS is being targeted (IMO) and not something I recommend that we depend on. On 11/12/2012 12:46 PM, Emmanuel Bernard wrote: > Hum, yes make sure to check the pom. There has been a few changes to > some superclasses we extend. I did some changes in master for that. I was able to build OGM master against ORM 4.1.6 without getting build errors. > > Emmanuel > > On Mon 2012-11-12 12:00, Scott Marlow wrote: >> Does it matter which version of Hibernate ORM is used (4.1.6 is what >> we are currently using on AS master branch)? >> >> Which version of OGM should I try to use? Previously, I built OGM > >from git master but I noticed that there is a beta1 available also. >> >> On 11/10/2012 05:41 PM, Scott Marlow wrote: >>> Hi Sanne, >>> >>> I'm not sure why the module names didn't show for ogm/orm. >>> >>> I'll try again with the demo app. >>> >>> Scott >>> >>> >>> Sent from my tardis >>> >>> >>> -Original Message- >>> From: Sanne Grinovero [sa...@hibernate.org] >>> Received: Saturday, 10 Nov 2012, 2:56pm >>> To: Scott Marlow [smar...@redhat.com] >>> CC: Emmanuel Bernard [emman...@hibernate.org]; Hibernate Dev >>> [hibernate-dev@lists.jboss.org] >>> Subject: Re: [hibernate-dev] Documentation on OGM + JBoss AS >>> >>> >>> Hi Scott, >>> we don't have that error when testing on AS 7.1.1 with the >>> kitchensink-ogm demo [1] so I'm confident the error is caused by some >>> difference in the module; indeed I remember it being tricky to put the >>> right things together: I can't test it on 7.2-SNAPSHOT now. >>> >>> We definitely don't specify any datasource in the demo configuration, >>> but a custom module is required. >>> >>> Side question on the stacktrace you posted: why is the version number >>> missing in the stack for Hibernate packages? Do we need to add that in >>> the manifest? >>> >>> Sanne >>> >>> 1 - latest version at https://github.com/hferentschik/ogm-kitchensink >>> >>> On 9 November 2012 20:08, Scott Marlow wrote: On 11/09/2012 11:37 AM, Emmanuel Bernard wrote: > On Fri 2012-11-09 11:15, Scott Marlow wrote: >> On 10/01/2012 11:12 AM, Emmanuel Bernard wrote: >>> On Mon 2012-10-01 10:51, Scott Marlow wrote: I got further yesterday (after removing the ---PlaceHolderDSForOGM--- property from HibernateOgmPersistence). Not sure what the long term change is (perhaps we should only add the ---PlaceHolderDSForOGM--- for the non-container case). >>> >>> That may have changed but this place holder was mandatory to get OGM >>> to start in some environment. >>> At least make sure that these change does not break the SE mode. >>> >> >> People are still hitting the "Caused by: >> org.hibernate.service.jndi.JndiException: Unable to lookup JNDI name >> [---PlaceHolderDSForOGM---]" error. >> >> Since people are still hitting the ---PlaceHolderDSForOGM--- induced >> failure (on AS7), we should create a jira for addressing it. The >> fix could be to only add ---PlaceHolderDSForOGM--- when booting in >> standalone mode but not container. > > The placeholder is there because otherwise, some part of Hibernate > EntityManager's configuration bootstrap complain. > > But this value should never be used because Hibernate OGM has an > integrator that overrides the ConnectionProviderInitiator with a Noop > version. > The fact that Sergio's stacktrace shows >>>
Re: [hibernate-dev] Documentation on OGM + JBoss AS
See below details about OgmIntegrator not overriding ORM ConnectionProviderInitiator. On 11/14/2012 11:09 AM, Steve Ebersole wrote: > Integrator is not working why? > >>> >>> People are still hitting the "Caused by: >>> org.hibernate.service.jndi.JndiException: Unable to lookup >>> JNDI name >>> [---PlaceHolderDSForOGM---]" error. >>> >>> Since people are still hitting the ---PlaceHolderDSForOGM--- >>> induced >>> failure (on AS7), we should create a jira for addressing it. >>> The >>> fix could be to only add ---PlaceHolderDSForOGM--- when >>> booting in >>> standalone mode but not container. >> >> The placeholder is there because otherwise, some part of >> Hibernate >> EntityManager's configuration bootstrap complain. >> >> But this value should never be used because Hibernate OGM has an >> integrator that overrides the ConnectionProviderInitiator with >> a Noop >> version. >> The fact that Sergio's stacktrace shows >> >> Caused by: org.hibernate.service.jndi.JndiException: Unable to >> lookup JNDI name [---PlaceHolderDSForOGM---] >> at >> org.hibernate.service.jndi.internal.JndiServiceImpl.locate(JndiServiceImpl.java:68) >> >> at >> org.hibernate.service.jdbc.connections.internal.DatasourceConnectionProviderImpl.configure(DatasourceConnectionProviderImpl.java:116) >> >> >> is proof to me that the OgmIntegrator is not taken into >> account which >> means that the file >> META-INF/services/org.hibernate.integrator.spi.Integrator >> is not seen by Hibernate ORM when it bootstraps the >> application which >> means that Hibernate OGM's classpath is not visible where it >> should be. > > I tried adding the Hibernate OGM module to the ORM module > classpath and > still get the same error (http://pastie.org/5352457). > >> >> That's why I strongly suspects that this is either a JBoss >> modules bug >> or some misconfiguration of the ogm modules. >> >> We could try and give a better error report, open an issue for >> that but >> at the end of the day, something is broken in the ORM-AS >> integration wrt >> integrator and service discovery. >> >> Emmanuel >> > > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev >>> > > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > >> >> ___ >> hibernate-dev mailing list >> hibernate-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Documentation on OGM + JBoss AS
1. is the one that must be solved because if the integrator is not seen then many other things won't work in Hibernate OGM, we heavily reconfigure components. 2. is not a real problem, it's just that the configuration logic would need to be a bit different but AFAIR that was not trivial to do. I'm happy with the placeholder Is there a way for Hibernate OGM to detect that the integrator has not been seen so that we can raise a clearer exception? I don't think so but we can open a JIRA to investigate further. On Wed 2012-11-14 11:05, Scott Marlow wrote: > Which failure do we want to address? > > 1. The integrator approach is not helping when using OGM/ORM on AS7. > > 2. The earlier failure that I haven't yet seen when the place > holder is removed and we bootstrap with > HibernateOgmPersistence.createContainerEntityManagerFactory(). > > Something else? > > On 11/13/2012 09:20 AM, Emmanuel Bernard wrote: > >If you remove the place holder it will fail as well. Earlier actually, > >so no. > >On Tue 2012-11-13 8:20, Scott Marlow wrote: > >>Let me know if you want me to try changing the OGM code that sets > >>"---PlaceHolderDSForOGM---" to only set the datasource if its not > >>already specified. > >> > >>For resolving why the OGM integrator being on the ORM classpath, is > >>not enough to avoid the ORM datasource lookup, I'm not sure. > >> > >>On 11/12/2012 01:43 PM, Scott Marlow wrote: > >>>Hardy pointed me to > >>>https://github.com/hferentschik/ogm-kitchensink/blob/master/.openshift/config/modules/org/hibernate/ogm/module.xml > >>>which duplicates some other AS modules jars in the OGM module. That is > >>>going to be specific to which version of AS is being targeted (IMO) and > >>>not something I recommend that we depend on. > >>> > >>>On 11/12/2012 12:46 PM, Emmanuel Bernard wrote: > Hum, yes make sure to check the pom. There has been a few changes to > some superclasses we extend. I did some changes in master for that. > >>> > >>>I was able to build OGM master against ORM 4.1.6 without getting build > >>>errors. > >>> > > Emmanuel > > On Mon 2012-11-12 12:00, Scott Marlow wrote: > >Does it matter which version of Hibernate ORM is used (4.1.6 is what > >we are currently using on AS master branch)? > > > >Which version of OGM should I try to use? Previously, I built OGM > >from git master but I noticed that there is a beta1 available also. > > > >On 11/10/2012 05:41 PM, Scott Marlow wrote: > >>Hi Sanne, > >> > >>I'm not sure why the module names didn't show for ogm/orm. > >> > >>I'll try again with the demo app. > >> > >>Scott > >> > >> > >>Sent from my tardis > >> > >> > >>-Original Message- > >>From: Sanne Grinovero [sa...@hibernate.org] > >>Received: Saturday, 10 Nov 2012, 2:56pm > >>To: Scott Marlow [smar...@redhat.com] > >>CC: Emmanuel Bernard [emman...@hibernate.org]; Hibernate Dev > >>[hibernate-dev@lists.jboss.org] > >>Subject: Re: [hibernate-dev] Documentation on OGM + JBoss AS > >> > >> > >>Hi Scott, > >>we don't have that error when testing on AS 7.1.1 with the > >>kitchensink-ogm demo [1] so I'm confident the error is caused by some > >>difference in the module; indeed I remember it being tricky to put the > >>right things together: I can't test it on 7.2-SNAPSHOT now. > >> > >>We definitely don't specify any datasource in the demo configuration, > >>but a custom module is required. > >> > >>Side question on the stacktrace you posted: why is the version number > >>missing in the stack for Hibernate packages? Do we need to add that in > >>the manifest? > >> > >>Sanne > >> > >>1 - latest version at https://github.com/hferentschik/ogm-kitchensink > >> > >>On 9 November 2012 20:08, Scott Marlow wrote: > >>>On 11/09/2012 11:37 AM, Emmanuel Bernard wrote: > On Fri 2012-11-09 11:15, Scott Marlow wrote: > >On 10/01/2012 11:12 AM, Emmanuel Bernard wrote: > >>On Mon 2012-10-01 10:51, Scott Marlow wrote: > >>>I got further yesterday (after removing the > >>>---PlaceHolderDSForOGM--- property from HibernateOgmPersistence). > >>>Not sure what the long term change is (perhaps we should only add > >>>the ---PlaceHolderDSForOGM--- for the non-container case). > >> > >>That may have changed but this place holder was mandatory to get OGM > >>to start in some environment. > >>At least make sure that these change does not break the SE mode. > >> > > > >People are still hitting the "Caused by: > >org.hibernate.service.jndi.JndiException: Unable to lookup JNDI name > >[---PlaceHolderDSForOGM---]" error. > > > >Since people are still hitting the ---PlaceHolderDSForOGM--- induced > >failure (on AS7), we should create a jira for addressing i
Re: [hibernate-dev] Documentation on OGM + JBoss AS
But that's not what I am asking. I am asking why Integrator is not working here in AS. I assume this is more module classpath bs? On 11/14/2012 10:54 AM, Scott Marlow wrote: > See below details about OgmIntegrator not overriding ORM > ConnectionProviderInitiator. > > On 11/14/2012 11:09 AM, Steve Ebersole wrote: >> Integrator is not working why? -- st...@hibernate.org http://hibernate.org ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
[hibernate-dev] Shards
On https://github.com/hibernate/hibernate-orm/pull/407 Adriano has started work on porting Shards (based on the last release source) to the latest 4.1 code base. Shards really became a dump and run, which is why we did not even bother moving it over from SVN to GitHub when we migrated the other projects. The folks who developed it moved on and none of the development team really know its code. Bottom line, what is really needed is for someone to own that. I asked Adriano on that pull request if that was something he was willing to take on. He said yes. So the question becomes how do we proceed? Do we let him (and anyone else who joins in to help finish the migration) finish the work in his personal repo and move that over to under the Hibernate community when that work is complete? Other suggestions? -- st...@hibernate.org http://hibernate.org ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Documentation on OGM + JBoss AS
I would be guessing if I tried to explain why OgmIntegrator is not working. On 11/14/2012 12:11 PM, Steve Ebersole wrote: > But that's not what I am asking. I am asking why Integrator is not > working here in AS. I assume this is more module classpath bs? > > On 11/14/2012 10:54 AM, Scott Marlow wrote: >> See below details about OgmIntegrator not overriding ORM >> ConnectionProviderInitiator. >> >> On 11/14/2012 11:09 AM, Steve Ebersole wrote: >>> Integrator is not working why? > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Documentation on OGM + JBoss AS
Well is it not working or is it not being seen? Remember that Hibernate tries to find these Integrators based on the ClassLoader you hand it... On Wed 14 Nov 2012 11:33:30 AM CST, Scott Marlow wrote: > I would be guessing if I tried to explain why OgmIntegrator is not > working. > > On 11/14/2012 12:11 PM, Steve Ebersole wrote: >> But that's not what I am asking. I am asking why Integrator is not >> working here in AS. I assume this is more module classpath bs? >> >> On 11/14/2012 10:54 AM, Scott Marlow wrote: >>> See below details about OgmIntegrator not overriding ORM >>> ConnectionProviderInitiator. >>> >>> On 11/14/2012 11:09 AM, Steve Ebersole wrote: Integrator is not working why? >> > -- st...@hibernate.org http://hibernate.org ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Documentation on OGM + JBoss AS
If its a classloader issue. I'll post the corrected classpath definitions online. OGM was on the Hibernate classloader but I might of missed the "services=import" part... I'll give it another try. On 11/14/2012 12:36 PM, Steve Ebersole wrote: > Well is it not working or is it not being seen? Remember that Hibernate > tries to find these Integrators based on the ClassLoader you hand it... > > On Wed 14 Nov 2012 11:33:30 AM CST, Scott Marlow wrote: >> I would be guessing if I tried to explain why OgmIntegrator is not >> working. >> >> On 11/14/2012 12:11 PM, Steve Ebersole wrote: >>> But that's not what I am asking. I am asking why Integrator is not >>> working here in AS. I assume this is more module classpath bs? >>> >>> On 11/14/2012 10:54 AM, Scott Marlow wrote: See below details about OgmIntegrator not overriding ORM ConnectionProviderInitiator. On 11/14/2012 11:09 AM, Steve Ebersole wrote: > Integrator is not working why? >>> >> > > -- > st...@hibernate.org > http://hibernate.org ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Documentation on OGM + JBoss AS
You are speaking Chinese to me ;) I don't know what the distinction there means. What is "services=import"? Hibernate does a *highly* specialized form of java.util.ServiceLoader lookup, if thats what "services" there is supposed to mean. On Wed 14 Nov 2012 11:45:01 AM CST, Scott Marlow wrote: > If its a classloader issue. I'll post the corrected classpath > definitions online. OGM was on the Hibernate classloader but I might > of missed the "services=import" part... > > I'll give it another try. > > On 11/14/2012 12:36 PM, Steve Ebersole wrote: >> Well is it not working or is it not being seen? Remember that Hibernate >> tries to find these Integrators based on the ClassLoader you hand it... >> >> On Wed 14 Nov 2012 11:33:30 AM CST, Scott Marlow wrote: >>> I would be guessing if I tried to explain why OgmIntegrator is not >>> working. >>> >>> On 11/14/2012 12:11 PM, Steve Ebersole wrote: But that's not what I am asking. I am asking why Integrator is not working here in AS. I assume this is more module classpath bs? On 11/14/2012 10:54 AM, Scott Marlow wrote: > See below details about OgmIntegrator not overriding ORM > ConnectionProviderInitiator. > > On 11/14/2012 11:09 AM, Steve Ebersole wrote: >> Integrator is not working why? >>> >> >> -- >> st...@hibernate.org >> http://hibernate.org > -- st...@hibernate.org http://hibernate.org ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Where are the batched fetch statements generated?
Hi Steve, Sorry I missed the original series of emails, as unbelieveable as it sounds, gmail was acting strange recently... Ok, this is pushed to master. All 3 styles are implemented. See > issue for details. > > On Thu, Nov 1, 2012 at 2:43 PM, Steve Ebersole > wrote: > > fwiw... I have a lot of this implemented locally. At the moment it is > > "swappable", but I have not yet exposed this as a setting. Also, I only > > have (1) and (2) implemented. (2) is implemented by padding with the > main > > identifier that triggered the batch load. > > > > Plan is to work on (3) tomorrow, if I do not get to it today. > This is really great news, it actually allows me to drop my hacked version of hibernate-3.6 and finally update to 4.x. I guess dynamically generating the statement is what I am really looking for. I'll give it a try soon, thanks again =) - Clemens ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Documentation on OGM + JBoss AS
On 11/14/2012 12:01 PM, Emmanuel Bernard wrote: > 1. is the one that must be solved because if the integrator is not seen > then many other things won't work in Hibernate OGM, we heavily > reconfigure components. Okay, good to know that this is what we need to fix. I'll try again to get this to work by changing the OGM/ORM module definitions. I might of missed the "services=import" part in my last attempt. > > 2. is not a real problem, it's just that the configuration logic would > need to be a bit different but AFAIR that was not trivial to do. > I'm happy with the placeholder > > Is there a way for Hibernate OGM to detect that the integrator has not > been seen so that we can raise a clearer exception? I don't think so but > we can open a JIRA to investigate further. > > On Wed 2012-11-14 11:05, Scott Marlow wrote: >> Which failure do we want to address? >> >> 1. The integrator approach is not helping when using OGM/ORM on AS7. >> >> 2. The earlier failure that I haven't yet seen when the place >> holder is removed and we bootstrap with >> HibernateOgmPersistence.createContainerEntityManagerFactory(). >> >> Something else? >> >> On 11/13/2012 09:20 AM, Emmanuel Bernard wrote: >>> If you remove the place holder it will fail as well. Earlier actually, >>> so no. >>> On Tue 2012-11-13 8:20, Scott Marlow wrote: Let me know if you want me to try changing the OGM code that sets "---PlaceHolderDSForOGM---" to only set the datasource if its not already specified. For resolving why the OGM integrator being on the ORM classpath, is not enough to avoid the ORM datasource lookup, I'm not sure. On 11/12/2012 01:43 PM, Scott Marlow wrote: > Hardy pointed me to > https://github.com/hferentschik/ogm-kitchensink/blob/master/.openshift/config/modules/org/hibernate/ogm/module.xml > which duplicates some other AS modules jars in the OGM module. That is > going to be specific to which version of AS is being targeted (IMO) and > not something I recommend that we depend on. > > On 11/12/2012 12:46 PM, Emmanuel Bernard wrote: >> Hum, yes make sure to check the pom. There has been a few changes to >> some superclasses we extend. I did some changes in master for that. > > I was able to build OGM master against ORM 4.1.6 without getting build > errors. > >> >> Emmanuel >> >> On Mon 2012-11-12 12:00, Scott Marlow wrote: >>> Does it matter which version of Hibernate ORM is used (4.1.6 is what >>> we are currently using on AS master branch)? >>> >>> Which version of OGM should I try to use? Previously, I built OGM >> >from git master but I noticed that there is a beta1 available also. >>> >>> On 11/10/2012 05:41 PM, Scott Marlow wrote: Hi Sanne, I'm not sure why the module names didn't show for ogm/orm. I'll try again with the demo app. Scott Sent from my tardis -Original Message- From: Sanne Grinovero [sa...@hibernate.org] Received: Saturday, 10 Nov 2012, 2:56pm To: Scott Marlow [smar...@redhat.com] CC: Emmanuel Bernard [emman...@hibernate.org]; Hibernate Dev [hibernate-dev@lists.jboss.org] Subject: Re: [hibernate-dev] Documentation on OGM + JBoss AS Hi Scott, we don't have that error when testing on AS 7.1.1 with the kitchensink-ogm demo [1] so I'm confident the error is caused by some difference in the module; indeed I remember it being tricky to put the right things together: I can't test it on 7.2-SNAPSHOT now. We definitely don't specify any datasource in the demo configuration, but a custom module is required. Side question on the stacktrace you posted: why is the version number missing in the stack for Hibernate packages? Do we need to add that in the manifest? Sanne 1 - latest version at https://github.com/hferentschik/ogm-kitchensink On 9 November 2012 20:08, Scott Marlow wrote: > On 11/09/2012 11:37 AM, Emmanuel Bernard wrote: >> On Fri 2012-11-09 11:15, Scott Marlow wrote: >>> On 10/01/2012 11:12 AM, Emmanuel Bernard wrote: On Mon 2012-10-01 10:51, Scott Marlow wrote: > I got further yesterday (after removing the > ---PlaceHolderDSForOGM--- property from HibernateOgmPersistence). > Not sure what the long term change is (perhaps we should only add > the ---PlaceHolderDSForOGM--- for the non-container case). That may have changed but this place holder was mandatory to get OGM to start in some environment. At least make sure that these change does not break the SE mode.
[hibernate-dev] GitHub CONTRIBUTING(.md)
Interesting new GitHub feature : https://github.com/blog/1184-contributing-guidelines -- st...@hibernate.org http://hibernate.org ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Documentation on OGM + JBoss AS
Adding the "services=import" to the Hibernate ORM module helped us get further. We are making it to org.hibernate.ogm.persister.OgmEntityPersister but get stuck on Infnispan 5.2.x not liking org/hibernate/ogm/datastore/infinispan/default-config.xml. http://pastie.org/5378295 is from AS master which includes Infinispan 5.2.x. I added my module definitions here https://docs.jboss.org/author/display/AS72/JPA+Reference+Guide#JPAReferenceGuide-UsingHibernateOGM On 11/14/2012 12:42 PM, Scott Marlow wrote: > On 11/14/2012 12:01 PM, Emmanuel Bernard wrote: >> 1. is the one that must be solved because if the integrator is not seen >> then many other things won't work in Hibernate OGM, we heavily >> reconfigure components. > > Okay, good to know that this is what we need to fix. I'll try again to > get this to work by changing the OGM/ORM module definitions. I might of > missed the "services=import" part in my last attempt. > >> >> 2. is not a real problem, it's just that the configuration logic would >> need to be a bit different but AFAIR that was not trivial to do. >> I'm happy with the placeholder >> >> Is there a way for Hibernate OGM to detect that the integrator has not >> been seen so that we can raise a clearer exception? I don't think so but >> we can open a JIRA to investigate further. >> >> On Wed 2012-11-14 11:05, Scott Marlow wrote: >>> Which failure do we want to address? >>> >>> 1. The integrator approach is not helping when using OGM/ORM on AS7. >>> >>> 2. The earlier failure that I haven't yet seen when the place >>> holder is removed and we bootstrap with >>> HibernateOgmPersistence.createContainerEntityManagerFactory(). >>> >>> Something else? >>> >>> On 11/13/2012 09:20 AM, Emmanuel Bernard wrote: If you remove the place holder it will fail as well. Earlier actually, so no. On Tue 2012-11-13 8:20, Scott Marlow wrote: > Let me know if you want me to try changing the OGM code that sets > "---PlaceHolderDSForOGM---" to only set the datasource if its not > already specified. > > For resolving why the OGM integrator being on the ORM classpath, is > not enough to avoid the ORM datasource lookup, I'm not sure. > > On 11/12/2012 01:43 PM, Scott Marlow wrote: >> Hardy pointed me to >> https://github.com/hferentschik/ogm-kitchensink/blob/master/.openshift/config/modules/org/hibernate/ogm/module.xml >> which duplicates some other AS modules jars in the OGM module. That is >> going to be specific to which version of AS is being targeted (IMO) and >> not something I recommend that we depend on. >> >> On 11/12/2012 12:46 PM, Emmanuel Bernard wrote: >>> Hum, yes make sure to check the pom. There has been a few changes to >>> some superclasses we extend. I did some changes in master for that. >> >> I was able to build OGM master against ORM 4.1.6 without getting build >> errors. >> >>> >>> Emmanuel >>> >>> On Mon 2012-11-12 12:00, Scott Marlow wrote: Does it matter which version of Hibernate ORM is used (4.1.6 is what we are currently using on AS master branch)? Which version of OGM should I try to use? Previously, I built OGM >>> >from git master but I noticed that there is a beta1 available also. On 11/10/2012 05:41 PM, Scott Marlow wrote: > Hi Sanne, > > I'm not sure why the module names didn't show for ogm/orm. > > I'll try again with the demo app. > > Scott > > > Sent from my tardis > > > -Original Message- > From: Sanne Grinovero [sa...@hibernate.org] > Received: Saturday, 10 Nov 2012, 2:56pm > To: Scott Marlow [smar...@redhat.com] > CC: Emmanuel Bernard [emman...@hibernate.org]; Hibernate Dev > [hibernate-dev@lists.jboss.org] > Subject: Re: [hibernate-dev] Documentation on OGM + JBoss AS > > > Hi Scott, > we don't have that error when testing on AS 7.1.1 with the > kitchensink-ogm demo [1] so I'm confident the error is caused by some > difference in the module; indeed I remember it being tricky to put the > right things together: I can't test it on 7.2-SNAPSHOT now. > > We definitely don't specify any datasource in the demo configuration, > but a custom module is required. > > Side question on the stacktrace you posted: why is the version number > missing in the stack for Hibernate packages? Do we need to add that in > the manifest? > > Sanne > > 1 - latest version at https://github.com/hferentschik/ogm-kitchensink > > On 9 November 2012 20:08, Scott Marlow wrote: >> On 11/09/2012 11:37 AM, Emmanuel Bernard wrote: >>> On Fri 2012-11-09 11:15, Scott Marlow wrote: On 10/01/201
Re: [hibernate-dev] GitHub CONTRIBUTING(.md)
Nice. We should add this file to our repos. On 14 Nov 2012, at 19:26, Steve Ebersole wrote: > Interesting new GitHub feature : > https://github.com/blog/1184-contributing-guidelines > > -- > st...@hibernate.org > http://hibernate.org > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] GitHub CONTRIBUTING(.md)
Way ahead of you : https://github.com/hibernate/hibernate-orm/blob/master/CONTRIBUTING.md :) On Wed 14 Nov 2012 01:10:53 PM CST, Hardy Ferentschik wrote: > Nice. We should add this file to our repos. > > > > On 14 Nov 2012, at 19:26, Steve Ebersole wrote: > >> Interesting new GitHub feature : >> https://github.com/blog/1184-contributing-guidelines >> >> -- >> st...@hibernate.org >> http://hibernate.org >> ___ >> hibernate-dev mailing list >> hibernate-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev -- st...@hibernate.org http://hibernate.org ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] GitHub CONTRIBUTING(.md)
Cool :) Hardy, for HV we have https://community.jboss.org/wiki/ContributingToHibernateValidator. Do you want move/copy that completely to CONTRIBUTING.md or only the points most relevant for doing pull requests? Am 14.11.2012 20:43 schrieb "Steve Ebersole" : > Way ahead of you : > https://github.com/hibernate/hibernate-orm/blob/master/CONTRIBUTING.md > > :) > > On Wed 14 Nov 2012 01:10:53 PM CST, Hardy Ferentschik wrote: > > Nice. We should add this file to our repos. > > > > > > > > On 14 Nov 2012, at 19:26, Steve Ebersole wrote: > > > >> Interesting new GitHub feature : > >> https://github.com/blog/1184-contributing-guidelines > >> > >> -- > >> st...@hibernate.org > >> http://hibernate.org > >> ___ > >> hibernate-dev mailing list > >> hibernate-dev@lists.jboss.org > >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > > -- > st...@hibernate.org > http://hibernate.org > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Where are the batched fetch statements generated?
Cool. Let me know how it goes On Nov 14, 2012 12:07 PM, "Clemens Eisserer" wrote: > Hi Steve, > > Sorry I missed the original series of emails, as unbelieveable as it > sounds, gmail was acting strange recently... > > Ok, this is pushed to master. All 3 styles are implemented. See >> issue for details. >> >> On Thu, Nov 1, 2012 at 2:43 PM, Steve Ebersole >> wrote: >> > fwiw... I have a lot of this implemented locally. At the moment it is >> > "swappable", but I have not yet exposed this as a setting. Also, I only >> > have (1) and (2) implemented. (2) is implemented by padding with the >> main >> > identifier that triggered the batch load. >> > >> > Plan is to work on (3) tomorrow, if I do not get to it today. >> > > This is really great news, it actually allows me to drop my hacked version > of hibernate-3.6 and finally update to 4.x. > I guess dynamically generating the statement is what I am really looking > for. > > I'll give it a try soon, thanks again =) > > - Clemens > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
