Regarding the project explosion part, we don't have a strong need to have a
separate "module packaging" solution. Creating module packages in the OGM
project sounds like a good way.
Having said that, I still want to continue adding persistence provider specific
integration code to the AS project and find a good home for that code.
Sent from my tardis
-Original Message-
From: Emmanuel Bernard [emman...@hibernate.org]
Received: Friday, 05 Oct 2012, 6:38pm
To: Scott Marlow [smar...@redhat.com]
CC: Sanne Grinovero [sa...@hibernate.org]; Hibernate Dev
[hibernate-dev@lists.jboss.org]
Subject: Re: [hibernate-dev] Documentation on OGM + JBoss AS
If that does not slow down the test suite significantly, I'd favor a module to
limit project explosion.
On 5 oct. 2012, at 06:56, Scott Marlow wrote:
> On 10/05/2012 06:16 AM, Sanne Grinovero wrote:
>> Thanks Scott, that documentation arrived just in time:
>> https://forum.hibernate.org/viewtopic.php?f=31&t=1024476
>>
>> It looks like we could simplify things by creating an AS7 module, and
>> release it in tandem with an OGM release.
>>
>> What could be the best way to distribute this module?
>
> A few different ways that we could proceed. In the OGM project, we could
> assemble an AS7 module that is ready to drop into the AS7 root folder. This
> wouldn't include the OGM integration code module (which we haven't needed to
> write but could to make it easier to use OGM with AS7).
>
> Another way, would be to start a new project that packages the OGM provider
> into a ready to use AS7 module. We could also package the OGM integration
> code (persistence provider adapter) in this new project.
>
>>
>> Is there a "clean" way to create one? (by "clean" I mean possibly not
>> relying on the Maven assembly plugin, and more importantly making
>> something which can be tested in automation)
>
> If we create a new project for this, I'm open to suggestions for how to
> create the module from within the project (whether its with Maven, Ant, Ivy
> or something else).
>
>>
>> Sanne
>>
>>
>> On 1 October 2012 23:21, Sanne Grinovero wrote:
>>> You don't have to build it but having it in the cache woud help :)
>>>
>>> The test is building and materializing an AS7 module on the filesystem
>>> containing all dependencies, including Hibernate Search (among others)
>>> and uses ShrinkWrap to do that; if you look in the test you should
>>> find a line which forces it to stay offline (as it was massively slow
>>> otherwise), you should comment that line at least once so that it
>>> downloads all what it needs.
>>>
>>> On 1 October 2012 19:39, Scott Marlow wrote:
On 10/01/2012 12:23 PM, Sanne Grinovero wrote:
>
> On 1 October 2012 17:08, Scott Marlow wrote:
>>
>> On 10/01/2012 11:05 AM, Sanne Grinovero wrote:
>>>
>>>
>>> On 1 October 2012 15:51, Scott Marlow wrote:
I got further yesterday (after removing the ---PlaceHolderDSForOGM---
property from HibernateOgmPersistence). Not sure what the long term
change is (perhaps we should only add the ---PlaceHolderDSForOGM--- for
the non-container case).
>>>
>>>
>>>
>>> Nice. Is the AS still "mandating" a specific module name and injecting
>>> Hibernate 3?
>>
>>
>>
>> The OGM module name should be org.hibernate:ogm. The org.hibernate:ogm
>> module should depend on Hibernate 4 (org.hibernate:main) and Hibernate 4
>> should depend on OGM.
>
>
> I'm still not understanding why we need to hardcode a constant module
> name for the OGM provider, that's unintuitive and brought me a lot of
> pain when trying to use a *different* version, when recently trying
> out your instructions.
>
> I might want to deploy OGM using a different version of Hibernate ORM
> than what I have in another OGM-using application; also it is very
> likely that soon OGM will require a version which is not the one
> bundled in the AS.
>
> I would expect the module to be something I can configure in my own
> application:
>
>
> https://github.com/Sanne/ogm-kitchensink/blob/as711/src/main/webapp/WEB-INF/jboss-deployment-structure.xml
>
> it should be possible to use a different module name, how could I deal
> with multiple deployments otherwise? The AS should not mandate the
> module dependency, at best it could take some hint like you do with
> the _jboss.as.jpa.adapterModule_ property
>
>
> https://github.com/Sanne/ogm-kitchensink/blob/as711/.openshift/config/modules/org/hibernate/ogm/module.xml
>
> I didn't need any datasource, this worked fine:
>
> https://github.com/Sanne/ogm-kitchensink/blob/as711/src/main/resources/META-INF/persistence.xml
I tried building https://github.com/Sanne/ogm-kitchensink (as711 branch)
locally but got an error:
>
